tweetwine 0.4.2 → 0.4.3

data/test/support/common_helpers.rb

@@ -0,0 +1,43 @@
+# coding: utf-8
+
+module Tweetwine::Test
+  module CommonHelpers
+    FIXTURE_DIR = File.join File.dirname(__FILE__), '..', 'fixture'
+
+    def file_mode(file)
+      File.stat(file).mode & 0777
+    end
+
+    def fixture_path(filename)
+      File.join FIXTURE_DIR, filename
+    end
+
+    def fixture_file(filename)
+      File.open(fixture_path(filename)) do |f|
+        f.readlines.join("\n")
+      end
+    end
+
+    def tmp_env(vars = {})
+      originals = {}
+      vars.each_pair do |key, value|
+        key = key.to_s
+        originals[key] = ENV[key]
+        ENV[key] = value
+      end
+      yield
+    ensure
+      originals.each_pair do |key, value|
+        ENV[key] = value
+      end
+    end
+
+    def tmp_kcode(val)
+      original = $KCODE
+      $KCODE = val
+      yield
+    ensure
+      $KCODE = original
+    end
+  end
+end

data/test/support/doubles.rb

@@ -0,0 +1,35 @@
+# coding: utf-8
+
+module Tweetwine::Test
+  module Doubles
+    def mock_config
+      @config = mock('Config')
+      Tweetwine::CLI.stubs(:config).returns(@config)
+    end
+
+    def mock_http
+      @http = mock('Http')
+      Tweetwine::CLI.stubs(:http).returns(@http)
+    end
+
+    def mock_oauth
+      @oauth = mock('OAuth')
+      Tweetwine::CLI.stubs(:oauth).returns(@oauth)
+    end
+
+    def mock_ui
+      @ui = mock('UI')
+      Tweetwine::CLI.stubs(:ui).returns(@ui)
+    end
+
+    def mock_url_shortener
+      @url_shortener = mock('UrlShortener')
+      Tweetwine::CLI.stubs(:url_shortener).returns(@url_shortener)
+    end
+
+    def stub_config(options = {})
+      @config = options
+      Tweetwine::CLI.stubs(:config).returns(@config)
+    end
+  end
+end

data/test/{integration/helper.rb → support/integration_test_case.rb}

@@ -7,15 +7,16 @@
   tempfile
   time
   timecop
+  support/common
+  support/common_helpers
+  support/webmock_integration
 }.each { |lib| require lib }
 
-require 'helper'
-
 module Tweetwine::Test
   module Integration
-    module Helper
-      include Tweetwine::Test::CommonHelper
-      extend Tweetwine::Test::CommonHelper
+    module Helpers
+      include CommonHelpers
+      extend CommonHelpers
 
       SNAPSHOT_CREATED_AT = Time.parse "2009-10-14 01:56:15 +0300"
 
@@ -62,9 +63,13 @@ module Tweetwine::Test
 
     class TestCase < MiniTest::Spec
       include WebMockIntegration
+
+      include Helpers
+      extend Helpers
+
+      # Shorten writing tests a bit by making our main namespace available in
+      # the test case.
       include Tweetwine
-      include Helper
-      extend Helper
     end
   end
 end

data/test/support/mocha_integration.rb

@@ -0,0 +1,16 @@
+# coding: utf-8
+
+require 'mocha_standalone'
+
+module Tweetwine::Test
+  module MochaIntegration
+    include Mocha::API
+
+    def teardown
+      mocha_teardown
+      super
+    end
+  end
+end
+
+Mocha::Configuration.prevent :stubbing_non_existent_method

data/test/support/tweets.rb

@@ -0,0 +1,95 @@
+# coding: utf-8
+
+require 'timecop'
+
+module Tweetwine::Test
+  module Tweets
+    FIELD_PATHS = {
+      :from_user  => %w{screen_name},
+      :to_user    => %w{status in_reply_to_screen_name},
+      :retweet    => %w{retweeted_status},
+      :created_at => %w{status created_at},
+      :status     => %w{status text}
+    }.freeze
+
+    DEFAULT_TIMESTAMP = Time.utc(2011, 'feb', 17, 22, 28, 0)
+
+    DEFAULT_FIELD_VALUES = {
+      :from_user  => 'fred',
+      :to_user    => nil,
+      :retweet    => nil,
+      :created_at => DEFAULT_TIMESTAMP.iso8601,
+      :status     => nil
+    }.freeze
+
+    RECORD_SKELETON = {
+      'screen_name'       => nil,
+      'retweeted_status'  => nil,
+      'status'            => {
+        'in_reply_to_screen_name' => nil,
+        'created_at'              => nil,
+        'text'                    => nil
+      }.freeze
+    }.freeze
+
+    def create_record(fields = {})
+      record = Tweets.create_nonrt_record(Tweets.nonrt_fields(fields))
+      Tweets.modify_to_rt_record(record, fields[:rt_user]) if fields[:rt_user]
+      record
+    end
+
+    def create_tweet(fields = {})
+      Tweetwine::Tweet.new(create_record(fields), FIELD_PATHS)
+    end
+
+    def at_default_time(&block)
+      Timecop.freeze(DEFAULT_TIMESTAMP, &block)
+    end
+
+    def create_timestamp(minus_seconds)
+      (DEFAULT_TIMESTAMP - minus_seconds).iso8601
+    end
+
+    class << self
+      def nonrt_fields(fields)
+        DEFAULT_FIELD_VALUES.merge(fields.reject { |(k, v)| k == :rt_user })
+      end
+
+      def create_nonrt_record(fields)
+        FIELD_PATHS.inject(deep_copy(RECORD_SKELETON)) do |result, (path_name, path_actual)|
+          hash, field = find_hash_of_field_path(result, path_actual)
+          hash[field] = fields[path_name]
+          result
+        end
+      end
+
+      def modify_to_rt_record(record, rt_user)
+        rt_hash, rt_field = find_hash_of_field_path(record, FIELD_PATHS[:retweet])
+        fr_hash, fr_field = find_hash_of_field_path(record, FIELD_PATHS[:from_user])
+        st_hash, st_field = find_hash_of_field_path(record, FIELD_PATHS[:status])
+        rt_hash[rt_field] = {
+          fr_field => fr_hash[fr_field].dup,
+          'status' => st_hash.dup
+        }
+        fr_hash[fr_field] = rt_user
+        st_hash[st_field] = 'retweeted status text. you should not see me.'
+        cr_hash, cr_field = find_hash_of_field_path(record, FIELD_PATHS[:created_at])
+        cr_hash[cr_field] = 'old created timestamp. you should not see me.'
+      end
+
+      def find_hash_of_field_path(hash, path)
+        path = [path] unless path.is_a? Array
+        if path.size > 1
+          hash_path, field = path[0..-2], path.last
+          [Tweetwine::Support.find_hash_path(hash, hash_path), field]
+        else
+          [hash, path.first]
+        end
+      end
+
+      def deep_copy(obj)
+        Marshal.load(Marshal.dump(obj))
+      end
+    end
+  end
+end

data/test/support/unit_test_case.rb

@@ -0,0 +1,28 @@
+# coding: utf-8
+
+%w{
+  support/common
+  support/common_helpers
+  support/assertions
+  support/doubles
+  support/mocha_integration
+  support/webmock_integration
+}.each { |lib| require lib }
+
+module Tweetwine::Test
+  module Unit
+    class TestCase < MiniTest::Spec
+      include MochaIntegration
+      include WebMockIntegration
+
+      include Assertions
+      include Doubles
+      include CommonHelpers
+      extend CommonHelpers
+
+      # Shorten writing tests a bit by making our main namespace available in
+      # the test case.
+      include Tweetwine
+    end
+  end
+end

data/test/support/webmock_integration.rb

@@ -0,0 +1,16 @@
+# coding: utf-8
+
+require 'webmock'
+
+module Tweetwine::Test
+  module WebMockIntegration
+    include WebMock::API
+
+    def teardown
+      WebMock.reset!
+      super
+    end
+  end
+end
+
+WebMock.disable_net_connect!

data/test/unit/character_encoding_test.rb

@@ -1,6 +1,6 @@
 # coding: utf-8
 
-require 'unit/helper'
+require 'support/unit_test_case'
 
 module Tweetwine::Test::Unit
 

data/test/unit/cli_test.rb

@@ -1,6 +1,6 @@
 # coding: utf-8
 
-require 'unit/helper'
+require 'support/unit_test_case'
 require 'stringio'
 
 module Tweetwine::Test::Unit
@@ -9,13 +9,13 @@ module Tweetwine::Test::Unit
 class CLITest < TestCase
   describe "for initialization" do
     it "disallows using #new to create a new instance" do
-      assert_raises(NoMethodError) { CLI.new }
+      assert_raises(NoMethodError) { Tweetwine::CLI.new }
     end
 
     it "allows defining same option multiple times, last value winning" do
       winning_option_value = 'second'
       start_cli %W{-f first -f #{winning_option_value} -v}
-      assert_equal winning_option_value, CLI.config[:config_file]
+      assert_equal winning_option_value, Tweetwine::CLI.config[:config_file]
     end
   end
 
@@ -23,7 +23,7 @@ class CLITest < TestCase
 
   def start_cli(args)
     output = StringIO.new
-    CLI.start(args, { :out => output })
+    Tweetwine::CLI.start(args, { :out => output })
     output.string.split("\n")
   end
 end

data/test/unit/config_test.rb

@@ -1,6 +1,6 @@
 # coding: utf-8
 
-require 'unit/helper'
+require 'support/unit_test_case'
 require 'fileutils'
 require 'tempfile'
 require 'yaml'

data/test/unit/http_test.rb

@@ -1,6 +1,6 @@
 # coding: utf-8
 
-require 'unit/helper'
+require 'support/unit_test_case'
 
 module Tweetwine::Test::Unit
 

data/test/unit/oauth_test.rb

@@ -1,6 +1,6 @@
 # coding: utf-8
 
-require 'unit/helper'
+require 'support/unit_test_case'
 require 'fixture/oauth'
 require 'net/http'
 

data/test/unit/obfuscate_test.rb

@@ -1,6 +1,6 @@
 # coding: utf-8
 
-require 'unit/helper'
+require 'support/unit_test_case'
 
 module Tweetwine::Test::Unit
 

data/test/unit/option_parser_test.rb

@@ -1,6 +1,6 @@
 # coding: utf-8
 
-require 'unit/helper'
+require 'support/unit_test_case'
 
 module Tweetwine::Test::Unit
 

data/test/unit/promise_test.rb

@@ -1,6 +1,6 @@
 # coding: utf-8
 
-require 'unit/helper'
+require 'support/unit_test_case'
 
 module Tweetwine::Test::Unit
 

data/test/unit/support_test.rb

@@ -1,6 +1,6 @@
 # coding: utf-8
 
-require 'unit/helper'
+require 'support/unit_test_case'
 require 'time'
 
 module Tweetwine::Test::Unit

data/test/unit/tweet_test.rb

@@ -1,12 +1,12 @@
 # coding: utf-8
 
-require 'unit/helper'
-require 'unit/tweet_helper'
+require 'support/unit_test_case'
+require 'support/tweets'
 
 module Tweetwine::Test::Unit
 
 class TweetTest < TestCase
-  include TweetHelper
+  include Test::Tweets
 
   describe "for initialization" do
     it "raises exception if from user field is not found" do

data/test/unit/twitter_test.rb

@@ -1,10 +1,10 @@
 # coding: utf-8
 
-require 'unit/helper'
+require 'support/unit_test_case'
 
 module Tweetwine::Test::Unit
 
-class ClientTest < TestCase
+class TwitterTest < TestCase
   before do
     @config = {
       :num_tweets => 20,
@@ -383,31 +383,6 @@ class ClientTest < TestCase
         @twitter.update(long_status)
       end
 
-      it "discards obviously invalid shortened URLs, using originals instead" do
-        long_urls = ["http://www.google.fi/", "http://www.w3.org/TR/1999/REC-xpath-19991116"]
-        status = long_urls.join(" and ")
-        short_urls = [nil, ""]
-        twitter_records, internal_records = create_rest_api_status_records({
-          :from_user  => @username,
-          :status     => status
-        })
-        @oauth.expects(:request_signer)
-        http_subresource = mock
-        http_subresource.expects(:post).
-          with({ :status => status }).
-          returns(twitter_records[0].to_json)
-        @rest_api.expects(:[]).
-          with("statuses/update.json").
-          returns(http_subresource)
-        @url_shortener.expects(:shorten).with(long_urls.first).returns(short_urls.first)
-        @url_shortener.expects(:shorten).with(long_urls.last).returns(short_urls.last)
-        @ui.expects(:show_status_preview).with(status)
-        @ui.expects(:confirm).with("Really send?").returns(true)
-        @ui.expects(:info).with("Sent status update.\n\n")
-        @ui.expects(:show_tweets).with(internal_records)
-        @twitter.update(status)
-      end
-
       it "reuses a shortened URL for duplicate long URLs" do
         long_urls = ["http://www.w3.org/TR/1999/REC-xpath-19991116"] * 2
         long_status = long_urls.join(" and ")
@@ -443,6 +418,33 @@ class ClientTest < TestCase
           })
         end
 
+        it "warns if URLs returned from shortening service are not shortened, using originals instead" do
+          long_urls = ["http://www.google.fi/", "http://www.w3.org/TR/1999/REC-xpath-19991116"]
+          status = long_urls.join(" and ")
+          short_urls = [long_urls.first, ""]
+          twitter_records, internal_records = create_rest_api_status_records({
+            :from_user  => @username,
+            :status     => status
+          })
+          @oauth.expects(:request_signer)
+          http_subresource = mock
+          http_subresource.expects(:post).
+            with({ :status => status }).
+            returns(twitter_records[0].to_json)
+          @rest_api.expects(:[]).
+            with("statuses/update.json").
+            returns(http_subresource)
+          @url_shortener.expects(:shorten).with(long_urls.first).returns(short_urls.first)
+          @url_shortener.expects(:shorten).with(long_urls.last).returns(short_urls.last)
+          @ui.expects(:warn).with("No short URL for #{long_urls.first}")
+          @ui.expects(:warn).with("No short URL for #{long_urls.last}")
+          @ui.expects(:show_status_preview).with(status)
+          @ui.expects(:confirm).with("Really send?").returns(true)
+          @ui.expects(:info).with("Sent status update.\n\n")
+          @ui.expects(:show_tweets).with(internal_records)
+          @twitter.update(status)
+        end
+
         it "skips shortening URLs if required libraries are not found" do
           Tweetwine::CLI.stubs(:url_shortener).raises(LoadError, 'gem not found')
           @oauth.expects(:request_signer)

data/test/unit/ui_test.rb

@@ -1,12 +1,12 @@
 # coding: utf-8
 
-require 'unit/helper'
-require 'unit/tweet_helper'
+require 'support/unit_test_case'
+require 'support/tweets'
 
 module Tweetwine::Test::Unit
 
 class UITest < TestCase
-  include TweetHelper
+  include Test::Tweets
 
   before do
     @in  = mock

data/test/unit/uri_test.rb

@@ -1,6 +1,6 @@
 # coding: utf-8
 
-require 'unit/helper'
+require 'support/unit_test_case'
 
 module Tweetwine::Test::Unit
 

data/test/unit/url_shortener_test.rb

@@ -1,6 +1,6 @@
 # coding: utf-8
 
-require 'unit/helper'
+require 'support/unit_test_case'
 
 module Tweetwine::Test::Unit
 

data/tweetwine.gemspec

@@ -10,14 +10,15 @@ Gem::Specification.new do |s|
   s.executables = `git ls-files -- bin/*`.split("\n").map { |f| File.basename(f) }
 
   s.add_dependency 'oauth', '~> 0.4.4'
-  s.add_development_dependency 'gem-man',       '~> 0.2.0'
-  s.add_development_dependency 'minitest',      '~> 2.1.0'
+  s.add_development_dependency 'gem-man',       '~> 0.3.0'
+  s.add_development_dependency 'minitest',      '~> 2.4.0'
   s.add_development_dependency 'mocha',         '~> 0.9.12'
   s.add_development_dependency 'open4',         '~> 1.0.1'
-  s.add_development_dependency 'rake',          '~> 0.8.7'
+  s.add_development_dependency 'perftools.rb',  '~> 0.5.6'
+  s.add_development_dependency 'rake',          '>= 0.8.7'
   s.add_development_dependency 'ronn',          '~> 0.7.3'
   s.add_development_dependency 'timecop',       '~> 0.3.5'
-  s.add_development_dependency 'webmock',       '~> 1.6.2'
+  s.add_development_dependency 'webmock',       '~> 1.7.7'
 
   s.post_install_message = <<-END