tweetwine 0.2.12 → 0.3.0

data/test/{io_test.rb → ui_test.rb}

@@ -2,64 +2,82 @@
 
 require "test_helper"
 
-module Tweetwine
+module Tweetwine::Test
 
-class IOTest < TweetwineTestCase
-  context "An IO instance" do
+class UITest < UnitTestCase
+  context "a UI instance" do
     setup do
-      @input = mock()
-      @output = mock()
-      @io = IO.new({ :input => @input, :output => @output })
+      @in  = mock
+      @out = mock
+      @err = mock
+      @ui  = UI.new({ :in => @in, :out => @out, :err => @err })
     end
 
     should "output prompt and return input as trimmed" do
-      @output.expects(:print).with("The answer: ")
-      @input.expects(:gets).returns("  42 ")
-      assert_equal "42", @io.prompt("The answer")
+      @out.expects(:print).with("The answer: ")
+      @in.expects(:gets).returns("  42 ")
+      assert_equal "42", @ui.prompt("The answer")
     end
 
     should "output info message" do
-      @output.expects(:puts).with("foo")
-      @io.info("foo")
+      @out.expects(:puts).with("foo")
+      @ui.info("foo")
+    end
+
+    should "output info message in process style when given a block" do
+      inform = sequence('inform')
+      @out.expects(:print).with("processing...").in_sequence(inform)
+      @out.expects(:puts).with(" done.").in_sequence(inform)
+      @ui.info("processing...") { true }
+    end
+
+    should "output empty line as info message" do
+      @out.expects(:puts).with("\n")
+      @ui.info
     end
 
     should "output warning message" do
-      @output.expects(:puts).with("Warning: monkey patching ahead")
-      @io.warn("monkey patching ahead")
+      @out.expects(:puts).with("Warning: monkey patching ahead")
+      @ui.warn("monkey patching ahead")
+    end
+
+    should "output error message" do
+      @err.expects(:puts).with("ERROR: Invalid monkey patch")
+      @ui.error("Invalid monkey patch")
     end
 
     should "confirm action, with positive answer" do
-      @output.expects(:print).with("Fire nukes? [yN] ")
-      @input.expects(:gets).returns("y")
-      assert_equal true, @io.confirm("Fire nukes?")
+      @out.expects(:print).with("Fire nukes? [yN] ")
+      @in.expects(:gets).returns("y")
+      assert_equal true, @ui.confirm("Fire nukes?")
     end
 
     should "confirm action, with negative answer" do
-      @output.expects(:print).with("Fire nukes? [yN] ")
-      @input.expects(:gets).returns("n")
-      assert_equal false, @io.confirm("Fire nukes?")
+      @out.expects(:print).with("Fire nukes? [yN] ")
+      @in.expects(:gets).returns("n")
+      assert_equal false, @ui.confirm("Fire nukes?")
     end
 
     should "confirm action, with default answer" do
-      @output.expects(:print).with("Fire nukes? [yN] ")
-      @input.expects(:gets).returns("")
-      assert_equal false, @io.confirm("Fire nukes?")
+      @out.expects(:print).with("Fire nukes? [yN] ")
+      @in.expects(:gets).returns("")
+      assert_equal false, @ui.confirm("Fire nukes?")
     end
 
     context "with colorization disabled" do
       setup do
-        @io = IO.new({ :input => @input, :output => @output, :colors => false })
+        @ui = UI.new({:in => @in, :out => @out, :colors => false })
       end
 
       should "output a record as user info when no status is given" do
         from_user = "fooman"
         record = { :from_user => from_user }
-        @output.expects(:puts).with(<<-END
+        @out.expects(:puts).with(<<-END
 #{from_user}
 
         END
         )
-        @io.show_record(record)
+        @ui.show_record(record)
       end
 
       should "output a record as status info when status is given, without in-reply info" do
@@ -72,13 +90,13 @@ class IOTest < TweetwineTestCase
           :to_user    => nil
         }
         Util.expects(:humanize_time_diff).returns([2, "secs"])
-        @output.expects(:puts).with(<<-END
+        @out.expects(:puts).with(<<-END
 #{from_user}, 2 secs ago:
 #{status}
 
         END
         )
-        @io.show_record(record)
+        @ui.show_record(record)
       end
 
       should "output a record as status info when status is given, with in-reply info" do
@@ -92,13 +110,13 @@ class IOTest < TweetwineTestCase
           :to_user    => to_user
         }
         Util.expects(:humanize_time_diff).returns([2, "secs"])
-        @output.expects(:puts).with(<<-END
+        @out.expects(:puts).with(<<-END
 #{from_user}, in reply to #{to_user}, 2 secs ago:
 #{status}
 
         END
         )
-        @io.show_record(record)
+        @ui.show_record(record)
       end
 
 
@@ -113,41 +131,41 @@ class IOTest < TweetwineTestCase
           :to_user    => nil
         }
         Util.expects(:humanize_time_diff).returns([2, "secs"])
-        @output.expects(:puts).with(<<-END
+        @out.expects(:puts).with(<<-END
 #{from_user}, 2 secs ago:
 #{unescaped_status}
 
         END
         )
-        @io.show_record(record)
+        @ui.show_record(record)
       end
 
       should "output a preview of a status" do
         status = "@nick, check http://bit.ly/18rU_Vx"
-        @output.expects(:puts).with(<<-END
+        @out.expects(:puts).with(<<-END
 
 #{status}
 
         END
         )
-        @io.show_status_preview(status)
+        @ui.show_status_preview(status)
       end
     end
 
     context "with colorization enabled" do
       setup do
-        @io = IO.new({ :input => @input, :output => @output, :colors => true })
+        @ui = UI.new({:in => @in, :out => @out, :colors => true})
       end
 
       should "output a record as user info when no status is given" do
         from_user = "fooman"
         record = { :from_user => from_user }
-        @output.expects(:puts).with(<<-END
+        @out.expects(:puts).with(<<-END
 \e[32m#{from_user}\e[0m
 
         END
         )
-        @io.show_record(record)
+        @ui.show_record(record)
       end
 
       should "output a record as status info when status is given, without in-reply info" do
@@ -160,13 +178,13 @@ class IOTest < TweetwineTestCase
           :to_user    => nil
         }
         Util.expects(:humanize_time_diff).returns([2, "secs"])
-        @output.expects(:puts).with(<<-END
+        @out.expects(:puts).with(<<-END
 \e[32m#{from_user}\e[0m, 2 secs ago:
 #{status}
 
         END
         )
-        @io.show_record(record)
+        @ui.show_record(record)
       end
 
       should "output a record as status info when status is given, with in-reply info" do
@@ -179,24 +197,24 @@ class IOTest < TweetwineTestCase
           :to_user    => to_user
         }
         Util.expects(:humanize_time_diff).returns([2, "secs"])
-        @output.expects(:puts).with(<<-END
+        @out.expects(:puts).with(<<-END
 \e[32m#{from_user}\e[0m, in reply to \e[32m#{to_user}\e[0m, 2 secs ago:
 \e[33m@#{to_user}\e[0m! How are you doing?
 
         END
         )
-        @io.show_record(record)
+        @ui.show_record(record)
       end
 
       should "output a preview of a status" do
         status = "@nick, check http://bit.ly/18rU_Vx"
-        @output.expects(:puts).with(<<-END
+        @out.expects(:puts).with(<<-END
 
 \e[33m@nick\e[0m, check \e[36mhttp://bit.ly/18rU_Vx\e[0m
 
         END
         )
-        @io.show_status_preview(status)
+        @ui.show_status_preview(status)
       end
 
       should "highlight hashtags in a status" do
@@ -209,13 +227,13 @@ class IOTest < TweetwineTestCase
           :to_user    => nil
         }
         Util.expects(:humanize_time_diff).returns([2, "secs"])
-        @output.expects(:puts).with(<<-END
+        @out.expects(:puts).with(<<-END
 \e[32m#{from_user}\e[0m, 2 secs ago:
 Lulz, so happy! \e[35m#{hashtags[0]}\e[0m \e[35m#{hashtags[1]}\e[0m
 
         END
         )
-        @io.show_record(record)
+        @ui.show_record(record)
       end
 
       %w{http://is.gd/1qLk3 http://is.gd/1qLk3?id=foo}.each do |url|
@@ -228,13 +246,13 @@ Lulz, so happy! \e[35m#{hashtags[0]}\e[0m \e[35m#{hashtags[1]}\e[0m
             :to_user    => nil
           }
           Util.expects(:humanize_time_diff).returns([2, "secs"])
-          @output.expects(:puts).with(<<-END
+          @out.expects(:puts).with(<<-END
 \e[32m#{from_user}\e[0m, 2 secs ago:
 New Rails³ - \e[36m#{url}\e[0m
 
           END
           )
-          @io.show_record(record)
+          @ui.show_record(record)
         end
       end
 
@@ -251,13 +269,13 @@ New Rails³ - \e[36m#{url}\e[0m
             :to_user    => nil
           }
           Util.expects(:humanize_time_diff).returns([2, "secs"])
-          @output.expects(:puts).with(<<-END
+          @out.expects(:puts).with(<<-END
 \e[32m#{from_user}\e[0m, 2 secs ago:
 Links: \e[36m#{first_url}\e[0m and \e[36m#{second_url}\e[0m np
 
           END
           )
-          @io.show_record(record)
+          @ui.show_record(record)
         end
       end
 
@@ -271,13 +289,13 @@ Links: \e[36m#{first_url}\e[0m and \e[36m#{second_url}\e[0m np
           :to_user    => nil
         }
         Util.expects(:humanize_time_diff).returns([2, "secs"])
-        @output.expects(:puts).with(<<-END
+        @out.expects(:puts).with(<<-END
 \e[32m#{from_user}\e[0m, 2 secs ago:
 I salute you \e[33m#{users[0]}\e[0m, \e[33m#{users[1]}\e[0m, and \e[33m#{users[2]}\e[0m!
 
         END
         )
-        @io.show_record(record)
+        @ui.show_record(record)
       end
 
       should "not highlight email addresses as usernames in a status" do
@@ -291,50 +309,50 @@ I salute you \e[33m#{users[0]}\e[0m, \e[33m#{users[1]}\e[0m, and \e[33m#{users[2
           :to_user    => nil
         }
         Util.expects(:humanize_time_diff).returns([2, "secs"])
-        @output.expects(:puts).with(<<-END
+        @out.expects(:puts).with(<<-END
 \e[32m#{from_user}\e[0m, 2 secs ago:
 Hi, \e[33m#{users[0]}\e[0m! You should notify \e[33m#{users[1]}\e[0m, #{email}
 
         END
         )
-        @io.show_record(record)
+        @ui.show_record(record)
       end
     end
   end
 
-  context "Username regex" do
+  context "username regex" do
     should "match a proper username reference" do
-      assert_full_match IO::USERNAME_REGEX, "@nick"
-      assert_full_match IO::USERNAME_REGEX, "@nick_man"
-      assert_full_match IO::USERNAME_REGEX, "@nick"
-      assert_full_match IO::USERNAME_REGEX, " @nick"
+      assert_full_match UI::USERNAME_REGEX, "@nick"
+      assert_full_match UI::USERNAME_REGEX, "@nick_man"
+      assert_full_match UI::USERNAME_REGEX, "@nick"
+      assert_full_match UI::USERNAME_REGEX, " @nick"
     end
 
     should "not match an inproper username reference" do
-      assert_no_full_match IO::USERNAME_REGEX, "@"
-      assert_no_full_match IO::USERNAME_REGEX, "nick"
-      assert_no_full_match IO::USERNAME_REGEX, "-@nick"
-      assert_no_full_match IO::USERNAME_REGEX, "@nick-man"
-      assert_no_full_match IO::USERNAME_REGEX, "@nick "
-      assert_no_full_match IO::USERNAME_REGEX, " @nick "
-      assert_no_full_match IO::USERNAME_REGEX, "man @nick"
-      assert_no_full_match IO::USERNAME_REGEX, "man@nick"
+      assert_no_full_match UI::USERNAME_REGEX, "@"
+      assert_no_full_match UI::USERNAME_REGEX, "nick"
+      assert_no_full_match UI::USERNAME_REGEX, "-@nick"
+      assert_no_full_match UI::USERNAME_REGEX, "@nick-man"
+      assert_no_full_match UI::USERNAME_REGEX, "@nick "
+      assert_no_full_match UI::USERNAME_REGEX, " @nick "
+      assert_no_full_match UI::USERNAME_REGEX, "man @nick"
+      assert_no_full_match UI::USERNAME_REGEX, "man@nick"
     end
   end
 
-  context "Hashtag regex" do
+  context "hashtag regex" do
     should "match a proper hashtag reference" do
-      assert_full_match IO::HASHTAG_REGEX, "#mayhem"
-      assert_full_match IO::HASHTAG_REGEX, "#friday_mayhem"
-      assert_full_match IO::HASHTAG_REGEX, "#friday-mayhem"
+      assert_full_match UI::HASHTAG_REGEX, "#mayhem"
+      assert_full_match UI::HASHTAG_REGEX, "#friday_mayhem"
+      assert_full_match UI::HASHTAG_REGEX, "#friday-mayhem"
     end
 
     should "not match an inproper hashtag reference" do
-      assert_no_full_match IO::USERNAME_REGEX, "#"
-      assert_no_full_match IO::USERNAME_REGEX, "mayhem"
-      assert_no_full_match IO::USERNAME_REGEX, " #mayhem"
-      assert_no_full_match IO::USERNAME_REGEX, "#mayhem "
-      assert_no_full_match IO::USERNAME_REGEX, " #mayhem "
+      assert_no_full_match UI::USERNAME_REGEX, "#"
+      assert_no_full_match UI::USERNAME_REGEX, "mayhem"
+      assert_no_full_match UI::USERNAME_REGEX, " #mayhem"
+      assert_no_full_match UI::USERNAME_REGEX, "#mayhem "
+      assert_no_full_match UI::USERNAME_REGEX, " #mayhem "
     end
   end
 end

data/test/url_shortener_test.rb

@@ -2,159 +2,139 @@
 
 require "test_helper"
 
-module Tweetwine
+module Tweetwine::Test
 
-class UrlShortenerTest < TweetwineTestCase
-  context "An UrlShortener instance" do
-    setup do
-      @http_client = mock()
+class UrlShortenerTest < UnitTestCase
+  setup do
+    mock_http
+  end
+
+  context "for initialization" do
+    should "raise exception if service should be disabled" do
+      assert_raise(RuntimeError) do
+        UrlShortener.new(
+          :disable          => true,
+          :service_url      => "http://shorten.it/create",
+          :url_param_name   => "url",
+          :xpath_selector   => "//input[@id='short_url']/@value")
+      end
     end
 
-    context "upon initialization" do
-      should "raise exception if service URL is not given" do
-        assert_raise(ArgumentError) do
-          UrlShortener.new(
-            @http_client,
-            {
-              :service_url      => nil,
-              :url_param_name   => "url",
-              :xpath_selector   => "//input[@id='short_url']/@value"
-            }
-          )
-        end
+    should "raise exception if service URL is not given" do
+      assert_raise(RequiredOptionError) do
+        UrlShortener.new(
+          :service_url      => nil,
+          :url_param_name   => "url",
+          :xpath_selector   => "//input[@id='short_url']/@value")
       end
+    end
 
-      should "raise exception if URL parameter name is not given" do
-        assert_raise(ArgumentError) do
-          UrlShortener.new(
-            @http_client,
-            {
-              :service_url      => "http://shorten.it/create",
-              :url_param_name   => nil,
-              :xpath_selector   => "//input[@id='short_url']/@value"
-            }
-          )
-        end
+    should "raise exception if URL parameter name is not given" do
+      assert_raise(RequiredOptionError) do
+        UrlShortener.new(
+          :service_url      => "http://shorten.it/create",
+          :url_param_name   => nil,
+          :xpath_selector   => "//input[@id='short_url']/@value")
       end
+    end
 
-      should "raise exception if XPath selector is not given" do
-        assert_raise(ArgumentError) do
-          UrlShortener.new(
-            @http_client,
-            {
-              :service_url      => "http://shorten.it/create",
-              :url_param_name   => "url",
-              :xpath_selector   => nil
-            }
-          )
-        end
+    should "raise exception if XPath selector is not given" do
+      assert_raise(RequiredOptionError) do
+        UrlShortener.new(
+          :service_url      => "http://shorten.it/create",
+          :url_param_name   => "url",
+          :xpath_selector   => nil)
       end
+    end
 
-      should "fallback to use GET method if not given explicitly" do
-        url_shortener = UrlShortener.new(
-          @http_client,
-          {
-            :service_url      => "http://shorten.it/create",
-            :url_param_name   => "url",
-            :xpath_selector   => "//input[@id='short_url']/@value"
-          }
-        )
-        assert_equal(:get, url_shortener.instance_variable_get(:@method))
+    should "fallback to use GET method if method is not given explicitly" do
+      url_shortener = UrlShortener.new(
+        :service_url      => "http://shorten.it/create",
+        :url_param_name   => "url",
+        :xpath_selector   => "//input[@id='short_url']/@value")
+      @http.expects(:get)
+      url_shortener.shorten("http://www.ruby-doc.org/core/")
+    end
+
+    should "raise exception if given HTTP request method is unsupported" do
+      assert_raise(CommandLineError) do
+        UrlShortener.new(
+          :method           => "put",
+          :service_url      => "http://shorten.it/create",
+          :url_param_name   => "url",
+          :xpath_selector   => "//input[@id='short_url']/@value")
       end
     end
+  end
 
-    context "at runtime" do
-      context "configured for HTTP GET" do
-        should "use parameters as URL query parameters, with just the URL parameter" do
-          url_shortener = UrlShortener.new(
-            @http_client,
-            {
-              :method           => "get",
-              :service_url      => "http://shorten.it/create",
-              :url_param_name   => "url",
-              :xpath_selector   => "//input[@id='short_url']/@value"
-            }
-          )
-          @http_client.expects(:get) \
-              .with("http://shorten.it/create?url=http://www.ruby-doc.org/core/")
-          url_shortener.shorten("http://www.ruby-doc.org/core/")
-        end
+  context "at runtime" do
+    context "configured for HTTP GET" do
+      should "use parameters as URL query parameters, with just the URL parameter" do
+        url_shortener = UrlShortener.new(
+          :method           => "get",
+          :service_url      => "http://shorten.it/create",
+          :url_param_name   => "url",
+          :xpath_selector   => "//input[@id='short_url']/@value")
+        @http.expects(:get).
+          with("http://shorten.it/create?url=http://www.ruby-doc.org/core/")
+        url_shortener.shorten("http://www.ruby-doc.org/core/")
+      end
 
-        should "use parameters as URL query parameters, with additional extra parameters" do
-          url_shortener = UrlShortener.new(
-            @http_client,
-            {
-              :method           => "get",
-              :service_url      => "http://shorten.it/create",
-              :url_param_name   => "url",
-              :extra_params     => {
-                :token => "xyz"
-              },
-              :xpath_selector   => "//input[@id='short_url']/@value"
-            }
-          )
-          @http_client.expects(:get) \
-              .with("http://shorten.it/create?token=xyz&url=http://www.ruby-doc.org/core/")
-          url_shortener.shorten("http://www.ruby-doc.org/core/")
-        end
+      should "use parameters as URL query parameters, with additional extra parameters" do
+        url_shortener = UrlShortener.new(
+          :method           => "get",
+          :service_url      => "http://shorten.it/create",
+          :url_param_name   => "url",
+          :extra_params     => {
+            :token => "xyz"
+          },
+          :xpath_selector   => "//input[@id='short_url']/@value")
+        @http.expects(:get).
+            with("http://shorten.it/create?token=xyz&url=http://www.ruby-doc.org/core/")
+        url_shortener.shorten("http://www.ruby-doc.org/core/")
       end
+    end
 
-      context "configured for HTTP POST" do
-        should "use parameters as payload, with just the URL parameter" do
-          url_shortener = UrlShortener.new(
-            @http_client,
-            {
-              :method           => "post",
-              :service_url      => "http://shorten.it/create",
-              :url_param_name   => "url",
-              :xpath_selector   => "//input[@id='short_url']/@value"
-            }
-          )
-          @http_client.expects(:post) \
-              .with("http://shorten.it/create", {:url => "http://www.ruby-doc.org/core/"})
-          url_shortener.shorten("http://www.ruby-doc.org/core/")
-        end
+    context "configured for HTTP POST" do
+      should "use parameters as payload, with just the URL parameter" do
+        url_shortener = UrlShortener.new(
+          :method           => "post",
+          :service_url      => "http://shorten.it/create",
+          :url_param_name   => "url",
+          :xpath_selector   => "//input[@id='short_url']/@value")
+        @http.expects(:post).
+            with("http://shorten.it/create", {:url => "http://www.ruby-doc.org/core/"})
+        url_shortener.shorten("http://www.ruby-doc.org/core/")
+      end
 
-        should "use parameters as payload, with additional extra parameters" do
-          url_shortener = UrlShortener.new(
-            @http_client,
-            {
-              :method           => "post",
-              :service_url      => "http://shorten.it/create",
-              :url_param_name   => "url",
-              :extra_params     => {
-                :token => "xyz"
-              },
-              :xpath_selector   => "//input[@id='short_url']/@value"
-            }
-          )
-          @http_client.expects(:post) \
-              .with("http://shorten.it/create", {
-                :token => "xyz",
-                :url   => "http://www.ruby-doc.org/core/"
-              })
-          url_shortener.shorten("http://www.ruby-doc.org/core/")
-        end
+      should "use parameters as payload, with additional extra parameters" do
+        url_shortener = UrlShortener.new(
+          :method           => "post",
+          :service_url      => "http://shorten.it/create",
+          :url_param_name   => "url",
+          :extra_params     => {
+            :token => "xyz"
+          },
+          :xpath_selector   => "//input[@id='short_url']/@value")
+        @http.expects(:post).
+            with("http://shorten.it/create",
+              :token => "xyz",
+              :url   => "http://www.ruby-doc.org/core/")
+        url_shortener.shorten("http://www.ruby-doc.org/core/")
       end
+    end
 
-      context "in erroenous situations" do
-        should "raise HttpError upon connection error" do
-          url_shortener = UrlShortener.new(
-            @http_client,
-            {
-              :method           => "post",
-              :service_url      => "http://shorten.it/create",
-              :url_param_name   => "url",
-              :xpath_selector   => "//input[@id='short_url']/@value"
-            }
-          )
-          @http_client.expects(:post) \
-              .with("http://shorten.it/create", {
-                :url   => "http://www.ruby-doc.org/core/"
-              }) \
-              .raises(HttpError, "connection error")
-          assert_raise(HttpError) { url_shortener.shorten("http://www.ruby-doc.org/core/") }
-        end
+    context "in erroenous network situations" do
+      should "pass exceptions through" do
+        url_shortener = UrlShortener.new(
+          :method           => "post",
+          :service_url      => "http://shorten.it/create",
+          :url_param_name   => "url",
+          :xpath_selector   => "//input[@id='short_url']/@value")
+        @http.expects(:post).
+            with("http://shorten.it/create", :url => "http://www.ruby-doc.org/core/").
+            raises(HttpError.new(404, "Not Found"))
+        assert_raise(HttpError) { url_shortener.shorten("http://www.ruby-doc.org/core/") }
       end
     end
   end