tweetstream 2.6.0 → 2.6.1

data/spec/tweetstream/client_userstream_spec.rb

@@ -10,55 +10,55 @@ describe TweetStream::Client do
     end
     @client = TweetStream::Client.new
 
-    @stream = double("EM::Twitter::Client",
-      :connect => true,
-      :unbind => true,
-      :each => true,
-      :on_error => true,
-      :on_max_reconnects => true,
-      :on_reconnect => true,
-      :connection_completed => true,
-      :on_no_data_received => true,
-      :on_unauthorized => true,
-      :on_enhance_your_calm => true
+    @stream = double('EM::Twitter::Client',
+                     :connect => true,
+                     :unbind => true,
+                     :each => true,
+                     :on_error => true,
+                     :on_max_reconnects => true,
+                     :on_reconnect => true,
+                     :connection_completed => true,
+                     :on_no_data_received => true,
+                     :on_unauthorized => true,
+                     :on_enhance_your_calm => true
     )
     allow(EM).to receive(:run).and_yield
     allow(EM::Twitter::Client).to receive(:connect).and_return(@stream)
   end
 
-  describe "User Stream support" do
-    context "when calling #userstream" do
-      it "sends the userstream host" do
-        expect(EM::Twitter::Client).to receive(:connect).with(hash_including(:host => "userstream.twitter.com")).and_return(@stream)
+  describe 'User Stream support' do
+    context 'when calling #userstream' do
+      it 'sends the userstream host' do
+        expect(EM::Twitter::Client).to receive(:connect).with(hash_including(:host => 'userstream.twitter.com')).and_return(@stream)
         @client.userstream
       end
 
-      it "uses the userstream uri" do
-        expect(@client).to receive(:start).once.with("/1.1/user.json", an_instance_of(Hash)).and_return(@stream)
+      it 'uses the userstream uri' do
+        expect(@client).to receive(:start).once.with('/1.1/user.json', an_instance_of(Hash)).and_return(@stream)
         @client.userstream
       end
 
       it "supports :replies => 'all'" do
-        expect(@client).to receive(:start).once.with("/1.1/user.json", hash_including(:replies => 'all')).and_return(@stream)
+        expect(@client).to receive(:start).once.with('/1.1/user.json', hash_including(:replies => 'all')).and_return(@stream)
         @client.userstream(:replies => 'all')
       end
 
       it "supports :stall_warnings => 'true'" do
-        expect(@client).to receive(:start).once.with("/1.1/user.json", hash_including(:stall_warnings => 'true')).and_return(@stream)
+        expect(@client).to receive(:start).once.with('/1.1/user.json', hash_including(:stall_warnings => 'true')).and_return(@stream)
         @client.userstream(:stall_warnings => 'true')
       end
 
       it "supports :with => 'followings'" do
-        expect(@client).to receive(:start).once.with("/1.1/user.json", hash_including(:with => 'followings')).and_return(@stream)
+        expect(@client).to receive(:start).once.with('/1.1/user.json', hash_including(:with => 'followings')).and_return(@stream)
         @client.userstream(:with => 'followings')
       end
 
       it "supports :with => 'user'" do
-        expect(@client).to receive(:start).once.with("/1.1/user.json", hash_including(:with => 'user')).and_return(@stream)
+        expect(@client).to receive(:start).once.with('/1.1/user.json', hash_including(:with => 'user')).and_return(@stream)
         @client.userstream(:with => 'user')
       end
 
-      it "supports event callbacks" do
+      it 'supports event callbacks' do
         event = nil
         expect(@stream).to receive(:each).and_yield(fixture('favorite.json'))
         @client.on_event(:favorite) do |e|

data/spec/tweetstream/daemon_spec.rb

@@ -1,26 +1,26 @@
 require 'helper'
 
 describe TweetStream::Daemon do
-  describe ".new" do
-    it "initializes with no arguments" do
+  describe '.new' do
+    it 'initializes with no arguments' do
       client = TweetStream::Daemon.new
       expect(client).to be_kind_of(TweetStream::Client)
     end
 
-    it "initializes with defaults" do
+    it 'initializes with defaults' do
       client = TweetStream::Daemon.new
       expect(client.app_name).to eq(TweetStream::Daemon::DEFAULT_NAME)
       expect(client.daemon_options).to eq(TweetStream::Daemon::DEFAULT_OPTIONS)
     end
 
-    it "initializes with an app_name" do
+    it 'initializes with an app_name' do
       client = TweetStream::Daemon.new('tweet_tracker')
       expect(client.app_name).to eq('tweet_tracker')
     end
   end
 
-  describe "#start" do
-    it "starts the daemon" do
+  describe '#start' do
+    it 'starts the daemon' do
       client = TweetStream::Daemon.new
       expect(Daemons).to receive(:run_proc).once
       client.track('intridea')

data/spec/tweetstream/site_stream_client_spec.rb

@@ -5,8 +5,8 @@ describe TweetStream::SiteStreamClient do
   let(:config_uri) { '/2b/site/c/1_1_54e345d655ee3e8df359ac033648530bfbe26c5g' }
   let(:client)     { TweetStream::SiteStreamClient.new(config_uri) }
 
-  describe "initialization" do
-    context "with module configuration" do
+  describe 'initialization' do
+    context 'with module configuration' do
 
       before do
         TweetStream.configure do |config|
@@ -20,7 +20,7 @@ describe TweetStream::SiteStreamClient do
         TweetStream.reset
       end
 
-      it "inherits module configuration" do
+      it 'inherits module configuration' do
         api = TweetStream::SiteStreamClient.new('/config_uri')
         keys.each do |key|
           expect(api.send(key)).to eq(key)
@@ -28,7 +28,7 @@ describe TweetStream::SiteStreamClient do
       end
     end
 
-    context "with class configuration" do
+    context 'with class configuration' do
       let(:configuration) do
         {
           :consumer_key => 'CK',
@@ -38,8 +38,8 @@ describe TweetStream::SiteStreamClient do
         }
       end
 
-      context "during initialization" do
-        it "overrides module configuration" do
+      context 'during initialization' do
+        it 'overrides module configuration' do
           api = TweetStream::SiteStreamClient.new('/config_uri', configuration)
           keys.each do |key|
             expect(api.send(key)).to eq(configuration[key])
@@ -47,8 +47,8 @@ describe TweetStream::SiteStreamClient do
         end
       end
 
-      context "after initilization" do
-        it "overrides module configuration after initialization" do
+      context 'after initilization' do
+        it 'overrides module configuration after initialization' do
           api = TweetStream::SiteStreamClient.new('/config_uri')
           configuration.each do |key, value|
             api.send("#{key}=", value)
@@ -61,30 +61,30 @@ describe TweetStream::SiteStreamClient do
     end
   end
 
-  describe "#on_error" do
-    it "stores the on_error proc" do
+  describe '#on_error' do
+    it 'stores the on_error proc' do
       client = TweetStream::SiteStreamClient.new('/config_uri')
       client.on_error { puts 'hi' }
       expect(client.on_error).to be_kind_of(Proc)
     end
   end
 
-  describe "#info" do
-    context "success" do
-      it "returns the information hash" do
+  describe '#info' do
+    context 'success' do
+      it 'returns the information hash' do
         stub_request(:get, "https://sitestream.twitter.com#{config_uri}/info.json").
           to_return(:status => 200, :body => fixture('info.json'), :headers => {})
         stream_info = nil
 
         EM.run_block do
-          client.info { |info| stream_info = info}
+          client.info { |info| stream_info = info }
         end
         expect(stream_info).to be_kind_of(Hash)
       end
     end
 
-    context "failure" do
-      it "invokes the on_error callback" do
+    context 'failure' do
+      it 'invokes the on_error callback' do
         stub_request(:get, "https://sitestream.twitter.com#{config_uri}/info.json").
           to_return(:status => 401, :body => '', :headers => {})
         called = false
@@ -99,142 +99,142 @@ describe TweetStream::SiteStreamClient do
     end
   end
 
-  describe "#add_user" do
-    context "success" do
-      it "calls a block (if passed one)" do
+  describe '#add_user' do
+    context 'success' do
+      it 'calls a block (if passed one)' do
         stub_request(:post, "https://sitestream.twitter.com#{config_uri}/add_user.json").
           to_return(:status => 200, :body => '', :headers => {})
         called = false
 
         EM.run_block do
-          client.add_user(12345) { called = true }
+          client.add_user(123) { called = true }
         end
         expect(called).to be_true
       end
     end
 
-    context "failure" do
-      it "invokes the on_error callback" do
+    context 'failure' do
+      it 'invokes the on_error callback' do
         stub_request(:post, "https://sitestream.twitter.com#{config_uri}/add_user.json").
           to_return(:status => 401, :body => '', :headers => {})
         called = false
 
         EM.run_block do
           client.on_error { called = true }
-          client.add_user(12345) { |info| info }
+          client.add_user(123) { |info| info }
         end
         expect(called).to be_true
       end
     end
 
-    it "accepts an array of user_ids" do
+    it 'accepts an array of user_ids' do
       conn = double('Connection')
       expect(conn).to receive(:post).
-        with(:path => "#{config_uri}/add_user.json", :body => { 'user_id' => '1234,5678' }).
+        with(:path => "#{config_uri}/add_user.json", :body => {'user_id' => '1234,5678'}).
         and_return(FakeHttp.new)
       allow(client).to receive(:connection) { conn }
-      client.add_user(['1234','5678'])
+      client.add_user(%w[1234 5678])
     end
 
-    describe "accepts a single user_id as" do
+    describe 'accepts a single user_id as' do
       before :each do
         conn = double('Connection')
         expect(conn).to receive(:post).
-          with(:path => "#{config_uri}/add_user.json", :body => { 'user_id' => '1234' }).
+          with(:path => "#{config_uri}/add_user.json", :body => {'user_id' => '1234'}).
           and_return(FakeHttp.new)
         allow(client).to receive(:connection) { conn }
       end
 
-      it "a string" do
+      it 'a string' do
         client.add_user('1234')
       end
 
-      it "an integer" do
+      it 'an integer' do
         client.add_user(1234)
       end
     end
 
   end
 
-  describe "#remove_user" do
-    context "success" do
-      it "calls a block (if passed one)" do
+  describe '#remove_user' do
+    context 'success' do
+      it 'calls a block (if passed one)' do
         stub_request(:post, "https://sitestream.twitter.com#{config_uri}/remove_user.json").
           to_return(:status => 200, :body => '', :headers => {})
         called = false
 
         EM.run_block do
-          client.remove_user(12345) { called = true }
+          client.remove_user(123) { called = true }
         end
         expect(called).to be_true
       end
     end
 
-    context "failure" do
-      it "invokes the on_error callback" do
+    context 'failure' do
+      it 'invokes the on_error callback' do
         stub_request(:post, "https://sitestream.twitter.com#{config_uri}/remove_user.json").
           to_return(:status => 401, :body => '', :headers => {})
         called = false
 
         EM.run_block do
           client.on_error { called = true }
-          client.remove_user(12345) { |info| info }
+          client.remove_user(123) { |info| info }
         end
         expect(called).to be_true
       end
     end
 
-    it "accepts an array of user_ids" do
+    it 'accepts an array of user_ids' do
       conn = double('Connection')
       expect(conn).to receive(:post).
-        with(:path => "#{config_uri}/remove_user.json", :body => { 'user_id' => '1234,5678' }).
+        with(:path => "#{config_uri}/remove_user.json", :body => {'user_id' => '1234,5678'}).
         and_return(FakeHttp.new)
       allow(client).to receive(:connection) { conn }
-      client.remove_user(['1234','5678'])
+      client.remove_user(%w[1234 5678])
     end
 
-    describe "accepts a single user_id as" do
+    describe 'accepts a single user_id as' do
       before :each do
         conn = double('Connection')
         expect(conn).to receive(:post).
-          with(:path => "#{config_uri}/remove_user.json", :body => { 'user_id' => '1234' }).
+          with(:path => "#{config_uri}/remove_user.json", :body => {'user_id' => '1234'}).
           and_return(FakeHttp.new)
         allow(client).to receive(:connection) { conn }
       end
 
-      it "a string" do
+      it 'a string' do
         client.remove_user('1234')
       end
 
-      it "an integer" do
+      it 'an integer' do
         client.remove_user(1234)
       end
     end
   end
 
-  describe "#friends_ids" do
-    context "success" do
-      it "returns the information hash" do
+  describe '#friends_ids' do
+    context 'success' do
+      it 'returns the information hash' do
         stub_request(:post, "https://sitestream.twitter.com#{config_uri}/friends/ids.json").
           to_return(:status => 200, :body => fixture('ids.json'), :headers => {})
         stream_info = nil
 
         EM.run_block do
-          client.friends_ids(12345) { |info| stream_info = info }
+          client.friends_ids(123) { |info| stream_info = info }
         end
         expect(stream_info).to be_kind_of(Hash)
       end
     end
 
-    context "failure" do
-      it "invokes the on_error callback" do
+    context 'failure' do
+      it 'invokes the on_error callback' do
         stub_request(:post, "https://sitestream.twitter.com#{config_uri}/friends/ids.json").
           to_return(:status => 401, :body => '', :headers => {})
         called = false
 
         EM.run_block do
           client.on_error { called = true }
-          client.friends_ids(12345) { |info| info }
+          client.friends_ids(123) { |info| info }
         end
         expect(called).to be_true
       end

data/spec/tweetstream_spec.rb

@@ -2,96 +2,96 @@ require 'helper'
 
 describe TweetStream do
 
-  context "when delegating to a client" do
+  context 'when delegating to a client' do
     before do
-      @stream = double("EM::Twitter::Client",
-        :connect => true,
-        :unbind => true,
-        :each_item => true,
-        :on_error => true,
-        :on_max_reconnects => true,
-        :on_reconnect => true,
-        :connection_completed => true,
-        :on_no_data_received => true,
-        :on_unauthorized => true,
-        :on_enhance_your_calm => true
+      @stream = double('EM::Twitter::Client',
+                       :connect => true,
+                       :unbind => true,
+                       :each_item => true,
+                       :on_error => true,
+                       :on_max_reconnects => true,
+                       :on_reconnect => true,
+                       :connection_completed => true,
+                       :on_no_data_received => true,
+                       :on_unauthorized => true,
+                       :on_enhance_your_calm => true
       )
       allow(EM).to receive(:run).and_yield
       allow(EM::Twitter::Client).to receive(:connect).and_return(@stream)
     end
 
-    it "returns the same results as a client" do
+    it 'returns the same results as a client' do
       expect(MultiJson).to receive(:decode).and_return({})
       expect(@stream).to receive(:each).and_yield(sample_tweets[0].to_json)
-      TweetStream.track('abc','def')
+      TweetStream.track('abc', 'def')
     end
   end
 
-  describe ".new" do
-    it "is a TweetStream::Client" do
+  describe '.new' do
+    it 'is a TweetStream::Client' do
       expect(TweetStream.new).to be_a TweetStream::Client
     end
   end
 
-  describe ".respond_to?" do
-    it "takes an optional argument" do
+  describe '.respond_to?' do
+    it 'takes an optional argument' do
       expect(TweetStream.respond_to?(:new, true)).to be_true
     end
   end
 
-  describe ".username" do
-    it "returns the default username" do
+  describe '.username' do
+    it 'returns the default username' do
       expect(TweetStream.username).to eq(TweetStream::Configuration::DEFAULT_USERNAME)
     end
   end
 
-  describe ".username=" do
-    it "sets the username" do
+  describe '.username=' do
+    it 'sets the username' do
       TweetStream.username = 'jack'
       expect(TweetStream.username).to eq('jack')
     end
   end
 
-  describe ".password" do
-    it "returns the default password" do
+  describe '.password' do
+    it 'returns the default password' do
       expect(TweetStream.password).to eq(TweetStream::Configuration::DEFAULT_PASSWORD)
     end
   end
 
-  describe ".password=" do
-    it "sets the password" do
+  describe '.password=' do
+    it 'sets the password' do
       TweetStream.password = 'passw0rd'
       expect(TweetStream.password).to eq('passw0rd')
     end
   end
 
-  describe ".auth_method" do
-    it "shold return the default auth method" do
+  describe '.auth_method' do
+    it 'shold return the default auth method' do
       expect(TweetStream.auth_method).to eq(TweetStream::Configuration::DEFAULT_AUTH_METHOD)
     end
   end
 
-  describe ".auth_method=" do
-    it "sets the auth method" do
+  describe '.auth_method=' do
+    it 'sets the auth method' do
       TweetStream.auth_method = :basic
       expect(TweetStream.auth_method).to eq(:basic)
     end
   end
 
-  describe ".user_agent" do
-    it "returns the default user agent" do
+  describe '.user_agent' do
+    it 'returns the default user agent' do
       expect(TweetStream.user_agent).to eq(TweetStream::Configuration::DEFAULT_USER_AGENT)
     end
   end
 
-  describe ".user_agent=" do
-    it "sets the user_agent" do
+  describe '.user_agent=' do
+    it 'sets the user_agent' do
       TweetStream.user_agent = 'Custom User Agent'
       expect(TweetStream.user_agent).to eq('Custom User Agent')
     end
   end
 
-  describe ".configure" do
+  describe '.configure' do
     TweetStream::Configuration::VALID_OPTIONS_KEYS.each do |key|
       it "sets the #{key}" do
         TweetStream.configure do |config|
@@ -102,14 +102,14 @@ describe TweetStream do
     end
   end
 
-  describe ".options" do
-    it "returns the configuration as a hash" do
+  describe '.options' do
+    it 'returns the configuration as a hash' do
       expect(TweetStream.options).to be_kind_of(Hash)
     end
   end
 
-  describe ".oauth_options" do
-    it "returns the oauth configuration as a hash" do
+  describe '.oauth_options' do
+    it 'returns the oauth configuration as a hash' do
       expect(TweetStream.oauth_options).to be_kind_of(Hash)
     end
   end
@@ -122,7 +122,7 @@ describe TweetStream do
 
   describe '.proxy=' do
     it 'sets the proxy' do
-      TweetStream.proxy = { :uri => 'http://someproxy:8081' }
+      TweetStream.proxy = {:uri => 'http://someproxy:8081'}
       expect(TweetStream.proxy).to be_kind_of(Hash)
     end
   end