twdeps 1.0.2 → 1.1.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 02ba155ab3b383b038d5e2c4df847450dd105467d32a6d85210c077a1d9e409b
-  data.tar.gz: 03360def6b47864ac9f31983597d35de084ae11be770a227a49261a2ce57703e
+  metadata.gz: 21e937aa5bc22ba04dce7989b7f230eee6e32d0beeebad1d5342b6b4a8fea74a
+  data.tar.gz: 4e5424264d551351b0b64ef549ca4381293fd6622bad709e42e1856a507edc67
 SHA512:
-  metadata.gz: bede1f117238591b1c9f54935cbd8cbecddc250f731533635e074b21d479ec967cfdcdc4dbc752e7edb1d31426fe68040a14d1dd7e240fabda300933a54eec6f
-  data.tar.gz: 833e77bc779e3fb92440691c7c8d513660b24948e2d5077d15f2f931ce8eee65406ac04a05455562e5e31a59ed91b33a0aeb9ff96a7a5d58d1f04bceb29e8bfb
+  metadata.gz: af9dc05e434ec0ef6c56134b1ebbd08b8292f02f636ab4279eca6c949d5c733e62c97e34da902e51188e00860cdbee22dd53edf7d708de9670a5ea2ba342ecd9
+  data.tar.gz: 2e42fb492cf2c8219b3ce0b7fb52bbb76740f72d057ae7ba14a4b4beb85ff31faf3a15dfd75a98614c5e666bbcbadea35a549a12bae8916f0d7841c2e5cd3cc3

data/.travis.yml

@@ -1,7 +1,7 @@
 language: ruby
 
 rvm:
-  - 2.5.1
+  - 2.5.3
 
 before_script:
  - mkdir ~/.task

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    twdeps (1.0.2)
+    twdeps (1.1.0)
       optimist
       ruby-graphviz
       taskwarrior (~> 1.0.0)
@@ -9,13 +9,14 @@ PATH
 GEM
   remote: https://rubygems.org/
   specs:
-    activemodel (5.2.1)
-      activesupport (= 5.2.1)
-    activesupport (5.2.1)
+    activemodel (5.2.1.1)
+      activesupport (= 5.2.1.1)
+    activesupport (5.2.1.1)
       concurrent-ruby (~> 1.0, >= 1.0.2)
       i18n (>= 0.7, < 2)
       minitest (~> 5.1)
       tzinfo (~> 1.1)
+    byebug (10.0.2)
     coderay (1.1.2)
     concurrent-ruby (1.1.3)
     ffi (1.9.25)
@@ -54,6 +55,9 @@ GEM
     pry (0.12.2)
       coderay (~> 1.1.0)
       method_source (~> 0.9.0)
+    pry-byebug (3.6.0)
+      byebug (~> 10.0)
+      pry (~> 0.10)
     rake (12.3.1)
     rb-fsevent (0.10.3)
     rb-inotify (0.9.10)
@@ -77,6 +81,7 @@ DEPENDENCIES
   guard-bundler
   guard-minitest
   minitest
+  pry-byebug
   rake
   twdeps!
   twtest

data/README.md

@@ -17,13 +17,17 @@ Result:
 
 ![party](https://raw.github.com/nerab/twdeps/master/examples/party.png)
 
-For the impatient: The JSON export is also available as [party.json](https://raw.github.com/nerab/twdeps/master/test/fixtures/party.json). If you download it, the command
+For the impatient: The JSON export is also available as [party.json](https://raw.github.com/nerab/twdeps/master/test/fixtures/party.json). Once you installed `twdeps`, the command
 
 ```bash
-$ twdeps -f png party.json > party.png
+$ curl https://raw.githubusercontent.com/nerab/twdeps/master/test/fixtures/party.json | twdeps -f png > party.png
 ```
 
-will generate `party.png` in the current directory.
+will generate `party.png` in the current directory. If you don't want to download the JSON file, try the local oen that comes with `twdeps`:
+
+```bash
+$ twdeps $(dirname $(gem which twdeps))/../test/fixtures/party.json -f png > party.png
+```
 
 ## Installation
 

data/lib/twdeps/graph.rb

@@ -39,10 +39,11 @@ module TaskWarrior
 
           # resolve all dependencies we don't know yet
           task.dependencies.each do |dependency|
-            unless @dependencies.include?(dependency)
-              @dependencies << dependency
-              self << dependency
-            end
+            next if @dependencies.include?(dependency)
+            next if dependency.nil?
+
+            @dependencies << dependency
+            self << dependency
           end
         else
           # it's a project

data/lib/twdeps/version.rb

@@ -1,5 +1,5 @@
 module TaskWarrior
   module Dependencies
-    VERSION = '1.0.2'
+    VERSION = '1.1.0'
   end
 end

data/test/fixtures/dead-dependency.json

@@ -0,0 +1,14 @@
+[{
+  "id": 42,
+  "depends": "9c16b278-6c79-407e-be1b-3eb65e4b11be",
+  "description": "Handle dead depends",
+  "entry": "20101121T205311Z",
+  "project": "FixAllTheBugs",
+  "status": "pending",
+  "uuid": "2170fecc-0646-4320-99e0-75ed3c365f1c",
+  "annotations": [{
+    "entry": "20130210T173348Z",
+    "description": "This is a comment"
+  }],
+  "urgency": -1.2
+}]

data/test/test_helper.rb

@@ -1,4 +1,5 @@
 require 'minitest/autorun'
+require 'pry-byebug'
 require 'twtest'
 require 'twdeps'
 require 'helpers/plain_graph_parser.rb'

data/test/unit/test_broken_dependencies.rb

@@ -0,0 +1,28 @@
+require 'test_helper'
+
+module TaskWarrior
+  module Test
+    class TestBrokenDependencies < MiniTest::Test
+      include TaskWarrior::Test::Fixtures
+
+      def setup
+        graph = TaskWarrior::Dependencies::Graph.new(self.class.name)
+
+        TaskWarrior::Repository.new(File.read(fixture('dead-dependency.json'))).tasks.each do |task|
+          graph << task
+        end
+
+        @parsed_graph = TaskWarrior::Test::PlainGraphParser.new(graph.render(:plain))
+      end
+
+
+      def test_node_size
+        assert_equal(2, @parsed_graph.nodes.size)
+      end
+
+      def test_node_text
+        refute_nil(@parsed_graph.node('2170fecc-0646-4320-99e0-75ed3c365f1c'))
+      end
+    end
+  end
+end

data/test/unit/test_graph.rb

@@ -7,7 +7,6 @@ module TaskWarrior
 
       def setup
         repo = TaskWarrior::Repository.new(File.read(fixture('party_taxes.json')))
-
         plain = TaskWarrior::Dependencies::Graph.new(self.class.name)
 
         repo.tasks.each do |task|

data/twdeps.gemspec

@@ -22,4 +22,5 @@ Gem::Specification.new do |gem|
   gem.add_development_dependency 'guard-minitest'
   gem.add_development_dependency 'guard-bundler'
   gem.add_development_dependency 'rake'
+  gem.add_development_dependency 'pry-byebug'
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: twdeps
 version: !ruby/object:Gem::Version
-  version: 1.0.2
+  version: 1.1.0
 platform: ruby
 authors:
 - Nicholas E. Rabenau
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2018-11-26 00:00:00.000000000 Z
+date: 2018-12-03 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: ruby-graphviz
@@ -122,6 +122,20 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '0'
+- !ruby/object:Gem::Dependency
+  name: pry-byebug
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
 description: Takes a TaskWarrior export and emits a graph that visualizes the dependencies
   between tasks.
 email:
@@ -150,6 +164,7 @@ files:
 - lib/twdeps/project_presenter.rb
 - lib/twdeps/task_presenter.rb
 - lib/twdeps/version.rb
+- test/fixtures/dead-dependency.json
 - test/fixtures/no_deps.json
 - test/fixtures/party.json
 - test/fixtures/party2.json
@@ -157,6 +172,7 @@ files:
 - test/helpers/plain_graph_parser.rb
 - test/integration/test_dependencies.rb
 - test/test_helper.rb
+- test/unit/test_broken_dependencies.rb
 - test/unit/test_graph.rb
 - test/unit/test_presenters.rb
 - twdeps.gemspec
@@ -184,6 +200,7 @@ signing_key:
 specification_version: 4
 summary: Visualizes dependencies between TaskWarrior tasks.
 test_files:
+- test/fixtures/dead-dependency.json
 - test/fixtures/no_deps.json
 - test/fixtures/party.json
 - test/fixtures/party2.json
@@ -191,5 +208,6 @@ test_files:
 - test/helpers/plain_graph_parser.rb
 - test/integration/test_dependencies.rb
 - test/test_helper.rb
+- test/unit/test_broken_dependencies.rb
 - test/unit/test_graph.rb
 - test/unit/test_presenters.rb