turkish_cities 0.1.3 → 0.2.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: d989f10ad83bcdcb075741115677daca3be317e0030d5dc4b265273e9a5fbeb9
-  data.tar.gz: 23a660a74d9708b27b297ce71f6d2627c74a0af99d976c182432df3ffc5de331
+  metadata.gz: 528b791fc697635aaedf2ea43825b172f02271f452256c6a3886fb74c8971a83
+  data.tar.gz: d6e52070ceaed57ff61fa8725e80a2d5459aefce48c0787bfd0c87a7705c3877
 SHA512:
-  metadata.gz: 5e0a364e8d251692bf4c98792f02b26a8765b24321e7c0054c6a003055f63808903b82fd2271c4244364407f040e5f41058abe29f9a4ce100f3e25478a13c596
-  data.tar.gz: 1f62992e4e054526f1a1b396c6c0c3e2d23eda86024e0faa93024e3a26737ecdc95d4d23d9a23caea83c3a93882e3ab5a5b2864157f28edc338e291b398546a0
+  metadata.gz: ee0223deae4c3907f26e1769ab57e19f8b901873efa532aa8be31fec3cfe27ce22ebb32fd0d24ebf99d7ec3a17abfc26f3c6061b05782a9cfb376de26ae18b18
+  data.tar.gz: 9a10b09a78d230af8e57dafd1609ef3246de8e3ceb45c610132567553d519b6cc6535e7a76e38febedb0547dc5a018683456405ac56892b557ceb788449c02e6

data/.codeclimate.yml

@@ -0,0 +1,5 @@
+version: "2"
+checks:
+  method-complexity:
+    config:
+      threshold: 10

data/.hound.yml

@@ -1,3 +1,3 @@
 rubocop:
   version: 0.80.0
-  config_file: .rubocop.yml
+  config_file: .older.rubocop.yml

data/.older.rubocop.yml

@@ -0,0 +1,23 @@
+AllCops:
+  TargetRubyVersion: 2.5.1
+  Exclude:
+    - 'Gemfile'
+    - 'turkish_cities.gemspec'
+Layout/LineLength:
+  Max: 100
+Metrics/AbcSize:
+  Max: 20
+Metrics/BlockLength:
+  ExcludedMethods: ['describe', 'context']
+Metrics/MethodLength:
+  Max: 15
+Style/Documentation:
+  Enabled: false
+Style/HashEachMethods:
+  Enabled: true
+Style/HashTransformKeys:
+  Description: 'Prefer `transform_keys` over `each_with_object` and `map`.'
+  Enabled: true
+Style/HashTransformValues:
+  Description: 'Prefer `transform_values` over `each_with_object` and `map`.'
+  Enabled: true

data/.rubocop.yml

@@ -3,6 +3,8 @@ AllCops:
   Exclude:
     - 'Gemfile'
     - 'turkish_cities.gemspec'
+Layout/EmptyLinesAroundAttributeAccessor:
+  Enabled: true
 Layout/LineLength:
   Max: 100
 Layout/SpaceAroundMethodCallOperator:
@@ -11,8 +13,12 @@ Lint/RaiseException:
   Enabled: true
 Lint/StructNewOverride:
   Enabled: true
+Metrics/AbcSize:
+  Max: 20
 Metrics/BlockLength:
   ExcludedMethods: ['describe', 'context']
+Metrics/MethodLength:
+  Max: 15
 Style/Documentation:
   Enabled: false
 Style/ExponentialNotation:
@@ -25,3 +31,5 @@ Style/HashTransformKeys:
 Style/HashTransformValues:
   Description: 'Prefer `transform_values` over `each_with_object` and `map`.'
   Enabled: true
+Style/SlicingWithRange:
+  Enabled: true

data/.travis.yml

@@ -1,3 +1,6 @@
+env:
+  global:
+    - CC_TEST_REPORTER_ID=23062197f289fd0ae7601ae06c2dd4a0af4e16c436f2428b99ab4b64a7e4a587
 language: ruby
 dist: trusty
 rvm:
@@ -6,7 +9,13 @@ rvm:
   - 2.7
 before_install:
   - gem install bundler
+before_script:
+  - curl -L https://codeclimate.com/downloads/test-reporter/test-reporter-latest-linux-amd64 > ./cc-test-reporter
+  - chmod +x ./cc-test-reporter
+  - ./cc-test-reporter before-build
 script: bundle exec rspec spec
+after_script:
+  - ./cc-test-reporter after-build --exit-code $TRAVIS_TEST_RESULT
 notifications:
   email:
     - arslanoglusemih93@gmail.com

data/CHANGELOG.md

@@ -1,5 +1,23 @@
 # Changelog
 
+## 0.2.0 (2020-05-18)
+
+### New features
+
+* [#36](https://github.com/sarslanoglu/turkish_cities/issues/36): Add ```postcode``` class and ```find_by_postcode``` method for finding city, district and subdistrict information by given postcode
+
+* [#33](https://github.com/sarslanoglu/turkish_cities/issues/33): Add ```list_neighborhoods``` method for listing neighborhoods and fix some wrong district names
+
+* [#29](https://github.com/sarslanoglu/turkish_cities/issues/29): Add ```district``` class and ```list_subdistricts``` method for listing subdistricts
+
+* [#27](https://github.com/sarslanoglu/turkish_cities/issues/27): Add all subdistricts and neighborhoods of all Turkish cities
+
+* [#25](https://github.com/sarslanoglu/turkish_cities/issues/25): Add district data to each city at yaml file and add new method ```list_districts``` for listing disctricts of cities alphabetically sorted
+
+### Changes
+
+* [#24](https://github.com/sarslanoglu/turkish_cities/issues/24): Add listing support with ```metropolitan_municipality_since, phone_code, plate_number, region``` to ```listing_cities``` method
+
 ## 0.1.3 (2020-04-20)
 
 ### New features

data/Gemfile.lock

@@ -19,10 +19,9 @@ GEM
     docile (1.3.2)
     i18n (1.8.2)
       concurrent-ruby (~> 1.0)
-    jaro_winkler (1.5.4)
     json (2.3.0)
     parallel (1.19.1)
-    parser (2.7.1.1)
+    parser (2.7.1.2)
       ast (~> 2.4.0)
     rainbow (3.0.0)
     rexml (3.2.4)
@@ -39,8 +38,7 @@ GEM
       diff-lcs (>= 1.2.0, < 2.0)
       rspec-support (~> 3.9.0)
     rspec-support (3.9.2)
-    rubocop (0.82.0)
-      jaro_winkler (~> 1.5.1)
+    rubocop (0.83.0)
       parallel (~> 1.10)
       parser (>= 2.7.0.1)
       rainbow (>= 2.2.2, < 4.0)
@@ -68,7 +66,7 @@ DEPENDENCIES
   bundler (~> 2.1.4)
   coveralls (~> 0.8.23)
   rspec (~> 3.9.0)
-  rubocop (~> 0.82.0)
+  rubocop (~> 0.83.0)
   turkish_cities!
 
 BUNDLED WITH

data/README.md

@@ -1,13 +1,35 @@
 # 🏙️ Turkish Cities
 [![Gem Version](https://badge.fury.io/rb/turkish_cities.svg)](https://rubygems.org/gems/turkish_cities)
 [![Build Status](https://travis-ci.org/sarslanoglu/turkish_cities.svg?branch=master)](https://travis-ci.org/sarslanoglu/turkish_cities)
-[![Code Climate](https://codeclimate.com/github/sarslanoglu/turkish_cities.svg)](https://codeclimate.com/github/sarslanoglu/turkish_cities)
 [![Coverage Status](https://coveralls.io/repos/github/sarslanoglu/turkish_cities/badge.svg?branch=master)](https://coveralls.io/github/sarslanoglu/turkish_cities?branch=master)
+[![Maintainability](https://api.codeclimate.com/v1/badges/c1dbe0cef353b152956e/maintainability)](https://codeclimate.com/github/sarslanoglu/turkish_cities/maintainability)
+[![Test Coverage](https://api.codeclimate.com/v1/badges/c1dbe0cef353b152956e/test_coverage)](https://codeclimate.com/github/sarslanoglu/turkish_cities/test_coverage)
 [![Protected by Hound](https://img.shields.io/badge/Protected_by-Hound-a873d1.svg)](https://houndci.com)
 [![License](https://img.shields.io/github/license/sarslanoglu/turkish_cities.svg)](https://opensource.org/licenses/MIT)
 
 **turkish_cities** is a Ruby gem which makes searching and listing Turkish cities easy. https://rubygems.org/gems/turkish_cities
 
+## Table of Contents
+* [Installation](#installation)
+* [Documentation](#documentation)
+  * [Finding city name by plate number](#finding-city-name-by-plate-number)
+  * [Finding city name by phone code](#finding-city-name-by-phone-code)
+  * [Finding plate number by city name](#finding-plate-number-by-city-name)
+  * [Finding phone code by city name](#finding-phone-code-by-city-name)
+  * [Listing all cities](#listing-all-cities)
+    * [Listing all cities with only name](#listing-all-cities-with-only-name)
+    * [Listing all cities with other parameters](#listing-all-cities-with-other-parameters)
+  * [Listing all districts of given city](#listing-all-districts-of-given-city)
+  * [Listing all subdistricts of given city and district](#listing-all-subdistricts-of-given-city-and-district)
+  * [Listing all neighborhoods of given city and district](#listing-all-neighborhoods-of-given-city-and-district)
+    * [With subdistrict info](#with-subdistrict-info)
+    * [Without subdistrict info](#ithout-subdistrict-info)
+  * [Finding city, district and subdistrict name by postcode](#finding-city-district-and-subdistrict-name-by-postcode)
+* [Compatibility](#compatibility)
+* [Contributing](#contributing)
+* [Changelog](#changelog)
+* [Copyright](#copyright)
+
 ## Installation
 
 Installation is pretty standard:
@@ -38,56 +60,56 @@ require 'turkish_cities'
 
 ### Finding city name by plate number
 
-There are 81 cities in Turkey. By calling a plate number between 1-81 will give city_name
+There are 81 cities in Turkey. By calling a plate number between 1-81 will give city_name.
 
 ```ruby
-TurkishCities.find_name_by_plate_number(26) # => "Eskişehir"
-TurkishCities.find_name_by_plate_number(7) # => "Antalya"
+TurkishCities.find_name_by_plate_number(26)   # => "Eskişehir"
+TurkishCities.find_name_by_plate_number(7)    # => "Antalya"
 TurkishCities.find_name_by_plate_number(0007) # => "Antalya"
 TurkishCities.find_name_by_plate_number(43.0) # => "Kütahya"
 TurkishCities.find_name_by_plate_number('78') # => "Karabük"
-TurkishCities.find_name_by_plate_number(100) # => 'Given value [100] is outside bounds of 1 to 81.'
+TurkishCities.find_name_by_plate_number(100)  # => 'Given value [100] is outside bounds of 1 to 81.'
 ```
 
 ### Finding city name by phone code
 
-There are 81 cities in Turkey. By calling a phone code between 212-488 will give city_name. All phone codes are even sending odd number will give error without searching
+There are 81 cities in Turkey. By calling a phone code between 212-488 will give city_name. All phone codes are even sending odd number will give error without searching.
 
 ```ruby
-TurkishCities.find_name_by_phone_code(312) # => "Ankara"
-TurkishCities.find_name_by_phone_code(242) # => "Antalya"
+TurkishCities.find_name_by_phone_code(312)    # => "Ankara"
+TurkishCities.find_name_by_phone_code(242)    # => "Antalya"
 TurkishCities.find_name_by_phone_code(000222) # => "Eskişehir"
-TurkishCities.find_name_by_phone_code(274.0) # => "Kütahya"
-TurkishCities.find_name_by_phone_code('212') # => "İstanbul"
-TurkishCities.find_name_by_phone_code(216) # => "İstanbul"
-TurkishCities.find_name_by_phone_code(360) # => 'Couldn't find city name with phone code 360'
-TurkishCities.find_name_by_phone_code(0) # => 'Given value [0] is outside bounds of 212 to 488.'
-TurkishCities.find_name_by_phone_code(213) # => 'Given value [213] must be an even number.'
+TurkishCities.find_name_by_phone_code(274.0)  # => "Kütahya"
+TurkishCities.find_name_by_phone_code('212')  # => "İstanbul"
+TurkishCities.find_name_by_phone_code(216)    # => "İstanbul"
+TurkishCities.find_name_by_phone_code(360)    # => 'Couldn't find city name with phone code 360'
+TurkishCities.find_name_by_phone_code(0)      # => 'Given value [0] is outside bounds of 212 to 488.'
+TurkishCities.find_name_by_phone_code(213)    # => 'Given value [213] must be an even number.'
 ```
 
 ### Finding plate number by city name
 
-City name can be given case and turkish character insensitive
+City name can be given case and turkish character insensitive.
 
 ```ruby
-TurkishCities.find_plate_number_by_name('Ankara') # => 6
-TurkishCities.find_plate_number_by_name('Eskişehir') # => 26
-TurkishCities.find_plate_number_by_name('Canakkale') # => 17
-TurkishCities.find_plate_number_by_name('Istanbul') # => 34
-TurkishCities.find_plate_number_by_name('kirsehir') # => 40
+TurkishCities.find_plate_number_by_name('Ankara')     # => 6
+TurkishCities.find_plate_number_by_name('Eskişehir')  # => 26
+TurkishCities.find_plate_number_by_name('Canakkale')  # => 17
+TurkishCities.find_plate_number_by_name('Istanbul')   # => 34
+TurkishCities.find_plate_number_by_name('kirsehir')   # => 40
 TurkishCities.find_plate_number_by_name('falansehir') # => "Couldn't find city name with 'falansehir'"
 ```
 
-### Finding phone number by city name
+### Finding phone code by city name
 
-City name can be given case and turkish character insensitive
+City name can be given case and turkish character insensitive.
 
 ```ruby
-TurkishCities.find_phone_code_by_name('Ankara') # => 312
-TurkishCities.find_phone_code_by_name('Eskişehir') # => 222
-TurkishCities.find_phone_code_by_name('Canakkale') # => 286
-TurkishCities.find_phone_code_by_name('Istanbul') # => [212, 216]
-TurkishCities.find_phone_code_by_name('kirsehir') # => 386
+TurkishCities.find_phone_code_by_name('Ankara')     # => 312
+TurkishCities.find_phone_code_by_name('Eskişehir')  # => 222
+TurkishCities.find_phone_code_by_name('Canakkale')  # => 286
+TurkishCities.find_phone_code_by_name('Istanbul')   # => [212, 216]
+TurkishCities.find_phone_code_by_name('kirsehir')   # => 386
 TurkishCities.find_phone_code_by_name('filansehir') # => "Couldn't find city name with 'filansehir'"
 ```
 
@@ -99,6 +121,8 @@ By default cities will be listed by their plate number ascending.
 TurkishCities.list_cities # => ["Adana", "Adıyaman" ... "Kilis", "Osmaniye", "Düzce"]
 ```
 
+### Listing all cities with only name
+
 While listing cities three additional parameters can be send ```alphabetically_sorted```, ```metropolitan_municipality``` and ```region```. All parameters can be send seperately and together.
 
 ```ruby
@@ -116,13 +140,113 @@ TurkishCities.list_cities({ alphabetically_sorted: true, metropolitan_municipali
 # => ["Adana", "Ankara" ... "Tekirdağ", "Trabzon", "Van"]
 ```
 
+### Listing all cities with other parameters
+
+While listing cities ```with``` parameter can be used for listing cities with other attributes. These parameters are ```alphabetically_sorted```, ```metropolitan_municipality``` and ```region```. All parameters can be send seperately and together.
+
+```ruby
+TurkishCities.list_cities({ alphabetically_sorted: true, with: { phone_code: true } })
+# => [{:name=>"Adana", :phone_code=>322}, {:name=>"Adıyaman", :phone_code=>416}, {:name=>"Afyon", :phone_code=>272} .
+# .. {:name=>"Yozgat", :phone_code=>354}, {:name=>"Zonguldak", :phone_code=>372}]
+TurkishCities.list_cities({ with: { plate_number: true } })
+# => [{:name=>"Adana", :plate_number=>1}, {:name=>"Adıyaman", :plate_number=>2}, {:name=>"Afyon", :plate_number=>3} .
+# .. {:name=>"Osmaniye", :plate_number=>80}, {:name=>"Düzce", :plate_number=>81}]
+TurkishCities.list_cities({ metropolitan_municipality: true, region: 'Karadeniz', with: { all: true } })
+# => [{:name=>"Ordu", :plate_number=>52, :phone_code=>452, :metropolitan_municipality_since=>2012,
+#      :region=>"Karadeniz"},{:name=>"Samsun", :plate_number=>55, :phone_code=>362,
+#      :metropolitan_municipality_since=>1993, :region=>"Karadeniz"}, {:name=>"Trabzon", :plate_number=>61,
+#      :phone_code=>462, :metropolitan_municipality_since=>2012, :region=>"Karadeniz"}]
+```
+
+### Listing all districts of given city
+
+City name can be given case and turkish character insensitive. Listing of districts are alphabetically sorted.
+
+```ruby
+TurkishCities.list_districts('Ankara')
+# => ["Akyurt", "Altındağ" ... "Sincan", "Şereflikoçhisar", "Yenimahalle"]
+TurkishCities.list_districts('Eskişehir')
+# => ["Alpu", "Beylikova", "Çifteler" ... "Sivrihisar", "Tepebaşı"]
+TurkishCities.list_districts('Canakkale')
+# => ["Ayvacık", "Bayramiç" ... "Lapseki", "Merkez", "Yenice"]
+TurkishCities.list_districts('Bayburt')
+# => ["Aydıntepe", "Demirözü", "Merkez"]
+TurkishCities.list_districts('Istanbul').length
+# => 39
+TurkishCities.list_districts('filansehir')
+# => "Couldn't find city name with 'filansehir'"
+```
+
+### Listing all subdistricts of given city and district
+
+City name can be given case and turkish character insensitive. District name should be case and turkish character sensitive.(Correct district names can be obtained by ```list_districts``` method.) Listing of subdistricts are alphabetically sorted.
+
+```ruby
+TurkishCities.list_subdistricts('Adana', 'Seyhan')
+# => ["Akkapı", "Denizli" ... "Yeşiloba", "Yeşilyurt", "Ziyapaşa"]
+TurkishCities.list_subdistricts('Eskişehir', 'Odunpazarı')
+# => ["Alanönü", "Arifiye", "Büyükdere" ... "Vişnelik", "Yenikent"]
+TurkishCities.list_subdistricts('Istanbul', 'Beşiktaş')
+# => ["Abbasağa", "Akatlar", "Arnavutköy", "Bebek", "Etiler", "Gayrettepe", "Levazım", "Levent", "Ortaköy", "Türkali"]
+TurkishCities.list_subdistricts('filansehir', 'Beşiktaş')
+# => "Couldn't find district name with 'Beşiktaş' of 'filansehir'"
+TurkishCities.list_subdistricts('İstanbul', 'Kadılarköyü')
+# => "Couldn't find district name with 'Kadılarköyü' of 'İstanbul'"
+```
+
+### Listing all neighborhoods of given city and district
+
+### With subdistrict info
+
+City name can be given case and turkish character insensitive. District name and subdistrict name should be case and turkish character sensitive.(Correct district names can be obtained by ```list_districts``` method. Correct subdistrict names can be obtained by ```list_subdistricts``` method.) Listing of neighborhoods are alphabetically sorted.
+
+```ruby
+TurkishCities.list_neighborhoods('Adana', 'Seyhan', 'Emek')
+# => ["Emek Mah", "Ova Mah", "Şakirpaşa Mah", "Uçak Mah"]
+TurkishCities.list_neighborhoods('Eskişehir', 'Odunpazarı', 'Büyükdere')
+# => ["Büyükdere Mah", "Göztepe Mah", "Gültepe Mah", "Yıldıztepe Mah"]
+TurkishCities.list_neighborhoods('Istanbul', 'Beşiktaş', 'Gayrettepe')
+# => ["Balmumcu Mah", "Dikilitaş Mah", "Gayrettepe Mah", "Yıldız Mah"]
+TurkishCities.list_neighborhoods('Adana', 'Beşiktaş', 'Emek')
+# => "Couldn't find district name with 'Beşiktaş' of 'Adana'"
+```
+
+### Without subdistrict info
+
+Also ```list_neighborhoods``` can work without subdistrict information. This time neighborhoods result will be larger based on searched city and district.
+
+City name can be given case and turkish character insensitive. District name should be case and turkish character sensitive.(Correct district names can be obtained by ```list_districts``` method.) Listing of neighborhoods are alphabetically sorted.
+
+```ruby
+TurkishCities.list_neighborhoods('Adana', 'Seyhan')
+# => ["2000 Evler Mah", "Ahmet Remzi Yüreğir Mah", "Akkapı Mah" ... "Zeytinli Mah", "Ziyapaşa Mah"]
+TurkishCities.list_neighborhoods('Eskişehir', 'Odunpazarı')
+# => ["71 Evler Mah", "75. Yıl Osb Mah" ... "Yukarıkalabak Mah", "Yürükkaracaören Mah", "Yürükkırka Mah"]
+TurkishCities.list_neighborhoods('Istanbul', 'Beşiktaş')
+# => ["Abbasağa Mah", "Akat Mah", "Arnavutköy Mah" ... "Türkali Mah", "Ulus Mah", "Vişnezade Mah", "Yıldız Mah"]
+TurkishCities.list_neighborhoods('İstanbul', 'filanmevki')
+# => "Couldn't find district name with 'filanmevki' of 'İstanbul'"
+```
+
+### Finding city, district and subdistrict name by postcode
+
+In Turkey postcodes are uniq for subdistricts. Basically when a postcode is search through ```find_by_postcode``` it will give city, district and subdistrict information of postcode if valid and found
+
+```ruby
+TurkishCities.find_by_postcode(34380)    # => ["İstanbul", "Şişli", "Cumhuriyet"]
+TurkishCities.find_by_postcode(34433)    # => ["İstanbul", "Beyoğlu", "Cihangir"]
+TurkishCities.find_by_postcode('26040')  # => ["Eskişehir", "Odunpazarı", "Büyükdere"]
+TurkishCities.find_by_postcode(34382)    # => "Couldn't find any subdistrict with postcode '34382'"
+TurkishCities.find_by_postcode('100000') # => Given value [100000] is outside bounds of 1010 to 81952.
+```
+
 ## Compatibility
 
-- ✅ `2.7.0` (stable)
-- ✅ `2.6.3` (stable)
-- ✅ `2.5.5` (stable)
+- ✅ `2.7.1` (stable)
+- ✅ `2.6.6` (stable)
+- ✅ `2.5.8` (stable)
 
-- This gem heavily depends of ```:turkic``` case mapping support of Ruby string downcase method. Below Ruby version 2.5.1 some functions will run buggy/false or even won't run at all.
+- This gem heavily depends on ```:turkic``` case mapping support of Ruby string downcase method. Below Ruby version 2.5.1 some functions will run buggy/false or even won't run at all.
 
 ## Contributing
 

data/lib/turkish_cities/city.rb

@@ -3,7 +3,11 @@
 require 'i18n'
 require 'yaml'
 
+require_relative '../turkish_cities/helpers/decomposer_helper'
+
 class City
+  include DecomposerHelper
+
   I18n.enforce_available_locales = false
 
   file_path = File.join(File.dirname(__FILE__), 'data/cities.yaml')
@@ -28,7 +32,7 @@ class City
         return city['name']
       end
     end
-    "Couldn't find city name with phone code #{phone_code}"
+    city_not_found_error(phone_code)
   end
 
   def find_by_name(city_name, return_type)
@@ -37,7 +41,7 @@ class City
         return return_type == 'plate_number' ? city['plate_number'] : city['phone_code']
       end
     end
-    "Couldn't find city name with '#{city_name}'"
+    city_not_found_error(city_name)
   end
 
   def list_cities(options)
@@ -46,28 +50,25 @@ class City
     city_list = filter_metropolitan_municipalities(city_list) if options[:metropolitan_municipality]
     city_list = filter_regions(city_list, options[:region]) if options[:region]
 
-    final_city_list = prepare_city_list(city_list)
-    options[:alphabetically_sorted] ? sort_cities(final_city_list) : final_city_list
+    final_list = prepare_city_list(city_list, options)
+    options[:alphabetically_sorted] ? sort_alphabetically(final_list, options) : final_list
   end
 
-  private
-
-  def check_input_range(input, min, max)
-    return if input.to_i.between?(min, max)
-
-    raise RangeError, "Given value [#{input}] is outside bounds of #{min} to #{max}."
+  def list_districts(city_name)
+    CITY_LIST.each do |city|
+      return city['districts'] if convert_chars(city['name']) == convert_chars(city_name)
+    end
+    city_not_found_error(city_name)
   end
 
+  private
+
   def check_phone_code(input)
     return if input.to_i.even?
 
     raise ArgumentError, "Given value [#{input}] must be an even number."
   end
 
-  def convert_chars(string)
-    I18n.transliterate(string.downcase(:turkic))
-  end
-
   def filter_metropolitan_municipalities(city_list)
     city_list.map { |city| city unless city['metropolitan_municipality_since'].nil? }.compact
   end
@@ -76,17 +77,4 @@ class City
     region = convert_chars(region.to_s)
     city_list.map { |city| city if convert_chars(city['region']) == region }.compact
   end
-
-  def prepare_city_list(city_list)
-    city_list.map do |city|
-      city['name']
-    end
-  end
-
-  def sort_cities(city_list)
-    turkish_alphabet = ' -abcçdefgğhıijklmnoöprsştuüvyz'
-    city_list.sort_by do |city|
-      city.downcase(:turkic).chars.map { |char| turkish_alphabet.index(char) }
-    end
-  end
 end