turkish_banks 0.5.0 → 0.6.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
-SHA1:
-  metadata.gz: 7a80baf063a00e72b52432962210edf7e968edd0
-  data.tar.gz: 4f766321ddd487b92384e01420dfdea4f491d685
+SHA256:
+  metadata.gz: 507f9a4bb17809fdf68a95947bb937759701a2f4f0267df1efb769187bdcfee8
+  data.tar.gz: 5a6d1c8c8fe43d984b7028f0c41526a898a730bac0dee0b8c1814d02b33b255f
 SHA512:
-  metadata.gz: 217556656643e20256dad4a31eae79666669ab21ca597381d96dce5f97eb9f57cd5f2f7305ea402f7060000c6a91e907a40030bc748274fe8324fe8206b76938
-  data.tar.gz: 8353e29491ea41fd1c0c6de1b7f47d3260107ef2ec4ff7655e9f6f80b83f436b0e19894812871bea9f8ea74b6ddff7e5676ac14ecf64584e36728473625889b5
+  metadata.gz: '08c7a3f09d95afef0e09da7c5980e392e0b8768e9e3ed2e179ea0af90380fa7ae3f986c8b60f5aefea59f5d288121618e7280bb83d3023e67a620ffb606ba893'
+  data.tar.gz: 0163fc54c49b07bb180b940ad2d3219fde863ce77beba7e54c4b2a2677441d24faff68e2ccc24df897ae5dd76dda92bd0ee662a273ec062afc0ffebe13af8313

data/.travis.yml

@@ -1,3 +1,9 @@
 language: ruby
+dist: trusty
 rvm:
-  - 2.2.0
+  - 2.5.5
+  - 2.6.3
+  - 2.7.0
+before_install:
+  - gem install bundler
+script: bundle exec rspec spec

data/Gemfile

@@ -4,6 +4,6 @@ source 'https://rubygems.org'
 gemspec
 
 group :development, :test do
-  gem 'pry', '~> 0.10.0'
-  gem 'rspec', '>= 2.14'
+  gem 'pry', '~> 0.13.1'
+  gem 'rspec', '>= 3.9.0'
 end

data/README.md

@@ -46,11 +46,3 @@ branches.first.name # => "ANKARA ŞUBESİ"
 
 * Improve search part.
 * New features. Please send some pull-request.
-
-## Contributing
-
-1. Fork it ( https://github.com/[my-github-username]/turkish_banks/fork )
-2. Create your feature branch (`git checkout -b my-new-feature`)
-3. Commit your changes (`git commit -am 'Add some feature'`)
-4. Push to the branch (`git push origin my-new-feature`)
-5. Create a new Pull Request

data/lib/turkish_banks/bank.rb

@@ -9,4 +9,4 @@ module TurkishBanks
       @address = bank["adr"]
     end
   end
-end
+end

data/lib/turkish_banks/branch.rb

@@ -1,12 +1,16 @@
 module TurkishBanks
   class Branch < TurkishBank
-    attr_accessor :name, :code, :bank_code, :city
+    attr_accessor :name, :code, :bank_code, :city_code, :city, :district_code, :district, :phone
 
     def initialize(branch)
-      @name      = branch["sAd"]
-      @code      = branch["sKd"]
-      @bank_code = branch["bKd"]
-      @city      = branch["bIlAd"]
+      @name          = branch["sAd"]
+      @code          = branch["sKd"]
+      @bank_code     = branch["bKd"]
+      @city_code     = branch["sIlKd"]
+      @city          = branch["sIlAd"]
+      @district_code = branch["sIlcKd"]
+      @district      = branch["sIlcAd"]
+      @phone         = branch["tlf"]
     end
   end
-end
+end

data/lib/turkish_banks/turkish_bank.rb

@@ -1,14 +1,11 @@
-require "turkish_support"
-
 module TurkishBanks
   class TurkishBank
-    using TurkishSupport
     attr_accessor :last_update_date, :banks
 
     BANKS_URL = "http://eftemkt.tcmb.gov.tr/bankasubelistesi/bankaSubeTumListe.xml".freeze
 
     def initialize
-      doc = Nokogiri.XML(open(BANKS_URL), nil, 'UTF-8')
+      doc = Nokogiri.XML(::OpenURI.open_uri(BANKS_URL), nil, 'UTF-8')
       doc.remove_namespaces!
       response          = Hash.from_xml(doc.to_s)
       @last_update_date = response["bankaSubeTumListe"]["tarih"]
@@ -16,20 +13,27 @@ module TurkishBanks
     end
 
     def get_information_of(bank_name)
+      return "#{bank_name} isminde bir banka bulunamadı." if get_bank(bank_name).empty?
+
       bank = get_bank(bank_name).first["banka"]
       TurkishBanks::Bank.new bank
     end
 
     def get_branches_of(bank_name)
+      return "#{bank_name} isminde bir bankaya ait şube bilgisi bulunamadı." if get_bank(bank_name).empty?
+
+      bank_branches = []
       branches = get_bank(bank_name).first["sube"]
       branches.each do |branch|
-        TurkishBanks::Branch.new branch
+        bank_branches << TurkishBanks::Branch.new(branch)
       end
+      bank_branches
     end
 
     private
+
     def get_bank(bank_name)
-      @banks.select {|b| b["banka"]["bAd"] == bank_name.upcase}
+      @banks.select {|b| b["banka"]["bAd"] == bank_name.upcase(:turkic)}
     end
   end
 end

data/lib/turkish_banks/version.rb

@@ -1,3 +1,3 @@
 module TurkishBanks
-  VERSION = "0.5.0"
+  VERSION = "0.6.0"
 end

data/turkish_banks.gemspec

@@ -4,10 +4,11 @@ $LOAD_PATH.unshift(lib) unless $LOAD_PATH.include?(lib)
 require 'turkish_banks/version'
 
 Gem::Specification.new do |spec|
-  spec.name          = "turkish_banks"
-  spec.version       = TurkishBanks::VERSION
-  spec.authors       = ["Ender Ahmet Yurt"]
-  spec.email         = ["enderyurt@gmail.com"]
+  spec.name                  = "turkish_banks"
+  spec.version               = TurkishBanks::VERSION
+  spec.required_ruby_version = '>= 2.5.1'
+  spec.authors               = ["Ender Ahmet Yurt"]
+  spec.email                 = ["enderyurt@gmail.com"]
 
   # if spec.respond_to?(:metadata)
   #   spec.metadata['allowed_push_host'] = ""
@@ -23,9 +24,8 @@ Gem::Specification.new do |spec|
   spec.executables   = spec.files.grep(%r{^exe/}) { |f| File.basename(f) }
   spec.require_paths = ["lib"]
 
-  spec.add_development_dependency "bundler", "~> 1.8"
-  spec.add_development_dependency "rake", "~> 12.0"
-  spec.add_development_dependency "nokogiri", "~> 1.8.1"
-  spec.add_development_dependency "activesupport"
-  spec.add_development_dependency "turkish_support"
+  spec.add_development_dependency "activesupport", "~> 6.0.2.2"
+  spec.add_development_dependency "bundler", "~> 2.1.4"
+  spec.add_development_dependency "nokogiri", "~> 1.10.9"
+  spec.add_development_dependency "rake", "~> 13.0.0"
 end

metadata

@@ -1,85 +1,71 @@
 --- !ruby/object:Gem::Specification
 name: turkish_banks
 version: !ruby/object:Gem::Version
-  version: 0.5.0
+  version: 0.6.0
 platform: ruby
 authors:
 - Ender Ahmet Yurt
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2018-01-08 00:00:00.000000000 Z
+date: 2020-04-24 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
-  name: bundler
+  name: activesupport
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.8'
+        version: 6.0.2.2
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.8'
+        version: 6.0.2.2
 - !ruby/object:Gem::Dependency
-  name: rake
+  name: bundler
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '12.0'
+        version: 2.1.4
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '12.0'
+        version: 2.1.4
 - !ruby/object:Gem::Dependency
   name: nokogiri
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 1.8.1
+        version: 1.10.9
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 1.8.1
-- !ruby/object:Gem::Dependency
-  name: activesupport
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
+        version: 1.10.9
 - !ruby/object:Gem::Dependency
-  name: turkish_support
+  name: rake
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: 13.0.0
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: 13.0.0
 description: Fetch the all data about Turkish Banks and their branches.
 email:
 - enderyurt@gmail.com
@@ -115,15 +101,14 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
-      version: '0'
+      version: 2.5.1
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubyforge_project: 
-rubygems_version: 2.6.13
+rubygems_version: 3.1.2
 signing_key: 
 specification_version: 4
 summary: Fetch Turkish Banks and their branches.