turkish_banks 0.2.0 → 1.0.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
-SHA1:
-  metadata.gz: 5029ddc0ebe347cd8ad48c7c875fbdbb8a060cf5
-  data.tar.gz: 2ebfbeeb4f1f4aa5eaba5f693023f639b8274b09
+SHA256:
+  metadata.gz: 5a4a1e3454cffe707870cf8ad1b4ae3cd0158b40ff58c3251028063e57c94c85
+  data.tar.gz: '09afc7a80cbb76814f595ebd89113697d28ab8e77a912fff8205a8ed4c2542b1'
 SHA512:
-  metadata.gz: d20970cd9349b14f3ef7101116e859499ab1d9a855047c3f55b5df3120d76b93cf08ced2606b63863f9169aa9591c2c44f8d20efee148d11e46b3997686de330
-  data.tar.gz: c352d024b79c74fa5ac2ebc9df2a38a0433e9533c14b7d56911d7018800247c482ee7116d57353988d7e9ff073b49a62a96db4d8c685152fb701a1218a26ca3a
+  metadata.gz: 8552c337e65bb399cb91cb844d4ee5197e7314b854b59052719741bd84ea2b1ac6ebda409349d54cd43612dc825a310c55b53725243a1c0a2fd1db85d3c123a8
+  data.tar.gz: 636f245cc55b582d2539999788b653515322ff22a238eda3d73c59391eccadfe05a189bc55d1754153a9b25266bb7cd58592ff82fea59777839358f975a42831

data/.gitignore

@@ -7,3 +7,4 @@
 /pkg/
 /spec/reports/
 /tmp/
+/.idea/

data/.travis.yml

@@ -1,3 +1,9 @@
 language: ruby
+dist: trusty
 rvm:
-  - 2.2.0
+  - 2.5.5
+  - 2.6.3
+  - 2.7.0
+before_install:
+  - gem install bundler
+script: bundle exec rspec spec

data/Gemfile

@@ -4,6 +4,6 @@ source 'https://rubygems.org'
 gemspec
 
 group :development, :test do
-  gem 'pry', '~> 0.9.12'
-  gem 'rspec', '>= 2.14'
+  gem 'pry', '~> 0.13.1'
+  gem 'rspec', '>= 3.9.0'
 end

data/README.md

@@ -24,33 +24,34 @@ Or install it yourself as:
 ## Usage
 
 ```ruby
-# Creates a TurkishBank object
-turkish_bank = TurkishBanks::TurkishBank.new
-
 # Gets last update date
-turkish_bank.last_update_date
+TurkishBanks::LAST_UPDATE
 
 # Gets all banks
-turkish_bank.banks
+TurkishBanks.banks
 
-# Returns a bank object
-bank = turkish_bank.get_information_of "türkiye cumhuriyeti ziraat bankası a.ş."
-bank.name # => TÜRKİYE CUMHURİYETİ ZIRAAT BANKASI A.Ş.
+# Create a bank from its name
+bank = TurkishBanks::Bank.new("türkiye cumhuriyeti ziraat bankası a.ş.")
+bank.name # => "TÜRKİYE CUMHURİYETİ ZIRAAT BANKASI A.Ş."
 
-# Returns a collection of branch objectes
-branches = turkish_bank.get_branches_of "türkiye cumhuriyeti ziraat bankası a.ş."
-branches.first.name # => "ANKARA ŞUBESİ"
-```    
+# Get a collection of branch objects
+branches = bank.branches
+branches.first.name # => "MERKEZ/ANKARA ŞUBESİ"
+branches.size       # => 1791
+```
 
-## TODO
+## Exception Handling
 
-* Improve search part.
-* New features. Please send some pull-request.
+If you pass the wrong bank name to `Bank#new`, it raises `TurkishBanks::BankNotFoundError` exception. You can rescue this error, then do something else.
 
-## Contributing
+```ruby
+begin
+  TurkishBanks::Bank.new('fake bank')
+rescue TurkishBanks::BankNotFoundError
+  # do something here
+end
+``` 
 
-1. Fork it ( https://github.com/[my-github-username]/turkish_banks/fork )
-2. Create your feature branch (`git checkout -b my-new-feature`)
-3. Commit your changes (`git commit -am 'Add some feature'`)
-4. Push to the branch (`git push origin my-new-feature`)
-5. Create a new Pull Request
+## TODO
+* Improve search part.
+* New features. Please send some pull-request.

data/lib/turkish_banks.rb

@@ -1,13 +1,13 @@
-require "active_support/core_ext/hash"
+require 'active_support/core_ext/hash'
 
-require "rubygems"
-require "open-uri"
-require "nokogiri"
-require "turkish_banks/version"
+require 'rubygems'
+require 'open-uri'
+require 'nokogiri'
+require 'turkish_banks/version'
 
-require "turkish_banks/turkish_bank"
-require "turkish_banks/bank"
-require "turkish_banks/branch"
+require 'turkish_banks/turkish_banks'
+require 'turkish_banks/branch'
+require 'turkish_banks/bank'
 
 module TurkishBanks
 end

data/lib/turkish_banks/bank.rb

@@ -1,12 +1,21 @@
 module TurkishBanks
-  class Bank < TurkishBank
-    attr_accessor :name, :code, :city, :address
-    
-    def initialize bank
-      @name    = bank["bAd"]
-      @code    = bank["bKd"]
-      @city    = bank["bIlAd"]
-      @address = bank["adr"]
+  class Bank
+    attr_reader :name, :code, :city, :address
+
+    def initialize(bank_name)
+      bank_params = TurkishBanks.get_bank_params(bank_name)
+      @name    = bank_params['bAd']
+      @code    = bank_params['bKd']
+      @city    = bank_params['bIlAd']
+      @address = bank_params['adr']
+    end
+
+    def branches
+      nodes = TurkishBanks::DOC.xpath("//sube[bKd= '#{@code}']")
+      nodes.map do |node|
+        branch_params = Hash.from_xml(node.to_s)['sube']
+        TurkishBanks::Branch.new(branch_params)
+      end
     end
   end
-end
+end

data/lib/turkish_banks/branch.rb

@@ -1,12 +1,17 @@
 module TurkishBanks
-  class Branch < TurkishBank
-    attr_accessor :name, :code, :bank_code, :city
-    
-    def initialize branch
-      @name      = branch["sAd"]
-      @code      = branch["sKd"]
-      @bank_code = branch["bKd"]
-      @city      = branch["bIlAd"]
+  class Branch
+    attr_reader :name, :code, :bank_code, :city_code,
+                :city, :district_code, :district, :phone
+
+    def initialize(branch_params)
+      @name          = branch_params['sAd']
+      @code          = branch_params['sKd']
+      @bank_code     = branch_params['bKd']
+      @city_code     = branch_params['sIlKd']
+      @city          = branch_params['sIlAd']
+      @district_code = branch_params['sIlcKd']
+      @district      = branch_params['sIlcAd']
+      @phone         = branch_params['tlf']
     end
   end
-end
+end

data/lib/turkish_banks/turkish_banks.rb

@@ -0,0 +1,25 @@
+module TurkishBanks
+  class BankNotFoundError < StandardError
+    def message
+      'Banka bulunamadı.'
+    end
+  end
+
+  BANKS_URL = 'http://eftemkt.tcmb.gov.tr/bankasubelistesi/bankaSubeTumListe.xml'.freeze
+  DOC = Nokogiri
+        .XML(::OpenURI.open_uri(BANKS_URL), nil, 'UTF-8')
+        .remove_namespaces!.freeze
+  LAST_UPDATE = DOC.at_xpath('//bankaSubeTumListe')['tarih'].freeze
+
+  def self.get_bank_params(bank_name)
+    node = DOC.at_xpath("//banka[bAd= '#{bank_name.upcase(:turkic)}']")
+    raise BankNotFoundError if node.nil?
+
+    Hash.from_xml(node.to_s)['banka']
+  end
+
+  def self.banks
+    nodes = DOC.xpath('//banka')
+    nodes.each.map { |node| Hash.from_xml(node.to_s)['banka'] }
+  end
+end

data/lib/turkish_banks/version.rb

@@ -1,3 +1,3 @@
 module TurkishBanks
-  VERSION = "0.2.0"
+  VERSION = "1.0.0"
 end

data/turkish_banks.gemspec

@@ -4,10 +4,11 @@ $LOAD_PATH.unshift(lib) unless $LOAD_PATH.include?(lib)
 require 'turkish_banks/version'
 
 Gem::Specification.new do |spec|
-  spec.name          = "turkish_banks"
-  spec.version       = TurkishBanks::VERSION
-  spec.authors       = ["Ender Ahmet Yurt"]
-  spec.email         = ["enderyurt@gmail.com"]
+  spec.name                  = "turkish_banks"
+  spec.version               = TurkishBanks::VERSION
+  spec.required_ruby_version = '>= 2.5.1'
+  spec.authors               = ["Ender Ahmet Yurt"]
+  spec.email                 = ["enderyurt@gmail.com"]
 
   # if spec.respond_to?(:metadata)
   #   spec.metadata['allowed_push_host'] = ""
@@ -23,9 +24,8 @@ Gem::Specification.new do |spec|
   spec.executables   = spec.files.grep(%r{^exe/}) { |f| File.basename(f) }
   spec.require_paths = ["lib"]
 
-  spec.add_development_dependency "bundler", "~> 1.8"
-  spec.add_development_dependency "rake", "~> 10.0"
-  spec.add_development_dependency "nokogiri", "~> 1.6.0"
-  spec.add_development_dependency "activesupport"
-  spec.add_development_dependency "turkish_support"
+  spec.add_development_dependency "activesupport", ">= 6.0.3.1"
+  spec.add_development_dependency "bundler", "~> 2.1.4"
+  spec.add_development_dependency "nokogiri", "~> 1.10.9"
+  spec.add_development_dependency "rake", "~> 13.0.0"
 end

metadata

@@ -1,85 +1,71 @@
 --- !ruby/object:Gem::Specification
 name: turkish_banks
 version: !ruby/object:Gem::Version
-  version: 0.2.0
+  version: 1.0.0
 platform: ruby
 authors:
 - Ender Ahmet Yurt
-autorequire: 
+autorequire:
 bindir: exe
 cert_chain: []
-date: 2015-03-05 00:00:00.000000000 Z
+date: 2020-11-18 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
-  name: bundler
+  name: activesupport
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '1.8'
+        version: 6.0.3.1
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '1.8'
+        version: 6.0.3.1
 - !ruby/object:Gem::Dependency
-  name: rake
+  name: bundler
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '10.0'
+        version: 2.1.4
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '10.0'
+        version: 2.1.4
 - !ruby/object:Gem::Dependency
   name: nokogiri
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 1.6.0
+        version: 1.10.9
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 1.6.0
-- !ruby/object:Gem::Dependency
-  name: activesupport
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
+        version: 1.10.9
 - !ruby/object:Gem::Dependency
-  name: turkish_support
+  name: rake
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: 13.0.0
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: 13.0.0
 description: Fetch the all data about Turkish Banks and their branches.
 email:
 - enderyurt@gmail.com
@@ -100,15 +86,14 @@ files:
 - lib/turkish_banks.rb
 - lib/turkish_banks/bank.rb
 - lib/turkish_banks/branch.rb
-- lib/turkish_banks/turkish_bank.rb
+- lib/turkish_banks/turkish_banks.rb
 - lib/turkish_banks/version.rb
-- turkish_banks-0.1.0.gem
 - turkish_banks.gemspec
 homepage: https://github.com/enderahmetyurt/turkish_banks
 licenses:
 - MIT
 metadata: {}
-post_install_message: 
+post_install_message:
 rdoc_options: []
 require_paths:
 - lib
@@ -116,17 +101,15 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
-      version: '0'
+      version: 2.5.1
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubyforge_project: 
-rubygems_version: 2.2.1
-signing_key: 
+rubygems_version: 3.1.4
+signing_key:
 specification_version: 4
 summary: Fetch Turkish Banks and their branches.
 test_files: []
-has_rdoc: 

data/lib/turkish_banks/turkish_bank.rb

@@ -1,36 +0,0 @@
-require "turkish_support"
-
-module TurkishBanks
-  class TurkishBank
-    using TurkishSupport
-    attr_accessor :last_update_date, :banks
-
-    BANKS_URL = "http://eft.tcmb.gov.tr/bankasubelistesi/bankaSubeTumListe.xml"    
-    
-    def initialize
-      doc = Nokogiri.XML(open(BANKS_URL), nil, 'UTF-8')
-      doc.remove_namespaces!
-      response = Hash.from_xml(doc.to_s)
-      @last_update_date = response["bankaSubeTumListe"]["tarih"]
-      @banks = response["bankaSubeTumListe"]["bankaSubeleri"]
-    end
-
-    def get_information_of bank_name
-      bank = get_bank(bank_name).first["banka"]
-      TurkishBanks::Bank.new bank
-    end
-
-    def get_branches_of bank_name
-      branches = get_bank(bank_name).first["sube"]
-      branches.each do |branch|
-        TurkishBanks::Branch.new branch
-      end
-    end
-
-    private
-
-    def get_bank bank_name
-      @banks.select {|b| b["banka"]["bAd"] == bank_name.upcase}
-    end
-  end
-end