turbot 0.1.36 → 0.2.3

data/spec/support/command_helper.rb

@@ -0,0 +1,20 @@
+module CommandHelper
+  def execute(command_line)
+    original_stderr, original_stdout = $stderr, $stdout
+
+    $stderr = captured_stderr = StringIO.new
+    $stdout = captured_stdout = StringIO.new
+
+    begin
+      Turbot::CLI.start(*command_line.split(' '))
+    rescue Exception => e
+      unless SystemExit === e
+        p e
+      end
+    ensure
+      $stderr, $stdout = original_stderr, original_stdout
+    end
+
+    [captured_stderr.string, captured_stdout.string]
+  end
+end

data/spec/support/custom_matchers.rb

@@ -0,0 +1,5 @@
+RSpec::Matchers.define :equal_lines do |expected|
+  match do |actual|
+    actual.split(/\r?\n/) == expected.split(/\r?\n/)
+  end
+end

data/spec/support/fixture_helper.rb

@@ -0,0 +1,9 @@
+module FixtureHelper
+  def fixture(path, chmod = 0600)
+    filename = File.expand_path(File.join('..', '..', 'fixtures', path), __FILE__)
+    if File.exist?(filename)
+      FileUtils.chmod(chmod, filename)
+    end
+    filename
+  end
+end

data/spec/support/netrc_helper.rb

@@ -0,0 +1,21 @@
+module NetrcHelper
+  def spec_open_netrc
+    Netrc.read(Netrc.default_path)
+  end
+
+  def spec_save_netrc_entry(data)
+    netrc = spec_open_netrc
+    netrc['api.http://turbot.opencorporates.com'] = data
+    netrc.save
+  end
+
+  def spec_delete_netrc_entry
+    netrc = spec_open_netrc
+    netrc.delete('api.http://turbot.opencorporates.com')
+    netrc.save
+  end
+
+  def spec_read_netrc
+    spec_open_netrc['api.http://turbot.opencorporates.com']
+  end
+end

data/spec/turbot/command/auth_spec.rb

@@ -1,38 +1,220 @@
-require "spec_helper"
-require "turbot/command/auth"
+require 'spec_helper'
+require 'turbot/command/auth'
 
 describe Turbot::Command::Auth do
-  describe "auth" do
-    it "displays turbot help auth" do
-      stderr, stdout = execute("auth")
+  describe 'auth' do
+    it 'displays help for auth commands' do
+      stderr, stdout = execute('auth')
 
-      stderr.should == ""
-      stdout.should include "Additional commands"
-      stdout.should include "auth:login"
-      stdout.should include "auth:logout"
+      expect(stderr).to eq('')
+      expect(stdout).to include('turbot auth')
+      expect(stdout).to include('Additional commands')
+      expect(stdout).to include('auth:whoami')
     end
   end
 
-  describe "auth:token" do
+  context 'when editing the .netrc file' do
+    before do
+      allow(Netrc).to receive(:default_path).and_return(fixture('writable'))
+    end
 
-    it "displays the user's api key" do
-      stderr, stdout = execute("auth:token")
-      stderr.should == ""
-      stdout.should == <<-STDOUT
-apikey01
+    describe 'auth:login' do
+      it 'logs the user in' do
+        stub_request(:get, 'http://turbot.opencorporates.com/api/user/api_key?api_key=&email=email@example.com&password=password').to_return({
+          :status => 200,
+          :body => JSON.dump('api_key' => 'apikey01'),
+        })
+        stub_request(:get, 'http://turbot.opencorporates.com/api/user?api_key=apikey01').to_return({
+          :status => 200,
+          :body => JSON.dump('api_key' => 'apikey01'),
+        })
+        allow(STDIN).to receive(:gets).and_return('email@example.com', 'password')
+        allow_any_instance_of(Turbot::Command::Auth).to receive(:ask_for_password_on_windows).and_return('password')
+
+        spec_delete_netrc_entry
+
+        stderr, stdout = execute('auth:login')
+
+        expect(spec_read_netrc.to_a).to eq(['email@example.com', 'apikey01'])
+
+        expect(stderr).to eq('')
+        expect(stdout).to eq <<-STDOUT
+Enter your Turbot email and password.
+Email: Password (typing will be hidden): 
+Authentication successful.
+STDOUT
+      end
+
+      it 'displays an error message' do
+        stub_request(:get, 'http://turbot.opencorporates.com/api/user/api_key?api_key=&email=&password=').to_return(:status => 200, :body => '{"api_key":""}')
+        allow(STDIN).to receive(:gets).and_return('', '')
+        allow_any_instance_of(Turbot::Command::Auth).to receive(:ask_for_password_on_windows).and_return('')
+
+        spec_delete_netrc_entry
+
+        stderr, stdout = execute('auth:login')
+
+        expect(spec_read_netrc).to eq(nil)
+
+        expect(stdout).to eq <<-STDOUT
+Enter your Turbot email and password.
+Email: Password (typing will be hidden): 
 STDOUT
+        expect(stderr).to eq <<-STDERR
+ !    Authentication failed.
+STDERR
+      end
+    end
+
+    describe 'auth:logout' do
+      it 'logs the user out' do
+        spec_save_netrc_entry(['user', 'pass'])
+
+        stderr, stdout = execute('auth:logout')
+
+        expect(spec_read_netrc).to eq(nil)
+
+        expect(stderr).to eq('')
+        expect(stdout).to eq <<-STDOUT
+Deleted Turbot credentials.
+STDOUT
+      end
     end
   end
 
-  describe "auth:whoami" do
-    it "displays the user's email address" do
-      stderr, stdout = execute("auth:whoami")
-      stderr.should == ""
-      stdout.should == <<-STDOUT
+  context 'when logged in' do
+    before do
+      allow(Netrc).to receive(:default_path).and_return(fixture('netrc'))
+    end
+
+    describe 'auth:token' do
+      it "displays the user's api key" do
+        stderr, stdout = execute('auth:token')
+
+        expect(stderr).to eq('')
+        expect(stdout).to eq <<-STDOUT
+apikey01
+STDOUT
+      end
+    end
+
+    describe 'auth:whoami' do
+      it "displays the user's email address" do
+        stderr, stdout = execute('auth:whoami')
+
+        expect(stderr).to eq('')
+        expect(stdout).to eq <<-STDOUT
 email@example.com
 STDOUT
+      end
     end
 
+    context 'with TURBOT_HOST set' do
+      around(:each) do |example|
+        ENV['TURBOT_HOST'] = 'http://turbot.example.com'
+        example.run
+        ENV['TURBOT_HOST'] = nil
+      end
+
+      describe 'auth:token' do
+        it "displays the user's api key" do
+          stderr, stdout = execute('auth:token')
+
+          expect(stderr).to eq('')
+          expect(stdout).to eq <<-STDOUT
+apikey02
+STDOUT
+        end
+      end
+
+      describe 'auth:whoami' do
+        it "displays the user's email address" do
+          stderr, stdout = execute('auth:whoami')
+
+          expect(stderr).to eq('')
+          expect(stdout).to eq <<-STDOUT
+example@email.com
+STDOUT
+        end
+      end
+    end
+
+    context 'with TURBOT_API_KEY set' do
+      around(:each) do |example|
+        ENV['TURBOT_API_KEY'] = 'apikey99'
+        example.run
+        ENV['TURBOT_API_KEY'] = nil
+      end
+
+      describe 'auth:token' do
+        it "displays the user's api key" do
+          stderr, stdout = execute('auth:token')
+
+          expect(stderr).to eq('')
+          expect(stdout).to eq <<-STDOUT
+apikey99
+STDOUT
+        end
+      end
+
+      describe 'auth:whoami' do
+        it "displays nothing" do
+          stderr, stdout = execute('auth:whoami')
+
+          expect(stderr).to eq('')
+          expect(stdout).to eq <<-STDOUT
+
+STDOUT
+        end
+      end
+    end
   end
 
+  context 'when logged out' do
+    ['empty', 'nonexistent'].each do |path|
+      before do
+        allow(Netrc).to receive(:default_path).and_return(fixture(path))
+      end
+
+      describe 'auth:token' do
+        it 'displays an error message' do
+          stderr, stdout = execute('auth:token')
+
+          expect(stdout).to eq('')
+          expect(stderr).to eq <<-STDERR
+ !    not logged in
+STDERR
+        end
+      end
+
+      describe 'auth:whoami' do
+        it 'displays an error message' do
+          stderr, stdout = execute('auth:whoami')
+
+          expect(stdout).to eq('')
+          expect(stderr).to eq <<-STDERR
+ !    not logged in
+STDERR
+        end
+      end
+    end
+  end
+
+  # Windows NTFS and FAT don't support `File.chmod`.
+  unless RUBY_PLATFORM =~ /mswin32|mingw32/
+    context 'with a bad .netrc file' do
+      before do
+        allow(Netrc).to receive(:default_path).and_return(fixture('bad_permissions', 0644))
+      end
+
+      describe 'auth:whoami' do
+        it 'displays an error message' do
+          stderr, stdout = execute('auth:whoami')
+
+          expect(stdout).to eq('')
+          expect(stderr).to match(%r{\A !    Permission bits for '.+/spec/fixtures/bad_permissions' should be 0600, but are 644\n\z})
+        end
+      end
+    end
+  end
 end

data/spec/turbot/command/base_spec.rb

@@ -1,66 +1,30 @@
-require "spec_helper"
-require "turbot/command/base"
+require 'spec_helper'
 
-module Turbot::Command
-  describe Base do
-    before do
-      @base = Base.new
-      @base.stub!(:display)
-      @client = mock('turbot client', :host => 'turbot.com')
-    end
-
-    describe "confirming" do
-      it "confirms the bot via --confirm" do
-        Turbot::Command.stub(:current_options).and_return(:confirm => "example")
-        @base.stub(:bot).and_return("example")
-        @base.confirm_command.should be_true
-      end
-
-      it "does not confirms the bot via --confirm on a mismatch" do
-        Turbot::Command.stub(:current_options).and_return(:confirm => "badapp")
-        @base.stub(:bot).and_return("example")
-        lambda { @base.confirm_command}.should raise_error CommandFailed
-      end
-
-      it "confirms the bot interactively via ask" do
-        @base.stub(:bot).and_return("example")
-        @base.stub(:ask).and_return("example")
-        Turbot::Command.stub(:current_options).and_return({})
-        @base.confirm_command.should be_true
-      end
+describe Turbot::Command::Base do
+  before do
+    allow(subject).to receive(:display)
+    @client = double('turbot client', :host => 'turbot.com')
+  end
 
-      it "fails if the interactive confirm doesn't match" do
-        @base.stub(:bot).and_return("example")
-        @base.stub(:ask).and_return("badresponse")
-        Turbot::Command.stub(:current_options).and_return({})
-        capture_stderr do
-          lambda { @base.confirm_command }.should raise_error(SystemExit)
-        end.should == <<-STDERR
- !    Confirmation did not match example. Aborted.
-STDERR
-      end
+  context 'detecting the bot' do
+    it 'attempts to find the bot via the --bot option' do
+      allow(subject).to receive(:options).and_return(:bot => 'example')
+      expect(subject.bot).to eq('example')
     end
 
-    context "detecting the bot" do
-      it "attempts to find the bot via the --bot option" do
-        @base.stub!(:options).and_return(:bot => "example")
-        @base.bot.should == "example"
-      end
-
-      it "attempts to find the bot via TURBOT_BOT when not explicitly specified" do
-        ENV['TURBOT_BOT'] = "myenvapp"
-        @base.bot.should == "myenvapp"
-        @base.stub!(:options).and_return([])
-        @base.bot.should == "myenvapp"
-        ENV.delete('TURBOT_BOT')
-      end
+    it 'attempts to find the bot via TURBOT_BOT when not explicitly specified' do
+      ENV['TURBOT_BOT'] = 'myenvapp'
+      expect(subject.bot).to eq('myenvapp')
+      allow(subject).to receive(:options).and_return([])
+      expect(subject.bot).to eq('myenvapp')
+      ENV.delete('TURBOT_BOT')
+    end
 
-      it "overrides TURBOT_BOT when explicitly specified" do
-        ENV['TURBOT_BOT'] = "myenvapp"
-        @base.stub!(:options).and_return(:bot => "example")
-        @base.bot.should == "example"
-        ENV.delete('TURBOT_BOT')
-      end
+    it 'overrides TURBOT_BOT when explicitly specified' do
+      ENV['TURBOT_BOT'] = 'myenvapp'
+      allow(subject).to receive(:options).and_return(:bot => 'example')
+      expect(subject.bot).to eq('example')
+      ENV.delete('TURBOT_BOT')
     end
   end
 end

data/spec/turbot/command/bots_spec.rb

@@ -1,133 +1,624 @@
-require "spec_helper"
-require "turbot/command/bots"
+require 'spec_helper'
+require 'turbot/command/bots'
+require 'turbot_runner'
 
 describe Turbot::Command::Bots do
-  describe "validate" do
-    let :working_directory do
-      Dir.mktmpdir
+  context 'when unauthenticated' do
+    before do
+      allow(Netrc).to receive(:default_path).and_return(fixture('empty'))
     end
 
-    let :schemas_directory do
-      Dir.mktmpdir
+    describe 'bots' do
+      it 'lists no bots' do
+        stub_request(:get, 'http://turbot.opencorporates.com/api/bots?api_key=').to_return({
+          :status => 401,
+          :body => JSON.dump('message' => 'No API key provided'),
+        })
+
+        stderr, stdout = execute('bots')
+
+        expect(stdout).to eq('')
+        expect(stderr).to eq <<-STDERR
+ !    No API key provided (HTTP 401)
+STDERR
+      end
     end
+  end
 
+  context 'when authenticated' do
     before do
-      config = {
-        'bot_id' => 'dummy bot',
-        'data_type' => 'dummy',
-        'identifying_fields' => ['name'],
-        'files' => 'scraper.rb',
-        'language' => 'ruby',
-        'publisher' => {
-          'name' => 'Dummy',
-          'url' => 'http://example.com/',
-          'terms' => 'MIT',
-          'terms_url' => 'http://opensource.org/licenses/MIT',
-        },
-      }
-      Turbot::Command::Bots.any_instance.stub(:parsed_manifest).and_return(config)
-
-      # Create a manifest.json file for TurbotRunner to find.
-      File.open(File.join(working_directory, 'manifest.json'), 'w') { |f| f << JSON.dump(config) }
-      Turbot::Command::Bots.any_instance.stub(:working_directory).and_return(working_directory)
-
-      # Change the path to TurbotRunner's schemas.
-      begin
-        old_verbose, $VERBOSE = $VERBOSE, nil
-        TurbotRunner::SCHEMAS_PATH = File.expand_path('../../../schemas', __FILE__)
-      ensure
-        $VERBOSE = old_verbose
+      allow(Netrc).to receive(:default_path).and_return(fixture('netrc'))
+    end
+
+    describe 'bots' do
+      it 'lists bots' do
+        stub_request(:get, 'http://turbot.opencorporates.com/api/bots?api_key=apikey01').to_return({
+          :status => 200,
+          :body => JSON.dump({
+            'data' => [{
+              'bot_id' => 'dummy_bot',
+              'created_at' => '2010-01-01T00:00:00.000Z',
+              'updated_at' => '2010-01-02T00:00:00.000Z',
+              'state' => 'scheduled',
+            }],
+          }),
+        })
+
+        stderr, stdout = execute('bots')
+
+        expect(stderr).to eq('')
+        expect(stdout).to eq <<-STDOUT
+dummy_bot
+STDOUT
+      end
+
+      it 'lists no bots' do
+        stub_request(:get, 'http://turbot.opencorporates.com/api/bots?api_key=apikey01').to_return({
+          :status => 200,
+          :body => JSON.dump('data' => []),
+        })
+
+        stderr, stdout = execute('bots')
+
+        expect(stderr).to eq('')
+        expect(stdout).to eq <<-STDOUT
+You have no bots.
+STDOUT
       end
     end
 
-    after do
-      FileUtils.remove_entry_secure(working_directory)
-      FileUtils.remove_entry_secure(schemas_directory)
+    describe 'bots:info' do
+      it "shows the given bot's details" do
+        stub_bot_info
+
+        stderr, stdout = execute('bots:info --bot example')
+
+        expect(stderr).to eq('')
+        expect(stdout).to eq <<-STDOUT
+bot_id: dummy_bot
+created_at: 2010-01-01T00:00:00.000Z
+updated_at: 2010-01-02T00:00:00.000Z
+state: scheduled
+STDOUT
+      end
+
+      it "shows the inferred bot's details" do
+        stub_bot_info
+
+        bot_directory = create_bot_directory
+        create_manifest_file(bot_directory)
+
+        stderr, stdout = execute_in_directory('bots:info', bot_directory)
+
+        expect(stderr).to eq('')
+        expect(stdout).to eq <<-STDOUT
+bot_id: dummy_bot
+created_at: 2010-01-01T00:00:00.000Z
+updated_at: 2010-01-02T00:00:00.000Z
+state: scheduled
+STDOUT
+      end
+
+      it 'errors if no local bot is found' do
+        stderr, stdout = execute('bots:info')
+
+        expect(stdout).to eq('')
+        expect(stderr).to eq <<-STDERR
+ !    No bot specified.
+ !    Run this command from a bot directory containing a `manifest.json` file, or specify the bot with --bot BOT.
+STDERR
+      end
+
+      it 'errors if no bot exists in Turbot' do
+        stub_bot_info_error
+
+        stderr, stdout = execute('bots:info --bot example')
+
+        expect(stdout).to eq('')
+        expect(stderr).to eq <<-STDERR
+ !    No bot registered for bot_id example
+ !    If you have renamed your bot, ... (HTTP 402: bot-not-found)
+STDERR
+      end
     end
 
-    def define_scraper(hash)
-      File.open(File.join(working_directory, 'scraper.rb'), 'w') do |f|
-        f << <<-EOL
-require 'json'
-puts JSON.dump(#{hash})
-        EOL
+    describe 'bots:generate' do
+      it 'generates a Ruby bot template' do
+        stub_bot_info_error('rb')
+
+        working_directory = Dir.mktmpdir
+
+        stderr, stdout = execute_in_directory('bots:generate --bot rb', working_directory)
+
+        expect(stderr).to eq('')
+        expect(stdout).to eq <<-STDOUT
+Created new bot template for rb!
+STDOUT
+
+        expect(File.exist?(File.join(working_directory, 'rb', 'LICENSE.txt'))).to eq(true)
+        expect(File.exist?(File.join(working_directory, 'rb', 'manifest.json'))).to eq(true)
+        expect(File.exist?(File.join(working_directory, 'rb', 'scraper.rb'))).to eq(true)
+      end
+
+      it 'generates a Python bot template' do
+        stub_bot_info_error('py')
+
+        working_directory = Dir.mktmpdir
+
+        stderr, stdout = execute_in_directory('bots:generate --bot py --language python', working_directory)
+
+        expect(stderr).to eq('')
+        expect(stdout).to eq <<-STDOUT
+Created new bot template for py!
+STDOUT
+
+        expect(File.exist?(File.join(working_directory, 'py', 'LICENSE.txt'))).to eq(true)
+        expect(File.exist?(File.join(working_directory, 'py', 'manifest.json'))).to eq(true)
+        expect(File.exist?(File.join(working_directory, 'py', 'scraper.py'))).to eq(true)
+      end
+
+      it 'errors if the bot exists in Turbot' do
+        stub_bot_info
+
+        stderr, stdout = execute('bots:generate --bot example')
+
+        expect(stdout).to eq('')
+        expect(stderr).to eq <<-STDERR
+ !    There's already a bot named example in Turbot. Try another name.
+STDERR
+      end
+
+      it 'errors if the bot name is invalid' do
+        stub_bot_info_error('example!')
+
+        stderr, stdout = execute('bots:generate --bot example!')
+
+        expect(stdout).to eq('')
+        expect(stderr).to include('The bot name example! is invalid.')
+      end
+
+      it 'errors if the directory exists' do
+        stub_bot_info_error
+
+        working_directory = Dir.mktmpdir
+        bot_directory = create_bot_directory(working_directory)
+
+        stderr, stdout = execute_in_directory('bots:generate --bot example', working_directory)
+
+        expect(stdout).to eq('')
+        expect(stderr).to eq <<-STDERR
+ !    There's already a directory named example. Move it, delete it, change directory, or try another name.
+STDERR
+      end
+
+      it 'errors if the language is unsupported' do
+        stub_bot_info_error
+
+        stderr, stdout = execute('bots:generate --bot example --language go')
+
+        expect(stdout).to eq('')
+        expect(stderr).to eq <<-STDOUT
+ !    The language go is unsupported.
+STDOUT
       end
     end
 
-    context "for data_type with schema" do
-      it "says bot is valid if its output matches the schema" do
-        define_scraper(name: 'One')
+    describe 'bots:register' do
+      it 'registers the bot' do
+        stub_bot_info_error
+        stub_request(:post, 'http://turbot.opencorporates.com/api/bots').to_return(:status => 200, :body => '{}')
 
-        stderr, stdout = execute("bots:validate")
+        bot_directory = create_bot_directory
+        create_manifest_file(bot_directory)
 
-        stdout.should include 'Validated 1 records!'
-        stderr.should == ""
+        stderr, stdout = execute_in_directory('bots:register', bot_directory)
+
+        expect(stderr).to eq('')
+        expect(stdout).to eq <<-STDOUT
+Registered example!
+STDOUT
       end
 
-      it "says bot is invalid if its output doesn't match the schema" do
-        define_scraper(name: 123)
+      it 'errors if no local bot is found' do
+        stub_bot_info_error
 
-        stderr, stdout = execute("bots:validate")
+        stderr, stdout = execute('bots:register')
 
-        stdout.should include 'Property of wrong type'
-        stderr.should == ""
+        expect(stdout).to eq('')
+        expect(stderr).to eq <<-STDERR
+ !    No bot specified.
+ !    Run this command from a bot directory containing a `manifest.json` file, or specify the bot with --bot BOT.
+STDERR
       end
 
-      context "for bot that doesn't output identifying fields" do
-        it "says bot is invalid" do
-          define_scraper(title: 'One')
+      it 'errors if the bot exists in Turbot' do
+        stub_bot_info
 
-          stderr, stdout = execute("bots:validate")
+        bot_directory = create_bot_directory
+        create_manifest_file(bot_directory)
 
-          stdout.should include 'There were no values provided for any of the identifying fields'
-          stderr.should == ""
-        end
+        stderr, stdout = execute_in_directory('bots:register', bot_directory)
+
+        expect(stdout).to eq('')
+        expect(stderr).to eq <<-STDERR
+ !    There's already a bot named example in Turbot. Try another name.
+STDERR
+      end
+    end
+
+    describe 'bots:push' do
+      it 'pushes to Turbot' do
+        allow(STDIN).to receive(:gets).and_return('y')
+        stub_request(:put, 'http://turbot.opencorporates.com/api/bots/example/code').to_return(:status => 200, :body => '{}')
+
+        bot_directory = create_bot_directory
+        create_manifest_file(bot_directory)
+        create_scraper_file(bot_directory)
+
+        stderr, stdout = execute_in_directory('bots:push', bot_directory)
+
+        expect(stderr).to eq('')
+        expect(stdout).to eq <<-STDOUT
+This will submit your bot and its data for review.
+Are you happy your bot produces valid data (e.g. with `turbot bots:validate`)? [Y/n]
+Your bot has been pushed to Turbot and will be reviewed for inclusion as soon as we can. THANK YOU!
+STDOUT
+      end
+
+      it 'skips confirmation' do
+        allow(STDIN).to receive(:gets).and_return('y')
+        stub_request(:put, 'http://turbot.opencorporates.com/api/bots/example/code').to_return(:status => 200, :body => '{}')
+
+        bot_directory = create_bot_directory
+        create_manifest_file(bot_directory)
+        create_scraper_file(bot_directory)
+
+        stderr, stdout = execute_in_directory('bots:push --yes', bot_directory)
+
+        expect(stderr).to eq('')
+        expect(stdout).to eq <<-STDOUT
+Your bot has been pushed to Turbot and will be reviewed for inclusion as soon as we can. THANK YOU!
+STDOUT
+      end
+
+      it 'errors if no local bot is found' do
+        stderr, stdout = execute('bots:push')
+
+        expect(stdout).to eq('')
+        expect(stderr).to eq <<-STDERR
+ !    No bot specified.
+ !    Run this command from a bot directory containing a `manifest.json` file, or specify the bot with --bot BOT.
+STDERR
+      end
+
+      it 'aborts if push not confirmed' do
+        allow(STDIN).to receive(:gets).and_return('n')
+
+        bot_directory = create_bot_directory
+        create_manifest_file(bot_directory)
+
+        stderr, stdout = execute_in_directory('bots:push', bot_directory)
+
+        expect(stdout).to eq <<-STDOUT
+This will submit your bot and its data for review.
+Are you happy your bot produces valid data (e.g. with `turbot bots:validate`)? [Y/n]
+STDOUT
+        expect(stderr).to eq <<-STDERR
+ !    Aborted.
+STDERR
       end
     end
 
-    context "for data_type without schema" do
-      it "says bot is invalid" do
-        define_scraper({})
+    describe 'bots:validate' do
+      before do
+        set_turbot_runner_schemas
+      end
+
+      it 'validates valid records' do
+        bot_directory = create_bot_directory
+        create_manifest_file(bot_directory)
+        create_scraper_file(bot_directory)
+
+        stderr, stdout = execute_in_directory('bots:validate', bot_directory)
+
+        expect(stderr).to eq('')
+        expect(stdout).to eq <<-STDOUT
+Validated 1 records!
+STDOUT
+      end
+
+      it 'reports invalid records' do
+        bot_directory = create_bot_directory
+        create_manifest_file(bot_directory)
+        create_scraper_file(bot_directory, [{'name' => 1}])
+
+        stderr, stdout = execute_in_directory('bots:validate', bot_directory)
+
+        expect(stderr).to eq('')
+        expect(stdout).to eq <<-STDOUT
+
+The following record is invalid:
+{"name":1}
+ * Property of wrong type: name (must be of type string)
+
+Validated 0 records before bot failed!
+STDOUT
+       end
+
+      it 'reports invalid JSON' do
+        bot_directory = create_bot_directory
+        create_manifest_file(bot_directory)
+        create_scraper_file(bot_directory, ['{'])
+
+        stderr, stdout = execute_in_directory('bots:validate', bot_directory)
+
+        expect(stderr).to eq('')
+        expect(stdout).to equal_lines <<-STDOUT
+
+The following line was not valid JSON:
+"{"
+Validated 0 records before bot failed!
+STDOUT
+       end
+
+      it 'reports records without identifying fields' do
+        bot_directory = create_bot_directory
+        create_manifest_file(bot_directory)
+        create_scraper_file(bot_directory, [{}])
+
+        stderr, stdout = execute_in_directory('bots:validate', bot_directory)
+
+        expect(stderr).to eq('')
+        expect(stdout).to eq <<-STDOUT
 
-        stderr, stdout = execute("bots:validate")
+The following record is invalid:
+{}
+ * There were no values provided for any of the identifying fields: name
 
-        stdout.should include "Validated 0 records before bot failed!"
-        stderr.should == ""
+Validated 0 records before bot failed!
+STDOUT
+       end
+
+      it 'errors if no local bot is found' do
+        stderr, stdout = execute('bots:validate')
+
+        expect(stdout).to eq('')
+        expect(stderr).to eq <<-STDERR
+ !    No bot specified.
+ !    Run this command from a bot directory containing a `manifest.json` file, or specify the bot with --bot BOT.
+STDERR
+      end
+
+      it 'errors if manifest is invalid JSON' do
+        bot_directory = create_bot_directory
+        create_manifest_file(bot_directory, '{')
+
+        stderr, stdout = execute_in_directory('bots:validate', bot_directory)
+
+        expect(stdout).to eq('')
+        expect(stderr).to eq <<-STDERR
+ !    `manifest.json` is invalid JSON. Consider validating it at http://pro.jsonlint.com/
+STDERR
+      end
+
+      it 'warns if deprecated fields are used' do
+        bot_directory = create_bot_directory
+        create_scraper_file(bot_directory)
+        create_manifest_file(bot_directory, JSON.dump(valid_manifest.merge({
+          'allow_duplicates' => true,
+          'author' => 'John Q. Public',
+          'incremental' => true,
+          'public_repository' => 'http://example.com/',
+        })))
+
+        stderr, stdout = execute_in_directory('bots:validate', bot_directory)
+
+        expect(stderr).to eq('')
+        expect(stdout).to eq <<-STDOUT
+WARNING: "allow_duplicates" is deprecated. Use "duplicates_allowed" instead.
+WARNING: "author" is deprecated. Use "publisher" instead.
+WARNING: "incremental" is deprecated. Use "manually_end_run" instead.
+WARNING: "public_repository" is deprecated. Use "public_repo_url" instead.
+Validated 1 records!
+STDOUT
+      end
+
+      it 'errors if manifest is invalid' do
+        bot_directory = create_bot_directory
+        create_scraper_file(bot_directory)
+        create_manifest_file(bot_directory, JSON.dump(valid_manifest.merge({
+          'bot_id' => 'example!',
+          'title' => 1,
+        })))
+
+        stderr, stdout = execute_in_directory('bots:validate', bot_directory)
+
+        expect(stdout).to eq('')
+        expect(stderr).to eq <<-STDERR
+ !    `manifest.json` is invalid. Please correct the errors:
+ !    * The property '#/bot_id' value "example!" did not match the regex '^[A-Za-z0-9._-]+$'
+ !    * The property '#/title' of type Fixnum did not match the following type: string
+STDERR
+      end
+
+      it 'errors if transformer files not in files list' do
+        bot_directory = create_bot_directory
+        create_scraper_file(bot_directory)
+        create_manifest_file(bot_directory, JSON.dump(valid_manifest.merge({
+          'transformers' => [{
+            'data_type' => 'dummy',
+            'file' => 'transformer.rb',
+            'identifying_fields' => ['name'],
+          }]
+        })))
+
+        stderr, stdout = execute_in_directory('bots:validate', bot_directory)
+
+        expect(stdout).to eq('')
+        expect(stderr).to eq <<-STDERR
+ !    `manifest.json` is invalid. Please correct the errors:
+ !    * Some transformer files are not listed in the top-level files: transformer.rb
+STDERR
+      end
+
+      it 'errors if data_type is invalid' do
+        bot_directory = create_bot_directory
+        create_scraper_file(bot_directory)
+        create_manifest_file(bot_directory, JSON.dump(valid_manifest.merge({
+          'data_type' => 'invalid',
+        })))
+
+        stderr, stdout = execute_in_directory('bots:validate', bot_directory)
+
+        expect(stdout).to eq('')
+        expect(stderr).to eq <<-STDERR
+ !    `manifest.json` is invalid. Please correct the errors:
+ !    * The property '#/data_type' value "invalid" is not a supported data type.
+STDERR
       end
     end
 
-    context "for bot with manifest missing some required fields" do
-      it "says bot is invalid" do
-        config = {
-          'bot_id' => 'dummy bot',
-          'identifying_fields' => ['name'],
-          'files' => 'scraper.rb',
-        }
-        Turbot::Command::Bots.any_instance.stub(:parsed_manifest).and_return(config)
+    describe 'bots:preview' do
+      it 'submits records' do
+        stub_preview
+
+        set_turbot_runner_schemas
+
+        bot_directory = create_bot_directory
+        create_manifest_file(bot_directory)
+        create_scraper_file(bot_directory)
 
-        stderr, stdout = execute("bots:validate")
+        allow_any_instance_of(Turbot::Command::Base).to receive(:working_directory).and_return(bot_directory)
+        stderr, stdout = execute('bots:preview')
+        restore_working_directory_method
 
-        stdout.should == ""
-        stderr.should include 'Manifest is missing data_type'
+        expect(stderr).to eq('')
+        expect(stdout).to eq <<-STDOUT
+Sending to Turbot...
+Submitted 1 records to Turbot.
+View your records at http://example.com/
+STDOUT
+      end
+
+      it 'errors if no local bot is found' do
+        stderr, stdout = execute('bots:preview')
+
+        expect(stdout).to eq('')
+        expect(stderr).to eq <<-STDERR
+ !    No bot specified.
+ !    Run this command from a bot directory containing a `manifest.json` file, or specify the bot with --bot BOT.
+STDERR
+      end
+
+      it 'errors if the scraper is broken' do
+        stub_preview
+
+        set_turbot_runner_schemas
+
+        bot_directory = create_bot_directory
+        create_manifest_file(bot_directory)
+        create_broken_scraper_file(bot_directory)
+
+        allow_any_instance_of(Turbot::Command::Base).to receive(:working_directory).and_return(bot_directory)
+        stderr, stdout = execute('bots:preview')
+        restore_working_directory_method
+
+        expect(stderr).to eq('')
+        expect(stdout).to eq <<-STDOUT
+Sending to Turbot...
+Bot failed!
+STDOUT
       end
     end
-  end
 
-  describe '#create_zip_archive' do
-    it 'adds all given files to archive' do
-      dirs = ['a', 'b', 'a/p', 'b/p']
-      paths = ['a/p/x', 'a/y', 'b/p/x', 'b/y', 'z']
+    describe 'bots:dump' do
+      it 'dumps records' do
+        set_turbot_runner_schemas
+
+        bot_directory = create_bot_directory
+        create_manifest_file(bot_directory)
+        create_scraper_file(bot_directory)
+
+        allow_any_instance_of(Turbot::Command::Base).to receive(:working_directory).and_return(bot_directory)
+        stderr, stdout = execute('bots:dump')
+        restore_working_directory_method
+
+        expect(stderr).to eq('')
+        expect(stdout).to eq <<-STDOUT
+{"name":"foo"}
+Bot ran successfully!
+STDOUT
+      end
 
-      base_dir = Dir.mktmpdir
-      dirs.each {|dir| Dir.mkdir(File.join(base_dir, dir))}
-      paths.each {|path| FileUtils.touch(File.join(base_dir, path))}
+      it 'reports only validation errors' do
+        set_turbot_runner_schemas
 
-      command = Turbot::Command::Bots.new
-      archive_path = Tempfile.new('test').path
-      command.send(:create_zip_archive, archive_path, base_dir, ['a', 'b/p/x', 'b/y', 'z'])
+        bot_directory = create_bot_directory
+        create_manifest_file(bot_directory)
+        create_scraper_file(bot_directory, [{'name' => 'foo'}, {'name' => 1}])
 
-      Zip::File.open(archive_path) do |zipfile|
-        expect(zipfile.map {|entry| entry.to_s}).to match_array(paths + ['a/p/'])
+        allow_any_instance_of(Turbot::Command::Base).to receive(:working_directory).and_return(bot_directory)
+        stderr, stdout = execute('bots:dump --quiet')
+        restore_working_directory_method
+
+        expect(stderr).to eq('')
+        expect(stdout).to eq <<-STDOUT
+
+The following record is invalid:
+{"name":1}
+ * Property of wrong type: name (must be of type string)
+
+Bot failed!
+STDOUT
+      end
+
+      it 'errors if no local bot is found' do
+        stderr, stdout = execute('bots:dump')
+
+        expect(stdout).to eq('')
+        expect(stderr).to eq <<-STDERR
+ !    No bot specified.
+ !    Run this command from a bot directory containing a `manifest.json` file, or specify the bot with --bot BOT.
+STDERR
+      end
+
+      it 'errors if the scraper is broken' do
+        set_turbot_runner_schemas
+
+        bot_directory = create_bot_directory
+        create_manifest_file(bot_directory)
+        create_broken_scraper_file(bot_directory)
+
+        allow_any_instance_of(Turbot::Command::Base).to receive(:working_directory).and_return(bot_directory)
+        stderr, stdout = execute('bots:dump')
+        restore_working_directory_method
+
+        expect(stderr).to eq('')
+        expect(stdout).to eq <<-STDOUT
+Bot failed!
+STDOUT
+      end
+    end
+
+    describe '#create_zip_archive' do
+      it 'adds all given files to archive' do
+        dirs = ['a', 'b', 'a/p', 'b/p']
+        paths = ['a/p/x', 'a/y', 'b/p/x', 'b/y', 'z']
+        working_directory = Dir.mktmpdir
+        dirs.each { |dir| Dir.mkdir(File.join(working_directory, dir)) }
+        paths.each { |path| FileUtils.touch(File.join(working_directory, path)) }
+
+        tempfile = Tempfile.new('test')
+        tempfile.close
+        archive_path = "#{tempfile.path}.zip"
+
+        allow_any_instance_of(Turbot::Command::Base).to receive(:working_directory).and_return(working_directory)
+        Turbot::Command::Bots.new.send(:create_zip_archive, archive_path, ['a', 'b/p/x', 'b/y', 'z'])
+        restore_working_directory_method
+
+        Zip::File.open(archive_path) do |zipfile|
+          expect(zipfile.map { |entry| entry.to_s }).to match_array(paths + ['a/p/'])
+        end
       end
     end
   end