turbo_tests 1.2.2 → 1.2.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 92f70e0d1c7d01b5f9d17960ddcf2418c8c4fa620e8c46d0bb81df21b9193452
-  data.tar.gz: 0a21dd64949d53a8045e167754f19b698356f2a5c088f6ad56b83297d42932a6
+  metadata.gz: ed1e26234763e4fd425447465a01b091f3b895c5c315beaf06e03b96225a2b28
+  data.tar.gz: c37798c25bab9b136a0768795d3f2c45d65de8d6b2a2c48a9e1fd7ed30a6a5eb
 SHA512:
-  metadata.gz: 0d0e28e448d9b3f6e8dc5f47ef6b6308d3a8a08ffdcdcacdddc20f979af2a1f6d7e0827afbe5cc1fd09293efa3abed703cf7c0082a5d5cc400dd32fb9c9672a0
-  data.tar.gz: 6efbeb21524f9973d759914766cf0966f4b3da0d0c68dab75c4efe0c412808df6a979324793ce3de21ff77745ca7f5bffda605f3a6e73635839e14e84b1d4658
+  metadata.gz: 3381d49ecc0e38cdfa0a71cce9961d29bfb41b0ccb4d1b9abae13ac4202c90ea59f8b3951292e8a1f89d298d8ffbd426bead4a8135c51b8b675793018eadb239
+  data.tar.gz: '085230889cbe5749e66d140ecd32fa3ba0bfc4ab7bbf117e1b400cf48e65e1590de959ffaac6cfb7c95faf4b5db09147282eb26deb4c021f749a9fb9c269fc70'

data/.rspec

@@ -1,3 +1,4 @@
 --format documentation
 --color
+--tty
 --require spec_helper

data/Gemfile

@@ -3,4 +3,4 @@ source "https://rubygems.org"
 # Specify your gem's dependencies in turbo_tests.gemspec
 gemspec
 
-gem "rake", "~> 12.0"
+gem "rake", "~> 13.0"

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    turbo_tests (1.2.2)
+    turbo_tests (1.2.3)
       bundler
       parallel_tests (~> 3.3)
       rspec (~> 3.10.0)
@@ -13,12 +13,12 @@ GEM
     diff-lcs (1.4.4)
     method_source (1.0.0)
     parallel (1.20.1)
-    parallel_tests (3.5.0)
+    parallel_tests (3.5.2)
       parallel
     pry (0.14.0)
       coderay (~> 1.1)
       method_source (~> 1.0)
-    rake (12.3.3)
+    rake (13.0.3)
     rspec (3.10.0)
       rspec-core (~> 3.10.0)
       rspec-expectations (~> 3.10.0)
@@ -37,8 +37,8 @@ PLATFORMS
   ruby
 
 DEPENDENCIES
-  pry (~> 0.13)
-  rake (~> 12.0)
+  pry (~> 0.14)
+  rake (~> 13.0)
   turbo_tests!
 
 BUNDLED WITH

data/fixtures/rspec/errors_outside_of_examples_spec.rb

@@ -0,0 +1,5 @@
+RSpec.describe "Fixture of spec file with errors outside of examples" do
+  it("passes") { expect(2 * 2).to eql(4) }
+
+  1 / 0
+end

data/lib/turbo_tests.rb

@@ -23,14 +23,14 @@ module TurboTests
         klass =
           Class.new(FakeException) {
             define_singleton_method(:name) do
-              obj["class_name"]
+              obj[:class_name]
             end
           }
 
         klass.new(
-          obj["backtrace"],
-          obj["message"],
-          FakeException.from_obj(obj["cause"])
+          obj[:backtrace],
+          obj[:message],
+          FakeException.from_obj(obj[:cause])
         )
       end
     end
@@ -40,11 +40,11 @@ module TurboTests
   class FakeExecutionResult
     def self.from_obj(obj)
       new(
-        obj["example_skipped?"],
-        obj["pending_message"],
-        obj["status"].to_sym,
-        obj["pending_fixed?"],
-        FakeException.from_obj(obj["exception"])
+        obj[:example_skipped?],
+        obj[:pending_message],
+        obj[:status].to_sym,
+        obj[:pending_fixed?],
+        FakeException.from_obj(obj[:exception])
       )
     end
   end
@@ -52,24 +52,24 @@ module TurboTests
   FakeExample = Struct.new(:execution_result, :location, :description, :full_description, :metadata, :location_rerun_argument)
   class FakeExample
     def self.from_obj(obj)
-      metadata = obj["metadata"]
+      metadata = obj[:metadata]
 
-      metadata["shared_group_inclusion_backtrace"].map! do |frame|
+      metadata[:shared_group_inclusion_backtrace].map! do |frame|
         RSpec::Core::SharedExampleGroupInclusionStackFrame.new(
-          frame["shared_group_name"],
-          frame["inclusion_location"]
+          frame[:shared_group_name],
+          frame[:inclusion_location]
         )
       end
 
-      metadata[:shared_group_inclusion_backtrace] = metadata.delete("shared_group_inclusion_backtrace")
+      metadata[:shared_group_inclusion_backtrace] = metadata.delete(:shared_group_inclusion_backtrace)
 
       new(
-        FakeExecutionResult.from_obj(obj["execution_result"]),
-        obj["location"],
-        obj["description"],
-        obj["full_description"],
+        FakeExecutionResult.from_obj(obj[:execution_result]),
+        obj[:location],
+        obj[:description],
+        obj[:full_description],
         metadata,
-        obj["location_rerun_argument"]
+        obj[:location_rerun_argument]
       )
     end
 

data/lib/turbo_tests/json_rows_formatter.rb

@@ -30,6 +30,7 @@ module TurboTests
       :example_group_started,
       :example_group_finished,
       :example_pending,
+      :message,
       :seed
     )
 
@@ -39,59 +40,65 @@ module TurboTests
       @output = output
     end
 
-
     def start(notification)
       output_row(
-        "type" => :load_summary,
-        "summary" => load_summary_to_json(notification)
+        type: :load_summary,
+        summary: load_summary_to_json(notification)
       )
     end
 
     def example_group_started(notification)
       output_row(
-        "type" => :group_started,
-        "group" => group_to_json(notification)
+        type: :group_started,
+        group: group_to_json(notification)
       )
     end
 
     def example_group_finished(notification)
       output_row(
-        "type" => :group_finished,
-        "group" => group_to_json(notification)
+        type: :group_finished,
+        group: group_to_json(notification)
       )
     end
 
     def example_passed(notification)
       output_row(
-        "type" => :example_passed,
-        "example" => example_to_json(notification.example)
+        type: :example_passed,
+        example: example_to_json(notification.example)
       )
     end
 
     def example_pending(notification)
       output_row(
-        "type" => :example_pending,
-        "example" => example_to_json(notification.example)
+        type: :example_pending,
+        example: example_to_json(notification.example)
       )
     end
 
     def example_failed(notification)
       output_row(
-        "type" => :example_failed,
-        "example" => example_to_json(notification.example)
+        type: :example_failed,
+        example: example_to_json(notification.example)
       )
     end
 
     def seed(notification)
       output_row(
-        "type" => :seed,
-        "seed" => notification.seed
+        type: :seed,
+        seed: notification.seed
       )
     end
 
     def close(notification)
       output_row(
-        "type" => :close
+        type: :close
+      )
+    end
+
+    def message(notification)
+      output_row(
+        type: :message,
+        message: notification.message
       )
     end
 
@@ -100,62 +107,65 @@ module TurboTests
     def exception_to_json(exception)
       if exception
         {
-          "class_name" => exception.class.name.to_s,
-          "backtrace" => exception.backtrace,
-          "message" => exception.message,
-          "cause" => exception_to_json(exception.cause)
+          class_name: exception.class.name.to_s,
+          backtrace: exception.backtrace,
+          message: exception.message,
+          cause: exception_to_json(exception.cause)
         }
       end
     end
 
     def execution_result_to_json(result)
       {
-        "example_skipped?" => result.example_skipped?,
-        "pending_message" => result.pending_message,
-        "status" => result.status,
-        "pending_fixed?" => result.pending_fixed?,
-        "exception" => exception_to_json(result.exception)
+        example_skipped?: result.example_skipped?,
+        pending_message: result.pending_message,
+        status: result.status,
+        pending_fixed?: result.pending_fixed?,
+        exception: exception_to_json(result.exception)
       }
     end
 
     def stack_frame_to_json(frame)
       {
-        "shared_group_name" => frame.shared_group_name,
-        "inclusion_location" => frame.inclusion_location
+        shared_group_name: frame.shared_group_name,
+        inclusion_location: frame.inclusion_location
       }
     end
 
     def example_to_json(example)
       {
-        "execution_result" => execution_result_to_json(example.execution_result),
-        "location" => example.location,
-        "description" => example.description,
-        "full_description" => example.full_description,
-        "metadata" => {
-          "shared_group_inclusion_backtrace" =>
-            example.metadata[:shared_group_inclusion_backtrace].map { |frame| stack_frame_to_json(frame) }
+        execution_result: execution_result_to_json(example.execution_result),
+        location: example.location,
+        description: example.description,
+        full_description: example.full_description,
+        metadata: {
+          shared_group_inclusion_backtrace:
+            example
+              .metadata[:shared_group_inclusion_backtrace]
+              .map { |frame| stack_frame_to_json(frame) }
         },
-        "location_rerun_argument" => example.location_rerun_argument
+        location_rerun_argument: example.location_rerun_argument
       }
     end
 
     def load_summary_to_json(notification)
       {
         count: notification.count,
-        load_time: notification.load_time
+        load_time: notification.load_time,
       }
     end
 
     def group_to_json(notification)
       {
-        "group": {
-          "description": notification.group.description
+        group: {
+          description: notification.group.description
         }
       }
     end
 
     def output_row(obj)
-      output.puts ENV["RSPEC_FORMATTER_OUTPUT_ID"] + obj.to_json
+      output.puts(obj.to_json)
+      output.flush
     end
   end
 end

data/lib/turbo_tests/reporter.rb

@@ -28,8 +28,10 @@ module TurboTests
       @pending_examples = []
       @failed_examples = []
       @all_examples = []
+      @messages = []
       @start_time = start_time
       @load_time = 0
+      @errors_outside_of_examples_count = 0
     end
 
     def add(name, outputs)
@@ -76,6 +78,15 @@ module TurboTests
       @failed_examples << example
     end
 
+    def message(message)
+      delegate_to_formatters(:message, RSpec::Core::Notifications::MessageNotification.new(message))
+      @messages << message
+    end
+
+    def error_outside_of_examples
+      @errors_outside_of_examples_count += 12
+    end
+
     def finish
       # SEE: https://bit.ly/2NP87Cz
       end_time = Process.clock_gettime(Process::CLOCK_MONOTONIC)
@@ -97,7 +108,7 @@ module TurboTests
           @failed_examples,
           @pending_examples,
           @load_time,
-          0
+          @errors_outside_of_examples_count
         ))
       delegate_to_formatters(:close,
         RSpec::Core::Notifications::NullNotification)

data/lib/turbo_tests/runner.rb

@@ -20,6 +20,10 @@ module TurboTests
       fail_fast = opts.fetch(:fail_fast, nil)
       count = opts.fetch(:count, nil)
 
+      if verbose
+        STDERR.puts "VERBOSE"
+      end
+
       reporter = Reporter.from_config(formatters, start_time)
 
       new(
@@ -41,12 +45,11 @@ module TurboTests
       @count = opts[:count]
       @load_time = 0
       @load_count = 0
-
       @failure_count = 0
-      @runtime_log = "tmp/parallel_runtime_rspec.log"
 
       @messages = Queue.new
       @threads = []
+      @error = false
     end
 
     def run
@@ -55,17 +58,33 @@ module TurboTests
         ParallelTests::RSpec::Runner.tests_with_size(@files, {}).size
       ].min
 
+      use_runtime_info = @files == ["spec"]
+
+      group_opts = {}
+
+      if use_runtime_info
+        group_opts[:runtime_log] = "tmp/turbo_rspec_runtime.log"
+      else
+        group_opts[:group_by] = :filesize
+      end
+
       tests_in_groups =
         ParallelTests::RSpec::Runner.tests_in_groups(
           @files,
           @num_processes,
-          runtime_log: @runtime_log
+          **group_opts
         )
 
+      setup_tmp_dir
+
+      subprocess_opts = {
+        record_runtime: use_runtime_info
+      }
+
       report_number_of_tests(tests_in_groups)
 
-      tests_in_groups.each_with_index do |tests, process_id|
-        start_regular_subprocess(tests, process_id + 1)
+      wait_threads = tests_in_groups.map.with_index do |tests, process_id|
+        start_regular_subprocess(tests, process_id + 1, **subprocess_opts)
       end
 
       handle_messages
@@ -74,38 +93,64 @@ module TurboTests
 
       @threads.each(&:join)
 
-      @reporter.failed_examples.empty?
+      @reporter.failed_examples.empty? && wait_threads.map(&:value).all?(&:success?)
     end
 
-    protected
+    private
+
+    def setup_tmp_dir
+      begin
+        FileUtils.rm_r("tmp/test-pipes")
+      rescue Errno::ENOENT
+      end
+
+      FileUtils.mkdir_p("tmp/test-pipes/")
+    end
 
-    def start_regular_subprocess(tests, process_id)
+    def start_regular_subprocess(tests, process_id, **opts)
       start_subprocess(
         {"TEST_ENV_NUMBER" => process_id.to_s},
         @tags.map { |tag| "--tag=#{tag}" },
         tests,
-        process_id
+        process_id,
+        **opts
       )
     end
 
-    def start_subprocess(env, extra_args, tests, process_id)
+    def start_subprocess(env, extra_args, tests, process_id, record_runtime:)
       if tests.empty?
         @messages << {
-          "type" => "exit",
-          "process_id" => process_id
+          type: "exit",
+          process_id: process_id
         }
       else
-        require "securerandom"
-        env["RSPEC_FORMATTER_OUTPUT_ID"] = SecureRandom.uuid
-        env["RUBYOPT"] = "-I#{File.expand_path("..", __dir__)}"
+        tmp_filename = "tmp/test-pipes/subprocess-#{process_id}"
+
+        begin
+          File.mkfifo(tmp_filename)
+        rescue Errno::EEXIST
+        end
+
+        env["RUBYOPT"] = ["-I#{File.expand_path("..", __dir__)}", ENV["RUBYOPT"]].compact.join(" ")
+        env["RSPEC_SILENCE_FILTER_ANNOUNCEMENTS"] = "1"
+
+        record_runtime_options =
+          if record_runtime
+            [
+              "--format", "ParallelTests::RSpec::RuntimeLogger",
+              "--out", "tmp/turbo_rspec_runtime.log",
+            ]
+          else
+            []
+          end
 
         command = [
           ENV["BUNDLE_BIN_PATH"], "exec", "rspec",
           *extra_args,
-          "--seed", rand(2**16).to_s,
-          "--format", "ParallelTests::RSpec::RuntimeLogger",
-          "--out", @runtime_log,
+          "--seed", rand(0xFFFF).to_s,
           "--format", "TurboTests::JsonRowsFormatter",
+          "--out", tmp_filename,
+          *record_runtime_options,
           *tests
         ]
 
@@ -118,29 +163,33 @@ module TurboTests
           STDERR.puts "Process #{process_id}: #{command_str}"
         end
 
-        _stdin, stdout, stderr, _wait_thr = Open3.popen3(env, *command)
+        stdin, stdout, stderr, wait_thr = Open3.popen3(env, *command)
+        stdin.close
 
         @threads <<
-          Thread.new {
-            require "json"
-            stdout.each_line do |line|
-              result = line.split(env["RSPEC_FORMATTER_OUTPUT_ID"])
-
-              output = result.shift
-              STDOUT.print(output) unless output.empty?
-
-              message = result.shift
-              next unless message
-
-              message = JSON.parse(message)
-              message["process_id"] = process_id
-              @messages << message
+          Thread.new do
+            File.open(tmp_filename) do |fd|
+              fd.each_line do |line|
+                message = JSON.parse(line, symbolize_names: true)
+
+                message[:process_id] = process_id
+                @messages << message
+              end
             end
 
-            @messages << {"type" => "exit", "process_id" => process_id}
-          }
+            @messages << {type: "exit", process_id: process_id}
+          end
 
+        @threads << start_copy_thread(stdout, STDOUT)
         @threads << start_copy_thread(stderr, STDERR)
+
+        @threads << Thread.new {
+          unless wait_thr.value.success?
+            @messages << {type: "error"}
+          end
+        }
+
+        wait_thr
       end
     end
 
@@ -149,6 +198,7 @@ module TurboTests
         loop do
           msg = src.readpartial(4096)
         rescue EOFError
+          src.close
           break
         else
           dst.write(msg)
@@ -161,40 +211,47 @@ module TurboTests
 
       loop do
         message = @messages.pop
-        case message["type"]
+        case message[:type]
         when "example_passed"
-          example = FakeExample.from_obj(message["example"])
+          example = FakeExample.from_obj(message[:example])
           @reporter.example_passed(example)
         when "group_started"
-          @reporter.group_started(message["group"].to_struct)
+          @reporter.group_started(message[:group].to_struct)
         when "group_finished"
           @reporter.group_finished
         when "example_pending"
-          example = FakeExample.from_obj(message["example"])
+          example = FakeExample.from_obj(message[:example])
           @reporter.example_pending(example)
         when "load_summary"
-          message = message["summary"]
+          message = message[:summary]
           # NOTE: notifications order and content is not guaranteed hence the fetch
           #       and count increment tracking to get the latest accumulated load time
-          @reporter.load_time = message["load_time"] if message.fetch("count", 0) > @load_count
+          @reporter.load_time = message[:load_time] if message.fetch(:count, 0) > @load_count
         when "example_failed"
-          example = FakeExample.from_obj(message["example"])
+          example = FakeExample.from_obj(message[:example])
           @reporter.example_failed(example)
           @failure_count += 1
           if fail_fast_met
             @threads.each(&:kill)
             break
           end
+        when "message"
+          @reporter.message(message[:message])
         when "seed"
         when "close"
+        when "error"
+          @reporter.error_outside_of_examples
+          @error = true
         when "exit"
           exited += 1
           if exited == @num_processes
             break
           end
         else
-          warn("Unhandled message in main process: #{message}")
+          STDERR.puts("Unhandled message in main process: #{message}")
         end
+
+        STDOUT.flush
       end
     rescue Interrupt
     end
@@ -203,8 +260,6 @@ module TurboTests
       !@fail_fast.nil? && @fail_fast >= @failure_count
     end
 
-    private
-
     def report_number_of_tests(groups)
       name = ParallelTests::RSpec::Runner.test_file_name
 

data/lib/turbo_tests/version.rb

@@ -1,3 +1,3 @@
 module TurboTests
-  VERSION = "1.2.2"
+  VERSION = "1.2.3"
 end

data/turbo_tests.gemspec

@@ -19,7 +19,7 @@ Gem::Specification.new do |spec|
   spec.add_dependency "rspec", "~> 3.10.0"
   spec.add_dependency "parallel_tests", "~> 3.3"
 
-  spec.add_development_dependency "pry", "~> 0.13"
+  spec.add_development_dependency "pry", "~> 0.14"
 
   spec.add_runtime_dependency "bundler"
 

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: turbo_tests
 version: !ruby/object:Gem::Version
-  version: 1.2.2
+  version: 1.2.3
 platform: ruby
 authors:
 - Ilya Zub
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2021-03-02 00:00:00.000000000 Z
+date: 2021-03-25 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rspec
@@ -44,14 +44,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '0.13'
+        version: '0.14'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '0.13'
+        version: '0.14'
 - !ruby/object:Gem::Dependency
   name: bundler
   requirement: !ruby/object:Gem::Requirement
@@ -86,6 +86,7 @@ files:
 - README.md
 - Rakefile
 - bin/turbo_tests
+- fixtures/rspec/errors_outside_of_examples_spec.rb
 - lib/turbo_tests.rb
 - lib/turbo_tests/cli.rb
 - lib/turbo_tests/json_rows_formatter.rb