turbo-rails 0.7.12 → 0.8.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 85771aa7f175db32f70c6b54ed5ae8ef2dd5e5538bf987b40d68eb6e4699e7b0
-  data.tar.gz: 946d4845a3f2478c5ca443507114d9a7fc5231a86ecf17a294dbe40c28b10174
+  metadata.gz: 53322c9735f1d41eb97512711037e8143fcaf903a60ed69b724a03c1859e329a
+  data.tar.gz: 2fddfbb67fc6b44ca622f2b33e7eef51130115759929f2f5e5a96fb060980582
 SHA512:
-  metadata.gz: 41651d40a449a1622e479b2c2950f82149749fce699b88a1a723a77fc3c23af543e491bb2aefafa4ad0cfe5e85db95b7ea8e059d15294db22537b74a39a18ceb
-  data.tar.gz: 78f1a8a26ddc16fa9263eac070b7311223decaa69409715f4931f03f410435374a883759e360410f8ae8729c6fd6fdeafbe9d3b9e57211aaa5af677aa9b884a7
+  metadata.gz: 5867df95abc9376ff2f0df5be93545b2a3814853447b8a5a4c971b114066b041a8f8b9aa62faa537bdeae7402495e0395b9ae01a707dd2d8688b9f79ca51618f
+  data.tar.gz: 30057544c5b4bbf376903bb88c12759c90829243700273228b2a521ccd96dabac185c403856b1d471e71ed7aa53802a1afdc6cd783e1ed7ae0ab83513355d1ce

data/README.md

@@ -71,10 +71,7 @@ Turbo can coexist with Rails UJS, but you need to take a series of upgrade steps
 
 ## Development
 
-* To run the Rails tests: `bundle exec rake`.
-  * To install dependencies: `bundle install`
-  * To prepare the test database: `cd test/dummy; RAILS_ENV=test ./bin/rails db:migrate`
-* To compile the JavaScript for the asset pipeline: `yarn build`
+Run the tests with `./bin/test`.
 
 
 ## License

data/app/assets/javascripts/turbo.js

@@ -247,7 +247,11 @@ function dispatch(eventName, {target: target, cancelable: cancelable, detail: de
     bubbles: true,
     detail: detail
   });
-  void (target || document.documentElement).dispatchEvent(event);
+  if (target && target.isConnected) {
+    target.dispatchEvent(event);
+  } else {
+    document.documentElement.dispatchEvent(event);
+  }
   return event;
 }
 
@@ -2556,6 +2560,7 @@ class Session {
       const form = document.createElement("form");
       form.method = linkMethod;
       form.action = link.getAttribute("href") || "undefined";
+      form.hidden = true;
       (_a = link.parentNode) === null || _a === void 0 ? void 0 : _a.insertBefore(form, link);
       return dispatch("submit", {
         cancelable: true,

data/app/channels/turbo/streams/broadcasts.rb

@@ -6,61 +6,61 @@ module Turbo::Streams::Broadcasts
   include Turbo::Streams::ActionHelper
 
   def broadcast_remove_to(*streamables, **opts)
-    broadcast_action_to *streamables, action: :remove, **opts
+    broadcast_action_to(*streamables, action: :remove, **opts)
   end
 
   def broadcast_replace_to(*streamables, **opts)
-    broadcast_action_to *streamables, action: :replace, **opts
+    broadcast_action_to(*streamables, action: :replace, **opts)
   end
 
   def broadcast_update_to(*streamables, **opts)
-    broadcast_action_to *streamables, action: :update, **opts
+    broadcast_action_to(*streamables, action: :update, **opts)
   end
 
   def broadcast_before_to(*streamables, **opts)
-    broadcast_action_to *streamables, action: :before, **opts
+    broadcast_action_to(*streamables, action: :before, **opts)
   end
 
   def broadcast_after_to(*streamables, **opts)
-    broadcast_action_to *streamables, action: :after, **opts
+    broadcast_action_to(*streamables, action: :after, **opts)
   end
 
   def broadcast_append_to(*streamables, **opts)
-    broadcast_action_to *streamables, action: :append, **opts
+    broadcast_action_to(*streamables, action: :append, **opts)
   end
 
   def broadcast_prepend_to(*streamables, **opts)
-    broadcast_action_to *streamables, action: :prepend, **opts
+    broadcast_action_to(*streamables, action: :prepend, **opts)
   end
 
   def broadcast_action_to(*streamables, action:, target: nil, targets: nil, **rendering)
-    broadcast_stream_to *streamables, content: turbo_stream_action_tag(action, target: target, targets: targets, template:
+    broadcast_stream_to(*streamables, content: turbo_stream_action_tag(action, target: target, targets: targets, template:
       rendering.delete(:content) || (rendering.any? ? render_format(:html, **rendering) : nil)
-    )
+    ))
   end
 
   def broadcast_replace_later_to(*streamables, **opts)
-    broadcast_action_later_to *streamables, action: :replace, **opts
+    broadcast_action_later_to(*streamables, action: :replace, **opts)
   end
 
   def broadcast_update_later_to(*streamables, **opts)
-    broadcast_action_later_to *streamables, action: :update, **opts
+    broadcast_action_later_to(*streamables, action: :update, **opts)
   end
 
   def broadcast_before_later_to(*streamables, **opts)
-    broadcast_action_later_to *streamables, action: :before, **opts
+    broadcast_action_later_to(*streamables, action: :before, **opts)
   end
 
   def broadcast_after_later_to(*streamables, **opts)
-    broadcast_action_later_to *streamables, action: :after, **opts
+    broadcast_action_later_to(*streamables, action: :after, **opts)
   end
 
   def broadcast_append_later_to(*streamables, **opts)
-    broadcast_action_later_to *streamables, action: :append, **opts
+    broadcast_action_later_to(*streamables, action: :append, **opts)
   end
 
   def broadcast_prepend_later_to(*streamables, **opts)
-    broadcast_action_later_to *streamables, action: :prepend, **opts
+    broadcast_action_later_to(*streamables, action: :prepend, **opts)
   end
 
   def broadcast_action_later_to(*streamables, action:, target: nil, targets: nil, **rendering)
@@ -69,7 +69,7 @@ module Turbo::Streams::Broadcasts
   end
 
   def broadcast_render_to(*streamables, **rendering)
-    broadcast_stream_to *streamables, content: render_format(:turbo_stream, **rendering)
+    broadcast_stream_to(*streamables, content: render_format(:turbo_stream, **rendering))
   end
 
   def broadcast_render_later_to(*streamables, **rendering)

data/app/helpers/turbo/streams/action_helper.rb

@@ -14,7 +14,7 @@ module Turbo::Streams::ActionHelper
 
     if target = convert_to_turbo_stream_dom_id(target)
       %(<turbo-stream action="#{action}" target="#{target}">#{template}</turbo-stream>).html_safe
-    elsif targets = convert_to_turbo_stream_dom_id(targets)
+    elsif targets = convert_to_turbo_stream_dom_id(targets, include_selector: true)
       %(<turbo-stream action="#{action}" targets="#{targets}">#{template}</turbo-stream>).html_safe
     else
       raise ArgumentError, "target or targets must be supplied"
@@ -22,7 +22,11 @@ module Turbo::Streams::ActionHelper
   end
 
   private
-    def convert_to_turbo_stream_dom_id(target)
-      target.respond_to?(:to_key) ? ActionView::RecordIdentifier.dom_id(target) : target
+    def convert_to_turbo_stream_dom_id(target, include_selector: false)
+      if target.respond_to?(:to_key)
+        [ ("#" if include_selector), ActionView::RecordIdentifier.dom_id(target) ].compact.join
+      else
+        target
+      end
     end
 end

data/app/models/concerns/turbo/broadcastable.rb

@@ -76,7 +76,7 @@ module Turbo::Broadcastable
   #   # Sends <turbo-stream action="remove" target="clearance_5"></turbo-stream> to the stream named "identity:2:clearances"
   #   clearance.broadcast_remove_to examiner.identity, :clearances
   def broadcast_remove_to(*streamables, target: self)
-    Turbo::StreamsChannel.broadcast_remove_to *streamables, target: target
+    Turbo::StreamsChannel.broadcast_remove_to(*streamables, target: target)
   end
 
   # Same as <tt>#broadcast_remove_to</tt>, but the designated stream is automatically set to the current model.
@@ -95,7 +95,7 @@ module Turbo::Broadcastable
   #   # to the stream named "identity:2:clearances"
   #   clearance.broadcast_replace_to examiner.identity, :clearances, partial: "clearances/other_partial", locals: { a: 1 }
   def broadcast_replace_to(*streamables, **rendering)
-    Turbo::StreamsChannel.broadcast_replace_to *streamables, target: self, **broadcast_rendering_with_defaults(rendering)
+    Turbo::StreamsChannel.broadcast_replace_to(*streamables, target: self, **broadcast_rendering_with_defaults(rendering))
   end
 
   # Same as <tt>#broadcast_replace_to</tt>, but the designated stream is automatically set to the current model.
@@ -114,7 +114,7 @@ module Turbo::Broadcastable
   #   # to the stream named "identity:2:clearances"
   #   clearance.broadcast_update_to examiner.identity, :clearances, partial: "clearances/other_partial", locals: { a: 1 }
   def broadcast_update_to(*streamables, **rendering)
-    Turbo::StreamsChannel.broadcast_update_to *streamables, target: self, **broadcast_rendering_with_defaults(rendering)
+    Turbo::StreamsChannel.broadcast_update_to(*streamables, target: self, **broadcast_rendering_with_defaults(rendering))
   end
 
   # Same as <tt>#broadcast_update_to</tt>, but the designated stream is automatically set to the current model.
@@ -135,7 +135,7 @@ module Turbo::Broadcastable
   #   clearance.broadcast_before_to examiner.identity, :clearances, target: "clearance_5",
   #     partial: "clearances/other_partial", locals: { a: 1 }
   def broadcast_before_to(*streamables, target:, **rendering)
-    Turbo::StreamsChannel.broadcast_before_to *streamables, target: target, **broadcast_rendering_with_defaults(rendering)
+    Turbo::StreamsChannel.broadcast_before_to(*streamables, target: target, **broadcast_rendering_with_defaults(rendering))
   end
 
   # Insert a rendering of this broadcastable model after the target identified by it's dom id passed as <tt>target</tt>
@@ -151,7 +151,7 @@ module Turbo::Broadcastable
   #   clearance.broadcast_after_to examiner.identity, :clearances, target: "clearance_5",
   #     partial: "clearances/other_partial", locals: { a: 1 }
   def broadcast_after_to(*streamables, target:, **rendering)
-    Turbo::StreamsChannel.broadcast_after_to *streamables, target: target, **broadcast_rendering_with_defaults(rendering)
+    Turbo::StreamsChannel.broadcast_after_to(*streamables, target: target, **broadcast_rendering_with_defaults(rendering))
   end
 
   # Append a rendering of this broadcastable model to the target identified by it's dom id passed as <tt>target</tt>
@@ -167,7 +167,7 @@ module Turbo::Broadcastable
   #   clearance.broadcast_append_to examiner.identity, :clearances, target: "clearances",
   #     partial: "clearances/other_partial", locals: { a: 1 }
   def broadcast_append_to(*streamables, target: broadcast_target_default, **rendering)
-    Turbo::StreamsChannel.broadcast_append_to *streamables, target: target, **broadcast_rendering_with_defaults(rendering)
+    Turbo::StreamsChannel.broadcast_append_to(*streamables, target: target, **broadcast_rendering_with_defaults(rendering))
   end
 
   # Same as <tt>#broadcast_append_to</tt>, but the designated stream is automatically set to the current model.
@@ -188,7 +188,7 @@ module Turbo::Broadcastable
   #   clearance.broadcast_prepend_to examiner.identity, :clearances, target: "clearances",
   #     partial: "clearances/other_partial", locals: { a: 1 }
   def broadcast_prepend_to(*streamables, target: broadcast_target_default, **rendering)
-    Turbo::StreamsChannel.broadcast_prepend_to *streamables, target: target, **broadcast_rendering_with_defaults(rendering)
+    Turbo::StreamsChannel.broadcast_prepend_to(*streamables, target: target, **broadcast_rendering_with_defaults(rendering))
   end
 
   # Same as <tt>#broadcast_prepend_to</tt>, but the designated stream is automatically set to the current model.
@@ -213,7 +213,7 @@ module Turbo::Broadcastable
 
   # Same as <tt>broadcast_replace_to</tt> but run asynchronously via a <tt>Turbo::Streams::BroadcastJob</tt>.
   def broadcast_replace_later_to(*streamables, **rendering)
-    Turbo::StreamsChannel.broadcast_replace_later_to *streamables, target: self, **broadcast_rendering_with_defaults(rendering)
+    Turbo::StreamsChannel.broadcast_replace_later_to(*streamables, target: self, **broadcast_rendering_with_defaults(rendering))
   end
 
   # Same as <tt>#broadcast_replace_later_to</tt>, but the designated stream is automatically set to the current model.
@@ -223,7 +223,7 @@ module Turbo::Broadcastable
 
   # Same as <tt>broadcast_update_to</tt> but run asynchronously via a <tt>Turbo::Streams::BroadcastJob</tt>.
   def broadcast_update_later_to(*streamables, **rendering)
-    Turbo::StreamsChannel.broadcast_update_later_to *streamables, target: self, **broadcast_rendering_with_defaults(rendering)
+    Turbo::StreamsChannel.broadcast_update_later_to(*streamables, target: self, **broadcast_rendering_with_defaults(rendering))
   end
 
   # Same as <tt>#broadcast_update_later_to</tt>, but the designated stream is automatically set to the current model.
@@ -233,7 +233,7 @@ module Turbo::Broadcastable
 
   # Same as <tt>broadcast_append_to</tt> but run asynchronously via a <tt>Turbo::Streams::BroadcastJob</tt>.
   def broadcast_append_later_to(*streamables, target: broadcast_target_default, **rendering)
-    Turbo::StreamsChannel.broadcast_append_later_to *streamables, target: target, **broadcast_rendering_with_defaults(rendering)
+    Turbo::StreamsChannel.broadcast_append_later_to(*streamables, target: target, **broadcast_rendering_with_defaults(rendering))
   end
 
   # Same as <tt>#broadcast_append_later_to</tt>, but the designated stream is automatically set to the current model.
@@ -243,7 +243,7 @@ module Turbo::Broadcastable
 
   # Same as <tt>broadcast_prepend_to</tt> but run asynchronously via a <tt>Turbo::Streams::BroadcastJob</tt>.
   def broadcast_prepend_later_to(*streamables, target: broadcast_target_default, **rendering)
-    Turbo::StreamsChannel.broadcast_prepend_later_to *streamables, target: target, **broadcast_rendering_with_defaults(rendering)
+    Turbo::StreamsChannel.broadcast_prepend_later_to(*streamables, target: target, **broadcast_rendering_with_defaults(rendering))
   end
 
   # Same as <tt>#broadcast_prepend_later_to</tt>, but the designated stream is automatically set to the current model.
@@ -283,7 +283,7 @@ module Turbo::Broadcastable
   # Same as <tt>broadcast_render_later</tt> but run with the added option of naming the stream using the passed
   # <tt>streamables</tt>.
   def broadcast_render_later_to(*streamables, **rendering)
-    Turbo::StreamsChannel.broadcast_render_later_to *streamables, **broadcast_rendering_with_defaults(rendering)
+    Turbo::StreamsChannel.broadcast_render_later_to(*streamables, **broadcast_rendering_with_defaults(rendering))
   end
 
 

data/lib/install/turbo_needs_redis.rb

@@ -1,6 +1,16 @@
 if (cable_config_path = Rails.root.join("config/cable.yml")).exist?
   say "Enable redis in bundle"
-  uncomment_lines "Gemfile", /gem ['"]redis['"]/
+
+  gemfile_content = File.read(Rails.root.join("Gemfile"))
+  pattern = /gem ['"]redis['"]/
+
+  if gemfile_content.match?(pattern)
+    uncomment_lines "Gemfile", pattern
+  else
+    gem 'redis', '~> 4.0', comment: "Use Redis as Action Cable adapter instead of default Async. The Async adapter\ndoes not support Turbo Stream broadcasting."
+  end
+
+  run_bundle
 
   say "Switch development cable to use redis"
   gsub_file cable_config_path.to_s, /development:\n\s+adapter: async/, "development:\n  adapter: redis\n  url: redis://localhost:6379/1"

data/lib/tasks/turbo_tasks.rake

@@ -1,9 +1,9 @@
 def run_turbo_install_template(path)
-  system "#{RbConfig.ruby} ./bin/rails app:template LOCATION=#{File.expand_path("../install/#{path}.rb",  __dir__)}"
+  system "#{RbConfig.ruby} ./bin/rails app:template LOCATION=#{File.expand_path("../install/#{path}.rb", __dir__)}"
 end
 
 def redis_installed?
-  system('which redis-server')
+  system('which redis-server > /dev/null')
 end
 
 def switch_on_redis_if_available

data/lib/turbo/version.rb

@@ -1,3 +1,3 @@
 module Turbo
-  VERSION = "0.7.12"
+  VERSION = "0.8.0"
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: turbo-rails
 version: !ruby/object:Gem::Version
-  version: 0.7.12
+  version: 0.8.0
 platform: ruby
 authors:
 - Sam Stephenson
@@ -10,7 +10,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2021-09-15 00:00:00.000000000 Z
+date: 2021-09-24 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rails