turbine 1.0.0.pre → 1.0.0.pre2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 06c2b81075e5071fcc7ca1eaaab8c1e7edaaf787
-  data.tar.gz: 34a741dd15ec2e4a24d6e9b89a7710d222c4b758
+  metadata.gz: a7a2a4bba52161cd063ecf520df92f103c8bffd0
+  data.tar.gz: 3eb0563a6418e04eb860fe8c902ef0fa2fd4e20a
 SHA512:
-  metadata.gz: 24e0625293f5306c2f22615e5d6d2822536427bda3c811130de5fff9f60faf05b2348f6554fdfe7db58c3b163bba428cc4e0e2383f854a471d0d61fe12075f98
-  data.tar.gz: cbec4a21aa14a47fd9878fbe48e12d60aa20a910828532a37f70b0ee69bf9fc565d2fe8d2ab56827dcb6746812d6f10e9b33eb6143646aad9b9c08e6093251cf
+  metadata.gz: db3ec24b191a0fec4d9e6c52421857a6026c326e9b1094d184e7f60a4c10e2eb8630bfaf271c3a66334bd7fb8b21a7e88f208eeba7c9eef9a854f5b9e9c2faa3
+  data.tar.gz: d91d4f80a74401ce66b777a9f7cb0ef1bf71b03a9c05eb4c4278167a023bafd80a5b414b7f29a1cafc1f2e92d455f69f457888234686471cd8b54dd92b6f8c0d

data/.rubocop.yml

@@ -12,4 +12,4 @@ Style/ModuleFunction:
 
 Metrics/MethodLength:
   CountComments: false
-  Max: 15
+  Max: 20

data/.travis.yml

@@ -1,6 +1,11 @@
 language: ruby
 install: gem install bundler
 script: "bundle && bundle exec rake ci"
+
+env:
+  global:
+    - JRUBY_OPTS="--server -J-Xms1500m -J-Xmx1500m -J-XX:+UseConcMarkSweepGC -J-XX:-UseGCOverheadLimit -J-XX:+CMSClassUnloadingEnabled"
+
 rvm:
   - 2.2.2
   - jruby
@@ -8,6 +13,7 @@ rvm:
   - rbx-2
 
 matrix:
+  fast_finish: true
   allow_failures:
-    - rvn: jruby-head
+    - rvm: jruby-head
     - rvm: rbx-2

data/README.md

@@ -1,12 +1,13 @@
 ![Turbine](https://raw.githubusercontent.com/tarcieri/turbine/master/turbine.png)
 =======
+[![Gem Version](https://badge.fury.io/rb/turbine.svg)](http://rubygems.org/gems/turbine)
 [![Build Status](https://travis-ci.org/tarcieri/turbine.svg)](https://travis-ci.org/tarcieri/turbine)
 [![Code Climate](https://codeclimate.com/github/tarcieri/turbine/badges/gpa.svg)](https://codeclimate.com/github/tarcieri/turbine)
 [![Coverage Status](https://coveralls.io/repos/tarcieri/turbine/badge.svg)](https://coveralls.io/r/tarcieri/turbine)
 
 Fault-tolerant multithreaded stream processing for Ruby.
 
-Turbine is a perforance-oriented stream processing library built on Zookeeper.
+Turbine is a performance-oriented stream processing library built on Zookeeper.
 It presently supports Kafka as a message queue, but is designed to be pluggable
 in order to potentially support other message queues in the future.
 
@@ -33,6 +34,12 @@ Or install it yourself as:
 
     $ gem install turbine
 
+## Getting Started
+
+Please see the [Quickstart](https://github.com/tarcieri/turbine/wiki/Quickstart)
+on the Wiki for a quick tutorial on writing your first stream processing job
+using Turbine.
+
 ## Usage
 
 Turbine presently supports stream processing from the Kafka message queue
@@ -59,7 +66,7 @@ processor.process(consumer) do |msg|
 end
 ```
 
-## Error handling
+## Error Handling
 
 By default, Turbine prints exceptions that occur during message processing to STDERR.
 Chances are, you'd probably rather log them to an exception logging service.

data/lib/turbine.rb

@@ -8,4 +8,6 @@ require "turbine/processor"
 
 # Fault-tolerant multithreaded stream processing for Ruby
 module Turbine
+  # Consumer failed to connect to broker
+  ConnectionError = Class.new(StandardError)
 end

data/lib/turbine/consumer/kafka.rb

@@ -11,8 +11,12 @@ module Turbine
       def fetch
         batch = nil
 
-        @consumer.fetch commit: false do |partition, messages|
-          batch = Batch.new(messages, partition)
+        begin
+          @consumer.fetch commit: false do |partition, messages|
+            batch = Batch.new(messages, partition)
+          end
+        rescue Poseidon::Connection::ConnectionFailedError => ex
+          raise ConnectionError, ex.to_s, ex.backtrace
         end
 
         batch

data/lib/turbine/kafka_helper.rb

@@ -0,0 +1,87 @@
+require "open3"
+require "poseidon"
+
+module Turbine
+  # Helper functions for integration testing with Kafka
+  module KafkaHelper
+    extend self
+
+    ZOOKEEPER_ADDR = "localhost:2181"
+    KAFKA_ADDR     = "localhost:9092"
+
+    def delete_topic(topic)
+      log "*** Deleting Kafka topic: #{topic}"
+
+      topic_command :delete, topic: topic
+    end
+
+    def create_topic(topic)
+      log "*** Creating Kafka topic: #{topic}"
+
+      required_topic_command :create,
+                             "replication-factor" => 1,
+                             "partitions"         => 1,
+                             "topic"              => topic
+    end
+
+    def list_topics
+      topic_command(:list).split("\n")
+    end
+
+    def topic_exists?(topic)
+      list_topics.include?(topic)
+    end
+
+    def fill_topic(topic, n = 100_000)
+      fail ArgumentError, "min messages is 1000" if n < 1000
+
+      producer = Poseidon::Producer.new([KAFKA_ADDR], "my_test_producer", type: :sync)
+
+      log "*** Filling topic with #{n} messages: #{topic}"
+
+      (n / 1000).times do |i|
+        messages = []
+
+        1000.times do |j|
+          n = (i * 1000 + j)
+          messages << Poseidon::MessageToSend.new(topic, n.to_s)
+        end
+
+        producer.send_messages(messages)
+      end
+    ensure
+      producer.close if producer
+    end
+
+    private
+
+    def kafka_path
+      ENV["KAFKA_PATH"] || File.expand_path("../../../kafka", __FILE__)
+    end
+
+    def kafka_topics_bin_path
+      "#{kafka_path}/bin/kafka-topics.sh"
+    end
+
+    def kafka_args(args = {})
+      { zookeeper: ZOOKEEPER_ADDR }.merge(args).map { |k, v| "--#{k} #{v}" }.join(" ")
+    end
+
+    def topic_command(command, args = {})
+      cmd = "#{kafka_topics_bin_path} --#{command} #{kafka_args(args)}"
+      stdout_str, _stderr_str, status = Open3.capture3(cmd)
+      return unless status.success?
+      stdout_str
+    end
+
+    def required_topic_command(command, args = {})
+      result = topic_command(command, args)
+      fail "Kafka command failed!" unless result
+      true
+    end
+
+    def log(message)
+      STDERR.puts(message)
+    end
+  end
+end

data/lib/turbine/processor.rb

@@ -2,23 +2,22 @@ module Turbine
   # Multithreaded message processor
   class Processor
     # How long to sleep when busy waiting for the queue to empty
-    BUSY_WAIT_INTERVAL = 0.0001
+    BUSY_WAIT_INTERVAL    = 0.0001
+    DEFAULT_DRAIN_TIMEOUT = 10
 
     def initialize(*args)
       @running = Concurrent::AtomicBoolean.new
       @pool = Concurrent::ThreadPoolExecutor.new(*args)
       @completed_count = Concurrent::AtomicFixnum.new
       @pending = []
-      @error_handler = proc do |ex|
-        STDERR.puts "*** Error processing message: #{ex.class} #{ex}\n#{ex.backtrace.join("\n")}"
-      end
+      @error_handler = method(:default_error_handler)
     end
 
     def process(consumer, &block)
       fail ArgumentError, "no block given" unless block
       processor_method = method(:process_batch)
-
       @running.value = true
+
       while @running.value && (batch = consumer.fetch)
         enqueue_batch(batch)
 
@@ -31,6 +30,9 @@ module Turbine
 
         commit_completions(consumer)
       end
+    ensure
+      drain(DEFAULT_DRAIN_TIMEOUT)
+      commit_completions(consumer)
     end
 
     def stop
@@ -77,7 +79,7 @@ module Turbine
 
     def process_batch(batch, block)
       for index in (0...batch.size)
-        msg = batch[index]
+        msg = batch[index].value
 
         begin
           block.call(msg)
@@ -91,12 +93,15 @@ module Turbine
       batch.complete
     end
 
+    # We exceeded the pool's queue, so busy-wait and retry
+    # TODO: more intelligent busy-waiting strategy
     def busy_wait(consumer)
       commit_completions(consumer)
-
-      # We exceeded the pool's queue, so busy-wait and retry
-      # TODO: more intelligent busy-waiting strategy
       sleep BUSY_WAIT_INTERVAL
     end
+
+    def default_error_handler(ex, _msg)
+      STDERR.puts "*** Error processing message: #{ex.class} #{ex}\n#{ex.backtrace.join("\n")}"
+    end
   end
 end

data/lib/turbine/rake_tasks.rb

@@ -0,0 +1,55 @@
+require "rake/clean"
+require "colorize"
+require "socket"
+require "timeout"
+
+KAFKA_PORT    = 9092
+START_TIMEOUT = 10
+
+namespace :kafka do
+  KAFKA_VERSION = "0.8.2.1"
+  KAFKA_TARBALL = "kafka_2.10-#{KAFKA_VERSION}.tgz"
+
+  task download: "tmp/#{KAFKA_TARBALL}"
+  directory "tmp"
+
+  file "tmp/#{KAFKA_TARBALL}" => "tmp" do
+    puts "#{'***'.blue} #{'Downloading Kafka'.light_white}"
+    url = "https://www.apache.org/dist/kafka/#{KAFKA_VERSION}/kafka_2.10-#{KAFKA_VERSION}.tgz"
+    sh "curl #{url} -o tmp/#{KAFKA_TARBALL}"
+  end
+
+  task install: :download do
+    puts "#{'***'.blue} #{'Unpacking Kafka'.light_white}"
+
+    rm_rf "kafka" if File.exist? "kafka"
+    sh "tar -zxf tmp/#{KAFKA_TARBALL}"
+    mv "kafka_2.10-#{KAFKA_VERSION}", "kafka"
+  end
+
+  task start: %w(kafka zookeeper:start) do
+    puts "#{'***'.blue} #{'Starting Kafka'.light_white}"
+    sh "cd kafka && bin/kafka-server-start.sh config/server.properties &"
+
+    Timeout.timeout(START_TIMEOUT) do
+      begin
+        socket = TCPSocket.open("localhost", 9092)
+      rescue Errno::ECONNREFUSED
+        sleep 0.01
+        retry
+      end
+
+      socket.close
+    end
+
+    # Give Kafka some time to finish printing startup messages
+    sleep 0.5
+    puts "#{'***'.blue} #{'Kafka started!'.light_white}"
+  end
+end
+
+file "kafka" do
+  Rake::Task["kafka:install"].invoke
+end
+
+CLEAN.include "tmp", "kafka"

data/lib/turbine/version.rb

@@ -1,4 +1,4 @@
 # Fault-tolerant multithreaded stream processing for Ruby
 module Turbine
-  VERSION = "1.0.0.pre"
+  VERSION = "1.0.0.pre2"
 end

data/spec/turbine/consumer/kafka_spec.rb

@@ -1,6 +1,6 @@
 require "spec_helper"
 require "turbine/consumer/kafka"
-require "turbine/rspec/kafka_helper"
+require "turbine/kafka_helper"
 require "benchmark"
 
 RSpec.describe Turbine::Consumer::Kafka do
@@ -27,12 +27,12 @@ RSpec.describe Turbine::Consumer::Kafka do
     timestamp = Time.now.strftime("%Y%m%d%H%M%S%L")
 
     @example_topic = "turbike-kafka-specs-#{timestamp}"
-    KafkaHelper.create_topic(@example_topic)
-    KafkaHelper.fill_topic(@example_topic, MESSAGE_COUNT)
+    Turbine::KafkaHelper.create_topic(@example_topic)
+    Turbine::KafkaHelper.fill_topic(@example_topic, MESSAGE_COUNT)
   end
 
   after :all do
-    KafkaHelper.delete_topic(@example_topic)
+    Turbine::KafkaHelper.delete_topic(@example_topic)
   end
 
   it "fetches batches of messages" do

data/spec/turbine/processor_spec.rb

@@ -6,11 +6,16 @@ RSpec.describe Turbine::Processor do
   QUEUE_SIZE       = 100
 
   let(:example_batch_size)    { 100 }
-  let(:example_elements)      { (0...example_batch_size).to_a }
   let(:example_partition)     { 0 }
   let(:example_batch_count)   { 1000 }
   let(:example_message_count) { example_batch_size * example_batch_count }
 
+  let(:example_elements) do
+    example_batch_size.times.map do |n|
+      double(:message, value: n)
+    end
+  end
+
   let(:example_batches) do
     Array.new(example_batch_count).fill do
       Turbine::Batch.new(example_elements, example_partition)
@@ -49,7 +54,7 @@ RSpec.describe Turbine::Processor do
 
   it "tolerates processing errors gracefully" do
     # Check the default handler is printing to STDERR
-    expect(STDERR).to receive(:puts).exactly(example_message_count).times
+    expect(STDERR).to receive(:puts).at_most(example_message_count).times
 
     example_processor.process(mock_consumer) do |_msg, _ex|
       fail "uhoh!"

data/tasks/kafka.rake

@@ -1,55 +1 @@
-require "rake/clean"
-require "colorize"
-require "socket"
-require "timeout"
-
-KAFKA_PORT    = 9092
-START_TIMEOUT = 5
-
-namespace :kafka do
-  KAFKA_VERSION = "0.8.2.1"
-  KAFKA_TARBALL = "kafka_2.10-#{KAFKA_VERSION}.tgz"
-
-  task download: "tmp/#{KAFKA_TARBALL}"
-  directory "tmp"
-
-  file "tmp/#{KAFKA_TARBALL}" => "tmp" do
-    puts "#{'***'.blue} #{'Downloading Kafka'.light_white}"
-    url = "https://www.apache.org/dist/kafka/#{KAFKA_VERSION}/kafka_2.10-#{KAFKA_VERSION}.tgz"
-    sh "curl #{url} -o tmp/#{KAFKA_TARBALL}"
-  end
-
-  task install: :download do
-    puts "#{'***'.blue} #{'Unpacking Kafka'.light_white}"
-
-    rm_rf "kafka" if File.exist? "kafka"
-    sh "tar -zxf tmp/#{KAFKA_TARBALL}"
-    mv "kafka_2.10-#{KAFKA_VERSION}", "kafka"
-  end
-
-  task start: %w(kafka zookeeper:start) do
-    puts "#{'***'.blue} #{'Starting Kafka'.light_white}"
-    sh "cd kafka && bin/kafka-server-start.sh config/server.properties &"
-
-    Timeout.timeout(START_TIMEOUT) do
-      begin
-        socket = TCPSocket.open("localhost", 9092)
-      rescue Errno::ECONNREFUSED
-        sleep 0.01
-        retry
-      end
-
-      socket.close
-    end
-
-    # Give Kafka some time to finish printing startup messages
-    sleep 0.5
-    puts "#{'***'.blue} #{'Kafka started!'.light_white}"
-  end
-end
-
-file "kafka" do
-  Rake::Task["kafka:install"].invoke
-end
-
-CLEAN.include "tmp", "kafka"
+require "turbine/rake_tasks"

data/turbine.gemspec

@@ -10,7 +10,7 @@ Gem::Specification.new do |spec|
   spec.email         = ["bascule@gmail.com"]
 
   spec.summary       = "Fault-tolerant multithreaded stream processing for Ruby"
-  spec.description   = "Turbine is a performance-oriented stream processor built on Zookeeper"
+  spec.description   = "Performance-oriented stream processing built on Kafka and Zookeeper"
   spec.homepage      = "https://github.com/tarcieri/turbine"
   spec.license       = "MIT"
 

metadata

@@ -1,124 +1,124 @@
 --- !ruby/object:Gem::Specification
 name: turbine
 version: !ruby/object:Gem::Version
-  version: 1.0.0.pre
+  version: 1.0.0.pre2
 platform: ruby
 authors:
 - Tony Arcieri
-autorequire: 
+autorequire:
 bindir: exe
 cert_chain: []
-date: 2015-05-30 00:00:00.000000000 Z
+date: 2015-05-31 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: zk
-  requirement: !ruby/object:Gem::Requirement
+  version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - '>='
       - !ruby/object:Gem::Version
         version: '0'
-  type: :runtime
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
+  requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - '>='
       - !ruby/object:Gem::Version
         version: '0'
+  prerelease: false
+  type: :runtime
 - !ruby/object:Gem::Dependency
   name: poseidon
-  requirement: !ruby/object:Gem::Requirement
+  version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - '>='
       - !ruby/object:Gem::Version
         version: 0.0.5
-  type: :runtime
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
+  requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - '>='
       - !ruby/object:Gem::Version
         version: 0.0.5
+  prerelease: false
+  type: :runtime
 - !ruby/object:Gem::Dependency
   name: poseidon_cluster
-  requirement: !ruby/object:Gem::Requirement
+  version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - '>='
       - !ruby/object:Gem::Version
         version: 0.3.0
-  type: :runtime
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
+  requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - '>='
       - !ruby/object:Gem::Version
         version: 0.3.0
+  prerelease: false
+  type: :runtime
 - !ruby/object:Gem::Dependency
   name: concurrent-ruby
-  requirement: !ruby/object:Gem::Requirement
+  version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - '>='
       - !ruby/object:Gem::Version
         version: '0'
-  type: :runtime
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
+  requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - '>='
       - !ruby/object:Gem::Version
         version: '0'
+  prerelease: false
+  type: :runtime
 - !ruby/object:Gem::Dependency
   name: bundler
-  requirement: !ruby/object:Gem::Requirement
+  version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ~>
       - !ruby/object:Gem::Version
         version: '1.9'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
+  requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ~>
       - !ruby/object:Gem::Version
         version: '1.9'
+  prerelease: false
+  type: :development
 - !ruby/object:Gem::Dependency
   name: rake
-  requirement: !ruby/object:Gem::Requirement
+  version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ~>
       - !ruby/object:Gem::Version
         version: '10.0'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
+  requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ~>
       - !ruby/object:Gem::Version
         version: '10.0'
+  prerelease: false
+  type: :development
 - !ruby/object:Gem::Dependency
   name: rspec
-  requirement: !ruby/object:Gem::Requirement
+  version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ~>
       - !ruby/object:Gem::Version
         version: '3.2'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
+  requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ~>
       - !ruby/object:Gem::Version
         version: '3.2'
-description: Turbine is a performance-oriented stream processor built on Zookeeper
+  prerelease: false
+  type: :development
+description: Performance-oriented stream processing built on Kafka and Zookeeper
 email:
 - bascule@gmail.com
 executables: []
 extensions: []
 extra_rdoc_files: []
 files:
-- ".gitignore"
-- ".rspec"
-- ".rubocop.yml"
-- ".travis.yml"
+- .gitignore
+- .rspec
+- .rubocop.yml
+- .travis.yml
 - CODE_OF_CONDUCT.md
 - Gemfile
 - Guardfile
@@ -131,8 +131,9 @@ files:
 - lib/turbine/batch.rb
 - lib/turbine/consumer.rb
 - lib/turbine/consumer/kafka.rb
+- lib/turbine/kafka_helper.rb
 - lib/turbine/processor.rb
-- lib/turbine/rspec/kafka_helper.rb
+- lib/turbine/rake_tasks.rb
 - lib/turbine/version.rb
 - spec/spec_helper.rb
 - spec/turbine/batch_spec.rb
@@ -149,24 +150,24 @@ homepage: https://github.com/tarcieri/turbine
 licenses:
 - MIT
 metadata: {}
-post_install_message: 
+post_install_message:
 rdoc_options: []
 require_paths:
 - lib
 required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
-  - - ">="
+  - - '>='
     - !ruby/object:Gem::Version
       version: '0'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
-  - - ">"
+  - - '>'
     - !ruby/object:Gem::Version
       version: 1.3.1
 requirements: []
-rubyforge_project: 
-rubygems_version: 2.4.6
-signing_key: 
+rubyforge_project:
+rubygems_version: 2.4.5
+signing_key:
 specification_version: 4
 summary: Fault-tolerant multithreaded stream processing for Ruby
 test_files: []

data/lib/turbine/rspec/kafka_helper.rb

@@ -1,85 +0,0 @@
-require "open3"
-require "poseidon"
-
-# Helper functions for integration testing with Kafka
-module KafkaHelper
-  extend self
-
-  ZOOKEEPER_ADDR = "localhost:2181"
-  KAFKA_ADDR     = "localhost:9092"
-
-  def delete_topic(topic)
-    log "*** Deleting Kafka topic: #{topic}"
-
-    topic_command :delete, topic: topic
-  end
-
-  def create_topic(topic)
-    log "*** Creating Kafka topic: #{topic}"
-
-    required_topic_command :create,
-                           "replication-factor" => 1,
-                           "partitions"         => 1,
-                           "topic"              => topic
-  end
-
-  def list_topics
-    topic_command(:list).split("\n")
-  end
-
-  def topic_exists?(topic)
-    list_topics.include?(topic)
-  end
-
-  def fill_topic(topic, n = 100_000)
-    fail ArgumentError, "min messages is 1000" if n < 1000
-
-    producer = Poseidon::Producer.new([KAFKA_ADDR], "my_test_producer", type: :sync)
-
-    log "*** Filling topic with #{n} messages: #{topic}"
-
-    (n / 1000).times do |i|
-      messages = []
-
-      1000.times do |j|
-        n = (i * 1000 + j)
-        messages << Poseidon::MessageToSend.new(topic, n.to_s)
-      end
-
-      producer.send_messages(messages)
-    end
-  ensure
-    producer.close if producer
-  end
-
-  private
-
-  def kafka_path
-    File.expand_path("../../../../kafka", __FILE__)
-  end
-
-  def kafka_topics_bin_path
-    "#{kafka_path}/bin/kafka-topics.sh"
-  end
-
-  def kafka_args(args = {})
-    { zookeeper: ZOOKEEPER_ADDR }.merge(args).map { |k, v| "--#{k} #{v}" }.join(" ")
-  end
-
-  def topic_command(command, args = {})
-    cmd = "#{kafka_topics_bin_path} --#{command} #{kafka_args(args)}"
-    stdout_str, _stderr_str, status = Open3.capture3(cmd)
-    return unless status.success?
-    stdout_str
-  end
-
-  def required_topic_command(command, args = {})
-    result = topic_command(command, args)
-    fail "Kafka command failed!" unless result
-    true
-  end
-
-  def log(message)
-    STDERR.puts(message)
-  end
-end