tunemygc 1.0.46 → 1.0.47

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 49de1d99a256241f20303c4a9aadad76f38d018a
-  data.tar.gz: 6ad5a64acd9b13d07b97dfcca71c96b0117c1c72
+  metadata.gz: fdd4781423af377b02af2c99a16794cdec61e12e
+  data.tar.gz: b5c7fc03f4693a1d2ccc3015b1363fe4b1da4e6a
 SHA512:
-  metadata.gz: e2c5826b227af1523049f58f76193ea72a96e05892a9bd3ab4222ea5af6e62e5b0db157f71dd3ef7463b1397baac78e0d8aaa1a602141730c26b05bb8c92ef84
-  data.tar.gz: c1c2955d6bfc5b7724ad0bed2eed20bdeb1792094bda6802d3ef8ec16dbd0c69d1a005f20e7b295e8c34c4c6983043f5e191cf1b16f7dc409427eee425ad2a10
+  metadata.gz: fdb95cbb93251ff6ecfa865ebf058c2be1d28a69177513973bbdb4a9b5303ebf2f6bb8477a9c7ef0abb1fb5f990726f3656366e3de995412f210a229c0c7b9eb
+  data.tar.gz: b3e123b1e316e8b35ff1d475b1c849b73f2cdfb38b7bdc594c6aaf91a3089cd4cec5c33f218e12652331768b26488c8b3c645531cf806c04c4ade350d93297b6

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    tunemygc (1.0.43)
+    tunemygc (1.0.46)
 
 GEM
   remote: https://rubygems.org/

data/README.md

@@ -6,7 +6,7 @@ The Ruby garbage collector has been flagged as the crux of Ruby performance and
 
 ## We're fixing this
 
-![tunemygc workflow diagram](https://raw.githubusercontent.com/bear-metal/tunemygc/master/assets/tunemygc-graphic2x-80dac1571cacc70d9b272bb62ae9f6df.png?token=AAABe8sM_ofiQkrCpNw7OYRbtHMLO9l5ks5UuQlYwA%3D%3D)
+![tunemygc workflow diagram](https://raw.githubusercontent.com/bear-metal/tunemygc/master/assets/tunemygc-graphic2x-b3390590eadab5528577f4e0285330fd.png?token=AAABe8sM_ofiQkrCpNw7OYRbtHMLO9l5ks5UuQlYwA%3D%3D)
 
 We also recently [blogged](http://bearmetal.eu/theden/2015-02-20-rails-garbage-collection-tuning-approaches) about how the product works.
 

data/lib/tunemygc/agent.rb

@@ -35,11 +35,11 @@ module TuneMyGc
     logger.info "[TuneMyGC, pid: #{Process.pid}] #{message}"
   end
 
-  def spy_id
-    TuneMyGc::Spies.id
+  def spy_ids
+    TuneMyGc::Spies.ids
   end
 
-  def spy
+  def spies
     TuneMyGc::Spies.current
   end
 

data/lib/tunemygc/interposer.rb

@@ -4,12 +4,16 @@ require 'tunemygc/spies'
 
 module TuneMyGc
   class Interposer
-    attr_reader :spy
+    attr_reader :spies
     attr_accessor :installed
 
-    def initialize(spy = TuneMyGc.spy)
+    def initialize(spies = TuneMyGc.spies)
       reset
-      @spy = TuneMyGc::Spies.const_get(spy).new
+      @spies = spies.map{|s| TuneMyGc::Spies.const_get(s).new }
+    end
+
+    def spy
+      @spies.first
     end
 
     def on_initialized
@@ -17,7 +21,7 @@ module TuneMyGc
       TuneMyGc.install_gc_tracepoint
       TuneMyGc.log "hooked: GC tracepoints"
       TuneMyGc.snapshot(:BOOTED)
-      TuneMyGc.interposer.spy.install
+      TuneMyGc.interposer.spies.each{|s| s.install }
     end
 
     def install
@@ -36,7 +40,7 @@ module TuneMyGc
       at_exit do
         if @installed
           TuneMyGc.log "at_exit"
-          @spy.uninstall
+          @spies.each{|s| s.uninstall }
           TuneMyGc.snapshot(:TERMINATED)
           TuneMyGc.reccommendations
         end
@@ -47,13 +51,13 @@ module TuneMyGc
     end
 
     def check_uninstall
-      @spy.check_uninstall
+      @spies.each{|s| s.check_uninstall }
     end
 
     def uninstall
       TuneMyGc.uninstall_gc_tracepoint
       TuneMyGc.log "uninstalled GC tracepoint"
-      @spy.uninstall
+      @spies.each{|s| s.uninstall }
       reset
     end
 

data/lib/tunemygc/spies.rb

@@ -15,15 +15,19 @@ module TuneMyGc
     spy :Rspec, 'rspec'
     spy :QueJob, 'que_job'
 
-    def self.id
-      @spies.key(current)
+    def self.ids
+      current.map do |spy|
+        @spies.key(spy)
+      end.join(',')
     end
 
     def self.current
       if ENV['RUBY_GC_SPY']
-        @spies[ENV['RUBY_GC_SPY']] || raise(NotImplementedError, "TuneMyGC spy #{ENV['RUBY_GC_SPY']} not supported. Valid spies are #{@spies.keys}")
+        ENV['RUBY_GC_SPY'].split(",").map do |spy|
+          @spies[spy] || raise(NotImplementedError, "TuneMyGC spy #{spy} not supported. Valid spies are #{@spies.keys}")
+        end
       else
-        TuneMyGc.rails? ? 'ActionController' : 'Manual'
+        [(TuneMyGc.rails? ? 'ActionController' : 'Manual')]
       end
     end
   end

data/lib/tunemygc/syncer.rb

@@ -59,7 +59,7 @@ module TuneMyGc
     end
 
     def environment(snapshotter)
-      ENVIRONMENT.dup.concat([snapshotter.stat_keys, TuneMyGc.spy_id, Socket.gethostname, Process.ppid, Process.pid])
+      ENVIRONMENT.dup.concat([snapshotter.stat_keys, TuneMyGc.spy_ids, Socket.gethostname, Process.ppid, Process.pid])
     end
 
     private

data/lib/tunemygc/version.rb

@@ -1,5 +1,5 @@
 # encoding: utf-8
 
 module TuneMyGc
-  VERSION = "1.0.46"
+  VERSION = "1.0.47"
 end

data/test/test_activejob_interposer.rb

@@ -14,17 +14,17 @@ class TestActiveJobInterposer < TuneMyGcTestCase
   end
 
   def teardown
-    TuneMyGc.interposer = TuneMyGc::Interposer.new(:ActionController)
+    TuneMyGc.interposer = TuneMyGc::Interposer.new([:ActionController])
   end
 
   def test_init
-    TuneMyGc.interposer = TuneMyGc::Interposer.new(:ActiveJob)
+    TuneMyGc.interposer = TuneMyGc::Interposer.new([:ActiveJob])
     interposer = TuneMyGc.interposer
     assert !interposer.installed
   end
 
   def test_install_uninstall
-    TuneMyGc.interposer = TuneMyGc::Interposer.new(:ActiveJob)
+    TuneMyGc.interposer = TuneMyGc::Interposer.new([:ActiveJob])
     interposer = TuneMyGc.interposer
     interposer.install
     interposer.on_initialized
@@ -35,7 +35,7 @@ class TestActiveJobInterposer < TuneMyGcTestCase
   end
 
   def test_gc_hooks
-    TuneMyGc.interposer = TuneMyGc::Interposer.new(:ActiveJob)
+    TuneMyGc.interposer = TuneMyGc::Interposer.new([:ActiveJob])
     interposer = TuneMyGc.interposer
     interposer.install
     TuneMyGc.interposer.on_initialized
@@ -58,7 +58,7 @@ class TestActiveJobInterposer < TuneMyGcTestCase
   end
 
   def test_tests_limit
-    TuneMyGc.interposer = TuneMyGc::Interposer.new(:ActiveJob)
+    TuneMyGc.interposer = TuneMyGc::Interposer.new([:ActiveJob])
     interposer = TuneMyGc.interposer
     interposer.install
     TuneMyGc.interposer.on_initialized

data/test/test_agent.rb

@@ -12,10 +12,13 @@ class TestAgent < TuneMyGcTestCase
   end
 
   def test_spy
-    assert_equal 'ActionController', TuneMyGc.spy
+    assert_equal ['ActionController'], TuneMyGc.spies
     ENV['RUBY_GC_SPY'] = "minitest"
-    assert_equal 'Minitest', TuneMyGc.spy
-    assert_equal 'minitest', TuneMyGc.spy_id
+    assert_equal ['Minitest'], TuneMyGc.spies
+    assert_equal 'minitest', TuneMyGc.spy_ids
+    ENV['RUBY_GC_SPY'] = "action_controller,active_job"
+    assert_equal ['ActionController','ActiveJob'], TuneMyGc.spies
+    assert_equal 'action_controller,active_job', TuneMyGc.spy_ids
   ensure
     ENV.delete('RUBY_GC_SPY')
   end

data/test/test_minitest_interposer.rb

@@ -18,17 +18,17 @@ class TestMinitestInterposer < TuneMyGcTestCase
   end
 
   def teardown
-    TuneMyGc.interposer = TuneMyGc::Interposer.new(:ActionController)
+    TuneMyGc.interposer = TuneMyGc::Interposer.new([:ActionController])
   end
 
   def test_init
-    TuneMyGc.interposer = TuneMyGc::Interposer.new(:Minitest)
+    TuneMyGc.interposer = TuneMyGc::Interposer.new([:Minitest])
     interposer = TuneMyGc.interposer
     assert !interposer.installed
   end
 
   def test_install_uninstall
-    TuneMyGc.interposer = TuneMyGc::Interposer.new(:Minitest)
+    TuneMyGc.interposer = TuneMyGc::Interposer.new([:Minitest])
     interposer = TuneMyGc.interposer
     interposer.install
     interposer.on_initialized
@@ -39,7 +39,7 @@ class TestMinitestInterposer < TuneMyGcTestCase
   end
 
   def test_gc_hooks
-    TuneMyGc.interposer = TuneMyGc::Interposer.new(:Minitest)
+    TuneMyGc.interposer = TuneMyGc::Interposer.new([:Minitest])
     interposer = TuneMyGc.interposer
     interposer.install
     TuneMyGc.interposer.on_initialized
@@ -62,7 +62,7 @@ class TestMinitestInterposer < TuneMyGcTestCase
   end
 
   def test_tests_limit
-    TuneMyGc.interposer = TuneMyGc::Interposer.new(:Minitest)
+    TuneMyGc.interposer = TuneMyGc::Interposer.new([:Minitest])
     interposer = TuneMyGc.interposer
     interposer.install
     TuneMyGc.interposer.on_initialized

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: tunemygc
 version: !ruby/object:Gem::Version
-  version: 1.0.46
+  version: 1.0.47
 platform: ruby
 authors:
 - Bear Metal
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-03-20 00:00:00.000000000 Z
+date: 2015-03-26 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport
@@ -109,7 +109,7 @@ files:
 - README.md
 - Rakefile
 - assets/discourse_bench.png
-- assets/tunemygc-graphic2x-80dac1571cacc70d9b272bb62ae9f6df.png
+- assets/tunemygc-graphic2x-b3390590eadab5528577f4e0285330fd.png
 - bin/tunemygc
 - doc/protocol.md
 - ext/tunemygc/extconf.rb