tunable 0.1.1 → 0.1.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 5f3e0b03aefc94040217c4c2b0b4e58da393015ea4296dee04f2efc1e13de95c
-  data.tar.gz: 4a5d9dd43998e77b677cb5c652366e6ad3fbaab97a0e458358c2f912b1ef9ebb
+  metadata.gz: 06555f6a3bee956eca97a530f55f2a461b08d910cf0f8c47ab72d01a92e7423a
+  data.tar.gz: 8232870c5a435f1bd76b63f722988669974cab0ebe053b9196ac2b6b821b9e0c
 SHA512:
-  metadata.gz: e10ebb099faa035fe760a6b6c42acaabdb603513378bd4bd24c586cf1c3c872a3fa0597b2863760f715da6f8754b2671ed86a78fdf33f4f0ae6008366ddf060e
-  data.tar.gz: '019c5b00133fcad806079acd55c5152c599e70bda44474fcb904769399e1d54d8e8ee9403970a7b026510890f071973975757c7d9e416aabadc0922075d880da'
+  metadata.gz: 8dd607c4e3526efa2d55159ef7321d39caae9ea92e43b22745f1227225a00783081cf81c6557bec5a1b2ca35352239300f0d274c2c6257d63949bac181b075d2
+  data.tar.gz: 60257e7911a71e33cd58c179340a7f1f54b438c4b8bc932d2be631b9562e6bed232ddff900d8c2de7c67824f882daba44a2158d8961461b93f3ac6a22685e958

data/Gemfile

@@ -1,4 +1,4 @@
-source :rubygems
+source 'https://rubygems.org'
 
 # specified in gemspec
 gemspec

data/lib/tunable/core_ext.rb

@@ -13,7 +13,7 @@ module Tunable
 
       values_array = values.map do |arr|
         arr.map do |val, i|
-          val == true ? '"true"' : val == false ? '"false"' : connection.quote(val)
+          val == true ? "'true'" : val == false ? "'false'" : connection.quote(val)
         end.join(',')
       end
 

data/lib/tunable/setting.rb

@@ -26,7 +26,7 @@ module Tunable
 
       hash.each do |context, fields|
         fields.each do |key, val|
-          if val.blank? && !object.settings_context(context.to_sym)[key.to_sym].nil?
+          if (val.nil? || val == '') && !object.settings_context(context.to_sym)[key.to_sym].nil?
 
             # setting was present and now deleted
             object.queue_setting_for_deletion(context, key)
@@ -51,7 +51,7 @@ module Tunable
     end
 
     def value=(val)
-      self[:value] = Tunable.normalize_value(val)
+      self[:value] = Tunable.normalize_value(val).to_s
     end
 
   end

data/lib/tunable/version.rb

@@ -1,3 +1,3 @@
 module Tunable
-  VERSION = '0.1.1'
+  VERSION = '0.1.4'
 end

data/spec/spec_helper.rb

@@ -10,6 +10,7 @@ ActiveRecord::Base.establish_connection(
 )
 
 ActiveRecord::Base.logger = Logger.new(File.join(File.dirname(__FILE__), "debug.log"))
+# ActiveRecord::Base.logger = Logger.new(STDOUT)
 
 this_path = File.dirname(__FILE__)
 load File.join(this_path, '/schema.rb')

data/spec/tunable/setting_model_spec.rb

@@ -0,0 +1,73 @@
+require File.expand_path(File.dirname(__FILE__) + '/../spec_helper')
+
+describe Tunable::Setting do
+
+  before :all do
+    load_main_settings!
+    @model = TunableModel.create(name: "Yay, I'm settable!")
+  end
+
+  describe '#value=' do
+
+    it 'normalizes correctly' do
+      setting = @model.settings.new(context: 'test', key: 'foo', value: 'true')
+      expect(setting.value).to eq('true')
+      expect(setting[:value]).to eq('true')
+
+      setting.value = true
+      expect(setting.value).to eq('true')
+      expect(setting[:value]).to eq('true')
+
+      setting.value = 'false'
+      expect(setting.value).to eq('false')
+      expect(setting[:value]).to eq('false')
+
+      setting.value = false
+      expect(setting.value).to eq('false')
+      expect(setting[:value]).to eq('false')
+
+      setting.value = '1'
+      expect(setting.value).to eq('1')
+      expect(setting[:value]).to eq('1')
+
+      setting.value = 1
+      expect(setting.value).to eq('1')
+      expect(setting[:value]).to eq('1')
+
+      setting.value = '0'
+      expect(setting.value).to eq('0')
+      expect(setting[:value]).to eq('0')
+
+      setting.value = 0
+      expect(setting.value).to eq('0')
+      expect(setting[:value]).to eq('0')
+    end
+
+  end
+
+  describe '.import SQL quoting' do
+    it 'wraps boolean true/false in single quotes, not double quotes' do
+      columns = [:context, :key, :value, :settable_id, :settable_type]
+      values = [
+        ['test', 'bool_true', true, 1, 'TunableModel'],
+        ['test', 'bool_false', false, 1, 'TunableModel'],
+      ]
+
+      sqls = []
+      expect(ActiveRecord::Base.connection).to receive(:execute).twice do |sql|
+        sqls << sql
+      end
+
+      Tunable::Setting.import(columns, values, method: 'REPLACE')
+
+      sqls.each do |sql|
+        expect(sql).not_to include('"true"')
+        expect(sql).not_to include('"false"')
+      end
+
+      expect(sqls.any? { |s| s.include?("'true'") }).to be true
+      expect(sqls.any? { |s| s.include?("'false'") }).to be true
+    end
+  end
+
+end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: tunable
 version: !ruby/object:Gem::Version
-  version: 0.1.1
+  version: 0.1.4
 platform: ruby
 authors:
 - Tomás Pollak
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2025-08-22 00:00:00.000000000 Z
+date: 2026-07-06 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activerecord
@@ -108,6 +108,7 @@ files:
 - spec/tunable/normalization_spec.rb
 - spec/tunable/querying_spec.rb
 - spec/tunable/setters_spec.rb
+- spec/tunable/setting_model_spec.rb
 - tunable.gemspec
 homepage: https://github.com/tomas/tunable
 licenses: []