tunable 0.0.5 → 0.0.7

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 18948658c5465d7de3637533a887367622d7c1067d60cc67cb4a340936144fa7
-  data.tar.gz: 9caad8b2f1e03f15c862e4ae44b5f07f423ab21f2fbde7be9c0bf3ce2ceafa8c
+  metadata.gz: 17046a0d75a1878088af83018d2ec30961dd0ddc0e07eeb692a443b3c93785ed
+  data.tar.gz: 3bccc8448310b98a5db13f9e5231236d1e211e537d680dbe8d081baf383430ba
 SHA512:
-  metadata.gz: 1843588f136e89158718d78765dfede4be12a7748ecb6e2572c8e349b0b847209ab7f8b2e7239529eab4fc1885e0c3ee37b96f437f866d8230930efc1216dc38
-  data.tar.gz: 204320680e9719bcb102c25c166bb20c1df168b98fc788b2476e9106e0f81c352c01a4ad656747d811ac5b4a5d6b8207ab2cb8cd86f4e606f00ef711381dd82e
+  metadata.gz: d0b26b12263cedeaf93fbac85be0443faa4e933945de7cabd7453c2f76f91de2a537e6d6a01f63d8931983c236b8d4d5276731f9eb161555455abf46202f57ff
+  data.tar.gz: b987b703ba9930bca04279aaeaec1b6b8afe4a531b51185baf3cd4201b52087e4f9ec0230e8fd0a44eed545629d7b4bc3651bca52063c95d2a515b1cb57ce324

data/lib/tunable/model.rb

@@ -57,6 +57,17 @@ module Tunable
               default = opts
             end
 
+            getter = "#{name}_#{field}"
+
+            define_method getter do
+              get_setting(name, field)
+            end
+
+            define_method "#{getter}=" do |value|
+              # self.settings = { name => { field => val } }
+              set_setting(name, field, value)
+            end
+
             set_default_setting(name, field, default) unless default.nil?
           end
         end
@@ -109,7 +120,7 @@ module Tunable
 
             if value === current
               # puts 'Value is same as current'
-              @changed_attributes.delete(field) # in case we had set if before
+              changed_attributes.delete(field) # in case we had set if before
               return
             end
 
@@ -189,14 +200,14 @@ module Tunable
 
     def queue_setting_for_update(context, key, val)
       if self.class.main_settings_list.include?(key.to_sym)
-        @changed_attributes[key.to_sym] = val if changed_attributes.include?(key.to_sym)
+        changed_attributes[key.to_sym] = val if changed_attributes.include?(key.to_sym)
       end
       (modified_settings[context.to_sym] ||= {})[key.to_sym] = val
     end
 
     def queue_setting_for_deletion(context, key)
       if self.class.main_settings_list.include?(key)
-        @changed_attributes[key.to_sym] = nil if changed_attributes.include?(key.to_sym)
+        changed_attributes[key.to_sym] = nil if changed_attributes.include?(key.to_sym)
       end
       (deleted_settings[context.to_sym] ||= []) << key.to_sym
     end
@@ -228,12 +239,12 @@ module Tunable
     end
 
     def delete_setting(context, key)
-      Tunable::Setting.delete_all(
-        :context       => context.to_s,
-        :key           => key.to_s,
-        :settable_type => self.class.model_name.to_s,
-        :settable_id   => self.id
-      )
+      Tunable::Setting.where(
+        context: context.to_s,
+        key: key.to_s,
+        settable_type: self.class.model_name.to_s,
+        settable_id: self.id
+      ).delete_all
     end
 
     def save_new_settings

data/lib/tunable/version.rb

@@ -1,5 +1,3 @@
 module Tunable
-
-  VERSION = '0.0.5'
-
+  VERSION = '0.0.7'
 end

data/spec/tunable/defaults_spec.rb

@@ -93,7 +93,7 @@ describe 'defaults' do
           }
 
           @foo = TunableModel.new
-          @foo.update_attributes(@new_settings)
+          @foo.update(@new_settings)
         end
 
         describe 'settings_hash' do

data/spec/tunable/getters_spec.rb

@@ -0,0 +1,26 @@
+require File.expand_path(File.dirname(__FILE__) + '/../spec_helper')
+
+describe 'basic setters' do
+
+  before :all do
+    TunableModel.has_settings \
+      :website => {
+        super_mode: { default: false }
+      }
+
+    @model = TunableModel.create(name: "Yay, I'm settable!")
+  end
+
+
+  it 'has getters setters scoped by context' do
+    expect(@model.respond_to?(:website_super_mode)).to eq(true)
+    expect(@model.respond_to?(:website_super_mode=)).to eq(true)
+
+    expect(@model.website_super_mode).to eq(false)
+    expect(@model.website_super_mode = true).to eq(true)
+    expect(@model.website_super_mode).to eq(false)
+    @model.save
+    expect(@model.website_super_mode).to eq(true)
+  end
+
+end

data/spec/tunable/normalization_spec.rb

@@ -188,7 +188,7 @@ describe 'normalization' do
     describe 'using settings relationship' do
 
       before :all do
-        @model.update_attributes(:settings => VALUE_TYPES)
+        @model.update(:settings => VALUE_TYPES)
       end
 
       after :all do

data/tunable.gemspec

@@ -14,12 +14,12 @@ Gem::Specification.new do |s|
   s.required_rubygems_version = ">= 1.3.6"
   # s.rubyforge_project         = "tunable"
 
-  s.add_runtime_dependency "activerecord", "~> 4.2.x"
-  s.add_runtime_dependency "activesupport", "~> 4.2.x"
+  s.add_runtime_dependency "activerecord" #, "~> 4.2.x"
+  s.add_runtime_dependency "activesupport" #, "~> 4.2.x"
 
   s.add_development_dependency "bundler" #, '~> 1.0', '>= 1.0.0'
   s.add_development_dependency "rspec" #, '~> 3.0', '>= 3.0.0'
-  s.add_development_dependency "sqlite3", '< 1.4.x'
+  s.add_development_dependency "sqlite3" #, '< 1.4.x'
 
   s.files        = `git ls-files`.split("\n")
   s.executables  = `git ls-files`.split("\n").map{|f| f =~ /^bin\/(.*)/ ? $1 : nil}.compact

metadata

@@ -1,43 +1,43 @@
 --- !ruby/object:Gem::Specification
 name: tunable
 version: !ruby/object:Gem::Version
-  version: 0.0.5
+  version: 0.0.7
 platform: ruby
 authors:
 - Tomás Pollak
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2022-05-30 00:00:00.000000000 Z
+date: 2023-04-18 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activerecord
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: 4.2.x
+        version: '0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: 4.2.x
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: activesupport
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: 4.2.x
+        version: '0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: 4.2.x
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: bundler
   requirement: !ruby/object:Gem::Requirement
@@ -70,16 +70,16 @@ dependencies:
   name: sqlite3
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "<"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: 1.4.x
+        version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "<"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: 1.4.x
+        version: '0'
 description: Pluggable settings for your AR models.
 email:
 - tomas@forkhq.com
@@ -104,6 +104,7 @@ files:
 - spec/schema.rb
 - spec/spec_helper.rb
 - spec/tunable/defaults_spec.rb
+- spec/tunable/getters_spec.rb
 - spec/tunable/normalization_spec.rb
 - spec/tunable/querying_spec.rb
 - spec/tunable/setters_spec.rb
@@ -126,8 +127,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: 1.3.6
 requirements: []
-rubyforge_project: 
-rubygems_version: 2.7.3
+rubygems_version: 3.4.6
 signing_key: 
 specification_version: 4
 summary: Pluggable settings for your AR models.