tui-td 0.2.10 → 0.2.12

data/lib/tui_td/ansi_utils.rb

@@ -1,75 +1,7 @@
 # frozen_string_literal: true
 
-module TUITD
-  # Shared ANSI color constants and helpers.
-  # Used by Screenshot, HtmlRenderer, and other color-aware renderers.
-  module ANSIUtils
-    ANSI_RGB = {
-      "black"         => [0x00, 0x00, 0x00],
-      "red"           => [0xAA, 0x00, 0x00],
-      "green"         => [0x00, 0xAA, 0x00],
-      "yellow"        => [0xAA, 0x55, 0x00],
-      "blue"          => [0x00, 0x00, 0xAA],
-      "magenta"       => [0xAA, 0x00, 0xAA],
-      "cyan"          => [0x00, 0xAA, 0xAA],
-      "white"         => [0xAA, 0xAA, 0xAA],
-      "bright_black"  => [0x55, 0x55, 0x55],
-      "bright_red"    => [0xFF, 0x55, 0x55],
-      "bright_green"  => [0x55, 0xFF, 0x55],
-      "bright_yellow" => [0xFF, 0xFF, 0x55],
-      "bright_blue"   => [0x55, 0x55, 0xFF],
-      "bright_magenta"=> [0xFF, 0x55, 0xFF],
-      "bright_cyan"   => [0x55, 0xFF, 0xFF],
-      "bright_white"  => [0xFF, 0xFF, 0xFF],
-    }.freeze
-
-    CUBE = [0x00, 0x5F, 0x87, 0xAF, 0xD7, 0xFF].freeze
-
-    ANSI_INDEX = %w[
-      black red green yellow blue magenta cyan white
-      bright_black bright_red bright_green bright_yellow
-      bright_blue bright_magenta bright_cyan bright_white
-    ].freeze
-
-    DEFAULT_FG = [0xC0, 0xC0, 0xC0].freeze
-    DEFAULT_BG = [0x00, 0x00, 0x00].freeze
+require "tans-parser"
 
-    def resolve_color(name, fallback)
-      case name
-      when "default"
-        fallback
-      when /^#([0-9a-fA-F]{6})$/
-        [$1[0..1].to_i(16), $1[2..3].to_i(16), $1[4..5].to_i(16)]
-      when /\Acolor(\d+)\z/
-        xterm_256($1.to_i)
-      when /\Abright_(.+)\z/
-        ANSI_RGB[name] || fallback
-      else
-        ANSI_RGB[name] || fallback
-      end
-    end
-
-    def xterm_256(index)
-      if index < 16
-        name = ANSI_INDEX[index]
-        ANSI_RGB[name] || DEFAULT_FG
-      elsif index < 232
-        r = CUBE[((index - 16) / 36) % 6]
-        g = CUBE[((index - 16) / 6) % 6]
-        b = CUBE[(index - 16) % 6]
-        [r, g, b]
-      else
-        v = 8 + (index - 232) * 10
-        [v, v, v]
-      end
-    end
-
-    def _dig(hash, *keys)
-      keys.each do |k|
-        return nil unless hash
-        hash = hash[k] || hash[k.to_s]
-      end
-      hash
-    end
-  end
+module TUITD
+  ANSIUtils = TansParser::ANSIUtils
 end

data/lib/tui_td/cairo_renderer.rb

@@ -1,5 +1,7 @@
 # frozen_string_literal: true
 
+# rubocop:disable Metrics/MethodLength, Metrics/AbcSize, Metrics/ParameterLists
+
 module TUITD
   module CairoRenderer
     CELL_W = 8
@@ -76,9 +78,9 @@ module TUITD
           CELL_W.times do |dx|
             sum = 0
             scale.times do |sy|
-              row_off = (dy * scale + sy) * stride
+              row_off = ((dy * scale) + sy) * stride
               scale.times do |sx|
-                sum += data.getbyte(row_off + (dx * scale + sx) * 4 + 3)
+                sum += data.getbyte(row_off + (((dx * scale) + sx) * 4) + 3)
               end
             end
             alpha_grid[dy][dx] = sum / scale_sq
@@ -107,3 +109,4 @@ module TUITD
     end
   end
 end
+# rubocop:enable Metrics/MethodLength, Metrics/AbcSize, Metrics/ParameterLists

data/lib/tui_td/cli.rb

@@ -1,5 +1,7 @@
 # frozen_string_literal: true
 
+# rubocop:disable Metrics/ClassLength, Metrics/MethodLength, Metrics/AbcSize, Metrics/CyclomaticComplexity, Metrics/PerceivedComplexity, Metrics/BlockLength
+
 require "optparse"
 
 module TUITD
@@ -11,7 +13,7 @@ module TUITD
 
     def run(argv)
       global_opts = {}
-      command = nil
+      nil
       command_opts = {}
 
       OptionParser.new do |opts|
@@ -131,7 +133,7 @@ module TUITD
       server = MCP::Server.new(
         rows: globals[:rows] || 40,
         cols: globals[:cols] || 120,
-        timeout: globals[:timeout] || 30
+        timeout: globals[:timeout] || 30,
       )
       server.start
     end
@@ -148,7 +150,7 @@ module TUITD
 
       driver.wait_for_stable
 
-      if globals[:format] == :json || globals[:format] == :pretty_json
+      if %i[json pretty_json].include?(globals[:format])
         puts driver.state_json(pretty: globals[:format] == :pretty_json)
       else
         _render_text(driver.state_data)
@@ -182,6 +184,7 @@ module TUITD
           print "> "
           input = $stdin.gets
           break unless input
+
           input = input.chomp
           break if input == "exit"
 
@@ -195,7 +198,7 @@ module TUITD
           elsif input.start_with?("key ")
             driver.send_keys(input.split(" ", 2).last.to_sym)
           else
-            driver.send(input + "\n")
+            driver.send("#{input}\n")
           end
         end
       rescue Interrupt
@@ -258,16 +261,14 @@ module TUITD
 
       on_step = if verbose || live || step_mode
                   lambda do |info|
-                    if live && info[:driver]
-                      info[:driver].wait_for_stable(stable_ms: 200)
-                    end
+                    info[:driver].wait_for_stable(stable_ms: 200) if live && info[:driver]
                     if verbose
                       status = info[:result].passed ? "PASS" : "FAIL"
                       puts "[#{info[:index] + 1}/#{info[:total]}] #{info[:action]}: #{info[:result].message}"
                       puts "      → #{status}"
                     end
                     if live && info[:driver]
-                      print "\e[2J\e[H"  # clear screen, home cursor
+                      print "\e[2J\e[H" # clear screen, home cursor
                       _render_text(info[:driver].state_data)
                     end
                     if step_mode
@@ -285,7 +286,7 @@ module TUITD
 
       puts
       puts "Test: #{result[:name]}"
-      puts "Status: #{result[:passed] ? 'PASSED' : 'FAILED'}"
+      puts "Status: #{result[:passed] ? "PASSED" : "FAILED"}"
       puts "-" * 40
 
       result[:results].each do |r|
@@ -312,7 +313,7 @@ module TUITD
     end
 
     def _help_main
-      puts OptionParser.new { |o| o.banner = "Usage: tui-td <command> [options]" }
+      puts(OptionParser.new { |o| o.banner = "Usage: tui-td <command> [options]" })
       puts
       puts "For more: tui-td help test   (JSON test step types)"
       puts "          tui-td help rspec  (RSpec matchers)"
@@ -480,3 +481,4 @@ module TUITD
     end
   end
 end
+# rubocop:enable Metrics/ClassLength, Metrics/MethodLength, Metrics/AbcSize, Metrics/CyclomaticComplexity, Metrics/PerceivedComplexity, Metrics/BlockLength

data/lib/tui_td/driver.rb

@@ -1,8 +1,12 @@
 # frozen_string_literal: true
 
+# rubocop:disable Metrics/ClassLength, Metrics/MethodLength, Metrics/CyclomaticComplexity, Metrics/PerceivedComplexity, Metrics/ParameterLists
+# rubocop:disable Naming/PredicateMethod
+
 require "pty"
 require "io/console"
 require "json"
+require "shellwords"
 
 module TUITD
   # Drives a TUI application in a pseudo-terminal (PTY).
@@ -17,6 +21,9 @@ module TUITD
   #   driver.close
   #
   class Driver
+    FORBIDDEN_ENV = %w[PATH LD_PRELOAD LD_LIBRARY_PATH DYLD_INSERT_LIBRARIES
+                       DYLD_FRAMEWORK_PATH RUBYOPT HOME RUBYLIB GEM_HOME GEM_PATH].freeze
+
     attr_reader :command, :state
 
     def initialize(command, rows: 40, cols: 120, timeout: 30, chdir: nil, env: {})
@@ -25,7 +32,7 @@ module TUITD
       @cols = cols
       @timeout = timeout
       @chdir = chdir
-      @env = env
+      @env = sanitize_env(env)
       @state = nil
       @stdin = nil
       @stdout = nil
@@ -38,12 +45,14 @@ module TUITD
 
     # Start the TUI application in a PTY
     def start
-      env = { "TERM" => "xterm-256color", "COLUMNS" => @cols.to_s, "LINES" => @rows.to_s }.merge(@env.transform_keys(&:to_s))
+      env = { "TERM" => "xterm-256color", "COLUMNS" => @cols.to_s,
+              "LINES" => @rows.to_s, }.merge(@env.transform_keys(&:to_s))
       spawn_opts = {}
       spawn_opts[:chdir] = @chdir if @chdir
 
-      @stdout, @stdin, @pid = PTY.spawn(env, @command, spawn_opts)
-      @stdout.winsize = [@rows, @cols]  # Set PTY window size for TUIs that check winsize
+      cmd_args = Shellwords.shellsplit(@command)
+      @stdout, @stdin, @pid = PTY.spawn(env, *cmd_args, spawn_opts)
+      @stdout.winsize = [@rows, @cols] # Set PTY window size for TUIs that check winsize
       @wait_thr = Process.detach(@pid)
 
       # Read until initial output stabilizes
@@ -88,9 +97,11 @@ module TUITD
       deadline = monotonic + @timeout
       loop do
         raise TimeoutError, "Timeout waiting for: #{text.inspect}" if monotonic > deadline
+
         read_available!
         found = @output_mutex.synchronize { @output_buffer.include?(text) }
         break if found
+
         sleep 0.05
       end
       refresh_state!
@@ -117,7 +128,7 @@ module TUITD
         elsif !process_alive
           # Process exited and no more data — final state reached
           break
-        elsif last_grid && (monotonic - last_change) * 1000 >= stable_ms
+        elsif last_grid && (monotonic - last_change) * 1000 >= stable_ms # rubocop:disable Lint/DuplicateBranch
           break
         end
 
@@ -134,6 +145,7 @@ module TUITD
     # Get the process exit status (nil if still running)
     def exitstatus
       return nil unless @wait_thr
+
       status = @wait_thr.value
       status&.exitstatus
     rescue NoMethodError
@@ -179,16 +191,32 @@ module TUITD
       if @pid
         begin
           if Process.waitpid(@pid, Process::WNOHANG).nil?
-            Process.kill("TERM", @pid) rescue nil
+            begin
+              Process.kill("TERM", @pid)
+            rescue StandardError
+              nil
+            end
             sleep 0.05
-            Process.kill("KILL", @pid) rescue nil
+            begin
+              Process.kill("KILL", @pid)
+            rescue StandardError
+              nil
+            end
           end
         rescue Errno::ECHILD
           # Already reaped by Process.detach
         end
       end
-      @stdin&.close rescue nil
-      @stdout&.close rescue nil
+      begin
+        @stdin&.close
+      rescue StandardError
+        nil
+      end
+      begin
+        @stdout&.close
+      rescue StandardError
+        nil
+      end
       @stdin = @stdout = @pid = nil
     end
 
@@ -199,6 +227,7 @@ module TUITD
       @reader_thread = Thread.new do
         loop do
           break unless @reader_running
+
           begin
             read_available!
           rescue IOError, Errno::EIO
@@ -211,11 +240,19 @@ module TUITD
 
     def _stop_reader_thread
       @reader_running = false
-      if @reader_thread
-        @reader_thread.join(1)
-        @reader_thread.kill rescue nil
-        @reader_thread = nil
+      return unless @reader_thread
+
+      @reader_thread.join(1)
+      begin
+        @reader_thread.kill
+      rescue StandardError
+        nil
       end
+      @reader_thread = nil
+    end
+
+    def sanitize_env(env)
+      env.reject { |k, _| FORBIDDEN_ENV.include?(k.to_s.upcase) }
     end
 
     def ensure_running!
@@ -265,6 +302,7 @@ module TUITD
 
     def process_alive?
       return false unless @pid
+
       Process.waitpid(@pid, Process::WNOHANG).nil?
     rescue Errno::ECHILD
       false
@@ -273,7 +311,9 @@ module TUITD
     def monotonic
       Process.clock_gettime(Process::CLOCK_MONOTONIC)
     end
-    end
+  end
 
   class TimeoutError < Error; end
 end
+# rubocop:enable Metrics/ClassLength, Metrics/MethodLength, Metrics/CyclomaticComplexity, Metrics/PerceivedComplexity, Metrics/ParameterLists
+# rubocop:enable Naming/PredicateMethod

data/lib/tui_td/html_renderer.rb

@@ -1,5 +1,7 @@
 # frozen_string_literal: true
 
+# rubocop:disable Metrics/ClassLength, Metrics/MethodLength, Metrics/AbcSize, Metrics/CyclomaticComplexity, Metrics/PerceivedComplexity
+
 require_relative "ansi_utils"
 
 module TUITD
@@ -121,14 +123,14 @@ module TUITD
     def render_body
       lines = @grid.map.with_index do |row, ri|
         line_html = if row.nil? || row.empty?
-          '<span class="line"></span>'
-        else
-          runs = build_runs(row, ri)
-          spans = runs.map do |run|
-            render_run(run)
-          end
-          %(<span class="line">#{spans.join}</span>)
-        end
+                      '<span class="line"></span>'
+                    else
+                      runs = build_runs(row, ri)
+                      spans = runs.map do |run|
+                        render_run(run)
+                      end
+                      %(<span class="line">#{spans.join}</span>)
+                    end
         line_html
       end
 
@@ -140,7 +142,7 @@ module TUITD
       current_run = nil
 
       row.each_with_index do |cell, ci|
-        char = (cell[:char] || cell["char"] || " ")
+        char = cell[:char] || cell["char"] || " "
         fg = cell[:fg] || cell["fg"] || "default"
         bg = cell[:bg] || cell["bg"] || "default"
         bold = cell[:bold] || cell["bold"] || false
@@ -149,7 +151,7 @@ module TUITD
         blink = cell[:blink] || cell["blink"] || false
 
         style_key = [fg, bg, bold, italic, underline, blink]
-        is_cur = is_cursor?(ri, ci)
+        is_cur = cursor_at?(ri, ci)
 
         if current_run && current_run[:key] == style_key && !current_run[:has_cursor] && !is_cur
           current_run[:chars] << char
@@ -159,7 +161,7 @@ module TUITD
             chars: [char],
             style: cell_style(fg, bg, bold, italic, underline),
             has_cursor: is_cur,
-            blink: blink
+            blink: blink,
           }
           runs << current_run
         end
@@ -186,9 +188,7 @@ module TUITD
       if run[:has_cursor]
         classes << "cursor-cell"
         cursor_vis = @cursor[:visible] != false && @cursor["visible"] != false
-        if !cursor_vis
-          classes << "cursor-hidden"
-        else
+        if cursor_vis
           style_val = @cursor[:style] || @cursor["style"]
           case style_val
           when 0, 1
@@ -204,6 +204,8 @@ module TUITD
           when 6
             classes << "cursor-bar"
           end
+        else
+          classes << "cursor-hidden"
         end
       end
       classes << "term-blink" if run[:blink]
@@ -213,12 +215,12 @@ module TUITD
       %(<span#{cls}#{style}>#{chars}</span>)
     end
 
-    def is_cursor?(ri, ci)
+    def cursor_at?(ri, ci)
       (@cursor[:row] || @cursor["row"]) == ri && (@cursor[:col] || @cursor["col"]) == ci
     end
 
     def css_color(rgb)
-      format("#%02x%02x%02x", *rgb)
+      format("#%<r>02x%<g>02x%<b>02x", r: rgb[0], g: rgb[1], b: rgb[2])
     end
 
     def escape_html(char)
@@ -230,6 +232,6 @@ module TUITD
       else char
       end
     end
-
   end
 end
+# rubocop:enable Metrics/ClassLength, Metrics/MethodLength, Metrics/AbcSize, Metrics/CyclomaticComplexity, Metrics/PerceivedComplexity

data/lib/tui_td/matchers.rb

@@ -19,8 +19,8 @@ module TUITD
       end
 
       description { "have text #{expected.inspect}" }
-      failure_message { |state| "expected terminal to contain #{expected.inspect}" }
-      failure_message_when_negated { |state| "expected terminal NOT to contain #{expected.inspect}" }
+      failure_message { |_state| "expected terminal to contain #{expected.inspect}" }
+      failure_message_when_negated { |_state| "expected terminal NOT to contain #{expected.inspect}" }
     end
 
     RSpec::Matchers.define :have_regex do |pattern|
@@ -30,12 +30,15 @@ module TUITD
       end
 
       description { "match regex #{pattern.inspect}" }
-      failure_message { |state| "expected terminal to match #{pattern.inspect}" }
-      failure_message_when_negated { |state| "expected terminal NOT to match #{pattern.inspect}" }
+      failure_message { |_state| "expected terminal to match #{pattern.inspect}" }
+      failure_message_when_negated { |_state| "expected terminal NOT to match #{pattern.inspect}" }
     end
 
     RSpec::Matchers.define :have_fg do |expected|
-      chain(:at) { |row, col| @row, @col = row, col }
+      chain(:at) do |row, col|
+        @row = row
+        @col = col
+      end
 
       match do |state|
         @actual = state.foreground_at(@row, @col)
@@ -43,13 +46,16 @@ module TUITD
       end
 
       description { "have foreground #{expected.inspect} at [#{@row},#{@col}]" }
-      failure_message do |state|
+      failure_message do |_state|
         "expected FG at [#{@row},#{@col}] to be #{expected.inspect}, but was #{@actual.inspect}"
       end
     end
 
     RSpec::Matchers.define :have_bg do |expected|
-      chain(:at) { |row, col| @row, @col = row, col }
+      chain(:at) do |row, col|
+        @row = row
+        @col = col
+      end
 
       match do |state|
         @actual = state.background_at(@row, @col)
@@ -57,13 +63,16 @@ module TUITD
       end
 
       description { "have background #{expected.inspect} at [#{@row},#{@col}]" }
-      failure_message do |state|
+      failure_message do |_state|
         "expected BG at [#{@row},#{@col}] to be #{expected.inspect}, but was #{@actual.inspect}"
       end
     end
 
     RSpec::Matchers.define :have_style do
-      chain(:at) { |row, col| @row, @col = row, col }
+      chain(:at) do |row, col|
+        @row = row
+        @col = col
+      end
       chain(:with) { |expected| @expected = expected }
 
       match do |state|
@@ -75,7 +84,7 @@ module TUITD
       description do
         "have style #{@expected.inspect} at [#{@row},#{@col}]"
       end
-      failure_message do |state|
+      failure_message do |_state|
         "expected style at [#{@row},#{@col}] to be #{@expected.inspect}, but was #{@actual.inspect}"
       end
     end
@@ -88,10 +97,10 @@ module TUITD
       end
 
       description { "have exit status #{expected}" }
-      failure_message do |driver|
+      failure_message do |_driver|
         "expected exit status #{expected}, but was #{@actual}"
       end
-      failure_message_when_negated do |driver|
+      failure_message_when_negated do |_driver|
         "expected exit status not to be #{expected}"
       end
     end