tty-table 0.11.0 → 0.12.0

data/lib/tty-table.rb

@@ -1 +1 @@
-require_relative 'tty/table'
+require_relative "tty/table"

data/lib/tty/table.rb

@@ -1,24 +1,22 @@
 # frozen_string_literal: true
 
-require 'equatable'
-require 'forwardable'
-require 'necromancer'
-
-require_relative 'table/columns'
-require_relative 'table/header'
-require_relative 'table/orientation'
-require_relative 'table/row'
-require_relative 'table/renderer'
-require_relative 'table/transformation'
-require_relative 'table/validatable'
-require_relative 'table/version'
+require "forwardable"
+
+require_relative "table/columns"
+require_relative "table/header"
+require_relative "table/orientation"
+require_relative "table/row"
+require_relative "table/renderer"
+require_relative "table/transformation"
+require_relative "table/validatable"
+require_relative "table/version"
 
 module TTY
   # A core class intended for storing data in a structured, tabular form.
   # Once the data is stored in a TTY::Table various operations can be performed
   # before the information is dumped into a stdout.
   class Table
-    include Comparable, Enumerable, Validatable, Equatable
+    include Comparable, Enumerable, Validatable
     extend Forwardable
 
     # The table header
@@ -64,7 +62,7 @@ module TTY
     # Create a new Table where each argument is a row
     #
     # @example
-    #   table = TTY::Table[['a1', 'a2'], ['b1', 'b2']]
+    #   table = TTY::Table[["a1", "a2"], ["b1", "b2"]]
     #
     # @api public
     def self.[](*rows)
@@ -74,18 +72,18 @@ module TTY
     # Instantiate a new Table
     #
     # @example of no header
-    #   table = Table.new [['a1', 'a2'], ['b1', 'b2']]
+    #   table = Table.new [["a1", "a2"], ["b1", "b2"]]
     #
     # @example of direct parameters
-    #   rows  = [['a1', 'a2'], ['b1', 'b2']]
-    #   table = Table.new ['Header 1', 'Header 2'], rows
+    #   rows  = [["a1", "a2"], ["b1", "b2"]]
+    #   table = Table.new ["Header 1", "Header 2"], rows
     #
     # @example of parameters passed as options
-    #   rows  = [['a1', 'a2'], ['b1', 'b2']]
-    #   table = Table.new header: ['Header 1', 'Header 2'], rows: rows
+    #   rows  = [["a1", "a2"], ["b1", "b2"]]
+    #   table = Table.new header: ["Header 1", "Header 2"], rows: rows
     #
     # @example of parameters passed as hash
-    #   Table.new [{'Header1' => ['a1','a2'], 'Header2' => ['b1', 'b2'] }]}
+    #   Table.new [{"Header1" => ["a1","a2"], "Header2" => ["b1", "b2"] }]}
     #
     # @param [Array[Symbol], Hash] args
     #
@@ -115,7 +113,6 @@ module TTY
     # @api private
     def initialize(options = {}, &block)
       validate_options! options
-      @converter     = Necromancer.new
       @header        = (value = options[:header]) ? Header.new(value) : nil
       @rows          = coerce(options.fetch(:rows) { Row.new([]) })
       @rotated       = false
@@ -204,10 +201,10 @@ module TTY
     # @param [Integer] column_index
     #
     # @example
-    #   table = TTY::Table.new [['a1','a2'], ['b1','b2']]
-    #   table[0]    # => ['a1','a2']
-    #   table[0,0]  # => 'a1'
-    #   table[-1]   # => ['b1','b2']
+    #   table = TTY::Table.new [["a1","a2"], ["b1","b2"]]
+    #   table[0]    # => ["a1","a2"]
+    #   table[0,0]  # => "a1"
+    #   table[-1]   # => ["b1","b2"]
     #
     # @api public
     def [](row_index, column_index = false)
@@ -215,12 +212,12 @@ module TTY
       if row_index >= 0 && column_index >= 0
         rows.fetch(row_index) { return nil }[column_index]
       else
-        fail TTY::Table::TupleMissing.new(row_index, column_index)
+        raise TTY::Table::TupleMissing.new(row_index, column_index)
       end
     end
-    alias_method :at, :[]
-    alias_method :element, :[]
-    alias_method :component, :[]
+    alias at []
+    alias element []
+    alias component []
 
     # Set table value at row(i) and column(j)
     #
@@ -234,7 +231,7 @@ module TTY
     # When a block is given, the elements of that Array are iterated over.
     #
     # @example
-    #   rows  = [['a1', 'a2'], ['b1', 'b2']]
+    #   rows  = [["a1", "a2"], ["b1", "b2"]]
     #   table = TTY::Table.new rows: rows
     #   table.row(1) { |row| ... }
     #
@@ -261,7 +258,7 @@ module TTY
     #
     # @example
     #   header = [:h1, :h2]
-    #   rows  = [ ['a1', 'a2'], ['b1', 'b2'] ]
+    #   rows  = [ ["a1", "a2"], ["b1", "b2"] ]
     #   table = TTY::Table.new :rows => rows, :header => header
     #   table.column(1)
     #   table.column(1)   { |element| ... }
@@ -298,8 +295,7 @@ module TTY
       if row == Border::SEPARATOR
         separators << columns_size - (header ? 0 : 2)
       else
-        rows_copy = rows.dup
-        assert_row_sizes rows_copy << row
+        assert_row_size(row, rows)
         rows << to_row(row)
       end
       self
@@ -480,7 +476,7 @@ module TTY
     # @api public
     def coerce(rows)
       coerced_rows = []
-      @converter.convert(rows).to(:array).each do |row|
+      Array(rows).each do |row|
         if row == Border::SEPARATOR
           separators << coerced_rows.length - (header ? 0 : 1)
         else
@@ -490,6 +486,46 @@ module TTY
       coerced_rows
     end
 
+    # Compare table for equality of header and rows attributes
+    #
+    # @return [Boolean]
+    #
+    # @api public
+    def eql?(other)
+      instance_of?(other.class) &&
+        header.eql?(other.header) && rows.eql?(other.rows)
+    end
+
+    # Compare table for equivalence of header and rows attributes
+    #
+    # @return [Boolean]
+    #
+    # @api public
+    def ==(other)
+      other.is_a?(self.class) &&
+        header == other.header && rows == other.rows
+    end
+
+    # Inspect this instance attributes
+    #
+    # @return [String]
+    #
+    # @api public
+    def inspect
+      "#<#{self.class.name} header=#{header.inspect} rows=#{rows.inspect} " \
+        "original_rows=#{original_rows.inspect} " \
+        "original_columns=#{original_columns.inspect}>"
+    end
+
+    # Hash for this instance and its attributes
+    #
+    # @return [Numeric]
+    #
+    # @api public
+    def hash
+      [self.class, header, rows].hash
+    end
+
     private
 
     # Evaluate block

data/lib/tty/table/alignment_set.rb

@@ -1,7 +1,5 @@
 # frozen_string_literal: true
 
-require 'necromancer'
-
 module TTY
   class Table
     # A class responsible for column alignments
@@ -19,7 +17,7 @@ module TTY
       #
       # @api private
       def initialize(alignments)
-        @alignments = Necromancer.convert(alignments).to(:array).map(&:to_sym)
+        @alignments = Array(alignments).map(&:to_sym)
       end
 
       # Iterate over each element in the alignment set

data/lib/tty/table/border.rb

@@ -1,23 +1,19 @@
 # frozen_string_literal: true
 
-require 'equatable'
-require 'pastel'
-require 'strings'
+require "pastel"
+require "strings"
 
-require_relative 'border_options'
-require_relative 'border_dsl'
-require_relative 'border/row_line'
-require_relative 'error'
+require_relative "border_dsl"
+require_relative "border/row_line"
+require_relative "error"
 
 module TTY
   class Table
     # Abstract base class that is responsible for building the table border.
     class Border
-      include Equatable
+      EMPTY_CHAR = ""
 
-      EMPTY_CHAR = ''.freeze
-
-      SPACE_CHAR = ' '.freeze
+      SPACE_CHAR = " "
 
       # Represent a separtor on each row
       EACH_ROW = :each_row
@@ -32,39 +28,40 @@ module TTY
         attr_accessor :characters
       end
 
+      # Define border characters
+      #
+      # @param [Hash] characters
+      #   the border characters
+      #
+      # @return [Hash]
+      #
+      # @api public
+      def self.def_border(characters = (not_set = true), &block)
+        return self.characters = characters unless not_set
+
+        dsl = BorderDSL.new(&block)
+        self.characters = dsl.characters
+      end
+
       # Instantiate a new object
       #
       # @param [Array] column_widths
       #   the table column widths
       #
-      # @param [BorderOptions] options
+      # @param [BorderOptions] border_opts
       #
       # @return [Object]
       #
       # @api private
-      def initialize(column_widths, options = nil)
+      def initialize(column_widths, border_opts = nil)
         if self.class == Border
-          fail NotImplementedError, "#{self} is an abstract class"
-        else
-          @widths = column_widths
-          @border_options = TTY::Table::BorderOptions.from options
-          @color  = Pastel.new
+          raise NotImplementedError, "#{self} is an abstract class"
         end
-      end
-
-      # Define border characters
-      #
-      # @param [Hash] characters
-      #   the border characters
-      #
-      # @return [Hash]
-      #
-      # @api public
-      def self.def_border(characters=(not_set=true), &block)
-        return self.characters = characters unless not_set
 
-        dsl = TTY::Table::BorderDSL.new(&block)
-        self.characters = dsl.characters
+        @widths = column_widths
+        @dsl = BorderDSL.new(border_opts)
+        @characters = self.class.characters.merge(@dsl.characters)
+        @color = Pastel.new
       end
 
       # Retrive individual character by type
@@ -76,13 +73,7 @@ module TTY
       #
       # @api private
       def [](type)
-        characters = self.class.characters
-        chars = if border_options.nil?
-                  characters
-                else
-                  characters.merge(border_options.characters)
-                end
-        chars[type] || EMPTY_CHAR
+        @characters[type] || EMPTY_CHAR
       end
 
       # Check if border color is set
@@ -91,7 +82,7 @@ module TTY
       #
       # @api public
       def color?
-        border_options && border_options.style
+        !!@dsl.style
       end
 
       # A line spanning all columns marking top of a table.
@@ -117,7 +108,7 @@ module TTY
       # @return [String]
       #
       # @api private
-      def separator
+      def middle_line
         (result = render(:mid)).empty? ? nil : result
       end
 
@@ -130,30 +121,27 @@ module TTY
       #
       # @api public
       def row_line(row)
-        line = RowLine.new(self['left'], self['center'], self['right'])
-        line.colorize(self, border_options.style) if color?
+        line = RowLine.new(self["left"], self["center"], self["right"])
+        line.colorize(self, @dsl.style) if color?
 
         result = row_heights(row, line)
         result.empty? ? EMPTY_CHAR : result
       end
 
-      # Set color on characters
+      # Set color for a string
       #
       # @param [Symbol] color
       #
-      # @param [Array[String]] strings array of strings
+      # @param [String] string
+      #   the string to color
       #
-      # @return [Array[String]]
+      # @return [String]
       #
       # @api public
-      def set_color(color, *strings)
-        strings.map do |string|
-          if string.gsub(/\s+/, '').empty?
-            string
-          else
-            @color.decorate(string, color)
-          end
-        end
+      def set_color(color, string)
+        return string if string.gsub(/\s+/, EMPTY_CHAR).empty?
+
+        @color.decorate(string, color)
       end
 
       protected
@@ -166,7 +154,9 @@ module TTY
       # The table custom border options including styling
       #
       # @api private
-      attr_reader :border_options
+      def border_options
+        @dsl.options
+      end
 
       # Separate multiline string into individual rows with border.
       #
@@ -210,7 +200,9 @@ module TTY
       # Generate particular border type
       #
       # @param [String] type
-      #  border type one of [:top, :bottom, :mid]
+      #  border type one of :top, :bottom and :mid
+      #
+      # @return [String]
       #
       # @api private
       def render(type)
@@ -222,7 +214,8 @@ module TTY
                            self["#{type}_mid"])
 
         return line unless color?
-        set_color(border_options.style, line).join
+
+        set_color(@dsl.style, line)
       end
 
       # Generate a border string

data/lib/tty/table/border/ascii.rb

@@ -1,6 +1,6 @@
 # frozen_string_literal: true
 
-require_relative '../border'
+require_relative "../border"
 
 module TTY
   class Table
@@ -11,21 +11,21 @@ module TTY
       class ASCII < Border
 
         def_border do
-          top           '-'
-          top_mid       '+'
-          top_left      '+'
-          top_right     '+'
-          bottom        '-'
-          bottom_mid    '+'
-          bottom_left   '+'
-          bottom_right  '+'
-          mid           '-'
-          mid_mid       '+'
-          mid_left      '+'
-          mid_right     '+'
-          left          '|'
-          center        '|'
-          right         '|'
+          top           "-"
+          top_mid       "+"
+          top_left      "+"
+          top_right     "+"
+          bottom        "-"
+          bottom_mid    "+"
+          bottom_left   "+"
+          bottom_right  "+"
+          mid           "-"
+          mid_mid       "+"
+          mid_left      "+"
+          mid_right     "+"
+          left          "|"
+          center        "|"
+          right         "|"
         end
 
       end # ASCII

data/lib/tty/table/border/null.rb

@@ -1,38 +1,35 @@
 # frozen_string_literal: true
 
-require_relative '../border'
+require_relative "../border"
 
 module TTY
   class Table
     class Border
       # A class that represents no border.
       class Null < Border
-
         def_border do
-          center SPACE_CHAR
-        end
-
-        # A stub top line
-        #
-        # @api private
-        def top_line
-          border_options ? super : nil
-        end
-
-        # A stub separator line
-        #
-        # @api private
-        def separator
-          return [] if border_options.separator # == EACH_ROW #TODO ask about this looks broken.
-          # how could border_options ever be nil, if we just did border_options.separator
-          border_options ? super : nil
+          top           EMPTY_CHAR
+          top_mid       EMPTY_CHAR
+          top_left      EMPTY_CHAR
+          top_right     EMPTY_CHAR
+          bottom        EMPTY_CHAR
+          bottom_mid    EMPTY_CHAR
+          bottom_left   EMPTY_CHAR
+          bottom_right  EMPTY_CHAR
+          mid           EMPTY_CHAR
+          mid_mid       EMPTY_CHAR
+          mid_left      EMPTY_CHAR
+          mid_right     EMPTY_CHAR
+          left          EMPTY_CHAR
+          center        SPACE_CHAR
+          right         EMPTY_CHAR
         end
 
-        # A stub bottom line
+        # A stub middle line
         #
         # @api private
-        def bottom_line
-          border_options ? super : nil
+        def middle_line
+          border_options.separator ? "" : super
         end
       end # Null
     end # Border