trusty-layouts-extension 1.0.0

data/vendor/plugins/rails_upgrade/lib/tasks/rails_upgrade_tasks.rake

@@ -0,0 +1,79 @@
+$:.unshift(File.dirname(__FILE__) + "/../../lib")
+require 'routes_upgrader'
+require 'gemfile_generator'
+require 'application_checker'
+require 'new_configuration_generator'
+require "active_support"
+
+require 'fileutils'
+
+namespace :rails do
+  namespace :upgrade do
+    desc "Runs a battery of checks on your Rails 2.x app and generates a report on required upgrades for Rails 3"
+    task :check do
+      checker = Rails::Upgrading::ApplicationChecker.new
+      checker.run
+    end
+
+    desc "Generates a Gemfile for your Rails 3 app out of your config.gem directives"
+    task :gems do
+      generator = Rails::Upgrading::GemfileGenerator.new
+      new_gemfile = generator.generate_new_gemfile
+
+      puts new_gemfile
+    end
+
+    desc "Create a new, upgraded route file from your current routes.rb"
+    task :routes do
+      upgrader = Rails::Upgrading::RoutesUpgrader.new
+      new_routes = upgrader.generate_new_routes
+
+      puts new_routes
+    end
+
+    desc "Extracts your configuration code so you can create a new config/application.rb"
+    task :configuration do
+      upgrader = Rails::Upgrading::NewConfigurationGenerator.new
+      new_config = upgrader.generate_new_application_rb
+
+      puts new_config
+    end
+
+    CLEAR      = "\e[0m"  unless defined? CLEAR
+    CYAN       = "\e[36m" unless defined? CYAN
+    WHITE      = "\e[37m" unless defined? WHITE
+
+    desc "Backs up your likely modified files so you can run the Rails 3 generator on your app with little risk"
+    task :backup do
+      files = [".gitignore",
+      "app/controllers/application_controller.rb",
+      "app/helpers/application_helper.rb",
+      "config/routes.rb",
+      "config/environment.rb",
+      "config/environments/development.rb",
+      "config/environments/production.rb",
+      "config/environments/staging.rb",
+      "config/database.yml",
+      "config.ru",
+      "doc/README_FOR_APP",
+      "test/test_helper.rb"]
+
+      puts
+      files.each do |f|
+        if File.exist?(f)
+          puts "#{CYAN}* #{CLEAR}backing up #{WHITE}#{f}#{CLEAR} to #{WHITE}#{f}.rails2#{CLEAR}"
+          FileUtils.cp(f, "#{f}.rails2")
+        end
+      end
+
+      puts
+      puts "This is a list of the files analyzed and backed up (if they existed);\nyou will probably not want the generator to replace them since\nyou probably modified them (but now they're safe if you accidentally do!)."
+      puts
+
+      files.each do |f|
+        puts "#{CYAN}- #{CLEAR}#{f}"
+      end
+      puts
+    end
+  end
+end

data/vendor/plugins/rails_upgrade/test/application_checker_test.rb

@@ -0,0 +1,344 @@
+require 'test_helper'
+require 'application_checker'
+require 'fileutils'
+
+tmp_dir = File.expand_path("#{File.dirname(__FILE__)}/fixtures/tmp")
+
+if defined? BASE_ROOT
+  BASE_ROOT.replace tmp_dir
+else
+  BASE_ROOT = tmp_dir
+end
+FileUtils.mkdir_p BASE_ROOT
+
+# Stub out methods on upgrader class
+module Rails
+  module Upgrading
+    class ApplicationChecker
+      attr_reader :alerts, :culprits
+
+      def base_path
+        BASE_ROOT + "/"
+      end
+
+      def in_rails_app?
+        true
+      end
+
+      def initialize
+        @alerts = {}
+        @culprits = {}
+      end
+
+      def alert(title, text, more_info_url, culprits)
+        @alerts[title] = [text, more_info_url]
+        @culprits[title] = culprits
+      end
+    end
+  end
+end
+
+class ApplicationCheckerTest < ActiveSupport::TestCase
+  def setup
+    @checker = Rails::Upgrading::ApplicationChecker.new
+    @old_dir = Dir.pwd
+
+    Dir.chdir(BASE_ROOT)
+  end
+
+  def test_check_ar_methods_in_controller
+    make_file("app/controllers", "post_controller.rb", "Post.find(:all)")
+    @checker.check_ar_methods
+
+    assert @checker.alerts.has_key?("Soon-to-be-deprecated ActiveRecord calls")
+  end
+
+  def test_check_ar_methods_in_models
+    make_file("app/models", "post.rb", "Post.find(:all)")
+    @checker.check_ar_methods
+
+    key = "Soon-to-be-deprecated ActiveRecord calls"
+    assert @checker.alerts.has_key?(key)
+    assert_equal "app/models/post.rb", @checker.culprits[key].first
+  end
+  
+  def test_check_svn_subdirs_are_not_included
+    make_file("app/models/.svn/text-base", "foo.rb.tmp", "Post.find(:all)")
+    @checker.check_ar_methods
+    assert @checker.alerts.empty?
+  end
+  
+  def test_check_validation_on_methods
+    make_file("app/models", "post.rb", "validate_on_create :comments_valid?")
+    @checker.check_validation_on_methods
+    
+    assert @checker.alerts.has_key?("Updated syntax for validate_on_* methods")
+  end
+  
+  def test_check_before_validation_on_methods
+    make_file("app/models", "post.rb", "before_validation_on_create :comments_valid?")
+    @checker.check_before_validation_on_methods
+    
+    assert @checker.alerts.has_key?("Updated syntax for before_validation_on_* methods")
+  end
+
+  def test_named_scope_left_over
+    make_file("app/models", "post.rb", "named_scope :failure")
+    @checker.check_ar_methods
+
+    assert @checker.alerts.has_key?("named_scope is now just scope")
+  end
+
+  def test_check_routes
+    make_file("config/", "routes.rb", "  map.connect 'fail'")
+    @checker.check_routes
+
+    assert @checker.alerts.has_key?("Old router API")
+  end
+
+  def test_check_for_old_test_help
+    make_file("test/", "test_helper.rb", "  require 'test_help'")
+    @checker.check_test_help
+
+    assert @checker.alerts.has_key?("Deprecated test_help path")
+  end
+
+  def test_check_for_old_test_help_with_double_quotes
+    make_file("test/", "test_helper.rb", "  require \"test_help\"")
+    @checker.check_test_help
+
+    assert @checker.alerts.has_key?("Deprecated test_help path")
+  end
+
+  def test_check_for_old_test_help_doesnt_see_test_helper
+    make_file("test/", "test_helper.rb", "  require 'test_helper'")
+    @checker.check_test_help
+
+    assert !@checker.alerts.has_key?("Deprecated test_help path")
+  end
+
+  def test_check_lack_of_app_dot_rb
+    @checker.check_environment
+
+    assert @checker.alerts.has_key?("New file needed: config/application.rb")
+  end
+
+  def test_check_environment_syntax
+    make_file("config/", "environment.rb", "config.frameworks = []")
+    @checker.check_environment
+
+    assert @checker.alerts.has_key?("Old environment.rb")
+  end
+
+  def test_check_gems
+    make_file("config/", "environment.rb", "config.gem 'rails'")
+    @checker.check_gems
+
+    assert @checker.alerts.has_key?("Old gem bundling (config.gems)")
+  end
+  
+  def test_check_gems_finds_nothing
+    @checker.check_gems
+
+    assert_equal false, @checker.alerts.has_key?("Old gem bundling (config.gems)")
+  end
+  
+  def test_check_mailer_finds_nothing
+    @checker.check_mailers
+
+    assert_equal false, @checker.alerts.has_key?("Old ActionMailer class API")
+  end
+
+  def test_check_mailer_syntax
+    make_file("app/models/", "notifications.rb", "def signup\nrecipients @users\n end")
+    @checker.check_mailers
+
+    assert @checker.alerts.has_key?("Old ActionMailer class API")
+  end
+
+  def test_check_mailer_syntax_from
+    make_file("app/models/", "notifications.rb", "def signup\nfrom @user\n end")
+    @checker.check_mailers
+
+    assert @checker.alerts.has_key?("Old ActionMailer class API")
+  end
+
+  def test_check_mailer_syntax_subject
+    make_file("app/models/", "notifications.rb", "def signup\nsubject @subject\n end")
+    @checker.check_mailers
+
+    assert @checker.alerts.has_key?("Old ActionMailer class API")
+  end
+
+  def test_check_mailer_syntax_attachment
+    make_file("app/models/", "notifications.rb", "def signup\nattachment 'application/pdf' do |a|\n end")
+    @checker.check_mailers
+
+    assert @checker.alerts.has_key?("Old ActionMailer class API")
+  end
+
+  def test_new_check_mailer_syntax_from
+    make_file("app/models/", "notifications.rb", "def signup\n:from => @users\n end")
+    @checker.check_mailers
+
+    assert ! @checker.alerts.has_key?("Old ActionMailer class API")
+  end
+
+  def test_new_check_mailer_syntax_subject
+    make_file("app/models/", "notifications.rb", "def signup\n:subject => @users\n end")
+    @checker.check_mailers
+
+    assert ! @checker.alerts.has_key?("Old ActionMailer class API")
+  end
+
+  def test_new_check_mailer_syntax_attachments
+    make_file("app/models/", "notifications.rb", "def signup\nattachments['an-image.jp'] = File.read('an-image.jpg')\n end")
+    @checker.check_mailers
+
+    assert ! @checker.alerts.has_key?("Old ActionMailer class API")
+  end
+
+  def test_check_mailer_api
+    make_file("app/controllers/", "thing_controller.rb", "def signup\n Notifications.deliver_signup\n end")
+    @checker.check_mailers
+
+    assert @checker.alerts.has_key?("Deprecated ActionMailer API")
+  end
+
+  def test_check_generators
+    make_file("vendor/plugins/thing/generators/thing/", "thing_generator.rb", "def manifest\n m.whatever\n end")
+    @checker.check_generators
+
+    assert @checker.alerts.has_key?("Old Rails generator API")
+  end
+
+  def test_check_plugins
+    make_file("vendor/plugins/rspec-rails/", "whatever.rb", "def rspec; end")
+    @checker.check_plugins
+
+    assert @checker.alerts.has_key?("Known broken plugins")
+  end
+
+  def test_ignoring_comments
+    make_file("config/", "routes.rb", "#  map.connect 'fail'")
+    @checker.check_routes
+
+    assert !@checker.alerts.has_key?("Old router API")
+  end
+
+  def test_check_deprecated_constants_in_app_code
+    make_file("app/controllers/", "thing_controller.rb", "class ThingController; THING = Rails.env; end;")
+    @checker.check_deprecated_constants
+
+    assert @checker.alerts.has_key?("Deprecated constant(s)")
+  end
+
+  def test_check_deprecated_constants_in_lib
+    make_file("lib/", "extra_thing.rb", "class ExtraThing; THING = Rails.env; end;")
+    @checker.check_deprecated_constants
+
+    assert @checker.alerts.has_key?("Deprecated constant(s)")
+  end
+  
+  def test_check_deprecated_cookie_finds_nothing
+    @checker.check_old_cookie_secret
+    assert_equal false, @checker.alerts.has_key?("Deprecated cookie secret setting")
+  end
+
+  def test_check_deprecated_cookie_settings
+    make_file("config/initializers/", "more_settings.rb", "ActionController::Base.cookie_verifier_secret = 'OMG'")
+    @checker.check_old_cookie_secret
+
+    assert @checker.alerts.has_key?("Deprecated cookie secret setting")
+  end
+
+  def test_check_deprecated_session_finds_nothing
+    @checker.check_old_session_secret
+    assert_equal false, @checker.alerts.has_key?("Deprecated session secret setting")
+  end
+
+  def test_check_deprecated_session_secret
+    make_file("config/initializers/", "more_settings.rb", "ActionController::Base.session = {\n:whatever => 'woot'\n}")
+    @checker.check_old_session_secret
+
+    assert @checker.alerts.has_key?("Deprecated session secret setting")
+  end
+  
+  def test_check_old_session_setting_finds_nothing
+    @checker.check_old_session_setting
+    assert_equal false, @checker.alerts.has_key?("Old session store setting")
+  end
+
+  def test_check_deprecated_session_settings
+    make_file("config/initializers/", "more_settings.rb", "ActionController::Base.session_store = :cookie\nthings.awesome(:whatever)")
+    @checker.check_old_session_setting
+
+    assert @checker.alerts.has_key?("Old session store setting")
+  end
+
+  def test_check_helpers
+    make_file("app/views/users/", "test.html.erb", "<b>blah blah blah</b><% form_for(:thing) do |f| %> <label>doo dah</label> <%= f.whatever %> <% end %>")
+    @checker.check_old_helpers
+
+    assert @checker.alerts.has_key?("Deprecated ERb helper calls")
+    
+  end
+  
+  def test_check_old_helpers_lets_regular_blocks_pass
+    make_file("app/views/users/", "another_test.html.erb", "<b>blah blah blah</b><% @some_items.each do |item| %> <label>doo dah</label> <%= item %> <% end %>")
+    @checker.check_old_helpers
+
+    assert_equal @checker.alerts.has_key?("Deprecated ERb helper calls"), false
+  end
+  
+  def test_check_old_helpers_lets_regular_blocks_pass
+    make_file("app/views/users/", "another_test.html.erb", "<b>blah blah blah</b><% @some_items.each do |item| %> <label>doo dah</label> <%= item %> <% end %>")
+    @checker.check_old_helpers
+
+    assert_equal false, @checker.alerts.has_key?("Deprecated ERb helper calls")
+  end
+
+  def test_check_old_ajax_helpers
+    make_file("app/views/sections", "section.js", "<%= link_to_remote 'section-', :update => 'sections', :url => {:action => :destroy, :controller => 'sections', :id => @section.id } %>")
+    @checker.check_old_ajax_helpers
+
+    assert @checker.alerts.has_key?("Deprecated AJAX helper calls")
+  end
+  
+  def test_check_old_ajax_helpers
+    make_file("app/controllers", "application_controller.rb", "filter_parameter_logging :password")
+    @checker.check_old_filter_parameter
+
+    assert @checker.alerts.has_key?("Deprecated filter_parameter_logging calls")
+  end
+
+  def test_check_old_ajax_helpers_empty
+    @checker.check_old_ajax_helpers
+
+    assert ! @checker.alerts.has_key?("Deprecated AJAX helper calls")
+  end
+
+  def test_check_old_action_mailer_sent_on_setting
+    make_file("app/models", "mailer.rb", "sent_on Time.now")
+    @checker.check_old_action_mailer_sent_on_setting
+
+    assert @checker.alerts.has_key?("Deprecated ActionMailer attribute :sent_on")
+  end
+
+  def teardown
+    clear_files
+
+    Dir.chdir(@old_dir)
+  end
+
+  def make_file(where, name=nil, contents=nil)
+    FileUtils.mkdir_p "#{BASE_ROOT}/#{where}"
+    File.open("#{BASE_ROOT}/#{where}/#{name}", "w+") do |f|
+      f.write(contents)
+    end if name
+  end
+
+  def clear_files
+    FileUtils.rm_rf(Dir.glob("#{BASE_ROOT}/*"))
+  end
+end

data/vendor/plugins/rails_upgrade/test/gemfile_generator_test.rb

@@ -0,0 +1,72 @@
+require 'test_helper'
+require 'gemfile_generator'
+
+# Stub out methods on upgrader class
+module Rails
+  module Upgrading
+    class GemfileGenerator
+      attr_writer :environment_code
+      
+      def has_environment?
+        true
+      end
+      
+      def environment_code
+        @environment_code
+      end
+    end
+  end
+end
+
+class GemfileGeneratorTest < ActiveSupport::TestCase
+  PREAMBLE = <<STR
+# Edit this Gemfile to bundle your application's dependencies.
+# This preamble is the current preamble for Rails 3 apps; edit as needed.
+source 'http://rubygems.org'
+
+gem 'rails', '3.0.6'
+
+STR
+
+  def test_generates_with_no_gems
+    generator = Rails::Upgrading::GemfileGenerator.new
+    generator.environment_code = ""
+    
+    assert_equal PREAMBLE, generator.generate_gemfile
+  end
+  
+  def test_generates_with_gem
+    generator = Rails::Upgrading::GemfileGenerator.new
+    generator.environment_code = "config.gem 'camping'"
+    
+    assert_equal PREAMBLE + "gem 'camping'", generator.generate_gemfile
+  end
+  
+  def test_generates_with_version
+    generator = Rails::Upgrading::GemfileGenerator.new
+    generator.environment_code = "config.gem 'camping', :version => '2.1.1'"
+    
+    assert_equal PREAMBLE + "gem 'camping', '2.1.1'", generator.generate_gemfile
+  end
+  
+  def test_can_add_sources
+    generator = Rails::Upgrading::GemfileGenerator.new
+    generator.environment_code = "config.gem 'camping', :source => 'http://code.whytheluckystiff.net'"
+    
+    assert_equal PREAMBLE + "source 'http://code.whytheluckystiff.net'\ngem 'camping'", generator.generate_gemfile
+  end
+  
+  def test_changes_lib_to_new_key
+    generator = Rails::Upgrading::GemfileGenerator.new
+    generator.environment_code = "config.gem 'camping', :lib => 'kamping'"
+    
+    assert_equal PREAMBLE + "gem 'camping', :require => 'kamping'", generator.generate_gemfile    
+  end
+  
+  def test_generates_with_all_options
+    generator = Rails::Upgrading::GemfileGenerator.new
+    generator.environment_code = "config.gem 'camping', :lib => 'kamping', :source => 'http://code.whytheluckystiff.net', :version => '2.1.1'"
+    
+    assert_equal PREAMBLE + "source 'http://code.whytheluckystiff.net'\ngem 'camping', '2.1.1', :require => 'kamping'", generator.generate_gemfile     
+  end
+end