trusty-cms 4.1.2 → 4.1.3

data/app/models/status.rb

@@ -3,7 +3,8 @@ class Status
 
   def initialize(options = {})
     options = options.symbolize_keys
-    @id, @name = options[:id], options[:name]
+    @id = options[:id]
+    @name = options[:name]
   end
 
   def symbol
@@ -27,15 +28,14 @@ class Status
   end
 
   def self.selectable_values
-    self.selectable.map(&:name)
+    selectable.map(&:name)
   end
 
   @@statuses = [
-    Status.new(:id => 1,   :name => 'Draft'    ),
-    Status.new(:id => 50,  :name => 'Reviewed' ),
-    Status.new(:id => 90,  :name => 'Scheduled'),
-    Status.new(:id => 100, :name => 'Published'),
-    Status.new(:id => 101, :name => 'Hidden'   )
+    Status.new(id: 1,   name: 'Draft'),
+    Status.new(id: 50,  name: 'Reviewed'),
+    Status.new(id: 90,  name: 'Scheduled'),
+    Status.new(id: 100, name: 'Published'),
+    Status.new(id: 101, name: 'Hidden'),
   ]
-
 end

data/app/models/trusty_cms/config.rb

@@ -1,5 +1,4 @@
 module TrustyCms
-
   class << self
     def config_definitions
       @config_definitions ||= {}
@@ -67,7 +66,7 @@ module TrustyCms
     #   edit_setting('admin.name)
     #
 
-    self.table_name = "config"
+    self.table_name = 'config'
     after_save :update_cache
     attr_reader :definition
 
@@ -105,12 +104,12 @@ module TrustyCms
       end
 
       def to_hash
-        Hash[ *all.map { |pair| [pair.key, pair.value] }.flatten ]
+        Hash[*all.map { |pair| [pair.key, pair.value] }.flatten]
       end
 
       def initialize_cache
         TrustyCms::Config.ensure_cache_file
-        Rails.cache.write('TrustyCms::Config',TrustyCms::Config.to_hash)
+        Rails.cache.write('TrustyCms::Config', TrustyCms::Config.to_hash)
         Rails.cache.write('TrustyCms.cache_mtime', File.mtime(cache_file))
         Rails.cache.silence!
       end
@@ -121,6 +120,7 @@ module TrustyCms
 
       def stale_cache?
         return true unless TrustyCms::Config.cache_file_exists?
+
         Rails.cache.read('TrustyCms.cache_mtime') != File.mtime(cache_file)
       end
 
@@ -134,15 +134,15 @@ module TrustyCms
       end
 
       def cache_file
-        File.join(cache_path,'trusty_config_cache.txt')
+        File.join(cache_path, 'trusty_config_cache.txt')
       end
 
       def site_settings
-        @site_settings ||= %w{ site.title site.host dev.host local.timezone }
+        @site_settings ||= %w{site.title site.host dev.host local.timezone}
       end
 
       def default_settings
-        @default_settings ||= %w{ defaults.locale defaults.page.filter defaults.page.parts defaults.page.fields defaults.page.status }
+        @default_settings ||= %w{defaults.locale defaults.page.filter defaults.page.parts defaults.page.fields defaults.page.status}
       end
 
       def user_settings
@@ -161,7 +161,7 @@ module TrustyCms
       #
       def namespace(prefix, options = {}, &block)
         prefix = [options[:prefix], prefix].join('.') if options[:prefix]
-        with_options(options.merge(:prefix => prefix), &block)
+        with_options(options.merge(prefix: prefix), &block)
       end
 
       # Declares a setting definition that will constrain and support the use of a particular config entry.
@@ -176,7 +176,7 @@ module TrustyCms
       # * :allow_blank should be false if the config item must not be blank or nil
       # * :allow_change should be false if the config item can only be set, not changed. Add a default to specify an unchanging config entry.
       # * :allow_display should be false if the config item should not be showable in radius tags
-      #    
+      #
       #   TrustyCms.config do |config|
       #     config.define 'defaults.locale', :select_from => lambda { TrustyCms::AvailableLocales.locales }, :allow_blank => true
       #     config.define 'defaults.page.parts', :default => "Body,Extended"
@@ -191,7 +191,7 @@ module TrustyCms
       #
       # but at the moment that's only done in testing.
       #
-      def define(key, options={})
+      def define(key, options = {})
         called_from = caller.grep(/\/initializers\//).first
         if options.is_a? TrustyCms::Config::Definition
           definition = options
@@ -199,7 +199,7 @@ module TrustyCms
           key = [options[:prefix], key].join('.') if options[:prefix]
         end
 
-        definition ||= TrustyCms::Config::Definition.new(options.merge(:definer => called_from))
+        definition ||= TrustyCms::Config::Definition.new(options.merge(definer: called_from))
         definitions[key] = definition
 
         if self[key].nil? && !definition.default.nil?
@@ -216,9 +216,8 @@ module TrustyCms
       end
 
       def definition_for(key)
-        definitions[key] ||= TrustyCms::Config::Definition.new(:empty => true)
+        definitions[key] ||= TrustyCms::Config::Definition.new(empty: true)
       end
-
     end
 
     # The usual way to use a config item:
@@ -236,13 +235,14 @@ module TrustyCms
     def value=(param)
       newvalue = param.to_s
       if newvalue != self[:value]
-        raise ConfigError, "#{self.key} cannot be changed" unless settable? || self[:value].blank?
-        if boolean?
-          self[:value] = (newvalue == "1" || newvalue == "true") ? "true" : "false"
-        else
-          self[:value] = newvalue
-        end
-        self.save!
+        raise ConfigError, "#{key} cannot be changed" unless settable? || self[:value].blank?
+
+        self[:value] = if boolean?
+                         newvalue == '1' || newvalue == 'true' ? 'true' : 'false'
+                       else
+                         newvalue
+                       end
+        save!
       end
       self[:value]
     end
@@ -270,20 +270,21 @@ module TrustyCms
     # that does not restrict use.
     #
     def definition
-      @definition ||= self.class.definition_for(self.key)
+      @definition ||= self.class.definition_for(key)
     end
 
     # Returns true if the item key ends with '?' or the definition specifies :type => :boolean.
     #
     def boolean?
-      definition.boolean? || self.key.ends_with?("?")
+      definition.boolean? || key.ends_with?('?')
     end
 
     # Returns true if the item is boolean and true.
     #
     def checked?
       return nil if self[:value].nil?
-      boolean? && self[:value] == "true"
+
+      boolean? && self[:value] == 'true'
     end
 
     # Returns true if the item defintion includes a :select_from parameter that limits the range of permissible options.
@@ -302,11 +303,10 @@ module TrustyCms
       TrustyCms::Config.initialize_cache
     end
 
-    delegate :default, :type, :allow_blank?, :hidden?, :visible?, :settable?, :selection, :notes, :units, :to => :definition
+    delegate :default, :type, :allow_blank?, :hidden?, :visible?, :settable?, :selection, :notes, :units, to: :definition
 
     def validate
       definition.validate(self)
     end
-
   end
 end

data/app/models/trusty_cms/page_response_cache_director.rb

@@ -22,7 +22,7 @@ module TrustyCms
     private
 
     def non_cacheable_response
-      @listener.set_expiry nil, :private => true, "no-cache" => true
+      @listener.set_expiry nil, :private => true, 'no-cache' => true
       @listener.set_etag('')
     end
 
@@ -32,12 +32,11 @@ module TrustyCms
         timeout = @page.cache_timeout
       end
 
-      @listener.set_expiry timeout, :public => true, :private => false
+      @listener.set_expiry timeout, public: true, private: false
     end
 
     def cacheable?
       @listener.cacheable_request? && @page.cache?
     end
-
   end
 end

data/app/models/user.rb

@@ -1,10 +1,10 @@
 class User < ActiveRecord::Base
-  has_many :pages, :foreign_key => :created_by_id
+  has_many :pages, foreign_key: :created_by_id
   self.table_name = 'admins'
 
   # :confirmable, :lockable, :timeoutable and :omniauthable
   devise :database_authenticatable, :registerable,
-    :recoverable, :rememberable, :trackable, :validatable
+         :recoverable, :rememberable, :trackable, :validatable
 
   alias_attribute :created_by_id, :id
 
@@ -13,53 +13,54 @@ class User < ActiveRecord::Base
   validate :password_complexity
 
   # Default Order
-  default_scope {order('last_name')}
+  default_scope { order('last_name') }
 
   # Associations
-  belongs_to :created_by, :class_name => 'User'
-  belongs_to :updated_by, :class_name => 'User'
+  belongs_to :created_by, class_name: 'User'
+  belongs_to :updated_by, class_name: 'User'
 
   def has_role?(role)
     case role
     when :admin
-      self.admin?
+      admin?
     when :designer
-      self.designer?
+      designer?
     when :content_editor
-      self.content_editor?  
+      content_editor?
     else
       false
     end
   end
 
   def admin?
-    self.admin
+    admin
   end
 
   def designer?
-    self.designer
+    designer
   end
 
   def content_editor?
-    self.content_editor
+    content_editor
   end
 
-  def locale 
+  def locale
     'en'
   end
 
   def name
-    "#{self.first_name} #{self.last_name}"
+    "#{first_name} #{last_name}"
   end
 
   def password_required?
     return false if skip_password_validation
+
     super
   end
 
   def password_complexity
     return false if password.blank? || password =~ /^(?=.*?[A-Z])(?=.*?[a-z])(?=.*?[0-9])(?=.*?[#?!@$%^&*-]).{8,70}$/
+
     errors.add :password, 'Complexity requirement not met. Length should be 12 characters and include: 1 uppercase, 1 lowercase, 1 digit and 1 special character.'
   end
-
 end

data/app/models/user_action_observer.rb

@@ -4,7 +4,7 @@ class UserActionObserver < ActiveRecord::Observer
   def current_user=(user)
     self.class.current_user = user
   end
-  
+
   def self.current_user=(user)
     Thread.current[:current_user] = user
   end
@@ -18,10 +18,10 @@ class UserActionObserver < ActiveRecord::Observer
   end
 
   def before_create(model)
-    #model.created_by = self.current_user
+    # model.created_by = self.current_user
   end
 
   def before_update(model)
-    #model.updated_by = self.current_user
+    # model.updated_by = self.current_user
   end
 end

data/bin/rails

@@ -2,12 +2,12 @@
 # This command will automatically be run when you run "rails" with Rails gems
 # installed from the root of your application.
 
-ENGINE_ROOT = File.expand_path('../..', __FILE__)
-ENGINE_PATH = File.expand_path('../../lib/trusty/cms/engine', __FILE__)
-APP_PATH = File.expand_path('../../test/dummy/config/application', __FILE__)
+ENGINE_ROOT = File.expand_path('..', __dir__)
+ENGINE_PATH = File.expand_path('../lib/trusty/cms/engine', __dir__)
+APP_PATH = File.expand_path('../test/dummy/config/application', __dir__)
 
 # Set up gems listed in the Gemfile.
-ENV['BUNDLE_GEMFILE'] ||= File.expand_path('../../Gemfile', __FILE__)
+ENV['BUNDLE_GEMFILE'] ||= File.expand_path('../Gemfile', __dir__)
 require 'bundler/setup' if File.exist?(ENV['BUNDLE_GEMFILE'])
 
 require 'rails/all'

data/bin/trusty_cms

@@ -1,11 +1,11 @@
 #!/usr/bin/env ruby
 
-ENV["RAILS_ENV"] ||= 'production'
+ENV['RAILS_ENV'] ||= 'production'
 
 $LOAD_PATH << File.join(File.dirname(__FILE__), '..')
 
 require 'ruby_version_check'
-Signal.trap("INT") { puts; exit }
+Signal.trap('INT') { puts; exit }
 
 require 'trusty_cms'
 if ARGV.any? { |arg| %w(--version -v).any? { |flag| arg == flag } }
@@ -19,7 +19,6 @@ require 'rails_generator'
 require 'rails_generator/scripts/generate'
 
 class Rails::Generator::Base
-
   def self.use_application_sources!
     reset_sources
     sources << Rails::Generator::PathSource.new(:builtin, "#{File.dirname(__FILE__)}/../lib/generators")
@@ -46,7 +45,6 @@ class Rails::Generator::Base
       end
     end
   end
-
 end
 
-Rails::Generators.invoke("trusty_cms", [ARGV])
+Rails::Generators.invoke('trusty_cms', [ARGV])

data/config.ru

@@ -1,4 +1,4 @@
 # This file is used by Rack-based servers to start the application.
 
-require ::File.expand_path('../config/environment',  __FILE__)
+require ::File.expand_path('../config/environment', __FILE__)
 run TrustyCms::Application

data/config/application.rb

@@ -1,4 +1,4 @@
-require File.expand_path('../boot', __FILE__)
+require File.expand_path('boot', __dir__)
 
 require 'rails/all'
 require 'acts_as_tree'
@@ -10,9 +10,8 @@ require 'rack/cache'
 require 'trustygems'
 require 'devise'
 
-
 if defined?(Bundler)
-  Bundler.require(*Rails.groups(:assets => %w(development test)))
+  Bundler.require(*Rails.groups(assets: %w(development test)))
 end
 
 module TrustyCms
@@ -30,12 +29,12 @@ module TrustyCms
 
     # Initialize extension paths
     config.initialize_extension_paths
-    extension_loader = ExtensionLoader.instance {|l| l.initializer = self }
+    extension_loader = ExtensionLoader.instance { |l| l.initializer = self }
     extension_loader.paths(:load).reverse_each do |path|
       config.autoload_paths.unshift path
       $LOAD_PATH.unshift path
     end
-    paths["app/helpers"] = []
+    paths['app/helpers'] = []
     # config.add_plugin_paths(extension_loader.paths(:plugin))
     trusty_locale_paths = Dir[File.join(TRUSTY_CMS_ROOT, 'config', 'locales', '*.{rb,yml}')]
     config.i18n.load_path = trusty_locale_paths + extension_loader.paths(:locale)
@@ -44,16 +43,16 @@ module TrustyCms
     config.encoding = 'utf-8'
 
     config.middleware.use Rack::Cache,
-                          :private_headers => ['Authorization'],
-                          :entitystore => "trusty:tmp/cache/entity",
-                          :metastore => "trusty:tmp/cache/meta",
-                          :verbose => false,
-                          :allow_reload => false,
-                          :allow_revalidate => false
+                          private_headers: ['Authorization'],
+                          entitystore: 'trusty:tmp/cache/entity',
+                          metastore: 'trusty:tmp/cache/meta',
+                          verbose: false,
+                          allow_reload: false,
+                          allow_revalidate: false
     config.middleware.insert_before(Rack::ConditionalGet, Rack::Cache)
     config.assets.enabled = true
 
-    config.filter_parameters += [:password, :password_confirmation]
+    config.filter_parameters += %i[password password_confirmation]
 
     # Use the database for sessions instead of the cookie-based default,
     # which shouldn't be used to store highly confidential information
@@ -83,9 +82,9 @@ module TrustyCms
       extension_loader.load_extensions
       extension_loader.load_extension_initalizers
 
-      extension_loader.activate_extensions  # also calls initialize_views
-      #config.add_controller_paths(extension_loader.paths(:controller))
-      #config.add_eager_load_paths(extension_loader.paths(:eager_load))
+      extension_loader.activate_extensions # also calls initialize_views
+      # config.add_controller_paths(extension_loader.paths(:controller))
+      # config.add_eager_load_paths(extension_loader.paths(:eager_load))
 
       # Add new inflection rules using the following format:
       ActiveSupport::Inflector.inflections do |inflect|

data/config/boot.rb

@@ -1,8 +1,7 @@
 # Don't change this file!
 # Configure your app in config/environment.rb and config/environments/*.rb
 
-
 # Set up gems listed in the Gemfile.
-ENV['BUNDLE_GEMFILE'] ||= File.expand_path('../../Gemfile', __FILE__)
+ENV['BUNDLE_GEMFILE'] ||= File.expand_path('../Gemfile', __dir__)
 
 require 'bundler/setup' if File.exists?(ENV['BUNDLE_GEMFILE'])