trust 0.6.3 → 0.7.0

data/test/unit/trust/active_model_test.rb

@@ -0,0 +1,80 @@
+# Copyright (c) 2012 Bingo Entreprenøren AS
+# Copyright (c) 2012 Teknobingo Scandinavia AS
+# Copyright (c) 2012 Knut I. Stenmark
+# Copyright (c) 2012 Patrick Hanevold
+#
+# Permission is hereby granted, free of charge, to any person obtaining
+# a copy of this software and associated documentation files (the
+# "Software"), to deal in the Software without restriction, including
+# without limitation the rights to use, copy, modify, merge, publish,
+# distribute, sublicense, and/or sell copies of the Software, and to
+# permit persons to whom the Software is furnished to do so, subject to
+# the following conditions:
+#
+# The above copyright notice and this permission notice shall be
+# included in all copies or substantial portions of the Software.
+#
+# THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
+# EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF
+# MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND
+# NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE
+# LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION
+# OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION
+# WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
+
+require 'test_helper'
+
+class Trust::ActiveModelTest < ActiveSupport::TestCase
+  context 'permits?' do
+    setup do
+      @user = User.new
+      @account = Account.new
+    end
+    should 'support calls to authorized? on class level' do
+      Trust::Authorization.expects(:authorized?).with(:manage,Account,:foo)
+      Account.permits? :manage, :foo
+    end
+    should 'support calls to authorized? on instance' do
+      Trust::Authorization.expects(:authorized?).with(:manage,@account,:foo)
+      @account.permits? :manage, :foo
+    end
+    should 'support calls to authorized? with actor specified' do
+      Trust::Authorization.expects(:authorized?).with(:manage,Account,:foo, :by => :actor)
+      Account.permits? :manage, :foo, :by => :actor
+      Trust::Authorization.expects(:authorized?).with(:manage,@account,:foo, :by => :actor)
+      @account.permits? :manage, :foo, :by => :actor
+    end
+    should 'support calls to authorized? with actor specified and no parent' do
+      Trust::Authorization.expects(:authorized?).with(:manage,Account, :by => :actor)
+      Account.permits? :manage, :by => :actor
+      Trust::Authorization.expects(:authorized?).with(:manage,@account, :by => :actor)
+      @account.permits? :manage, :by => :actor
+    end
+  end
+  context 'ensure_permitted!' do
+    setup do
+      @user = User.new
+      @account = Account.new
+    end
+    should 'support calls to athorized! on class level' do
+      Trust::Authorization.expects(:authorize!).with(:manage,Account,:foo)
+      Account.ensure_permitted! :manage, :foo
+    end
+    should 'support calls to athorized! on instance' do
+      Trust::Authorization.expects(:authorize!).with(:manage,@account,:foo)
+      @account.ensure_permitted! :manage, :foo
+    end
+    should 'support calls to authorized! with actor specified' do
+      Trust::Authorization.expects(:authorize!).with(:manage,Account,:foo, :by => :actor)
+      Account.ensure_permitted! :manage, :foo, :by => :actor
+      Trust::Authorization.expects(:authorize!).with(:manage,@account,:foo, :by => :actor)
+      @account.ensure_permitted! :manage, :foo, :by => :actor
+    end
+    should 'support calls to authorized! with actor specified and no parent' do
+      Trust::Authorization.expects(:authorize!).with(:manage,Account, :by => :actor)
+      Account.ensure_permitted! :manage, :by => :actor
+      Trust::Authorization.expects(:authorize!).with(:manage,@account, :by => :actor)
+      @account.ensure_permitted! :manage, :by => :actor
+    end
+  end
+end

data/test/unit/trust/{active_record_test.rb → actor_test.rb}

@@ -24,33 +24,25 @@
 
 require 'test_helper'
 
-class Trust::ActiveRecordTest < ActiveSupport::TestCase
-  context 'permits?' do
-    setup do
-      @user = User.new
-      @account = Account.new
-    end
-    should 'support calls to athorized? on class level' do
-      Trust::Authorization.expects(:authorized?).with(:manage,Account,:foo)
-      Account.permits? :manage, :foo
-    end
-    should 'support calls to athorized? on instance' do
-      Trust::Authorization.expects(:authorized?).with(:manage,@account,:foo)
-      @account.permits? :manage, :foo
-    end
+class Trust::ActorTest < ActiveSupport::TestCase
+  class User
+    include ::Trust::Actor
   end
-  context 'ensure_permitted!' do
+  
+  context 'can?' do
     setup do
       @user = User.new
       @account = Account.new
     end
-    should 'support calls to athorized? on class level' do
-      Trust::Authorization.expects(:authorize!).with(:manage,Account,:foo)
-      Account.ensure_permitted! :manage, :foo
-    end
-    should 'support calls to athorized? on instance' do
-      Trust::Authorization.expects(:authorize!).with(:manage,@account,:foo)
-      @account.ensure_permitted! :manage, :foo
+    should 'support calls to authorized? on instance' do
+      Trust::Authorization.expects(:authorized?).with(:manage,@account, :by => @user, :parent => nil)
+      @user.can? :manage, @account
+      Trust::Authorization.expects(:authorized?).with(:manage,@account, :by => @user, :parent => :foo)
+      @user.can? :manage, @account, :foo
+      Trust::Authorization.expects(:authorized?).with(:manage,@account, :by => @user, :parent => :foo)
+      @user.can? :manage, @account, :parent => :foo
+      Trust::Authorization.expects(:authorized?).with(:manage,@account, :by => @user, :parent => :foo)
+      @user.can? :manage, @account, :for => :foo
     end
   end
 end

data/test/unit/trust/authorization_test.rb

@@ -65,34 +65,52 @@ class Trust::AuthorizationTest < ActiveSupport::TestCase
     setup do
       class Validator
       end
-      class TestAuthorizing
+      class TestAuthorizing # overrides authorizing_class
         def initialize(user, action, klass, object, parent)
           Validator.values user, action, klass, object, parent
         end
       end
-      Trust::Authorization.expects(:user).returns(:user)
-      TestAuthorizing.any_instance.expects(:authorized?).returns(true)
+      TestAuthorizing.any_instance.stubs(:authorized?).returns(true)
       Trust::Authorization.expects(:authorizing_class).with(String).returns(TestAuthorizing)
     end
     should 'instanciate authorizing class and set correct parameters for object' do
+      Trust::Authorization.expects(:user).returns(:user)
       Validator.expects(:values).with(:user, :action, String, 'object_or_class', :parent)
       assert Trust::Authorization.authorized?('action', 'object_or_class', :parent)
     end
     should 'instanciate authorizing class and set correct parameters for class' do
+      Trust::Authorization.expects(:user).returns(:user)
       Validator.expects(:values).with(:user, :action, String, nil, :parent)
       assert Trust::Authorization.authorized?('action', String, :parent)
     end
+    should 'allow actor to override user with actor' do
+      Validator.expects(:values).with('TheActor', :action, String, nil, :parent)
+      assert Trust::Authorization.authorized?('action', String, :parent, :by => 'TheActor')      
+      Trust::Authorization.expects(:authorizing_class).with(String).returns(TestAuthorizing)
+      Validator.expects(:values).with('TheActor', :action, String, nil, nil)
+      assert Trust::Authorization.authorized?('action', String, :by => 'TheActor')      
+    end
+    should 'support option for :parent' do
+      Trust::Authorization.expects(:user).returns(:user)
+      Validator.expects(:values).with(:user, :action, String, nil, 'parent')
+      assert Trust::Authorization.authorized?('action', String, :parent => 'parent')
+    end
+    should 'support option alias for :parent, namely :for' do
+      Trust::Authorization.expects(:user).returns(:user)
+      Validator.expects(:values).with(:user, :action, String, nil, 'parent')
+      assert Trust::Authorization.authorized?('action', String, :for => 'parent')
+    end
   end
 
   context 'authorize!' do
     should 'call access_denied! unless authorized?' do
       Trust::Authorization.expects(:access_denied!).once
-      Trust::Authorization.expects(:authorized?).with(1, 2, 3).returns(false)
+      Trust::Authorization.expects(:authorized?).with(1, 2, 3, {}).returns(false)
       Trust::Authorization.authorize!(1,2,3)
     end
     should 'call access_denied! if authorized?' do
       Trust::Authorization.expects(:access_denied!).never
-      Trust::Authorization.expects(:authorized?).with(1, 2, 3).returns(true)
+      Trust::Authorization.expects(:authorized?).with(1, 2, 3, {}).returns(true)
       Trust::Authorization.authorize!(1,2,3)
     end    
   end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: trust
 version: !ruby/object:Gem::Version
-  version: 0.6.3
+  version: 0.7.0
   prerelease: 
 platform: ruby
 authors:
@@ -10,7 +10,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2012-09-13 00:00:00.000000000 Z
+date: 2012-09-23 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rails
@@ -59,7 +59,8 @@ extensions: []
 extra_rdoc_files: []
 files:
 - lib/tasks/trust_tasks.rake
-- lib/trust/active_record.rb
+- lib/trust/active_model.rb
+- lib/trust/actor.rb
 - lib/trust/authorization.rb
 - lib/trust/controller/properties.rb
 - lib/trust/controller/resource.rb
@@ -151,6 +152,7 @@ files:
 - test/dummy/db/migrate/20120523144144_create_clients.rb
 - test/dummy/db/schema.rb
 - test/dummy/db/test.sqlite3
+- test/dummy/log/development.log
 - test/dummy/log/test.log
 - test/dummy/public/404.html
 - test/dummy/public/422.html
@@ -176,7 +178,8 @@ files:
 - test/dummy/test/unit/user_test.rb
 - test/test_helper.rb
 - test/trust_test.rb
-- test/unit/trust/active_record_test.rb
+- test/unit/trust/active_model_test.rb
+- test/unit/trust/actor_test.rb
 - test/unit/trust/authorization_test.rb
 - test/unit/trust/controller/properties_test.rb
 - test/unit/trust/controller/resource_test.rb
@@ -197,7 +200,7 @@ required_ruby_version: !ruby/object:Gem::Requirement
       version: '0'
       segments:
       - 0
-      hash: -4551844611628128017
+      hash: -3498159881798664050
 required_rubygems_version: !ruby/object:Gem::Requirement
   none: false
   requirements:
@@ -206,7 +209,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
       segments:
       - 0
-      hash: -4551844611628128017
+      hash: -3498159881798664050
 requirements: []
 rubyforge_project: 
 rubygems_version: 1.8.24
@@ -292,6 +295,7 @@ test_files:
 - test/dummy/db/migrate/20120523144144_create_clients.rb
 - test/dummy/db/schema.rb
 - test/dummy/db/test.sqlite3
+- test/dummy/log/development.log
 - test/dummy/log/test.log
 - test/dummy/public/404.html
 - test/dummy/public/422.html
@@ -317,7 +321,8 @@ test_files:
 - test/dummy/test/unit/user_test.rb
 - test/test_helper.rb
 - test/trust_test.rb
-- test/unit/trust/active_record_test.rb
+- test/unit/trust/active_model_test.rb
+- test/unit/trust/actor_test.rb
 - test/unit/trust/authorization_test.rb
 - test/unit/trust/controller/properties_test.rb
 - test/unit/trust/controller/resource_test.rb