truemail 2.4.9 → 2.5.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 5fe7168451269d442bab0872d515895af1c79b884ed3306648f4849ce74320b2
-  data.tar.gz: 9797a040d814da27daa9073e19d984fa50fd033ac83eaffa96bbc5485501471d
+  metadata.gz: f4489970da0eb47e0577b29a6dd696d7a89d4c74b977a383d690e0b33e510e61
+  data.tar.gz: d3e3868b250db8d306ca42092703a2fd85576afed9657b998992b4c509651f86
 SHA512:
-  metadata.gz: 12d6e026591650b65eef26b5aa43b67e2d065e2dcb8f4d8229a6e19567e4162d6eebc41a992d35a8793a21893ea92e55f89de66ce9f35625d5efe466931e1b76
-  data.tar.gz: 04bed3c49eaf6314a21a33d0e761ca9e8c82671411f96e2b7428202cd3e0225ac4f13fd545202c6898f9328a17466e91cf957c5abfcf03ac8f0bf8801c0dc807
+  metadata.gz: e6086d5f8e6700ede8b26db492c5fbe3fe4e56ecf844f9461364af755f945210de4856f4ec5b255602571ce46dd166dc4739b53b9c00431bcd9b3817d16afa5e
+  data.tar.gz: a626ff47ae105cd13c8659522e8e354e7ec8cf35533930901c34a23378cb15c90dac591294186ec260ba1e4adffca5db00abd3374cf6e2b5ee35f35c6c537828

data/.codeclimate.yml

@@ -7,7 +7,7 @@ checks:
 plugins:
   rubocop:
     enabled: true
-    channel: rubocop-1-19
+    channel: rubocop-1-22
 
   reek:
     enabled: true

data/.rubocop.yml

@@ -169,6 +169,15 @@ Style/QuotedSymbols:
 Style/RedundantSelfAssignmentBranch:
   Enabled: true
 
+Style/NumberedParameters:
+  Enabled: true
+
+Style/NumberedParametersLimit:
+  Enabled: true
+
+Style/SelectByRegexp:
+  Enabled: true
+
 Layout/LineLength:
   Max: 140
 
@@ -332,9 +341,21 @@ Lint/EmptyInPattern:
 Lint/AmbiguousRange:
   Enabled: true
 
+Lint/AmbiguousOperatorPrecedence:
+  Enabled: true
+
+Lint/IncompatibleIoSelectWithFiberScheduler:
+  Enabled: true
+
+Lint/RequireRelativeSelfPath:
+  Enabled: true
+
 Gemspec/DateAssignment:
   Enabled: true
 
+Security/IoMethods:
+  Enabled: true
+
 Performance/AncestorsInclude:
   Enabled: true
 
@@ -383,6 +404,9 @@ Performance/RedundantSplitRegexpArgument:
 Performance/MapCompact:
   Enabled: true
 
+Performance/ConcurrentMonotonicTime:
+  Enabled: true
+
 RSpec/ExampleLength:
   Enabled: false
 
@@ -418,3 +442,9 @@ RSpec/IdenticalEqualityAssertion:
 
 RSpec/Rails/AvoidSetupHook:
   Enabled: true
+
+RSpec/ExcessiveDocstringSpacing:
+  Enabled: true
+
+RSpec/SubjectDeclaration:
+  Enabled: true

data/CHANGELOG.md

@@ -2,6 +2,47 @@
 
 The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/), and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
 
+## [2.5.3] - 2021.11.08
+
+### Fixed
+
+- Ruby 3.0 stdlib SMTP client SSL certificate verification issues for cases when IP address uses as MX host. Thanks [@esb](https://github.com/esb) for bug report.
+
+### Updated
+
+- Updated `Truemail::Validate::Smtp::Request#run`
+- Updated gem development dependencies
+- Updated gem version
+
+## [2.5.2] - 2021.10.06
+
+### Fixed
+
+- `Truemail::RegexConstant::REGEX_EMAIL_PATTERN` behaviour with double `@` in email. Thanks [@your-favorite-dev](https://github.com/your-favorite-dev) for bug report.
+
+### Updated
+
+- Updated tests
+- Updated gem development dependencies
+- Updated gem version
+
+## [2.5.1] - 2021.10.01
+
+### Updated
+
+- Updated gem development dependencies
+- Updated gem version
+
+## [2.5.0] - 2021.09.01
+
+### Updated
+
+Optimized DNS (MX) validation flow. Removed needless DNS request for case when custom email pattern was defined and email for validation includes invalid domain name.
+
+- Updated `Truemail::Validate::Mx#run`, tests
+- Updated gem development dependencies
+- Updated gem documentation, version
+
 ## [2.4.9] - 2021.08.20
 
 ### Updated

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    truemail (2.4.9)
+    truemail (2.5.3)
       simpleidn (~> 0.2.1)
 
 GEM
@@ -10,7 +10,7 @@ GEM
     addressable (2.8.0)
       public_suffix (>= 2.0.2, < 5.0)
     ast (2.4.2)
-    bundler-audit (0.8.0)
+    bundler-audit (0.9.0.1)
       bundler (>= 1.2.0, < 3)
       thor (~> 1.0)
     byebug (11.1.3)
@@ -20,16 +20,16 @@ GEM
     crack (0.4.5)
       rexml
     diff-lcs (1.4.4)
-    dns_mock (1.4.1)
+    dns_mock (1.4.3)
       simpleidn (~> 0.2.1)
     docile (1.4.0)
     fasterer (0.9.0)
       colorize (~> 0.7)
       ruby_parser (>= 3.14.1)
-    ffaker (2.19.0)
+    ffaker (2.20.0)
     hashdiff (1.0.1)
     iniparse (1.5.0)
-    json (2.5.1)
+    json (2.6.1)
     json_matchers (0.11.1)
       json_schema
     json_schema (0.21.0)
@@ -39,7 +39,7 @@ GEM
       childprocess (>= 0.6.3, < 5)
       iniparse (~> 1.4)
       rexml (~> 3.2)
-    parallel (1.20.1)
+    parallel (1.21.0)
     parser (3.0.2.0)
       ast (~> 2.4.1)
     pry (0.13.1)
@@ -69,28 +69,27 @@ GEM
     rspec-mocks (3.10.2)
       diff-lcs (>= 1.2.0, < 2.0)
       rspec-support (~> 3.10.0)
-    rspec-support (3.10.2)
-    rubocop (1.19.1)
+    rspec-support (3.10.3)
+    rubocop (1.22.3)
       parallel (~> 1.10)
       parser (>= 3.0.0.0)
       rainbow (>= 2.2.2, < 4.0)
       regexp_parser (>= 1.8, < 3.0)
       rexml
-      rubocop-ast (>= 1.9.1, < 2.0)
+      rubocop-ast (>= 1.12.0, < 2.0)
       ruby-progressbar (~> 1.7)
       unicode-display_width (>= 1.4.0, < 3.0)
-    rubocop-ast (1.10.0)
+    rubocop-ast (1.13.0)
       parser (>= 3.0.1.1)
-    rubocop-performance (1.11.5)
+    rubocop-performance (1.12.0)
       rubocop (>= 1.7.0, < 2.0)
       rubocop-ast (>= 0.4.0)
-    rubocop-rspec (2.4.0)
-      rubocop (~> 1.0)
-      rubocop-ast (>= 1.1.0)
+    rubocop-rspec (2.6.0)
+      rubocop (~> 1.19)
     ruby-progressbar (1.11.0)
-    ruby_parser (3.17.0)
-      sexp_processor (~> 4.15, >= 4.15.1)
-    sexp_processor (4.15.3)
+    ruby_parser (3.18.0)
+      sexp_processor (~> 4.16)
+    sexp_processor (4.16.0)
     simplecov (0.17.1)
       docile (~> 1.1)
       json (>= 1.8, < 3)
@@ -105,8 +104,8 @@ GEM
       truemail (>= 2.4)
     unf (0.1.4)
       unf_ext
-    unf_ext (0.0.7.7)
-    unicode-display_width (2.0.0)
+    unf_ext (0.0.8)
+    unicode-display_width (2.1.0)
     webmock (3.14.0)
       addressable (>= 2.8.0)
       crack (>= 0.3.2)
@@ -116,24 +115,24 @@ PLATFORMS
   x86_64-darwin-20
 
 DEPENDENCIES
-  bundler (~> 2.2, >= 2.2.26)
-  bundler-audit (~> 0.8.0)
-  dns_mock (~> 1.4, >= 1.4.1)
+  bundler (~> 2.2, >= 2.2.31)
+  bundler-audit (~> 0.9.0.1)
+  dns_mock (~> 1.4, >= 1.4.3)
   fasterer (~> 0.9.0)
-  ffaker (~> 2.19)
+  ffaker (~> 2.20)
   json_matchers (~> 0.11.1)
   overcommit (~> 0.58.0)
   pry-byebug (~> 3.9)
   rake (~> 13.0, >= 13.0.6)
   reek (~> 6.0, >= 6.0.6)
   rspec (~> 3.10)
-  rubocop (~> 1.19, >= 1.19.1)
-  rubocop-performance (~> 1.11, >= 1.11.5)
-  rubocop-rspec (~> 2.4)
+  rubocop (~> 1.22, >= 1.22.3)
+  rubocop-performance (~> 1.12)
+  rubocop-rspec (~> 2.6)
   simplecov (~> 0.17.1)
   truemail!
   truemail-rspec (~> 0.7.0)
   webmock (~> 3.14)
 
 BUNDLED WITH
-   2.2.26
+   2.2.31

data/README.md

@@ -368,7 +368,7 @@ Truemail.validate('email@white-domain.com')
   @result=#<struct Truemail::Validator::Result
     success=true,
     email="email@white-domain.com",
-    domain=nil,
+    domain="white-domain.com",
     mail_servers=[],
     errors={},
     smtp_debug=nil>,
@@ -416,7 +416,7 @@ Truemail.validate('email@white-domain.com', with: :regex)
   @result=#<struct Truemail::Validator::Result
     success=true,
     email="email@white-domain.com",
-    domain=nil,
+    domain="white-domain.com",
     mail_servers=[],
     errors={},
     smtp_debug=nil>,
@@ -451,7 +451,7 @@ Truemail.validate('email@domain.com', with: :regex)
   @result=#<struct Truemail::Validator::Result
     success=false,
     email="email@domain.com",
-    domain=nil,
+    domain="domain.com",
     mail_servers=[],
     errors={},
     smtp_debug=nil>,
@@ -488,7 +488,7 @@ Truemail.validate('email@black-domain.com')
   @result=#<struct Truemail::Validator::Result
     success=false,
     email="email@black-domain.com",
-    domain=nil,
+    domain="black-domain.com",
     mail_servers=[],
     errors={},
     smtp_debug=nil>,
@@ -525,7 +525,7 @@ Truemail.validate('email@somedomain.com')
   @result=#<struct Truemail::Validator::Result
     success=true,
     email="email@somedomain.com",
-    domain=nil,
+    domain="somedomain.com",
     mail_servers=[],
     errors={},
     smtp_debug=nil>,
@@ -579,7 +579,7 @@ Truemail.validate('email@example.com', with: :regex)
     #<struct Truemail::Validator::Result
       success=true,
       email="email@example.com",
-      domain=nil,
+      domain="example.com",
       mail_servers=[],
       errors={},
       smtp_debug=nil>,
@@ -624,7 +624,7 @@ Truemail.validate('email@example.com', with: :regex)
     #<struct Truemail::Validator::Result
       success=true,
       email="email@example.com",
-      domain=nil,
+      domain="example.com",
       mail_servers=[],
       errors={},
       smtp_debug=nil>,

data/lib/truemail/core.rb

@@ -20,7 +20,7 @@ module Truemail
 
   module RegexConstant
     REGEX_DOMAIN = /[\p{L}0-9]+([\-.]{1}[\p{L}0-9]+)*\.\p{L}{2,63}/i.freeze
-    REGEX_EMAIL_PATTERN = /(?=\A.{6,255}\z)(\A([\p{L}0-9]+[\W\w]*)@(#{REGEX_DOMAIN})\z)/.freeze
+    REGEX_EMAIL_PATTERN = %r{(?=\A.{6,255}\z)(\A([\p{L}0-9]+[\w\p{L}.+!~,'&%#*^`{}|\-/?=$]*)@(#{REGEX_DOMAIN})\z)}.freeze
     REGEX_DOMAIN_PATTERN = /(?=\A.{4,255}\z)(\A#{REGEX_DOMAIN}\z)/.freeze
     REGEX_DOMAIN_FROM_EMAIL = /\A.+@(.+)\z/.freeze
     REGEX_SMTP_ERROR_BODY_PATTERN = /(?=.*550)(?=.*(user|account|customer|mailbox)).*/i.freeze

data/lib/truemail/dns/punycode_representer.rb

@@ -2,7 +2,7 @@
 
 module Truemail
   module Dns
-    PunycodeRepresenter = Class.new do
+    PunycodeRepresenter = ::Class.new do
       require 'simpleidn'
 
       def self.call(email)

data/lib/truemail/validate/mx.rb

@@ -8,13 +8,17 @@ module Truemail
 
       def run
         return false unless Truemail::Validate::Regex.check(result)
-        return true if success(mx_lookup && domain_not_include_null_mx)
+        return true if success(email_domain_valid? && mx_lookup && domain_not_include_null_mx)
         mail_servers.clear && add_error(Truemail::Validate::Mx::ERROR)
         false
       end
 
       private
 
+      def email_domain_valid?
+        Truemail::RegexConstant::REGEX_DOMAIN_PATTERN.match?(result.domain)
+      end
+
       def host_extractor_methods
         return %i[hosts_from_mx_records?] if configuration.not_rfc_mx_lookup_flow
         %i[hosts_from_mx_records? hosts_from_cname_records? host_from_a_record?]

data/lib/truemail/validate/smtp/request.rb

@@ -35,7 +35,7 @@ module Truemail
         end
 
         def run
-          session.start(configuration.verifier_domain) do |smtp_request|
+          session.start(configuration.verifier_domain, **(::RUBY_VERSION[/\A3\..+\z/] ? { tls_verify: false } : {})) do |smtp_request|
             response.connection = response.helo = true
             smtp_handshakes(smtp_request, response)
           end

data/lib/truemail/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Truemail
-  VERSION = '2.4.9'
+  VERSION = '2.5.3'
 end

data/truemail.gemspec

@@ -28,25 +28,25 @@ Gem::Specification.new do |spec|
 
   spec.files = `git ls-files -z`.split("\x0").reject { |f| f.match(%r{^(test|spec|features)/}) }
   spec.bindir        = 'exe'
-  spec.executables   = spec.files.grep(%r{^exe/}) { |f| File.basename(f) }
+  spec.executables   = spec.files.grep(%r{^exe/}) { |f| ::File.basename(f) }
   spec.require_paths = ['lib']
 
   spec.add_runtime_dependency 'simpleidn', '~> 0.2.1'
 
-  spec.add_development_dependency 'bundler', '~> 2.2', '>= 2.2.26'
-  spec.add_development_dependency 'bundler-audit', '~> 0.8.0'
-  spec.add_development_dependency 'dns_mock', '~> 1.4', '>= 1.4.1'
+  spec.add_development_dependency 'bundler', '~> 2.2', '>= 2.2.31'
+  spec.add_development_dependency 'bundler-audit', '~> 0.9.0.1'
+  spec.add_development_dependency 'dns_mock', '~> 1.4', '>= 1.4.3'
   spec.add_development_dependency 'fasterer', '~> 0.9.0'
-  spec.add_development_dependency 'ffaker', '~> 2.19'
+  spec.add_development_dependency 'ffaker', '~> 2.20'
   spec.add_development_dependency 'json_matchers', '~> 0.11.1'
   spec.add_development_dependency 'overcommit', '~> 0.58.0'
   spec.add_development_dependency 'pry-byebug', '~> 3.9'
   spec.add_development_dependency 'rake', '~> 13.0', '>= 13.0.6'
   spec.add_development_dependency 'reek', '~> 6.0', '>= 6.0.6'
   spec.add_development_dependency 'rspec', '~> 3.10'
-  spec.add_development_dependency 'rubocop', '~> 1.19', '>= 1.19.1'
-  spec.add_development_dependency 'rubocop-performance', '~> 1.11', '>= 1.11.5'
-  spec.add_development_dependency 'rubocop-rspec', '~> 2.4'
+  spec.add_development_dependency 'rubocop', '~> 1.22', '>= 1.22.3'
+  spec.add_development_dependency 'rubocop-performance', '~> 1.12'
+  spec.add_development_dependency 'rubocop-rspec', '~> 2.6'
   spec.add_development_dependency 'simplecov', '~> 0.17.1'
   spec.add_development_dependency 'truemail-rspec', '~> 0.7.0'
   spec.add_development_dependency 'webmock', '~> 3.14'

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: truemail
 version: !ruby/object:Gem::Version
-  version: 2.4.9
+  version: 2.5.3
 platform: ruby
 authors:
 - Vladislav Trotsenko
 autorequire:
 bindir: exe
 cert_chain: []
-date: 2021-08-20 00:00:00.000000000 Z
+date: 2021-11-08 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: simpleidn
@@ -33,7 +33,7 @@ dependencies:
         version: '2.2'
     - - ">="
       - !ruby/object:Gem::Version
-        version: 2.2.26
+        version: 2.2.31
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
@@ -43,21 +43,21 @@ dependencies:
         version: '2.2'
     - - ">="
       - !ruby/object:Gem::Version
-        version: 2.2.26
+        version: 2.2.31
 - !ruby/object:Gem::Dependency
   name: bundler-audit
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.8.0
+        version: 0.9.0.1
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.8.0
+        version: 0.9.0.1
 - !ruby/object:Gem::Dependency
   name: dns_mock
   requirement: !ruby/object:Gem::Requirement
@@ -67,7 +67,7 @@ dependencies:
         version: '1.4'
     - - ">="
       - !ruby/object:Gem::Version
-        version: 1.4.1
+        version: 1.4.3
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
@@ -77,7 +77,7 @@ dependencies:
         version: '1.4'
     - - ">="
       - !ruby/object:Gem::Version
-        version: 1.4.1
+        version: 1.4.3
 - !ruby/object:Gem::Dependency
   name: fasterer
   requirement: !ruby/object:Gem::Requirement
@@ -98,14 +98,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '2.19'
+        version: '2.20'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '2.19'
+        version: '2.20'
 - !ruby/object:Gem::Dependency
   name: json_matchers
   requirement: !ruby/object:Gem::Requirement
@@ -208,54 +208,48 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.19'
+        version: '1.22'
     - - ">="
       - !ruby/object:Gem::Version
-        version: 1.19.1
+        version: 1.22.3
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.19'
+        version: '1.22'
     - - ">="
       - !ruby/object:Gem::Version
-        version: 1.19.1
+        version: 1.22.3
 - !ruby/object:Gem::Dependency
   name: rubocop-performance
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.11'
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: 1.11.5
+        version: '1.12'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.11'
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: 1.11.5
+        version: '1.12'
 - !ruby/object:Gem::Dependency
   name: rubocop-rspec
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '2.4'
+        version: '2.6'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '2.4'
+        version: '2.6'
 - !ruby/object:Gem::Dependency
   name: simplecov
   requirement: !ruby/object:Gem::Requirement