truemail 2.4.8 → 2.5.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: caceed57ea14acc7cff6b2932fe2943940294aeeddc1bed4350e54bb24fa01d1
-  data.tar.gz: 14bf64538f0cf1a4c8ed898902943bb80d0df954fb225afa14afd7bef39d91cf
+  metadata.gz: d8654d41d2c02eb0fc2e8519425c89e9fb761bcdbc2aee01f9b2043c167ab9a3
+  data.tar.gz: 02ae00188163c899b4f18ea9b176025f851b76063ab96844d71f45fbcd538984
 SHA512:
-  metadata.gz: eb39ef6db6d29ffb9dc8010fc5d0b5e75f0ff3dd586a0cded87ee33000141712752ab4bb5af60cbba35df4dedec7dd8c2a9dbf1429981f1cae78b0814e737cff
-  data.tar.gz: f8e99e41faa7b9332e109d11ef1acba36247bcc14687c2543465c2414b70d2d919347162409decd8bb2be286d361ab0874ad994978a9e07848f9402e7030bef6
+  metadata.gz: '070814d64890b1257e731a63c560396589327e93c0e9c69afff84ba392a527684b7397b659a04533ff9fca4388fe0aec598dc38b42be0269bec35f8193352a02'
+  data.tar.gz: 90159401dbcee96037cb14173e8feda4cd9c998162d10b18ef701b4102d1252532968d2a75d66eb8b097bd8db4d91ae4fefd2b40d48cce9c82f99470c9cad241

data/.codeclimate.yml

@@ -7,7 +7,7 @@ checks:
 plugins:
   rubocop:
     enabled: true
-    channel: rubocop-1-18
+    channel: rubocop-1-22
 
   reek:
     enabled: true

data/.rubocop.yml

@@ -166,6 +166,18 @@ Style/MultilineInPatternThen:
 Style/QuotedSymbols:
   Enabled: true
 
+Style/RedundantSelfAssignmentBranch:
+  Enabled: true
+
+Style/NumberedParameters:
+  Enabled: true
+
+Style/NumberedParametersLimit:
+  Enabled: true
+
+Style/SelectByRegexp:
+  Enabled: true
+
 Layout/LineLength:
   Max: 140
 
@@ -326,9 +338,24 @@ Lint/TripleQuotes:
 Lint/EmptyInPattern:
   Enabled: true
 
+Lint/AmbiguousRange:
+  Enabled: true
+
+Lint/AmbiguousOperatorPrecedence:
+  Enabled: true
+
+Lint/IncompatibleIoSelectWithFiberScheduler:
+  Enabled: true
+
+Lint/RequireRelativeSelfPath:
+  Enabled: true
+
 Gemspec/DateAssignment:
   Enabled: true
 
+Security/IoMethods:
+  Enabled: true
+
 Performance/AncestorsInclude:
   Enabled: true
 
@@ -412,3 +439,9 @@ RSpec/IdenticalEqualityAssertion:
 
 RSpec/Rails/AvoidSetupHook:
   Enabled: true
+
+RSpec/ExcessiveDocstringSpacing:
+  Enabled: true
+
+RSpec/SubjectDeclaration:
+  Enabled: true

data/CHANGELOG.md

@@ -2,6 +2,44 @@
 
 The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/), and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
 
+## [2.5.2] - 2021.10.06
+
+### Fixed
+
+- `Truemail::RegexConstant::REGEX_EMAIL_PATTERN` behaviour with double `@` in email. Thanks [@your-favorite-dev](https://github.com/your-favorite-dev) for bug report.
+
+### Updated
+
+- Updated tests
+- Updated gem development dependencies
+- Updated gem version
+
+## [2.5.1] - 2021.10.01
+
+### Updated
+
+- Updated gem development dependencies
+- Updated gem version
+
+## [2.5.0] - 2021.09.01
+
+### Updated
+
+Optimized DNS (MX) validation flow. Removed needless DNS request for case when custom email pattern was defined and email for validation includes invalid domain name.
+
+- Updated `Truemail::Validate::Mx#run`, tests
+- Updated gem development dependencies
+- Updated gem documentation, version
+
+## [2.4.9] - 2021.08.20
+
+### Updated
+
+- Updated `Truemail::Validate::DomainListMatch#email_domain`, tests
+- Updated `Truemail::Validate::Mx#domain`, tests
+- Updated gem development dependencies
+- Updated gem version
+
 ## [2.4.8] - 2021.08.12
 
 ### Updated
@@ -18,7 +56,7 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
 ### Updated
 
 - Updated gem codebase, refactored `Truemail::ContextHelper`
-- Updated tests
+- Updated tests with `Truemail::DnsHelper#dns_mock_gateway`
 - Updated gem development dependencies
 - Updated gem version
 

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    truemail (2.4.8)
+    truemail (2.5.2)
       simpleidn (~> 0.2.1)
 
 GEM
@@ -10,7 +10,7 @@ GEM
     addressable (2.8.0)
       public_suffix (>= 2.0.2, < 5.0)
     ast (2.4.2)
-    bundler-audit (0.8.0)
+    bundler-audit (0.9.0.1)
       bundler (>= 1.2.0, < 3)
       thor (~> 1.0)
     byebug (11.1.3)
@@ -20,13 +20,13 @@ GEM
     crack (0.4.5)
       rexml
     diff-lcs (1.4.4)
-    dns_mock (1.4.0)
+    dns_mock (1.4.2)
       simpleidn (~> 0.2.1)
     docile (1.4.0)
     fasterer (0.9.0)
       colorize (~> 0.7)
       ruby_parser (>= 3.14.1)
-    ffaker (2.18.0)
+    ffaker (2.20.0)
     hashdiff (1.0.1)
     iniparse (1.5.0)
     json (2.5.1)
@@ -39,7 +39,7 @@ GEM
       childprocess (>= 0.6.3, < 5)
       iniparse (~> 1.4)
       rexml (~> 3.2)
-    parallel (1.20.1)
+    parallel (1.21.0)
     parser (3.0.2.0)
       ast (~> 2.4.1)
     pry (0.13.1)
@@ -48,14 +48,12 @@ GEM
     pry-byebug (3.9.0)
       byebug (~> 11.0)
       pry (~> 0.13.0)
-    psych (4.0.1)
     public_suffix (4.0.6)
     rainbow (3.0.0)
     rake (13.0.6)
-    reek (6.0.5)
+    reek (6.0.6)
       kwalify (~> 0.7.0)
       parser (~> 3.0.0)
-      psych (>= 3.1, < 5.0)
       rainbow (>= 2.0, < 4.0)
     regexp_parser (2.1.1)
     rexml (3.2.5)
@@ -72,23 +70,22 @@ GEM
       diff-lcs (>= 1.2.0, < 2.0)
       rspec-support (~> 3.10.0)
     rspec-support (3.10.2)
-    rubocop (1.18.4)
+    rubocop (1.22.1)
       parallel (~> 1.10)
       parser (>= 3.0.0.0)
       rainbow (>= 2.2.2, < 4.0)
       regexp_parser (>= 1.8, < 3.0)
       rexml
-      rubocop-ast (>= 1.8.0, < 2.0)
+      rubocop-ast (>= 1.12.0, < 2.0)
       ruby-progressbar (~> 1.7)
       unicode-display_width (>= 1.4.0, < 3.0)
-    rubocop-ast (1.9.1)
+    rubocop-ast (1.12.0)
       parser (>= 3.0.1.1)
-    rubocop-performance (1.11.4)
+    rubocop-performance (1.11.5)
       rubocop (>= 1.7.0, < 2.0)
       rubocop-ast (>= 0.4.0)
-    rubocop-rspec (2.4.0)
-      rubocop (~> 1.0)
-      rubocop-ast (>= 1.1.0)
+    rubocop-rspec (2.5.0)
+      rubocop (~> 1.19)
     ruby-progressbar (1.11.0)
     ruby_parser (3.17.0)
       sexp_processor (~> 4.15, >= 4.15.1)
@@ -107,8 +104,8 @@ GEM
       truemail (>= 2.4)
     unf (0.1.4)
       unf_ext
-    unf_ext (0.0.7.7)
-    unicode-display_width (2.0.0)
+    unf_ext (0.0.8)
+    unicode-display_width (2.1.0)
     webmock (3.14.0)
       addressable (>= 2.8.0)
       crack (>= 0.3.2)
@@ -118,24 +115,24 @@ PLATFORMS
   x86_64-darwin-20
 
 DEPENDENCIES
-  bundler (~> 2.2, >= 2.2.25)
-  bundler-audit (~> 0.8.0)
-  dns_mock (~> 1.4)
+  bundler (~> 2.2, >= 2.2.28)
+  bundler-audit (~> 0.9.0.1)
+  dns_mock (~> 1.4, >= 1.4.2)
   fasterer (~> 0.9.0)
-  ffaker (~> 2.18)
+  ffaker (~> 2.20)
   json_matchers (~> 0.11.1)
   overcommit (~> 0.58.0)
   pry-byebug (~> 3.9)
   rake (~> 13.0, >= 13.0.6)
-  reek (~> 6.0, >= 6.0.5)
+  reek (~> 6.0, >= 6.0.6)
   rspec (~> 3.10)
-  rubocop (~> 1.18, >= 1.18.4)
-  rubocop-performance (~> 1.11, >= 1.11.4)
-  rubocop-rspec (~> 2.4)
+  rubocop (~> 1.22, >= 1.22.1)
+  rubocop-performance (~> 1.11, >= 1.11.5)
+  rubocop-rspec (~> 2.5)
   simplecov (~> 0.17.1)
   truemail!
   truemail-rspec (~> 0.7.0)
   webmock (~> 3.14)
 
 BUNDLED WITH
-   2.2.25
+   2.2.28

data/README.md

@@ -368,7 +368,7 @@ Truemail.validate('email@white-domain.com')
   @result=#<struct Truemail::Validator::Result
     success=true,
     email="email@white-domain.com",
-    domain=nil,
+    domain="white-domain.com",
     mail_servers=[],
     errors={},
     smtp_debug=nil>,
@@ -416,7 +416,7 @@ Truemail.validate('email@white-domain.com', with: :regex)
   @result=#<struct Truemail::Validator::Result
     success=true,
     email="email@white-domain.com",
-    domain=nil,
+    domain="white-domain.com",
     mail_servers=[],
     errors={},
     smtp_debug=nil>,
@@ -451,7 +451,7 @@ Truemail.validate('email@domain.com', with: :regex)
   @result=#<struct Truemail::Validator::Result
     success=false,
     email="email@domain.com",
-    domain=nil,
+    domain="domain.com",
     mail_servers=[],
     errors={},
     smtp_debug=nil>,
@@ -488,7 +488,7 @@ Truemail.validate('email@black-domain.com')
   @result=#<struct Truemail::Validator::Result
     success=false,
     email="email@black-domain.com",
-    domain=nil,
+    domain="black-domain.com",
     mail_servers=[],
     errors={},
     smtp_debug=nil>,
@@ -525,7 +525,7 @@ Truemail.validate('email@somedomain.com')
   @result=#<struct Truemail::Validator::Result
     success=true,
     email="email@somedomain.com",
-    domain=nil,
+    domain="somedomain.com",
     mail_servers=[],
     errors={},
     smtp_debug=nil>,
@@ -579,7 +579,7 @@ Truemail.validate('email@example.com', with: :regex)
     #<struct Truemail::Validator::Result
       success=true,
       email="email@example.com",
-      domain=nil,
+      domain="example.com",
       mail_servers=[],
       errors={},
       smtp_debug=nil>,
@@ -624,7 +624,7 @@ Truemail.validate('email@example.com', with: :regex)
     #<struct Truemail::Validator::Result
       success=true,
       email="email@example.com",
-      domain=nil,
+      domain="example.com",
       mail_servers=[],
       errors={},
       smtp_debug=nil>,

data/lib/truemail/core.rb

@@ -20,7 +20,7 @@ module Truemail
 
   module RegexConstant
     REGEX_DOMAIN = /[\p{L}0-9]+([\-.]{1}[\p{L}0-9]+)*\.\p{L}{2,63}/i.freeze
-    REGEX_EMAIL_PATTERN = /(?=\A.{6,255}\z)(\A([\p{L}0-9]+[\W\w]*)@(#{REGEX_DOMAIN})\z)/.freeze
+    REGEX_EMAIL_PATTERN = %r{(?=\A.{6,255}\z)(\A([\p{L}0-9]+[\w\p{L}.+!~,'&%#*^`{}|\-/?=$]*)@(#{REGEX_DOMAIN})\z)}.freeze
     REGEX_DOMAIN_PATTERN = /(?=\A.{4,255}\z)(\A#{REGEX_DOMAIN}\z)/.freeze
     REGEX_DOMAIN_FROM_EMAIL = /\A.+@(.+)\z/.freeze
     REGEX_SMTP_ERROR_BODY_PATTERN = /(?=.*550)(?=.*(user|account|customer|mailbox)).*/i.freeze

data/lib/truemail/dns/punycode_representer.rb

@@ -2,7 +2,7 @@
 
 module Truemail
   module Dns
-    PunycodeRepresenter = Class.new do
+    PunycodeRepresenter = ::Class.new do
       require 'simpleidn'
 
       def self.call(email)

data/lib/truemail/validate/domain_list_match.rb

@@ -15,7 +15,8 @@ module Truemail
       private
 
       def email_domain
-        @email_domain ||= result.email[Truemail::RegexConstant::REGEX_DOMAIN_FROM_EMAIL, 1]
+        @email_domain ||=
+          result.domain = result.email[Truemail::RegexConstant::REGEX_DOMAIN_FROM_EMAIL, 1]
       end
 
       def whitelisted_domain?

data/lib/truemail/validate/mx.rb

@@ -8,13 +8,17 @@ module Truemail
 
       def run
         return false unless Truemail::Validate::Regex.check(result)
-        return true if success(mx_lookup && domain_not_include_null_mx)
+        return true if success(email_domain_valid? && mx_lookup && domain_not_include_null_mx)
         mail_servers.clear && add_error(Truemail::Validate::Mx::ERROR)
         false
       end
 
       private
 
+      def email_domain_valid?
+        Truemail::RegexConstant::REGEX_DOMAIN_PATTERN.match?(result.domain)
+      end
+
       def host_extractor_methods
         return %i[hosts_from_mx_records?] if configuration.not_rfc_mx_lookup_flow
         %i[hosts_from_mx_records? hosts_from_cname_records? host_from_a_record?]
@@ -52,10 +56,7 @@ module Truemail
       end
 
       def domain
-        @domain ||= begin
-          result.domain = result.email[Truemail::RegexConstant::REGEX_DOMAIN_FROM_EMAIL, 1]
-          result.punycode_email[Truemail::RegexConstant::REGEX_DOMAIN_FROM_EMAIL, 1]
-        end
+        @domain ||= result.punycode_email[Truemail::RegexConstant::REGEX_DOMAIN_FROM_EMAIL, 1]
       end
 
       def hosts_from_mx_records?

data/lib/truemail/validate/smtp.rb

@@ -35,7 +35,7 @@ module Truemail
       def attempts
         @attempts ||= begin
           return {} if fail_fast? || !mail_servers.one?
-          { attempts: configuration.connection_attempts }
+          { attempts: configuration.connection_attempts } # attempts should used for case with one mail server only
         end
       end
 

data/lib/truemail/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Truemail
-  VERSION = '2.4.8'
+  VERSION = '2.5.2'
 end

data/truemail.gemspec

@@ -28,25 +28,25 @@ Gem::Specification.new do |spec|
 
   spec.files = `git ls-files -z`.split("\x0").reject { |f| f.match(%r{^(test|spec|features)/}) }
   spec.bindir        = 'exe'
-  spec.executables   = spec.files.grep(%r{^exe/}) { |f| File.basename(f) }
+  spec.executables   = spec.files.grep(%r{^exe/}) { |f| ::File.basename(f) }
   spec.require_paths = ['lib']
 
   spec.add_runtime_dependency 'simpleidn', '~> 0.2.1'
 
-  spec.add_development_dependency 'bundler', '~> 2.2', '>= 2.2.25'
-  spec.add_development_dependency 'bundler-audit', '~> 0.8.0'
-  spec.add_development_dependency 'dns_mock', '~> 1.4'
+  spec.add_development_dependency 'bundler', '~> 2.2', '>= 2.2.28'
+  spec.add_development_dependency 'bundler-audit', '~> 0.9.0.1'
+  spec.add_development_dependency 'dns_mock', '~> 1.4', '>= 1.4.2'
   spec.add_development_dependency 'fasterer', '~> 0.9.0'
-  spec.add_development_dependency 'ffaker', '~> 2.18'
+  spec.add_development_dependency 'ffaker', '~> 2.20'
   spec.add_development_dependency 'json_matchers', '~> 0.11.1'
   spec.add_development_dependency 'overcommit', '~> 0.58.0'
   spec.add_development_dependency 'pry-byebug', '~> 3.9'
   spec.add_development_dependency 'rake', '~> 13.0', '>= 13.0.6'
-  spec.add_development_dependency 'reek', '~> 6.0', '>= 6.0.5'
+  spec.add_development_dependency 'reek', '~> 6.0', '>= 6.0.6'
   spec.add_development_dependency 'rspec', '~> 3.10'
-  spec.add_development_dependency 'rubocop', '~> 1.18', '>= 1.18.4'
-  spec.add_development_dependency 'rubocop-performance', '~> 1.11', '>= 1.11.4'
-  spec.add_development_dependency 'rubocop-rspec', '~> 2.4'
+  spec.add_development_dependency 'rubocop', '~> 1.22', '>= 1.22.1'
+  spec.add_development_dependency 'rubocop-performance', '~> 1.11', '>= 1.11.5'
+  spec.add_development_dependency 'rubocop-rspec', '~> 2.5'
   spec.add_development_dependency 'simplecov', '~> 0.17.1'
   spec.add_development_dependency 'truemail-rspec', '~> 0.7.0'
   spec.add_development_dependency 'webmock', '~> 3.14'

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: truemail
 version: !ruby/object:Gem::Version
-  version: 2.4.8
+  version: 2.5.2
 platform: ruby
 authors:
 - Vladislav Trotsenko
 autorequire:
 bindir: exe
 cert_chain: []
-date: 2021-08-12 00:00:00.000000000 Z
+date: 2021-10-06 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: simpleidn
@@ -33,7 +33,7 @@ dependencies:
         version: '2.2'
     - - ">="
       - !ruby/object:Gem::Version
-        version: 2.2.25
+        version: 2.2.28
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
@@ -43,21 +43,21 @@ dependencies:
         version: '2.2'
     - - ">="
       - !ruby/object:Gem::Version
-        version: 2.2.25
+        version: 2.2.28
 - !ruby/object:Gem::Dependency
   name: bundler-audit
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.8.0
+        version: 0.9.0.1
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.8.0
+        version: 0.9.0.1
 - !ruby/object:Gem::Dependency
   name: dns_mock
   requirement: !ruby/object:Gem::Requirement
@@ -65,6 +65,9 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: '1.4'
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: 1.4.2
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
@@ -72,6 +75,9 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: '1.4'
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: 1.4.2
 - !ruby/object:Gem::Dependency
   name: fasterer
   requirement: !ruby/object:Gem::Requirement
@@ -92,14 +98,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '2.18'
+        version: '2.20'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '2.18'
+        version: '2.20'
 - !ruby/object:Gem::Dependency
   name: json_matchers
   requirement: !ruby/object:Gem::Requirement
@@ -171,7 +177,7 @@ dependencies:
         version: '6.0'
     - - ">="
       - !ruby/object:Gem::Version
-        version: 6.0.5
+        version: 6.0.6
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
@@ -181,7 +187,7 @@ dependencies:
         version: '6.0'
     - - ">="
       - !ruby/object:Gem::Version
-        version: 6.0.5
+        version: 6.0.6
 - !ruby/object:Gem::Dependency
   name: rspec
   requirement: !ruby/object:Gem::Requirement
@@ -202,20 +208,20 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.18'
+        version: '1.22'
     - - ">="
       - !ruby/object:Gem::Version
-        version: 1.18.4
+        version: 1.22.1
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.18'
+        version: '1.22'
     - - ">="
       - !ruby/object:Gem::Version
-        version: 1.18.4
+        version: 1.22.1
 - !ruby/object:Gem::Dependency
   name: rubocop-performance
   requirement: !ruby/object:Gem::Requirement
@@ -225,7 +231,7 @@ dependencies:
         version: '1.11'
     - - ">="
       - !ruby/object:Gem::Version
-        version: 1.11.4
+        version: 1.11.5
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
@@ -235,21 +241,21 @@ dependencies:
         version: '1.11'
     - - ">="
       - !ruby/object:Gem::Version
-        version: 1.11.4
+        version: 1.11.5
 - !ruby/object:Gem::Dependency
   name: rubocop-rspec
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '2.4'
+        version: '2.5'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '2.4'
+        version: '2.5'
 - !ruby/object:Gem::Dependency
   name: simplecov
   requirement: !ruby/object:Gem::Requirement