truemail 2.4.6 → 2.5.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 5b2201740b5ebff1faab259b9fc6f824c3a1d35ae09c7e39ad1a12ec669acfaa
-  data.tar.gz: ee1d67e7ce06d83f314f0e1bb3cb74c184ce5299e25d1dcc8303f34d07121e9f
+  metadata.gz: 515e45301d2ce2c107072aa76fe6384a87b675f76f1116be453f4bfdb6ff2f2a
+  data.tar.gz: f21f8a5b3c3fc66d9a236983c010ff497676c7273dbdba81d2a85fee918f041b
 SHA512:
-  metadata.gz: d778d06f21cd3c6fac2fc346ef576a060e47f502e1f83d1c06533c2857785f7589b85a0762cd0692ad18b0520cb44531840821dd986eb1ff3d687b90e524ac7f
-  data.tar.gz: d493f1b19593721bf6d7c86c2a7534a4a6a856642a095b213746b44a4e7e4c99e1cde52d6f026bdbdbd1613176edfad904497159bd8e5756729d5b7e162a64ad
+  metadata.gz: 14bbc12149dbbbb9dc575c7af8a4575189e4a49f05cf7335c0acaa65a92cd88a29d347b1c4a486d04e022f5a5ba8748b2881fe002ea0857c07bc28c69c8da85a
+  data.tar.gz: f98c6c20dc88c08f7fdad35fa240b989ec62f7928be4b32b98bba178f6645732a028b1c355c1ac5b5b623e144ee1e2524f1e283dabc28a0c5f35a96077f24308

data/.codeclimate.yml

@@ -7,7 +7,7 @@ checks:
 plugins:
   rubocop:
     enabled: true
-    channel: rubocop-1-18
+    channel: rubocop-1-19
 
   reek:
     enabled: true

data/.rubocop.yml

@@ -166,6 +166,9 @@ Style/MultilineInPatternThen:
 Style/QuotedSymbols:
   Enabled: true
 
+Style/RedundantSelfAssignmentBranch:
+  Enabled: true
+
 Layout/LineLength:
   Max: 140
 
@@ -326,6 +329,9 @@ Lint/TripleQuotes:
 Lint/EmptyInPattern:
   Enabled: true
 
+Lint/AmbiguousRange:
+  Enabled: true
+
 Gemspec/DateAssignment:
   Enabled: true
 

data/CHANGELOG.md

@@ -2,6 +2,45 @@
 
 The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/), and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
 
+## [2.5.0] - 2021.09.01
+
+### Updated
+
+Optimized DNS (MX) validation flow. Removed needless DNS request for case when custom email pattern was defined and email for validation includes invalid domain name.
+
+- Updated `Truemail::Validate::Mx#run`, tests
+- Updated gem development dependencies
+- Updated gem documentation, version
+
+## [2.4.9] - 2021.08.20
+
+### Updated
+
+- Updated `Truemail::Validate::DomainListMatch#email_domain`, tests
+- Updated `Truemail::Validate::Mx#domain`, tests
+- Updated gem development dependencies
+- Updated gem version
+
+## [2.4.8] - 2021.08.12
+
+### Updated
+
+- Updated gem development dependencies
+- Updated gem version
+
+### Changed
+
+- `faker` to `ffaker` development dependency
+
+## [2.4.7] - 2021.08.09
+
+### Updated
+
+- Updated gem codebase, refactored `Truemail::ContextHelper`
+- Updated tests with `Truemail::DnsHelper#dns_mock_gateway`
+- Updated gem development dependencies
+- Updated gem version
+
 ## [2.4.6] - 2021.07.10
 
 ### Fixed

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    truemail (2.4.6)
+    truemail (2.5.0)
       simpleidn (~> 0.2.1)
 
 GEM
@@ -17,20 +17,17 @@ GEM
     childprocess (4.1.0)
     coderay (1.1.3)
     colorize (0.8.1)
-    concurrent-ruby (1.1.9)
     crack (0.4.5)
       rexml
     diff-lcs (1.4.4)
-    dns_mock (1.3.1)
+    dns_mock (1.4.1)
+      simpleidn (~> 0.2.1)
     docile (1.4.0)
-    faker (2.18.0)
-      i18n (>= 1.6, < 2)
     fasterer (0.9.0)
       colorize (~> 0.7)
       ruby_parser (>= 3.14.1)
+    ffaker (2.19.0)
     hashdiff (1.0.1)
-    i18n (1.8.10)
-      concurrent-ruby (~> 1.0)
     iniparse (1.5.0)
     json (2.5.1)
     json_matchers (0.11.1)
@@ -51,14 +48,12 @@ GEM
     pry-byebug (3.9.0)
       byebug (~> 11.0)
       pry (~> 0.13.0)
-    psych (3.3.2)
     public_suffix (4.0.6)
     rainbow (3.0.0)
     rake (13.0.6)
-    reek (6.0.4)
+    reek (6.0.6)
       kwalify (~> 0.7.0)
       parser (~> 3.0.0)
-      psych (~> 3.1)
       rainbow (>= 2.0, < 4.0)
     regexp_parser (2.1.1)
     rexml (3.2.5)
@@ -75,25 +70,25 @@ GEM
       diff-lcs (>= 1.2.0, < 2.0)
       rspec-support (~> 3.10.0)
     rspec-support (3.10.2)
-    rubocop (1.18.3)
+    rubocop (1.19.1)
       parallel (~> 1.10)
       parser (>= 3.0.0.0)
       rainbow (>= 2.2.2, < 4.0)
       regexp_parser (>= 1.8, < 3.0)
       rexml
-      rubocop-ast (>= 1.7.0, < 2.0)
+      rubocop-ast (>= 1.9.1, < 2.0)
       ruby-progressbar (~> 1.7)
       unicode-display_width (>= 1.4.0, < 3.0)
-    rubocop-ast (1.7.0)
+    rubocop-ast (1.10.0)
       parser (>= 3.0.1.1)
-    rubocop-performance (1.11.4)
+    rubocop-performance (1.11.5)
       rubocop (>= 1.7.0, < 2.0)
       rubocop-ast (>= 0.4.0)
     rubocop-rspec (2.4.0)
       rubocop (~> 1.0)
       rubocop-ast (>= 1.1.0)
     ruby-progressbar (1.11.0)
-    ruby_parser (3.16.0)
+    ruby_parser (3.17.0)
       sexp_processor (~> 4.15, >= 4.15.1)
     sexp_processor (4.15.3)
     simplecov (0.17.1)
@@ -104,16 +99,16 @@ GEM
     simpleidn (0.2.1)
       unf (~> 0.1.4)
     thor (1.1.0)
-    truemail-rspec (0.6.0)
-      faker (~> 2.17)
+    truemail-rspec (0.7.0)
+      ffaker (~> 2.18)
       rspec (~> 3.10)
       truemail (>= 2.4)
     unf (0.1.4)
       unf_ext
     unf_ext (0.0.7.7)
     unicode-display_width (2.0.0)
-    webmock (3.13.0)
-      addressable (>= 2.3.6)
+    webmock (3.14.0)
+      addressable (>= 2.8.0)
       crack (>= 0.3.2)
       hashdiff (>= 0.4.0, < 2.0.0)
 
@@ -121,24 +116,24 @@ PLATFORMS
   x86_64-darwin-20
 
 DEPENDENCIES
-  bundler (~> 2.2, >= 2.2.23)
+  bundler (~> 2.2, >= 2.2.26)
   bundler-audit (~> 0.8.0)
-  dns_mock (~> 1.3, >= 1.3.1)
-  faker (~> 2.18)
+  dns_mock (~> 1.4, >= 1.4.1)
   fasterer (~> 0.9.0)
+  ffaker (~> 2.19)
   json_matchers (~> 0.11.1)
   overcommit (~> 0.58.0)
   pry-byebug (~> 3.9)
   rake (~> 13.0, >= 13.0.6)
-  reek (~> 6.0, >= 6.0.4)
+  reek (~> 6.0, >= 6.0.6)
   rspec (~> 3.10)
-  rubocop (~> 1.18, >= 1.18.3)
-  rubocop-performance (~> 1.11, >= 1.11.4)
+  rubocop (~> 1.19, >= 1.19.1)
+  rubocop-performance (~> 1.11, >= 1.11.5)
   rubocop-rspec (~> 2.4)
   simplecov (~> 0.17.1)
   truemail!
-  truemail-rspec (~> 0.6)
-  webmock (~> 3.13)
+  truemail-rspec (~> 0.7.0)
+  webmock (~> 3.14)
 
 BUNDLED WITH
-   2.2.23
+   2.2.26

data/lib/truemail/validate/domain_list_match.rb

@@ -15,7 +15,8 @@ module Truemail
       private
 
       def email_domain
-        @email_domain ||= result.email[Truemail::RegexConstant::REGEX_DOMAIN_FROM_EMAIL, 1]
+        @email_domain ||=
+          result.domain = result.email[Truemail::RegexConstant::REGEX_DOMAIN_FROM_EMAIL, 1]
       end
 
       def whitelisted_domain?

data/lib/truemail/validate/mx.rb

@@ -8,13 +8,17 @@ module Truemail
 
       def run
         return false unless Truemail::Validate::Regex.check(result)
-        return true if success(mx_lookup && domain_not_include_null_mx)
+        return true if success(email_domain_valid? && mx_lookup && domain_not_include_null_mx)
         mail_servers.clear && add_error(Truemail::Validate::Mx::ERROR)
         false
       end
 
       private
 
+      def email_domain_valid?
+        Truemail::RegexConstant::REGEX_DOMAIN_PATTERN.match?(result.domain)
+      end
+
       def host_extractor_methods
         return %i[hosts_from_mx_records?] if configuration.not_rfc_mx_lookup_flow
         %i[hosts_from_mx_records? hosts_from_cname_records? host_from_a_record?]
@@ -52,10 +56,7 @@ module Truemail
       end
 
       def domain
-        @domain ||= begin
-          result.domain = result.email[Truemail::RegexConstant::REGEX_DOMAIN_FROM_EMAIL, 1]
-          result.punycode_email[Truemail::RegexConstant::REGEX_DOMAIN_FROM_EMAIL, 1]
-        end
+        @domain ||= result.punycode_email[Truemail::RegexConstant::REGEX_DOMAIN_FROM_EMAIL, 1]
       end
 
       def hosts_from_mx_records?

data/lib/truemail/validate/smtp.rb

@@ -35,7 +35,7 @@ module Truemail
       def attempts
         @attempts ||= begin
           return {} if fail_fast? || !mail_servers.one?
-          { attempts: configuration.connection_attempts }
+          { attempts: configuration.connection_attempts } # attempts should used for case with one mail server only
         end
       end
 

data/lib/truemail/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Truemail
-  VERSION = '2.4.6'
+  VERSION = '2.5.0'
 end

data/truemail.gemspec

@@ -33,21 +33,21 @@ Gem::Specification.new do |spec|
 
   spec.add_runtime_dependency 'simpleidn', '~> 0.2.1'
 
-  spec.add_development_dependency 'bundler', '~> 2.2', '>= 2.2.23'
+  spec.add_development_dependency 'bundler', '~> 2.2', '>= 2.2.26'
   spec.add_development_dependency 'bundler-audit', '~> 0.8.0'
-  spec.add_development_dependency 'dns_mock', '~> 1.3', '>= 1.3.1'
-  spec.add_development_dependency 'faker', '~> 2.18'
+  spec.add_development_dependency 'dns_mock', '~> 1.4', '>= 1.4.1'
   spec.add_development_dependency 'fasterer', '~> 0.9.0'
+  spec.add_development_dependency 'ffaker', '~> 2.19'
   spec.add_development_dependency 'json_matchers', '~> 0.11.1'
   spec.add_development_dependency 'overcommit', '~> 0.58.0'
   spec.add_development_dependency 'pry-byebug', '~> 3.9'
   spec.add_development_dependency 'rake', '~> 13.0', '>= 13.0.6'
-  spec.add_development_dependency 'reek', '~> 6.0', '>= 6.0.4'
+  spec.add_development_dependency 'reek', '~> 6.0', '>= 6.0.6'
   spec.add_development_dependency 'rspec', '~> 3.10'
-  spec.add_development_dependency 'rubocop', '~> 1.18', '>= 1.18.3'
-  spec.add_development_dependency 'rubocop-performance', '~> 1.11', '>= 1.11.4'
+  spec.add_development_dependency 'rubocop', '~> 1.19', '>= 1.19.1'
+  spec.add_development_dependency 'rubocop-performance', '~> 1.11', '>= 1.11.5'
   spec.add_development_dependency 'rubocop-rspec', '~> 2.4'
   spec.add_development_dependency 'simplecov', '~> 0.17.1'
-  spec.add_development_dependency 'truemail-rspec', '~> 0.6'
-  spec.add_development_dependency 'webmock', '~> 3.13'
+  spec.add_development_dependency 'truemail-rspec', '~> 0.7.0'
+  spec.add_development_dependency 'webmock', '~> 3.14'
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: truemail
 version: !ruby/object:Gem::Version
-  version: 2.4.6
+  version: 2.5.0
 platform: ruby
 authors:
 - Vladislav Trotsenko
 autorequire:
 bindir: exe
 cert_chain: []
-date: 2021-07-10 00:00:00.000000000 Z
+date: 2021-09-01 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: simpleidn
@@ -33,7 +33,7 @@ dependencies:
         version: '2.2'
     - - ">="
       - !ruby/object:Gem::Version
-        version: 2.2.23
+        version: 2.2.26
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
@@ -43,7 +43,7 @@ dependencies:
         version: '2.2'
     - - ">="
       - !ruby/object:Gem::Version
-        version: 2.2.23
+        version: 2.2.26
 - !ruby/object:Gem::Dependency
   name: bundler-audit
   requirement: !ruby/object:Gem::Requirement
@@ -64,48 +64,48 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.3'
+        version: '1.4'
     - - ">="
       - !ruby/object:Gem::Version
-        version: 1.3.1
+        version: 1.4.1
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.3'
+        version: '1.4'
     - - ">="
       - !ruby/object:Gem::Version
-        version: 1.3.1
+        version: 1.4.1
 - !ruby/object:Gem::Dependency
-  name: faker
+  name: fasterer
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '2.18'
+        version: 0.9.0
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '2.18'
+        version: 0.9.0
 - !ruby/object:Gem::Dependency
-  name: fasterer
+  name: ffaker
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.9.0
+        version: '2.19'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.9.0
+        version: '2.19'
 - !ruby/object:Gem::Dependency
   name: json_matchers
   requirement: !ruby/object:Gem::Requirement
@@ -177,7 +177,7 @@ dependencies:
         version: '6.0'
     - - ">="
       - !ruby/object:Gem::Version
-        version: 6.0.4
+        version: 6.0.6
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
@@ -187,7 +187,7 @@ dependencies:
         version: '6.0'
     - - ">="
       - !ruby/object:Gem::Version
-        version: 6.0.4
+        version: 6.0.6
 - !ruby/object:Gem::Dependency
   name: rspec
   requirement: !ruby/object:Gem::Requirement
@@ -208,20 +208,20 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.18'
+        version: '1.19'
     - - ">="
       - !ruby/object:Gem::Version
-        version: 1.18.3
+        version: 1.19.1
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.18'
+        version: '1.19'
     - - ">="
       - !ruby/object:Gem::Version
-        version: 1.18.3
+        version: 1.19.1
 - !ruby/object:Gem::Dependency
   name: rubocop-performance
   requirement: !ruby/object:Gem::Requirement
@@ -231,7 +231,7 @@ dependencies:
         version: '1.11'
     - - ">="
       - !ruby/object:Gem::Version
-        version: 1.11.4
+        version: 1.11.5
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
@@ -241,7 +241,7 @@ dependencies:
         version: '1.11'
     - - ">="
       - !ruby/object:Gem::Version
-        version: 1.11.4
+        version: 1.11.5
 - !ruby/object:Gem::Dependency
   name: rubocop-rspec
   requirement: !ruby/object:Gem::Requirement
@@ -276,28 +276,28 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '0.6'
+        version: 0.7.0
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '0.6'
+        version: 0.7.0
 - !ruby/object:Gem::Dependency
   name: webmock
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '3.13'
+        version: '3.14'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '3.13'
+        version: '3.14'
 description: Configurable framework agnostic plain Ruby email validator. Verify email
   via Regex, DNS, SMTP and even more.
 email: