truemail 2.0.2 → 2.2.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 6345fef51d5f38efde3065b8edb6d777f7c0cf9aec7a44b073da86bce5943c6a
-  data.tar.gz: 6e55b56b4cb92143059ccd3263739e724ea29f118943546d6464af248951d0c6
+  metadata.gz: 57ce495b7ea8e70dc9788b5d5528f3386a57d69233f645ab665f1a187ca08e08
+  data.tar.gz: e5696bb995de86253fec296cd6985ddb5a26f93ccc24e4a95a21b5f4ded05681
 SHA512:
-  metadata.gz: 451d5ee34a5eb52e5451017210bf6c4c5fe213f44cf7bc8b66221ab31fa202c682ecad99f810c571f430f4da0fa0c981958db694e929407ad268201bb60c0652
-  data.tar.gz: 4210cf723bd90843ccf7d806b07563b4eff7bece40d361e35897316bb5c779eedd8a82e60d46948a0f419ea9ee5ed2bfc80fc67a4384dcc47de85d25326609ac
+  metadata.gz: 3ac657676afa3a27b5b2192ec7650fd742200fd4a0d5da7a21346f4a3fb75bc2038b1183d4ebdf63ad0fcd579f05169bff6bebdf1a9c2817092d634a7974a30f
+  data.tar.gz: 3f7f43b6ee28ef483c5fdd9a31fb615f98c688e849e0363370e59d3818d3a572272c50daa7a4422dd1f12b0c5ada49e12468f8016e9a17144fc94354d6478eb7

data/.codeclimate.yml

@@ -7,7 +7,7 @@ checks:
 plugins:
   rubocop:
     enabled: true
-    channel: rubocop-1-3
+    channel: rubocop-1-5
 
   reek:
     enabled: true

data/.github/ISSUE_TEMPLATE/bug_report.md

@@ -1,7 +1,7 @@
 ---
 name: Bug report
 about: Create a report to help us improve
-title: [BUG]
+title: "[BUG] Your bug report title here"
 labels: bug
 assignees: bestwebua
 
@@ -16,6 +16,8 @@ assignees: bestwebua
 - [ ] I have read the [documentation](https://truemail-rb.org/truemail-gem)
 - [ ] I have searched for [existing GitHub issues](https://github.com/truemail-rb/truemail/issues)
 
+<!-- Please use next pattern for your bug report title: [BUG] Your bug report title here -->
+
 ### Bug description
 <!-- Please include what's happening, expected behavior, and any relevant code samples -->
 

data/.github/ISSUE_TEMPLATE/feature_request.md

@@ -1,7 +1,7 @@
 ---
 name: Feature request
 about: Suggest an idea for Truemail
-title: [FEATURE]
+title: "[FEATURE] Your feature request title here"
 labels: enhancement
 assignees: bestwebua
 
@@ -16,6 +16,8 @@ assignees: bestwebua
 - [ ] I have read the [documentation](https://truemail-rb.org/truemail-gem)
 - [ ] I have searched for [existing GitHub issues](https://github.com/truemail-rb/truemail/issues)
 
+<!-- Please use next pattern for your feature request title: [FEATURE] Your feature request title here -->
+
 ### Feature description
 
 <!-- Is your feature request related to a problem? Please describe. A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]

data/.github/ISSUE_TEMPLATE/issue_report.md

@@ -1,7 +1,7 @@
 ---
 name: Issue report
 about: Create a report to help us improve
-title: [ISSUE]
+title: "[ISSUE] Your issue report title here"
 labels: ''
 assignees: bestwebua
 
@@ -16,6 +16,8 @@ assignees: bestwebua
 - [ ] I have read the [documentation](https://truemail-rb.org/truemail-gem)
 - [ ] I have searched for [existing GitHub issues](https://github.com/truemail-rb/truemail/issues)
 
+<!-- Please use next pattern for your issue report title: [ISSUE] Your issue report title here -->
+
 ### Issue description
 <!-- Please include what's happening, expected behavior, and any relevant code samples -->
 

data/.github/ISSUE_TEMPLATE/question.md

@@ -1,7 +1,7 @@
 ---
 name: Question
 about: Ask your question to Truemail team
-title: [QUESTION]
+title: "[QUESTION] Your question title here"
 labels: question
 assignees: bestwebua
 
@@ -15,6 +15,8 @@ assignees: bestwebua
 - [ ] I have read the [documentation](https://truemail-rb.org/truemail-gem)
 - [ ] I have searched for [existing GitHub issues](https://github.com/truemail-rb/truemail/issues)
 
+<!-- Please use next pattern for your question title: [QUESTION] Your question title here -->
+
 ### Question
 
 <!-- Your question context here -->

data/.reek.yml

@@ -13,6 +13,7 @@ detectors:
       - Truemail::Validate::Smtp#run
       - Truemail::Validate::Mx#hosts_from_cname_records
       - Truemail::Configuration#logger=
+      - Truemail::Validate::Smtp::Request#initialize
 
   TooManyInstanceVariables:
     exclude:
@@ -27,6 +28,7 @@ detectors:
     exclude:
       - Truemail::Configuration#whitelist_validation
       - Truemail::Configuration#not_rfc_mx_lookup_flow
+      - Truemail::Configuration#smtp_fail_fast
       - Truemail::Configuration#smtp_safe_check
       - Truemail::Wrapper#attempts
 
@@ -41,6 +43,7 @@ detectors:
       - Truemail::Configuration#domain_matcher
       - Truemail::Configuration#logger_options
       - Truemail::Log::Serializer::Base#errors
+      - Truemail::Log::Serializer::ValidatorBase#replace_invalid_chars
 
   ControlParameter:
     exclude:

data/.rubocop.yml

@@ -136,6 +136,15 @@ Style/NilLambda:
 Style/SwapValues:
   Enabled: true
 
+Style/RedundantArgument:
+  Enabled: true
+
+Style/HashExcept:
+  Enabled: true
+
+Style/EndlessMethod:
+  Enabled: true
+
 Layout/LineLength:
   Max: 140
 
@@ -167,6 +176,9 @@ Layout/EmptyLinesAroundAttributeAccessor:
 Layout/BeginEndAlignment:
   Enabled: true
 
+Layout/SpaceBeforeBrackets:
+  Enabled: true
+
 Lint/NonDeterministicRequireOrder:
   Enabled: false
 
@@ -260,6 +272,21 @@ Lint/ToEnumArguments:
 Lint/UnmodifiedReduceAccumulator:
   Enabled: true
 
+Lint/UnexpectedBlockArity:
+  Enabled: true
+
+Lint/AmbiguousAssignment:
+  Enabled: true
+
+Lint/DeprecatedConstants:
+  Enabled: true
+
+Lint/LambdaWithoutLiteralBlock:
+  Enabled: true
+
+Lint/RedundantDirGlobSort:
+  Enabled: true
+
 Performance/AncestorsInclude:
   Enabled: true
 
@@ -287,6 +314,18 @@ Performance/StringInclude:
 Performance/Sum:
   Enabled: true
 
+Performance/BlockGivenWithExplicitBlock:
+  Enabled: true
+
+Performance/CollectionLiteralInLoop:
+  Enabled: true
+
+Performance/ConstantRegexp:
+  Enabled: true
+
+Performance/MethodObjectAsBlock:
+  Enabled: true
+
 RSpec/ExampleLength:
   Enabled: false
 

data/CHANGELOG.md

@@ -2,6 +2,76 @@
 
 The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/), and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
 
+## [2.2.3] - 2020.01.12
+
+### Fixed
+
+Removed needless `Timeout.timeout` block in `Truemail::Validate::Smtp::Request#check_port`, replaced `TCPSocket` to `Socket` with native timeout detection. Thanks to [@wikiti](https://github.com/wikiti) for idea, testing on production and clean PR [#127](https://github.com/truemail-rb/truemail/pull/127).
+
+### Changed
+
+- Updated `Truemail::Validate::Smtp::Request`
+- Updated gem development dependencies
+- Updated rubocop, reek configs
+
+## [2.2.2] - 2020.12.30
+
+### Changed
+
+- Updated gem development dependencies
+- Updated rubocop config
+
+## [2.2.1] - 2020.12.06
+
+### Fixed
+
+- Filter out ASCII-8BIT chars for serialized SMTP response errors. Fixed `Encoding::UndefinedConversionError` in `Truemail::Log::Serializer::ValidatorJson#serialize`. Thanks to [@eni9889](https://github.com/eni9889) for report
+- Added missed `smtp_fail_fast` attribute to serialized validator and auditor results
+
+### Added
+
+- Added `Truemail::Log::Serializer::ValidatorBase#replace_invalid_chars`
+
+### Changed
+
+- Updated `Truemail::Log::Serializer::Base`
+- Updated `Truemail::Log::Serializer::ValidatorBase`
+- Updated gem development dependencies
+
+## [2.2.0] - 2020.12.01
+
+Ability to use fail fast behaviour for SMTP validation layer. When `smtp_fail_fast = true` it means that `truemail` ends smtp validation session after first attempt on the first mx server in any fail cases (network connection/timeout error, smtp validation error). This feature helps to reduce total time of SMTP validation session up to 1 second.
+
+### Added
+
+- Added `Truemail::Configuration#smtp_fail_fast`
+- Added `Truemail::Validate::Smtp#smtp_fail_fast?`
+- Added `Truemail::Validate::Smtp#filtered_mail_servers_by_fail_fast_scenario`
+
+### Changed
+
+- Updated `Truemail::Validate::Smtp#attempts`
+- Updated `Truemail::Validate::Smtp#establish_smtp_connection`
+- Updated gem documentation
+
+It's a configurable and not required option:
+
+```ruby
+Truemail.configure do |config|
+  config.smtp_fail_fast = true # by default it's equal to false
+end
+```
+
+Thanks to [@wikiti](https://github.com/wikiti) for timeout reports.
+
+## [2.1.0] - 2020.11.21
+
+Collecting only unique ip-addresses for target mail servers. This update reduces email validation time for case when remote server have closed connection via avoiding connection attempt to server with the same ip address.
+
+### Changed
+
+- Updated `Truemail::Validate::Mx#fetch_target_hosts`
+
 ## [2.0.2] - 2020.11.14
 
 ### Fixed

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    truemail (2.0.2)
+    truemail (2.2.3)
       simpleidn (~> 0.1.1)
 
 GEM
@@ -15,14 +15,18 @@ GEM
     childprocess (4.0.0)
     coderay (1.1.3)
     colorize (0.8.1)
+    concurrent-ruby (1.1.7)
     diff-lcs (1.4.4)
-    docile (1.3.2)
+    docile (1.3.4)
+    faker (2.15.1)
+      i18n (>= 1.6, < 2)
     fasterer (0.8.3)
       colorize (~> 0.7)
       ruby_parser (>= 3.14.1)
-    ffaker (2.17.0)
+    i18n (1.8.7)
+      concurrent-ruby (~> 1.0)
     iniparse (1.5.0)
-    json (2.3.1)
+    json (2.5.1)
     json_matchers (0.11.1)
       json_schema
     json_schema (0.20.9)
@@ -31,8 +35,8 @@ GEM
     overcommit (0.57.0)
       childprocess (>= 0.6.3, < 5)
       iniparse (~> 1.4)
-    parallel (1.20.0)
-    parser (2.7.2.0)
+    parallel (1.20.1)
+    parser (3.0.0.0)
       ast (~> 2.4.1)
     pry (0.13.1)
       coderay (~> 1.1)
@@ -40,50 +44,50 @@ GEM
     pry-byebug (3.9.0)
       byebug (~> 11.0)
       pry (~> 0.13.0)
-    psych (3.2.0)
+    psych (3.3.0)
     rainbow (3.0.0)
-    rake (13.0.1)
-    reek (6.0.2)
+    rake (13.0.3)
+    reek (6.0.3)
       kwalify (~> 0.7.0)
-      parser (>= 2.5.0.0, < 2.8, != 2.5.1.1)
+      parser (~> 3.0.0)
       psych (~> 3.1)
       rainbow (>= 2.0, < 4.0)
-    regexp_parser (1.8.2)
+    regexp_parser (2.0.3)
     rexml (3.2.4)
     rspec (3.10.0)
       rspec-core (~> 3.10.0)
       rspec-expectations (~> 3.10.0)
       rspec-mocks (~> 3.10.0)
-    rspec-core (3.10.0)
+    rspec-core (3.10.1)
       rspec-support (~> 3.10.0)
-    rspec-expectations (3.10.0)
+    rspec-expectations (3.10.1)
       diff-lcs (>= 1.2.0, < 2.0)
       rspec-support (~> 3.10.0)
-    rspec-mocks (3.10.0)
+    rspec-mocks (3.10.1)
       diff-lcs (>= 1.2.0, < 2.0)
       rspec-support (~> 3.10.0)
-    rspec-support (3.10.0)
-    rubocop (1.3.0)
+    rspec-support (3.10.1)
+    rubocop (1.8.1)
       parallel (~> 1.10)
-      parser (>= 2.7.1.5)
+      parser (>= 3.0.0.0)
       rainbow (>= 2.2.2, < 4.0)
-      regexp_parser (>= 1.8)
+      regexp_parser (>= 1.8, < 3.0)
       rexml
-      rubocop-ast (>= 1.1.1)
+      rubocop-ast (>= 1.2.0, < 2.0)
       ruby-progressbar (~> 1.7)
-      unicode-display_width (>= 1.4.0, < 2.0)
-    rubocop-ast (1.1.1)
+      unicode-display_width (>= 1.4.0, < 3.0)
+    rubocop-ast (1.4.0)
       parser (>= 2.7.1.5)
-    rubocop-performance (1.8.1)
-      rubocop (>= 0.87.0)
+    rubocop-performance (1.9.2)
+      rubocop (>= 0.90.0, < 2.0)
       rubocop-ast (>= 0.4.0)
-    rubocop-rspec (2.0.0)
+    rubocop-rspec (2.1.0)
       rubocop (~> 1.0)
       rubocop-ast (>= 1.1.0)
-    ruby-progressbar (1.10.1)
-    ruby_parser (3.15.0)
+    ruby-progressbar (1.11.0)
+    ruby_parser (3.15.1)
       sexp_processor (~> 4.9)
-    sexp_processor (4.15.1)
+    sexp_processor (4.15.2)
     simplecov (0.17.1)
       docile (~> 1.1)
       json (>= 1.8, < 3)
@@ -92,13 +96,14 @@ GEM
     simpleidn (0.1.1)
       unf (~> 0.1.4)
     thor (1.0.1)
-    truemail-rspec (0.2.1)
-      rspec (~> 3.9)
-      truemail (~> 1.4, >= 1.4.1)
+    truemail-rspec (0.3.3)
+      faker (~> 2.15, >= 2.15.1)
+      rspec (~> 3.10)
+      truemail (~> 2.2)
     unf (0.1.4)
       unf_ext
     unf_ext (0.0.7.7)
-    unicode-display_width (1.7.0)
+    unicode-display_width (2.0.0)
 
 PLATFORMS
   ruby
@@ -106,20 +111,20 @@ PLATFORMS
 DEPENDENCIES
   bundler (~> 1.16)
   bundler-audit (~> 0.7.0.1)
+  faker (~> 2.15, >= 2.15.1)
   fasterer (~> 0.8.3)
-  ffaker (~> 2.17)
   json_matchers (~> 0.11.1)
   overcommit (~> 0.57.0)
   pry-byebug (~> 3.9)
-  rake (~> 13.0, >= 13.0.1)
-  reek (~> 6.0, >= 6.0.2)
+  rake (~> 13.0, >= 13.0.3)
+  reek (~> 6.0, >= 6.0.3)
   rspec (~> 3.10)
-  rubocop (~> 1.3)
-  rubocop-performance (~> 1.8, >= 1.8.1)
-  rubocop-rspec (~> 2.0)
+  rubocop (~> 1.8, >= 1.8.1)
+  rubocop-performance (~> 1.9, >= 1.9.2)
+  rubocop-rspec (~> 2.1)
   simplecov (~> 0.17.1)
   truemail!
-  truemail-rspec (~> 0.2.1)
+  truemail-rspec (~> 0.3.3)
 
 BUNDLED WITH
    1.16.6

data/README.md

@@ -40,6 +40,7 @@ Configurable framework agnostic plain Ruby email validator. Verify email via Reg
       - [RFC MX lookup flow](#rfc-mx-lookup-flow)
       - [Not RFC MX lookup flow](#not-rfc-mx-lookup-flow)
     - [SMTP validation](#smtp-validation)
+      - [SMTP fail fast enabled](#smtp-fail-fast-enabled)
       - [SMTP safe check disabled](#smtp-safe-check-disabled)
       - [SMTP safe check enabled](#smtp-safe-check-enabled)
   - [Host audit features](#host-audit-features)
@@ -82,10 +83,12 @@ Also Truemail gem allows performing an audit of the host in which runs.
 - Minimal runtime dependencies
 - Supporting of internationalized emails ([EAI](https://en.wikipedia.org/wiki/Email_address#Internationalization))
 - Whitelist/blacklist validation layers
+- Ability to configure different MX/SMTP validation flows
 - Simple SMTP debugger
 - Event logger
 - Host auditor tools (helps to detect common host problems interfering to proper email verification)
 - JSON serializers
+- Ability to use the library as independent stateless microservice ([Truemail Server](https://truemail-rb.org/truemail-rack))
 
 ## Requirements
 
@@ -129,6 +132,8 @@ You can use global gem configuration or custom independent configuration. Availa
 - whitelisted domains
 - whitelist validation
 - blacklisted domains
+- RFC MX lookup flow
+- SMTP fail fast
 - SMTP safe check
 - event logger
 - JSON serializer
@@ -201,6 +206,13 @@ Truemail.configure do |config|
   # By default this option is disabled.
   config.not_rfc_mx_lookup_flow = true
 
+  # Optional parameter. This option will provide to use smtp fail fast behaviour. When
+  # smtp_fail_fast = true it means that truemail ends smtp validation session after first
+  # attempt on the first mx server in any fail cases (network connection/timeout error,
+  # smtp validation error). This feature helps to reduce total time of SMTP validation
+  # session up to 1 second. By default this option is disabled.
+  config.smtp_fail_fast = true
+
   # Optional parameter. This option will be parse bodies of SMTP errors. It will be helpful
   # if SMTP server does not return an exact answer that the email does not exist
   # By default this option is disabled, available for SMTP validation only.
@@ -233,6 +245,7 @@ Truemail.configuration
  @verifier_domain="somedomain.com",
  @verifier_email="verifier@example.com",
  @not_rfc_mx_lookup_flow=true,
+ @smtp_fail_fast=true,
  @smtp_safe_check=true,
  @logger=#<Truemail::Logger:0x0000557f837450b0
    @event=:all, @file="/home/app/log/truemail.log", @stdout=true>>
@@ -262,6 +275,7 @@ Truemail.configuration
  @verifier_domain="somedomain.com",
  @verifier_email="verifier@example.com",
  @not_rfc_mx_lookup_flow=true,
+ @smtp_fail_fast=true,
  @smtp_safe_check=true,
  @logger=#<Truemail::Logger:0x0000557f837450b0
    @event=:all, @file="/home/app/log/truemail.log", @stdout=true>>
@@ -294,7 +308,6 @@ Truemail.host_audit('email@example.com', custom_configuration: custom_configurat
 
 Please note, you should have global or custom configuration for use Truemail gem.
 
-
 ### Validation features
 
 #### Whitelist/Blacklist check
@@ -346,6 +359,7 @@ Truemail.validate('email@white-domain.com')
      @response_timeout=2,
      @smtp_error_body_pattern=/(?=.*550)(?=.*(user|account|customer|mailbox)).*/i,
      @not_rfc_mx_lookup_flow=false,
+     @smtp_fail_fast=false,
      @smtp_safe_check=false,
      @validation_type_by_domain={"somedomain.com"=>:mx},
      @verifier_domain="example.com",
@@ -392,6 +406,7 @@ Truemail.validate('email@white-domain.com', with: :regex)
      @response_timeout=2,
      @smtp_error_body_pattern=/(?=.*550)(?=.*(user|account|customer|mailbox)).*/i,
      @not_rfc_mx_lookup_flow=false,
+     @smtp_fail_fast=false,
      @smtp_safe_check=false,
      @validation_type_by_domain={},
      @verifier_domain="example.com",
@@ -424,6 +439,7 @@ Truemail.validate('email@domain.com', with: :regex)
      @response_timeout=2,
      @smtp_error_body_pattern=/(?=.*550)(?=.*(user|account|customer|mailbox)).*/i,
      @not_rfc_mx_lookup_flow=false,
+     @smtp_fail_fast=false,
      @smtp_safe_check=false,
      @validation_type_by_domain={},
      @verifier_domain="example.com",
@@ -458,6 +474,7 @@ Truemail.validate('email@black-domain.com')
      @response_timeout=2,
      @smtp_error_body_pattern=/(?=.*550)(?=.*(user|account|customer|mailbox)).*/i,
      @not_rfc_mx_lookup_flow=false,
+     @smtp_fail_fast=false,
      @smtp_safe_check=false,
      @validation_type_by_domain={},
      @verifier_domain="example.com",
@@ -492,6 +509,7 @@ Truemail.validate('email@somedomain.com')
      @response_timeout=2,
      @smtp_error_body_pattern=/(?=.*550)(?=.*(user|account|customer|mailbox)).*/i,
      @not_rfc_mx_lookup_flow=false,
+     @smtp_fail_fast=false,
      @smtp_safe_check=false,
      @validation_type_by_domain={},
      @verifier_domain="example.com",
@@ -542,6 +560,7 @@ Truemail.validate('email@example.com', with: :regex)
        @response_timeout=2,
        @smtp_error_body_pattern=/(?=.*550)(?=.*(user|account|customer|mailbox)).*/i,
        @not_rfc_mx_lookup_flow=false,
+       @smtp_fail_fast=false,
        @smtp_safe_check=false,
        @validation_type_by_domain={},
        @verifier_domain="example.com",
@@ -584,6 +603,7 @@ Truemail.validate('email@example.com', with: :regex)
        @response_timeout=2,
        @smtp_error_body_pattern=/(?=.*550)(?=.*(user|account|customer|mailbox)).*/i,
        @not_rfc_mx_lookup_flow=false,
+       @smtp_fail_fast=false,
        @smtp_safe_check=false,
        @validation_type_by_domain={},
        @verifier_domain="example.com",
@@ -637,6 +657,7 @@ Truemail.validate('email@example.com', with: :mx)
        @response_timeout=2,
        @smtp_error_body_pattern=/(?=.*550)(?=.*(user|account|customer|mailbox)).*/i,
        @not_rfc_mx_lookup_flow=false,
+       @smtp_fail_fast=false,
        @smtp_safe_check=false,
        @validation_type_by_domain={},
        @verifier_domain="example.com",
@@ -681,6 +702,7 @@ Truemail.validate('email@example.com', with: :mx)
        @response_timeout=2,
        @smtp_error_body_pattern=/(?=.*550)(?=.*(user|account|customer|mailbox)).*/i,
        @not_rfc_mx_lookup_flow=true,
+       @smtp_fail_fast=false,
        @smtp_safe_check=false,
        @validation_type_by_domain={},
        @verifier_domain="example.com",
@@ -702,6 +724,68 @@ If total count of MX servers is equal to one, `Truemail::Smtp` validator will us
 
 By default, you don't need pass with-parameter to use it. Example of usage is specified below:
 
+##### SMTP fail fast enabled
+
+Truemail can use fail fast behaviour for SMTP validation layer. When `smtp_fail_fast = true` it means that `truemail` ends smtp validation session after first attempt on the first mx server in any fail cases (network connection/timeout error, smtp validation error). This feature helps to reduce total time of SMTP validation session up to 1 second.
+
+```ruby
+require 'truemail'
+
+Truemail.configure do |config|
+  config.verifier_email = 'verifier@example.com'
+  config.smtp_fail_fast = true
+end
+
+Truemail.validate('email@example.com')
+
+# SMTP validation failed, smtp fail fast validation scenario
+=> #<Truemail::Validator:0x00007fdc4504f460
+    @result=
+      #<struct Truemail::Validator::Result
+        success=false,
+        email="email@example.com",
+        domain="example.com",
+        mail_servers=["127.0.1.1", "127.0.1.2", "127.0.1.3"], # there are 3 mail servers in a row
+        errors={:smtp=>"smtp error"},
+        smtp_debug=
+          [#<Truemail::Validate::Smtp::Request:0x00007fdc43150b90 # but iteration has been stopped after the first failure
+            @attempts=nil,
+            @configuration=
+              #<Truemail::Validate::Smtp::Request::Configuration:0x00007fdc43150b18
+                @connection_timeout=2,
+                @response_timeout=2,
+                @verifier_domain="example.com",
+                @verifier_email="verifier@example.com">,
+            @email="email@example.com",
+            @host="127.0.1.1",
+            @response=
+              #<struct Truemail::Validate::Smtp::Response
+                port_opened=false,
+                connection=nil,
+                helo=nil,
+                mailfrom=nil,
+                rcptto=nil,
+                errors={}>>],
+        configuration=
+          #<Truemail::Configuration:0x00007fdc4504f5c8
+            @blacklisted_domains=[],
+            @connection_attempts=2,
+            @connection_timeout=2,
+            @default_validation_type=:smtp,
+            @email_pattern=/(?=\A.{6,255}\z)(\A([\p{L}0-9]+[\w|\-.+]*)@((?i-mx:[\p{L}0-9]+([\-.]{1}[\p{L}0-9]+)*\.\p{L}{2,63}))\z)/,
+            @not_rfc_mx_lookup_flow=false,
+            @response_timeout=2,
+            @smtp_error_body_pattern=/(?=.*550)(?=.*(user|account|customer|mailbox)).*/i,
+            @smtp_fail_fast=true,
+            @smtp_safe_check=false,
+            @validation_type_by_domain={},
+            @verifier_domain="example.com",
+            @verifier_email="verifier@example.com",
+            @whitelist_validation=false,
+            @whitelisted_domains=[]>>,
+      @validation_type=:smtp>
+```
+
 ##### SMTP safe check disabled
 
 With `smtp_safe_check = false`
@@ -735,6 +819,7 @@ Truemail.validate('email@example.com')
        @response_timeout=2,
        @smtp_error_body_pattern=/(?=.*550)(?=.*(user|account|customer|mailbox)).*/i,
        @not_rfc_mx_lookup_flow=false,
+       @smtp_fail_fast=false,
        @smtp_safe_check=false,
        @validation_type_by_domain={},
        @verifier_domain="example.com",
@@ -784,6 +869,7 @@ Truemail.validate('email@example.com')
              @response_timeout=2,
              @smtp_error_body_pattern=/(?=.*550)(?=.*(user|account|customer|mailbox)).*/i,
              @not_rfc_mx_lookup_flow=false,
+             @smtp_fail_fast=false,
              @smtp_safe_check=false,
              @validation_type_by_domain={},
              @verifier_domain="example.com",
@@ -845,6 +931,7 @@ Truemail.validate('email@example.com')
              @response_timeout=2,
              @smtp_error_body_pattern=/(?=.*550)(?=.*(user|account|customer|mailbox)).*/i,
              @not_rfc_mx_lookup_flow=false,
+             @smtp_fail_fast=false,
              @smtp_safe_check=false,
              @validation_type_by_domain={},
              @verifier_domain="example.com",
@@ -891,6 +978,7 @@ Truemail.validate('email@example.com')
              @response_timeout=2,
              @smtp_error_body_pattern=/(?=.*550)(?=.*(user|account|customer|mailbox)).*/i,
              @not_rfc_mx_lookup_flow=false,
+             @smtp_fail_fast=false,
              @smtp_safe_check=false,
              @validation_type_by_domain={},
              @verifier_domain="example.com",
@@ -938,6 +1026,7 @@ Truemail.host_audit
          @response_timeout=2,
          @smtp_error_body_pattern=/(?=.*550)(?=.*(user|account|customer|mailbox)).*/i,
          @not_rfc_mx_lookup_flow=false,
+         @smtp_fail_fast=false,
          @smtp_safe_check=false,
          @validation_type_by_domain={},
          @verifier_domain="example.com",
@@ -964,6 +1053,7 @@ Truemail.host_audit
          @response_timeout=2,
          @smtp_error_body_pattern=/(?=.*550)(?=.*(user|account|customer|mailbox)).*/i,
          @not_rfc_mx_lookup_flow=false,
+         @smtp_fail_fast=false,
          @smtp_safe_check=false,
          @validation_type_by_domain={},
          @verifier_domain="example.com",
@@ -1012,6 +1102,7 @@ Truemail::Log::Serializer::AuditorJson.call(Truemail.host_audit)
     "whitelisted_domains": null,
     "blacklisted_domains": null,
     "not_rfc_mx_lookup_flow": false,
+    "smtp_fail_fast": false,
     "smtp_safe_check": false,
     "email_pattern": "default gem value",
     "smtp_error_body_pattern": "default gem value"
@@ -1050,6 +1141,7 @@ Truemail::Log::Serializer::ValidatorJson.call(Truemail.validate('nonexistent_ema
     "whitelisted_domains": null,
     "blacklisted_domains": null,
     "not_rfc_mx_lookup_flow": false,
+    "smtp_fail_fast": false,
     "smtp_safe_check": false,
     "email_pattern": "default gem value",
     "smtp_error_body_pattern": "default gem value"
@@ -1090,6 +1182,7 @@ Truemail.host_audit.as_json
     "whitelisted_domains": null,
     "blacklisted_domains": null,
     "not_rfc_mx_lookup_flow": false,
+    "smtp_fail_fast": false,
     "smtp_safe_check": false,
     "email_pattern": "default gem value",
     "smtp_error_body_pattern": "default gem value"
@@ -1125,6 +1218,7 @@ Truemail.validate('nonexistent_email@bestweb.com.ua').as_json
     "whitelisted_domains": null,
     "blacklisted_domains": null,
     "not_rfc_mx_lookup_flow": false,
+    "smtp_fail_fast": false,
     "smtp_safe_check": false,
     "email_pattern": "default gem value",
     "smtp_error_body_pattern": "default gem value"

data/lib/truemail.rb

@@ -10,7 +10,7 @@ module Truemail
   class << self
     def configuration(&block)
       @configuration ||= begin
-        return unless block_given?
+        return unless block
         configuration = Truemail::Configuration.new(&block)
         raise_unless(configuration.complete?, Truemail::INCOMPLETE_CONFIG)
         configuration

data/lib/truemail/configuration.rb

@@ -21,13 +21,13 @@ module Truemail
                 :blacklisted_domains,
                 :logger
 
-    attr_accessor :whitelist_validation, :not_rfc_mx_lookup_flow, :smtp_safe_check
+    attr_accessor :whitelist_validation, :not_rfc_mx_lookup_flow, :smtp_fail_fast, :smtp_safe_check
 
     def initialize(&block)
       instance_initializer.each do |instace_variable, value|
         instance_variable_set(:"@#{instace_variable}", value)
       end
-      tap(&block) if block_given?
+      tap(&block) if block
     end
 
     %i[email_pattern smtp_error_body_pattern].each do |method|
@@ -102,6 +102,7 @@ module Truemail
         whitelist_validation: false,
         blacklisted_domains: [],
         not_rfc_mx_lookup_flow: false,
+        smtp_fail_fast: false,
         smtp_safe_check: false
       }
     end

data/lib/truemail/log/serializer/base.rb

@@ -56,6 +56,7 @@ module Truemail
             whitelisted_domains: whitelisted_domains,
             blacklisted_domains: blacklisted_domains,
             not_rfc_mx_lookup_flow: executor_configuration.not_rfc_mx_lookup_flow,
+            smtp_fail_fast: executor_configuration.smtp_fail_fast,
             smtp_safe_check: executor_configuration.smtp_safe_check,
             email_pattern: email_pattern,
             smtp_error_body_pattern: smtp_error_body_pattern

data/lib/truemail/log/serializer/validator_base.rb

@@ -13,6 +13,10 @@ module Truemail
 
         attr_reader :validation_type
 
+        def replace_invalid_chars
+          ->(value) { value.encode('UTF-8', invalid: :replace) }
+        end
+
         def smtp_debug
           validation_smtp_debug = executor_result.smtp_debug
           return unless validation_smtp_debug
@@ -22,7 +26,7 @@ module Truemail
               mail_host: smtp_request.host,
               port_opened: smtp_response.port_opened,
               connection: smtp_response.connection,
-              errors: smtp_response.errors
+              errors: smtp_response.errors.transform_values(&replace_invalid_chars)
             }
           end
         end

data/lib/truemail/validate/mx.rb

@@ -30,7 +30,7 @@ module Truemail
       end
 
       def fetch_target_hosts(hosts)
-        mail_servers.push(*hosts)
+        mail_servers.push(*(hosts.uniq - mail_servers))
       end
 
       def null_mx?(domain_mx_records)

data/lib/truemail/validate/smtp.rb

@@ -24,13 +24,23 @@ module Truemail
 
       private
 
-      def request
-        smtp_results.last
+      def fail_fast?
+        configuration.smtp_fail_fast
+      end
+
+      def filtered_mail_servers_by_fail_fast_scenario
+        fail_fast? ? mail_servers.first(1) : mail_servers
       end
 
       def attempts
-        @attempts ||=
-          mail_servers.one? ? { attempts: configuration.connection_attempts } : {}
+        @attempts ||= begin
+          return {} if fail_fast? || !mail_servers.one?
+          { attempts: configuration.connection_attempts }
+        end
+      end
+
+      def request
+        smtp_results.last
       end
 
       def rcptto_error
@@ -38,7 +48,7 @@ module Truemail
       end
 
       def establish_smtp_connection
-        mail_servers.each do |mail_server|
+        filtered_mail_servers_by_fail_fast_scenario.each do |mail_server|
           smtp_results << Truemail::Validate::Smtp::Request.new(
             configuration: configuration, host: mail_server, email: result.punycode_email, **attempts
           )

data/lib/truemail/validate/smtp/request.rb

@@ -13,20 +13,24 @@ module Truemail
 
         attr_reader :configuration, :host, :email, :response
 
-        def initialize(configuration:, host:, email:, attempts: nil)
+        def initialize(configuration:, host:, email:, attempts: nil, port_open_status: proc { true })
           @configuration = Truemail::Validate::Smtp::Request::Configuration.new(configuration)
           @response = Truemail::Validate::Smtp::Response.new
           @host = host
           @email = email
           @attempts = attempts
+          @port_open_status = port_open_status
         end
 
         def check_port
-          Timeout.timeout(configuration.connection_timeout) do
-            return response.port_opened = !TCPSocket.new(host, Truemail::Validate::Smtp::Request::SMTP_PORT).close
-          end
+          response.port_opened = Socket.tcp(
+            host,
+            Truemail::Validate::Smtp::Request::SMTP_PORT,
+            connect_timeout: configuration.connection_timeout,
+            &port_open_status
+          )
         rescue => error
-          retry if attempts_exist? && error.is_a?(Timeout::Error)
+          retry if attempts_exist? && error.is_a?(Errno::ETIMEDOUT)
           response.port_opened = false
         end
 
@@ -53,7 +57,7 @@ module Truemail
           end
         end
 
-        attr_reader :attempts
+        attr_reader :attempts, :port_open_status
 
         def attempts_exist?
           return false unless attempts

data/lib/truemail/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Truemail
-  VERSION = '2.0.2'
+  VERSION = '2.2.3'
 end

data/truemail.gemspec

@@ -35,17 +35,17 @@ Gem::Specification.new do |spec|
 
   spec.add_development_dependency 'bundler', '~> 1.16'
   spec.add_development_dependency 'bundler-audit', '~> 0.7.0.1'
+  spec.add_development_dependency 'faker', '~> 2.15', '>= 2.15.1'
   spec.add_development_dependency 'fasterer', '~> 0.8.3'
-  spec.add_development_dependency 'ffaker', '~> 2.17'
   spec.add_development_dependency 'json_matchers', '~> 0.11.1'
   spec.add_development_dependency 'overcommit', '~> 0.57.0'
   spec.add_development_dependency 'pry-byebug', '~> 3.9'
-  spec.add_development_dependency 'rake', '~> 13.0', '>= 13.0.1'
-  spec.add_development_dependency 'reek', '~> 6.0', '>= 6.0.2'
+  spec.add_development_dependency 'rake', '~> 13.0', '>= 13.0.3'
+  spec.add_development_dependency 'reek', '~> 6.0', '>= 6.0.3'
   spec.add_development_dependency 'rspec', '~> 3.10'
-  spec.add_development_dependency 'rubocop', '~> 1.3'
-  spec.add_development_dependency 'rubocop-performance', '~> 1.8', '>= 1.8.1'
-  spec.add_development_dependency 'rubocop-rspec', '~> 2.0'
+  spec.add_development_dependency 'rubocop', '~> 1.8', '>= 1.8.1'
+  spec.add_development_dependency 'rubocop-performance', '~> 1.9', '>= 1.9.2'
+  spec.add_development_dependency 'rubocop-rspec', '~> 2.1'
   spec.add_development_dependency 'simplecov', '~> 0.17.1'
-  spec.add_development_dependency 'truemail-rspec', '~> 0.2.1'
+  spec.add_development_dependency 'truemail-rspec', '~> 0.3.3'
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: truemail
 version: !ruby/object:Gem::Version
-  version: 2.0.2
+  version: 2.2.3
 platform: ruby
 authors:
 - Vladislav Trotsenko
 autorequire:
 bindir: exe
 cert_chain: []
-date: 2020-11-14 00:00:00.000000000 Z
+date: 2021-01-12 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: simpleidn
@@ -53,33 +53,39 @@ dependencies:
       - !ruby/object:Gem::Version
         version: 0.7.0.1
 - !ruby/object:Gem::Dependency
-  name: fasterer
+  name: faker
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.8.3
+        version: '2.15'
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: 2.15.1
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.8.3
+        version: '2.15'
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: 2.15.1
 - !ruby/object:Gem::Dependency
-  name: ffaker
+  name: fasterer
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '2.17'
+        version: 0.8.3
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '2.17'
+        version: 0.8.3
 - !ruby/object:Gem::Dependency
   name: json_matchers
   requirement: !ruby/object:Gem::Requirement
@@ -131,7 +137,7 @@ dependencies:
         version: '13.0'
     - - ">="
       - !ruby/object:Gem::Version
-        version: 13.0.1
+        version: 13.0.3
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
@@ -141,7 +147,7 @@ dependencies:
         version: '13.0'
     - - ">="
       - !ruby/object:Gem::Version
-        version: 13.0.1
+        version: 13.0.3
 - !ruby/object:Gem::Dependency
   name: reek
   requirement: !ruby/object:Gem::Requirement
@@ -151,7 +157,7 @@ dependencies:
         version: '6.0'
     - - ">="
       - !ruby/object:Gem::Version
-        version: 6.0.2
+        version: 6.0.3
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
@@ -161,7 +167,7 @@ dependencies:
         version: '6.0'
     - - ">="
       - !ruby/object:Gem::Version
-        version: 6.0.2
+        version: 6.0.3
 - !ruby/object:Gem::Dependency
   name: rspec
   requirement: !ruby/object:Gem::Requirement
@@ -182,48 +188,54 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.3'
+        version: '1.8'
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: 1.8.1
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.3'
+        version: '1.8'
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: 1.8.1
 - !ruby/object:Gem::Dependency
   name: rubocop-performance
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.8'
+        version: '1.9'
     - - ">="
       - !ruby/object:Gem::Version
-        version: 1.8.1
+        version: 1.9.2
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.8'
+        version: '1.9'
     - - ">="
       - !ruby/object:Gem::Version
-        version: 1.8.1
+        version: 1.9.2
 - !ruby/object:Gem::Dependency
   name: rubocop-rspec
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '2.0'
+        version: '2.1'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '2.0'
+        version: '2.1'
 - !ruby/object:Gem::Dependency
   name: simplecov
   requirement: !ruby/object:Gem::Requirement
@@ -244,14 +256,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.2.1
+        version: 0.3.3
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.2.1
+        version: 0.3.3
 description: Configurable framework agnostic plain Ruby email validator. Verify email
   via Regex, DNS and SMTP.
 email: