troystribling-agent_xmpp 0.0.0 → 0.0.1

data/test/app/app.rb

@@ -0,0 +1,134 @@
+##########################################################################################################
+require 'rubygems'
+require "#{File.dirname(__FILE__)}/../../lib/agent_xmpp"
+
+##########################################################################################################
+# callbacks
+before_start do 
+  AgentXmpp.logger.level = Logger::DEBUG
+  AgentXmpp.logger.info "before_start"
+end
+
+#.........................................................................................................
+after_connected do |connection|
+  AgentXmpp.logger.info "after_connected"
+end
+
+#.........................................................................................................
+restarting_client do |connection|
+  AgentXmpp.logger.info "restarting_client"
+end
+
+#.........................................................................................................
+discovered_pubsub_node do |service, node|
+  AgentXmpp.logger.info "discovered_pubsub_node: #{service}, #{node}"
+  if node.eql?(AgentXmpp.user_pubsub_root+'/time')
+    AgentXmpp.logger.info "LAUNCHING TIME PUBLISH TASK"
+    EventMachine::PeriodicTimer.new(60) do
+      publish_time(Time.now.to_s)
+      AgentXmpp.logger.info "FIRING EVENT TIME: #{Time.now.to_s}"
+    end  
+  elsif node.eql?(AgentXmpp.user_pubsub_root+'/shot')
+    AgentXmpp.logger.info "LAUNCHING SHOT PUBLISH TASK"
+    EventMachine::Timer.new(30) do
+      publish_shot(Time.now.to_s)
+      AgentXmpp.logger.info "FIRING EVENT SHOT: #{Time.now.to_s}"
+    end  
+  end
+end
+
+#.........................................................................................................
+discovered_command_nodes do |jid, nodes|
+  AgentXmpp.logger.info "discovered_command_nodes"
+  nodes.each do |n|
+    AgentXmpp.logger.info "COMMAND NODE: #{jid}, #{n}"
+    command(:to=>jid, :node=> n) do |status, data|
+      AgentXmpp.logger.info "COMMAND RESPONSE: #{status}, #{data.inspect}"
+    end
+  end
+end
+
+#.........................................................................................................
+received_presence do |from, status|
+  AgentXmpp.logger.info "received_presence: #{from}, #{status}"
+end
+
+##########################################################################################################
+# command processing
+#.........................................................................................................
+execute 'scalar' do
+  AgentXmpp.logger.info "ACTION: scalar"
+  'scalar' 
+end
+
+#.........................................................................................................
+execute 'hash' do
+  AgentXmpp.logger.info "ACTION: hash"
+  {:attr1 => 'val1', :attr2 => 'val2'}
+end
+
+#.........................................................................................................
+execute 'scalar_array' do
+  AgentXmpp.logger.info "ACTION: array"
+  ['val1', 'val2','val3', 'val4'] 
+end
+
+#.........................................................................................................
+execute 'hash_array' do
+  AgentXmpp.logger.info "ACTION: hash_array"
+  {:attr1 => ['val11', 'val11'], :attr2 => 'val12'}
+end
+
+#.........................................................................................................
+execute 'array_hash' do
+  AgentXmpp.logger.info "ACTION: array_hash"
+  [{:attr1 => 'val11', :attr2 => 'val12'}, 
+   {:attr1 => 'val21', :attr2 => 'val22'}, 
+   {:attr1 => 'val31', :attr2 => 'val32'}]
+end
+
+#.........................................................................................................
+execute 'array_hash_array' do
+  AgentXmpp.logger.info "ACTION: hash_array"
+  [{:attr1 => ['val11', 'val11'], :attr2 => 'val12'}, 
+   {:attr1 => ['val21', 'val21'], :attr2 => 'val22'}, 
+   {:attr1 => ['val31', 'val31'], :attr2 => 'val32'}]
+end
+
+#.........................................................................................................
+# respond with a result and another command resquest
+execute 'hash_hello' do
+  AgentXmpp.logger.info "ACTION: hash_hello"
+  command(:to=>params[:from], :node=> 'hello') do |status, data|
+    AgentXmpp.logger.info "COMMAND RESPONSE: #{status}, #{data.inspect}"
+  end
+  {:attr1 => 'val1', :attr2 => 'val2'}
+end
+
+##########################################################################################################
+# chat messages
+chat do
+  AgentXmpp.logger.info "CHAT MESSAGE: #{params[:from]}, #{params[:body]}"
+  params[:body].reverse  
+end
+
+##########################################################################################################
+# pubsub events
+#.........................................................................................................
+# respond with a chat message
+event 'test@planbresearch.com', 'val' do
+  AgentXmpp.logger.info "EVENT: test@planbresearch.com/val"
+  message(:to=>params[:from], :body=>"Got the event at: " + Time.now.to_s)
+end
+
+#.........................................................................................................
+event 'test@planbresearch.com', 'waiting' do
+  AgentXmpp.logger.info "EVENT: test@planbresearch.com/waiting"
+  p params
+end
+
+#.........................................................................................................
+event 'test@plan-b.ath.cx', 'val' do
+  AgentXmpp.logger.info "EVENT: test@plan-b.ath.cx/val"
+  p params
+end

data/test/cases/test_application_message_processing.rb

@@ -0,0 +1,65 @@
+##############################################################################################################
+require 'test_helper'
+
+##############################################################################################################
+class TestApplicationMessageProcessing < Test::Unit::TestCase
+
+  #.........................................................................................................
+  def setup
+    @config = {'jid' => 'test@nowhere.com', 'roster' =>['dev@nowhere.com'], 'password' => 'nopass'}
+    @client = TestClient.new(@config)
+    AgentXmpp::Xmpp::IdGenerator.set_gen_id
+    test_init_roster(@client)
+    @delegate = @client.new_delegate
+  end
+
+  #.........................................................................................................
+  should "respond to a received message with agent version information if no chat route is specified" do
+    @client.receiving(ApplicationMessages.recv_message_chat(@client, 'dev@nowhere.com')).should \
+      respond_with(ApplicationMessages.send_message_chat(@client, 'dev@nowhere.com'))
+  end
+  
+  #.........................................................................................................
+  should "respond to requests with scalars in jabber:x:data format" do
+    @client.receiving(ApplicationMessages.recv_iq_set_command_execute(@client, 'scalar', 'dev@nowhere.com')).should \
+      respond_with(ApplicationMessages.send_iq_result_command_x_data_scalar(@client, 'dev@nowhere.com'))
+  end
+  
+  #.........................................................................................................
+  should "respond to requests with arrays of scalars in jabber:x:data format" do
+    @client.receiving(ApplicationMessages.recv_iq_set_command_execute(@client, 'scalar_array', 'dev@nowhere.com')).should \
+      respond_with(ApplicationMessages.send_iq_result_command_x_data_scalar_array(@client, 'dev@nowhere.com'))
+  end
+  
+  #.........................................................................................................
+  should "respond to requests with hashes in jabber:x:data format" do
+    @client.receiving(ApplicationMessages.recv_iq_set_command_execute(@client, 'hash', 'dev@nowhere.com')).should \
+      respond_with(ApplicationMessages.send_iq_result_command_x_data_hash(@client, 'dev@nowhere.com'))
+  end
+  
+  #.........................................................................................................
+  should "respond to requests with arrays of hashes in jabber:x:data format" do
+    @client.receiving(ApplicationMessages.recv_iq_set_command_execute(@client, 'array_hash', 'dev@nowhere.com')).should \
+      respond_with(ApplicationMessages.send_iq_result_command_x_data_array_hash(@client, 'dev@nowhere.com'))
+  end
+  
+  #.........................................................................................................
+  should "respond to requests with hashes of arrays in jabber:x:data format" do
+    @client.receiving(ApplicationMessages.recv_iq_set_command_execute(@client, 'hash_array', 'dev@nowhere.com')).should \
+      respond_with(ApplicationMessages.send_iq_result_command_x_data_hash_array(@client, 'dev@nowhere.com'))
+  end
+  
+  #.........................................................................................................
+  should "respond to requests with arrays of hashes of arrays in jabber:x:data format" do
+    @client.receiving(ApplicationMessages.recv_iq_set_command_execute(@client, 'array_hash_array', 'dev@nowhere.com')).should \
+      respond_with(ApplicationMessages.send_iq_result_command_x_data_array_hash_array(@client, 'dev@nowhere.com'))
+  end
+   
+  #.........................................................................................................
+  should "return error if command node does not map to a route" do
+    @client.receiving(ApplicationMessages.recv_iq_set_command_execute(@client, 'no_route', 'dev@nowhere.com')).should \
+      respond_with(ApplicationMessages.send_error_command_routing(@client, 'no_route', 'dev@nowhere.com'))
+  end
+  
+end
+

data/test/cases/test_errors.rb

@@ -0,0 +1,24 @@
+##############################################################################################################
+require 'test_helper'
+
+##############################################################################################################
+class TestErrors < Test::Unit::TestCase
+
+  #.........................................................................................................
+  def setup
+    @client = TestClient.new()
+    test_init_roster(@client)
+    @delegate = @client.new_delegate
+    @test = AgentXmpp::Xmpp::Jid.new('test@plan-b.ath.cx/home')
+  end
+  
+  #.........................................................................................................
+  should "respond with feature-not-implemented when unsupported messages are received" do
+    @delegate.did_receive_unsupported_message_method.should_not be_called
+    @client.receiving(ErrorMessages.recv_iq_error(@client, @test.to_s)).should \
+      respond_with(ErrorMessages.send_iq_error(@client, @test.to_s))
+    @delegate.did_receive_unsupported_message_method.should be_called
+  end
+  
+end
+

data/test/cases/test_presence_management.rb

@@ -0,0 +1,139 @@
+##############################################################################################################
+require 'test_helper'
+
+##############################################################################################################
+class TestPresenceManagement < Test::Unit::TestCase
+
+  #.........................................................................................................
+  def setup
+    @config = {'jid' => 'test@nowhere.com', 'roster' =>['dev@nowhere.com', 'troy@nowhere.com'], 'password' => 'nopass'}
+    @client = TestClient.new(@config)
+    test_init_roster(@client)
+    @delegate = @client.new_delegate
+    @home = AgentXmpp::Xmpp::Jid.new('troy@nowhere.com/home')
+    @work = AgentXmpp::Xmpp::Jid.new('troy@nowhere.com/work')
+    @noone = AgentXmpp::Xmpp::Jid.new('noone@nowhere.com/here')
+  end
+    
+  ####------------------------------------------------------------------------------------------------------
+  context "on receipt of first presence message from jid in configured roster" do
+  
+    #.........................................................................................................
+    setup do
+      AgentXmpp::Xmpp::IdGenerator.set_gen_id([1,2])
+      AgentXmpp.roster.resources(@home).should be_empty
+      @delegate.did_receive_presence_method.should_not be_called
+      @client.receiving(PresenceMessages.recv_presence_available(@client, @home.to_s)).should \
+        respond_with(VersionDiscoveryMessages.send_iq_get_query_version(@client, @home.to_s), \
+                     ServiceDiscoveryMessages.send_iq_get_query_discoinfo(@client, @home.to_s))
+      @delegate.did_receive_presence_method.should be_called
+      AgentXmpp.roster.resource(@home).should_not be_nil
+    end
+  
+    #.........................................................................................................
+    should "create presence status entry in roster for resource and send client version request to jid" do
+    end
+      
+    #.........................................................................................................
+    should "update roster item resource presence status to unavailble on receiving unavailable presence" do
+      @delegate = @client.new_delegate
+      @delegate.did_receive_presence_unavailable_method.should_not be_called
+      AgentXmpp.roster.resource(@home).type.should be_nil # nil presence type=available
+      @client.receiving(PresenceMessages.recv_presence_unavailable(@client, @home.to_s)).should not_respond
+      @delegate.did_receive_presence_unavailable_method.should be_called
+      AgentXmpp.roster.resource(@home).type.should be(:unavailable)   
+    end
+     
+    #.........................................................................................................
+    should "update existing roster item resource presence status from unavailble to availble on receiving available presence" do
+      @delegate = @client.new_delegate
+      @client.receiving(PresenceMessages.recv_presence_unavailable(@client, @home.to_s)).should not_respond
+      AgentXmpp::Xmpp::IdGenerator.set_gen_id([1,2])
+      AgentXmpp.roster.resource(@home).type.should be(:unavailable)   
+      @delegate.did_receive_presence_method.should_not be_called
+      @client.receiving(PresenceMessages.recv_presence_available(@client, @home.to_s)).should \
+        respond_with(VersionDiscoveryMessages.send_iq_get_query_version(@client, @home.to_s), \
+                     ServiceDiscoveryMessages.send_iq_get_query_discoinfo(@client, @home.to_s))
+      @delegate.did_receive_presence_method.should be_called
+      AgentXmpp.roster.resource(@home).type.should be_nil # nil presence type=available
+    end
+          
+    #.........................................................................................................
+    should "maintain multiple presence status entries for multiple resources for a roster item" do
+      @delegate = @client.new_delegate
+      AgentXmpp::Xmpp::IdGenerator.set_gen_id([1,2])
+      @delegate.did_receive_presence_method.should_not be_called
+      AgentXmpp.roster.resource(@work).should be_nil
+      @client.receiving(PresenceMessages.recv_presence_available(@client, @work.to_s)).should \
+        respond_with(VersionDiscoveryMessages.send_iq_get_query_version(@client, @work.to_s), \
+                     ServiceDiscoveryMessages.send_iq_get_query_discoinfo(@client, @work.to_s))
+      @delegate.did_receive_presence_method.should be_called
+      AgentXmpp.roster.resource(@work).should_not be_nil  
+      AgentXmpp.roster.resource(@home).should_not be_nil  
+    end
+      
+  end
+     
+  #.........................................................................................................
+  should "create presence status for resource on receipt of self presence" do
+    AgentXmpp.roster.resources(@client.client.jid).should be_empty
+    @delegate.did_receive_presence_method.should_not be_called
+    @client.receiving(PresenceMessages.recv_presence_self(@client)).should not_respond
+    @delegate.did_receive_presence_method.should be_called
+    AgentXmpp.roster.resource(@client.client.jid).should_not be_nil
+  end
+       
+  #.........................................................................................................
+  should "ignore presence messages from jids not in configured roster" do
+    AgentXmpp.roster.has_jid?(@noone).should be(false)
+    @delegate.did_receive_presence_method.should_not be_called
+    @client.receiving(PresenceMessages.recv_presence_available(@client, @noone.to_s)).should not_respond
+    @delegate.did_receive_presence_method.should be_called
+    AgentXmpp.roster.has_jid?(@noone).should be(false)
+  end
+    
+  #.........................................................................................................
+  should "accept subscription requests from jids which are in the configured roster" do
+    AgentXmpp.roster.has_jid?(@home).should be(true)
+    @delegate.did_receive_presence_subscribe_method.should_not be_called
+    @delegate.did_receive_presence_subscribed_method.should_not be_called
+    @client.receiving(PresenceMessages.recv_presence_subscribe(@client, @home.bare.to_s)).should \
+      respond_with(PresenceMessages.send_presence_subscribed(@client, @home.bare.to_s))
+    @client.receiving(PresenceMessages.recv_presence_subscribed(@client, @home.bare.to_s)).should not_respond
+    @delegate.did_receive_presence_subscribe_method.should be_called
+    @delegate.did_receive_presence_subscribed_method.should be_called
+    AgentXmpp.roster.has_jid?(@home).should be(true)
+  end
+  
+  #.........................................................................................................
+  should "remove roster item with jid from configured roster when an unsubscribe resquest is recieved" do
+    AgentXmpp.roster.has_jid?(@home).should be(true)
+    @delegate.did_receive_presence_unsubscribed_method.should_not be_called
+    @client.receiving(PresenceMessages.recv_presence_unsubscribed(@client, @home.bare.to_s)).should \
+      respond_with(RosterMessages.send_iq_set_query_roster_remove(@client, @home.bare.to_s))
+    @client.receiving(RosterMessages.recv_iq_result_query_roster_ack(@client)).should not_respond
+    @delegate.did_receive_presence_unsubscribed_method.should be_called
+    AgentXmpp.roster.has_jid?(@home).should be(false)
+  end
+    
+  #.........................................................................................................
+  should "do nothing when an unsubscribe resquest is recieved from a jid not in the configured roster" do
+    AgentXmpp.roster.has_jid?(@noone).should be(false)
+    @delegate.did_receive_presence_unsubscribed_method.should_not be_called
+    @client.receiving(PresenceMessages.recv_presence_unsubscribed(@client, @noone.bare.to_s)).should not_respond
+    @delegate.did_receive_presence_unsubscribed_method.should be_called
+    AgentXmpp.roster.has_jid?(@noone).should be(false)
+  end
+    
+  #.........................................................................................................
+  should "decline subscription requests from jids which are not in the configured roster" do
+    AgentXmpp.roster.has_jid?(@noone).should be(false)
+    @delegate.did_receive_presence_subscribe_method.should_not be_called
+    @client.receiving(PresenceMessages.recv_presence_subscribe(@client, @noone.bare.to_s)).should \
+      respond_with(PresenceMessages.send_presence_unsubscribed(@client, @noone.bare.to_s))
+    @delegate.did_receive_presence_subscribe_method.should be_called
+    AgentXmpp.roster.has_jid?(@noone).should be(false)
+  end
+  
+end
+

data/test/cases/test_roster_management.rb

@@ -0,0 +1,214 @@
+##############################################################################################################
+require 'test_helper'
+
+##############################################################################################################
+class TestRosterManagement < Test::Unit::TestCase
+
+  #.........................................................................................................
+  def setup
+    @troy = AgentXmpp::Xmpp::Jid.new('troy@nowhere.com')
+    @dev = AgentXmpp::Xmpp::Jid.new('dev@nowhere.com')
+  end
+    
+  #.........................................................................................................
+  def test_receive_roster_item(client)
+    delegate = client.new_delegate
+    delegate.did_receive_roster_item_method.should_not be_called
+    delegate.did_receive_all_roster_items_method.should_not be_called
+    yield client
+    delegate.did_receive_roster_item_method.should be_called
+    delegate.did_receive_all_roster_items_method.should be_called     
+  end
+  
+  ####------------------------------------------------------------------------------------------------------
+  #.........................................................................................................
+  should "query server for roster on succesful session start and activate configured roster items which match those returned in query result" do
+  
+    config = {'jid' => 'test@nowhere.com', 'roster' =>[@dev.bare.to_s, @troy.bare.to_s], 'password' => 'nopass'}
+    client = TestClient.new(config)
+    test_init_roster(client)
+    
+  end
+  
+  #.........................................................................................................
+  should "query server for roster on succesful session start and send a subscription request to configured roster items not returned by query result" do
+  
+    #### client configured with two contacts in roster. 'troy@nowhere.com' will not be returned by roster initial query
+    config = {'jid' => 'test@nowhere.com', 'roster' =>[@dev.bare.to_s, @troy.bare.to_s], 'password' => 'nopass'}
+    client = TestClient.new(config)
+    test_send_roster_request(client)
+    delegate = client.new_delegate
+    
+    #### receive roster request and verify that appropriate roster item is activated and add roster message is sent for 'troy@nowhere.com'
+    test_receive_roster_item(client) do |client|
+      AgentXmpp.roster.find_all{|r| r.status.should be(:inactive)}  
+      client.receiving(RosterMessages.recv_iq_result_query_roster(client, [@dev.bare.to_s])).should \
+        respond_with(RosterMessages.send_iq_set_query_roster(client, @troy.bare.to_s))
+      AgentXmpp.roster.find_by_jid(@dev).status.should be(:both)      
+      AgentXmpp.roster.find_by_jid(@troy).status.should be(:inactive)
+    end
+  
+    ### receive roster add ackgnowledgement and send subscription request
+    delegate = client.new_delegate
+    delegate.did_acknowledge_add_roster_item_method.should_not be_called
+    client.receiving(RosterMessages.recv_iq_result_query_roster_ack(client)).should \
+      respond_with(PresenceMessages.send_presence_subscribe(client, @troy.bare.to_s))
+    delegate.did_acknowledge_add_roster_item_method.should be_called
+  
+    #### receive roster update with subscribe=none for newly added contact
+    test_receive_roster_item(client) do |client|
+      client.receiving(RosterMessages.recv_iq_set_query_roster_none(client, @troy.bare.to_s)).should not_respond
+      AgentXmpp.roster.find_by_jid(@troy).status.should be(:added)      
+    end
+  
+    #### receive roster update with subscription=none and ask=subscribe indicating pending susbscription request for newly added contact
+    test_receive_roster_item(client) do |client|
+      client.receiving(RosterMessages.recv_iq_set_query_roster_none_subscribe(client, @troy.bare.to_s)).should not_respond
+      AgentXmpp.roster.find_by_jid(@troy).status.should be(:ask)      
+    end
+    
+    #### receive roster update with subscription=to indicating that the contact's presence updates will be received 
+    #### (i.e. the contact accepted the invite)
+    test_receive_roster_item(client) do |client|
+      client.receiving(RosterMessages.recv_iq_set_query_roster_to(client, @troy.bare.to_s)).should not_respond
+      AgentXmpp.roster.find_by_jid(@troy).status.should be(:to)
+    end
+    
+    #### receive subscribe request from contact and accept
+    delegate = client.new_delegate
+    delegate.did_receive_presence_subscribe_method.should_not be_called
+    client.receiving(PresenceMessages.recv_presence_subscribe(client, @troy.bare.to_s)).should \
+      respond_with(PresenceMessages.send_presence_subscribed(client, @troy.bare.to_s))
+    delegate.did_receive_presence_subscribe_method.should be_called
+    
+    #### receive roster update with subscription=both indicating that the contact's presence updates will be received and contact 
+    #### will treceive presence updates and activate contact roster item
+    test_receive_roster_item(client) do |client|
+      client.receiving(RosterMessages.recv_iq_set_query_roster_both(client, @troy.bare.to_s)).should not_respond
+      AgentXmpp.roster.find_by_jid(@troy).status.should be(:both)      
+    end
+    
+  end
+  
+  #.........................................................................................................
+  should "query server for roster on succesful session start and send an unsubscribe request to roster items returned by query result that are not in the configuration roster" do
+  
+    #### client configured with one contact in roster. 'troy@nowhere.com' will be returned by roster initial query
+    config = {'jid' => 'test@nowhere.com', 'roster' =>[@dev.bare.to_s], 'password' => 'nopass'}
+    client = TestClient.new(config)
+    test_send_roster_request(client)
+    delegate = client.new_delegate
+    
+    #### receive roster request and verify that appropriate roster item is activated and remove roster message is sent for 'troy@nowhere.com'
+    test_receive_roster_item(client) do |client|
+      AgentXmpp.roster.find_all{|r| r.status.should be(:inactive)}  
+      client.receiving(RosterMessages.recv_iq_result_query_roster(client, [@dev.bare.to_s, @troy.bare.to_s])).should \
+        respond_with(RosterMessages.send_iq_set_query_roster_remove(client, @troy.bare.to_s))
+      AgentXmpp.roster.find_by_jid(@dev).status.should be(:both)      
+    end
+  
+    #### receive roster remove ackgnowledgement
+    delegate = client.new_delegate
+    delegate.did_acknowledge_remove_roster_item_method.should_not be_called
+    client.receiving(RosterMessages.recv_iq_result_query_roster_ack(client)).should not_respond
+    delegate.did_acknowledge_remove_roster_item_method.should be_called
+  
+    #### recieve roster item remove
+    delegate.did_remove_roster_item_method.should_not be_called
+    delegate.did_receive_all_roster_items_method.should_not be_called
+    client.receiving(RosterMessages.recv_iq_set_query_roster_remove(client, @troy.bare.to_s)).should not_respond
+    AgentXmpp.roster.has_jid?(@troy).should be(false) 
+    delegate.did_remove_roster_item_method.should be_called
+    delegate.did_receive_all_roster_items_method.should be_called
+  
+  end
+    
+  #.........................................................................................................
+  should "remove roster item if a roster add message is received for a roster item not in the configuration roster" do
+  
+    config = {'jid' => 'test@nowhere.com', 'roster' =>[@dev.bare.to_s], 'password' => 'nopass'}
+    client = TestClient.new(config)
+    test_init_roster(client)
+  
+    #### receive roster request and verify that appropriate roster item is not configured and send remove roster message to 'troy@nowhere.com'
+    test_receive_roster_item(client) do |client|
+      AgentXmpp.roster.find_all{|r| r.status.should be(:inactive)}  
+      client.receiving(RosterMessages.recv_iq_set_query_roster_none_subscribe(client, [@troy.bare.to_s])).should \
+        respond_with(RosterMessages.send_iq_set_query_roster_remove(client, @troy.bare.to_s))
+      AgentXmpp.roster.has_jid?(@troy).should be(false) 
+    end
+  
+    #### receive roster remove ackgnowledgement
+    delegate = client.new_delegate
+    delegate.did_acknowledge_remove_roster_item_method.should_not be_called
+    client.receiving(RosterMessages.recv_iq_result_query_roster_ack(client)).should not_respond
+    delegate.did_acknowledge_remove_roster_item_method.should be_called
+  
+  end
+    
+  #.........................................................................................................
+  should "query server for roster on succesful session start and throw an exeception if there is an error retrieving roster" do
+  
+    #### client configured with two contacts in roster
+    config = {'jid' => 'test@nowhere.com', 'roster' =>[@dev.bare.to_s], 'password' => 'nopass'}
+    client = TestClient.new(config)
+    test_send_roster_request(client)
+    delegate = client.new_delegate
+  
+    #### receive roster request and verify that roster items are activated
+    lambda{client.receiving(RosterMessages.recv_error_query_roster_add(client))}.should raise_error(AgentXmpp::AgentXmppError) 
+  
+  end
+    
+  #.........................................................................................................
+  should "not respond to errors received in response to a remove roster query" do
+  
+    config = {'jid' => 'test@nowhere.com', 'roster' =>[@dev.bare.to_s], 'password' => 'nopass'}
+    client = TestClient.new(config)
+    test_init_roster(client)
+  
+    #### receive roster request and verify that appropriate roster item is not configured and send remove roster message to 'troy@nowhere.com'
+    test_receive_roster_item(client) do |client|
+      AgentXmpp.roster.find_all{|r| r.status.should be(:inactive)}  
+      client.receiving(RosterMessages.recv_iq_set_query_roster_none_subscribe(client, [@troy.bare.to_s])).should \
+        respond_with(RosterMessages.send_iq_set_query_roster_remove(client, @troy.bare.to_s))
+      AgentXmpp.roster.has_jid?(@troy).should be(false) 
+    end
+  
+    #### receive roster remove ackgnowledgement
+    delegate = client.new_delegate
+    delegate.did_receive_remove_roster_item_error_method.should_not be_called
+    client.receiving(RosterMessages.recv_error_query_roster_remove(client)).should not_respond
+    AgentXmpp.roster.has_jid?(@troy).should be(false) 
+    delegate.did_receive_remove_roster_item_error_method.should be_called
+    
+  end
+  
+  #.........................................................................................................
+  should "not respond to errors received in response to an add roster query but should remove roster item from configured list" do
+  
+    #### client configured with two contacts in roster. 'troy@nowhere.com' will not be returned by roster initial query
+    config = {'jid' => 'test@nowhere.com', 'roster' =>[@dev.bare.to_s, @troy.bare.to_s], 'password' => 'nopass'}
+    client = TestClient.new(config)
+    test_send_roster_request(client)
+    delegate = client.new_delegate
+    
+    #### receive roster request and verify that appropriate roster item is activated and add roster message is sent for 'troy@nowhere.com'
+    test_receive_roster_item(client) do |client|
+      AgentXmpp.roster.find_all{|r| r.status.should be(:inactive)}  
+      client.receiving(RosterMessages.recv_iq_result_query_roster(client, [@dev.bare.to_s])).should \
+        respond_with(RosterMessages.send_iq_set_query_roster(client, @troy.bare.to_s))
+      AgentXmpp.roster.find_by_jid(@dev).status.should be(:both)      
+      AgentXmpp.roster.find_by_jid(@troy).status.should be(:inactive)
+    end
+  
+    ### receive roster add ackgnowledgement and send subscription request
+    delegate = client.new_delegate
+    delegate.did_receive_add_roster_item_error_method.should_not be_called
+    client.receiving(RosterMessages.recv_error_query_roster_remove(client)).should not_respond
+    delegate.did_receive_add_roster_item_error_method.should be_called
+    AgentXmpp.roster.has_jid?(@troy).should be(false) 
+    
+  end
+  
+end