trollolo 0.0.9 → 0.0.10

data/spec/unit/scrum_board_spec.rb

@@ -83,4 +83,94 @@ describe ScrumBoard do
       expect(scrum_board.done_column.name).to eq("Done (July 20th - August 3rd)")
     end
   end
+
+  describe "card counts" do
+    context "full board" do
+      let(:board) { ScrumBoard.new(JSON.parse(load_test_file("full-board.json")), dummy_settings) }
+
+      it "#done_cards" do
+        expect(board.done_cards.count).to eq(3)
+        expect(board.done_cards[0].name).to eq("Burndown chart")
+        expect(board.done_cards[1].name).to eq("Sprint 10")
+        expect(board.done_cards[2].name).to eq("(3) P3: Fill Done columns")
+      end
+
+      it "#extra_cards" do
+        expect(board.extra_cards.count).to eq(1)
+        expect(board.extra_cards[0].name).to eq("(8) P6: Celebrate testing board")
+      end
+
+      it "#extra_done_cards" do
+        expect(board.extra_done_cards.count).to eq(0)
+      end
+
+      it "#unplanned_cards" do
+        expect(board.unplanned_cards.count).to eq(2)
+        expect(board.unplanned_cards[0].name).to eq("(2) Some unplanned work")
+        expect(board.unplanned_cards[1].name).to eq("(1) Fix emergency")
+      end
+
+      it "#unplanned_done_cards" do
+        expect(board.unplanned_done_cards.count).to eq(1)
+        expect(board.unplanned_done_cards[0].name).to eq("(2) Some unplanned work")
+      end
+
+      it "#done_fast_lane_cards_count" do
+        expect(board.done_fast_lane_cards_count).to eq(0)
+      end
+
+      it "#scrum_cards" do
+        expect(board.scrum_cards.count).to eq(4)
+        expect(board.scrum_cards[0].name).to eq("Burndown chart")
+        expect(board.scrum_cards[1].name).to eq("Sprint 10")
+        expect(board.scrum_cards[2].name).to eq("(3) P3: Fill Done columns")
+        expect(board.scrum_cards[3].name).to eq("(2) Some unplanned work")
+      end
+    end
+
+    context "full board with 'Accepted' column" do
+      let(:board) { ScrumBoard.new(JSON.parse(load_test_file("full-board-with-accepted.json")), dummy_settings) }
+
+      it "#done_cards" do
+        expect(board.done_cards.count).to eq(4)
+        expect(board.done_cards[0].name).to eq("Burndown chart")
+        expect(board.done_cards[1].name).to eq("Sprint 10")
+        expect(board.done_cards[2].name).to eq("(2) P7: Add Accepted column")
+        expect(board.done_cards[3].name).to eq("(3) P3: Fill Done columns")
+      end
+
+      it "#extra_cards" do
+        expect(board.extra_cards.count).to eq(1)
+        expect(board.extra_cards[0].name).to eq("(8) P6: Celebrate testing board")
+      end
+
+      it "#extra_done_cards" do
+        expect(board.extra_done_cards.count).to eq(0)
+      end
+
+      it "#unplanned_cards" do
+        expect(board.unplanned_cards.count).to eq(2)
+        expect(board.unplanned_cards[0].name).to eq("(2) Some unplanned work")
+        expect(board.unplanned_cards[1].name).to eq("(1) Fix emergency")
+      end
+
+      it "#unplanned_done_cards" do
+        expect(board.unplanned_done_cards.count).to eq(1)
+        expect(board.unplanned_done_cards[0].name).to eq("(2) Some unplanned work")
+      end
+
+      it "#done_fast_lane_cards_count" do
+        expect(board.done_fast_lane_cards_count).to eq(0)
+      end
+
+      it "#scrum_cards" do
+        expect(board.scrum_cards.count).to eq(5)
+        expect(board.scrum_cards[0].name).to eq("Burndown chart")
+        expect(board.scrum_cards[1].name).to eq("Sprint 10")
+        expect(board.scrum_cards[2].name).to eq("(2) Some unplanned work")
+        expect(board.scrum_cards[3].name).to eq("(2) P7: Add Accepted column")
+        expect(board.scrum_cards[4].name).to eq("(3) P3: Fill Done columns")
+      end
+    end
+  end
 end

data/spec/unit/settings_spec.rb

@@ -3,25 +3,61 @@ require_relative 'spec_helper'
 describe Settings do
 
   include GivenFilesystemSpecHelpers
-  
+
   context "given config file" do
     before(:each) do
       @settings = Settings.new( File.expand_path('../../data/trollolorc',__FILE__) )
     end
-    
+
     it "is not verbose by default" do
       expect(@settings.verbose).to be false
     end
-    
+
     it "reads config file" do
       expect(@settings.developer_public_key).to eq "mykey"
       expect(@settings.member_token).to eq "mytoken"
     end
+
+    context "#scrum" do
+      context "when setting is missing" do
+        before do
+          @settings = Settings.new( File.expand_path('../../data/trollolorc_with_board_aliases',__FILE__) )
+        end
+        it "returns default settings" do
+          expect(@settings.scrum["board_names"]).to eq({"planning"=>"Planning Board", "sprint"=>"Sprint Board"})
+        end
+      end
+
+      context "when setting does exist" do
+        it "returns name" do
+          expect(@settings.scrum["board_names"]["sprint"]).to eq("Sprint Board")
+          expect(@settings.scrum.board_names["planning"]).to eq("Planning Board")
+        end
+      end
+    end
+
+    context "#board_aliases" do
+      context "when aliases do not exist" do
+        it "returns an empty Hash" do
+          expect(@settings.board_aliases).to eq({})
+        end
+      end
+
+      context "when mapping exists" do
+        before do
+          @settings = Settings.new( File.expand_path('../../data/trollolorc_with_board_aliases',__FILE__) )
+        end
+
+        it "returns the mapping" do
+          expect(@settings.board_aliases).to eq({"MyTrelloBoard" => "53186e8391ef8671265eba9d"})
+        end
+      end
+    end
   end
-  
+
   context "non-existent config file" do
     use_given_filesystem
-  
+
     before(:each) do
       @config_file = given_dummy_file
       @settings = Settings.new(@config_file)
@@ -31,7 +67,7 @@ describe Settings do
       @settings.developer_public_key = "mypublickey"
       @settings.member_token = "mymembertoken"
       @settings.save_config
-      
+
       expect(File.read(@config_file)).to eq "---\ndeveloper_public_key: mypublickey\nmember_token: mymembertoken\n"
     end
   end

data/spec/unit/spec_helper.rb

@@ -1,9 +1,10 @@
-require "codeclimate-test-reporter"
-CodeClimate::TestReporter.start
+require "simplecov"
+SimpleCov.start
 require_relative '../../lib/trollolo'
 require 'given_filesystem/spec_helpers'
 require 'webmock/rspec'
 require 'byebug'
+require 'pry'
 WebMock.disable_net_connect!(:allow => "codeclimate.com")
 
 bin_path = File.expand_path( "../../../bin/", __FILE__ )

data/spec/unit/support/update_webmock_data

@@ -13,7 +13,9 @@ def scrub_file(file)
   json = JSON.parse(File.read(file))
   if json.is_a?(Hash) and json.has_key?("cards")
     json["cards"].each do |card|
-      card["email"] = "trello@example.com"
+      if card.has_key?("email")
+        card["email"] = "trello@example.com"
+      end
     end
   end
   File.open(file, "w") do |f|

data/spec/unit/support/vcr.rb

@@ -4,26 +4,26 @@ VCR.configure do |config|
   config.hook_into :webmock
 end
 
-# example needs to use real_settings if vcr_rerecord: true is used
+# example needs to use real_settings if vcr_record: true is used
 def real_settings
   config_path = ENV["TROLLOLO_CONFIG_PATH"] || File.expand_path("~/.trollolorc")
   Settings.new(config_path)
 end
 
-def real_settings_needed?(example, subject)
-  example.metadata[:vcr_rerecord] && subject.instance_variable_get(:@settings).developer_public_key == 'mykey'
+def real_settings_needed?(example)
+  example.metadata[:vcr_record] && Trello.configuration.developer_public_key == 'mykey'
 end
 
 def cassette_path(cassette)
   File.join(VCR.configuration.cassette_library_dir, cassette + '.yml')
 end
 
-def vcr_rerecord?(example)
-  example.metadata[:vcr_rerecord] && File.readable?(cassette_path(example.metadata[:vcr]))
+def vcr_record?(example)
+  example.metadata[:vcr_record]
 end
 
 def vcr_record_mode(example)
-  return :all if vcr_rerecord?(example)
+  return :all if vcr_record?(example)
   :none
 end
 
@@ -40,11 +40,11 @@ end
 RSpec.configure do |c|
   c.around do |example|
     if cassette = example.metadata[:vcr]
-      fail "you need to use real_settings to re-record vcr data" if real_settings_needed?(example, subject)
+      fail "you need to use real_settings to re-record vcr data" if real_settings_needed?(example)
       VCR.use_cassette(cassette, record: vcr_record_mode(example)) do
         example.run
       end
-      vcr_replace_tokens(cassette_path(cassette)) if vcr_rerecord?(example)
+      vcr_replace_tokens(cassette_path(cassette)) if vcr_record?(example)
     else
       example.run
     end

data/spec/unit/support/webmocks.rb

@@ -19,6 +19,15 @@ def webmock_mapping
         "card_checklists" => "all"
       },
       file: 'full-board.json'
+    },
+    {
+      path: 'boards/P4kJA4bE',
+      parameters: {
+        "cards" => "open",
+        "lists" => "open",
+        "card_checklists" => "all"
+      },
+      file: 'full-board-with-accepted.json'
     }
   ]
 end

data/spec/unit/trello_wrapper_spec.rb

@@ -47,6 +47,26 @@ describe TrelloWrapper do
     end
   end
 
+  describe '#backup' do
+    it 'raises an error for empty board id' do
+      expect { subject.backup("") }.to raise_error(TrolloloError)
+    end
+
+    it 'raises an error for nil board id' do
+      expect { subject.backup(nil) }.to raise_error(TrolloloError)
+    end
+  end
+
+  describe '#retrieve_board_data' do
+    it 'raises error when board id is empty' do
+      expect { subject.retrieve_board_data('') }.to raise_error(TrolloloError)
+    end
+
+    it 'raises error when board id is nil' do
+      expect { subject.retrieve_board_data(nil) }.to raise_error(TrolloloError)
+    end
+  end
+
   describe '#add_attachment' do
     use_given_filesystem
 

data/trollolo.gemspec

@@ -17,7 +17,8 @@ Gem::Specification.new do |s|
   s.rubyforge_project         = 'trollolo'
 
   s.add_dependency 'thor', '~> 0.19'
-  s.add_dependency 'ruby-trello', '~> 1.1'
+  s.add_dependency 'ruby-trello', '~> 1.5.0'
+  s.add_dependency 'activesupport', '~> 4'
 
   s.files        = `git ls-files`.split("\n")
   s.executables  = `git ls-files`.split("\n").map{|f| f =~ /^bin\/(.*)/ ? $1 : nil}.compact

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: trollolo
 version: !ruby/object:Gem::Version
-  version: 0.0.9
+  version: 0.0.10
 platform: ruby
 authors:
 - Cornelius Schumacher
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-07-19 00:00:00.000000000 Z
+date: 2017-05-17 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: thor
@@ -30,14 +30,28 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.1'
+        version: 1.5.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.1'
+        version: 1.5.0
+- !ruby/object:Gem::Dependency
+  name: activesupport
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '4'
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '4'
 description: Trollolo is a command line tool to access Trello and support tasks like
   generation of burndown charts.
 email:
@@ -66,10 +80,20 @@ files:
 - lib/checklist.rb
 - lib/cli.rb
 - lib/column.rb
-- lib/prioritizer.rb
+- lib/empty_column.rb
+- lib/scrum.rb
+- lib/scrum/backlog_mover.rb
+- lib/scrum/card_type_detection.rb
+- lib/scrum/creator.rb
+- lib/scrum/prioritizer.rb
+- lib/scrum/priority_name.rb
+- lib/scrum/scrum_boards.rb
+- lib/scrum/sprint_board.rb
+- lib/scrum/sprint_cleaner.rb
+- lib/scrum/sprint_planning_board.rb
 - lib/scrum_board.rb
 - lib/settings.rb
-- lib/sprint_cleanup.rb
+- lib/trello_service.rb
 - lib/trello_wrapper.rb
 - lib/trollolo.rb
 - lib/version.rb
@@ -107,10 +131,22 @@ files:
 - spec/data/create_burndown_helper/burndown-data-35.yaml
 - spec/data/create_burndown_helper/burndown-data-42.yaml
 - spec/data/create_burndown_helper/burndown-data-56.yaml
+- spec/data/full-board-with-accepted.json
 - spec/data/full-board.json
 - spec/data/lists.json
 - spec/data/trollolorc
+- spec/data/trollolorc_with_board_aliases
+- spec/data/vcr/creator_custom_config.yml
+- spec/data/vcr/creator_default_config.yml
+- spec/data/vcr/move_backlog.yml
+- spec/data/vcr/move_backlog_missing_backlog.yml
+- spec/data/vcr/move_backlog_missing_waterbed.yml
+- spec/data/vcr/prioritize_backlog_list.yml
+- spec/data/vcr/prioritize_no_backlog_list.yml
+- spec/data/vcr/sprint_board.yml
+- spec/data/vcr/sprint_board_no_waterline.yml
 - spec/data/vcr/sprint_cleanup.yml
+- spec/data/vcr/sprint_planning_board.yml
 - spec/integration/command_line_spec.rb
 - spec/integration/create_burndown_spec.rb
 - spec/integration/integration_spec_helper.rb
@@ -123,12 +159,19 @@ files:
 - spec/unit/burndown_data_spec.rb
 - spec/unit/card_spec.rb
 - spec/unit/cli_spec.rb
-- spec/unit/prioritizer_spec.rb
+- spec/unit/empty_column_spec.rb
 - spec/unit/retrieve_data_spec.rb
+- spec/unit/scrum/backlog_mover_spec.rb
+- spec/unit/scrum/card_type_detection_spec.rb
+- spec/unit/scrum/creator_spec.rb
+- spec/unit/scrum/prioritizer_spec.rb
+- spec/unit/scrum/priority_name_spec.rb
+- spec/unit/scrum/sprint_board_spec.rb
+- spec/unit/scrum/sprint_cleaner_spec.rb
+- spec/unit/scrum/sprint_planning_board_spec.rb
 - spec/unit/scrum_board_spec.rb
 - spec/unit/settings_spec.rb
 - spec/unit/spec_helper.rb
-- spec/unit/sprint_cleanup_spec.rb
 - spec/unit/support/test_data_operations.rb
 - spec/unit/support/update_webmock_data
 - spec/unit/support/vcr.rb
@@ -156,7 +199,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: 1.3.6
 requirements: []
 rubyforge_project: trollolo
-rubygems_version: 2.4.5.1
+rubygems_version: 2.5.1
 signing_key: 
 specification_version: 4
 summary: Trello command line client

data/lib/prioritizer.rb

@@ -1,34 +0,0 @@
-class Prioritizer
-
-  def initialize(settings)
-    @settings = settings
-  end
-
-  def prioritize(board_id, list_name)
-    list = find_list(board_id, list_name)
-    fail "list not found on board" unless list
-    update_priorities(list)
-  end
-
-  private
-
-  def trello
-    @trello ||= TrelloWrapper.new(@settings)
-  end
-
-  def update_priorities(list)
-    n = 1
-    list.cards.each do |card|
-      next if card.name =~ /waterline/i
-      card.priority = n
-      trello.set_name(card.id, card.name)
-      puts %(set priority to #{n} for "#{card.name}")
-      n += 1
-    end
-  end
-
-  def find_list(board_id, list_name)
-    board = trello.board(board_id)
-    board.columns.find { |list| list.name == list_name }
-  end
-end

data/lib/sprint_cleanup.rb

@@ -1,54 +0,0 @@
-class SprintCleanup
-  SOURCE_LISTS = ["Sprint Backlog", "Doing"]
-  TARGET_LIST = "Ready"
-
-  def initialize(settings)
-    @settings = settings
-    init_trello
-  end
-
-  def cleanup(board_id, target_board_id)
-    @board = Trello::Board.find(board_id)
-    @target_board = Trello::Board.find(target_board_id)
-
-    SOURCE_LISTS.each do |list_name|
-      move_cards(@board.lists.find { |l| l.name == list_name })
-    end
-  end
-
-  private
-
-  def init_trello
-    Trello.configure do |config|
-      config.developer_public_key = @settings.developer_public_key
-      config.member_token         = @settings.member_token
-    end
-  end
-
-  def target_list
-    @target_list ||= @target_board.lists.find { |l| l.name == TARGET_LIST }
-  end
-
-  def sticky?(card)
-    card.labels.any? { |l| l.name == "Sticky" }
-  end
-
-  def waterline_label(card)
-    card.labels.find { |label| label.name =~ /waterline/i }
-  end
-
-  def remove_waterline_label(card)
-    label = waterline_label(card)
-    card.remove_label(label) if label
-  end
-
-  def move_cards(source_list)
-    source_list.cards.each do |card|
-      next if sticky?(card)
-      puts %(moving card "#{card.name}" to list "#{target_list.name}")
-      card.members.each { |member| card.remove_member(member) }
-      remove_waterline_label(card)
-      card.move_to_board(@target_board, target_list)
-    end
-  end
-end

data/spec/unit/prioritizer_spec.rb

@@ -1,47 +0,0 @@
-require_relative "spec_helper"
-require 'pry'
-
-describe Prioritizer do
-  it "creates new prioritizer" do
-    prioritizer = Prioritizer.new(dummy_settings)
-    expect(prioritizer).to be
-  end
-
-  context "default" do
-    subject { described_class.new(dummy_settings) }
-
-    before(:each) do
-      full_board_mock
-    end
-
-    it "raises an exception if list is not on board" do
-      expect {
-        subject.prioritize("53186e8391ef8671265eba9d", "Backlog")
-      }.to raise_error("list not found on board")
-    end
-
-    it "raises an exception if list is not on board" do
-			RSpec::Expectations.configuration.on_potential_false_positives = :nothing
-      expect {
-        subject.prioritize("53186e8391ef8671265eba9d", "Sprint Backlog")
-      }.not_to raise_error("list not found on board")
-    end
-
-    it "adds priority text to card titles" do
-      [
-        "5319bf244cc53afd5afd991f/name?key=mykey&token=mytoken&value=P1:%20Sprint%203",
-        "5319c16d9d04708d450d65f1/name?key=mykey&token=mytoken&value=(3)%20P2:%20Fill%20Backlog%20column",
-        "5319c57ff6be845f428aa7a3/name?key=mykey&token=mytoken&value=(5)%20P3:%20Read%20data%20from%20Trollolo",
-        "5319c5961e530fd26f83999d/name?key=mykey&token=mytoken&value=(3)%20P4:%20Save%20read%20data%20as%20reference%20data",
-				"5319c5a8743488047e13fcbc/name?key=mykey&token=mytoken&value=(8)%20P5:%20Celebrate%20testing%20board",
-      ].each { |value|
-        stub_request(:put, "https://api.trello.com/1/cards/#{value}")
-      }
-
-      expect(STDOUT).to receive(:puts).exactly(5).times
-      expect {
-        subject.prioritize("53186e8391ef8671265eba9d", "Sprint Backlog")
-      }.not_to raise_error
-    end
-  end
-end

data/spec/unit/sprint_cleanup_spec.rb

@@ -1,18 +0,0 @@
-require_relative "spec_helper"
-require 'pry'
-
-describe SprintCleanup do
-  it "creates new sprint cleanup" do
-    sprint_cleanup = SprintCleanup.new(dummy_settings)
-    expect(sprint_cleanup).to be
-  end
-
-  context "default" do
-    subject { described_class.new(dummy_settings) }
-
-    it "moves remaining cards to target board", vcr: "sprint_cleanup", vcr_rerecord: false do
-      expect(STDOUT).to receive(:puts).exactly(5).times
-      expect(subject.cleanup("GVMQz9dx", "neUHHzDo")).to be
-    end
-  end
-end