trmnl_preview 0.8.8 → 0.8.10

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 84919e1b992ea8c0adab71308260b49c178f6c8c9af501b0d5662f80f123e262
-  data.tar.gz: 58c3960edf707710301e76b004172d0983a7f26e6fc8f4cd79e2376a599938fe
+  metadata.gz: 3145b576605d810530928542bfd48de0c6c402fa2ab8dc0063144c7ec15d5dfc
+  data.tar.gz: 4138e9af75278586a63fd4a6f3ca3d51bb2dd9b73f01c8ce74745dd84d96b56e
 SHA512:
-  metadata.gz: 7c6f55953c874c74239386a4cc703e7e1641058a4b3b4ea37a12eb7403d540f8acae62a3479eeb6c12b7eedf6243ec80dc6e5d887891e3ad5e64684abc4350b1
-  data.tar.gz: 1de6ad69a4708c0c7922cb21ce40f811f6e2fd591641cda99dbddeac157bbb0470c541a7fa661366b83b978075bc27dece96c416aa70d3310b146ea2afacdf74
+  metadata.gz: a292f2a442bc47bd4654649f86293ac3ae91d8b9b6a484fd210685efbcbdabfbbef80f72d7f9828d401e3dc1dc5b601491a4bf0f39ab801c76ae2e7b64d898d0
+  data.tar.gz: bf523d8eeea24970c1cd3eb64e43cef8c4d38ea3a0749b401ff5b0f5951650ec73ce9da521ca943de0d312b88d513902c72eb9254afc6dab34b03c1d6699dbb0

data/CHANGELOG.md

@@ -1,6 +1,14 @@
 
 # Changelog
 
+## 0.8.10
+
+- Fixed Python serverless transforms failing on Windows. The local subprocess backend hardcoded `python3`, which the python.org Windows installer does not put on PATH (it installs `python` and the `py` launcher), so every Python transform raised "interpreter not available". The interpreter is now resolved from a per-language list of command candidates (`python3`, then `python`, then the `py` launcher) using a cross-platform PATH lookup, leaving POSIX behavior unchanged. (#116)
+
+## 0.8.9
+
+- Fixed `trmnlp serve` binding to localhost under Podman, which left the dev server unreachable through published ports. Container detection only looked for `/.dockerenv`, which Docker writes but Podman does not, so `serve` fell back to `127.0.0.1`. It now also checks for `/run/.containerenv`, which Podman writes, so the automatic `0.0.0.0` bind works for both runtimes. (#112)
+
 ## 0.8.8
 
 - Added a `--server` flag to `trmnlp login` so commands like `trmnlp push` can target a self-hosted (BYOS) server. The chosen URL is saved as `base_url`, and the `user_` API key prefix is only required for trmnl.com; BYOS servers accept their own token formats. A scheme-less `--server` value (such as `localhost:3000`) no longer crashes the host check. (#113)

data/README.md

@@ -206,7 +206,8 @@ docker run \
     --pull always \
     --publish 4567:4567 \
     --volume "$(pwd):/plugin" \
-    trmnl/trmnlp serve
+    trmnl/trmnlp serve \
+    --bind 0.0.0.0
 ```
 
 `--pull always` checks the registry on every run and pulls a newer image if one exists, so you don't have to remember to `docker pull` after each release.

data/lib/trmnlp/cli.rb

@@ -16,7 +16,11 @@ module TRMNLP
 
     def self.exit_on_failure? = true
 
-    def self.default_bind = File.exist?('/.dockerenv') ? '0.0.0.0' : '127.0.0.1'
+    # Docker writes /.dockerenv; Podman writes /run/.containerenv. Either means we're
+    # in a container, where binding to localhost makes the dev server unreachable via
+    # published ports, so we bind to all interfaces instead.
+    def self.in_container? = File.exist?('/.dockerenv') || File.exist?('/run/.containerenv')
+    def self.default_bind = in_container? ? '0.0.0.0' : '127.0.0.1'
 
     desc 'build', 'Generate static HTML files'
     method_option :png, type: :boolean, default: false, desc: 'Also render a PNG per view'

data/lib/trmnlp/transform_backend/subprocess.rb

@@ -4,6 +4,7 @@ require 'open3'
 require 'tmpdir'
 
 require_relative '../transform_client'
+require_relative 'which'
 require_relative 'wrapper'
 
 module TRMNLP
@@ -19,11 +20,16 @@ module TRMNLP
       # Seconds a TERM'd process is given to exit before escalating to KILL.
       GRACE_PERIOD = 0.1
 
+      # Candidate commands per language, highest priority first. Windows is
+      # why a language needs more than one: its python.org installer provides
+      # `python` and the `py` launcher but no `python3`. `py` ranks last yet
+      # is the surest Windows hit — it stays on PATH even when the installer's
+      # optional "Add to PATH" step is skipped.
       INTERPRETERS = {
-        'python' => { cmd: 'python3', ext: 'py' },
-        'ruby' => { cmd: 'ruby',    ext: 'rb' },
-        'node' => { cmd: 'node',    ext: 'js' },
-        'php' => { cmd: 'php', ext: 'php' }
+        'python' => { cmds: %w[python3 python py], ext: 'py' },
+        'ruby' => { cmds: %w[ruby],                ext: 'rb' },
+        'node' => { cmds: %w[node],                ext: 'js' },
+        'php' => { cmds: %w[php],                  ext: 'php' }
       }.freeze
 
       def execute(code:, language:, stdin: '', timeout_seconds: DEFAULT_TIMEOUT)
@@ -40,7 +46,7 @@ module TRMNLP
           output_path = File.join(dir, 'output.json')
           src_path = File.join(dir, "transform.#{spec[:ext]}")
           File.write(src_path, Wrapper.for(language, code, sink_for(language, output_path)))
-          run_process(spec[:cmd], src_path, stdin, timeout_seconds, output_path)
+          run_process(Which.resolve(spec[:cmds]), src_path, stdin, timeout_seconds, output_path)
         end
       rescue Errno::ENOENT, Errno::EACCES => e
         failure("interpreter not available: #{e.message}")

data/lib/trmnlp/transform_backend/which.rb

@@ -0,0 +1,29 @@
+# frozen_string_literal: true
+
+module TRMNLP
+  module TransformBackend
+    # Resolves a command to the interpreter actually present on PATH, so one
+    # transform runs unchanged on platforms that name an interpreter
+    # differently — most pressingly Windows, which ships no `python3`.
+    module Which
+      module_function
+
+      # Falls back to the first candidate when none resolve, leaving the
+      # caller to surface the usual "interpreter not available" ENOENT.
+      def resolve(candidates, path: ENV.fetch('PATH', ''), pathext: ENV.fetch('PATHEXT', ''))
+        candidates.find { |cmd| locate(cmd, path: path, pathext: pathext) } || candidates.first
+      end
+
+      # Windows marks executables by extension, enumerated in PATHEXT
+      # (.EXE/.BAT/...); POSIX leaves PATHEXT unset and relies on the exec bit.
+      def locate(cmd, path: ENV.fetch('PATH', ''), pathext: ENV.fetch('PATHEXT', ''))
+        suffixes = pathext.split(File::PATH_SEPARATOR)
+        suffixes = [''] if suffixes.empty?
+        path.split(File::PATH_SEPARATOR)
+            .product(suffixes)
+            .map { |dir, suffix| File.join(dir, "#{cmd}#{suffix}") }
+            .find { |candidate| File.file?(candidate) && File.executable?(candidate) }
+      end
+    end
+  end
+end

data/lib/trmnlp/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module TRMNLP
-  VERSION = '0.8.8'
+  VERSION = '0.8.10'
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: trmnl_preview
 version: !ruby/object:Gem::Version
-  version: 0.8.8
+  version: 0.8.10
 platform: ruby
 authors:
 - Rockwell Schrock
@@ -313,6 +313,7 @@ files:
 - lib/trmnlp/screenshot.rb
 - lib/trmnlp/transform_backend/http.rb
 - lib/trmnlp/transform_backend/subprocess.rb
+- lib/trmnlp/transform_backend/which.rb
 - lib/trmnlp/transform_backend/wrapper.rb
 - lib/trmnlp/transform_client.rb
 - lib/trmnlp/transform_pipeline.rb