trmnl_preview 0.17.0 → 0.17.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: e31acf7d3493227af9ab7f728969de7c882622102661528186d29dce67ca722a
-  data.tar.gz: 29761cde0d07f5a026ff7a0bc3b1342ea6ad924402236296215bb6f8edfc2e29
+  metadata.gz: 835368508a529b50bb30de82e6a0170a9d5c14f6edebeb4ffdd2afc774273e58
+  data.tar.gz: 7cf9003dde78b9688674ff48fe0e0fa7decd50ee36204de9196078141ae3defa
 SHA512:
-  metadata.gz: c2a64c19c1fcbdd43c49f94e604e4e0f136f46469abf42a96d2c993f9594f2f4ba1801b3c243d71edc97dfc59e1801b882ee288fcc0184cd638e5917abbe1286
-  data.tar.gz: 40a4779d9e8694389ee0d087ec03081171a930c72341aee959e2cbea37ca1ef095006a8bc311ab4dd2bf0fd610f682fe5afbb93792c247c2f9f1b4ba7bc884c2
+  metadata.gz: 339f9c574ee307ebc59ed949d6b12bcdb7c58aaa6191564f0b8b6d5b91c675322e2f329055b2630f6d29db3ca341386e09aded2f02e928c129f297890584fbb4
+  data.tar.gz: 3d5c286313c7a75f2b6beaba417917fdc932a51dd8e4e9f3953065111f1accec23d3480164f47588547b6bcc2b482abbe534368328c8107e034308f354197dfd

data/CHANGELOG.md

@@ -1,6 +1,15 @@
 
 # Changelog
 
+## 0.17.2
+
+- `trmnlp test` no longer inlines a stylesheet link inside a script's string, such as a CDN fallback written with `document.write`. It broke the script, and every render came out blank. (#174)
+
+## 0.17.1
+
+- `trmnlp test --report` writes its images readable by everyone, and `--update` its snapshots. They kept the 0600 mode of the screen's temp file, so under the `trmnl/trmnlp` image, which runs as root, the init workflow could not upload the report. (#171)
+- Capybara's matchers compose with `.and` and `.or` in a plugin's tests. (#172)
+
 ## 0.17.0
 
 - `trmnlp init` adds a starter `tests/plugin_spec.rb`, and its GitHub workflow gains a `test` job: `trmnlp test --report` in the `trmnl/trmnlp` image (one `TRMNLP_IMAGE` setting picks the tag), the report uploaded, a manual `update_snapshots` run, and the push to TRMNL waiting for lint and tests. (#168)

data/lib/trmnlp/testing/inline_stylesheets.rb

@@ -10,16 +10,19 @@ module TRMNLP
     # measures text (a layout solver, say) raced them and drew a different board from run to run.
     module InlineStylesheets
       LINK = /<link\b[^>]*\brel=["']stylesheet["'][^>]*>/i
+      SCRIPT = %r{<script\b.*?</script>}im
       HREF = /\bhref=["'](https?:[^"']+)["']/i
       CSS_URL = /url\(\s*(['"]?)(?!data:|https?:|#)([^'")]+)\1\s*\)/i
 
       module_function
 
       def call(html)
-        html.gsub(LINK) do |link|
-          url = link[HREF, 1]
+        html.gsub(Regexp.union(SCRIPT, LINK)) do |tag|
+          next tag if tag.match?(/\A<script/i)
+
+          url = tag[HREF, 1]
           css = url && stylesheet(url)
-          css ? "<style data-href=\"#{url}\">#{css}</style>" : link
+          css ? "<style data-href=\"#{url}\">#{css}</style>" : tag
         end
       end
 

data/lib/trmnlp/testing/report.rb

@@ -71,7 +71,7 @@ module TRMNLP
       def copy_image(path)
         name = "images/#{@images += 1}.png"
         FileUtils.mkdir_p(File.join(@dir, 'images'))
-        FileUtils.cp(path, File.join(@dir, name))
+        File.binwrite(File.join(@dir, name), File.binread(path)) # not cp, which keeps the screen's private 0600 mode
         name
       end
 

data/lib/trmnlp/testing/rspec.rb

@@ -1,9 +1,9 @@
 # frozen_string_literal: true
 
 # Loaded by `trmnlp test`: gives each example `trmnl`, Capybara's matchers and trmnlp's own.
-require 'capybara/rspec/matchers'
 require 'rspec/core'
 require 'rspec/expectations'
+require 'capybara/rspec/matchers' # after rspec/expectations, or its matchers lose .and and .or
 
 require_relative '../../trmnlp'
 require_relative '../browser_pool'

data/lib/trmnlp/testing/snapshot.rb

@@ -33,7 +33,7 @@ module TRMNLP
 
       def store
         FileUtils.mkdir_p(File.dirname(path))
-        FileUtils.cp(screen.png_path, path)
+        File.binwrite(path, File.binread(screen.png_path)) # not cp, which keeps the screen's private 0600 mode
         nil
       end
 

data/lib/trmnlp/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module TRMNLP
-  VERSION = '0.17.0'
+  VERSION = '0.17.2'
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: trmnl_preview
 version: !ruby/object:Gem::Version
-  version: 0.17.0
+  version: 0.17.2
 platform: ruby
 authors:
 - Rockwell Schrock