triviacrack 0.6.0 → 0.7.0

data/spec/parsers/game_parser_spec.rb

@@ -1,18 +1,18 @@
-require "spec_helper"
+# frozen_string_literal: true
 
-describe TriviaCrack::Parsers::GameParser do
-
-  describe ".parse" do
+require 'spec_helper'
 
+describe TriviaCrack::Parsers::GameParser do
+  describe '.parse' do
     subject { TriviaCrack::Parsers::GameParser.parse raw_data }
 
-    let(:game_data) { SpecData.get_json "game.json" }
-    let(:dashboard_data) { SpecData.get_json "dashboard.json" }
-    let(:answer_data) { SpecData.get_json "answer.json" }
-    let(:new_game_data) { SpecData.get_json "new_game.json" }
+    let(:game_data) { SpecData.get_json 'game.json' }
+    let(:dashboard_data) { SpecData.get_json 'dashboard.json' }
+    let(:answer_data) { SpecData.get_json 'answer.json' }
+    let(:new_game_data) { SpecData.get_json 'new_game.json' }
 
     context 'when given data from the games API' do
-      let(:raw_data) { SpecData.get_json "game.json" }
+      let(:raw_data) { SpecData.get_json 'game.json' }
 
       it { is_expected.to be_a TriviaCrack::Game }
       its(:id) { is_expected.to be 1111 }
@@ -31,13 +31,13 @@ describe TriviaCrack::Parsers::GameParser do
       its(:status_version) { is_expected.to be 23 }
       its(:available_crowns) { is_expected.to contain_exactly(:entertainment, :arts, :sports) }
       its('questions.first') { is_expected.to be_a TriviaCrack::Question }
-      its('questions.first.id') { is_expected.to be 16653413 }
+      its('questions.first.id') { is_expected.to be 16_653_413 }
       its(:my_statistics) { is_expected.to be_a TriviaCrack::GameStatistics }
       its(:opponent_statistics) { is_expected.to be_a TriviaCrack::GameStatistics }
     end
 
     context 'when given data from the dashboard API' do
-      let(:raw_data) { SpecData.get_json("dashboard.json")["list"][3] }
+      let(:raw_data) { SpecData.get_json('dashboard.json')['list'][3] }
 
       it { is_expected.to be_a TriviaCrack::Game }
       its(:id) { is_expected.to be 1115 }
@@ -56,13 +56,13 @@ describe TriviaCrack::Parsers::GameParser do
       its(:status_version) { is_expected.to be 24 }
       its(:available_crowns) { is_expected.to contain_exactly(:entertainment, :arts, :sports) }
       its('questions.first') { is_expected.to be_a TriviaCrack::Question }
-      its('questions.first.id') { is_expected.to be 15593975 }
+      its('questions.first.id') { is_expected.to be 15_593_975 }
       its(:my_statistics) { is_expected.to be_a TriviaCrack::GameStatistics }
       its(:opponent_statistics) { is_expected.to be_a TriviaCrack::GameStatistics }
     end
 
     context 'when given data from the answers API' do
-      let(:raw_data) { SpecData.get_json "answer.json" }
+      let(:raw_data) { SpecData.get_json 'answer.json' }
 
       it { is_expected.to be_a TriviaCrack::Game }
       its(:id) { is_expected.to be 1111 }
@@ -81,13 +81,13 @@ describe TriviaCrack::Parsers::GameParser do
       its(:status_version) { is_expected.to be 24 }
       its(:available_crowns) { is_expected.to contain_exactly(:entertainment, :arts, :sports) }
       its('questions.first') { is_expected.to be_a TriviaCrack::Question }
-      its('questions.first.id') { is_expected.to be 15593975 }
+      its('questions.first.id') { is_expected.to be 15_593_975 }
       its(:my_statistics) { is_expected.to be_a TriviaCrack::GameStatistics }
       its(:opponent_statistics) { is_expected.to be_a TriviaCrack::GameStatistics }
     end
 
     context 'when given data from the new game API' do
-      let(:raw_data) { SpecData.get_json "new_game.json" }
+      let(:raw_data) { SpecData.get_json 'new_game.json' }
 
       it { is_expected.to be_a TriviaCrack::Game }
       its(:id) { is_expected.to be 2222 }
@@ -104,15 +104,17 @@ describe TriviaCrack::Parsers::GameParser do
       its(:is_random) { is_expected.to be true }
       its(:unread_messages) { is_expected.to be 0 }
       its(:status_version) { is_expected.to be 0 }
-      its(:available_crowns) { is_expected.to contain_exactly(:arts, :entertainment, :geography, :history, :science, :sports) }
+      its(:available_crowns) do
+        is_expected.to contain_exactly(:arts, :entertainment, :geography, :history, :science, :sports)
+      end
       its('questions.first') { is_expected.to be_a TriviaCrack::Question }
-      its('questions.first.id') { is_expected.to be 12785 }
+      its('questions.first.id') { is_expected.to be 12_785 }
       its(:my_statistics) { is_expected.to be_a TriviaCrack::GameStatistics }
       its(:opponent_statistics) { is_expected.to be_a TriviaCrack::GameStatistics }
     end
 
     context 'when given data from the games API and the game is a duel' do
-      let(:raw_data) { SpecData.get_json "game_duel.json" }
+      let(:raw_data) { SpecData.get_json 'game_duel.json' }
 
       it { is_expected.to be_a TriviaCrack::Game }
       its(:id) { is_expected.to be 1119 }
@@ -132,7 +134,7 @@ describe TriviaCrack::Parsers::GameParser do
       its(:available_crowns) { is_expected.to contain_exactly(:entertainment, :science, :history, :sports) }
       its('questions.size') { is_expected.to eq(7) }
       its('questions.first') { is_expected.to be_a TriviaCrack::Question }
-      its('questions.first.id') { is_expected.to be 17881223 }
+      its('questions.first.id') { is_expected.to be 17_881_223 }
       its(:my_statistics) { is_expected.to be_a TriviaCrack::GameStatistics }
       its(:opponent_statistics) { is_expected.to be_a TriviaCrack::GameStatistics }
     end

data/spec/parsers/game_statistics_parser_spec.rb

@@ -1,16 +1,16 @@
-require "spec_helper"
+# frozen_string_literal: true
 
-describe TriviaCrack::Parsers::GameStatisticsParser do
-
-  describe ".parse" do
+require 'spec_helper'
 
+describe TriviaCrack::Parsers::GameStatisticsParser do
+  describe '.parse' do
     subject { TriviaCrack::Parsers::GameStatisticsParser.parse statistics_data }
 
-    let(:statistics_data) { raw_data["statistics"]["player_one_statistics"] }
-    before { statistics_data["crowns"] = raw_data["player_one"]["crowns"] }
+    let(:statistics_data) { raw_data['statistics']['player_one_statistics'] }
+    before { statistics_data['crowns'] = raw_data['player_one']['crowns'] }
 
     context 'when given data from the games API' do
-      let(:raw_data) { SpecData.get_json "game.json" }
+      let(:raw_data) { SpecData.get_json 'game.json' }
 
       it { is_expected.to be_a TriviaCrack::GameStatistics }
       its(:correct_answers) { is_expected.to be 12 }
@@ -21,7 +21,7 @@ describe TriviaCrack::Parsers::GameStatisticsParser do
     end
 
     context 'when given data from the dashboard API' do
-      let(:raw_data) { SpecData.get_json("dashboard.json")["list"][3] }
+      let(:raw_data) { SpecData.get_json('dashboard.json')['list'][3] }
 
       it { is_expected.to be_a TriviaCrack::GameStatistics }
       its(:correct_answers) { is_expected.to be 13 }
@@ -32,7 +32,7 @@ describe TriviaCrack::Parsers::GameStatisticsParser do
     end
 
     context 'when given data from the answer API' do
-      let(:raw_data) { SpecData.get_json "answer.json" }
+      let(:raw_data) { SpecData.get_json 'answer.json' }
 
       it { is_expected.to be_a TriviaCrack::GameStatistics }
       its(:correct_answers) { is_expected.to be 13 }
@@ -43,14 +43,14 @@ describe TriviaCrack::Parsers::GameStatisticsParser do
     end
 
     context 'when given data from the new game API' do
-      let(:raw_data) { SpecData.get_json "new_game.json" }
+      let(:raw_data) { SpecData.get_json 'new_game.json' }
 
       it { is_expected.to be_a TriviaCrack::GameStatistics }
       its(:correct_answers) { is_expected.to be 0 }
       its(:incorrect_answers) { is_expected.to be 0 }
       its(:challenges_won) { is_expected.to be 0 }
       its(:questions_answered) { is_expected.to be 0 }
-      its(:crowns) { is_expected.to be_empty}
+      its(:crowns) { is_expected.to be_empty }
     end
   end
 end

data/spec/parsers/profile_parser_spec.rb

@@ -1,21 +1,21 @@
-require "spec_helper"
+# frozen_string_literal: true
 
-describe TriviaCrack::Parsers::ProfileParser do
-
-  describe ".parse" do
+require 'spec_helper'
 
+describe TriviaCrack::Parsers::ProfileParser do
+  describe '.parse' do
     subject { TriviaCrack::Parsers::ProfileParser.parse raw_data }
 
     context 'when given data from the profile API' do
-      let(:raw_data) { SpecData.get_json "profile.json" }
+      let(:raw_data) { SpecData.get_json 'profile.json' }
 
       it { is_expected.to be_a TriviaCrack::Profile }
       its(:id) { is_expected.to be 111 }
       its(:is_friend) { is_expected.to be false }
       its(:is_blocked) { is_expected.to be false }
-      its(:username) { is_expected.to eq "example" }
+      its(:username) { is_expected.to eq 'example' }
       its(:country) { is_expected.to be :us }
-      its(:email) { is_expected.to eq "user@example.com" }
+      its(:email) { is_expected.to eq 'user@example.com' }
       its(:last_play) { is_expected.to be_a Time }
       its(:last_login) { is_expected.to be_a Time }
       its(:games_won) { is_expected.to be 530 }
@@ -32,15 +32,15 @@ describe TriviaCrack::Parsers::ProfileParser do
     end
 
     context 'when given data from the current user profile API' do
-      let(:raw_data) { SpecData.get_json "my_profile.json" }
+      let(:raw_data) { SpecData.get_json 'my_profile.json' }
 
       it { is_expected.to be_a TriviaCrack::Profile }
       its(:id) { is_expected.to be 222 }
       its(:is_friend) { is_expected.to be false }
       its(:is_blocked) { is_expected.to be false }
-      its(:username) { is_expected.to eq "example2" }
+      its(:username) { is_expected.to eq 'example2' }
       its(:country) { is_expected.to be :ca }
-      its(:email) { is_expected.to eq "user2@example.com" }
+      its(:email) { is_expected.to eq 'user2@example.com' }
       its(:last_play) { is_expected.to be_a Time }
       its(:last_login) { is_expected.to be_a Time }
       its(:games_won) { is_expected.to be 37 }

data/spec/parsers/question_parser_spec.rb

@@ -1,34 +1,38 @@
-require "spec_helper"
+# frozen_string_literal: true
 
-describe TriviaCrack::Parsers::QuestionParser do
-
-  describe ".parse" do
+require 'spec_helper'
 
+describe TriviaCrack::Parsers::QuestionParser do
+  describe '.parse' do
     subject { TriviaCrack::Parsers::QuestionParser.parse raw_data }
 
     context 'when given data without an image' do
-      let(:raw_data) { SpecData.get_json "question.json" }
+      let(:raw_data) { SpecData.get_json 'question.json' }
 
       it { is_expected.to be_a TriviaCrack::Question }
       its(:type) { is_expected.to be :normal }
       its(:media_type) { is_expected.to be :normal }
-      its(:text) { is_expected.to eq "Who recorded this album?" }
+      its(:text) { is_expected.to eq 'Who recorded this album?' }
       its(:correct_answer) { is_expected.to be 3 }
       its(:category) { is_expected.to be :entertainment }
-      its(:answers) { is_expected.to contain_exactly "Creedence Cleawater Revival", "Bob Marley", "blink-182", "Jimmy Hendrix" }
+      its(:answers) do
+        is_expected.to contain_exactly 'Creedence Cleawater Revival', 'Bob Marley', 'blink-182', 'Jimmy Hendrix'
+      end
     end
 
     context 'when given data with an image' do
-      let(:raw_data) { SpecData.get_json "question_image.json" }
+      let(:raw_data) { SpecData.get_json 'question_image.json' }
 
       it { is_expected.to be_a TriviaCrack::Question }
       its(:type) { is_expected.to be :normal }
       its(:media_type) { is_expected.to be :image }
-      its(:text) { is_expected.to eq "Who recorded this album?" }
+      its(:text) { is_expected.to eq 'Who recorded this album?' }
       its(:correct_answer) { is_expected.to be 3 }
       its(:category) { is_expected.to be :entertainment }
-      its(:image_url) { is_expected.to eq "http://qimg.preguntados.com/ENT_3028" }
-      its(:answers) { is_expected.to contain_exactly "Creedence Cleawater Revival", "Bob Marley", "blink-182", "Jimmy Hendrix" }
+      its(:image_url) { is_expected.to eq 'http://qimg.preguntados.com/ENT_3028' }
+      its(:answers) do
+        is_expected.to contain_exactly 'Creedence Cleawater Revival', 'Bob Marley', 'blink-182', 'Jimmy Hendrix'
+      end
     end
   end
 end

data/spec/parsers/session_parser_spec.rb

@@ -1,19 +1,19 @@
-require "spec_helper"
+# frozen_string_literal: true
 
-describe TriviaCrack::Parsers::SessionParser do
-
-  describe ".parse" do
+require 'spec_helper'
 
+describe TriviaCrack::Parsers::SessionParser do
+  describe '.parse' do
     subject { TriviaCrack::Parsers::SessionParser.parse raw_data }
 
     context 'when given data from the login API' do
-      let(:raw_data) { SpecData.get_json "login.json" }
+      let(:raw_data) { SpecData.get_json 'login.json' }
 
       it { is_expected.to be_a TriviaCrack::Session }
       its(:user_id) { is_expected.to be 111 }
-      its(:username) { is_expected.to eq "example" }
-      its(:session_id) { is_expected.to eq "session123" }
-      its(:device_key) { is_expected.to eq "device123" }
+      its(:username) { is_expected.to eq 'example' }
+      its(:session_id) { is_expected.to eq 'session123' }
+      its(:device_key) { is_expected.to eq 'device123' }
       its(:expiration) { is_expected.to be_a Time }
     end
   end

data/spec/parsers/time_parser_spec.rb

@@ -1,12 +1,12 @@
-require "spec_helper"
+# frozen_string_literal: true
 
-describe TriviaCrack::Parsers::TimeParser do
-
-  describe ".parse" do
+require 'spec_helper'
 
+describe TriviaCrack::Parsers::TimeParser do
+  describe '.parse' do
     subject { TriviaCrack::Parsers::TimeParser.parse raw_data }
 
-    let(:raw_data) { "02/18/2015 00:11:33 EST" }
+    let(:raw_data) { '02/18/2015 00:11:33 EST' }
 
     it { is_expected.to be_a Time }
     its(:day) { is_expected.to be 18 }

data/spec/parsers/user_parser_spec.rb

@@ -1,19 +1,19 @@
-require "spec_helper"
+# frozen_string_literal: true
 
-describe TriviaCrack::Parsers::UserParser do
-
-  describe ".parse" do
+require 'spec_helper'
 
+describe TriviaCrack::Parsers::UserParser do
+  describe '.parse' do
     subject { TriviaCrack::Parsers::UserParser.parse raw_data }
 
     context 'when given data from the user API' do
-      let(:raw_data) { SpecData.get_json "user.json" }
+      let(:raw_data) { SpecData.get_json 'user.json' }
 
       it { is_expected.to be_a TriviaCrack::User }
       its(:id) { is_expected.to be 111 }
-      its(:username) { is_expected.to eq "example" }
-      its(:facebook_id) { is_expected.to eq "1" }
-      its(:facebook_name) { is_expected.to eq "Example Name" }
+      its(:username) { is_expected.to eq 'example' }
+      its(:facebook_id) { is_expected.to eq '1' }
+      its(:facebook_name) { is_expected.to eq 'Example Name' }
       its(:coins) { is_expected.to be 111 }
       its(:lives) { is_expected.to be 3 }
       its(:max_lives) { is_expected.to be 3 }
@@ -28,12 +28,12 @@ describe TriviaCrack::Parsers::UserParser do
     end
 
     context 'when given opponent data from the game API' do
-      let(:raw_data) { SpecData.get_json("game.json")["opponent"] }
+      let(:raw_data) { SpecData.get_json('game.json')['opponent'] }
 
       it { is_expected.to be_a TriviaCrack::User }
       its(:id) { is_expected.to be 111 }
-      its(:username) { is_expected.to eq "example.2" }
-      its(:facebook_id) { is_expected.to eq "" }
+      its(:username) { is_expected.to eq 'example.2' }
+      its(:facebook_id) { is_expected.to eq '' }
       its(:facebook_name) { is_expected.to be nil }
       its(:coins) { is_expected.to be nil }
       its(:lives) { is_expected.to be nil }

data/spec/spec_helper.rb

@@ -1,37 +1,38 @@
+# frozen_string_literal: true
+
 require 'simplecov'
 SimpleCov.start
 
-require "json"
-require "rspec/its"
-
-require_relative "../lib/triviacrack/category_statistics"
-require_relative "../lib/triviacrack/game"
-require_relative "../lib/triviacrack/game_statistics"
-require_relative "../lib/triviacrack/profile"
-require_relative "../lib/triviacrack/question"
-require_relative "../lib/triviacrack/session"
-require_relative "../lib/triviacrack/user"
-
-require_relative "../lib/triviacrack/api/client"
-require_relative "../lib/triviacrack/api/game"
-require_relative "../lib/triviacrack/api/login"
-require_relative "../lib/triviacrack/api/profile"
-require_relative "../lib/triviacrack/api/question"
-require_relative "../lib/triviacrack/api/user"
-
-require_relative "../lib/triviacrack/errors/parse_error"
-require_relative "../lib/triviacrack/errors/request_error"
-
-require_relative "../lib/triviacrack/parsers/category_statistics_parser"
-require_relative "../lib/triviacrack/parsers/game_parser"
-require_relative "../lib/triviacrack/parsers/game_statistics_parser"
-require_relative "../lib/triviacrack/parsers/profile_parser"
-require_relative "../lib/triviacrack/parsers/question_parser"
-require_relative "../lib/triviacrack/parsers/session_parser"
-require_relative "../lib/triviacrack/parsers/user_parser"
+require 'json'
+require 'rspec/its'
+
+require_relative '../lib/triviacrack/category_statistics'
+require_relative '../lib/triviacrack/game'
+require_relative '../lib/triviacrack/game_statistics'
+require_relative '../lib/triviacrack/profile'
+require_relative '../lib/triviacrack/question'
+require_relative '../lib/triviacrack/session'
+require_relative '../lib/triviacrack/user'
+
+require_relative '../lib/triviacrack/api/client'
+require_relative '../lib/triviacrack/api/game'
+require_relative '../lib/triviacrack/api/login'
+require_relative '../lib/triviacrack/api/profile'
+require_relative '../lib/triviacrack/api/question'
+require_relative '../lib/triviacrack/api/user'
+
+require_relative '../lib/triviacrack/errors/parse_error'
+require_relative '../lib/triviacrack/errors/request_error'
+
+require_relative '../lib/triviacrack/parsers/category_statistics_parser'
+require_relative '../lib/triviacrack/parsers/game_parser'
+require_relative '../lib/triviacrack/parsers/game_statistics_parser'
+require_relative '../lib/triviacrack/parsers/profile_parser'
+require_relative '../lib/triviacrack/parsers/question_parser'
+require_relative '../lib/triviacrack/parsers/session_parser'
+require_relative '../lib/triviacrack/parsers/user_parser'
 
 class SpecData
-
   def self.get(filename)
     File.read(File.expand_path("../data/#{filename}", __FILE__))
   end
@@ -40,13 +41,10 @@ class SpecData
     file = File.read(File.expand_path("../data/#{filename}", __FILE__))
     JSON.parse(file)
   end
-
 end
 
 class APIStub
-
   def initialize(session = nil)
     @session = session
   end
-
 end

data/spec/user_spec.rb

@@ -1,12 +1,12 @@
-require_relative "spec_helper"
+# frozen_string_literal: true
 
-describe TriviaCrack::User do
+require_relative 'spec_helper'
 
+describe TriviaCrack::User do
   let(:user_id) { 111 }
   let(:user) { TriviaCrack::User.new id: user_id, lives: lives, unlimited_lives: unlimited_lives }
 
-  describe "#start_new_game?" do
-
+  describe '#start_new_game?' do
     subject { user.start_new_game? }
 
     context 'when the user has one or more live' do

data/triviacrack.gemspec

@@ -1,32 +1,33 @@
-# coding: utf-8
-lib = File.expand_path('../lib', __FILE__)
+# frozen_string_literal: true
+
+lib = File.expand_path('lib', __dir__)
 $LOAD_PATH.unshift(lib) unless $LOAD_PATH.include?(lib)
 require 'triviacrack/version'
 
 Gem::Specification.new do |spec|
-  spec.name          = "triviacrack"
+  spec.name          = 'triviacrack'
   spec.version       = TriviaCrack::VERSION
-  spec.authors       = ["David Kus"]
-  spec.email         = ["david@kus.dk"]
-  spec.summary       = %q{A Ruby interface to the Trivia Crack API.}
-  spec.description   = %q{A Ruby interface to the Trivia Crack API.}
-  spec.homepage      = "https://github.com/davidkus/triviacrack"
-  spec.license       = "MIT"
+  spec.authors       = ['David Kus']
+  spec.email         = ['david@kus.dk']
+  spec.summary       = 'A Ruby interface to the Trivia Crack API.'
+  spec.description   = 'A Ruby interface to the Trivia Crack API.'
+  spec.homepage      = 'https://github.com/davidkus/triviacrack'
+  spec.license       = 'MIT'
 
   spec.files         = `git ls-files -z`.split("\x0")
   spec.executables   = spec.files.grep(%r{^bin/}) { |f| File.basename(f) }
-  spec.test_files    = spec.files.grep(%r{^(test|spec|features)/})
-  spec.require_paths = ["lib"]
+  spec.require_paths = ['lib']
 
-  spec.required_ruby_version = ">= 2.0"
+  spec.required_ruby_version = '>= 2.5'
 
-  spec.add_development_dependency "bundler", "~> 2.2.27"
-  spec.add_development_dependency "simplecov", "~> 0.21.2"
-  spec.add_development_dependency "rake", "~> 13.0.6"
-  spec.add_development_dependency "rspec", "~> 3.10.0"
-  spec.add_development_dependency "rspec-its", "~> 1.3.0"
-  spec.add_development_dependency "fuubar", "~> 2.5.1"
+  spec.add_development_dependency 'bundler', '~> 2.3.18'
+  spec.add_development_dependency 'fuubar', '~> 2.5.1'
+  spec.add_development_dependency 'rake', '~> 13.0.6'
+  spec.add_development_dependency 'rspec', '~> 3.10.0'
+  spec.add_development_dependency 'rspec-its', '~> 1.3.0'
+  spec.add_development_dependency 'rubocop', '~> 1.31.2'
+  spec.add_development_dependency 'simplecov', '~> 0.21.2'
 
-  spec.add_dependency "json", "~> 2.5.1"
-  spec.add_dependency "faraday", "~> 1.7.2"
+  spec.add_dependency 'faraday', '~> 1.7.2'
+  spec.add_dependency 'json', '~> 2.5.1'
 end