triviacrack 0.2.0 → 0.3.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 528d22e9dbd73fd60d40d2de5ee7fe22ab03a8463d0d324ff07c9c27898a3b30
-  data.tar.gz: fce027f935aa56b814a0d23bde2c325b9df4cbe6d583204050212752412cc3e1
+  metadata.gz: 92b5c77a56e170172762ed6a3c145743b913128803db0980fe500d23f355dfc8
+  data.tar.gz: 64e7b4d9ca31159378e038bcd5892a8caed86f053ad0550ac026d1d74ca6bad8
 SHA512:
-  metadata.gz: 526eb31bc72c77fefdd42846f83192c94df7a71ba340e272ca970d6be4205a99cc03ba81acd9c7b4295d771f5cee44a373a6d63b18714cbb50556b7db088dd06
-  data.tar.gz: a7fad7895865826a8abec5392c125723f9243cd8995624bf65f246f8ffdfe2d264f91961ca85a6a5bf0d48d4a41936020aef6eeec43ad37333fa19fe5f91ac45
+  metadata.gz: 5ab48a4eb4d28486d4a898bea402ece598b3643e0dad5ca2f19eddc35bbadf3a7aac55ac181d21949a88ea0bb18ccfeb9064ee63eb5231247c46f06e8cd94f15
+  data.tar.gz: ca05c593330b0b7ddad16214c3bedc8c3e211d0eba02004f17447832f09ae083fe5117e151fab833818b872e358bc350e3634c61ccb4e67fa63881542469df97

data/lib/triviacrack/api/common.rb

@@ -19,7 +19,7 @@ module TriviaCrack
         response = Unirest.get "#{API_HOST}#{url}", parameters: parameters,
                                                     headers: default_headers
 
-        check_response response
+        check_response url, response
       end
 
       # Internal: Makes a POST request to the Trivia Crack API using the set of
@@ -34,7 +34,7 @@ module TriviaCrack
         response = Unirest.post "#{API_HOST}#{url}", parameters: parameters,
                                                      headers: default_headers
 
-        check_response response
+        check_response url, response
       end
 
       private
@@ -63,10 +63,10 @@ module TriviaCrack
       #
       # Returns the response object.
       # Raises TriviaCrack:Errors::RequestError if the request failed.
-      def check_response(response)
+      def check_response(url, response)
         if not response.code.between? 200, 299
-          raise TriviaCrack::Errors::RequestError.new(response.code),
-            "Request to the Trivia Crack API failed."
+          raise TriviaCrack::Errors::RequestError.new(response.code, url, response.body),
+            "Request to #{API_HOST}#{url} failed with code #{response.code}."
         end
 
         response

data/lib/triviacrack/errors/request_error.rb

@@ -7,11 +7,20 @@ module TriviaCrack
       # Public: The HTTP status code returned by the Trivia Crack server.
       attr_reader :code
 
+      #Public: The URL that was requested.
+      attr_reader :url
+
+      #Public: The response body that was returned by the Trivia Crack server.
+      attr_reader :body
+
       # Public: Initializes a RequestError.
       #
       # code - The HTTP status code returned by the Trivia Crack server.
-      def initialize(code)
+      # url - The URL that was requested.
+      # body - The response body that was returned by the Trivia Crack server.
+      def initialize(code, url, body)
         @code = code
+        @url = url
       end
     end
   end

data/lib/triviacrack/version.rb

@@ -1,4 +1,4 @@
 # Public: The version of this gem.
 module TriviaCrack
-  VERSION = "0.2.0"
+  VERSION = "0.3.0"
 end

data/spec/api/game_spec.rb

@@ -27,12 +27,17 @@ describe TriviaCrack::API::Game do
       let(:code) { 400 }
 
       it { expect{ subject }.to raise_error TriviaCrack::Errors::RequestError }
+      it { expect{ subject }.to raise_error(an_instance_of(TriviaCrack::Errors::RequestError)
+        .and having_attributes(code: 400)) }
+      it { expect{ subject }.to raise_error(an_instance_of(TriviaCrack::Errors::RequestError)
+        .and having_attributes(url: "/api/users/#{session.user_id}/dashboard")) }
     end
   end
 
   describe "#get_game" do
+    let(:game_id) { 123 }
 
-    subject { client.get_game 123 }
+    subject { client.get_game game_id }
 
     let(:raw_data) { SpecData.get "game.json" }
 
@@ -47,6 +52,10 @@ describe TriviaCrack::API::Game do
       let(:code) { 400 }
 
       it { expect{ subject }.to raise_error TriviaCrack::Errors::RequestError }
+      it { expect{ subject }.to raise_error(an_instance_of(TriviaCrack::Errors::RequestError)
+        .and having_attributes(code: code)) }
+      it { expect{ subject }.to raise_error(an_instance_of(TriviaCrack::Errors::RequestError)
+        .and having_attributes(url: "/api/users/#{session.user_id}/games/#{game_id}")) }
     end
   end
 
@@ -67,6 +76,10 @@ describe TriviaCrack::API::Game do
       let(:code) { 400 }
 
       it { expect{ subject }.to raise_error TriviaCrack::Errors::RequestError }
+      it { expect{ subject }.to raise_error(an_instance_of(TriviaCrack::Errors::RequestError)
+        .and having_attributes(code: code)) }
+      it { expect{ subject }.to raise_error(an_instance_of(TriviaCrack::Errors::RequestError)
+        .and having_attributes(url: "/api/users/#{session.user_id}/games")) }
     end
   end
 end

data/spec/api/login_spec.rb

@@ -25,10 +25,14 @@ describe TriviaCrack::API::Login do
       its(:session_id) { is_expected.to eq "session123" }
     end
 
-    context 'given that the request is fails' do
+    context 'given that the request fails' do
       let(:code) { 400 }
 
       it { expect{ subject }.to raise_error TriviaCrack::Errors::RequestError }
+      it { expect{ subject }.to raise_error(an_instance_of(TriviaCrack::Errors::RequestError)
+        .and having_attributes(code: code)) }
+      it { expect{ subject }.to raise_error(an_instance_of(TriviaCrack::Errors::RequestError)
+        .and having_attributes(url: '/api/login')) }
     end
   end
 end

data/spec/api/profile_spec.rb

@@ -10,8 +10,9 @@ describe TriviaCrack::API::Profile do
   before { allow(Unirest).to receive(:get) { response } }
 
   describe "#get_profile" do
+    let(:user_id) { 111 }
 
-    subject { client.get_profile 111 }
+    subject { client.get_profile user_id }
 
     let(:raw_data) { SpecData.get "profile.json" }
 
@@ -26,6 +27,10 @@ describe TriviaCrack::API::Profile do
       let(:code) { 400 }
 
       it { expect{ subject }.to raise_error TriviaCrack::Errors::RequestError }
+      it { expect{ subject }.to raise_error(an_instance_of(TriviaCrack::Errors::RequestError)
+        .and having_attributes(code: code)) }
+      it { expect{ subject }.to raise_error(an_instance_of(TriviaCrack::Errors::RequestError)
+        .and having_attributes(url: "/api/users/#{session.user_id}/profiles/#{user_id}")) }
     end
   end
 
@@ -46,6 +51,10 @@ describe TriviaCrack::API::Profile do
       let(:code) { 400 }
 
       it { expect{ subject }.to raise_error TriviaCrack::Errors::RequestError }
+      it { expect{ subject }.to raise_error(an_instance_of(TriviaCrack::Errors::RequestError)
+        .and having_attributes(code: code)) }
+      it { expect{ subject }.to raise_error(an_instance_of(TriviaCrack::Errors::RequestError)
+        .and having_attributes(url: "/api/users/#{session.user_id}/profiles/#{session.user_id}")) }
     end
   end
 end

data/spec/api/question_spec.rb

@@ -40,6 +40,10 @@ describe TriviaCrack::API::Question do
       let(:answer) { 1 }
 
       it { expect{ subject }.to raise_error TriviaCrack::Errors::RequestError }
+      it { expect{ subject }.to raise_error(an_instance_of(TriviaCrack::Errors::RequestError)
+        .and having_attributes(code: code)) }
+      it { expect{ subject }.to raise_error(an_instance_of(TriviaCrack::Errors::RequestError)
+        .and having_attributes(url: "/api/users/#{session.user_id}/games/#{game_id}/answers")) }
     end
   end
 end

data/spec/api/user_spec.rb

@@ -10,8 +10,9 @@ describe TriviaCrack::API::User do
   before { allow(Unirest).to receive(:get) { response } }
 
   describe "#get_user_id" do
+    let(:username) { "example.2" }
 
-    subject { client.get_user_id "example.2" }
+    subject { client.get_user_id username }
 
     let(:raw_data) { SpecData.get "search.json" }
 
@@ -25,6 +26,10 @@ describe TriviaCrack::API::User do
       let(:code) { 400 }
 
       it { expect{ subject }.to raise_error TriviaCrack::Errors::RequestError }
+      it { expect{ subject }.to raise_error(an_instance_of(TriviaCrack::Errors::RequestError)
+        .and having_attributes(code: code)) }
+      it { expect{ subject }.to raise_error(an_instance_of(TriviaCrack::Errors::RequestError)
+        .and having_attributes(url: "/api/search?username=#{username}")) }
     end
   end
 
@@ -45,6 +50,10 @@ describe TriviaCrack::API::User do
       let(:code) { 400 }
 
       it { expect{ subject }.to raise_error TriviaCrack::Errors::RequestError }
+      it { expect{ subject }.to raise_error(an_instance_of(TriviaCrack::Errors::RequestError)
+        .and having_attributes(code: code)) }
+      it { expect{ subject }.to raise_error(an_instance_of(TriviaCrack::Errors::RequestError)
+        .and having_attributes(url: "/api/users/#{session.user_id}")) }
     end
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: triviacrack
 version: !ruby/object:Gem::Version
-  version: 0.2.0
+  version: 0.3.0
 platform: ruby
 authors:
 - David Kus
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2020-02-24 00:00:00.000000000 Z
+date: 2020-03-06 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler