trino-client 2.2.5 → 2.2.6

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 52373d10e6b2a747763c91f89a5f2da08824fa239b97808b6fb50229f0501b6b
-  data.tar.gz: 15678aba8084b3ed6845c5784d7fcc2d68699ad5f002776d6fd5897206f2bf23
+  metadata.gz: 69f501fb237b50a19cab4a4ca36e5702ce0b6852aa4f47c28cc58ee2bf9b0b56
+  data.tar.gz: 0505db32b400bd17516b49b7c151c5717a95cd6316f3a0a91258409e483822c3
 SHA512:
-  metadata.gz: 83a93c0ed41734746f4e69a0b752c7acb978b143188e4d088ef348632ebb2df040b523eae8243b31ee1a94908d61444591405fa0d5f06cfecb2e5767e6d974d4
-  data.tar.gz: 32dfdb8fb542c3cd8b7ebe3e01678baa2f2146c21e05a30c185b8a27b84845be96a2a3b57471bb8e667edf9c1a9449354b59e72b9149d4978cd7b8a223a55dc4
+  metadata.gz: f31ffb1267de01b418f3a39c244dcf34dc8f3dd2d5d3bff3e15c6dc6b8aef1c701ec70ac46c5b85f08a1de89094e0be0198439083e9a57b337bb72c6c3f549e7
+  data.tar.gz: 77aeab61775faadb4cd79f567089cb3cfd25c86e3a6d5469ae82da589ad2b88ca59f5e982c49d9aba3832960dc50c1236246913098bc1422587e80cdebb1e475

data/ChangeLog.md

@@ -1,5 +1,15 @@
 trino-client-ruby
 ====
+## 2.2.6
+- fix: improve POST retry tests and document idempotency assumption ([#159](https://github.com/treasure-data/trino-client-ruby/issues/159)) [[e64c2a9](https://github.com/treasure-data/trino-client-ruby/commit/e64c2a9)]
+- Add retry to POST /v1/statement ([#157](https://github.com/treasure-data/trino-client-ruby/issues/157)) [[64a5c66](https://github.com/treasure-data/trino-client-ruby/commit/64a5c66)]
+- Update psych requirement from ~> 3 to ~> 5 ([#140](https://github.com/treasure-data/trino-client-ruby/issues/140)) [[eeb3333](https://github.com/treasure-data/trino-client-ruby/commit/eeb3333)]
+- Update dependabot.yaml to change the update interval from weekly to monthly and set commit message prefix to "chore". [[2fde3f2](https://github.com/treasure-data/trino-client-ruby/commit/2fde3f2)]
+- Minor fix [[db03c07](https://github.com/treasure-data/trino-client-ruby/commit/db03c07)]
+- Update addressable requirement from ~> 2.8.1 to ~> 2.9.0 [[1a56064](https://github.com/treasure-data/trino-client-ruby/commit/1a56064)]
+- Update README.md for release instructions [skip ci] [[dda6a06](https://github.com/treasure-data/trino-client-ruby/commit/dda6a06)]
+- v2.2.5 [[12ce8e8](https://github.com/treasure-data/trino-client-ruby/commit/12ce8e8)]
+
 ## 2.2.5
 - Merge pull request [#155](https://github.com/treasure-data/trino-client-ruby/issues/155) from murakami-ta/add-http-debug-logger-option [[143a801](https://github.com/treasure-data/trino-client-ruby/commit/143a801)]
 - Fix http_debug_logger test to work with both Faraday 1 and 2 [[0976be7](https://github.com/treasure-data/trino-client-ruby/commit/0976be7)]

data/README.md

@@ -126,20 +126,17 @@ See [RDoc](http://www.rubydoc.info/gems/presto-client/) for the full documentati
 
 ### Releasing a new version
 
-1. First update `lib/trino/client/version.rb` to the next version.
-2. Run the following command which will update `ChangeLog.md` file automatically.
+1. Run the following command which will prompt for the new version, update `lib/trino/client/version.rb`, and generate/let you edit `ChangeLog.md`.
 ```
 $ ruby release.rb
 ```
 
-3. Create tag
+2. Commit and tag
 ```
 $ git commit -am "vX.Y.Z"
 $ git tag "vX.Y.Z"
-% git push --tags
+$ git push origin master
+$ git push --tags
 ```
 
-4. Push package by the following command which will build and push `trino-client-X.Y.Z.gem` and `trino-client-ruby-X.Y.Z.gem` automatically.
-```
-$ ruby publish.rb
-```
+Pushing a `v*` tag triggers the GitHub Actions publisher workflow, which automatically builds and publishes the gem to RubyGems.org.

data/lib/trino/client/statement_client.rb

@@ -26,6 +26,8 @@ module Trino::Client
         :max_nesting => false
     }
 
+    RETRYABLE_STATUSES = [502, 503, 504]
+
     def initialize(faraday, query, options, next_uri=nil)
       @faraday = faraday
 
@@ -66,16 +68,31 @@ module Trino::Client
 
     def post_query_request!
       uri = "/v1/statement"
-      response = @faraday.post do |req|
-        req.url uri
+      response = with_retry_loop do
+        begin
+          r = @faraday.post do |req|
+            req.url uri
 
-        req.body = @query
-        init_request(req)
-      end
+            req.body = @query
+            init_request(req)
+          end
+        rescue Faraday::TimeoutError, Faraday::ConnectionFailed
+          # POST /v1/statement is not idempotent; retrying transport-level errors
+          # (timeouts/connection failures) can submit duplicate queries. This is
+          # intentional under the assumption the failure happened before Trino
+          # received the request (e.g. rejected by a load balancer upstream).
+          throw :retry_with_backoff
+        rescue => e
+          exception! e
+        end
 
-      # TODO error handling
-      if response.status != 200
-        exception! TrinoHttpError.new(response.status, "Failed to start query: #{response.body} (#{response.status})")
+        if r.status == 200
+          r
+        elsif RETRYABLE_STATUSES.include?(r.status)
+          throw :retry_with_backoff
+        else
+          exception! TrinoHttpError.new(r.status, "Failed to start query: #{r.body} (#{r.status})")
+        end
       end
 
       @results_headers = response.headers
@@ -189,31 +206,12 @@ module Trino::Client
 
     private :parse_body
 
-    def faraday_get_with_retry(uri, &block)
+    def with_retry_loop
       start = Process.clock_gettime(Process::CLOCK_MONOTONIC)
       attempts = 0
 
       loop do
-        begin
-          response = @faraday.get(uri)
-        rescue Faraday::TimeoutError, Faraday::ConnectionFailed
-          # temporally error to retry
-          response = nil
-        rescue => e
-          exception! e
-        end
-
-        if response
-          if response.status == 200 && !response.body.to_s.empty?
-            return response
-          end
-
-          # retry if 502, 503, 504 according to the trino protocol
-          unless [502, 503, 504].include?(response.status)
-            # deterministic error
-            exception! TrinoHttpError.new(response.status, "Trino API error at #{uri} returned #{response.status}: #{response.body}")
-          end
-        end
+        catch(:retry_with_backoff) { return yield }
 
         raise_if_timeout!
 
@@ -226,6 +224,28 @@ module Trino::Client
       exception! TrinoHttpError.new(408, "Trino API error due to timeout")
     end
 
+    private :with_retry_loop
+
+    def faraday_get_with_retry(uri)
+      with_retry_loop do
+        begin
+          response = @faraday.get(uri)
+        rescue Faraday::TimeoutError, Faraday::ConnectionFailed
+          throw :retry_with_backoff
+        rescue => e
+          exception! e
+        end
+
+        if response.status == 200 && !response.body.to_s.empty?
+          response
+        elsif RETRYABLE_STATUSES.include?(response.status)
+          throw :retry_with_backoff
+        else
+          exception! TrinoHttpError.new(response.status, "Trino API error at #{uri} returned #{response.status}: #{response.body}")
+        end
+      end
+    end
+
     def raise_if_timeout!
       if @started_at
         return if finished?

data/lib/trino/client/version.rb

@@ -15,6 +15,6 @@
 #
 module Trino
   module Client
-    VERSION = "2.2.5"
+    VERSION = "2.2.6"
   end
 end

data/trino-client.gemspec

@@ -29,8 +29,8 @@ Gem::Specification.new do |gem|
   gem.add_development_dependency "rake", [">= 0.9.2", "< 14.0"]
   gem.add_development_dependency "rspec", "~> 3.13.0"
   gem.add_development_dependency "webmock", ["~> 3.0"]
-  gem.add_development_dependency "addressable", "~> 2.8.1" # 2.5.0 doesn't support Ruby 1.9.3
+  gem.add_development_dependency "addressable", "~> 2.9.0"
   gem.add_development_dependency "simplecov", "~> 0.22.0"
   gem.add_development_dependency "standard", "~> 1.54.0"
-  gem.add_development_dependency "psych", "~> 3"
+  gem.add_development_dependency "psych", "~> 5"
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: trino-client
 version: !ruby/object:Gem::Version
-  version: 2.2.5
+  version: 2.2.6
 platform: ruby
 authors:
 - Sadayuki Furuhashi
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2026-05-27 00:00:00.000000000 Z
+date: 2026-06-08 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: faraday
@@ -126,14 +126,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 2.8.1
+        version: 2.9.0
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 2.8.1
+        version: 2.9.0
 - !ruby/object:Gem::Dependency
   name: simplecov
   requirement: !ruby/object:Gem::Requirement
@@ -168,14 +168,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '3'
+        version: '5'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '3'
+        version: '5'
 description: Trino client library
 email:
 - sf@treasure-data.com