trinidad_valve_extension 0.3 → 0.4

data/History.txt

@@ -1,3 +1,7 @@
+== 0.4.0 (2011-09-22)
+
+* Better error messaging when incorrect types or properties are configured
+
 == 0.3.0 (2011-09-20)
 
 * Correct hardcoded valve name to use variable

data/lib/trinidad_valve_extension.rb

@@ -1,12 +1,12 @@
 module Trinidad
   module Extensions
     module Valve
-      VERSION = '0.3'
+      VERSION = '0.4'
     end
 
     class ValveWebAppExtension < WebAppExtension
       def configure(tomcat, app_context)
-        logger = app_context.logger
+        @logger = app_context.logger
 
         @options[:valves] ||= Array.new
 
@@ -16,14 +16,14 @@ module Trinidad
             class_name = valve_properties.delete 'className'
 
             if not class_name
-              logger.warn("Tomcat valve defined without a 'className' attribute.  Skipping valve definition: '#{valve_properties.inspect}'")
+              @logger.warn("Tomcat valve defined without a 'className' attribute.  Skipping valve definition: '#{valve_properties.inspect}'")
               next
             end
 
             begin
               valve = get_valve(class_name)
             rescue NameError => e
-              logger.warn("Tomcat valve '#{class_name}' not found.  Ensure valve exists in your classpath")
+              @logger.warn("Tomcat valve '#{class_name}' not found.  Ensure valve exists in your classpath")
               next
             end
 
@@ -42,7 +42,17 @@ module Trinidad
 
       def set_valve_properties(valve_instance, properties)
         properties.each do |option,value|
-          valve_instance.send("#{option}=", replace_properties(value.to_s))
+          begin
+            if value.kind_of? String
+              value = replace_properties(value)
+            end
+          valve_instance.send("#{option}=", value)
+
+          rescue TypeError => e
+            @logger.warn("Incorrect type passed for property '#{option}' on valve '#{valve_instance.java_class}'. Skipping property")
+          rescue NoMethodError => e
+            @logger.warn("No settable property '#{option}' found on valve '#{valve_instance.java_class}'")
+          end
         end
       end
 

data/trinidad_valve_extension.gemspec

@@ -13,8 +13,8 @@ Gem::Specification.new do |s|
   ## If your rubyforge_project name is different, then edit it and comment out
   ## the sub! line in the Rakefile
   s.name              = 'trinidad_valve_extension'
-  s.version           = '0.3'
-  s.date              = '2011-08-20'
+  s.version           = '0.4'
+  s.date              = '2011-08-22'
   s.rubyforge_project = 'trinidad_valve_extension'
 
   ## Make sure your summary is short. The description may be as long

metadata

@@ -4,8 +4,8 @@ version: !ruby/object:Gem::Version
   prerelease: false
   segments: 
   - 0
-  - 3
-  version: "0.3"
+  - 4
+  version: "0.4"
 platform: ruby
 authors: 
 - Michael Leinartas
@@ -13,7 +13,7 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2011-08-20 00:00:00 -05:00
+date: 2011-08-22 00:00:00 -05:00
 default_executable: 
 dependencies: 
 - !ruby/object:Gem::Dependency