triggerable 0.1.7 → 0.1.8

data/lib/triggerable/conditions/predicate/or.rb

@@ -1,7 +1,16 @@
-module Conditions
-  class Or < PredicateCondition
-    def true_for? object
-      true_conditions(object).any?
+module Triggerable
+  module Conditions
+    class Or < PredicateCondition
+      def true_for? object
+        true_conditions(object).any?
+      end
+
+      def desc
+        @conditions.map do |c|
+          desc = c.try(:desc)
+          desc ? "(#{desc})" : c
+        end.join(' || ')
+      end
     end
   end
 end

data/lib/triggerable/conditions/predicate/predicate_condition.rb

@@ -1,45 +1,47 @@
-module Conditions
-  class PredicateCondition < Condition
-    attr_accessor :conditions
-
-    def initialize conditions
-      @conditions = conditions.map do |condition|
-        unless condition.is_a?(Hash)
-          condition
-        else
-          field     = condition.keys.first
-          statement = condition.values.first
-
-          Condition.build({field => statement})
+module Triggerable
+  module Conditions
+    class PredicateCondition < Condition
+      attr_accessor :conditions
+
+      def initialize conditions
+        @conditions = conditions.map do |condition|
+          unless condition.is_a?(Hash)
+            condition
+          else
+            field     = condition.keys.first
+            statement = condition.values.first
+
+            Condition.build({field => statement})
+          end
         end
       end
-    end
 
-    def scope table
-      predicate_scope = nil
+      def scope table
+        predicate_scope = nil
 
-      @conditions.each_with_index do |condition, index|
-        condition_scope = condition.scope(table)
+        @conditions.each_with_index do |condition, index|
+          condition_scope = condition.scope(table)
 
-        predicate_scope = if index.zero?
-          condition_scope
-        else
-          predicate_scope.send(predicate_name, condition_scope)
+          predicate_scope = if index.zero?
+            condition_scope
+          else
+            predicate_scope.send(predicate_name, condition_scope)
+          end
         end
-      end
 
-      predicate_scope
-    end
+        predicate_scope
+      end
 
-    protected
+      protected
 
-    def predicate_name
-      self.class.name.demodulize.downcase
-    end
+      def predicate_name
+        self.class.name.demodulize.downcase
+      end
 
-    def true_conditions object
-      @conditions.select do |c|
-        c.is_a?(Symbol) ? object.send(c) : c.true_for?(object)
+      def true_conditions object
+        @conditions.select do |c|
+          c.is_a?(Symbol) ? object.send(c) : c.true_for?(object)
+        end
       end
     end
   end

data/lib/triggerable/conditions/schedule/after.rb

@@ -1,20 +1,22 @@
-module Conditions
-  class After < ScheduleCondition
-    def from
-      automation_time - @value - Engine.interval
-    end
+module Triggerable
+  module Conditions
+    class After < ScheduleCondition
+      def from
+        automation_time - @value - Triggerable::Engine.interval
+      end
 
-    def to
-      automation_time - @value
-    end
+      def to
+        automation_time - @value
+      end
 
-    private
+      private
 
-    def condition
-      And.new [
-        GreaterThan.new(@field, from),
-        LessThanOrEqualTo.new(@field, to)
-      ]
+      def condition
+        And.new [
+          GreaterThan.new(@field, from),
+          LessThanOrEqualTo.new(@field, to)
+        ]
+      end
     end
   end
-end
+end

data/lib/triggerable/conditions/schedule/before.rb

@@ -1,20 +1,22 @@
-module Conditions
-  class Before < ScheduleCondition
-    def from
-      automation_time + @value
-    end
+module Triggerable
+  module Conditions
+    class Before < ScheduleCondition
+      def from
+        automation_time + @value
+      end
 
-    def to
-      automation_time + @value + Engine.interval
-    end
+      def to
+        automation_time + @value + Triggerable::Engine.interval
+      end
 
-    private
+      private
 
-    def condition
-      And.new [
-        GreaterThanOrEqualTo.new(@field, from),
-        LessThan.new(@field, to)
-      ]
+      def condition
+        And.new [
+          GreaterThanOrEqualTo.new(@field, from),
+          LessThan.new(@field, to)
+        ]
+      end
     end
   end
-end
+end

data/lib/triggerable/conditions/schedule/schedule_condition.rb

@@ -1,24 +1,26 @@
-module Conditions
-  class ScheduleCondition < FieldCondition
-    def initialize field, value
-      @value = value.values.first if value.is_a?(Hash)
-      super
-    end
+module Triggerable
+  module Conditions
+    class ScheduleCondition < FieldCondition
+      def initialize field, value
+        @value = value.values.first if value.is_a?(Hash)
+        super
+      end
 
-    def true_for? object
-      condition.true_for?(object)
-    end
+      def true_for? object
+        condition.true_for?(object)
+      end
 
-    def scope table
-      condition.scope(table)
-    end
+      def scope table
+        condition.scope(table)
+      end
 
-    protected
+      protected
 
-    # automation_time is Time.now rounded by Engine.interval
-    def automation_time
-      i = Engine.interval
-      Time.at((Time.now.to_i / i) * i).utc
+      # automation_time is Time.now rounded by Engine.interval
+      def automation_time
+        i = Triggerable::Engine.interval
+        Time.at((Time.now.to_i / i) * i).utc
+      end
     end
   end
-end
+end

data/lib/triggerable/engine.rb

@@ -1,28 +1,41 @@
-class Engine
-  cattr_accessor :triggers, :automations, :interval
+require 'logger'
 
-  self.triggers    = []
-  self.automations = []
+module Triggerable
+  class Engine
+    cattr_accessor :triggers,
+                   :automations,
+                   :interval,
+                   :logger,
+                   :debug
 
-  def self.trigger model, options, block
-    self.triggers << Rules::Trigger.new(model, options, block)
-  end
+    self.triggers    = []
+    self.automations = []
 
-  def self.automation model, options, block
-    self.automations << Rules::Automation.new(model, options, block)
-  end
+    def self.trigger model, options, block
+      self.triggers << Rules::Trigger.new(model, options, block)
+    end
 
-  def self.triggers_for obj, callback
-    triggers.select { |t| obj.class.name == t.model.name && t.callback == callback }
-  end
+    def self.automation model, options, block
+      self.automations << Rules::Automation.new(model, options, block)
+    end
 
-  def self.run_automations interval
-    self.interval = interval
-    automations.each(&:execute!)
-  end
+    def self.triggers_for obj, callback
+      triggers.select { |t| obj.class.name == t.model.name && t.callback == callback }
+    end
 
-  def self.clear
-    self.triggers    = []
-    self.automations = []
+    def self.run_automations interval
+      self.interval = interval
+      automations.each(&:execute!)
+    end
+
+    def self.clear
+      self.triggers    = []
+      self.automations = []
+    end
+
+    def self.log level, message
+      puts message if debug
+      logger.send(level, "#{Time.now.strftime('%FT%T%z')}: #{message}") if logger.present?
+    end
   end
 end

data/lib/triggerable/rules/automation.rb

@@ -1,13 +1,33 @@
-module Rules
-  class Automation < Rule
-    def execute!
-      table = Arel::Table.new(model.table_name)
-      scope = @condition.scope(table)
-      query = table.where(scope).project(Arel.sql('id')).to_sql
-      ids = ActiveRecord::Base.connection.execute(query).map { |r| r['id'] }
-      models = model.where(id: ids)
-
-      models.each {|object| actions.each {|a| a.run_for!(object, name)} }
+module Triggerable
+  module Rules
+    class Automation < Rule
+      def execute!
+        ids = ActiveRecord::Base.connection.execute(build_query).map { |r| r['id'] }
+        models = model.where(id: ids)
+
+        Triggerable::Engine.log(:debug, "#{desc}: processing #{models.count} object(s)")
+
+        models.each do |object|
+          begin
+            actions.each {|a| a.run_for!(object, name)}
+          rescue Exception => ex
+            Triggerable::Engine.log(:error, "#{desc} failed with exception #{ex}")
+          end
+        end
+      end
+
+      private
+
+      def build_query
+        table = Arel::Table.new(model.table_name)
+        query = table.where(@condition.scope(table))
+                     .project(Arel.sql('id'))
+                     .to_sql
+
+        Triggerable::Engine.log(:debug, "#{desc}: #{query}")
+
+        query
+      end
     end
   end
-end
+end

data/lib/triggerable/rules/rule.rb

@@ -1,12 +1,24 @@
-module Rules
-  class Rule
-    attr_accessor :name, :model, :condition, :actions
-
-    def initialize model, options, block
-      @model     = model
-      @condition = Conditions::Condition.build(options[:if])
-      @name      = options[:name]
-      @actions   = Triggerable::Action.build(block || options[:do])
+module Triggerable
+  module Rules
+    class Rule
+      attr_accessor :name, :model, :condition, :actions
+
+      def initialize model, options, block
+        @model     = model
+        @condition = Conditions::Condition.build(options[:if])
+        @name      = options[:name]
+        @actions   = Triggerable::Actions::Action.build(block || options[:do])
+      end
+
+      protected
+
+      def desc
+        "#{self.class.name} #{name || self}(#{model})"
+      end
+
+      def debug?
+        Triggerable::Engine.debug
+      end
     end
   end
 end

data/lib/triggerable/rules/trigger.rb

@@ -1,14 +1,24 @@
-module Rules
-  class Trigger < Rule
-    attr_accessor :callback
+module Triggerable
+  module Rules
+    class Trigger < Rule
+      attr_accessor :callback
 
-    def initialize model, options, block
-      super
-      @callback  = options[:on]
-    end
+      def initialize model, options, block
+        super
+        @callback  = options[:on]
+      end
+
+      def execute! object
+        return unless condition.true_for?(object)
 
-    def execute! object
-      actions.each {|a| a.run_for!(object, name)} if condition.true_for?(object)
+        actions.each do |action|
+          begin
+            action.run_for!(object, name)
+          rescue Exception => ex
+            Triggerable::Engine.log(:error, "#{desc} failed with exception #{ex}")
+          end
+        end
+      end
     end
   end
 end

data/lib/triggerable/version.rb

@@ -1,3 +1,3 @@
 module Triggerable
-  VERSION = '0.1.7'
+  VERSION = '0.1.8'
 end

data/spec/conditions_spec.rb

@@ -1,6 +1,6 @@
 require 'spec_helper'
 
-describe Conditions do
+describe Triggerable::Conditions do
   before(:each) do
     class Sample; attr_accessor(:field); end
     @obj = Sample.new
@@ -9,11 +9,11 @@ describe Conditions do
   context 'is' do
 
     def check_value value
-      Conditions::Is.new(:field, value).true_for?(@obj)
+      Triggerable::Conditions::Is.new(:field, value).true_for?(@obj)
     end
 
     def scope value
-      Conditions::Is.new(:field, value).scope
+      Triggerable::Conditions::Is.new(:field, value).scope
     end
 
     it 'integer' do
@@ -36,11 +36,11 @@ describe Conditions do
   context 'is_not' do
 
     def check_value value
-      Conditions::IsNot.new(:field, value).true_for?(@obj)
+      Triggerable::Conditions::IsNot.new(:field, value).true_for?(@obj)
     end
 
     def scope value
-      Conditions::IsNot.new(:field, value).scope
+      Triggerable::Conditions::IsNot.new(:field, value).scope
     end
 
     it 'integer' do
@@ -62,11 +62,11 @@ describe Conditions do
 
   context 'greater_than' do
     def check_value value
-      Conditions::GreaterThan.new(:field, value).true_for?(@obj)
+      Triggerable::Conditions::GreaterThan.new(:field, value).true_for?(@obj)
     end
 
     def scope value
-      Conditions::GreaterThan.new(:field, value).scope
+      Triggerable::Conditions::GreaterThan.new(:field, value).scope
     end
 
     it 'integer' do
@@ -90,11 +90,11 @@ describe Conditions do
 
   context 'less_than' do
     def check_value value
-      Conditions::LessThan.new(:field, value).true_for?(@obj)
+      Triggerable::Conditions::LessThan.new(:field, value).true_for?(@obj)
     end
 
     def scope value
-      Conditions::LessThan.new(:field, value).scope
+      Triggerable::Conditions::LessThan.new(:field, value).scope
     end
 
     it 'integer' do
@@ -118,11 +118,11 @@ describe Conditions do
 
   context 'in' do
     def check_value value
-      Conditions::In.new(:field, value).true_for?(@obj)
+      Triggerable::Conditions::In.new(:field, value).true_for?(@obj)
     end
 
     def scope value
-      Conditions::In.new(:field, value).scope
+      Triggerable::Conditions::In.new(:field, value).scope
     end
 
     it 'integer' do
@@ -160,7 +160,7 @@ describe Conditions do
     end
 
     context 'and' do
-      before(:each) { @and_condition = Conditions::And.new([]) }
+      before(:each) { @and_condition = Triggerable::Conditions::And.new([]) }
 
       it ('true + true') do
         @and_condition.conditions = [TrueCondition.new, TrueCondition.new]
@@ -179,7 +179,7 @@ describe Conditions do
     end
 
     context 'or' do
-      before(:each) { @or_condition = Conditions::Or.new([]) }
+      before(:each) { @or_condition = Triggerable::Conditions::Or.new([]) }
 
       it ('true + true') do
         @or_condition.conditions = [TrueCondition.new, TrueCondition.new]