trifle 0.0.4 → 0.0.5

data/Gemfile.lock

@@ -9,7 +9,7 @@ GIT
 PATH
   remote: .
   specs:
-    trifle (0.0.3)
+    trifle (0.0.5)
 
 GEM
   remote: http://rubygems.org/

data/README.md

@@ -44,7 +44,7 @@ trifle = Trifle.new(Redis.new, key: "foobar")
 You can also load the Trifle from the command line:
 
 ```
-trifle file1.csv file2.csv
+trifle redis://127.0.0.1:6379/0 file1.csv file2.csv
 ```
 
 ### Lookup
@@ -65,6 +65,8 @@ trifle.find "192.168.1.1"
 
 ## Release notes
 
+* **0.0.5** Fixed bug when finding IPs at the edge of the data set
+* **0.0.4** Changed binary syntax
 * **0.0.3** Added a binary for loading Trifle from the command line
 * **0.0.2** Added support for custom Redis key
 * **0.0.1** First draft

data/lib/trifle/finder.rb

@@ -13,7 +13,7 @@ class Trifle
     protected
 
     def find ip_i, lower, upper
-      return nil if lower > upper
+      return nil if lower >= upper
 
       index = (lower+upper)/2
 

data/lib/trifle/version.rb

@@ -1,3 +1,3 @@
 class Trifle
-  VERSION = "0.0.4" unless defined? Trifle::VERSION
+  VERSION = "0.0.5" unless defined? Trifle::VERSION
 end

data/spec/trifle/finder_spec.rb

@@ -17,9 +17,9 @@ describe Trifle::Finder do
       ["223.255.255.0","223.255.255.255","3758096128","3758096383","AU","Australia"]
     ]
     @redis = Redis.new
-    trifle = Trifle.new(@redis)
+    @trifle = Trifle.new(@redis)
     @finder = Trifle::Finder.new(@redis)
-    trifle.load(data: @valid_data)
+    @trifle.load(data: @valid_data)
   end
 
   describe "#handle" do
@@ -32,6 +32,11 @@ describe Trifle::Finder do
     it "should return nil if the entry wasn't found" do
       @finder.handle("127.0.0.1").should be_nil
     end
+
+    it "should not fail if there's only 1 record" do
+      @trifle.load(data: [["82.132.242.55","82.132.242.55","1384444471","1384444471","GB","United Kingdrom"]])
+      @finder.handle("127.0.0.1").should be_nil
+    end
   end
 
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: trifle
 version: !ruby/object:Gem::Version
-  version: 0.0.4
+  version: 0.0.5
   prerelease: 
 platform: ruby
 authors:
@@ -13,7 +13,7 @@ date: 2012-06-21 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rspec
-  requirement: &70309726715860 !ruby/object:Gem::Requirement
+  requirement: &70169180633800 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -21,10 +21,10 @@ dependencies:
         version: '0'
   type: :development
   prerelease: false
-  version_requirements: *70309726715860
+  version_requirements: *70169180633800
 - !ruby/object:Gem::Dependency
   name: rujitsu
-  requirement: &70309726715260 !ruby/object:Gem::Requirement
+  requirement: &70169180632840 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -32,10 +32,10 @@ dependencies:
         version: '0'
   type: :development
   prerelease: false
-  version_requirements: *70309726715260
+  version_requirements: *70169180632840
 - !ruby/object:Gem::Dependency
   name: active_support
-  requirement: &70309726714540 !ruby/object:Gem::Requirement
+  requirement: &70169180632020 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -43,10 +43,10 @@ dependencies:
         version: '0'
   type: :development
   prerelease: false
-  version_requirements: *70309726714540
+  version_requirements: *70169180632020
 - !ruby/object:Gem::Dependency
   name: fakeredis
-  requirement: &70309726713980 !ruby/object:Gem::Requirement
+  requirement: &70169180631100 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ~>
@@ -54,7 +54,7 @@ dependencies:
         version: 0.3.0
   type: :development
   prerelease: false
-  version_requirements: *70309726713980
+  version_requirements: *70169180631100
 description: Stores the GeoIP databases in Redis and gives it a simple way to lookup
   IPs and map them to countries
 email: