trice 0.2.0 → 0.2.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: b9097c61e695a9f53208d64b12cade17d4d2fe89
-  data.tar.gz: 167602e225951b8c6dceb09f0e9cb872818af6aa
+  metadata.gz: 2b5c704c1fe09caf5987257b287f21616445d583
+  data.tar.gz: 6ca50c285e540bddd31fd167cf3f8c4c5656ca78
 SHA512:
-  metadata.gz: c5040644cbc271721d2c439e194fa88ccf1091e33bb4617e9566975077c758eaa53a9c7ca13446f705d610ed0f0c18cb4ad342ee412de1cc25ac6a456a0f8956
-  data.tar.gz: 8c1cf24577b05add0576ec7c1c97e7e1168564381d3cf46756e87ad2a5abd86ac232f886053b1a0e6ac3828d55fbacc432627b783cad9eb85698119aa26842e9
+  metadata.gz: 653a39eb48ae6332edabf6a0468c52b1cd2a202b27adf281b06ed41aaa4b0e4987b5be729ab01b33eed6dff150e0010845a40422d2633e2b28932c7b18c98fa0
+  data.tar.gz: d28c70c39e1f413c6a792116b10de2e49fa1dbca920569c1aa084a72ff0efae6eab4ba763f09227ea88faaf67b4d31e017c8d8201e10ccd4e6aa0b1b609a270d

data/README.md

@@ -39,7 +39,7 @@ Then your controller and view gets an accessor method to access consistent time
 
 ### Include helper module outside of controller
 
-Inlude `Trice::ReferenceTime` add `#reference_time` method to lookup current reference time.
+Include `Trice::ReferenceTime` add `#reference_time` method to lookup current reference time.
 
 Use it in Rails model.
 
@@ -84,7 +84,7 @@ Trice allows you to stub reference time to run travelled time-testing and / or p
 
 Set `_requested_at=<timish>` query parameter like below
 ```
-$ curl https://example.com/campaigns/12345?_requested_at=20160215130
+$ curl https://example.com/campaigns/12345?_requested_at=201602151300
 ```
 
 Or can set HTTP header, useful for tests.
@@ -92,17 +92,17 @@ Or can set HTTP header, useful for tests.
 X-REQUESTED-AT: 2016-02-15T13:00:00+09:00
 ```
 
-Value format, which specified both query parameter and header, should be `Time.parsse` parasable.
+Value format, which specified both query parameter and header, should be `Time.parse` parasable.
 
 #### Enable/Disable stubbing
 
-Toggle requested at stubbing in `config/initializers`. The default is below, enabled unelss `Rails.env.production?`.
+Toggle requested at stubbing in `config/initializers`. The default is below, enabled unless `Rails.env.production?`.
 
 ```ruby
 Trice.support_requested_at_stubbing = !Rails.env.production?
 ```
 
-Setting callable object let you choice enable/disable dinamically by seeing request.
+Setting callable object let you choice enable/disable dynamically by seeing request.
 
 ```ruby
 our_office_network = IPAddr.new('203.0.113.0/24')
@@ -127,7 +127,7 @@ end
 I recommend to pass reference time to a model by method and/or constructor argument because reference time is an external input, should be handled controller layer.
 But sometimes it is required  from deep inside of model logics and tests for them.
 
-Model unit spec has `with_reference_time` and `set_now_to_reference_time` declarition method to set `Trice.reference_time` in an example.
+Model unit spec has `with_reference_time` and `set_now_to_reference_time` declaration method to set `Trice.reference_time` in an example.
 
 ```ruby
 describe MyModel do
@@ -145,7 +145,7 @@ describe MyModel do
 end
 ```
 
-Feature specs (or othre Capybara based E2E tests) also has helper method using stubbing mechanism. `stub_requested_at <timish>` set `X-Trice-Requested-At` automatically.
+Feature specs (or other Capybara based E2E tests) also has helper method using stubbing mechanism. `stub_requested_at <timish>` set `X-Trice-Requested-At` automatically.
 
 ```ruby
 context 'on ひな祭り day' do

data/lib/trice/controller_methods/reference_time_assignment.rb

@@ -10,27 +10,23 @@ module Trice
       end
 
       def around(controller, &action)
-        t = determine_requested_at(controller)
+        t = stubbed_requested_at(controller) || Time.now
 
         Trice.with_reference_time(t, &action)
       end
 
       private
 
-      def determine_requested_at(controller)
-        if @stub_configuration.stubbable?(controller)
-          extract_requested_at(controller.request) || Time.now
-        else
-          Time.now
+      def stubbed_requested_at(controller)
+        requested_at = requested_at_string(controller.request)
+
+        if requested_at && @stub_configuration.stubbable?(controller)
+          Time.zone.parse(requested_at)
         end
       end
 
-      def extract_requested_at(request)
-        if request.params[QUERY_STUB_KEY]
-          Time.zone.parse(request.params[QUERY_STUB_KEY])
-        elsif request.headers[HEADER_STUB_KEY]
-          Time.zone.parse(request.headers[HEADER_STUB_KEY])
-        end
+      def requested_at_string(request)
+        request.params[QUERY_STUB_KEY] || request.headers[HEADER_STUB_KEY]
       end
     end
   end

data/lib/trice/version.rb

@@ -1,3 +1,3 @@
 module Trice
-  VERSION = "0.2.0"
+  VERSION = "0.2.1"
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: trice
 version: !ruby/object:Gem::Version
-  version: 0.2.0
+  version: 0.2.1
 platform: ruby
 authors:
 - moro
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2016-05-06 00:00:00.000000000 Z
+date: 2016-09-29 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport