trent 0.2.0 → 0.2.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: ae2e50c64156a238d44cea8d8dd2f75d065a67181c83c4c8393b977185a780dc
-  data.tar.gz: 030376142fdf94609f35462eeaf57c6aeae1c3613c2cacaaa3a0b32090a54fea
+  metadata.gz: 0f1c859844b58137c350ba12bd63c3be0cbb31cb47bb3355081c41e0ffb28f53
+  data.tar.gz: 5fd4d79c8f89e8945c75d1d16676f5cadf0e2cc5c236d326f95d71f92e7c43f5
 SHA512:
-  metadata.gz: a04dada57e421b6c9b832dbed4c8f096448dcc89a61afb0da3f0086f2f865816b90e4d6b1f4be9be1d506a47fcf629a64a6bdd1c194407440476c1e145e7b622
-  data.tar.gz: f106b7156d6a8188e58ee7b802b411fc7a297e9dcf52dabcc562234d6710d5e3d91b95e6be45d702051ea2e3ee2e1d559d4d9eb7a6d25b5e95a1054e53c94285
+  metadata.gz: 30482d95de07171e55bc1f58c1c397c93203f9c1f907ee12c44f97548df0851f3907715b0302e627151883c67b3ba60858f126fcd3e8c2c7bbff675a71b780fc
+  data.tar.gz: b5636c209077500c3945e6e6e6b13c2857a516f91b9eed1d25ebf1b2ad307df1523321d5a071eb4469cc20cc290086fa46087511b762a8a526ac2da68f78d58c

data/CHANGELOG.md

@@ -1,12 +1,10 @@
-### [0.1.0] 2018-08-07
+### [0.2.1] 2018-08-27
 
-First release! 
+### Fixed 
+- `sh()` and `ssh()` did not actually use the `fail_non_success` parameter. There was a bug in the code that ended up ignoring the parameter. 
 
-### Added
-- Ability to run local shell commands on Travis CI build. 
-- Ability to run remote ssh commands on Travis CI builds. 
-- Ability to send a comment on the GitHub pull request for the Travis CI build. 
-- Trent only works with Travis-CI at this time. 
+### Changed 
+- When attempting to comment on a GitHub pull request and you're not on a pull request, Trent will log a warning to the console with the comment message. 
 
 ### [0.2.0] 2018-08-08
 
@@ -16,4 +14,14 @@ Add `path` function to Trent to perform string replacing in your commands for yo
 - Add `path` function to Trent to perform string replacing in your commands for you. 
 
 ### Changed
-- Each time you run `sh()` or `ssh()` commands, your command will perform a string replace with all commands you add to `path()`. 
+- Each time you run `sh()` or `ssh()` commands, your command will perform a string replace with all commands you add to `path()`. 
+
+### [0.1.0] 2018-08-07
+
+First release! 
+
+### Added
+- Ability to run local shell commands on Travis CI build. 
+- Ability to run remote ssh commands on Travis CI builds. 
+- Ability to send a comment on the GitHub pull request for the Travis CI build. 
+- Trent only works with Travis-CI at this time. 

data/lib/github/github.rb

@@ -12,6 +12,11 @@ class GitHub
 
   # Comment on Pull Request
   def comment(message)
+    unless ENV['TRAVIS_PULL_REQUEST']
+      Log.warning("Not in pull request, skipping GitHub comment. Message: #{message}")
+      return
+    end
+
     result = comment_on_pull_request(message)
 
     if !result[:successful]

data/lib/trent.rb

@@ -38,32 +38,25 @@ class Trent
   end
 
   ## Run ssh command
-  def ssh(command, fail_non_success = true)
+  def ssh(command, fail_non_success: true)
     command = Command.path_replace(command, @paths)
     Log.fatal('You did not configure SSH yet.') unless @ssh
 
     puts command.colorize(@color)
     result = @ssh.run(command)
 
-    Log.fatal('Command failed with a non 0 exit status.') if !result[:result] && fail_non_success
+    process_shell_result(result, fail_non_success)
 
     result
   end
 
   # Run local bash command
-  def sh(command, fail_non_success = true)
+  def sh(command, fail_non_success: true)
     command = Command.path_replace(command, @paths)
     puts command.colorize(@color)
 
     result = @sh.run(command)
-
-    unless result[:result]
-      if fail_non_success
-        Log.fatal('Command failed with a non 0 exit status.')
-      else
-        Log.warning('Command failed with a non 0 exit status.')
-      end
-    end
+    process_shell_result(result, fail_non_success)
 
     result
   end
@@ -73,4 +66,16 @@ class Trent
     Log.fatal('You did not configure GitHub yet.') unless @github
     @github
   end
+
+  private
+
+  def process_shell_result(result, fail_non_success)
+    return if result[:result]
+
+    if fail_non_success
+      Log.fatal('Command failed with a non 0 exit status.')
+    else
+      Log.warning('Command failed with a non 0 exit status.')
+    end
+  end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: trent
 version: !ruby/object:Gem::Version
-  version: 0.2.0
+  version: 0.2.1
 platform: ruby
 authors:
 - Levi Bostian