trello-fs 0.1.5 → 0.1.6

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 1ad4e72e639015d196993e241a9de84c03b26603
-  data.tar.gz: 23f3e09d23a991b51fdd2fc0cb2f28ae96ad7248
+  metadata.gz: da00f44ee1357ebf00449eb4b77cd855597366c5
+  data.tar.gz: 05539b142f5d5b4d4381dc395fc65e30e384e5ac
 SHA512:
-  metadata.gz: 00ba43ada3f4c1dea631715b8830225f0c8d1e915dff7470b84a5d16749e10078b02039564f0828577e140aeee0db887f85512bacbbff55d57d45e05030a5e18
-  data.tar.gz: 406460a7a03e8fcb445830d0d81e9dd073993209f21681572fd43df93da744510523165ce8bf29b4e9dceb7e92117d470b5b8f4213f7787eee2c2ff3042b0a5d
+  metadata.gz: 4d40a0f286e72ce49461a32363fceb3a89d6538c9a35c39a5fab65390bf30ae0e6cd94bef257806bcce36530969c31264609230b63c5c82bad4ba431f524a02c
+  data.tar.gz: 0554b429271b6d5920d1794b01dd616a4ca089a1c6bb7f3cfcfbb628d547f6bd9530b99da2723a12239d0ba461e70c87ed2ed672b954467dc16e4e3a9b4f7188

data/lib/trello-fs/attachment_builder.rb

@@ -20,6 +20,8 @@ module TrelloFs
     end
 
     def download_and_save
+      return unless is_trello_attachment?
+
       data = download
       return unless data
 
@@ -53,8 +55,12 @@ module TrelloFs
       File.exist? path
     end
 
+    def is_trello_attachment?
+      url.include?('trello-attachments.s3.amazonaws.com')
+    end
+
     def download
-      open(@attachment.url).read
+      open(url).read
     end
 
     def repository
@@ -64,5 +70,9 @@ module TrelloFs
     def board_builder
       @card_builder.board_builder
     end
+
+    def url
+      @attachment.url
+    end
   end
 end

data/lib/trello-fs/card_builder.rb

@@ -17,7 +17,11 @@ module TrelloFs
       attachment_paths = @card.attachments.map do |attachment|
         attachment_builder = AttachmentBuilder.new(self, attachment)
         attachment_builder.build
-        attachment_builder.relative_path
+        if attachment_builder.is_trello_attachment?
+          attachment_builder.relative_path
+        else
+          attachment_builder.url
+        end
       end
 
       File.open(path, 'w') do |file|
@@ -60,8 +64,13 @@ module TrelloFs
       return '' unless attachment_paths.any?
 
       links = attachment_paths.map do |path|
-        name = path.split('/').last
-        path = "../../#{path}"
+        if is_url?(path)
+          name = path
+        else
+          name = path.split('/').last
+          path = "../../#{path}"
+        end
+
         link = "[#{name}](#{path})"
         if path.end_with?('.png') || path.end_with?('.jpg') || path.end_with?('gif') || path.end_with?('.jpeg')
           "!#{link}"
@@ -108,5 +117,11 @@ module TrelloFs
     def repository_name
       repository.title
     end
+
+    private
+
+    def is_url?(path)
+      path.start_with?('http://') || path.start_with?('https://')
+    end
   end
 end

data/lib/trello-fs/version.rb

@@ -1,3 +1,3 @@
 module TrelloFs
-    VERSION = "0.1.5"
+    VERSION = "0.1.6"
 end

data/spec/trello-fs/attachment_builder_spec.rb

@@ -1,7 +1,9 @@
 require 'spec_helper'
 
 describe TrelloFs::AttachmentBuilder do
-  let(:attachment) { OpenStruct.new(id: '1', name: 'Attachment Name') }
+  let(:attachment) { OpenStruct.new(id: '1',
+                                    name: 'Attachment Name',
+                                    url: 'trello-attachments.s3.amazonaws.com') }
   let(:card) { OpenStruct.new(name: 'Card Name', attachments: [attachment]) }
   let(:list) { OpenStruct.new(name: 'List Name', cards: [card]) }
   let(:board) { OpenStruct.new(name: 'Board') }
@@ -34,4 +36,18 @@ describe TrelloFs::AttachmentBuilder do
       should eq true
     end
   end
+
+  describe '#is_trello_attachment?' do
+    subject { attachment_builder.is_trello_attachment? }
+
+    it do
+      attachment.url = 'http://not-trello.com'
+      should eq false
+    end
+
+    it do
+      attachment.url = 'https://trello-attachments.s3.amazonaws.com/fdksajfls'
+      should eq true
+    end
+  end
 end

data/spec/trello-fs/card_builder_spec.rb

@@ -31,7 +31,7 @@ describe TrelloFs::CardBuilder do
   subject { card_builder }
 
   describe '#content' do
-    subject { card_builder.content(['Attachments/file.pdf', 'Attachments/picture.png']) }
+    subject { card_builder.content(['Attachments/file.pdf', 'Attachments/picture.png', 'http://url.com/file.docx']) }
 
     it { should include 'Card Name' }
     it { should include 'Card Description' }
@@ -40,6 +40,7 @@ describe TrelloFs::CardBuilder do
     it { should include 'List Name' }
     it { should include '[file.pdf' }
     it { should include '![picture.png]' }
+    it { should include '[http://url.com/file.docx](http://url.com/file.docx)' }
   end
 
   describe '#path' do

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: trello-fs
 version: !ruby/object:Gem::Version
-  version: 0.1.5
+  version: 0.1.6
 platform: ruby
 authors:
 - Matúš Tomlein
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-03-14 00:00:00.000000000 Z
+date: 2015-04-09 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler