trek 2.3.2 → 2.5.0

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
Files changed (221) hide show
  1. checksums.yaml +4 -4
  2. data/.node-version +1 -1
  3. data/.yarn/releases/yarn-4.18.1.cjs +1000 -0
  4. data/.yarnrc.yml +3 -5
  5. data/AGENTS.md +12 -8
  6. data/CHANGELOG.md +73 -0
  7. data/Gemfile.lock +226 -171
  8. data/Makefile +38 -1
  9. data/README.md +2 -2
  10. data/app/assets/icons/trek/passkey.svg +5 -0
  11. data/app/assets/stylesheets/trek/base.css +6 -0
  12. data/app/components/trek/entries/item_component/item_component.css +6 -0
  13. data/app/components/trek/form/image_field_component/image_field_component.html.slim +9 -0
  14. data/app/components/trek/form/image_field_component.rb +1 -5
  15. data/app/components/trek/form/password_strength_component/password_strength_component.css +56 -0
  16. data/app/components/trek/form/password_strength_component/password_strength_component.html.slim +8 -0
  17. data/app/components/trek/form/password_strength_component/password_strength_component.js +74 -0
  18. data/app/components/trek/form/password_strength_component.rb +29 -0
  19. data/app/components/trek/gate_component/gate_component.css +7 -0
  20. data/app/components/trek/icon/sprite_component.rb +3 -2
  21. data/app/components/trek/list/item_component.rb +1 -1
  22. data/app/components/trek/list/tree/item_component.rb +2 -2
  23. data/app/components/trek/search_component/search_component.html.slim +2 -1
  24. data/app/components/trek/search_component.rb +9 -1
  25. data/app/components/trek/section_component/section_component.css +22 -0
  26. data/app/components/trek/section_component/section_component.html.slim +5 -0
  27. data/app/components/trek/section_component/section_component.js +1 -0
  28. data/app/components/trek/section_component.rb +14 -0
  29. data/app/content/trek/content/bullet_list.rb +10 -0
  30. data/app/content/trek/content/document.rb +33 -0
  31. data/app/content/trek/content/image_block.rb +52 -0
  32. data/app/content/trek/content/link_resolver.rb +33 -0
  33. data/app/content/trek/content/list_item.rb +19 -0
  34. data/app/content/trek/content/ordered_list.rb +10 -0
  35. data/app/content/trek/content/paragraph.rb +10 -0
  36. data/app/content/trek/content/prompts_block.rb +22 -0
  37. data/app/content/trek/content.rb +32 -0
  38. data/app/controllers/concerns/trek/auditable.rb +103 -0
  39. data/app/controllers/concerns/trek/filters.rb +2 -0
  40. data/app/controllers/concerns/trek/passkeys.rb +37 -0
  41. data/app/controllers/concerns/trek/reorderable.rb +14 -3
  42. data/app/controllers/trek/csp_reports_controller.rb +59 -0
  43. data/app/controllers/trek/panels/base_controller.rb +3 -0
  44. data/app/controllers/trek/panels/links_controller.rb +1 -1
  45. data/app/controllers/trek/panels/prompts_controller.rb +1 -1
  46. data/app/controllers/trek/resource_controller.rb +7 -1
  47. data/app/helpers/trek/audit_logs_helper.rb +21 -0
  48. data/app/helpers/trek/thumbnail_helper.rb +11 -0
  49. data/app/helpers/trek/user_agents_helper.rb +36 -0
  50. data/app/javascript/controllers/index.js +3 -0
  51. data/app/javascript/controllers/passkey_controller.js +118 -0
  52. data/app/javascript/trek.js +4 -0
  53. data/app/jobs/trek/audit_log/purge_job.rb +18 -0
  54. data/app/jobs/trek/purge_expired_sessions_job.rb +14 -0
  55. data/app/jobs/trek/resolve_session_hostname_job.rb +17 -0
  56. data/app/models/concerns/trek/audit_log.rb +30 -0
  57. data/app/models/concerns/trek/contentable.rb +9 -14
  58. data/app/models/concerns/trek/pageable.rb +10 -1
  59. data/app/models/concerns/trek/users/passkeys.rb +75 -0
  60. data/app/models/concerns/trek/users/password_history.rb +51 -0
  61. data/app/models/concerns/trek/users/password_policy.rb +85 -0
  62. data/app/models/concerns/trek/users/password_renewal.rb +51 -0
  63. data/app/models/concerns/trek/users/session_lifetime.rb +39 -0
  64. data/app/models/concerns/trek/users/sign_in_lockout.rb +67 -0
  65. data/app/models/concerns/trek/users/sign_ins.rb +31 -0
  66. data/app/models/concerns/trek/users/validations.rb +3 -2
  67. data/app/models/trek/feature.rb +6 -0
  68. data/app/models/trek/pwned_passwords.rb +40 -0
  69. data/app/models/trek/user_session.rb +10 -0
  70. data/app/policies/trek/audit_log_policy.rb +34 -0
  71. data/app/policies/trek/user_policy.rb +5 -0
  72. data/app/validators/not_disposable_validator.rb +18 -0
  73. data/app/views/trek/panels/images/_form.html.slim +1 -1
  74. data/app/views/trek/panels/images/create.turbo_stream.slim +1 -1
  75. data/app/views/trek/panels/links/_form.html.slim +1 -1
  76. data/app/views/trek/panels/prompts/_form.html.slim +1 -1
  77. data/config/brakeman.ignore +22 -0
  78. data/config/i18n-tasks.yml +7 -0
  79. data/config/locales/trek.en.yml +167 -39
  80. data/config/locales/trek.fr.yml +168 -40
  81. data/docs/.vitepress/config.mjs +8 -3
  82. data/docs/deploy.md +2 -0
  83. data/docs/getting-started.md +3 -3
  84. data/docs/proxies.md +53 -0
  85. data/docs/reference/components.md +1 -0
  86. data/docs/reference/concerns/contentable.md +2 -1
  87. data/docs/reference/controllers.md +1 -1
  88. data/docs/reference/environment-variables.md +2 -0
  89. data/docs/reference/formatters.md +31 -8
  90. data/docs/reference/generators/admin-user.md +1 -1
  91. data/docs/reference/generators/audit-log.md +113 -0
  92. data/docs/reference/generators/install.md +12 -3
  93. data/docs/reference/generators/security-headers.md +109 -0
  94. data/docs/reference/index.md +3 -0
  95. data/docs/reference/models/fragment.md +1 -0
  96. data/docs/reference/models/tag.md +4 -2
  97. data/docs/reference/models/user.md +123 -3
  98. data/docs/reference/validators.md +94 -0
  99. data/docs/security.md +90 -0
  100. data/docs/what-is-trek.md +4 -4
  101. data/lefthook.yml +8 -0
  102. data/lib/generators/trek/helpers.rb +13 -5
  103. data/lib/generators/trek/install/admin/user_password_resets_generator.rb +5 -0
  104. data/lib/generators/trek/install/admin/user_sessions_generator.rb +5 -0
  105. data/lib/generators/trek/install/admin/users_generator.rb +23 -0
  106. data/lib/generators/trek/install/admin_generator.rb +8 -0
  107. data/lib/generators/trek/install/appsignal_generator.rb +1 -1
  108. data/lib/generators/trek/install/audit_log_generator.rb +56 -0
  109. data/lib/generators/trek/install/authentication_generator.rb +78 -4
  110. data/lib/generators/trek/install/authorization_generator.rb +1 -1
  111. data/lib/generators/trek/install/esbuild_generator.rb +1 -2
  112. data/lib/generators/trek/install/mailer_generator.rb +18 -0
  113. data/lib/generators/trek/install/model_specs_generator.rb +6 -4
  114. data/lib/generators/trek/install/postcss_generator.rb +1 -4
  115. data/lib/generators/trek/install/postmark_generator.rb +2 -2
  116. data/lib/generators/trek/install/security_headers_generator.rb +49 -0
  117. data/lib/generators/trek/install/specs_generator.rb +11 -0
  118. data/lib/generators/trek/install/user_generator.rb +1 -1
  119. data/lib/generators/trek/install/yarn_generator.rb +1 -1
  120. data/lib/generators/trek/install_generator.rb +62 -54
  121. data/lib/generators/trek/scaffold_generator.rb +13 -5
  122. data/lib/generators/trek/taxonomies_generator.rb +5 -0
  123. data/lib/generators/trek/templates/.gitlab-ci.yml +18 -2
  124. data/lib/generators/trek/templates/Makefile +1 -1
  125. data/lib/generators/trek/templates/controllers/admin/active_sessions_controller.rb +21 -0
  126. data/lib/generators/trek/templates/controllers/admin/audit_logs_controller.rb +30 -0
  127. data/lib/generators/trek/templates/controllers/admin/fragments_controller.rb +7 -0
  128. data/lib/generators/trek/templates/controllers/admin/panels/images_controller.rb +8 -0
  129. data/lib/generators/trek/templates/controllers/admin/panels/links_controller.rb +8 -0
  130. data/lib/generators/trek/templates/controllers/admin/panels/prompts_controller.rb +8 -0
  131. data/lib/generators/trek/templates/controllers/admin/passkey_sessions_controller.rb +41 -0
  132. data/lib/generators/trek/templates/controllers/admin/passkeys_controller.rb +37 -0
  133. data/lib/generators/trek/templates/controllers/admin/user_password_resets_controller.rb +4 -4
  134. data/lib/generators/trek/templates/controllers/admin/user_sessions_controller.rb +53 -4
  135. data/lib/generators/trek/templates/controllers/admin/users_controller.rb +20 -0
  136. data/lib/generators/trek/templates/controllers/concerns/trek/authentication.rb +58 -7
  137. data/lib/generators/trek/templates/helpers/application_helper.rb +0 -4
  138. data/lib/generators/trek/templates/initializers/audit_log.rb +11 -0
  139. data/lib/generators/trek/templates/initializers/content_security_policy.rb +49 -0
  140. data/lib/generators/trek/templates/initializers/permissions_policy.rb +19 -0
  141. data/lib/generators/trek/templates/jobs/admin/password_reset_job.rb +9 -0
  142. data/lib/generators/trek/templates/layouts/admin/auth.html.slim +0 -5
  143. data/lib/generators/trek/templates/layouts/admin.html.slim +0 -3
  144. data/lib/generators/trek/templates/mailers/admin/passwords_mailer.rb +1 -1
  145. data/lib/generators/trek/templates/mailers/admin_mailer.rb +28 -1
  146. data/lib/generators/trek/templates/migrations/audit_logs.rb.erb +27 -0
  147. data/lib/generators/trek/templates/migrations/tags.rb.erb +6 -1
  148. data/lib/generators/trek/templates/migrations/user_passkeys.rb.erb +24 -0
  149. data/lib/generators/trek/templates/migrations/user_password_renewal.rb.erb +8 -0
  150. data/lib/generators/trek/templates/migrations/user_previous_passwords.rb.erb +10 -0
  151. data/lib/generators/trek/templates/migrations/user_session_tracking.rb.erb +11 -0
  152. data/lib/generators/trek/templates/migrations/user_sign_in_lockout.rb.erb +7 -0
  153. data/lib/generators/trek/templates/migrations/user_sign_ins.rb.erb +13 -0
  154. data/lib/generators/trek/templates/models/audit_log.rb +3 -0
  155. data/lib/generators/trek/templates/models/fragment.rb +14 -0
  156. data/lib/generators/trek/templates/models/tag_category.rb +2 -1
  157. data/lib/generators/trek/templates/models/user/passkey.rb +17 -0
  158. data/lib/generators/trek/templates/models/user/previous_password.rb +4 -0
  159. data/lib/generators/trek/templates/models/user/session.rb +8 -0
  160. data/lib/generators/trek/templates/policies/audit_log.rb +4 -0
  161. data/lib/generators/trek/templates/spec/mailers/admin/passwords_mailer_spec.rb +16 -0
  162. data/lib/generators/trek/templates/spec/mailers/admin_mailer_spec.rb +51 -0
  163. data/lib/generators/trek/templates/spec/models/audit_log_spec.rb +43 -0
  164. data/lib/generators/trek/templates/spec/models/tag_spec.rb +52 -0
  165. data/lib/generators/trek/templates/spec/models/user/session_spec.rb +68 -0
  166. data/lib/generators/trek/templates/spec/models/user_spec.rb +142 -4
  167. data/lib/generators/trek/templates/spec/requests/admin/active_sessions_spec.rb +120 -0
  168. data/lib/generators/trek/templates/spec/requests/admin/audit_logs_spec.rb +149 -0
  169. data/lib/generators/trek/templates/spec/requests/admin/fragments_spec.rb +26 -2
  170. data/lib/generators/trek/templates/spec/requests/admin/pages_spec.rb +8 -0
  171. data/lib/generators/trek/templates/spec/requests/admin/panels_spec.rb +54 -0
  172. data/lib/generators/trek/templates/spec/requests/admin/passkey_sessions_spec.rb +103 -0
  173. data/lib/generators/trek/templates/spec/requests/admin/passkeys_spec.rb +104 -0
  174. data/lib/generators/trek/templates/spec/requests/admin/password_renewal_spec.rb +83 -0
  175. data/lib/generators/trek/templates/spec/requests/admin/sign_in_lockout_spec.rb +95 -0
  176. data/lib/generators/trek/templates/spec/requests/admin/sign_in_notices_spec.rb +95 -0
  177. data/lib/generators/trek/templates/spec/requests/admin/user_password_resets_spec.rb +43 -6
  178. data/lib/generators/trek/templates/spec/requests/admin/user_sessions_spec.rb +25 -2
  179. data/lib/generators/trek/templates/views/admin/audit_logs/index.html.slim +35 -0
  180. data/lib/generators/trek/templates/views/admin/audit_logs/show.html.slim +50 -0
  181. data/lib/generators/trek/templates/views/admin/fragments/index.html.slim +14 -3
  182. data/lib/generators/trek/templates/views/admin/user_password_resets/edit.html.slim +16 -6
  183. data/lib/generators/trek/templates/views/admin/user_password_resets/new.html.slim +2 -1
  184. data/lib/generators/trek/templates/views/admin/user_sessions/new.html.slim +27 -1
  185. data/lib/generators/trek/templates/views/admin/users/_passkeys.html.slim +67 -0
  186. data/lib/generators/trek/templates/views/admin/users/_properties.html.slim +21 -0
  187. data/lib/generators/trek/templates/views/admin/users/_sessions.html.slim +70 -0
  188. data/lib/generators/trek/templates/views/admin/users/index.html.slim +13 -0
  189. data/lib/generators/trek/templates/views/admin/users/show.html.slim +10 -21
  190. data/lib/generators/trek/templates/views/admin_mailer/new_sign_in.en.html.slim +22 -0
  191. data/lib/generators/trek/templates/views/admin_mailer/new_sign_in.en.text.erb +16 -0
  192. data/lib/generators/trek/templates/views/admin_mailer/new_sign_in.fr.html.slim +22 -0
  193. data/lib/generators/trek/templates/views/admin_mailer/new_sign_in.fr.text.erb +16 -0
  194. data/lib/generators/trek/templates/views/admin_mailer/sign_in_locked.en.html.slim +17 -0
  195. data/lib/generators/trek/templates/views/admin_mailer/sign_in_locked.en.text.erb +10 -0
  196. data/lib/generators/trek/templates/views/admin_mailer/sign_in_locked.fr.html.slim +18 -0
  197. data/lib/generators/trek/templates/views/admin_mailer/sign_in_locked.fr.text.erb +10 -0
  198. data/lib/trek/admin_ip_allowlist.rb +52 -0
  199. data/lib/trek/csp_reports.rb +99 -0
  200. data/lib/trek/data/common_passwords.txt +857 -0
  201. data/lib/trek/data/passkey_providers.json +404 -0
  202. data/lib/trek/disposable_email_domains.rb +53 -0
  203. data/lib/trek/engine.rb +18 -1
  204. data/lib/trek/passkey_providers.rb +19 -0
  205. data/lib/trek/reverse_dns.rb +27 -0
  206. data/lib/trek/saved_attachments_reload.rb +2 -1
  207. data/lib/trek/version.rb +1 -1
  208. data/lib/trek.rb +14 -1
  209. data/package.json +3 -5
  210. data/renovate.json +12 -1
  211. data/trek.gemspec +6 -3
  212. data/yarn.lock +2273 -2573
  213. metadata +160 -17
  214. data/.yarn/plugins/@yarnpkg/plugin-interactive-tools.cjs +0 -541
  215. data/.yarn/releases/yarn-3.8.0.cjs +0 -875
  216. data/app/formatters/prosemirror_to_html/global_id_to_links_formatter.rb +0 -19
  217. data/app/formatters/prosemirror_to_html/nodes/image_block.rb +0 -44
  218. data/app/formatters/prosemirror_to_html/nodes/prompts_block.rb +0 -28
  219. data/app/formatters/prosemirror_to_html/remove_empty_paragraphs_formatter.rb +0 -11
  220. data/app/models/prosemirror.rb +0 -23
  221. data/lib/generators/trek/templates/models/user_session.rb +0 -3
@@ -13,6 +13,14 @@ RSpec.describe "Admin pages", type: :request do
13
13
  expect(response.body).to include("Company").and include("Our team")
14
14
  end
15
15
 
16
+ it "lists a page with an image" do
17
+ pages.company.update!(image: file_fixture("image.png").open)
18
+
19
+ get admin_pages_path
20
+
21
+ expect(response).to have_http_status(:ok)
22
+ end
23
+
16
24
  it "renders the new page form" do
17
25
  get new_admin_page_path
18
26
 
@@ -0,0 +1,54 @@
1
+ require "rails_helper"
2
+
3
+ # The content editor's side panels (link, image, prompt), which its toolbar loads into the layout's
4
+ # stacked panel frame
5
+ RSpec.describe "Admin content editor panels", type: :request do
6
+ before do
7
+ editor = users.create(role: :editor)
8
+ post admin_user_session_path, params: { email: editor.email, password: users.password }
9
+ end
10
+
11
+ # A missing translation in a panel fails the request, instead of showing "Translation missing"
12
+ around do |example|
13
+ raise_on_missing = ActionView::Helpers::TranslationHelper.raise_on_missing_translations
14
+ ActionView::Helpers::TranslationHelper.raise_on_missing_translations = true
15
+ example.run
16
+ ensure
17
+ ActionView::Helpers::TranslationHelper.raise_on_missing_translations = raise_on_missing
18
+ end
19
+
20
+ def stacked_panel
21
+ Nokogiri::HTML5(response.body).at_css("turbo-frame#trek--layout-stacked-panel")
22
+ end
23
+
24
+ {
25
+ "link" => [:new_admin_panels_link_path, :link, :admin_panels_links_path],
26
+ "image" => [:new_admin_panels_image_path, :image, :admin_panels_images_path],
27
+ "prompt" => [:new_admin_panels_prompt_path, :prompt, :admin_panels_prompts_path]
28
+ }.each do |panel, (path, param, form_path)|
29
+ it "opens the #{panel} panel" do
30
+ get public_send(path, param => { turbo_frame_id: "page_1_content" })
31
+
32
+ expect(stacked_panel.at_css("form")["action"]).to eq(public_send(form_path))
33
+ end
34
+
35
+ it "titles the #{panel} panel" do
36
+ get public_send(path, param => { turbo_frame_id: "page_1_content" })
37
+
38
+ expect(stacked_panel.at_css("h1").text.squish).to eq(I18n.t("admin.panels.#{panel}s.form.title"))
39
+ end
40
+ end
41
+
42
+ it "opens the link panel on a link to another site" do
43
+ get new_admin_panels_link_path(link: { turbo_frame_id: "page_1_content", href: "https://example.com/", text: "Example" })
44
+
45
+ expect(stacked_panel.at_css("form")["action"]).to eq(admin_panels_links_path)
46
+ end
47
+
48
+ it "inserts a link into the editor" do
49
+ post admin_panels_links_path(format: :turbo_stream),
50
+ params: { link: { turbo_frame_id: "page_1_content", href: "https://example.com/", text: "Example" } }
51
+
52
+ expect(response).to have_http_status(:ok)
53
+ end
54
+ end
@@ -0,0 +1,103 @@
1
+ require "rails_helper"
2
+ # Not loaded with the gem: it stands in for a browser with an authenticator
3
+ require "webauthn/fake_client"
4
+
5
+ RSpec.describe "Admin sign-in with a passkey", type: :request do
6
+ let(:editor) { users.create(role: :editor) }
7
+ # A browser with an authenticator, on the app's test host
8
+ let(:client) { WebAuthn::FakeClient.new("http://www.example.com") }
9
+
10
+ # The passkey the editor added from their profile, then signed out
11
+ before do
12
+ post admin_user_session_path, params: { email: editor.email, password: users.password }
13
+ get options_admin_passkeys_path, as: :json
14
+ credential = client.create(challenge: response.parsed_body["challenge"], user_verified: true)
15
+ post admin_passkeys_path, params: { credential: credential.to_json }
16
+ delete admin_user_session_path
17
+ end
18
+
19
+ def request_challenge
20
+ get options_admin_passkey_session_path, as: :json
21
+ response.parsed_body["challenge"]
22
+ end
23
+
24
+ # The bytes the passkey was created for, which the browser sends back encoded
25
+ def sign_in(challenge: request_challenge, user_verified: true, user_handle: WebAuthn.standard_encoder.decode(editor.reload.webauthn_id))
26
+ credential = client.get(challenge:, user_verified:, user_handle:)
27
+ post admin_passkey_session_path, params: { credential: credential.to_json }
28
+ end
29
+
30
+ it "asks for any of the site's passkeys, verifying the user" do
31
+ get options_admin_passkey_session_path, as: :json
32
+
33
+ expect(response.parsed_body).to include("allowCredentials" => [], "userVerification" => "required")
34
+ end
35
+
36
+ it "signs the user in" do
37
+ sign_in
38
+
39
+ expect(response).to redirect_to(admin_root_url)
40
+ end
41
+
42
+ # A passkey can't be guessed: failed passwords don't keep its owner out
43
+ it "lets in a user whose password sign-in is locked, and unlocks it" do
44
+ User.sign_in_lockout_after.times do
45
+ post admin_user_session_path, params: { email: editor.email, password: "not the password" }
46
+ end
47
+
48
+ sign_in
49
+
50
+ expect([response.location, editor.reload.sign_in_locked?, editor.failed_sign_in_count]).to eq([admin_root_url, false, 0])
51
+ end
52
+
53
+ it "records the passkey's use" do
54
+ sign_in
55
+
56
+ expect(editor.passkeys.sole.last_used_at).to be_present
57
+ end
58
+
59
+ it "refuses a passkey that doesn't verify the user" do
60
+ sign_in(user_verified: false)
61
+
62
+ expect(response).to redirect_to(new_admin_user_session_path)
63
+ end
64
+
65
+ it "refuses a signature of another challenge" do
66
+ request_challenge
67
+ sign_in(challenge: WebAuthn.generate_user_id)
68
+
69
+ expect(response).to redirect_to(new_admin_user_session_path)
70
+ end
71
+
72
+ it "refuses to reuse a challenge" do
73
+ challenge = request_challenge
74
+ sign_in(challenge:)
75
+ delete admin_user_session_path
76
+
77
+ sign_in(challenge:)
78
+
79
+ expect(response).to redirect_to(new_admin_user_session_path)
80
+ end
81
+
82
+ it "refuses a passkey created for another user than the one it's stored for" do
83
+ sign_in(user_handle: WebAuthn.standard_encoder.decode(WebAuthn.generate_user_id))
84
+
85
+ expect(response).to redirect_to(new_admin_user_session_path)
86
+ end
87
+
88
+ it "refuses a deleted passkey" do
89
+ editor.passkeys.destroy_all
90
+
91
+ sign_in
92
+
93
+ expect(response).to redirect_to(new_admin_user_session_path)
94
+ end
95
+
96
+ it "refuses a user who is no longer privileged" do
97
+ editor.update!(role: :reader)
98
+
99
+ sign_in
100
+
101
+ expect(response).to redirect_to(new_admin_user_session_path)
102
+ end
103
+ end
@@ -0,0 +1,104 @@
1
+ require "rails_helper"
2
+ # Not loaded with the gem: it stands in for a browser with an authenticator
3
+ require "webauthn/fake_client"
4
+
5
+ RSpec.describe "Admin passkeys", type: :request do
6
+ let(:editor) { users.create(role: :editor) }
7
+ # A browser with an authenticator, on the app's test host
8
+ let(:client) { WebAuthn::FakeClient.new("http://www.example.com") }
9
+ let(:safari) { "Mozilla/5.0 (Macintosh; Intel Mac OS X 14_6) AppleWebKit/605.1.15 (KHTML, like Gecko) Version/17.6 Safari/605.1.15" }
10
+
11
+ before { post admin_user_session_path, params: { email: editor.email, password: users.password } }
12
+
13
+ def creation_options
14
+ get options_admin_passkeys_path, as: :json
15
+ response.parsed_body
16
+ end
17
+
18
+ def add_passkey(user_verified: true)
19
+ challenge = creation_options["challenge"]
20
+ credential = client.create(challenge:, user_verified:).to_json
21
+ post admin_passkeys_path, params: { credential: }, headers: { "User-Agent" => safari }
22
+ end
23
+
24
+ it "asks the authenticator to keep the passkey and verify the user" do
25
+ expect(creation_options["authenticatorSelection"]).to include("residentKey" => "required", "userVerification" => "required")
26
+ end
27
+
28
+ it "excludes the user's passkeys, so an authenticator holding one says so" do
29
+ add_passkey
30
+
31
+ expect(creation_options["excludeCredentials"].pluck("id")).to eq(editor.passkeys.pluck(:external_id))
32
+ end
33
+
34
+ it "adds a passkey, with its transports and the AAGUID saying what keeps it" do
35
+ add_passkey
36
+
37
+ expect(editor.passkeys.sole).to have_attributes(transports: ["internal"], aaguid: match(/\A\h{8}-\h{4}-\h{4}-\h{4}-\h{12}\z/))
38
+ end
39
+
40
+ it "shows it under its password manager's name" do
41
+ allow(Trek::PasskeyProviders).to receive(:[]).and_return("Passwords")
42
+
43
+ add_passkey
44
+
45
+ expect(editor.passkeys.sole.to_s).to eq("Passwords")
46
+ end
47
+
48
+ it "shows it under the browser it was added from when its password manager is unknown" do
49
+ allow(Trek::PasskeyProviders).to receive(:[]).and_return(nil)
50
+
51
+ add_passkey
52
+
53
+ expect(editor.passkeys.sole.to_s).to eq(I18n.t("trek.user_agents.browser_on_system", browser: "Safari", system: "macOS"))
54
+ end
55
+
56
+ it "goes back to the passkeys tab once added" do
57
+ add_passkey
58
+
59
+ expect(response).to redirect_to(admin_user_path(editor, anchor: "passkeys"))
60
+ end
61
+
62
+ it "refuses a passkey that doesn't verify the user" do
63
+ add_passkey(user_verified: false)
64
+
65
+ expect(editor.passkeys).to be_empty
66
+ end
67
+
68
+ it "refuses a passkey created for another challenge" do
69
+ creation_options
70
+ post admin_passkeys_path, params: { credential: client.create(challenge: WebAuthn.generate_user_id).to_json }
71
+
72
+ expect(editor.passkeys).to be_empty
73
+ end
74
+
75
+ it "refuses to reuse a challenge" do
76
+ challenge = creation_options["challenge"]
77
+ post admin_passkeys_path, params: { credential: client.create(challenge:, user_verified: true).to_json }
78
+ post admin_passkeys_path, params: { credential: client.create(challenge:, user_verified: true).to_json }
79
+
80
+ expect(editor.passkeys.count).to eq(1)
81
+ end
82
+
83
+ it "deletes a passkey" do
84
+ add_passkey
85
+
86
+ expect { delete admin_passkey_path(editor.passkeys.sole) }.to change(User::Passkey, :count).by(-1)
87
+ end
88
+
89
+ it "doesn't touch another user's passkey" do
90
+ other = users.create(role: :editor).passkeys.create!(name: "Theirs", external_id: "theirs", public_key: "key")
91
+
92
+ delete admin_passkey_path(other)
93
+
94
+ expect(response).to have_http_status(:not_found)
95
+ end
96
+
97
+ it "lists the passkeys on the user's profile" do
98
+ add_passkey
99
+
100
+ get admin_user_path(editor)
101
+
102
+ expect(response.body).to include(editor.passkeys.sole.to_s)
103
+ end
104
+ end
@@ -0,0 +1,83 @@
1
+ require "rails_helper"
2
+
3
+ RSpec.describe "Admin password renewal", type: :request do
4
+ let(:admin) { users.create(role: :admin) }
5
+ let(:editor) { users.create(role: :editor) }
6
+
7
+ def sign_in(user, password: users.password)
8
+ post admin_user_session_path, params: { email: user.email, password: }
9
+ end
10
+
11
+ it "lets an admin ask every user to renew their password" do
12
+ editor
13
+ sign_in(admin)
14
+
15
+ post require_password_renewal_admin_users_path
16
+
17
+ expect(editor.reload.password_renewal_required).to be(true)
18
+ end
19
+
20
+ it "doesn't let an editor ask for it" do
21
+ admin
22
+ sign_in(editor)
23
+
24
+ post require_password_renewal_admin_users_path
25
+
26
+ expect(admin.reload.password_renewal_required).to be(false)
27
+ end
28
+
29
+ context "when the password must be renewed" do
30
+ before do
31
+ editor
32
+ User.require_password_renewal!
33
+ end
34
+
35
+ it "sends the user to the new password form after signing in" do
36
+ sign_in(editor)
37
+ follow_redirect!
38
+
39
+ expect(response).to redirect_to(%r{/admin/user_password_resets/[^/]+/edit\z})
40
+ end
41
+
42
+ it "keeps the user signed out until then" do
43
+ sign_in(editor)
44
+ follow_redirect!
45
+ get admin_root_path
46
+
47
+ expect(response).to redirect_to(new_admin_user_session_path)
48
+ end
49
+
50
+ it "lets the user back in with the new password" do
51
+ sign_in(editor)
52
+ follow_redirect!
53
+ patch response.location.delete_suffix("/edit"), params: { password: "a renewed passphrase here" }
54
+ sign_in(editor, password: "a renewed passphrase here")
55
+
56
+ expect(response).to redirect_to(admin_root_url)
57
+ end
58
+ end
59
+
60
+ context "when the password has expired" do
61
+ around do |example|
62
+ User.password_expires_after = 1.year
63
+ example.run
64
+ ensure
65
+ User.password_expires_after = nil
66
+ end
67
+
68
+ it "sends the user to the new password form after signing in" do
69
+ editor.update!(password_changed_at: 2.years.ago)
70
+ sign_in(editor)
71
+ follow_redirect!
72
+
73
+ expect(response).to redirect_to(%r{/admin/user_password_resets/[^/]+/edit\z})
74
+ end
75
+
76
+ it "lets a recent password through" do
77
+ sign_in(editor)
78
+ follow_redirect!
79
+
80
+ expect(response).to have_http_status(:ok)
81
+ end
82
+ end
83
+ end
@@ -0,0 +1,95 @@
1
+ require "rails_helper"
2
+
3
+ RSpec.describe "Admin sign-in lockout", type: :request do
4
+ include ActiveSupport::Testing::TimeHelpers
5
+
6
+ let(:editor) { users.create(role: :editor) }
7
+
8
+ def sign_in(user = editor, password: users.password)
9
+ post admin_user_session_path, params: { email: user.email, password: }
10
+ end
11
+
12
+ def fail_sign_ins(count, user = editor)
13
+ count.times { sign_in(user, password: "not the password") }
14
+ end
15
+
16
+ def lock_then_extend
17
+ fail_sign_ins(User.sign_in_lockout_after)
18
+ travel(User.sign_in_lockout_duration + 1.second) { fail_sign_ins(1) }
19
+ end
20
+
21
+ describe "per account" do
22
+ it "refuses the right password once failures lock signing in" do
23
+ fail_sign_ins(User.sign_in_lockout_after)
24
+
25
+ sign_in
26
+
27
+ expect(response).to have_http_status(:unprocessable_entity)
28
+ end
29
+
30
+ it "answers a locked account as a wrong password, so it can't be told apart" do
31
+ fail_sign_ins(User.sign_in_lockout_after)
32
+ sign_in(password: "not the password")
33
+ wrong_password = [response.status, flash[:alert]]
34
+
35
+ sign_in
36
+
37
+ expect([response.status, flash[:alert]]).to eq(wrong_password)
38
+ end
39
+
40
+ it "lets the user in once the lock is over" do
41
+ fail_sign_ins(User.sign_in_lockout_after)
42
+
43
+ travel(User.sign_in_lockout_duration + 1.second) { sign_in }
44
+
45
+ expect(response).to redirect_to(admin_root_url)
46
+ end
47
+
48
+ it "lets the user in before failures lock signing in" do
49
+ fail_sign_ins(User.sign_in_lockout_after - 1)
50
+
51
+ sign_in
52
+
53
+ expect(response).to redirect_to(admin_root_url)
54
+ end
55
+
56
+ it "starts the count over after a successful sign-in" do
57
+ fail_sign_ins(User.sign_in_lockout_after - 1)
58
+ sign_in
59
+ delete admin_user_session_path
60
+
61
+ fail_sign_ins(1)
62
+
63
+ expect(editor.reload.sign_in_locked?).to be(false)
64
+ end
65
+
66
+ it "emails the user once when it locks, not on the failures that extend it" do
67
+ editor
68
+
69
+ expect { perform_enqueued_jobs { lock_then_extend } }.to change(ActionMailer::Base.deliveries, :size).by(1)
70
+ end
71
+ end
72
+
73
+ describe "per IP address, whatever the account" do
74
+ # The app's test cache is a null store, under which nothing is ever counted
75
+ before { allow(Rails).to receive(:cache).and_return(ActiveSupport::Cache::MemoryStore.new) }
76
+
77
+ let(:limit) { Admin::UserSessionsController::FAILED_SIGN_INS_PER_IP }
78
+
79
+ it "refuses any sign-in after too many failures" do
80
+ limit.times { |i| sign_in(users.create(email: "user#{i}@example.com", role: :editor), password: "wrong") }
81
+
82
+ sign_in
83
+
84
+ expect(response).to have_http_status(:too_many_requests)
85
+ end
86
+
87
+ it "lets sign-ins from the address in again after the window" do
88
+ limit.times { |i| sign_in(users.create(email: "user#{i}@example.com", role: :editor), password: "wrong") }
89
+
90
+ travel(Admin::UserSessionsController::FAILED_SIGN_INS_WINDOW + 1.second) { sign_in }
91
+
92
+ expect(response).to redirect_to(admin_root_url)
93
+ end
94
+ end
95
+ end
@@ -0,0 +1,95 @@
1
+ require "rails_helper"
2
+
3
+ RSpec.describe "Admin sign-in notices", type: :request do
4
+ include ActiveSupport::Testing::TimeHelpers
5
+
6
+ let(:editor) { users.create(role: :editor) }
7
+ # For examples reading English words, whatever the app's default locale
8
+ let(:english_editor) { users.create(role: :editor, locale: "en") }
9
+ let(:firefox) { "Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:131.0) Gecko/20100101 Firefox/131.0" }
10
+
11
+ def sign_in(user, user_agent: firefox)
12
+ post admin_user_session_path, params: { email: user.email, password: users.password }, headers: { "User-Agent" => user_agent }
13
+ end
14
+
15
+ def sign_out
16
+ delete admin_user_session_path
17
+ end
18
+
19
+ describe "the previous sign-in" do
20
+ it "keeps the sign-in notice short" do
21
+ sign_in(editor)
22
+ sign_out
23
+
24
+ sign_in(editor)
25
+
26
+ expect(flash[:notice]).to eq(I18n.t("admin.user_sessions.create.success"))
27
+ end
28
+
29
+ it "speaks the user's language, not the app's default one" do
30
+ other_locale = (I18n.available_locales - [I18n.default_locale]).first
31
+ skip "the app has a single locale" unless other_locale
32
+ user = users.create(role: :editor, locale: other_locale)
33
+
34
+ sign_in(user)
35
+
36
+ expect(flash[:notice]).to eq(I18n.t("admin.user_sessions.create.success", locale: other_locale))
37
+ end
38
+
39
+ it "records the current sign-in as the previous one for the next" do
40
+ sign_in(editor)
41
+ travel 1.day
42
+ sign_in(editor)
43
+
44
+ expect(editor.reload.last_sign_in_at).to be < editor.current_sign_in_at
45
+ end
46
+
47
+ it "shows the previous sign-in's date, browser and address on the sessions tab" do
48
+ sign_in(english_editor)
49
+ sign_out
50
+ sign_in(english_editor)
51
+
52
+ get admin_user_path(english_editor)
53
+
54
+ expect(response.body).to include("Firefox on Windows").and include("127.0.0.1")
55
+ end
56
+ end
57
+
58
+ it "offers to change the password when the previous sign-in wasn't the user's" do
59
+ sign_in(editor)
60
+ sign_out
61
+ sign_in(editor)
62
+
63
+ get admin_user_path(editor)
64
+
65
+ expect(response.body).to include(new_admin_user_password_reset_path(email: editor.email))
66
+ end
67
+
68
+ describe "the email on a sign-in from a new browser" do
69
+ it "isn't sent on the very first sign-in" do
70
+ expect { sign_in(editor) }.not_to have_enqueued_mail(AdminMailer, :new_sign_in)
71
+ end
72
+
73
+ it "isn't sent from a browser already used to sign in" do
74
+ sign_in(editor)
75
+ sign_out
76
+
77
+ expect { sign_in(editor) }.not_to have_enqueued_mail(AdminMailer, :new_sign_in)
78
+ end
79
+
80
+ it "is sent from a browser never used to sign in" do
81
+ sign_in(editor)
82
+ cookies.delete("trek_known_users")
83
+
84
+ expect { sign_in(editor) }.to have_enqueued_mail(AdminMailer, :new_sign_in)
85
+ end
86
+
87
+ it "isn't sent when the app turns it off" do
88
+ allow(User).to receive(:new_sign_in_email).and_return(false)
89
+ sign_in(editor)
90
+ cookies.delete("trek_known_users")
91
+
92
+ expect { sign_in(editor) }.not_to have_enqueued_mail(AdminMailer, :new_sign_in)
93
+ end
94
+ end
95
+ end
@@ -9,6 +9,12 @@ RSpec.describe "Admin password resets", type: :request do
9
9
  expect(response).to have_http_status(:ok)
10
10
  end
11
11
 
12
+ it "fills the reset request form with the email of the link" do
13
+ get new_admin_user_password_reset_path(email: "ada@example.com")
14
+
15
+ expect(response.body).to include('value="ada@example.com"')
16
+ end
17
+
12
18
  it "keeps the reset request actions in the card, out of the sticky action bar" do
13
19
  get new_admin_user_password_reset_path
14
20
 
@@ -16,19 +22,35 @@ RSpec.describe "Admin password resets", type: :request do
16
22
  end
17
23
 
18
24
  it "emails a reset link to a privileged user" do
19
- expect { post admin_user_password_resets_path, params: { email: editor.email } }
20
- .to have_enqueued_mail(Admin::PasswordsMailer, :reset)
25
+ perform_enqueued_jobs { post admin_user_password_resets_path, params: { email: editor.email } }
26
+
27
+ expect(ActionMailer::Base.deliveries.last.to).to eq([editor.email])
21
28
  end
22
29
 
23
30
  it "sends nothing for an unknown email" do
24
- expect { post admin_user_password_resets_path, params: { email: "nobody@example.com" } }
25
- .not_to have_enqueued_mail
31
+ expect { perform_enqueued_jobs { post admin_user_password_resets_path, params: { email: "nobody@example.com" } } }
32
+ .not_to change(ActionMailer::Base.deliveries, :count)
33
+ end
34
+
35
+ it "sends nothing to a user who is not privileged" do
36
+ reader = users.create(role: :reader)
37
+
38
+ expect { perform_enqueued_jobs { post admin_user_password_resets_path, params: { email: reader.email } } }
39
+ .not_to change(ActionMailer::Base.deliveries, :count)
26
40
  end
27
41
 
28
42
  it "answers an unknown email as a known one, so it can't be used to find accounts" do
43
+ post admin_user_password_resets_path, params: { email: editor.email }
44
+ known = [response.location, flash[:notice]]
45
+
29
46
  post admin_user_password_resets_path, params: { email: "nobody@example.com" }
30
47
 
31
- expect(response).to redirect_to(new_admin_user_session_path)
48
+ expect([response.location, flash[:notice]]).to eq(known)
49
+ end
50
+
51
+ it "queues the same job for an unknown email, so the response time doesn't tell it apart" do
52
+ expect { post admin_user_password_resets_path, params: { email: "nobody@example.com" } }
53
+ .to have_enqueued_job(Admin::PasswordResetJob).with("nobody@example.com")
32
54
  end
33
55
 
34
56
  it "renders the new password form from a reset link" do
@@ -37,6 +59,14 @@ RSpec.describe "Admin password resets", type: :request do
37
59
  expect(response).to have_http_status(:ok)
38
60
  end
39
61
 
62
+ it "states the password rules on the new password form" do
63
+ get edit_admin_user_password_reset_path(editor.password_reset_token)
64
+
65
+ rules = I18n.t("admin.user_password_resets.edit.rules", min: User.password_min_length, passphrase: User.passphrase_length)
66
+
67
+ expect(response.body).to include(CGI.escapeHTML(rules))
68
+ end
69
+
40
70
  it "keeps the new password actions in the card, out of the sticky action bar" do
41
71
  get edit_admin_user_password_reset_path(editor.password_reset_token)
42
72
 
@@ -65,7 +95,7 @@ RSpec.describe "Admin password resets", type: :request do
65
95
  post admin_user_session_path, params: { email: editor.email, password: users.password }
66
96
  patch admin_user_password_reset_path(editor.password_reset_token), params: { password: "a brand new password" }
67
97
 
68
- expect(editor.user_sessions).to be_empty
98
+ expect(editor.sessions).to be_empty
69
99
  end
70
100
 
71
101
  it "sends an empty password back to the form rather than pretending to change it" do
@@ -87,4 +117,11 @@ RSpec.describe "Admin password resets", type: :request do
87
117
 
88
118
  expect(editor.reload.authenticate(users.password)).to be_truthy
89
119
  end
120
+
121
+ it "sends a recent password back to the form, saying why" do
122
+ token = editor.password_reset_token
123
+ patch admin_user_password_reset_path(token), params: { password: users.password }
124
+
125
+ expect(flash[:alert]).to include(editor.errors.generate_message(:password, :recently_used, count: User.password_history_size))
126
+ end
90
127
  end
@@ -31,14 +31,37 @@ RSpec.describe "Admin sign-in", type: :request do
31
31
  it "refuses a wrong password" do
32
32
  post admin_user_session_path, params: { email: editor.email, password: "not the password" }
33
33
 
34
- expect(response).to redirect_to(new_admin_user_session_path)
34
+ expect(response).to have_http_status(:unprocessable_entity)
35
+ end
36
+
37
+ it "keeps the email typed after a wrong password" do
38
+ post admin_user_session_path, params: { email: editor.email, password: "not the password" }
39
+
40
+ expect(response.body).to include(%(value="#{editor.email}"))
35
41
  end
36
42
 
37
43
  it "refuses a user who is not privileged" do
38
44
  reader = users.create(role: :reader)
39
45
  post admin_user_session_path, params: { email: reader.email, password: users.password }
40
46
 
41
- expect(response).to redirect_to(new_admin_user_session_path)
47
+ expect(response).to have_http_status(:unprocessable_entity)
48
+ end
49
+
50
+ it "answers an unknown email as a wrong password, so it can't be used to find accounts" do
51
+ post admin_user_session_path, params: { email: editor.email, password: "not the password" }
52
+ wrong_password = [response.status, flash[:alert]]
53
+
54
+ post admin_user_session_path, params: { email: "nobody@example.com", password: "not the password" }
55
+
56
+ expect([response.status, flash[:alert]]).to eq(wrong_password)
57
+ end
58
+
59
+ it "still hashes the password typed with an unknown email, so it takes as long as a wrong password" do
60
+ allow(BCrypt::Password).to receive(:create).and_call_original
61
+
62
+ post admin_user_session_path, params: { email: "nobody@example.com", password: "not the password" }
63
+
64
+ expect(BCrypt::Password).to have_received(:create)
42
65
  end
43
66
 
44
67
  it "sends a signed-out visitor to the sign-in form" do