tree_diff 1.1.2 → 1.1.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 275453852f6c76b905b0f39363e622763473bbaf81ad6ff527d49a0a03711a9d
-  data.tar.gz: daf3a58eaf867ec2c308747b04bffec7befe7df8336ca9f49b4d49e472ad3caa
+  metadata.gz: 17646f7343db4fba5bb20b308c77b7cfa910b903b5c9a089f604b466db3bbf3b
+  data.tar.gz: e15623b04dba3b55518dc850d4d5eb4a15a1b3ecb8aa7e845ca1b807f1b0c682
 SHA512:
-  metadata.gz: feacaeada2e4d4b0298bace2d3441835f0cac924bec321a50c228edcd4e746ff0fed1d50ee59eef091864e2619915395cc5c05e04ea6fc3c0be91aa362e730ac
-  data.tar.gz: 0dc668bad79c7a76b2fab3d19da7fbf532b384188e0023b55f594f19bcdf9f14d000b5179583fc4bc381717f0168b316246b78b81cdc753c824ec3a5b0869c17
+  metadata.gz: 0b15fb4b1eee4a1da4eca5324ae3dae423ac18517f25e392ed52cff29fb9f8b55a703c43df6cc077692eacfcefecec6cb74e43c68b8c5b21fd1476653547e5e1
+  data.tar.gz: 30d487b43dba72b0b9b27576bdc3930b0cb76be6ceb57bbfeebdf71e9453ab4b204ee65d0f116e1e6cac2cbeb9f2d68a020f038d10da09f208eeff371c6f492a

data/lib/tree_diff.rb

@@ -203,10 +203,12 @@ class TreeDiff
   end
 
   def call_and_copy_value(receiver, method_name)
+    return -> { nil } unless receiver
+
     source_value = receiver.public_send(method_name)
     source_value = Marshal.load(Marshal.dump(source_value)) # Properly clones hashes
 
-    -> { source_value }
+    -> { source_value } # The return value of this becomes the body of the method defined on the Mold object
   end
 
   def iterate_observations(mold, current_object)
@@ -238,6 +240,8 @@ class TreeDiff
 
   def method_caller_with_condition(path)
     ->(object_and_method) do
+      return nil unless object_and_method.fetch(:receiver)
+
       condition = condition_for(path)
 
       if !condition || condition.call(object_and_method.fetch(:receiver))

data/test/helper.rb

@@ -10,6 +10,12 @@ ActiveRecord::Schema.define do
     t.string :number
   end
 
+  create_table :extra_order_details, force: true do |t|
+    t.references :order
+    t.string :integration_id
+    t.string :external_id
+  end
+
   create_table :line_items, force: true do |t|
     t.string :description
     t.integer :price_usd_cents
@@ -45,16 +51,20 @@ ActiveRecord::Schema.define do
   end
 end
 
-# Define the models
 class Order < ActiveRecord::Base
   has_many :line_items, inverse_of: :order
   has_many :orders_vehicles
+  has_one :detail, class_name: "ExtraOrderDetail"
 
   has_many :trucks, through: :orders_vehicles, source: :vehicle, source_type: "Vehicle", class_name: "Truck"
 
   accepts_nested_attributes_for :line_items, allow_destroy: true
 end
 
+class ExtraOrderDetail < ActiveRecord::Base
+  belongs_to :order
+end
+
 class LineItem < ActiveRecord::Base
   belongs_to :order, inverse_of: :line_items
   has_many :item_categories

data/test/tree_diff_test.rb

@@ -27,6 +27,10 @@ class TreeDiffTest < Minitest::Test
     observe :number, orders_vehicles: {vehicle: :id}
   end
 
+  class InvolvingOrderDetailDiff < TreeDiff
+    observe :number, detail: [:integration_id, :external_id]
+  end
+
   class TableDiff < TreeDiff
     observe wood_finish: [:color, :cost, :applied_at, :cost_mapping,
                           blemishes: [:severity]]
@@ -61,6 +65,18 @@ class TreeDiffTest < Minitest::Test
     assert_nil diff.changes_at(:quantity)
   end
 
+  def test_nil_associations
+    order = Order.create!(number: 'XYZ123')
+
+    diff = InvolvingOrderDetailDiff.new(order)
+    assert_empty diff.changes
+
+    order.update!(detail: ExtraOrderDetail.new(integration_id: '123', external_id: '321'))
+
+    assert_equal [{:path=>[:detail, :integration_id], :old=>nil, :new=>"123"},
+                  {:path=>[:detail, :external_id], :old=>nil, :new=>"321"}], diff.changes
+  end
+
   def test_big_tree
     foo_category = ItemCategory.new(description: 'foo')
     bar_category = ItemCategory.new(description: 'bar')

data/tree_diff.gemspec

@@ -1,6 +1,6 @@
 Gem::Specification.new do |s|
   s.name        = 'tree_diff'
-  s.version     = '1.1.2'
+  s.version     = '1.1.3'
   s.date        = '2019-08-23'
   s.summary     = "Observe attribute changes in big complex object trees, like a generic & standalone ActiveModel::Dirty"
   s.description = "Given a tree of relationships in a similar format to strong params, analyzes attribute changes by " \

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: tree_diff
 version: !ruby/object:Gem::Version
-  version: 1.1.2
+  version: 1.1.3
 platform: ruby
 authors:
 - Michael Nelson