trax_controller 0.0.4 → 0.1.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 0e4adb200e79b39ccad802b45128fa422f496406
-  data.tar.gz: fb0dcf577b599ad791f87fc840875c94a156d2a4
+  metadata.gz: 6d61bb93ac569a174d291f54084d306a6726c3bc
+  data.tar.gz: ca40fc02d4b101efe9d9d27498a926bb26a5dd1f
 SHA512:
-  metadata.gz: 33bc80d31708005d6e42b77a0a6b4805b986e147dfee728db9e63a6b80fd735cfcb64123d41876b6c38b7addb9aa87e716f695ee7bcf54532c701eeb90a8a04b
-  data.tar.gz: ae5aa8a93e9aa0408b6e6a6d2c10da94500123f209ddd9f40108427489bc649c2a344d53e338fdb984f3257fe74d6f10d2660a3185c84c537fdcfdff3e226da7
+  metadata.gz: 4495db797d01bcfd38f2e258b82049e4ccf390d328319e945d8aacad9e66310b682d33150c8e050f8727ea4d97d342baccf1ac4edda0fefc10042c957e8c7273
+  data.tar.gz: 8185f4a78f4ac4577dbfdda77e72d70f2e4151817855ab2c04febe70da0b95f03292819686f8e0f2f0a64020da21872cdb72bfb8812b528c7a8453c568c81d77

data/lib/trax/controller/action_types.rb

@@ -2,27 +2,17 @@ module Trax
   module Controller
     module ActionTypes
       extend ::ActiveSupport::Concern
-      #todo: pretty janky but works for now
-
-      included do
-        class_attribute :action_types
-
-        self.action_types = Hashie::Mash.new({
-          :collection => [:index, :search],
-          :resource => [ :show, :delete, :update, :create, :login ]
-        })
-      end
 
       def current_action
         :"#{request.params["action"]}"
       end
 
       def collection_action?
-        self.class.action_types[:collection].include?(current_action)
+        !!get_collection_ivar
       end
 
       def resource_action?
-        self.class.action_types[:resource].include? current_action
+        !!get_resource_ivar
       end
     end
   end

data/lib/trax/controller/actions.rb

@@ -99,7 +99,12 @@ module Trax
       end
 
       def render_errors(status = :unprocessable_entity, error_messages_hash:{}, **options)
-        errors = error_messages_hash.merge(resource_error_messages(**options) || {})
+        errors = if resource_action?
+          error_messages_hash.merge(resource_error_messages(**options) || {})
+        else
+          error_messages_hash.merge({})
+        end
+
         render json: { meta: { errors: errors } }, status: status, serializer: nil
       end
 

data/lib/trax_controller/version.rb

@@ -1,3 +1,3 @@
 module TraxController
-  VERSION = "0.0.4"
+  VERSION = "0.1.0"
 end

data/spec/internal/app/policies/widget_policy.rb

@@ -4,7 +4,7 @@ class WidgetPolicy < Trax::Controller::Authorization::Pundit::BasePolicy
   end
 
   def index?
-    true
+    @result &&= user.can_read_widgets
   end
 
   def create?

data/spec/trax/controller/authorization/pundit_spec.rb

@@ -104,6 +104,31 @@ require 'spec_helper'
         end
       end
 
+      describe '#index' do
+        context 'user can read widgets' do
+          let(:current_user) { user_who_can[:read_widgets] }
+
+          it 'is authorized' do
+            get :index, common_params
+            expect(response).to be_ok
+            json = JSON.parse response.body
+            expect(json).to have_key('widgets')
+          end
+        end
+
+        context 'user cannot read widgets' do
+          let(:current_user) { user_who_cannot[:read_widgets] }
+
+          it do
+            get :index, common_params
+            json = JSON.parse response.body
+            expect(response).to_not be_ok
+
+            unauthorized_result_expectations.call(json)
+          end
+        end
+      end
+
       describe '#create' do
         context "user can create widgets" do
           let(:current_user) { user_who_can[:create_widgets] }

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: trax_controller
 version: !ruby/object:Gem::Version
-  version: 0.0.4
+  version: 0.1.0
 platform: ruby
 authors:
 - Jason Ayre
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-04-15 00:00:00.000000000 Z
+date: 2016-04-18 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: trax_core
@@ -356,7 +356,6 @@ files:
 - spec/internal/app/serializers/widget_serializer.rb
 - spec/internal/config/database.yml
 - spec/internal/config/routes.rb
-- spec/internal/db/combustion_test.sqlite
 - spec/internal/db/schema.rb
 - spec/internal/log/.gitignore
 - spec/internal/public/favicon.ico
@@ -408,7 +407,6 @@ test_files:
 - spec/internal/app/serializers/widget_serializer.rb
 - spec/internal/config/database.yml
 - spec/internal/config/routes.rb
-- spec/internal/db/combustion_test.sqlite
 - spec/internal/db/schema.rb
 - spec/internal/log/.gitignore
 - spec/internal/public/favicon.ico