travis 1.11.1 → 1.13.0

data/spec/cli/setup/service_spec.rb

@@ -1,53 +1,52 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 
 describe Travis::CLI::Setup::Service do
   subject :service do
-    repository = double('repository',{:slug => 'test_slug'})
-    setup = double('Setup', :repository => repository)
+    repository = double('repository', { slug: 'test_slug' })
+    setup = double('Setup', repository:)
     described_class.new(setup)
   end
-  
+
   describe '#deploy' do
-  
     subject :deploy_config do
-      {'provider' => 'dummy'}
+      { 'provider' => 'dummy' }
     end
-    
+
     before do
       allow(service).to receive(:configure).and_yield(deploy_config)
       allow(service).to receive(:on).and_return(nil)
     end
-  
+
     context 'with no existing deploy section' do
-    
       it 'creates section contents without optional items' do
         service.send(:deploy, 'dummy') { |_| }
         expect(deploy_config).to include(
-            'provider'      => 'dummy',
-            'skip_cleanup'   => 'true'
+          'provider' => 'dummy',
+          'skip_cleanup' => 'true'
         )
       end
     end
-    
+
     context 'with existing deploy section' do
       it 'doesn\'t overwrite existing skip_cleanup' do
-        deploy_config['skip_cleanup']='false'
+        deploy_config['skip_cleanup'] = 'false'
         service.send(:deploy, 'dummy') { |_| }
-        expect(deploy_config).to include('skip_cleanup'   => 'false')
+        expect(deploy_config).to include('skip_cleanup' => 'false')
       end
 
       it 'doesn\'t set skip_cleanup for v2' do
-        deploy_config['edge']='true'
+        deploy_config['edge'] = 'true'
         service.send(:deploy, 'dummy') { |_| }
         expect(deploy_config).not_to include('skip_cleanup')
       end
-      
+
       it 'sets skip_cleanup for explicit v1' do
-        deploy_config['edge']='false'
+        deploy_config['edge'] = 'false'
         service.send(:deploy, 'dummy') { |_| }
-        expect(deploy_config).to include('skip_cleanup'   => 'true')
+        expect(deploy_config).to include('skip_cleanup' => 'true')
       end
     end
-    
   end
 end

data/spec/cli/setup_spec.rb

@@ -1,5 +1,3 @@
-require 'spec_helper'
+# frozen_string_literal: true
 
-describe Travis::CLI::Setup do
-  # TODO
-end
+require 'spec_helper'

data/spec/cli/show_spec.rb

@@ -1,9 +1,11 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 
 describe Travis::CLI::Show do
   example 'show 6180.1' do
     run_cli('show', '6180.1', '-E').should be_success
-    stdout.should include("Config:        ")
-    stdout.should include("env: GEM=railties")
+    stdout.should include('Config:        ')
+    stdout.should include('env: GEM=railties')
   end
 end

data/spec/cli/status_spec.rb

@@ -1,27 +1,29 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 
 describe Travis::CLI::Status do
-  example "travis status" do
+  example 'travis status' do
     run_cli('status').should be_success
     stdout.should be == "failed\n"
   end
 
-  example "travis status -x" do
+  example 'travis status -x' do
     run_cli('status', '-x').should_not be_success
     stdout.should be == "failed\n"
   end
 
-  example "travis status -q" do
+  example 'travis status -q' do
     run_cli('status', '-q').should be_success
     stdout.should be_empty
   end
 
-  example "travis status -pqx" do
+  example 'travis status -pqx' do
     run_cli('endpoint', '-pqx').should_not be_success
     stdout.should be_empty
   end
 
-  example "travis status -i" do
+  example 'travis status -i' do
     run_cli('status', '-i', '--skip-completion-check', '-r', 'travis-ci/travis.rb').should be_success
     stdout.should be == "build #6180 failed\n"
   end

data/spec/cli/token_spec.rb

@@ -1,15 +1,17 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 
 describe Travis::CLI::Token do
-  example "travis token (access token set)" do
+  example 'travis token (access token set)' do
     run_cli('token', '-t', 'super-secret').should be_success
-    stdout.should == "super-secret\n"
+    stdout.should
     stderr.should be_empty
   end
 
-  example "travis token -i (access token set)" do
+  example 'travis token -i (access token set)' do
     run_cli('token', '-it', 'super-secret').should be_success
-    stdout.should == "Your access token is super-secret\n"
+    stdout.should
     stderr.should be_empty
   end
 
@@ -17,6 +19,6 @@ describe Travis::CLI::Token do
     run_cli('token').should_not be_success
 
     stdout.should be_empty
-    stderr.should == "not logged in, please run #{File.basename($0)} login\n"
+    stderr.should == "not logged in, please run #{File.basename($PROGRAM_NAME)} login\n"
   end
 end

data/spec/cli/version_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 
 describe Travis::CLI::Version do

data/spec/cli/whoami_spec.rb

@@ -1,32 +1,34 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 
 describe Travis::CLI::Whoami do
-  example "travis whoami" do
+  example 'travis whoami' do
     run_cli('whoami').should_not be_success
     stdout.should be_empty
-    stderr.should be == "not logged in, please run #{File.basename $0} login\n"
+    stderr.should be == "not logged in, please run #{File.basename $PROGRAM_NAME} login\n"
   end
 
-  example "travis whoami --pro" do
+  example 'travis whoami --pro' do
     run_cli('whoami', '--pro').should_not be_success
     stdout.should be_empty
-    stderr.should be == "not logged in, please run #{File.basename $0} login --pro\n"
+    stderr.should be == "not logged in, please run #{File.basename $PROGRAM_NAME} login\n"
   end
 
-  example "travis whoami -t token" do
+  example 'travis whoami -t token' do
     run_cli('whoami', '-t', 'token').should be_success
     stdout.should be == "rkh\n"
     stderr.should be_empty
   end
 
-  example "TRAVIS_TOKEN=token travis whoami" do
+  example 'TRAVIS_TOKEN=token travis whoami' do
     ENV['TRAVIS_TOKEN'] = 'token'
     run_cli('whoami').should be_success
     stdout.should be == "rkh\n"
     stderr.should be_empty
   end
 
-  example "travis whoami -t token -i" do
+  example 'travis whoami -t token -i' do
     run_cli('whoami', '-t', 'token', '-i').should be_success
     stdout.should be == "You are rkh (Konstantin Haase)\n"
     stderr.should be_empty

data/spec/client/account_spec.rb

@@ -1,32 +1,40 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 
 describe Travis::Client::Account do
-  context "from all accounts" do
-    let(:session) { Travis::Client.new }
+  context 'with all accounts' do
     subject { session.accounts.first }
-    its(:name) { should be == 'Konstantin Haase' }
-    its(:login) { should be == 'rkh' }
-    its(:type) { should be == 'user' }
-    its(:repos_count) { should be == 200 }
-    its(:inspect) { should be == "#<Travis::Client::Account: rkh>" }
-  end
 
-  context "known account" do
     let(:session) { Travis::Client.new }
-    subject { session.account('rkh') }
-    its(:name) { should be == 'Konstantin Haase' }
-    its(:login) { should be == 'rkh' }
-    its(:type) { should be == 'user' }
-    its(:repos_count) { should be == 200 }
-    its(:inspect) { should be == "#<Travis::Client::Account: rkh>" }
+
+    its(:name) { is_expected.to be == 'Konstantin Haase' }
+    its(:login) { is_expected.to be == 'rkh' }
+    its(:type) { is_expected.to be == 'user' }
+    its(:repos_count) { is_expected.to be == 200 }
+    its(:inspect) { is_expected.to be == '#<Travis::Client::Account: rkh>' }
   end
 
-  context "known account" do
+  context 'with known account' do
+    subject { session.account('rkh') }
+
     let(:session) { Travis::Client.new }
+
+    its(:name) { is_expected.to be == 'Konstantin Haase' }
+    its(:login) { is_expected.to be == 'rkh' }
+    its(:type) { is_expected.to be == 'user' }
+    its(:repos_count) { is_expected.to be == 200 }
+    its(:inspect) { is_expected.to be == '#<Travis::Client::Account: rkh>' }
+  end
+
+  context 'with known account and nil name' do
     subject { session.account('foo') }
-    its(:name) { should be_nil }
-    its(:login) { should be == 'foo' }
-    its(:type) { should be_nil }
-    its(:inspect) { should be == "#<Travis::Client::Account: foo>" }
+
+    let(:session) { Travis::Client.new }
+
+    its(:name) { is_expected.to be_nil }
+    its(:login) { is_expected.to be == 'foo' }
+    its(:type) { is_expected.to be_nil }
+    its(:inspect) { is_expected.to be == '#<Travis::Client::Account: foo>' }
   end
 end

data/spec/client/auto_login_spec.rb

@@ -1,22 +1,25 @@
+# frozen_string_literal: true
+
 require 'travis/client/auto_login'
 require 'spec_helper'
 
 describe Travis::Client::AutoLogin do
-  let(:auto_login_with_token) { Travis::Client::AutoLogin.new(Travis::Client.new, { config_file: travis_config }) }
-  let(:auto_login_without_token) { Travis::Client::AutoLogin.new(Travis::Client.new) }
-  let(:travis_config) { File.expand_path("../support/fake_travis_config.yml", File.dirname(__FILE__)) }
+  let(:auto_login_with_token) { described_class.new(Travis::Client.new, { config_file: travis_config }) }
+  let(:auto_login_without_token) { described_class.new(Travis::Client.new) }
+  let(:travis_config) { File.expand_path('../support/fake_travis_config.yml', File.dirname(__FILE__)) }
 
-  context "authenticate" do
-    context "when user has a token in cli config" do
-      it "does not call Tools::Github#with_token" do
-        expect_any_instance_of(Travis::Tools::Github).to_not receive(:with_token)
+  context 'when user authenticates' do
+    context 'when user has a token in cli config' do
+      it 'does not call Tools::Github#with_token' do
+        expect_any_instance_of(Travis::Tools::Github).not_to receive(:with_token)
         auto_login_with_token.authenticate
       end
     end
 
-    context "when user does not have a token in cli config" do
+    context 'when user does not have a token in cli config' do
       before { auto_login_without_token.github.stub(:with_token).and_return(true) }
-      it "calls Tools::Github#with_token" do
+
+      it 'calls Tools::Github#with_token' do
         expect(auto_login_without_token.github).to receive(:with_token)
         auto_login_without_token.authenticate
       end

data/spec/client/broadcast_spec.rb

@@ -1,10 +1,12 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 
 describe Travis::Client::Broadcast do
-  let(:session) { Travis::Client.new }
   subject { session.broadcasts.first }
 
-  its(:id) { should be == 1 }
-  its(:message) { should be == "Hello!" }
+  let(:session) { Travis::Client.new }
 
+  its(:id) { is_expected.to be == 1 }
+  its(:message) { is_expected.to be == 'Hello!' }
 end

data/spec/client/build_spec.rb

@@ -1,31 +1,35 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 
 describe Travis::Client::Build do
+  subject { session.build(4_125_095) }
+
   let(:session) { Travis::Client.new }
-  subject { session.build(4125095) }
-  its(:number) { should be == '6180' }
-  its(:state) { should be == 'failed' }
-  its(:duration) { should be == 5019 }
-  its(:started_at) { should be_a(Time) }
-  its(:finished_at) { should be_nil }
-  its(:inspect) { should be == "#<Travis::Client::Build: rails/rails#6180>" }
-  its(:color) { should be == 'red' }
-  its(:commit) { should be_a(Travis::Client::Commit) }
-  its(:jobs) { should be_an(Array) }
-  its(:repository) { should be == session.repo('rails/rails') }
 
-  it { should be == subject.repository.last_build }
+  its(:number) { is_expected.to be == '6180' }
+  its(:state) { is_expected.to be == 'failed' }
+  its(:duration) { is_expected.to be == 5019 }
+  its(:started_at) { is_expected.to be_a(Time) }
+  its(:finished_at) { is_expected.to be_nil }
+  its(:inspect) { is_expected.to be == '#<Travis::Client::Build: rails/rails#6180>' }
+  its(:color) { is_expected.to be == 'red' }
+  its(:commit) { is_expected.to be_a(Travis::Client::Commit) }
+  its(:jobs) { is_expected.to be_an(Array) }
+  its(:repository) { is_expected.to be == session.repo('rails/rails') }
+
+  it { is_expected.to be == subject.repository.last_build }
 
-  it { should_not be_pending  }
-  it { should     be_started  }
-  it { should     be_finished }
-  it { should_not be_passed   }
-  it { should_not be_errored  }
-  it { should     be_failed   }
-  it { should_not be_canceled }
-  it { should     be_created  }
-  it { should     be_red      }
-  it { should_not be_green    }
-  it { should_not be_yellow   }
-  it { should be_unsuccessful }
+  it { is_expected.not_to be_pending  }
+  it { is_expected.to     be_started  }
+  it { is_expected.to     be_finished }
+  it { is_expected.not_to be_passed   }
+  it { is_expected.not_to be_errored  }
+  it { is_expected.to     be_failed   }
+  it { is_expected.not_to be_canceled }
+  it { is_expected.to     be_created  }
+  it { is_expected.to     be_red      }
+  it { is_expected.not_to be_green    }
+  it { is_expected.not_to be_yellow   }
+  it { is_expected.to be_unsuccessful }
 end

data/spec/client/commit_spec.rb

@@ -1,22 +1,25 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 
 describe Travis::Client::Build do
+  subject { session.build(4_125_095).commit }
+
   let(:session) { Travis::Client.new }
-  subject { session.build(4125095).commit }
 
-  its(:sha) { should be == 'a0265b98f16c6e33be32aa3f57231d1189302400' }
-  its(:short_sha) { should be == 'a0265b9' }
-  its(:branch) { should be == 'master' }
-  its(:message) { should be == 'Associaton -> Association' }
-  its(:committed_at) { should be_a(Time) }
-  its(:author_name) { should be == 'Steve Klabnik' }
-  its(:author_email) { should be == 'steve@steveklabnik.com' }
-  its(:committer_name) { should be == 'Steve Klabnik' }
-  its(:committer_email) { should be == 'steve@steveklabnik.com' }
-  its(:compare_url) { should be == 'https://github.com/rails/rails/compare/6581d798e830...a0265b98f16c' }
-  its(:subject) { should be == 'Associaton -> Association' }
+  its(:sha) { is_expected.to be == 'a0265b98f16c6e33be32aa3f57231d1189302400' }
+  its(:short_sha) { is_expected.to be == 'a0265b9' }
+  its(:branch) { is_expected.to be == 'master' }
+  its(:message) { is_expected.to be == 'Associaton -> Association' }
+  its(:committed_at) { is_expected.to be_a(Time) }
+  its(:author_name) { is_expected.to be == 'Steve Klabnik' }
+  its(:author_email) { is_expected.to be == 'steve@steveklabnik.com' }
+  its(:committer_name) { is_expected.to be == 'Steve Klabnik' }
+  its(:committer_email) { is_expected.to be == 'steve@steveklabnik.com' }
+  its(:compare_url) { is_expected.to be == 'https://github.com/rails/rails/compare/6581d798e830...a0265b98f16c' }
+  its(:subject) { is_expected.to be == 'Associaton -> Association' }
 
-  specify "with missing data" do
-    session.load("commit" => { "id" => 12 })['commit'].subject.should be_empty
+  specify 'with missing data' do
+    session.load('commit' => { 'id' => 12 })['commit'].subject.should be_empty
   end
 end

data/spec/client/job_spec.rb

@@ -1,30 +1,34 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 
 describe Travis::Client::Job do
+  subject { session.job(4_125_097) }
+
   let(:session) { Travis::Client.new }
-  subject { session.job(4125097) }
-  its(:number) { should be == '6180.2' }
-  its(:state) { should be == 'passed' }
-  its(:started_at) { should be_a(Time) }
-  its(:finished_at) { should be_a(Time) }
-  its(:inspect) { should be == "#<Travis::Client::Job: rails/rails#6180.2>" }
-  its(:color) { should be == 'green' }
-  its(:commit) { should be_a(Travis::Client::Commit) }
-  its(:repository) { should be == session.repo('rails/rails') }
-  its(:duration) { should be == 905 }
 
-  it { should be == subject.build.jobs[1] }
+  its(:number) { is_expected.to be == '6180.2' }
+  its(:state) { is_expected.to be == 'passed' }
+  its(:started_at) { is_expected.to be_a(Time) }
+  its(:finished_at) { is_expected.to be_a(Time) }
+  its(:inspect) { is_expected.to be == '#<Travis::Client::Job: rails/rails#6180.2>' }
+  its(:color) { is_expected.to be == 'green' }
+  its(:commit) { is_expected.to be_a(Travis::Client::Commit) }
+  its(:repository) { is_expected.to be == session.repo('rails/rails') }
+  its(:duration) { is_expected.to be == 905 }
+
+  it { is_expected.to be == subject.build.jobs[1] }
 
-  it { should_not be_pending      }
-  it { should     be_started      }
-  it { should     be_finished     }
-  it { should     be_passed       }
-  it { should_not be_errored      }
-  it { should_not be_failed       }
-  it { should_not be_canceled     }
-  it { should     be_created      }
-  it { should_not be_red          }
-  it { should     be_green        }
-  it { should_not be_yellow       }
-  it { should_not be_unsuccessful }
+  it { is_expected.not_to be_pending      }
+  it { is_expected.to     be_started      }
+  it { is_expected.to     be_finished     }
+  it { is_expected.to     be_passed       }
+  it { is_expected.not_to be_errored      }
+  it { is_expected.not_to be_failed       }
+  it { is_expected.not_to be_canceled     }
+  it { is_expected.to     be_created      }
+  it { is_expected.not_to be_red          }
+  it { is_expected.to     be_green        }
+  it { is_expected.not_to be_yellow       }
+  it { is_expected.not_to be_unsuccessful }
 end

data/spec/client/methods_spec.rb

@@ -1,13 +1,17 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 
 describe Travis::Client::Methods do
+  subject { OpenStruct.new(session:).extend(described_class) }
+
   let(:session) { Travis::Client.new }
-  subject { OpenStruct.new(:session => session).extend(Travis::Client::Methods) }
+
   before { subject.access_token = 'token' }
 
-  its(:api_endpoint) { should be == 'https://api.travis-ci.org/' }
-  its(:repos) { should be == session.find_many(Travis::Client::Repository) }
-  its(:user) { should be == session.find_one(Travis::Client::User) }
+  its(:api_endpoint) { is_expected.to be == 'https://api.travis-ci.com/' }
+  its(:repos) { is_expected.to be == session.find_many(Travis::Client::Repository) }
+  its(:user) { is_expected.to be == session.find_one(Travis::Client::User) }
 
   it 'fetches a single repo' do
     subject.repo(891).slug.should be == 'rails/rails'

data/spec/client/namespace_spec.rb

@@ -1,18 +1,22 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 
 describe Travis::Client::Namespace do
-  it { should be_a(Travis::Client::Methods) }
+  subject(:namespace) { described_class.new }
+
+  it { is_expected.to be_a(Travis::Client::Methods) }
 
   it 'creates a dummy for repos' do
-    repo = subject::Repository
+    repo = namespace::Repository
     repo.find_one('rails/rails').should be_a(Travis::Client::Repository)
     repo.find_many.should be_an(Array)
     repo.current.should be == repo.find_many
   end
 
   it 'creates a dummy for user' do
-    subject.access_token = 'token'
-    user = subject::User
+    namespace.access_token = 'token'
+    user = namespace::User
     user.find_one.should be_a(Travis::Client::User)
     user.current.should be == user.find_one
   end

data/spec/client/repository_spec.rb

@@ -1,39 +1,42 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 
 describe Travis::Client::Repository do
+  subject(:repository) { session.repo('rails/rails') }
+
   let(:session) { Travis::Client.new }
-  subject { session.repo('rails/rails') }
 
-  its(:slug) { should be == 'rails/rails' }
-  its(:description) { should_not be_empty }
-  its(:last_build_id) { should be == 4125095 }
-  its(:last_build_number) { should be == '6180' }
-  its(:last_build_state) { should be == 'failed' }
-  its(:last_build_duration) { should be == 5019 }
-  its(:last_build_started_at) { should be_a(Time) }
-  its(:last_build_finished_at) { should be_nil }
-  its(:inspect) { should be == "#<Travis::Client::Repository: rails/rails>" }
-  its(:key) { should be_a(Travis::Client::Repository::Key) }
-  its(:last_build) { should be_a(Travis::Client::Build) }
-  its(:color) { should be == 'red' }
-  its(:github_language) { should be == 'Ruby' }
-  its(:owner_name) { should be == 'rails' }
-  its(:owner) { should be == session.account("rails") }
+  its(:slug) { is_expected.to be == 'rails/rails' }
+  its(:description) { is_expected.not_to be_empty }
+  its(:last_build_id) { is_expected.to be == 4_125_095 }
+  its(:last_build_number) { is_expected.to be == '6180' }
+  its(:last_build_state) { is_expected.to be == 'failed' }
+  its(:last_build_duration) { is_expected.to be == 5019 }
+  its(:last_build_started_at) { is_expected.to be_a(Time) }
+  its(:last_build_finished_at) { is_expected.to be_nil }
+  its(:inspect) { is_expected.to be == '#<Travis::Client::Repository: rails/rails>' }
+  its(:key) { is_expected.to be_a(Travis::Client::Repository::Key) }
+  its(:last_build) { is_expected.to be_a(Travis::Client::Build) }
+  its(:color) { is_expected.to be == 'red' }
+  its(:github_language) { is_expected.to be == 'Ruby' }
+  its(:owner_name) { is_expected.to be == 'rails' }
+  its(:owner) { is_expected.to be == session.account('rails') }
 
-  it { should_not be_pending  }
-  it { should     be_started  }
-  it { should     be_finished }
-  it { should_not be_passed   }
-  it { should_not be_errored  }
-  it { should     be_failed   }
-  it { should_not be_canceled }
-  it { should     be_created  }
-  it { should     be_red      }
-  it { should_not be_green    }
-  it { should_not be_yellow   }
-  it { should be_unsuccessful }
+  it { is_expected.not_to be_pending  }
+  it { is_expected.to     be_started  }
+  it { is_expected.to     be_finished }
+  it { is_expected.not_to be_passed   }
+  it { is_expected.not_to be_errored  }
+  it { is_expected.to     be_failed   }
+  it { is_expected.not_to be_canceled }
+  it { is_expected.to     be_created  }
+  it { is_expected.to     be_red      }
+  it { is_expected.not_to be_green    }
+  it { is_expected.not_to be_yellow   }
+  it { is_expected.to be_unsuccessful }
 
-  it 'should expose the pubkey fingerprint' do
-    subject.public_key.fingerprint.should be == 'foobar'
+  it 'exposes the pubkey fingerprint' do
+    repository.public_key.fingerprint.should be == 'foobar'
   end
 end