travis 1.11.0 → 1.12.0

data/lib/travis/cli/report.rb

@@ -1,65 +1,72 @@
+# frozen_string_literal: true
+
 require 'travis/cli'
 require 'travis/tools/system'
 
 module Travis
   module CLI
     class Report < ApiCommand
-      description "generates a report useful for filing issues"
+      description 'generates a report useful for filing issues'
       on '-r', '--known-repos', 'include repositories in report'
       skip :authenticate, :clear_error
 
       def run
-        display("System",    :general)
-        display("CLI",       :cli_info)
-        display("Session",   :session_info)
-        display("Endpoints", :endpoints)
-        display("Known Repositories", :known_repos) if known_repos?
+        display('System',    :general)
+        display('CLI',       :cli_info)
+        display('Session',   :session_info)
+        display('Endpoints', :endpoints)
+        display('Known Repositories', :known_repos) if known_repos?
         display_error
-        say "For issues with the command line tool, please visit #{color("https://github.com/travis-ci/travis.rb/issues", :underline)}."
-        say "For Travis CI in general, go to #{color("https://github.com/travis-ci/travis-ci/issues", :underline)} or email #{color("support@travis-ci.com", :underline)}."
+        say "For issues with the command line tool, please visit #{color(
+          'https://github.com/travis-ci/travis.rb/issues', :underline
+        )}."
+        say "For Travis CI in general, go to #{color('https://github.com/travis-ci/travis-ci/issues',
+                                                     :underline)} or email #{color('support@travis-ci.com',
+                                                                                   :underline)}."
       end
 
       def display_error
-        return unless error = load_file("error.log")
-        display("Last Exception", :say, color(error, :info))
+        return unless (error = load_file('error.log'))
+
+        display('Last Exception', :say, color(error, :info))
       end
 
       def display(title, method, *args)
-        say color(title, [:bold, :underline])
+        say color(title, %i[bold underline])
         send(method, *args) { |*a| list(*a) }
         puts
       end
 
       def list(key, value, additional = nil)
         value = case value
-                when Array then value.empty? ? 'none' : value.map(&:inspect).join(", ")
-                when true  then "yes"
-                when false then "no"
-                when nil   then "unknown"
+                when Array then value.empty? ? 'none' : value.map(&:inspect).join(', ')
+                when true  then 'yes'
+                when false then 'no'
+                when nil   then 'unknown'
                 else value.to_s
                 end
         additional &&= " (#{additional})"
-        say "#{key}:".ljust(known_repos? ? 50 : 25) << " " << color(value.to_s, :bold) << additional.to_s
+        say "#{key}:".ljust(known_repos? ? 50 : 25) << ' ' << color(value.to_s, :bold) << additional.to_s
       end
 
       def general
-        yield "Ruby",               Tools::System.ruby
-        yield "Operating System",   Tools::System.os
-        yield "RubyGems",           Tools::System.rubygems
+        yield 'Ruby',               Tools::System.ruby
+        yield 'Operating System',   Tools::System.os
+        yield 'RubyGems',           Tools::System.rubygems
       end
 
       def cli_info
-        yield "Version",            Travis::VERSION
-        yield "Plugins",            defined?(TRAVIS_PLUGINS) ? TRAVIS_PLUGINS : []
-        yield "Auto-Completion",    Tools::Completion.completion_installed?
-        yield "Last Version Check", last_check['at'] ? Time.at(last_check['at']) : 'never'
+        yield 'Version',            Travis::VERSION
+        yield 'Plugins',            defined?(TRAVIS_PLUGINS) ? TRAVIS_PLUGINS : []
+        yield 'Auto-Completion',    Tools::Completion.completion_installed?
+        yield 'Last Version Check', last_check['at'] ? Time.at(last_check['at']) : 'never'
       end
 
       def session_info
-        yield "API Endpoint",       api_endpoint
-        yield "Logged In",          user_info
-        yield "Verify SSL",         !insecure
-        yield "Enterprise",         enterprise?
+        yield 'API Endpoint',       api_endpoint
+        yield 'Logged In',          user_info
+        yield 'Verify SSL',         !insecure
+        yield 'Enterprise',         enterprise?
       end
 
       def endpoints
@@ -74,25 +81,25 @@ module Travis
         end
       end
 
-      def endpoint_name(url, prefix = "")
+      def endpoint_name(url, prefix = '')
         case url
         when Travis::Client::ORG_URI  then "#{prefix}org"
         when Travis::Client::COM_URI  then "#{prefix}com"
-        when /api-staging\.travis-ci/ then endpoint_name(url.sub("api-staging.", "api."), "staging-")
+        when /api-staging\.travis-ci/ then endpoint_name(url.sub('api-staging.', 'api.'), 'staging-')
         else
-          key, _ = config['enterprise'].detect { |k,v| v.start_with? url } if config['enterprise'].respond_to?(:detect)
-          key ? "enterprise %p" % key : "???"
+          key, = config['enterprise'].detect { |_k, v| v.start_with? url } if config['enterprise'].respond_to?(:detect)
+          key ? 'enterprise %p' % key : '???'
         end
       end
 
       def known_repos
-        config["repos"].each do |key, info|
+        config['repos'].each do |key, info|
           yield key, info['endpoint']
         end
       end
 
       def user_info
-        access_token ? "as %p" % user.login : "no"
+        access_token ? 'as %p' % user.login : 'no'
       rescue Travis::Client::Error => e
         e.message
       end

data/lib/travis/cli/repos.rb

@@ -1,9 +1,11 @@
+# frozen_string_literal: true
+
 require 'travis/cli'
 
 module Travis
   module CLI
     class Repos < ApiCommand
-      description "lists repositories the user has certain permissions on"
+      description 'lists repositories the user has certain permissions on'
       on('-m', '--match PATTERN', 'only list repositories matching the given pattern (shell style)')
       on('-o', '--owner LOGIN', 'only list repos for a certain owner')
       on('-n', '--name NAME', 'only list repos with a given name')
@@ -15,11 +17,12 @@ module Travis
       def run
         repositories.each do |repo|
           next say(repo.slug) unless interactive?
+
           state_color = repo.active? ? :green : :yellow
-          say color(repo.slug, [:bold, state_color]) + " "
-          say color("(" << attributes(repo).map { |n,v| "#{n}: #{v ? "yes" : "no"}" }.join(", ") << ")", state_color)
+          say "#{color(repo.slug, [:bold, state_color])} "
+          say color('(' << attributes(repo).map { |n, v| "#{n}: #{v ? 'yes' : 'no'}" }.join(', ') << ')', state_color)
           description = repo.description.lines.first.chomp unless repo.description.to_s.empty?
-          say "Description: #{description || "???"}"
+          say "Description: #{description || '???'}"
           empty_line unless repo == repositories.last
         end
       end
@@ -29,21 +32,23 @@ module Travis
           repos = session.hooks.concat(user.repositories).uniq
           session.preload(repos).sort_by(&:slug).select do |repo|
             next false unless match? repo.slug
-            next false unless active.nil? or repo.active?    == active
-            next false unless owner.nil?  or repo.owner_name == owner
-            next false unless name.nil?   or repo.name       == name
-            next false unless admin.nil?  or repo.admin?     == admin
+            next false unless active.nil? || (repo.active?    == active)
+            next false unless owner.nil?  || (repo.owner_name == owner)
+            next false unless name.nil?   || (repo.name       == name)
+            next false unless admin.nil?  || (repo.admin?     == admin)
+
             true
           end
         end
       end
 
       def attributes(repo)
-        { "active" => repo.active?, "admin" => repo.admin?, "push" => repo.push?, "pull" => repo.pull? }
+        { 'active' => repo.active?, 'admin' => repo.admin?, 'push' => repo.push?, 'pull' => repo.pull? }
       end
 
       def match?(string)
         return true if match.nil?
+
         flags = File::FNM_PATHNAME | File::FNM_DOTMATCH
         flags |= File::FNM_EXTGLOB if defined? File::FNM_EXTGLOB
         File.fnmatch?(match, string, flags)

data/lib/travis/cli/requests.rb

@@ -1,9 +1,11 @@
+# frozen_string_literal: true
+
 require 'travis/cli'
 
 module Travis
   module CLI
     class Requests < RepoCommand
-      description "lists recent requests"
+      description 'lists recent requests'
       on '-l', '--limit LIMIT', 'Maximum number requests to display'
 
       def run
@@ -16,18 +18,17 @@ module Travis
 
           case request.event_type
           when 'push'
-            result      = request.result || "received"
+            result      = request.result || 'received'
             message     = request.message
-            message   ||= "validation pending"  unless request.rejected? or request.accepted?
-            message   ||= "unknown reason"      unless request.accepted?
-            message   ||= "triggered new build" unless request.rejected?
-            description = "push to #{request.branch || request.tag || "???"}"
+            message   ||= 'validation pending'  unless request.rejected? || request.accepted?
+            message   ||= 'unknown reason'      unless request.accepted?
+            message   ||= 'triggered new build' unless request.rejected?
+            description = "push to #{request.branch || request.tag || '???'}"
           when 'pull_request'
-            result      = request.result || "received"
+            result      = request.result || 'received'
             message     = request.message
-            message   ||= "HEAD commit not updated" unless request.accepted?
-            message   ||= "triggered new build"     unless request.rejected?
-            description = "push to #{request.branch || request.tag || "???"}"
+            message   ||= 'HEAD commit not updated' unless request.accepted?
+            message   ||= 'triggered new build'     unless request.rejected?
             description = "PR ##{request.pull_request_number}"
           end
 
@@ -35,9 +36,9 @@ module Travis
             color(description, [:bold, style]),
             color(result, style),
             color("(#{message})", style)
-          ].join(" ").strip + "\n"
+          ].join(' ').strip + "\n"
 
-          say "  " + color(request.commit.short_sha, :bold) + " - " + request.commit.subject if request.commit
+          say "  #{color(request.commit.short_sha, :bold)} - #{request.commit.subject}" if request.commit
           say "  received at: #{formatter.time(request.created_at)}"
           empty_line
         end

data/lib/travis/cli/restart.rb

@@ -1,9 +1,11 @@
+# frozen_string_literal: true
+
 require 'travis/cli'
 
 module Travis
   module CLI
     class Restart < RepoCommand
-      description "restarts a build or job"
+      description 'restarts a build or job'
 
       def run(number = last_build.number)
         authenticate
@@ -11,7 +13,7 @@ module Travis
         error "could not find job or build #{repository.slug}##{number}" unless entity
         entity.restart
 
-        say "restarted", "#{entity.class.one} ##{entity.number} has been %s"
+        say 'restarted', "#{entity.class.one} ##{entity.number} has been %s"
       end
     end
   end

data/lib/travis/cli/settings.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'travis/cli'
 
 module Travis
@@ -5,49 +7,52 @@ module Travis
     class Settings < RepoCommand
       attr_accessor :setting
 
-      description "access repository settings"
+      description 'access repository settings'
       on('--keys', 'always use setting key instead of description')
-      on('-t', '--enable',  'enable boolean setting(s)')  { |c  | c.setting = true  }
-      on('-f', '--disable', 'disable boolean setting(s)') { |c  | c.setting = false }
-      on('-s', '--set VALUE', 'set to given value')       { |c,v| c.setting = v     }
+      on('-t', '--enable',  'enable boolean setting(s)')  { |c| c.setting = true  }
+      on('-f', '--disable', 'disable boolean setting(s)') { |c| c.setting = false }
+      on('-s', '--set VALUE', 'set to given value')       { |c, v| c.setting = v }
       on('-c', '--configure', 'change settings interactively')
 
       DESCRIPTIONS = {
-        :builds_only_with_travis_yml => "Only run builds with a .travis.yml",
-        :build_pushes                => "Build pushes",
-        :build_pull_requests         => "Build pull requests",
-        :maximum_number_of_builds    => "Maximum number of concurrent builds",
-        :auto_cancel_pushes          => "Cancel older push builds that are not yet running",
-        :auto_cancel_pull_requests   => "Cancel older pull request builds that are not yet running"
-      }
+        builds_only_with_travis_yml: 'Only run builds with a .travis.yml',
+        build_pushes: 'Build pushes',
+        build_pull_requests: 'Build pull requests',
+        maximum_number_of_builds: 'Maximum number of concurrent builds',
+        auto_cancel_pushes: 'Cancel older push builds that are not yet running',
+        auto_cancel_pull_requests: 'Cancel older pull request builds that are not yet running'
+      }.freeze
 
       def run(*keys)
-        exit 1 if interactive? and keys.empty? and !setting.nil? and !all_settings? and !configure?
+        exit 1 if interactive? && keys.empty? && !setting.nil? && !all_settings? && !configure?
         authenticate
-        say repository.slug, "Settings for %s:"
+        say repository.slug, 'Settings for %s:'
         repository.settings.to_h.each do |key, value|
-          next unless keys.empty? or keys.include? key
+          next unless keys.empty? || keys.include?(key)
+
           if configure?
-            if boolean? key
-              repository.settings[key] = agree("#{describe(key, "enable #{key}")}? ") do |q|
-                default   = setting.nil? ? value : setting
-                q.default = default ? "yes" : "no"
-              end
-            else
-              repository.settings[key] = ask("#{describe(key,  "Value for #{key}")}: ", Integer) do |q|
-                default   = setting.to_i if setting and setting.respond_to? :to_i
-                default ||= value
-                default ||= 0
-                q.default = default
-              end
-            end
+            repository.settings[key] = if boolean? key
+                                         agree("#{describe(key, "enable #{key}")}? ") do |q|
+                                           default   = setting.nil? ? value : setting
+                                           q.default = default ? 'yes' : 'no'
+                                         end
+                                       else
+                                         ask("#{describe(key, "Value for #{key}")}: ", Integer) do |q|
+                                           default   = setting.to_i if setting && setting.respond_to?(:to_i)
+                                           default ||= value
+                                           default ||= 0
+                                           q.default = default
+                                         end
+                                       end
           else
             value  = repository.settings[key] = setting unless setting.nil?
-            descr  = color(describe(key, color(key, :info)) { |s| key.ljust(30) + " " + color(s, [:reset, :bold]) }, :info)
-            say format_value(value) << " " << descr
+            descr  = color(describe(key, color(key, :info)) do |s|
+                             "#{key.ljust(30)} #{color(s, %i[reset bold])}"
+                           end, :info)
+            say format_value(value) << ' ' << descr
           end
         end
-        repository.settings.save if configure? or !setting.nil?
+        repository.settings.save if configure? || !setting.nil?
       end
 
       def boolean?(key)
@@ -56,20 +61,21 @@ module Travis
 
       def format_value(value)
         case value
-        when false, nil then color("[-]", [ :bold, :red   ])
-        when true       then color("[+]", [ :bold, :green ])
-        else color(value.to_s.rjust(3),    [ :bold, :blue  ])
+        when false, nil then color('[-]', %i[bold red])
+        when true       then color('[+]', %i[bold green])
+        else color(value.to_s.rjust(3), %i[bold blue])
         end
       end
 
       def all_settings?
-        agree("Really #{setting ? "enable" : "disable"} all settings? ") do |q|
-          q.default = "no"
+        agree("Really #{setting ? 'enable' : 'disable'} all settings? ") do |q|
+          q.default = 'no'
         end
       end
 
       def describe(key, description = key)
         return description if keys?
+
         desc = DESCRIPTIONS[key.to_sym]
         desc &&= yield(desc) if block_given?
         desc || description

data/lib/travis/cli/setup/anynines.rb

@@ -1,20 +1,21 @@
+# frozen_string_literal: true
+
 require 'travis/cli/setup'
 
 module Travis
   module CLI
     class Setup
       class Anynines < Service
-        description "automatic deployment to anynines"
+        description 'automatic deployment to anynines'
 
         def run
           deploy 'anynines' do |config|
-            config['username']     ||= ask("anynines username: ").to_s
-            config['password']     ||= ask("anynines password: ") { |q| q.echo = "*" }.to_s
-            config['organization'] ||= ask("anynines organization: ").to_s
-            config['space']        ||= ask("anynines space: ").to_s
+            config['username']     ||= ask('anynines username: ').to_s
+            config['password']     ||= ask('anynines password: ') { |q| q.echo = '*' }.to_s
+            config['organization'] ||= ask('anynines organization: ').to_s
+            config['space']        ||= ask('anynines space: ').to_s
           end
         end
-
       end
     end
   end

data/lib/travis/cli/setup/appfog.rb

@@ -1,16 +1,18 @@
+# frozen_string_literal: true
+
 require 'travis/cli/setup'
 
 module Travis
   module CLI
     class Setup
       class Appfog < Service
-        description "automatic deployment to Appfog"
+        description 'automatic deployment to Appfog'
 
         def run
           deploy 'appfog' do |config|
-            config['email'] = ask("Email address: ").to_s
-            config['password'] = ask("Password: ") { |q| q.echo = "*" }.to_s
-            config['app'] = ask("App name: ") { |q| q.default = repository.name }.to_s
+            config['email'] = ask('Email address: ').to_s
+            config['password'] = ask('Password: ') { |q| q.echo = '*' }.to_s
+            config['app'] = ask('App name: ') { |q| q.default = repository.name }.to_s
           end
         end
       end

data/lib/travis/cli/setup/artifacts.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'travis/cli/setup'
 
 module Travis
@@ -10,11 +12,11 @@ module Travis
         def run
           travis_config['addons'] ||= {}
           configure 'artifacts', {}, travis_config['addons'] do |config|
-            config['key'] = ask("Access key ID: ").to_s
-            config['secret'] = ask("Secret access key: ") { |q| q.echo = "*" }.to_s
-            config['bucket'] = ask("Bucket: ").to_s
-            encrypt(config, 'key') if agree("Encrypt access key ID? ") { |q| q.default = 'yes' }
-            encrypt(config, 'secret') if agree("Encrypt secret access key? ") { |q| q.default = 'yes' }
+            config['key'] = ask('Access key ID: ').to_s
+            config['secret'] = ask('Secret access key: ') { |q| q.echo = '*' }.to_s
+            config['bucket'] = ask('Bucket: ').to_s
+            encrypt(config, 'key') if agree('Encrypt access key ID? ') { |q| q.default = 'yes' }
+            encrypt(config, 'secret') if agree('Encrypt secret access key? ') { |q| q.default = 'yes' }
           end
         end
       end

data/lib/travis/cli/setup/biicode.rb

@@ -1,16 +1,18 @@
+# frozen_string_literal: true
+
 require 'travis/cli/setup'
 
 module Travis
   module CLI
     class Setup
       class Biicode < Service
-        description "automatic publish to biicode"
+        description 'automatic publish to biicode'
 
         def run
           deploy 'biicode', 'release' do |config|
-            config['user'] ||= ask("biicode username: ") { |q| q }.to_s
-            config['password'] ||= ask("biicode password: ") { |q| q.echo = "*" }.to_s
-            on("publish only tagged commits? ", config, 'tags' => true)
+            config['user'] ||= ask('biicode username: ') { |q| q }.to_s
+            config['password'] ||= ask('biicode password: ') { |q| q.echo = '*' }.to_s
+            on('publish only tagged commits? ', config, 'tags' => true)
           end
         end
       end

data/lib/travis/cli/setup/cloud_66.rb

@@ -1,20 +1,22 @@
+# frozen_string_literal: true
+
 require 'travis/cli/setup'
 
 module Travis
   module CLI
     class Setup
       class Cloud_66 < Service
-        description "Automatic deployment to Cloud 66"
+        description 'Automatic deployment to Cloud 66'
         service_name 'cloud66'
 
         def run
           deploy 'cloud66', 'release' do |config|
-            config['redeployment_hook'] ||= ask("Cloud 66 Redeployment Hook Url: ") { |q| q.echo = "*" }.to_s
+            config['redeployment_hook'] ||= ask('Cloud 66 Redeployment Hook Url: ') { |q| q.echo = '*' }.to_s
 
-            encrypt(config, 'redeployment_hook') if agree("Encrypt Redeployment Hook?") { |q| q.default = 'yes' }
+            encrypt(config, 'redeployment_hook') if agree('Encrypt Redeployment Hook?') { |q| q.default = 'yes' }
           end
         end
       end
     end
   end
-end
+end

data/lib/travis/cli/setup/cloud_control.rb

@@ -1,21 +1,23 @@
+# frozen_string_literal: true
+
 require 'travis/cli/setup'
 
 module Travis
   module CLI
     class Setup
       class CloudControl < Service
-        description "automatic deployment to cloudControl"
+        description 'automatic deployment to cloudControl'
 
         def run
           deploy 'cloudcontrol' do |config|
-            config['email']      = ask("cloudControl email: ").to_s
-            config['password']   = ask("cloudControl password: ") { |q| q.echo = "*" }.to_s
-            app                  = ask("cloudControl application: ") { |q| q.default = repository.name }.to_s
-            dep                  = ask("cloudControl deployment: ") { |q| q.default = "default" }.to_s
+            config['email']      = ask('cloudControl email: ').to_s
+            config['password']   = ask('cloudControl password: ') { |q| q.echo = '*' }.to_s
+            app                  = ask('cloudControl application: ') { |q| q.default = repository.name }.to_s
+            dep                  = ask('cloudControl deployment: ') { |q| q.default = 'default' }.to_s
             config['deployment'] = "#{app}/#{dep}"
           end
         end
       end
     end
   end
-end
+end

data/lib/travis/cli/setup/cloud_files.rb

@@ -1,17 +1,19 @@
+# frozen_string_literal: true
+
 require 'travis/cli/setup'
 
 module Travis
   module CLI
     class Setup
       class CloudFiles < Service
-        description "automatic pushing to Rackspace Cloud Files"
+        description 'automatic pushing to Rackspace Cloud Files'
 
         def run
           deploy 'cloudfiles' do |config|
-            config['username'] = ask("Rackspace Username: ").to_s
-            config['api_key'] = ask("Rackspace Api Key: ") { |q| q.echo = "*" }.to_s
-            config['region'] = ask("Cloud Files Region: ").to_s
-            config['container'] = ask("Container: ").to_s
+            config['username'] = ask('Rackspace Username: ').to_s
+            config['api_key'] = ask('Rackspace Api Key: ') { |q| q.echo = '*' }.to_s
+            config['region'] = ask('Cloud Files Region: ').to_s
+            config['container'] = ask('Container: ').to_s
           end
         end
       end

data/lib/travis/cli/setup/cloud_foundry.rb

@@ -1,20 +1,22 @@
+# frozen_string_literal: true
+
 require 'travis/cli/setup'
 
 module Travis
   module CLI
     class Setup
       class CloudFoundry < Service
-        description "automatic deployment to Cloud Foundry"
+        description 'automatic deployment to Cloud Foundry'
 
         def run
           deploy 'cloudfoundry' do |config|
             target_file = File.expand_path('.cf/config.json', Dir.home)
-            config['api']       ||= JSON.parse(File.read(target_file))["Target"] if File.exist? target_file
-            config['api']       ||= ask("Cloud Foundry api: ").to_s
-            config['username']     ||= ask("Cloud Foundry username: ").to_s
-            config['password']     ||= ask("Cloud Foundry password: ") { |q| q.echo = "*" }.to_s
-            config['organization'] ||= ask("Cloud Foundry organization: ").to_s
-            config['space']        ||= ask("Cloud Foundry space: ").to_s
+            config['api']       ||= JSON.parse(File.read(target_file))['Target'] if File.exist? target_file
+            config['api']       ||= ask('Cloud Foundry api: ').to_s
+            config['username']     ||= ask('Cloud Foundry username: ').to_s
+            config['password']     ||= ask('Cloud Foundry password: ') { |q| q.echo = '*' }.to_s
+            config['organization'] ||= ask('Cloud Foundry organization: ').to_s
+            config['space']        ||= ask('Cloud Foundry space: ').to_s
           end
         end
       end