travis-lint 1.1.0 → 1.2.0

data/lib/travis/lint/linter.rb

@@ -81,11 +81,54 @@ module Travis
         hsh[:rvm].is_a?(Array) && hsh[:rvm].include?("1.8.6")
       end
 
+      DOCS_URL = "Travis CI documentation at http://bit.ly/travis-ci-environment"
+
+      validator_for :ruby, :rvm, "Detected unsupported Ruby versions. For an up-to-date list of supported Rubies, see #{DOCS_URL}" do |hsh|
+        ("ruby" == hsh[:language].to_s.downcase) && hsh[:rvm].is_a?(Array) && !known_ruby_versions?(hsh[:rvm])
+      end
+
+      validator_for :node_js, :node_js, "Detected unsupported Node.js versions. For an up-to-date list of supported Node.js versions, see #{DOCS_URL}" do |hsh|
+        ("node_js" == hsh[:language].to_s.downcase) && hsh[:node_js].is_a?(Array) && !known_node_js_versions?(hsh[:node_js])
+      end
+
+      validator_for :php, :php, "Detected unsupported PHP versions. For an up-to-date list of supported PHP versions, see #{DOCS_URL}" do |hsh|
+        ("php" == hsh[:language].to_s.downcase) && hsh[:php].is_a?(Array) && !known_php_versions?(hsh[:php])
+      end
+
 
 
       validator_for :ruby, :language, "Language is set to Ruby but node_js key is present. Ruby builder will ignore node_js key." do |hsh|
         hsh[:language].to_s.downcase == "ruby" && ! blank?(hsh[:node_js])
       end
+
+
+      KNOWN_RUBY_VERSIONS = %w(1.8.7 ruby-1.8.7 1.9.2 ruby-1.9.2 1.9.3 ruby-1.9.3 ruby-head jruby jruby-18mode jruby-19mode rbx rbx-18mode rbx-19mode jruby-head ree ree-1.8.7)
+      KNOWN_NODE_VERSIONS = %w(0.4 0.6 0.7)
+      KNOWN_PHP_VERSIONS  = %w(5.2 5.3 5.3.2 5.3.8 5.4)
+
+      protected
+
+      def self.known_ruby_versions?(ary)
+        ary = ary.map(&:to_s)
+
+        unknown = ary - KNOWN_RUBY_VERSIONS
+        unknown.empty?
+      end
+
+      def self.known_node_js_versions?(ary)
+        ary = ary.map(&:to_s)
+
+        unknown = ary - KNOWN_NODE_VERSIONS
+        unknown.empty?
+      end
+
+      def self.known_php_versions?(ary)
+        ary = ary.map(&:to_s)
+
+        unknown = ary - KNOWN_PHP_VERSIONS
+        unknown.empty?
+      end
+
     end
   end
 end

data/lib/travis/lint/version.rb

@@ -1,6 +1,6 @@
 module Travis
   module Lint
-    VERSION = "1.1.0"
+    VERSION = "1.2.0"
     Version = VERSION
   end
 end

data/spec/files/uses_unsupported_nodejs.yml

@@ -0,0 +1,5 @@
+language: node_js
+node_js:
+  - 0.5
+  - 110.00
+  - node-webscale

data/spec/files/uses_unsupported_php.yml

@@ -0,0 +1,5 @@
+language: php
+php:
+  - 0.5
+  - 6.0
+  - jphp

data/spec/files/uses_unsupported_rubies.yml

@@ -0,0 +1,5 @@
+language: ruby
+rvm:
+  - rubizilla
+  - ruby-1.8.7-p248
+  - goruby

data/spec/travis_lint_spec.rb

@@ -105,6 +105,56 @@ describe "A .travis.yml" do
     end
 
 
+    let(:docs) { "Travis CI documentation at http://bit.ly/travis-ci-environment" }
+
+
+    context "and uses an unsupported Ruby version" do
+      let(:unsupported_rubies) do
+        { :key => :rvm, :issue => "Detected unsupported Ruby versions. For an up-to-date list of supported Rubies, see #{docs}" }
+      end
+
+      let(:travis_yml) do
+        { :language => "ruby", :rvm => ["neoruby", "goruby", "bonanzaruby"] }
+      end
+
+      it "is invalid" do
+        Travis::Lint::Linter.validate(travis_yml).should include(unsupported_rubies)
+        Travis::Lint::Linter.valid?(content_of_sample_file("uses_unsupported_rubies.yml")).should be_false
+      end
+    end
+
+
+    context "and uses an unsupported Node.js version" do
+      let(:unsupported_nodejs) do
+        { :key => :node_js, :issue => "Detected unsupported Node.js versions. For an up-to-date list of supported Node.js versions, see #{docs}" }
+      end
+
+      let(:travis_yml) do
+        { :language => "node_js", :node_js => ["100.0", "0.5"] }
+      end
+
+      it "is invalid" do
+        Travis::Lint::Linter.validate(travis_yml).should include(unsupported_nodejs)
+        Travis::Lint::Linter.valid?(content_of_sample_file("uses_unsupported_nodejs.yml")).should be_false
+      end
+    end
+
+    context "and uses an unsupported PHP version" do
+      let(:unsupported_php) do
+        { :key => :php, :issue => "Detected unsupported PHP versions. For an up-to-date list of supported PHP versions, see #{docs}" }
+      end
+
+      let(:travis_yml) do
+        { :language => "php", :php => ["100.0", "0.5"] }
+      end
+
+      it "is invalid" do
+        Travis::Lint::Linter.validate(travis_yml).should include(unsupported_php)
+        Travis::Lint::Linter.valid?(content_of_sample_file("uses_unsupported_php.yml")).should be_false
+      end
+    end
+
+
     context "that specifies Ruby as the language but tries to set node_js version" do
       let(:travis_yml) do
         { :language => "ruby", :rvm => ["1.9.3"], :node_js => ["0.6"] }

metadata

@@ -1,13 +1,13 @@
 --- !ruby/object:Gem::Specification 
 name: travis-lint
 version: !ruby/object:Gem::Version 
-  hash: 19
+  hash: 31
   prerelease: 
   segments: 
   - 1
-  - 1
+  - 2
   - 0
-  version: 1.1.0
+  version: 1.2.0
 platform: ruby
 authors: 
 - Michael S. Klishin
@@ -16,7 +16,7 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2012-02-16 00:00:00 Z
+date: 2012-02-17 00:00:00 Z
 dependencies: 
 - !ruby/object:Gem::Dependency 
   name: hashr
@@ -79,6 +79,9 @@ files:
 - spec/files/uses_jruby_instead_of_jruby_in_specific_mode.yml
 - spec/files/uses_old_rbx_aliases.yml
 - spec/files/uses_ruby_as_language_but_tries_to_switch_nodejs.yml
+- spec/files/uses_unsupported_nodejs.yml
+- spec/files/uses_unsupported_php.yml
+- spec/files/uses_unsupported_rubies.yml
 - spec/spec_helper.rb
 - spec/travis_lint_spec.rb
 - travis-lint.gemspec
@@ -115,11 +118,5 @@ rubygems_version: 1.8.15
 signing_key: 
 specification_version: 3
 summary: Checks your .travis.yml for possible issues, deprecations and so on
-test_files: 
-- spec/files/no_language_key.yml
-- spec/files/no_rvm_key.yml
-- spec/files/uses_jruby_instead_of_jruby_in_specific_mode.yml
-- spec/files/uses_old_rbx_aliases.yml
-- spec/files/uses_ruby_as_language_but_tries_to_switch_nodejs.yml
-- spec/spec_helper.rb
-- spec/travis_lint_spec.rb
+test_files: []
+