traver 0.3.2 → 0.3.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 23992917260bb77f633cbfb7d24dbe491c966ac4
-  data.tar.gz: e435d995edbaa5cb92dd02da794be371ade59921
+  metadata.gz: e838d558b8741411bdab9c41672ac65a733faffd
+  data.tar.gz: 759f5ec6c9a5df7217e9e2b024ca56ec8d6bd1f1
 SHA512:
-  metadata.gz: 8984fe4739d900b9c7d68368b35bd1df98d643f940d607b246ac989ded037abad1528e31f455f90c6c52e710bcaf25ebeb5fe91c1a3c7583fdc3222d33286ee4
-  data.tar.gz: 11153c311605240e4e8b543e4796301f90728c83befb9850a0d82cc33fb1a04d1a916f7e097aab17202990f70bd51ab30c04133672620e32aa01e188f692e885
+  metadata.gz: a405141440336994abd7a0f0cb690ccc1b72fd14cffc10436a38a551f76105b02e6526a64c889db02641862eea4084f1ab526c2c8e9ab1495331fc1a56876e46
+  data.tar.gz: 385c70481788c78c80c4d27f46702df68b97e106702cf17f7691ab346416844b7f0c70144c91942b4838d4c04cc96aa19cf0f3945c55ce3292172be51ecfb3ef

data/README.md

@@ -1,5 +1,14 @@
 # Traver [![Build Status](https://travis-ci.org/yukas/traver.svg?branch=master)](https://travis-ci.org/yukas/traver)
 
+## Fixtures
+There are number of problems with fixtures:
+
+1. Magic values — you don't see there attribute values comes from
+2. You don't know how the record is setup, because it is not happening in context of the test
+3. Test data is centarized - if you need to change something, good chance you'll brake a lot of tests
+4. Hard to maintain — you need to manually change every fixture if your model changes
+
+## FactoryGirl
 The problem with the FactoryGirl is that it is complicated. It helps you define almost anything in terms of how complex your data model is. The thing is though — the more complex your factories the more complex seem to be the design of your system. Nobody wants to work with overcomplicated systems.
 
 We believe that factories should be simple and lightweight just to make it possible to pass validations, everything else should be defined inside the spec itself, so the person who's working with the spec has all the information in place. It is possible with FactoryGirl, but it is too verbose.
@@ -130,6 +139,13 @@ Create associated collections using factory names:
 Traver.create(blog: { title: "Hello", posts: [:published_post, :draft_post] })
 ```
 
+Create associated with already existing objects:
+
+```ruby
+Traver.create(blog: { title: "Hello", posts: [post1, post2] })
+```
+
+
 Create lists with sequences:
 
 ```ruby
@@ -197,6 +213,10 @@ post = Traver.create(:post) #=> #<Post>
 post.blog #=> #<Blog>
 ```
 
+## Plays well with FactoryGirl
+
+If you want to try out Traver for your new specs and keep using FactoryGirl for the old ones, no problem with that. Traver will detect FactoryGirl and will searching for factories inside `spec/traver_factories.rb` or `test/traver_factories.rb`.
+
 ## Development
 
 After checking out the repo, run `bin/setup` to install dependencies. Then, run `rake test` to run the tests. You can also run `bin/console` for an interactive prompt that will allow you to experiment.

data/lib/traver/factories_loader.rb

@@ -3,28 +3,43 @@ module Traver
     attr_reader :base_dir, :folder_name
     attr_reader :factories_loaded
     
-    FILE_NAME = "factories.rb"
+    FOLDER_NAMES = ["test", "spec"]
+    FILE_NAMES   = ["factories.rb", "traver_factories.rb"]
     
-    def initialize(base_dir, folder_name = "test")
+    def initialize(base_dir)
       @base_dir = base_dir
-      @folder_name = folder_name
       
       @factories_loaded = false
     end
     
     def load_factories
       unless factories_loaded
-        factories_file_path = File.join(base_dir, folder_name, FILE_NAME)
-    
-        require factories_file_path
+        FOLDER_NAMES.each do |folder_name|
+          FILE_NAMES.each do |file_name|
+            load_file(folder_name, file_name)
+          end
+        end
         
         @factories_loaded = true
       end
     end
-  end
-  
-  class NilFactoriesLoader
-    def load_factories
+    
+    private
+    
+    def load_file(folder_name, file_name)
+      file_path = File.join(base_dir, folder_name, file_name)
+      
+      if file_class.exist?(file_path)
+        kernel_module.require file_path
+      end
+    end
+    
+    def kernel_module
+      Kernel
+    end
+    
+    def file_class
+      File
     end
   end
 end

data/lib/traver/{factory_definer.rb → factories_store.rb}

@@ -1,5 +1,5 @@
 module Traver
-  class FactoryDefiner
+  class FactoriesStore
     def initialize
       undefine_all_factories
     end
@@ -8,23 +8,14 @@ module Traver
       factories[factory_name] = Factory.new(factory_name, params, factory_by_name(parent_name))
     end
     
-    alias :factory :define_factory
-    
-    def factory_params(factory_name)
-      factory_by_name(factory_name).params
-    end
-    
-    def parent_factory_name(factory_name)
-      factory_by_name(factory_name).parent_factory &&
-        factory_by_name(factory_name).parent_factory.name
-    end
-
-    def parent_factory_params(factory_name)
-      factory_by_name(factory_name).parent_factory.params
+    def factory_defined?(factory_name)
+      factories.has_key?(factory_name)
     end
     
     def factory_by_name(factory_name)
-      factories[factory_name] || default_factory(factory_name) if factory_name
+      if factory_name
+        factories[factory_name] || empty_factory(factory_name)
+      end
     end
     
     def undefine_all_factories
@@ -35,10 +26,12 @@ module Traver
       factories.keys.length
     end
     
+    alias :factory :define_factory
+    
     private
     attr_reader :factories
     
-    def default_factory(factory_name)
+    def empty_factory(factory_name)
       Factory.new(factory_name, {}, nil)
     end
   end

data/lib/traver/factory.rb

@@ -9,9 +9,17 @@ module Traver
     end
     
     def root_factory
-      parent_factory ? parent_factory.root_factory : self
+      if parent_factory
+        parent_factory.root_factory
+      else
+        self
+      end
     end
 
+    def root_name
+      root_factory.name
+    end
+    
     def inherited_params
       if parent_factory
         parent_factory.inherited_params.merge(params)
@@ -20,10 +28,6 @@ module Traver
       end
     end
     
-    def root_name
-      root_factory.name
-    end
-    
     def object_class_name
       root_factory.name.to_s.camelize
     end

data/lib/traver/graph_creator.rb

@@ -1,15 +1,15 @@
 module Traver
   class GraphCreator
-    attr_reader :factory_name, :params, :factory_definer, :sequencer
+    attr_reader :factory_name, :params, :factories_store, :sequencer
     attr_reader :graph
     
-    def initialize(factory_name, params, factory_definer, sequencer)
+    def initialize(factory_name, params, factories_store, sequencer)
       @factory_name    = factory_name
       @params          = params
-      @factory_definer = factory_definer
+      @factories_store = factories_store
       @sequencer       = sequencer
       
-      @object_creator = ObjectCreator.new(factory_name, params, factory_definer, sequencer)
+      @object_creator = ObjectCreator.new(factory_name, params, factories_store, sequencer)
       
       @graph = Graph.new
     end

data/lib/traver/list_creator.rb

@@ -1,19 +1,19 @@
 module Traver
   class ListCreator
-    attr_reader :num, :factory_name, :params, :factory_definer, :sequencer
+    attr_reader :num, :factory_name, :params, :factories_store, :sequencer
     attr_reader :list
     
-    def initialize(num, factory_name, params, factory_definer, sequencer)
+    def initialize(num, factory_name, params, factories_store, sequencer)
       @num             = num
       @factory_name    = factory_name
       @params          = params
-      @factory_definer = factory_definer
+      @factories_store = factories_store
       @sequencer       = sequencer
     end
     
     def create_list
       @list = num.times.map do
-        object_creator.create_object(factory_name, params, factory_definer, sequencer)
+        object_creator.create_object(factory_name, params, factories_store, sequencer)
       end
     end
     

data/lib/traver/object_creator.rb

@@ -44,6 +44,7 @@ module Traver
         set_nested_objects
         set_attributes
         persist_object
+        cache_object
         set_has_one_objects
         set_nested_collections
         call_after_create_hook
@@ -118,6 +119,7 @@ module Traver
         set_attribute(name, create_nested_object(value, {}))
       else
         set_attribute(name, value)
+        cache[name] = value
       end
     end
     
@@ -178,10 +180,16 @@ module Traver
           else
             raise "Wrong collection params #{params_array}"
           end
-        end
-      
-        params_array.map do |params|
-          create_nested_object(factory_name, params)
+          
+          params_array.map do |params|
+            create_nested_object(factory_name, params)
+          end
+        elsif params_array.first.is_a?(Hash)
+          params_array.map do |params|
+            create_nested_object(factory_name, params)
+          end
+        else
+          params_array
         end
       end
     end
@@ -207,6 +215,9 @@ module Traver
     
     def persist_object
       object_persister.persist_object(object)
+    end
+    
+    def cache_object
       cache[factory.root_name] = object
     end
     

data/lib/traver/traver_constructor.rb

@@ -1,22 +1,22 @@
 module Traver
   class TraverConstructor
-    attr_reader :factory_definer, :sequencer
+    attr_reader :factories_store, :sequencer
     
     def initialize
-      @factory_definer = FactoryDefiner.new
+      @factories_store = FactoriesStore.new
       @sequencer       = Sequencer.new
     end
     
     def create(*options)
       factory_name, params = parse_create_options(options)
       
-      ObjectCreator.create_object(factory_name, params, factory_definer, sequencer)
+      ObjectCreator.create_object(factory_name, params, factories_store, sequencer)
     end
     
     def create_graph(*options)
       factory_name, params = parse_create_options(options)
     
-      graph_creator = GraphCreator.new(factory_name, params, factory_definer, sequencer)
+      graph_creator = GraphCreator.new(factory_name, params, factories_store, sequencer)
       graph_creator.create_graph
     
       graph_creator.graph
@@ -25,7 +25,7 @@ module Traver
     def create_list(num, *options)
       factory_name, params = parse_create_options(options)
       
-      list_creator = ListCreator.new(num, factory_name, params, factory_definer, sequencer)
+      list_creator = ListCreator.new(num, factory_name, params, factories_store, sequencer)
       list_creator.create_list
       
       list_creator.list
@@ -40,17 +40,17 @@ module Traver
     def define_factory(factory_name, *options)
       parent_factory_name, params = parse_factory_options(options)
     
-      factory_definer.define_factory(factory_name, parent_factory_name, params)
+      factories_store.define_factory(factory_name, parent_factory_name, params)
     end
     
     alias :factory :define_factory
     
     def undefine_all_factories
-      factory_definer.undefine_all_factories
+      factories_store.undefine_all_factories
     end
     
     def factories_count
-      factory_definer.factories_count
+      factories_store.factories_count
     end
     
     private

data/lib/traver/version.rb

@@ -1,3 +1,3 @@
 module Traver
-  VERSION = "0.3.2"
+  VERSION = "0.3.3"
 end

data/lib/traver.rb

@@ -6,42 +6,39 @@ module Traver
   class Error < Exception; end
   
   class << self
-    attr_reader :factories_loaded
-    
-    def create(*options)
+    def create(*args)
       load_factories
       
-      traver_constructor.create(*options)
+      traver_constructor.create(*args)
     end
   
-    def create_graph(*options)
+    def create_graph(*args)
       load_factories
       
-      traver_constructor.create_graph(*options)
+      traver_constructor.create_graph(*args)
     end
     
-    def create_list(num, *options)
+    def create_list(*args)
       load_factories
       
-      traver_constructor.create_list(num, *options)
+      traver_constructor.create_list(*args)
     end
     
-    def define_factory(factory_name, *options)
-      traver_constructor.define_factory(factory_name, *options)
+    def define_factory(*args)
+      traver_constructor.define_factory(*args)
     end
 
-    alias :factory :define_factory
-    
     def define_factories(&block)
       traver_constructor.define_factories(&block)
     end
-    
-    alias :factories :define_factories
   
     def undefine_all_factories
       traver_constructor.undefine_all_factories
     end
-    
+
+    alias :factory   :define_factory    
+    alias :factories :define_factories
+
     private
     
     def traver_constructor
@@ -49,23 +46,11 @@ module Traver
     end
     
     def load_factories
-      unless factories_loaded
-        factories_loader.load_factories
-
-        @factories_loaded = true
-      end
+      factories_loader.load_factories
     end
     
     def factories_loader
-      if defined?(Rails)
-        if defined?(RSpec)
-          FactoriesLoader.new(Rails.root, "spec")
-        else
-          FactoriesLoader.new(Rails.root, "test")
-        end
-      else
-        NilFactoriesLoader.new
-      end
+      @factories_loader ||= FactoriesLoader.new(Dir.getwd)
     end
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: traver
 version: !ruby/object:Gem::Version
-  version: 0.3.2
+  version: 0.3.3
 platform: ruby
 authors:
 - Yuri Kaspervich
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2016-04-08 00:00:00.000000000 Z
+date: 2016-05-25 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport
@@ -116,8 +116,8 @@ files:
 - lib/traver/default_params_creators/active_record_default_params_creator.rb
 - lib/traver/default_params_creators/poro_default_params_creator.rb
 - lib/traver/factories_loader.rb
+- lib/traver/factories_store.rb
 - lib/traver/factory.rb
-- lib/traver/factory_definer.rb
 - lib/traver/graph.rb
 - lib/traver/graph_creator.rb
 - lib/traver/list_creator.rb