transpec 2.3.8 → 3.0.0

data/spec/transpec/spec_suite_spec.rb

@@ -9,9 +9,10 @@ module Transpec
     include FileHelper
     include_context 'isolated environment'
 
-    subject(:spec_suite) { SpecSuite.new(base_paths, runtime_data) }
+    subject(:spec_suite) { SpecSuite.new(project, target_paths, runtime_data) }
+    let(:project) { Project.new }
+    let(:target_paths) { [] }
     let(:runtime_data) { nil }
-    let(:base_paths) { [] }
 
     describe '#need_to_modify_yield_receiver_to_any_instance_implementation_blocks_config?' do
       subject do
@@ -79,7 +80,7 @@ module Transpec
       end
 
       context 'with runtime information' do
-        let(:runtime_data) { Transpec::DynamicAnalyzer.new(silent: true).analyze(base_paths) }
+        let(:runtime_data) { Transpec::DynamicAnalyzer.new(silent: true).analyze(target_paths) }
 
         let(:main_rspec_configure_node) do
           spec_suite.specs.each do |spec|

data/spec/transpec/syntax/current_example_spec.rb

@@ -20,7 +20,7 @@ module Transpec
         end
 
         let(:current_example_object) do
-          CurrentExample.new(target_node, source_rewriter, runtime_data)
+          CurrentExample.new(target_node, runtime_data)
         end
 
         subject { current_example_object.conversion_target? }
@@ -229,7 +229,7 @@ module Transpec
 
           let(:current_example_objects) do
             ast.each_node.each_with_object([]) do |node, objects|
-              current_example_object = CurrentExample.new(node, source_rewriter, runtime_data)
+              current_example_object = CurrentExample.new(node, runtime_data, project, source_rewriter)
               objects << current_example_object if current_example_object.conversion_target?
             end
           end

data/spec/transpec/syntax/double_spec.rb

@@ -18,7 +18,7 @@ module Transpec
         end
 
         let(:double_object) do
-          Double.new(target_node, source_rewriter, runtime_data)
+          Double.new(target_node, runtime_data)
         end
 
         subject { double_object.conversion_target? }

data/spec/transpec/syntax/example_group_spec.rb

@@ -3,11 +3,12 @@
 require 'spec_helper'
 require 'transpec/syntax/example_group'
 require 'ast'
+require 'active_support/core_ext/string/strip.rb'
 
 module Transpec
   class Syntax
     describe ExampleGroup do
-      include ::AST::Sexp
+      include ::AST::Sexp, FileHelper
       include_context 'parsed objects'
       include_context 'syntax object', ExampleGroup, :example_group
 
@@ -93,7 +94,7 @@ module Transpec
         shared_context 'multiple #describes' do
           before do
             ast.each_node do |node|
-              example_group = described_class.new(node, source_rewriter, runtime_data)
+              example_group = described_class.new(node, runtime_data, project, source_rewriter)
               next unless example_group.conversion_target?
               example_group.convert_to_non_monkey_patch!
             end
@@ -281,250 +282,305 @@ module Transpec
       end
 
       describe '#add_explicit_type_metadata!' do
-        before do
-          example_group.add_explicit_type_metadata!
-        end
+        context 'in rspec-rails project' do
+          before do
+            example_group.stub(:rspec_rails?).and_return(true)
+            example_group.add_explicit_type_metadata!
+          end
 
-        context 'when it is in top level scope' do
-          context "and expression `describe 'something' do ... end`" do
-            let(:source) do
-              <<-END
-                    describe 'something' do
-                    end
-              END
-            end
+          context 'when it is in top level scope' do
+            context "and expression `describe 'something' do ... end`" do
+              let(:source) do
+                <<-END
+                      describe 'something' do
+                      end
+                END
+              end
+
+              {
+                'controllers' => :controller,
+                'helpers'     => :helper,
+                'mailers'     => :mailer,
+                'models'      => :model,
+                'requests'    => :request,
+                'integration' => :request,
+                'api'         => :request,
+                'routing'     => :routing,
+                'views'       => :view,
+                'features'    => :feature
+              }.each do |directory, type|
+                context "and the file path is \"spec/#{directory}/some_spec.rb\"" do
+                  let(:source_path) { "spec/#{directory}/some_spec.rb" }
+
+                  let(:expected_source) do
+                    <<-END
+                      describe 'something', :type => #{type.inspect} do
+                      end
+                    END
+                  end
+
+                  it "adds metadata \":type => #{type.inspect}\"" do
+                    rewritten_source.should == expected_source
+                  end
+
+                  it "adds record `describe 'some #{type}' { }` " \
+                     "-> `describe 'some #{type}', :type => #{type.inspect} { }`" do
+                    record.old_syntax.should == "describe 'some #{type}' { }"
+                    record.new_syntax.should == "describe 'some #{type}', :type => #{type.inspect} { }"
+                  end
+                end
+              end
 
-            {
-              'controllers' => :controller,
-              'helpers'     => :helper,
-              'mailers'     => :mailer,
-              'models'      => :model,
-              'requests'    => :request,
-              'integration' => :request,
-              'api'         => :request,
-              'routing'     => :routing,
-              'views'       => :view,
-              'features'    => :feature
-            }.each do |directory, type|
-              context "and the file path is \"spec/#{directory}/some_spec.rb\"" do
-                let(:source_path) { "spec/#{directory}/some_spec.rb" }
+              context 'and the file path is "spec/contollers/some_namespace/some_spec.rb"' do
+                let(:source_path) { 'spec/controllers/some_namespace/some_spec.rb' }
 
                 let(:expected_source) do
                   <<-END
-                    describe 'something', :type => #{type.inspect} do
-                    end
+                      describe 'something', :type => :controller do
+                      end
                   END
                 end
 
-                it "adds metadata \":type => #{type.inspect}\"" do
+                it 'adds metadata ":type => :controller' do
                   rewritten_source.should == expected_source
                 end
+              end
 
-                it "adds record `describe 'some #{type}' { }` " \
-                   "-> `describe 'some #{type}', :type => #{type.inspect} { }`" do
-                  record.old_syntax.should == "describe 'some #{type}' { }"
-                  record.new_syntax.should == "describe 'some #{type}', :type => #{type.inspect} { }"
+              context 'and the file path is "spec/unit/some_spec.rb"' do
+                let(:source_path) { 'spec/unit/some_spec.rb' }
+
+                it 'does nothing' do
+                  rewritten_source.should == source
                 end
               end
-            end
 
-            context 'and the file path is "spec/contollers/some_namespace/some_spec.rb"' do
-              let(:source_path) { 'spec/controllers/some_namespace/some_spec.rb' }
+              context 'and the file path is "features/controllers/some_spec.rb"' do
+                let(:source_path) { 'features/controllers/some_spec.rb' }
 
-              let(:expected_source) do
+                it 'does nothing' do
+                  rewritten_source.should == source
+                end
+              end
+            end
+
+            context "and expression `describe 'something', :foo => :bar do ... end`" do
+              let(:source) do
                 <<-END
-                    describe 'something', :type => :controller do
+                    describe 'something', :foo => :bar do
                     end
                 END
               end
 
-              it 'adds metadata ":type => :controller' do
-                rewritten_source.should == expected_source
-              end
-            end
+              context 'and the file path is "spec/controllers/some_spec.rb"' do
+                let(:source_path) { 'spec/controllers/some_spec.rb' }
 
-            context 'and the file path is "spec/unit/some_spec.rb"' do
-              let(:source_path) { 'spec/unit/some_spec.rb' }
+                let(:expected_source) do
+                  <<-END
+                    describe 'something', :type => :controller, :foo => :bar do
+                    end
+                  END
+                end
 
-              it 'does nothing' do
-                rewritten_source.should == source
+                it 'adds metadata ":type => :controller" to the beginning of the hash metadata' do
+                  rewritten_source.should == expected_source
+                end
               end
             end
 
-            context 'and the file path is "features/controllers/some_spec.rb"' do
-              let(:source_path) { 'features/controllers/some_spec.rb' }
-
-              it 'does nothing' do
-                rewritten_source.should == source
+            context "and expression `describe 'something', '#some_method', :foo, :bar => true do ... end`" do
+              let(:source) do
+                <<-END
+                    describe 'something', '#some_method', :foo, :bar => true do
+                    end
+                END
               end
-            end
-          end
 
-          context "and expression `describe 'something', :foo => :bar do ... end`" do
-            let(:source) do
-              <<-END
-                  describe 'something', :foo => :bar do
-                  end
-              END
-            end
+              context 'and the file path is "spec/controllers/some_spec.rb"' do
+                let(:source_path) { 'spec/controllers/some_spec.rb' }
 
-            context 'and the file path is "spec/controllers/some_spec.rb"' do
-              let(:source_path) { 'spec/controllers/some_spec.rb' }
+                let(:expected_source) do
+                  <<-END
+                    describe 'something', '#some_method', :foo, :type => :controller, :bar => true do
+                    end
+                  END
+                end
 
-              let(:expected_source) do
+                it 'adds metadata ":type => :controller" to the beginning of the hash metadata' do
+                  rewritten_source.should == expected_source
+                end
+              end
+            end
+
+            context "and expression `describe 'something', foo: :bar do ... end`" do
+              let(:source) do
                 <<-END
-                  describe 'something', :type => :controller, :foo => :bar do
-                  end
+                    describe 'something', foo: :bar do
+                    end
                 END
               end
 
-              it 'adds metadata ":type => :controller" to the beginning of the hash metadata' do
-                rewritten_source.should == expected_source
-              end
-            end
-          end
+              context 'and the file path is "spec/controllers/some_spec.rb"' do
+                let(:source_path) { 'spec/controllers/some_spec.rb' }
 
-          context "and expression `describe 'something', '#some_method', :foo, :bar => true do ... end`" do
-            let(:source) do
-              <<-END
-                  describe 'something', '#some_method', :foo, :bar => true do
-                  end
-              END
-            end
+                let(:expected_source) do
+                  <<-END
+                    describe 'something', type: :controller, foo: :bar do
+                    end
+                  END
+                end
 
-            context 'and the file path is "spec/controllers/some_spec.rb"' do
-              let(:source_path) { 'spec/controllers/some_spec.rb' }
+                it 'adds metadata "type: :controller"' do
+                  rewritten_source.should == expected_source
+                end
+              end
+            end
 
-              let(:expected_source) do
+            context "and expression `describe 'something', :type => :foo do ... end`" do
+              let(:source) do
                 <<-END
-                  describe 'something', '#some_method', :foo, :type => :controller, :bar => true do
-                  end
+                    describe 'something', :type => :foo do
+                    end
                 END
               end
 
-              it 'adds metadata ":type => :controller" to the beginning of the hash metadata' do
-                rewritten_source.should == expected_source
+              context 'and the file path is "spec/controllers/some_spec.rb"' do
+                let(:source_path) { 'spec/controllers/some_spec.rb' }
+
+                it 'does nothing' do
+                  rewritten_source.should == source
+                end
               end
             end
-          end
 
-          context "and expression `describe 'something', foo: :bar do ... end`" do
-            let(:source) do
-              <<-END
-                  describe 'something', foo: :bar do
-                  end
-              END
-            end
+            context "and expression `RSpec.describe 'something' do ... end`" do
+              let(:source) do
+                <<-END
+                    RSpec.describe 'something' do
+                    end
+                END
+              end
 
-            context 'and the file path is "spec/controllers/some_spec.rb"' do
-              let(:source_path) { 'spec/controllers/some_spec.rb' }
+              context 'and the file path is "spec/controllers/some_spec.rb"' do
+                let(:source_path) { 'spec/controllers/some_spec.rb' }
 
-              let(:expected_source) do
+                let(:expected_source) do
+                  <<-END
+                    RSpec.describe 'something', :type => :controller do
+                    end
+                  END
+                end
+
+                it 'adds metadata ":type => :controller"' do
+                  rewritten_source.should == expected_source
+                end
+              end
+            end
+
+            context "and expression `shared_examples 'something' do ... end`" do
+              let(:source) do
                 <<-END
-                  describe 'something', type: :controller, foo: :bar do
-                  end
+                    shared_examples 'something' do
+                    end
                 END
               end
 
-              it 'adds metadata "type: :controller"' do
-                rewritten_source.should == expected_source
+              context 'and the file path is "spec/controllers/some_spec.rb"' do
+                let(:source_path) { 'spec/controllers/some_spec.rb' }
+
+                it 'does nothing' do
+                  rewritten_source.should == source
+                end
               end
             end
           end
 
-          context "and expression `describe 'something', :type => :foo do ... end`" do
+          context 'when #describes are nested' do
+            let(:source_path) { 'spec/controllers/some_spec.rb' }
+
             let(:source) do
               <<-END
-                  describe 'something', :type => :foo do
+                describe 'something' do
+                  describe '#some_method' do
                   end
+                end
               END
             end
 
-            context 'and the file path is "spec/controllers/some_spec.rb"' do
-              let(:source_path) { 'spec/controllers/some_spec.rb' }
-
-              it 'does nothing' do
-                rewritten_source.should == source
-              end
-            end
-          end
-
-          context "and expression `RSpec.describe 'something' do ... end`" do
-            let(:source) do
+            let(:expected_source) do
               <<-END
-                  RSpec.describe 'something' do
+                describe 'something', :type => :controller do
+                  describe '#some_method' do
                   end
+                end
               END
             end
 
-            context 'and the file path is "spec/controllers/some_spec.rb"' do
-              let(:source_path) { 'spec/controllers/some_spec.rb' }
+            it 'adds the metadata only to the outmost #describe' do
+              rewritten_source.should == expected_source
+            end
+          end
+        end
 
-              let(:expected_source) do
-                <<-END
-                  RSpec.describe 'something', :type => :controller do
-                  end
-                END
-              end
+        context 'with runtime information' do
+          include_context 'dynamic analysis objects'
 
-              it 'adds metadata ":type => :controller"' do
-                rewritten_source.should == expected_source
-              end
-            end
+          let(:source_path) { 'spec/controllers/some_spec.rb' }
+
+          before do
+            example_group.add_explicit_type_metadata!
           end
 
-          context "and expression `shared_examples 'something' do ... end`" do
+          context 'when rspec-rails is loaded in the spec' do
             let(:source) do
               <<-END
-                  shared_examples 'something' do
+                module RSpec
+                  module Rails
                   end
+                end
+
+                describe 'something' do
+                end
               END
             end
 
-            context 'and the file path is "spec/controllers/some_spec.rb"' do
-              let(:source_path) { 'spec/controllers/some_spec.rb' }
+            let(:expected_source) do
+              <<-END
+                module RSpec
+                  module Rails
+                  end
+                end
 
-              it 'does nothing' do
-                rewritten_source.should == source
-              end
+                describe 'something', :type => :controller do
+                end
+              END
             end
-          end
-        end
-
-        context 'when #describes are nested' do
-          let(:source_path) { 'spec/controllers/some_spec.rb' }
 
-          let(:source) do
-            <<-END
-              describe 'something' do
-                describe '#some_method' do
-                end
-              end
-            END
+            it 'adds the metadata' do
+              rewritten_source.should == expected_source
+            end
           end
 
-          let(:expected_source) do
-            <<-END
-              describe 'something', :type => :controller do
-                describe '#some_method' do
+          context 'when rspec-rails is not loaded in the spec' do
+            let(:source) do
+              <<-END
+                describe 'something' do
                 end
-              end
-            END
-          end
+              END
+            end
 
-          it 'adds the metadata only to the outmost #describe' do
-            rewritten_source.should == expected_source
+            it 'does nothing' do
+              rewritten_source.should == source
+            end
           end
         end
 
-        context 'with runtime information' do
-          include_context 'dynamic analysis objects'
+        context 'without runtime information' do
+          include_context 'isolated environment'
 
           let(:source_path) { 'spec/controllers/some_spec.rb' }
 
-          context 'when rspec-rails is loaded in the spec' do
-            let(:source) do
-              <<-END
+          let(:source) do
+            <<-END
                 module RSpec
                   module Rails
                   end
@@ -532,6 +588,70 @@ module Transpec
 
                 describe 'something' do
                 end
+            END
+          end
+
+          context 'when rspec-rails is specified in the Gemfile.lock' do
+            before do
+              create_file('Gemfile.lock', <<-END.strip_heredoc)
+                GEM
+                  remote: https://rubygems.org/
+                  specs:
+                    actionpack (4.1.8)
+                      actionview (= 4.1.8)
+                      activesupport (= 4.1.8)
+                      rack (~> 1.5.2)
+                      rack-test (~> 0.6.2)
+                    actionview (4.1.8)
+                      activesupport (= 4.1.8)
+                      builder (~> 3.1)
+                      erubis (~> 2.7.0)
+                    activemodel (4.1.8)
+                      activesupport (= 4.1.8)
+                      builder (~> 3.1)
+                    activesupport (4.1.8)
+                      i18n (~> 0.6, >= 0.6.9)
+                      json (~> 1.7, >= 1.7.7)
+                      minitest (~> 5.1)
+                      thread_safe (~> 0.1)
+                      tzinfo (~> 1.1)
+                    builder (3.2.2)
+                    diff-lcs (1.2.5)
+                    erubis (2.7.0)
+                    i18n (0.6.11)
+                    json (1.8.1)
+                    minitest (5.4.3)
+                    rack (1.5.2)
+                    rack-test (0.6.2)
+                      rack (>= 1.0)
+                    railties (4.1.8)
+                      actionpack (= 4.1.8)
+                      activesupport (= 4.1.8)
+                      rake (>= 0.8.7)
+                      thor (>= 0.18.1, < 2.0)
+                    rake (10.4.2)
+                    rspec-core (2.14.8)
+                    rspec-expectations (2.14.5)
+                      diff-lcs (>= 1.1.3, < 2.0)
+                    rspec-mocks (2.14.6)
+                    rspec-rails (2.14.2)
+                      actionpack (>= 3.0)
+                      activemodel (>= 3.0)
+                      activesupport (>= 3.0)
+                      railties (>= 3.0)
+                      rspec-core (~> 2.14.0)
+                      rspec-expectations (~> 2.14.0)
+                      rspec-mocks (~> 2.14.0)
+                    thor (0.19.1)
+                    thread_safe (0.3.4)
+                    tzinfo (1.2.2)
+                      thread_safe (~> 0.1)
+
+                PLATFORMS
+                  ruby
+
+                DEPENDENCIES
+                  rspec-rails (~> 2.14.0)
               END
             end
 
@@ -548,19 +668,44 @@ module Transpec
             end
 
             it 'adds the metadata' do
+              example_group.add_explicit_type_metadata!
               rewritten_source.should == expected_source
             end
           end
 
-          context 'when rspec-rails is not loaded in the spec' do
-            let(:source) do
-              <<-END
-                describe 'something' do
-                end
+          context 'when rspec-rails is not specified in the Gemfile.lock' do
+            before do
+              create_file('Gemfile.lock', <<-END.strip_heredoc)
+                GEM
+                  remote: https://rubygems.org/
+                  specs:
+                    diff-lcs (1.2.5)
+                    rspec (2.14.1)
+                      rspec-core (~> 2.14.0)
+                      rspec-expectations (~> 2.14.0)
+                      rspec-mocks (~> 2.14.0)
+                    rspec-core (2.14.8)
+                    rspec-expectations (2.14.5)
+                      diff-lcs (>= 1.1.3, < 2.0)
+                    rspec-mocks (2.14.6)
+
+                PLATFORMS
+                  ruby
+
+                DEPENDENCIES
+                  rspec (~> 2.14.0)
               END
             end
 
             it 'does nothing' do
+              example_group.add_explicit_type_metadata!
+              rewritten_source.should == source
+            end
+          end
+
+          context 'when there is no Gemfile.lock' do
+            it 'does nothing' do
+              example_group.add_explicit_type_metadata!
               rewritten_source.should == source
             end
           end