transpec 2.2.5 → 2.3.0

data/spec/transpec/syntax/rspec_configure_spec.rb

@@ -2,6 +2,7 @@
 
 require 'spec_helper'
 require 'transpec/syntax/rspec_configure'
+require 'transpec/rspec_version'
 
 module Transpec
   class Syntax
@@ -9,6 +10,8 @@ module Transpec
       include_context 'parsed objects'
       include_context 'syntax object', RSpecConfigure, :rspec_configure
 
+      let(:record) { rspec_configure.report.records.first }
+
       context 'when multiple configurations are added' do
         before do
           rspec_configure.expose_dsl_globally = true
@@ -53,31 +56,172 @@ module Transpec
         end
       end
 
-      describe '#expose_dsl_globally=' do
+      describe '#convert_deprecated_options!' do
         before do
-          rspec_configure.expose_dsl_globally = value
+          rspec_configure.convert_deprecated_options!(RSpecVersion.new('3.0.0'))
         end
 
-        let(:value) { true }
+        [
+          [:output,                   :output_stream],
+          [:out,                      :output_stream],
+          [:filename_pattern,         :pattern],
+          [:backtrace_cleaner,        :backtrace_formatter],
+          [:backtrace_clean_patterns, :backtrace_exclusion_patterns],
+          [:warnings,                 :warnings?]
+        ].each do |old_config, new_config|
+          context "with `c.#{old_config}`" do
+            let(:source) do
+              <<-END
+                RSpec.configure do |config|
+                  if config.#{old_config} == something
+                    do_something
+                  end
+                end
+              END
+            end
 
-        let(:source) do
-          <<-END
-            RSpec.configure do |config|
-              config.expose_dsl_globally = false
+            let(:expected_source) do
+              <<-END
+                RSpec.configure do |config|
+                  if config.#{new_config} == something
+                    do_something
+                  end
+                end
+              END
             end
-          END
+
+            it "converts to `c.#{new_config}`" do
+              rewritten_source.should == expected_source
+            end
+
+            it 'adds record of conversion ' \
+               "`RSpec.configure { |c| c.#{old_config} }` -> " \
+               "`RSpec.configure { |c| c.#{new_config} }`" do
+              record.type.should == :conversion
+              record.old_syntax.should == "RSpec.configure { |c| c.#{old_config} }"
+              record.new_syntax.should == "RSpec.configure { |c| c.#{new_config} }"
+            end
+          end
         end
 
-        let(:expected_source) do
-          <<-END
-            RSpec.configure do |config|
-              config.expose_dsl_globally = true
+        [
+          [:output,                   :output_stream],
+          [:out,                      :output_stream],
+          [:filename_pattern,         :pattern],
+          [:backtrace_clean_patterns, :backtrace_exclusion_patterns],
+          [:color_enabled,            :color]
+        ].each do |old_config, new_config|
+          context "with `c.#{old_config} = something`" do
+            let(:source) do
+              <<-END
+                RSpec.configure do |config|
+                  config.#{old_config} = something
+                end
+              END
             end
-          END
+
+            let(:expected_source) do
+              <<-END
+                RSpec.configure do |config|
+                  config.#{new_config} = something
+                end
+              END
+            end
+
+            it "converts to `c.#{new_config} = something`" do
+              rewritten_source.should == expected_source
+            end
+
+            it 'adds record of conversion ' \
+               "`RSpec.configure { |c| c.#{old_config} = something }` -> " \
+               "`RSpec.configure { |c| c.#{new_config} = something }`" do
+              record.type.should == :conversion
+              record.old_syntax.should == "RSpec.configure { |c| c.#{old_config} = something }"
+              record.new_syntax.should == "RSpec.configure { |c| c.#{new_config} = something }"
+            end
+          end
         end
 
-        it 'rewrites the `expose_dsl_globally` configuration' do
-          rewritten_source.should == expected_source
+        context 'with `c.color?(io)`' do
+          let(:source) do
+            <<-END
+              RSpec.configure do |config|
+                if config.color?($stdout)
+                  do_something
+                end
+              end
+            END
+          end
+
+          let(:expected_source) do
+            <<-END
+              RSpec.configure do |config|
+                if config.color_enabled?($stdout)
+                  do_something
+                end
+              end
+            END
+          end
+
+          it 'convertes to `c.color_enabled?(io)`' do
+            rewritten_source.should == expected_source
+          end
+        end
+      end
+
+      describe '#expose_dsl_globally=' do
+        before do
+          rspec_configure.expose_dsl_globally = false
+        end
+
+        context 'when #expose_dsl_globally= already exists' do
+          context 'and the current value is same as the new value' do
+            let(:source) do
+              <<-END
+                RSpec.configure do |config|
+                  config.expose_dsl_globally = false
+                end
+              END
+            end
+
+            it 'does nothing' do
+              rewritten_source.should == source
+            end
+
+            it 'reports nothing' do
+              record.should be_nil
+            end
+          end
+
+          context 'and the current value is different from the new value' do
+            let(:source) do
+              <<-END
+                RSpec.configure do |config|
+                  config.expose_dsl_globally = true
+                end
+              END
+            end
+
+            let(:expected_source) do
+              <<-END
+                RSpec.configure do |config|
+                  config.expose_dsl_globally = false
+                end
+              END
+            end
+
+            it 'rewrites the value' do
+              rewritten_source.should == expected_source
+            end
+
+            it 'adds record of modification ' \
+               '`RSpec.configure { |c| c.expose_dsl_globally = true }` -> ' \
+               '`RSpec.configure { |c| c.expose_dsl_globally = false }`' do
+              record.type.should == :modification
+              record.old_syntax.should == 'RSpec.configure { |c| c.expose_dsl_globally = true }'
+              record.new_syntax.should == 'RSpec.configure { |c| c.expose_dsl_globally = false }'
+            end
+          end
         end
 
         context 'when #expose_dsl_globally= does not exist' do
@@ -98,7 +242,7 @@ module Transpec
                 # For backwards compatibility this defaults to `true`.
                 #
                 # https://relishapp.com/rspec/rspec-core/v/3-0/docs/configuration/global-namespace-dsl
-                config.expose_dsl_globally = true
+                config.expose_dsl_globally = false
               end
             END
           end
@@ -106,9 +250,14 @@ module Transpec
           it 'adds #expose_dsl_globally= statement along with comment' do
             rewritten_source.should == expected_source
           end
+
+          it 'adds record of addition `RSpec.configure { |c| c.expose_dsl_globally = value }`' do
+            record.type.should == :addition
+            record.new_syntax.should == 'RSpec.configure { |c| c.expose_dsl_globally = false }'
+          end
         end
 
-        context 'when there are already some configurations' do
+        context 'when there are already some other configurations' do
           let(:source) do
             <<-END
               RSpec.configure do |config|
@@ -129,7 +278,7 @@ module Transpec
                 # For backwards compatibility this defaults to `true`.
                 #
                 # https://relishapp.com/rspec/rspec-core/v/3-0/docs/configuration/global-namespace-dsl
-                config.expose_dsl_globally = true
+                config.expose_dsl_globally = false
               end
             END
           end
@@ -173,6 +322,11 @@ module Transpec
           it 'adds #infer_spec_type_from_file_location! statement along with comment' do
             rewritten_source.should == expected_source
           end
+
+          it 'adds record of addition `RSpec.configure { |c| c.expose_dsl_globally = value }`' do
+            record.type.should == :addition
+            record.new_syntax.should == 'RSpec.configure { |c| c.infer_spec_type_from_file_location! }'
+          end
         end
 
         context 'when #infer_spec_type_from_file_location! already exists' do
@@ -187,6 +341,10 @@ module Transpec
           it 'does nothing' do
             rewritten_source.should == source
           end
+
+          it 'reports nothing' do
+            record.should be_nil
+          end
         end
 
         context 'with runtime information' do
@@ -509,6 +667,16 @@ module Transpec
               it 'rewrites the setter argument to `true`' do
                 rewritten_source.should == expected_source
               end
+
+              # rubocop:disable LineLength
+              it 'adds record of modification ' \
+                 '`RSpec.configure { |c| c.mock_with :rspec { |m| m.yield_receiver_to_any_instance_implementation_blocks = foo } }` ->' \
+                 '`RSpec.configure { |c| c.mock_with :rspec { |m| m.yield_receiver_to_any_instance_implementation_blocks = true } }`' do
+                record.type.should == :modification
+                record.old_syntax.should == 'RSpec.configure { |c| c.mock_with :rspec { |m| m.yield_receiver_to_any_instance_implementation_blocks = foo } }'
+                record.new_syntax.should == 'RSpec.configure { |c| c.mock_with :rspec { |m| m.yield_receiver_to_any_instance_implementation_blocks = true } }'
+              end
+              # rubocop:enable LineLength
             end
 
             context 'when false is passed' do
@@ -562,6 +730,14 @@ module Transpec
             it 'adds #yield_receiver_to_any_instance_implementation_blocks= statement along with comment' do
               rewritten_source.should == expected_source
             end
+
+            # rubocop:disable LineLength
+            it 'adds record of addition ' \
+               '`RSpec.configure { |c| c.mock_with :rspec { |m| m.yield_receiver_to_any_instance_implementation_blocks = true } }`' do
+              record.type.should == :addition
+              record.new_syntax.should == 'RSpec.configure { |c| c.mock_with :rspec { |m| m.yield_receiver_to_any_instance_implementation_blocks = true } }'
+            end
+            # rubocop:enable LineLength
           end
 
           context 'when #mock_with block does not exist' do
@@ -596,6 +772,14 @@ module Transpec
               rewritten_source.should == expected_source
             end
 
+            # rubocop:disable LineLength
+            it 'adds record of addition ' \
+               '`RSpec.configure { |c| c.mock_with :rspec { |m| m.yield_receiver_to_any_instance_implementation_blocks = true } }`' do
+              record.type.should == :addition
+              record.new_syntax.should == 'RSpec.configure { |c| c.mock_with :rspec { |m| m.yield_receiver_to_any_instance_implementation_blocks = true } }'
+            end
+            # rubocop:enable LineLength
+
             context "when RSpec.configure's block argument name is `mocks`" do
               let(:source) do
                 <<-END

data/spec/transpec/syntax/should_receive_spec.rb

@@ -40,8 +40,8 @@ module Transpec
 
           it 'adds record `obj.should_receive(:message)` -> `expect(obj).to receive(:message)`' do
             should_receive_object.expectize!
-            record.original_syntax.should  == 'obj.should_receive(:message)'
-            record.converted_syntax.should == 'expect(obj).to receive(:message)'
+            record.old_syntax.should == 'obj.should_receive(:message)'
+            record.new_syntax.should == 'expect(obj).to receive(:message)'
           end
 
           context 'when the statement continues over multi lines' do
@@ -181,8 +181,8 @@ module Transpec
           it 'adds record ' \
              '`obj.should_not_receive(:message)` -> `expect(obj).not_to receive(:message)`' do
             should_receive_object.expectize!
-            record.original_syntax.should  == 'obj.should_not_receive(:message)'
-            record.converted_syntax.should == 'expect(obj).not_to receive(:message)'
+            record.old_syntax.should == 'obj.should_not_receive(:message)'
+            record.new_syntax.should == 'expect(obj).not_to receive(:message)'
           end
 
           context 'and "to_not" is passed as negative form' do
@@ -204,8 +204,8 @@ module Transpec
             it 'adds record ' \
                '`obj.should_not_receive(:message)` -> `expect(obj).to_not receive(:message)`' do
               should_receive_object.expectize!('to_not')
-              record.original_syntax.should  == 'obj.should_not_receive(:message)'
-              record.converted_syntax.should == 'expect(obj).to_not receive(:message)'
+              record.old_syntax.should == 'obj.should_not_receive(:message)'
+              record.new_syntax.should == 'expect(obj).to_not receive(:message)'
             end
           end
         end
@@ -429,8 +429,8 @@ module Transpec
           it 'adds record `Klass.any_instance.should_receive(:message)` ' \
              '-> `expect_any_instance_of(Klass).to receive(:message)`' do
             should_receive_object.expectize!
-            record.original_syntax.should  == 'Klass.any_instance.should_receive(:message)'
-            record.converted_syntax.should == 'expect_any_instance_of(Klass).to receive(:message)'
+            record.old_syntax.should == 'Klass.any_instance.should_receive(:message)'
+            record.new_syntax.should == 'expect_any_instance_of(Klass).to receive(:message)'
           end
 
           context 'when the statement continues over multi lines' do
@@ -503,8 +503,8 @@ module Transpec
           it 'adds record `Klass.any_instance.should_receive(:message)` ' \
              '-> `expect_any_instance_of(Klass).to receive(:message)`' do
             should_receive_object.expectize!
-            record.original_syntax.should  == 'Klass.any_instance.should_receive(:message)'
-            record.converted_syntax.should == 'expect_any_instance_of(Klass).to receive(:message)'
+            record.old_syntax.should == 'Klass.any_instance.should_receive(:message)'
+            record.new_syntax.should == 'expect_any_instance_of(Klass).to receive(:message)'
           end
         end
 
@@ -541,8 +541,8 @@ module Transpec
           it 'adds record `Klass.any_instance.should_receive(:message)` ' \
              '-> `expect_any_instance_of(Klass).to receive(:message)`' do
             should_receive_object.expectize!
-            record.original_syntax.should  == 'Klass.any_instance.should_receive(:message)'
-            record.converted_syntax.should == 'expect_any_instance_of(Klass).to receive(:message)'
+            record.old_syntax.should == 'Klass.any_instance.should_receive(:message)'
+            record.new_syntax.should == 'expect_any_instance_of(Klass).to receive(:message)'
           end
         end
 
@@ -583,8 +583,8 @@ module Transpec
             it 'adds record `Klass.any_instance.should_receive(:message)` ' \
                '-> `expect_any_instance_of(Klass).to receive(:message)`' do
               should_receive_object.expectize!
-              record.original_syntax.should  == 'Klass.any_instance.should_receive(:message)'
-              record.converted_syntax.should == 'expect_any_instance_of(Klass).to receive(:message)'
+              record.old_syntax.should == 'Klass.any_instance.should_receive(:message)'
+              record.new_syntax.should == 'expect_any_instance_of(Klass).to receive(:message)'
             end
           end
         end
@@ -694,8 +694,8 @@ module Transpec
           it 'adds record ' \
              '`obj.should_receive(:message).any_number_of_times` -> `allow(obj).to receive(:message)`' do
             should_receive_object.allowize_useless_expectation!
-            record.original_syntax.should  == 'obj.should_receive(:message).any_number_of_times'
-            record.converted_syntax.should == 'allow(obj).to receive(:message)'
+            record.old_syntax.should == 'obj.should_receive(:message).any_number_of_times'
+            record.new_syntax.should == 'allow(obj).to receive(:message)'
           end
 
           context 'and #allow and #receive are not available in the context' do
@@ -796,8 +796,8 @@ module Transpec
           it 'adds record `Klass.any_instance.should_receive(:message).any_number_of_times` ' \
              '-> `allow_any_instance_of(Klass).to receive(:message)`' do
             should_receive_object.allowize_useless_expectation!
-            record.original_syntax.should  == 'Klass.any_instance.should_receive(:message).any_number_of_times'
-            record.converted_syntax.should == 'allow_any_instance_of(Klass).to receive(:message)'
+            record.old_syntax.should == 'Klass.any_instance.should_receive(:message).any_number_of_times'
+            record.new_syntax.should == 'allow_any_instance_of(Klass).to receive(:message)'
           end
         end
 
@@ -830,8 +830,8 @@ module Transpec
           it 'adds record `Klass.any_instance.should_receive(:message).any_number_of_times` ' \
              '-> `allow_any_instance_of(Klass).to receive(:message)`' do
             should_receive_object.allowize_useless_expectation!
-            record.original_syntax.should  == 'Klass.any_instance.should_receive(:message).any_number_of_times'
-            record.converted_syntax.should == 'allow_any_instance_of(Klass).to receive(:message)'
+            record.old_syntax.should == 'Klass.any_instance.should_receive(:message).any_number_of_times'
+            record.new_syntax.should == 'allow_any_instance_of(Klass).to receive(:message)'
           end
         end
 
@@ -864,8 +864,8 @@ module Transpec
           it 'adds record ' \
              '`obj.should_receive(:message).at_least(0)` -> `allow(obj).to receive(:message)`' do
             should_receive_object.allowize_useless_expectation!
-            record.original_syntax.should  == 'obj.should_receive(:message).at_least(0)'
-            record.converted_syntax.should == 'allow(obj).to receive(:message)'
+            record.old_syntax.should == 'obj.should_receive(:message).at_least(0)'
+            record.new_syntax.should == 'allow(obj).to receive(:message)'
           end
         end
 
@@ -898,8 +898,8 @@ module Transpec
           it 'adds record `Klass.any_instance.should_receive(:message).at_least(0)` ' \
              '-> `allow_any_instance_of(Klass).to receive(:message)`' do
             should_receive_object.allowize_useless_expectation!
-            record.original_syntax.should  == 'Klass.any_instance.should_receive(:message).at_least(0)'
-            record.converted_syntax.should == 'allow_any_instance_of(Klass).to receive(:message)'
+            record.old_syntax.should == 'Klass.any_instance.should_receive(:message).at_least(0)'
+            record.new_syntax.should == 'allow_any_instance_of(Klass).to receive(:message)'
           end
         end
 
@@ -953,8 +953,8 @@ module Transpec
 
           it 'adds record ' \
              '`obj.should_receive(:message).any_number_of_times` -> `obj.stub(:message)`' do
-            record.original_syntax.should  == 'obj.should_receive(:message).any_number_of_times'
-            record.converted_syntax.should == 'obj.stub(:message)'
+            record.old_syntax.should == 'obj.should_receive(:message).any_number_of_times'
+            record.new_syntax.should == 'obj.stub(:message)'
           end
         end
 
@@ -1007,8 +1007,8 @@ module Transpec
 
           it 'adds record ' \
              '`obj.should_receive(:message).and_return { value }` -> `obj.should_receive(:message) { value }`' do
-            record.original_syntax.should  == 'obj.should_receive(:message).and_return { value }'
-            record.converted_syntax.should == 'obj.should_receive(:message) { value }'
+            record.old_syntax.should == 'obj.should_receive(:message).and_return { value }'
+            record.new_syntax.should == 'obj.should_receive(:message) { value }'
           end
         end
       end
@@ -1047,8 +1047,8 @@ module Transpec
 
           it 'adds record `Klass.any_instance.should_receive(:message) { |arg| }` ' \
              '-> `Klass.any_instance.should_receive(:message) { |instance, arg| }`' do
-            record.original_syntax.should  == 'Klass.any_instance.should_receive(:message) { |arg| }'
-            record.converted_syntax.should == 'Klass.any_instance.should_receive(:message) { |instance, arg| }'
+            record.old_syntax.should == 'Klass.any_instance.should_receive(:message) { |arg| }'
+            record.new_syntax.should == 'Klass.any_instance.should_receive(:message) { |instance, arg| }'
           end
         end
 

data/spec/transpec/syntax/should_spec.rb

@@ -182,8 +182,8 @@ module Transpec
 
           it 'adds record `obj.should` -> `expect(obj).to`' do
             should_object.expectize!
-            record.original_syntax.should  == 'obj.should'
-            record.converted_syntax.should == 'expect(obj).to'
+            record.old_syntax.should == 'obj.should'
+            record.new_syntax.should == 'expect(obj).to'
           end
 
           context 'and #expect is available in the context by including RSpec::Matchers' do
@@ -313,8 +313,8 @@ module Transpec
 
           it 'adds record `obj.should_not` -> `expect(obj).not_to`' do
             should_object.expectize!
-            record.original_syntax.should  == 'obj.should_not'
-            record.converted_syntax.should == 'expect(obj).not_to'
+            record.old_syntax.should == 'obj.should_not'
+            record.new_syntax.should == 'expect(obj).not_to'
           end
 
           context 'and "to_not" is passed as negative form' do
@@ -335,8 +335,8 @@ module Transpec
 
             it 'adds record `obj.should_not` -> `expect(obj).to_not`' do
               should_object.expectize!('to_not')
-              record.original_syntax.should  == 'obj.should_not'
-              record.converted_syntax.should == 'expect(obj).to_not'
+              record.old_syntax.should == 'obj.should_not'
+              record.new_syntax.should == 'expect(obj).to_not'
             end
           end
         end
@@ -430,8 +430,8 @@ module Transpec
 
             it "adds record `#{method} { }.should` -> `expect { }.to`" do
               should_object.expectize!
-              record.original_syntax.should  == "#{method} { }.should"
-              record.converted_syntax.should == 'expect { }.to'
+              record.old_syntax.should == "#{method} { }.should"
+              record.new_syntax.should == 'expect { }.to'
             end
           end
         end

data/tasks/fixtures/mail/2.99.0/COMMIT_EDITMSG

@@ -1,6 +1,6 @@
 Convert specs to RSpec 2.99.0.beta2 syntax with Transpec
 
-This conversion is done by Transpec 2.2.0 with the following command:
+This conversion is done by Transpec 2.2.5 with the following command:
     transpec --force
 
 * 2161 conversions

data/tasks/fixtures/mail/3.0.0/COMMIT_EDITMSG

@@ -1,6 +1,6 @@
-Convert specs to RSpec 3.0.0 syntax with Transpec
+Convert specs to RSpec 3.0.1 syntax with Transpec
 
-This conversion is done by Transpec 2.2.0 with the following command:
+This conversion is done by Transpec 2.2.5 with the following command:
     transpec --force --convert example_group,hook_scope
 
 * 82 conversions
@@ -27,4 +27,7 @@ This conversion is done by Transpec 2.2.0 with the following command:
     from: obj.stub(:message => value)
       to: allow(obj).to receive_messages(:message => value)
 
+* 1 addition
+      of: RSpec.configure { |c| c.expose_dsl_globally = false }
+
 For more details: https://github.com/yujinakayama/transpec#supported-conversions

data/tasks/fixtures/twitter/2.99.0/COMMIT_EDITMSG

@@ -1,6 +1,6 @@
 Convert specs to RSpec 2.99.0.beta2 syntax with Transpec
 
-This conversion is done by Transpec 2.2.0 with the following command:
+This conversion is done by Transpec 2.2.5 with the following command:
     transpec --force
 
 * 899 conversions

data/tasks/fixtures/twitter/3.0.0/COMMIT_EDITMSG

@@ -1,6 +1,6 @@
-Convert specs to RSpec 3.0.0 syntax with Transpec
+Convert specs to RSpec 3.0.1 syntax with Transpec
 
-This conversion is done by Transpec 2.2.0 with the following command:
+This conversion is done by Transpec 2.2.5 with the following command:
     transpec --force --convert example_group,hook_scope
 
 * 54 conversions

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: transpec
 version: !ruby/object:Gem::Version
-  version: 2.2.5
+  version: 2.3.0
 platform: ruby
 authors:
 - Yuji Nakayama
@@ -288,7 +288,7 @@ files:
 - lib/transpec/syntax/expect.rb
 - lib/transpec/syntax/have.rb
 - lib/transpec/syntax/have/dynamic_analysis.rb
-- lib/transpec/syntax/have/have_record.rb
+- lib/transpec/syntax/have/record_builder.rb
 - lib/transpec/syntax/have/source_builder.rb
 - lib/transpec/syntax/hook.rb
 - lib/transpec/syntax/its.rb