transpec 1.9.0 → 1.9.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: fa52c57bc733f1dfe6a1c635a6338bd54cc39c0d
-  data.tar.gz: 54c31463aff3d7f8a0f52588da49914a4cb597d9
+  metadata.gz: 2c34e8b6406b750b87a6af37fd7ed8e1df46a235
+  data.tar.gz: 6d778d31bc2c9518fda218793f8a740268ab3dc7
 SHA512:
-  metadata.gz: af49f12b94003b1b14f426044d349c03d76c53a8ca78470e75765e1e15f1a1b3c431d2a5c64a0fae7329a74053d80759a0ada4c9282b251eac112a85bd71cdf9
-  data.tar.gz: 9c160cd00df22d3a0f0f52c1318ca10ebafd3b1fe6b8ddf4d4215a71121fd6448edba07ba649945d0e0aad187b7addb35760d7f4a714320f5cb706cf1ff38429
+  metadata.gz: a9e4b610441d631390420e67e391e759b1180e3260abe01ff78deb4fe3cefc57838f9d33da1a1cd5560d5e411a9ddd65f06c8c2fd287dce6a4203cacd737d5eb
+  data.tar.gz: 1ba96f0b28b40c05dd29257caead516bedfb4e4fac7fc4d51a56445f1e6734514385d1a27bd0610975d8ba4e513920b5d4e0c40807f6dc4c69c6d158bfa26bab

data/CHANGELOG.md

@@ -2,6 +2,10 @@
 
 ## Development
 
+## v1.9.1
+
+* Fix crash on `expect(obj).to non_matcher_object` in dynamic analysis ([#39](https://github.com/yujinakayama/transpec/issues/39))
+
 ## v1.9.0
 
 * Support conversion of `and_return { value }` and `and_return` without arguments

data/README.md

@@ -41,7 +41,7 @@ describe Account do
   end
 
   describe '#renew' do
-    context 'when the account is renewable and not closed' do
+    context 'when the account is not closed' do
       before do
         account.stub(:closed?).and_return(false)
       end
@@ -77,7 +77,7 @@ describe Account do
   end
 
   describe '#renew' do
-    context 'when the account is renewable and not closed' do
+    context 'when the account is not closed' do
       before do
         allow(account).to receive(:closed?).and_return(false)
       end
@@ -106,13 +106,13 @@ Simply install `transpec` with `gem` command:
 $ gem install transpec
 ```
 
-Usually you don't need to add `transpec` to your `*.gemspec` or `Gemfile` since this isn't a tool to be used daily.
+Normally you don't need to add `transpec` to your `Gemfile` or `*.gemspec` since this isn't a tool to be used daily.
 
 ## Basic Usage
 
 Before converting your specs:
 
-* Make sure your project has `rspec` gem dependency **2.14** or later. If not, change your `*.gemspec` or `Gemfile` to do so.
+* Make sure your project has `rspec` gem dependency **2.14** or later. If not, change your `Gemfile` or `*.gemspec` to do so.
 * Run `rspec` and check if all the specs pass.
 * Ensure the Git repository is clean. (You don't want to mix up your changes and Transpec's changes, do you?)
 

data/README.md.erb

@@ -43,7 +43,7 @@ describe Account do
   end
 
   describe '#renew' do
-    context 'when the account is renewable and not closed' do
+    context 'when the account is not closed' do
       before do
         account.stub(:closed?).and_return(false)
       end
@@ -80,13 +80,13 @@ Simply install `transpec` with `gem` command:
 $ gem install transpec
 ```
 
-Usually you don't need to add `transpec` to your `*.gemspec` or `Gemfile` since this isn't a tool to be used daily.
+Normally you don't need to add `transpec` to your `Gemfile` or `*.gemspec` since this isn't a tool to be used daily.
 
 ## Basic Usage
 
 Before converting your specs:
 
-* Make sure your project has `rspec` gem dependency **<%= Transpec.required_rspec_version %>** or later. If not, change your `*.gemspec` or `Gemfile` to do so.
+* Make sure your project has `rspec` gem dependency **<%= Transpec.required_rspec_version %>** or later. If not, change your `Gemfile` or `*.gemspec` to do so.
 * Run `rspec` and check if all the specs pass.
 * Ensure the Git repository is clean. (You don't want to mix up your changes and Transpec's changes, do you?)
 

data/lib/transpec/syntax.rb

@@ -61,7 +61,7 @@ module Transpec
       extend ActiveSupport::Concern
 
       module ClassMethods
-        def add_dynamic_analysis_request(&block)
+        def define_dynamic_analysis_request(&block)
           dynamic_analysis_requests << block
         end
 

data/lib/transpec/syntax/have.rb

@@ -7,6 +7,10 @@ require 'transpec/syntax/mixin/owned_matcher'
 module Transpec
   class Syntax
     class Have < Syntax
+      require 'transpec/syntax/have/dynamic_inspector'
+      require 'transpec/syntax/have/source_builder'
+      require 'transpec/syntax/have/have_record'
+
       include Mixin::Send, Mixin::OwnedMatcher
 
       # String#count is not query method, and there's no way to determine
@@ -25,19 +29,21 @@ module Transpec
           [:have, :have_exactly, :have_at_least, :have_at_most].include?(method_name)
       end
 
-      add_dynamic_analysis_request do |rewriter|
+      define_dynamic_analysis_request do |rewriter|
         DynamicInspector.register_request(self, rewriter)
       end
 
       def convert_to_standard_expectation!(parenthesize_matcher_arg = true)
         return if project_requires_collection_matcher?
-        replace(@expectation.subject_range, replacement_subject_source) if explicit_subject?
-        replace(matcher_range, replacement_matcher_source(parenthesize_matcher_arg))
+
+        replace(expectation.subject_range, replacement_subject_source) if explicit_subject?
+        replace(matcher_range, source_builder.replacement_matcher_source(parenthesize_matcher_arg))
+
         register_record if explicit_subject?
       end
 
       def explicit_subject?
-        @expectation.respond_to?(:subject_node)
+        expectation.respond_to?(:subject_node)
       end
 
       alias_method :have_node, :node
@@ -51,10 +57,6 @@ module Transpec
         items_node.children.size > 2
       end
 
-      def have_method_name # rubocop:disable PredicateName
-        have_node.children[1]
-      end
-
       def items_name
         items_node.children[1]
       end
@@ -93,35 +95,9 @@ module Transpec
         QUERY_METHOD_PRIORITIES.first
       end
 
-      def replacement_subject_source
-        build_replacement_subject_source(@expectation.subject_range.source)
-      end
-
-      def build_replacement_subject_source(original_subject_source)
-        source = original_subject_source.dup
-        if subject_is_owner_of_collection?
-          if collection_accessor_is_private?
-            source << ".send(#{collection_accessor.inspect}"
-            source << ", #{collection_accessor_args_body_source}" if items_method_has_arguments?
-            source << ')'
-          else
-            source << ".#{collection_accessor}#{collection_accessor_args_parentheses_source}"
-          end
-        end
-        source << ".#{query_method}"
-      end
-
-      def replacement_matcher_source(parenthesize_arg)
-        build_replacement_matcher_source(size_source, parenthesize_arg)
-      end
-
-      def build_replacement_matcher_source(size_source, parenthesize_arg = true)
-        case @expectation.current_syntax_type
-        when :should
-          build_replacement_matcher_source_for_should(size_source)
-        when :expect
-          build_replacement_matcher_source_for_expect(size_source, parenthesize_arg)
-        end
+      def replacement_subject_source(original_subject_source = nil)
+        original_subject_source ||= expectation.subject_range.source
+        source_builder.replacement_subject_source(original_subject_source)
       end
 
       def size_source
@@ -130,247 +106,23 @@ module Transpec
 
       private
 
+      def source_builder
+        @source_builder ||= SourceBuilder.new(self, size_source)
+      end
+
       def runtime_subject_data
         return @runtime_subject_data if instance_variable_defined?(:@runtime_subject_data)
-        node = explicit_subject? ? @expectation.subject_node : @expectation.node
+        node = explicit_subject? ? expectation.subject_node : expectation.node
         @runtime_subject_data = runtime_node_data(node)
       end
 
-      def build_replacement_matcher_source_for_should(size_source)
-        case have_method_name
-        when :have, :have_exactly then "== #{size_source}"
-        when :have_at_least       then ">= #{size_source}"
-        when :have_at_most        then "<= #{size_source}"
-        end
-      end
-
-      def build_replacement_matcher_source_for_expect(size_source, parenthesize_arg)
-        case have_method_name
-        when :have, :have_exactly
-          if parenthesize_arg
-            "eq(#{size_source})"
-          else
-            "eq #{size_source}"
-          end
-        when :have_at_least
-          "be >= #{size_source}"
-        when :have_at_most
-          "be <= #{size_source}"
-        end
-      end
-
       def matcher_range
         expression_range.join(items_node.loc.expression)
       end
 
-      def collection_accessor_args_parentheses_source
-        map = items_node.loc
-        range = map.selector.end.join(map.expression.end)
-        range.source
-      end
-
-      def collection_accessor_args_body_source
-        arg_nodes = items_node.children[2..-1]
-        range = arg_nodes.first.loc.expression.begin.join(arg_nodes.last.loc.expression.end)
-        range.source
-      end
-
       def register_record
         @report.records << HaveRecord.new(self)
       end
-
-      class DynamicInspector
-        def self.register_request(have, rewriter)
-          new(have, rewriter).register_request
-        end
-
-        def initialize(have, rewriter)
-          @have = have
-          @rewriter = rewriter
-        end
-
-        def target_node
-          if @have.explicit_subject?
-            @have.expectation.subject_node
-          else
-            @have.expectation.node
-          end
-        end
-
-        def target_type
-          if @have.explicit_subject?
-            :object
-          else
-            :context
-          end
-        end
-
-        def register_request
-          key = :collection_accessor
-          code = collection_accessor_inspection_code
-          @rewriter.register_request(target_node, key, code, target_type)
-
-          # Give up inspecting query methods of collection accessor with arguments
-          # (e.g. have(2).errors_on(variable)) since this is a context of #instance_eval.
-          unless @have.items_method_has_arguments?
-            key = :available_query_methods
-            code = available_query_methods_inspection_code
-            @rewriter.register_request(target_node, key, code, target_type)
-          end
-
-          key = :collection_accessor_is_private?
-          code = "#{subject_code}.private_methods.include?(#{@have.items_name.inspect})"
-          @rewriter.register_request(target_node, key, code, target_type)
-
-          key = :project_requires_collection_matcher?
-          code = 'defined?(RSpec::Rails) || defined?(RSpec::CollectionMatchers)'
-          @rewriter.register_request(target_node, key, code, :context)
-        end
-
-        def subject_code
-          @have.explicit_subject? ? 'self' : 'subject'
-        end
-
-        # rubocop:disable MethodLength
-        def collection_accessor_inspection_code
-          # `expect(owner).to have(n).things` invokes private owner#things with Object#__send__
-          # if the owner does not respond to any of #size, #count and #length.
-          #
-          # rubocop:disable LineLength
-          # https://github.com/rspec/rspec-expectations/blob/v2.14.3/lib/rspec/matchers/built_in/have.rb#L48-L58
-          # rubocop:enable LineLength
-          @collection_accessor_inspection_code ||= <<-END.gsub(/^\s+\|/, '').chomp
-            |begin
-            |  exact_name = #{@have.items_name.inspect}
-            |
-            |  inflector = if defined?(ActiveSupport::Inflector) &&
-            |                   ActiveSupport::Inflector.respond_to?(:pluralize)
-            |                ActiveSupport::Inflector
-            |              elsif defined?(Inflector)
-            |                Inflector
-            |              else
-            |                nil
-            |              end
-            |
-            |  if inflector
-            |    pluralized_name = inflector.pluralize(exact_name).to_sym
-            |    respond_to_pluralized_name = #{subject_code}.respond_to?(pluralized_name)
-            |  end
-            |
-            |  respond_to_query_methods =
-            |    !(#{subject_code}.methods & #{QUERY_METHOD_PRIORITIES.inspect}).empty?
-            |
-            |  if #{subject_code}.respond_to?(exact_name)
-            |    exact_name
-            |  elsif respond_to_pluralized_name
-            |    pluralized_name
-            |  elsif respond_to_query_methods
-            |    nil
-            |  else
-            |    exact_name
-            |  end
-            |end
-          END
-        end
-        # rubocop:enable MethodLength
-
-        def available_query_methods_inspection_code
-          <<-END.gsub(/^\s+\|/, '').chomp
-            |collection_accessor = #{collection_accessor_inspection_code}
-            |target = if collection_accessor
-            |           #{subject_code}.__send__(collection_accessor)
-            |         else
-            |           #{subject_code}
-            |         end
-            |target.methods & #{QUERY_METHOD_PRIORITIES.inspect}
-          END
-        end
-      end
-
-      class HaveRecord < Record
-        def initialize(have)
-          @have = have
-        end
-
-        def original_syntax
-          @original_syntax ||= begin
-            type = @have.expectation.class.snake_case_name.to_sym
-            syntax = build_expectation(original_subject, type)
-            syntax << " #{@have.have_method_name}(n).#{original_items}"
-          end
-        end
-
-        def converted_syntax
-          @converted_syntax ||= begin
-            type = @have.expectation.current_syntax_type
-            syntax = build_expectation(converted_subject, type)
-            syntax << " #{@have.build_replacement_matcher_source('n')}"
-          end
-        end
-
-        def build_expectation(subject, type)
-          case type
-          when :should
-            syntax = "#{subject}.should"
-            syntax << '_not' unless positive?
-          when :expect
-            syntax = "expect(#{subject})."
-            syntax << (positive? ? 'to' : 'not_to')
-          end
-
-          syntax
-        end
-
-        def positive?
-          @have.expectation.positive?
-        end
-
-        def original_subject
-          if @have.subject_is_owner_of_collection?
-            'obj'
-          else
-            'collection'
-          end
-        end
-
-        def original_items
-          if @have.subject_is_owner_of_collection?
-            if @have.items_method_has_arguments?
-              "#{@have.collection_accessor}(...)"
-            else
-              @have.collection_accessor
-            end
-          else
-            'items'
-          end
-        end
-
-        def converted_subject
-          if @have.subject_is_owner_of_collection?
-            build_converted_subject('obj')
-          else
-            build_converted_subject('collection')
-          end
-        end
-
-        def build_converted_subject(subject)
-          subject << '.'
-
-          if @have.subject_is_owner_of_collection?
-            if @have.collection_accessor_is_private?
-              subject << "send(#{@have.collection_accessor.inspect}"
-              subject << ', ...' if @have.items_method_has_arguments?
-              subject << ')'
-            else
-              subject << "#{@have.collection_accessor}"
-              subject << '(...)' if @have.items_method_has_arguments?
-            end
-            subject << ".#{@have.query_method}"
-          else
-            subject << "#{@have.default_query_method}"
-          end
-        end
-      end
     end
   end
 end

data/lib/transpec/syntax/have/dynamic_inspector.rb

@@ -0,0 +1,119 @@
+# coding: utf-8
+
+require 'transpec/syntax/have'
+
+module Transpec
+  class Syntax
+    class Have
+      class DynamicInspector
+        def self.register_request(have, rewriter)
+          new(have, rewriter).register_request
+        end
+
+        attr_reader :have, :rewriter
+
+        def initialize(have, rewriter)
+          @have = have
+          @rewriter = rewriter
+        end
+
+        def target_node
+          if have.explicit_subject?
+            have.expectation.subject_node
+          else
+            have.expectation.node
+          end
+        end
+
+        def target_type
+          if have.explicit_subject?
+            :object
+          else
+            :context
+          end
+        end
+
+        def register_request
+          key = :collection_accessor
+          code = collection_accessor_inspection_code
+          rewriter.register_request(target_node, key, code, target_type)
+
+          # Give up inspecting query methods of collection accessor with arguments
+          # (e.g. have(2).errors_on(variable)) since this is a context of #instance_eval.
+          unless have.items_method_has_arguments?
+            key = :available_query_methods
+            code = available_query_methods_inspection_code
+            rewriter.register_request(target_node, key, code, target_type)
+          end
+
+          key = :collection_accessor_is_private?
+          code = "#{subject_code}.private_methods.include?(#{have.items_name.inspect})"
+          rewriter.register_request(target_node, key, code, target_type)
+
+          key = :project_requires_collection_matcher?
+          code = 'defined?(RSpec::Rails) || defined?(RSpec::CollectionMatchers)'
+          rewriter.register_request(target_node, key, code, :context)
+        end
+
+        def subject_code
+          have.explicit_subject? ? 'self' : 'subject'
+        end
+
+        # rubocop:disable MethodLength
+        def collection_accessor_inspection_code
+          # `expect(owner).to have(n).things` invokes private owner#things with Object#__send__
+          # if the owner does not respond to any of #size, #count and #length.
+          #
+          # rubocop:disable LineLength
+          # https://github.com/rspec/rspec-expectations/blob/v2.14.3/lib/rspec/matchers/built_in/have.rb#L48-L58
+          # rubocop:enable LineLength
+          @collection_accessor_inspection_code ||= <<-END.gsub(/^\s+\|/, '').chomp
+            |begin
+            |  exact_name = #{have.items_name.inspect}
+            |
+            |  inflector = if defined?(ActiveSupport::Inflector) &&
+            |                   ActiveSupport::Inflector.respond_to?(:pluralize)
+            |                ActiveSupport::Inflector
+            |              elsif defined?(Inflector)
+            |                Inflector
+            |              else
+            |                nil
+            |              end
+            |
+            |  if inflector
+            |    pluralized_name = inflector.pluralize(exact_name).to_sym
+            |    respond_to_pluralized_name = #{subject_code}.respond_to?(pluralized_name)
+            |  end
+            |
+            |  respond_to_query_methods =
+            |    !(#{subject_code}.methods & #{QUERY_METHOD_PRIORITIES.inspect}).empty?
+            |
+            |  if #{subject_code}.respond_to?(exact_name)
+            |    exact_name
+            |  elsif respond_to_pluralized_name
+            |    pluralized_name
+            |  elsif respond_to_query_methods
+            |    nil
+            |  else
+            |    exact_name
+            |  end
+            |end
+          END
+        end
+        # rubocop:enable MethodLength
+
+        def available_query_methods_inspection_code
+          <<-END.gsub(/^\s+\|/, '').chomp
+            |collection_accessor = #{collection_accessor_inspection_code}
+            |target = if collection_accessor
+            |           #{subject_code}.__send__(collection_accessor)
+            |         else
+            |           #{subject_code}
+            |         end
+            |target.methods & #{QUERY_METHOD_PRIORITIES.inspect}
+          END
+        end
+      end
+    end
+  end
+end

data/lib/transpec/syntax/have/have_record.rb

@@ -0,0 +1,105 @@
+# coding: utf-8
+
+require 'transpec/syntax/have'
+
+module Transpec
+  class Syntax
+    class Have
+      class HaveRecord < Record
+        attr_reader :have
+
+        def initialize(have)
+          @have = have
+        end
+
+        def original_syntax
+          @original_syntax ||= begin
+            type = have.expectation.class.snake_case_name.to_sym
+            syntax = build_expectation(original_subject, type)
+            syntax << " #{have.method_name}(n).#{original_items}"
+          end
+        end
+
+        def converted_syntax
+          @converted_syntax ||= begin
+            type = have.expectation.current_syntax_type
+            syntax = build_expectation(converted_subject, type)
+            syntax << " #{source_builder.replacement_matcher_source}"
+          end
+        end
+
+        def build_expectation(subject, type)
+          case type
+          when :should
+            syntax = "#{subject}.should"
+            syntax << '_not' unless positive?
+          when :expect
+            syntax = "expect(#{subject})."
+            syntax << (positive? ? 'to' : 'not_to')
+          end
+
+          syntax
+        end
+
+        def positive?
+          have.expectation.positive?
+        end
+
+        def original_subject
+          if have.subject_is_owner_of_collection?
+            'obj'
+          else
+            'collection'
+          end
+        end
+
+        def original_items
+          if have.subject_is_owner_of_collection?
+            if have.items_method_has_arguments?
+              "#{have.collection_accessor}(...)"
+            else
+              have.collection_accessor
+            end
+          else
+            'items'
+          end
+        end
+
+        def converted_subject
+          if @have.subject_is_owner_of_collection?
+            build_converted_subject('obj')
+          else
+            build_converted_subject('collection')
+          end
+        end
+
+        def build_converted_subject(subject)
+          if have.subject_is_owner_of_collection?
+            converted_owner_of_collection(subject)
+          else
+            subject << ".#{have.default_query_method}"
+          end
+        end
+
+        def converted_owner_of_collection(subject)
+          subject << '.'
+
+          if have.collection_accessor_is_private?
+            subject << "send(#{have.collection_accessor.inspect}"
+            subject << ', ...' if have.items_method_has_arguments?
+            subject << ')'
+          else
+            subject << "#{have.collection_accessor}"
+            subject << '(...)' if have.items_method_has_arguments?
+          end
+
+          subject << ".#{have.query_method}"
+        end
+
+        def source_builder
+          @source_builder ||= SourceBuilder.new(have, 'n')
+        end
+      end
+    end
+  end
+end

data/lib/transpec/syntax/have/source_builder.rb

@@ -0,0 +1,78 @@
+# coding: utf-8
+
+require 'transpec/syntax/have'
+
+module Transpec
+  class Syntax
+    class Have
+      class SourceBuilder
+        attr_reader :have, :size_source
+
+        def initialize(have, size_source)
+          @have = have
+          @size_source = size_source
+        end
+
+        def replacement_subject_source(original_subject_source)
+          source = original_subject_source
+          if have.subject_is_owner_of_collection?
+            if have.collection_accessor_is_private?
+              source << ".send(#{have.collection_accessor.inspect}"
+              if have.items_method_has_arguments?
+                source << ", #{collection_accessor_args_body_source}"
+              end
+              source << ')'
+            else
+              source << ".#{have.collection_accessor}#{collection_accessor_args_parentheses_source}"
+            end
+          end
+          source << ".#{have.query_method}"
+        end
+
+        def replacement_matcher_source(parenthesize_arg = true)
+          case have.expectation.current_syntax_type
+          when :should
+            replacement_matcher_source_for_should
+          when :expect
+            replacement_matcher_source_for_expect(parenthesize_arg)
+          end
+        end
+
+        def replacement_matcher_source_for_should
+          case have.method_name
+          when :have, :have_exactly then "== #{size_source}"
+          when :have_at_least       then ">= #{size_source}"
+          when :have_at_most        then "<= #{size_source}"
+          end
+        end
+
+        def replacement_matcher_source_for_expect(parenthesize_arg)
+          case have.method_name
+          when :have, :have_exactly
+            if parenthesize_arg
+              "eq(#{size_source})"
+            else
+              "eq #{size_source}"
+            end
+          when :have_at_least
+            "be >= #{size_source}"
+          when :have_at_most
+            "be <= #{size_source}"
+          end
+        end
+
+        def collection_accessor_args_parentheses_source
+          map = have.items_node.loc
+          range = map.selector.end.join(map.expression.end)
+          range.source
+        end
+
+        def collection_accessor_args_body_source
+          arg_nodes = have.items_node.children[2..-1]
+          range = arg_nodes.first.loc.expression.begin.join(arg_nodes.last.loc.expression.end)
+          range.source
+        end
+      end
+    end
+  end
+end

data/lib/transpec/syntax/its.rb

@@ -13,7 +13,7 @@ module Transpec
         receiver_node.nil? && method_name == :its
       end
 
-      add_dynamic_analysis_request do |rewriter|
+      define_dynamic_analysis_request do |rewriter|
         key = :project_requires_its?
         code = 'defined?(RSpec::Its)'
         rewriter.register_request(@node, key, code, :context)

data/lib/transpec/syntax/method_stub.rb

@@ -42,7 +42,7 @@ module Transpec
         !receiver_node.nil? && [:stub, :stub!, :stub_chain, :unstub, :unstub!].include?(method_name)
       end
 
-      add_dynamic_analysis_request do |rewriter|
+      define_dynamic_analysis_request do |rewriter|
         register_request_of_syntax_availability_inspection(
           rewriter,
           :allow_to_receive_available?,

data/lib/transpec/syntax/mixin/expect_base.rb

@@ -13,7 +13,7 @@ module Transpec
         include Send
 
         included do
-          add_dynamic_analysis_request do |rewriter|
+          define_dynamic_analysis_request do |rewriter|
             if Receive.dynamic_analysis_target_node?(matcher_node)
               create_receive_matcher.register_request_for_dynamic_analysis(rewriter)
             end

data/lib/transpec/syntax/mixin/have_matcher_owner.rb

@@ -10,7 +10,7 @@ module Transpec
         extend ActiveSupport::Concern
 
         included do
-          add_dynamic_analysis_request do |rewriter|
+          define_dynamic_analysis_request do |rewriter|
             if Have.dynamic_analysis_target_node?(matcher_node)
               create_have_matcher.register_request_for_dynamic_analysis(rewriter)
             end

data/lib/transpec/syntax/mixin/monkey_patch_any_instance.rb

@@ -12,7 +12,7 @@ module Transpec
         include MonkeyPatch, ::AST::Sexp
 
         included do
-          add_dynamic_analysis_request do |rewriter|
+          define_dynamic_analysis_request do |rewriter|
             code = <<-END.gsub(/^\s+\|/, '').chomp
               |if self.class.name == 'RSpec::Mocks::AnyInstance::Recorder'
               |  if respond_to?(:klass)

data/lib/transpec/syntax/mixin/send.rb

@@ -45,7 +45,7 @@ module Transpec
         end
 
         included do
-          add_dynamic_analysis_request do |rewriter|
+          define_dynamic_analysis_request do |rewriter|
             if receiver_node
               target_node = receiver_node
               target_object_type = :object

data/lib/transpec/syntax/mixin/should_base.rb

@@ -14,7 +14,7 @@ module Transpec
         include Send, HaveMatcherOwner
 
         included do
-          add_dynamic_analysis_request do |rewriter|
+          define_dynamic_analysis_request do |rewriter|
             if OperatorMatcher.dynamic_analysis_target_node?(matcher_node)
               create_operator_matcher.register_request_for_dynamic_analysis(rewriter)
             end

data/lib/transpec/syntax/oneliner_should.rb

@@ -38,7 +38,7 @@ module Transpec
 
         insert_example_description!
 
-        subject_source = have_matcher.build_replacement_subject_source('subject')
+        subject_source = have_matcher.replacement_subject_source('subject')
         insert_before(expression_range, "#{subject_source}.")
 
         have_matcher.convert_to_standard_expectation!
@@ -53,7 +53,7 @@ module Transpec
 
         insert_example_description!
 
-        subject_source = have_matcher.build_replacement_subject_source('subject')
+        subject_source = have_matcher.replacement_subject_source('subject')
         expect_to_source = "expect(#{subject_source})."
         expect_to_source << (positive? ? 'to' : negative_form)
         replace(should_range, expect_to_source)
@@ -72,7 +72,7 @@ module Transpec
       def build_description(size)
         description = positive? ? 'has ' : 'does not have '
 
-        case have_matcher.have_method_name
+        case have_matcher.method_name
         when :have_at_least then description << 'at least '
         when :have_at_most  then description << 'at most '
         end
@@ -161,17 +161,19 @@ module Transpec
       end
 
       class OnelinerShouldHaveRecord < Have::HaveRecord
+        attr_reader :should, :negative_form_of_to
+
         def initialize(should, have, negative_form_of_to = nil)
+          super(have)
           @should = should
-          @have = have
           @negative_form_of_to = negative_form_of_to
         end
 
         def original_syntax
           @original_syntax ||= begin
-            syntax = @should.example_has_description? ? "it '...' do" : 'it {'
-            syntax << " #{@should.method_name} #{@have.have_method_name}(n).#{original_items} "
-            syntax << (@should.example_has_description? ? 'end' : '}')
+            syntax = should.example_has_description? ? "it '...' do" : 'it {'
+            syntax << " #{should.method_name} #{have.method_name}(n).#{original_items} "
+            syntax << (should.example_has_description? ? 'end' : '}')
           end
         end
 
@@ -181,25 +183,25 @@ module Transpec
             syntax << ' '
             syntax << converted_expectation
             syntax << ' '
-            syntax << @have.build_replacement_matcher_source('n')
+            syntax << source_builder.replacement_matcher_source
             syntax << ' end'
           end
         end
 
         def converted_description
-          if @should.example_has_description?
+          if should.example_has_description?
             "it '...' do"
           else
-            "it '#{@should.build_description('n')}' do"
+            "it '#{should.build_description('n')}' do"
           end
         end
 
         def converted_expectation
-          case @should.current_syntax_type
+          case should.current_syntax_type
           when :should
-            "#{converted_subject}.#{@should.method_name}"
+            "#{converted_subject}.#{should.method_name}"
           when :expect
-            "expect(#{converted_subject})." + (@should.positive? ? 'to' : @negative_form_of_to)
+            "expect(#{converted_subject})." + (should.positive? ? 'to' : negative_form_of_to)
           end
         end
 

data/lib/transpec/syntax/operator_matcher.rb

@@ -26,7 +26,7 @@ module Transpec
         check_target_node_dynamically(node, runtime_data)
       end
 
-      add_dynamic_analysis_request do |rewriter|
+      define_dynamic_analysis_request do |rewriter|
         if method_name == :=~
           rewriter.register_request(arg_node, :arg_is_enumerable?, 'is_a?(Enumerable)')
         end

data/lib/transpec/syntax/should.rb

@@ -22,7 +22,7 @@ module Transpec
         @current_syntax_type = :should
       end
 
-      add_dynamic_analysis_request do |rewriter|
+      define_dynamic_analysis_request do |rewriter|
         register_request_of_syntax_availability_inspection(
           rewriter,
           :expect_available?,

data/lib/transpec/syntax/should_receive.rb

@@ -17,7 +17,7 @@ module Transpec
         !receiver_node.nil? && [:should_receive, :should_not_receive].include?(method_name)
       end
 
-      add_dynamic_analysis_request do |rewriter|
+      define_dynamic_analysis_request do |rewriter|
         register_request_of_syntax_availability_inspection(
           rewriter,
           :expect_to_receive_available?,

data/lib/transpec/util.rb

@@ -84,7 +84,7 @@ module Transpec
       loop do
         child_node = parent_node.children.first
 
-        return unless child_node
+        return if !child_node || !child_node.is_a?(AST::Node)
         return unless [:send, :block].include?(child_node.type)
 
         if mode == :parent_as_second_arg

data/lib/transpec/version.rb

@@ -5,7 +5,7 @@ module Transpec
   module Version
     MAJOR = 1
     MINOR = 9
-    PATCH = 0
+    PATCH = 1
 
     def self.to_s
       [MAJOR, MINOR, PATCH].join('.')

data/spec/spec_helper.rb

@@ -26,20 +26,21 @@ RSpec.configure do |config|
   end
 end
 
-require 'simplecov'
-SimpleCov.coverage_dir(File.join('spec', 'coverage'))
-
-if ENV['TRAVIS']
-  require 'coveralls'
-  SimpleCov.formatter = Coveralls::SimpleCov::Formatter
-elsif ENV['CI']
-  require 'simplecov-rcov'
-  SimpleCov.formatter = SimpleCov::Formatter::RcovFormatter
-end
+if ENV['TRAVIS'] || ENV['CI'] || ENV['COVERAGE']
+  require 'simplecov'
+
+  if ENV['TRAVIS']
+    require 'coveralls'
+    SimpleCov.formatter = Coveralls::SimpleCov::Formatter
+  elsif ENV['CI']
+    require 'simplecov-rcov'
+    SimpleCov.formatter = SimpleCov::Formatter::RcovFormatter
+  end
 
-SimpleCov.start do
-  add_filter '/spec/'
-  add_filter '/vendor/bundle/'
+  SimpleCov.start do
+    add_filter '/spec/'
+    add_filter '/vendor/bundle/'
+  end
 end
 
 Dir[File.join(File.dirname(__FILE__), 'support', '*')].each do |path|

data/spec/transpec/util_spec.rb

@@ -47,6 +47,22 @@ module Transpec
       end
     end
 
+    describe '#each_forward_chained_node' do
+      context 'when a non-send node is passed' do
+        let(:source) { ':foo' }
+
+        it 'does not yield' do
+          yielded = false
+
+          Util.each_forward_chained_node(ast) do
+            yielded = true
+          end
+
+          yielded.should be_false
+        end
+      end
+    end
+
     describe '#expand_range_to_adjacent_whitespaces' do
       let(:node) { ast.each_node.find(&:block_type?) }
       let(:range) { node.loc.begin }

data/tasks/lib/transpec_demo.rb

@@ -28,7 +28,7 @@ class TranspecDemo < TranspecTest
   def run_demo(transpec_args = [])
     in_project_dir do
       with_clean_bundler_env do
-        sh File.join(Transpec.root, 'bin', 'transpec'), '--force'
+        sh File.join(Transpec.root, 'bin', 'transpec'), '--force', '--convert-stub-with-hash'
         sh 'bundle exec rspec'
         sh "git checkout --quiet -b #{DEMO_BRANCH}"
         sh 'git commit --all --file .git/COMMIT_EDITMSG'

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: transpec
 version: !ruby/object:Gem::Version
-  version: 1.9.0
+  version: 1.9.1
 platform: ruby
 authors:
 - Yuji Nakayama
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-02-08 00:00:00.000000000 Z
+date: 2014-02-15 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: parser
@@ -259,6 +259,9 @@ files:
 - lib/transpec/syntax/example.rb
 - lib/transpec/syntax/expect.rb
 - lib/transpec/syntax/have.rb
+- lib/transpec/syntax/have/dynamic_inspector.rb
+- lib/transpec/syntax/have/have_record.rb
+- lib/transpec/syntax/have/source_builder.rb
 - lib/transpec/syntax/its.rb
 - lib/transpec/syntax/matcher_definition.rb
 - lib/transpec/syntax/method_stub.rb