transpec 1.3.1 → 1.4.0

data/spec/transpec/dynamic_analyzer_spec.rb

@@ -13,8 +13,8 @@ module Transpec
     let(:rspec_command) { nil }
 
     describe '.new' do
-      context 'when when block is passed' do
-        it 'yields instance' do
+      context 'when block is passed' do
+        it 'yields the instance' do
           yielded = false
 
           DynamicAnalyzer.new(silent: true) do |analyzer|

data/spec/transpec/option_parser_spec.rb

@@ -63,6 +63,7 @@ module Transpec
       describe '-k/--keep option' do
         [
           ['should',         :convert_should?],
+          ['oneliner',       :convert_oneliner?],
           ['should_receive', :convert_should_receive?],
           ['stub',           :convert_stub?],
           ['have_items',     :convert_have_items],

data/spec/transpec/project_spec.rb

@@ -68,6 +68,16 @@ module Transpec
           rspec_version.to_s.should == RSpec::Core::Version::STRING
         end
       end
+
+      context 'when failed checking version' do
+        before do
+          IO.stub(:popen).and_return(nil)
+        end
+
+        it 'raises error' do
+          -> { rspec_version }.should raise_error(/failed checking/i)
+        end
+      end
     end
   end
 end

data/spec/transpec/rspec_version_spec.rb

@@ -7,38 +7,62 @@ module Transpec
   describe RSpecVersion do
     subject(:rspec_version) { RSpecVersion.new(version_string) }
 
-    describe '#be_truthy_available?' do
-      subject { rspec_version.be_truthy_available? }
-
-      [
-        ['2.14.0',        false],
-        ['2.99.0.beta.1', true],
-        ['2.99.0',        true],
-        ['3.0.0.beta.1',  true],
-        ['3.0.0',         true]
-      ].each do |version, expected|
-        context "when the version is #{version}" do
-          let(:version_string) { version }
-          it { should == expected }
+    shared_examples 'feature availability' do |method, expectations|
+      describe "##{method}" do
+        subject { rspec_version.send(method) }
+
+        expectations.each do |version, expected|
+          context "when the version is #{version}" do
+            let(:version_string) { version }
+
+            it "returns #{expected.inspect}" do
+              should be expected
+            end
+          end
         end
       end
     end
 
-    describe '#receive_messages_available?' do
-      subject { rspec_version.receive_messages_available? }
-
-      [
-        ['2.14.0',        false],
-        ['2.99.0.beta.1', false],
-        ['2.99.0',        false],
-        ['3.0.0.beta.1',  true],
-        ['3.0.0',         true]
-      ].each do |version, expected|
-        context "when the version is #{version}" do
-          let(:version_string) { version }
-          it { should == expected }
-        end
-      end
+    [:be_truthy_available?, :yielded_example_available?].each do |method|
+      include_examples 'feature availability', method, [
+        ['2.14.0',       false],
+        ['2.99.0.beta1', true],
+        ['2.99.0',       true],
+        ['3.0.0.beta1',  true],
+        ['3.0.0',        true]
+      ]
+    end
+
+    [:one_liner_is_expected_available?].each do |method|
+      include_examples 'feature availability', method, [
+        ['2.14.0',       false],
+        ['2.99.0.beta1', false],
+        ['2.99.0.beta2', true],
+        ['2.99.0',       true],
+        ['3.0.0.beta1',  true],
+        ['3.0.0',        true]
+      ]
+    end
+
+    [:receive_messages_available?].each do |method|
+      include_examples 'feature availability', method, [
+        ['2.14.0',       false],
+        ['2.99.0.beta1', false],
+        ['2.99.0',       false],
+        ['3.0.0.beta1',  true],
+        ['3.0.0',        true]
+      ]
+    end
+
+    [:receive_message_chain_available?].each do |method|
+      include_examples 'feature availability', method, [
+        ['2.14.0',       false],
+        ['2.99.0.beta1', false],
+        ['2.99.0',       false],
+        ['3.0.0.beta1',  false],
+        ['3.0.0.beta2',  true],
+        ['3.0.0',        true]
+      ]
     end
   end
 end

data/spec/transpec/static_context_inspector_spec.rb

@@ -143,7 +143,7 @@ module Transpec
           end
         end
 
-        it { should == expected }
+        it { should be expected }
       end
 
       describe '#non_monkey_patch_mock_available?' do
@@ -156,7 +156,7 @@ module Transpec
           end
         end
 
-        it { should == expected }
+        it { should be expected }
       end
     end
 

data/spec/transpec/syntax/be_boolean_spec.rb

@@ -7,14 +7,7 @@ module Transpec
   class Syntax
     describe BeBoolean do
       include_context 'parsed objects'
-
-      subject(:be_boolean_object) do
-        ast.each_node do |node|
-          next unless BeBoolean.target_node?(node)
-          return BeBoolean.new(node, source_rewriter)
-        end
-        fail 'No be_boolean node is found!'
-      end
+      include_context 'syntax object', BeBoolean, :be_boolean_object
 
       let(:record) { be_boolean_object.report.records.last }
 
@@ -50,7 +43,7 @@ module Transpec
             rewritten_source.should == expected_source
           end
 
-          it 'adds record "`be_true` -> `be_truthy`"' do
+          it 'adds record `be_true` -> `be_truthy`' do
             record.original_syntax.should  == 'be_true'
             record.converted_syntax.should == 'be_truthy'
           end
@@ -81,7 +74,7 @@ module Transpec
             rewritten_source.should == expected_source
           end
 
-          it 'adds record "`be_false` -> `be_falsey`"' do
+          it 'adds record `be_false` -> `be_falsey`' do
             record.original_syntax.should  == 'be_false'
             record.converted_syntax.should == 'be_falsey'
           end
@@ -103,7 +96,7 @@ module Transpec
               rewritten_source.should == expected_source
             end
 
-            it 'adds record "`be_false` -> `be_falsy`"' do
+            it 'adds record `be_false` -> `be_falsy`' do
               record.original_syntax.should  == 'be_false'
               record.converted_syntax.should == 'be_falsy'
             end
@@ -141,7 +134,7 @@ module Transpec
             rewritten_source.should == expected_source
           end
 
-          it 'adds record "`be_true` -> `be true`"' do
+          it 'adds record `be_true` -> `be true`' do
             record.original_syntax.should  == 'be_true'
             record.converted_syntax.should == 'be true'
           end
@@ -172,7 +165,7 @@ module Transpec
             rewritten_source.should == expected_source
           end
 
-          it 'adds record "`be_false` -> `be false`"' do
+          it 'adds record `be_false` -> `be false`' do
             record.original_syntax.should  == 'be_false'
             record.converted_syntax.should == 'be false'
           end

data/spec/transpec/syntax/be_close_spec.rb

@@ -7,14 +7,7 @@ module Transpec
   class Syntax
     describe BeClose do
       include_context 'parsed objects'
-
-      subject(:be_close_object) do
-        ast.each_node do |node|
-          next unless BeClose.target_node?(node)
-          return BeClose.new(node, source_rewriter)
-        end
-        fail 'No be_close node is found!'
-      end
+      include_context 'syntax object', BeClose, :be_close_object
 
       describe '#convert_to_be_within!' do
         before do
@@ -46,7 +39,7 @@ module Transpec
             rewritten_source.should == expected_source
           end
 
-          it 'adds record "`be_close(expected, delta)` -> `be_within(delta).of(expected)`"' do
+          it 'adds record `be_close(expected, delta)` -> `be_within(delta).of(expected)`' do
             record = be_close_object.report.records.first
             record.original_syntax.should  == 'be_close(expected, delta)'
             record.converted_syntax.should == 'be_within(delta).of(expected)'

data/spec/transpec/syntax/double_spec.rb

@@ -7,14 +7,7 @@ module Transpec
   class Syntax
     describe Double do
       include_context 'parsed objects'
-
-      subject(:double_object) do
-        ast.each_node do |node|
-          next unless Double.target_node?(node)
-          return Double.new(node, source_rewriter)
-        end
-        fail 'No double node is found!'
-      end
+      include_context 'syntax object', Double, :double_object
 
       describe '.target_node?' do
         let(:send_node) do
@@ -151,7 +144,7 @@ module Transpec
               rewritten_source.should == expected_source
             end
 
-            it "adds record \"`#{method}('something')` -> `double('something')`\"" do
+            it "adds record `#{method}('something')` -> `double('something')`" do
               record = double_object.report.records.first
               record.original_syntax.should  == "#{method}('something')"
               record.converted_syntax.should == "double('something')"

data/spec/transpec/syntax/example_spec.rb

@@ -0,0 +1,249 @@
+# coding: utf-8
+
+require 'spec_helper'
+require 'transpec/syntax/example'
+
+module Transpec
+  class Syntax
+    describe Example do
+      include_context 'parsed objects'
+      include_context 'syntax object', Example, :example_object
+
+      let(:record) { example_object.report.records.last }
+
+      describe '#convert!' do
+        before do
+          example_object.convert! unless example.metadata[:no_auto_convert]
+        end
+
+        (Util::EXAMPLE_METHODS + Util::HOOK_METHODS).each do |method|
+          context "when it is `#{method} do example end` form" do
+            let(:source) do
+              <<-END
+                describe 'example' do
+                  #{method} do
+                    do_something if example.metadata[:foo]
+                  end
+                end
+              END
+            end
+
+            let(:expected_source) do
+              <<-END
+                describe 'example' do
+                  #{method} do |example|
+                    do_something if example.metadata[:foo]
+                  end
+                end
+              END
+            end
+
+            it "converts into `#{method} do |example| example end` form" do
+              rewritten_source.should == expected_source
+            end
+
+            it "adds record `#{method} { example }` -> `#{method} { |example| example }`" do
+              record.original_syntax.should  == "#{method} { example }"
+              record.converted_syntax.should == "#{method} { |example| example }"
+            end
+          end
+        end
+
+        Util::HELPER_METHODS.each do |method|
+          context "when it is `#{method}(:name) do example end` form" do
+            let(:source) do
+              <<-END
+                describe 'example' do
+                  #{method}(:name) do
+                    do_something if example.metadata[:foo]
+                  end
+                end
+              END
+            end
+
+            let(:expected_source) do
+              <<-END
+                describe 'example' do
+                  #{method}(:name) do |example|
+                    do_something if example.metadata[:foo]
+                  end
+                end
+              END
+            end
+
+            it "converts into `#{method}(:name) do |example| example end` form" do
+              rewritten_source.should == expected_source
+            end
+
+            it "adds record `#{method}(:name) { example }` -> `#{method}(:name) { |example| example }`" do
+              record.original_syntax.should  == "#{method}(:name) { example }"
+              record.converted_syntax.should == "#{method}(:name) { |example| example }"
+            end
+          end
+        end
+
+        context 'when it is `after { example }` form' do
+          let(:source) do
+            <<-END
+              describe 'example' do
+                after {
+                  do_something if example.metadata[:foo]
+                }
+              end
+            END
+          end
+
+          let(:expected_source) do
+            <<-END
+              describe 'example' do
+                after { |example|
+                  do_something if example.metadata[:foo]
+                }
+              end
+            END
+          end
+
+          it 'converts into `after { |example| example }` form' do
+            rewritten_source.should == expected_source
+          end
+        end
+
+        context 'when it is `after do running_example end` form' do
+          let(:source) do
+            <<-END
+              describe 'example' do
+                after do
+                  do_something if running_example.metadata[:foo]
+                end
+              end
+            END
+          end
+
+          let(:expected_source) do
+            <<-END
+              describe 'example' do
+                after do |example|
+                  do_something if example.metadata[:foo]
+                end
+              end
+            END
+          end
+
+          it 'converts into `after do |example| example end` form' do
+            rewritten_source.should == expected_source
+          end
+        end
+
+        context 'when the wrapper block contains multiple invocation of `example`', :no_auto_convert do
+          let(:source) do
+            <<-END
+              describe 'example' do
+                after do
+                  do_something if example.metadata[:foo]
+                  puts example.description
+                end
+              end
+            END
+          end
+
+          let(:expected_source) do
+            <<-END
+              describe 'example' do
+                after do |example|
+                  do_something if example.metadata[:foo]
+                  puts example.description
+                end
+              end
+            END
+          end
+
+          let(:example_objects) do
+            ast.each_node.reduce([]) do |objects, node|
+              objects << Example.new(node, source_rewriter, runtime_data) if Example.target_node?(node)
+              objects
+            end
+          end
+
+          it 'adds only a block argument' do
+            example_objects.size.should eq(2)
+            example_objects.each(&:convert!)
+            rewritten_source.should == expected_source
+          end
+        end
+
+        context 'when it is `around do |ex| example end` form' do
+          let(:source) do
+            <<-END
+              describe 'example' do
+                around do |ex|
+                  do_something if example.metadata[:foo]
+                end
+              end
+            END
+          end
+
+          let(:expected_source) do
+            <<-END
+              describe 'example' do
+                around do |ex|
+                  do_something if ex.metadata[:foo]
+                end
+              end
+            END
+          end
+
+          it 'converts into `around do |ex| ex end` form' do
+            rewritten_source.should == expected_source
+          end
+        end
+
+        context 'when it is `def helper_method example; end` form' do
+          let(:source) do
+            <<-END
+              module Helper
+                def display_description
+                  puts example.description
+                end
+              end
+
+              describe 'example' do
+                include Helper
+
+                after do
+                  display_description
+                end
+              end
+            END
+          end
+
+          let(:expected_source) do
+            <<-END
+              module Helper
+                def display_description
+                  puts RSpec.current_example.description
+                end
+              end
+
+              describe 'example' do
+                include Helper
+
+                after do
+                  display_description
+                end
+              end
+            END
+          end
+
+          it 'converts into `def helper_method RSpec.current_example; end` form' do
+            rewritten_source.should == expected_source
+          end
+
+          it 'adds record `def helper_method example; end` -> `def helper_method RSpec.current_example; end`' do
+            record.original_syntax.should  == 'def helper_method example; end'
+            record.converted_syntax.should == 'def helper_method RSpec.current_example; end'
+          end
+        end
+      end
+    end
+  end
+end