transpec 1.2.2 → 1.3.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 59870e21327ecc3a1a3a436db95ed2f6ba446a66
-  data.tar.gz: dbb7b187b7a2d0224727c8bad33ff25e26cb9fe5
+  metadata.gz: c9cd93b43c3629f7c2f09782ee9616100b5147b8
+  data.tar.gz: 663a9de354fa930e147853a2024da3f904afae5a
 SHA512:
-  metadata.gz: 407da45de0345dd8d3e3e857b4e02038aa9c8d379d9dc49c49ae30cb100ba0ade7d82a3cf348001b59c9c0d15debea59203ec0a034fd59039e34895aca80a5d9
-  data.tar.gz: 8584f6ffac8f1157e9e78ca6f1d158cc67f603f669480f400c16c8e9f8ea8425f508d65a78a5d3ef8b88072c4df67012cdad477faebd69b31091b2975e6665e2
+  metadata.gz: 94f4f9b4a08a5d8ca703b9588e3bdda7a63eef38dc3b67b21de62a87c9f60ea09f560151ed08e68994281e0361ce7d2b344635843380c410c053c9f3c14f9f37
+  data.tar.gz: 65afbbd2ddd3f72b9794d95ed261c6d7f6c4f7f54ea02e415eee927c36c1fa95e6a2a71f8f60cce3e83bb26a65e52dea067a81db6d6352cf09117f4bc512e515

data/CHANGELOG.md

@@ -2,6 +2,15 @@
 
 ## Development
 
+## v1.3.0
+
+* Handle singular collection names like `have(n).item` ([#18](https://github.com/yujinakayama/transpec/issues/18))
+* Handle collection accessors with arguments like `have(n).errors_on(...)` ([#18](https://github.com/yujinakayama/transpec/issues/18))
+* Handle `described_class.any_instance` ([#18](https://github.com/yujinakayama/transpec/issues/18))
+* Handle indirect `any_instance` subject with runtime information  (e.g. `variable = SomeClass.any_instance; variable.stub(:message)`)
+* Disable conversion of `have(n).items` automatically if `rspec-rails` or `rspec-collection_matchers` is loaded in the target project
+* Disable conversion of `its` automatically if `rspec-its` is loaded in the target project
+
 ## v1.2.2
 
 * Fix error `singleton can't be dumped (TypeError)` at the end of dynamic analysis ([#17](https://github.com/yujinakayama/transpec/issues/17))

data/README.md

@@ -117,11 +117,11 @@ Before converting your specs:
 * Run `rspec` and check if all the specs pass.
 * Ensure the Git repository is clean. (You don't want to mix up your changes and Transpec's changes, right?)
 
-Then, run `transpec` (using `--generate-commit-message` is recommended) in the project root directory:
+Then, run `transpec` (using `-m/--generate-commit-message` is recommended) in the project root directory:
 
 ```bash
 $ cd some-project
-$ transpec --generate-commit-message
+$ transpec -m
 Copying project for dynamic analysis...
 Running dynamic analysis with command "bundle exec rspec"...
 ...............................................................................
@@ -214,12 +214,12 @@ $ transpec --keep should_receive,stub
 #### Available syntax types
 
 Type             | Target Syntax                    | Converted Syntax
------------------|----------------------------------|----------------------------
+-----------------|----------------------------------|-----------------------------------
 `should`         | `obj.should matcher`             | `expect(obj).to matcher`
 `should_receive` | `obj.should_receive`             | `expect(obj).to receive`
 `stub`           | `obj.stub`                       | `allow(obj).to receive`
 `have_items`     | `expect(obj).to have(x).items`   | `expect(obj.size).to eq(x)`
-`its`            | `its(:attr) { }`                 | `describe { subject { } it { } }`
+`its`            | `its(:attr) { }`                 | `describe { subject { }; it { } }`
 `deprecated`     | `obj.stub!`, `mock('foo')`, etc. | `obj.stub`, `double('foo')`
 
 See [Supported Conversions](#supported-conversions) for more details.
@@ -409,6 +409,8 @@ expect(obj).to be false
 
 So, converting `be_true`/`be_false` to `be_truthy`/`be_falsey` never breaks your specs and this is the Transpec's default. If you are willing to test boolean values strictly, you can convert them to `be true`/`be false` with `--boolean-matcher true,false` option. Note that this may break your specs if your library codes don't return exact boolean values.
 
+---
+
 * Conversion can be disabled by: `--keep deprecated`
 * Deprecation: Deprecated since RSpec 2.99, removed at RSpec 3.0
 * See also: [Consider renaming `be_true` and `be_false` to `be_truthy` and `be_falsey` · rspec/rspec-expectations](https://github.com/rspec/rspec-expectations/issues/283)
@@ -429,6 +431,8 @@ expect(1.0 / 3.0).to be_within(0.001).of(0.333)
 
 ### `have(n).items` matcher
 
+**This conversion will be disabled automatically if `rspec-collection_matchers` or `rspec-rails` is loaded in your spec.**
+
 ```ruby
 # Targets
 expect(collection).to have(3).items
@@ -455,8 +459,15 @@ expect(team.players.size).to eq(3)
 expect(team.send(:players).size).to eq(3)
 ```
 
-There's the option to continue using `have(n).items` matcher with [rspec-collection_matchers](https://github.com/rspec/rspec-collection_matchers) that is an external gem extracted from `rspec-expectations`.
-If you choose so, disable this conversion with `--keep have_items`.
+There's an option to continue using `have(n).items` matcher with [rspec-collection_matchers](https://github.com/rspec/rspec-collection_matchers) that is an external gem extracted from `rspec-expectations`.
+If you choose so, disable this conversion by either:
+
+* Specify `--keep have_items` option manually.
+* Require `rspec-collection_matchers` or `rspec-rails` in your spec so that Transpec automatically disables this conversion.
+
+Note: `rspec-rails` 3.0 [still uses `have(n).items` matcher with `rspec-collection_matchers`](https://github.com/rspec/rspec-rails/blob/v3.0.0.beta1/rspec-rails.gemspec#L41).
+
+---
 
 * Conversion can be disabled by: `--keep have_items`
 * Deprecation: Deprecated since RSpec 2.99, removed at RSpec 3.0
@@ -501,11 +512,11 @@ lambda { do_something }.should_not raise_error # with `--keep should`
 ```ruby
 # Targets
 obj.should_receive(:foo)
-SomeClass.any_instance.should_receive(:foo)
+Klass.any_instance.should_receive(:foo)
 
 # Converted
 expect(obj).to receive(:foo)
-expect_any_instance_of(SomeClass).to receive(:foo)
+expect_any_instance_of(Klass).to receive(:foo)
 ```
 
 * Conversion can be disabled by: `--keep should_receive`
@@ -519,15 +530,15 @@ expect_any_instance_of(SomeClass).to receive(:foo)
 obj.should_receive(:foo).any_number_of_times
 obj.should_receive(:foo).at_least(0)
 
-SomeClass.any_instance.should_receive(:foo).any_number_of_times
-SomeClass.any_instance.should_receive(:foo).at_least(0)
+Klass.any_instance.should_receive(:foo).any_number_of_times
+Klass.any_instance.should_receive(:foo).at_least(0)
 
 # Converted
 allow(obj).to receive(:foo)
 obj.stub(:foo) # with `--keep stub`
 
-allow_any_instance_of(SomeClass).to receive(:foo)
-SomeClass.any_instance.stub(:foo) # with `--keep stub`
+allow_any_instance_of(Klass).to receive(:foo)
+Klass.any_instance.stub(:foo) # with `--keep stub`
 ```
 
 * Conversion can be disabled by: `--keep deprecated`
@@ -544,7 +555,7 @@ obj.stub!(:foo)
 
 obj.stub(:foo => 1, :bar => 2)
 
-SomeClass.any_instance.stub(:foo)
+Klass.any_instance.stub(:foo)
 
 # Converted
 allow(obj).to receive(:foo)
@@ -558,7 +569,7 @@ allow(obj).to receive(:bar).and_return(2)
 # If the target project's rspec gem dependency is 3.0 or later
 allow(obj).to receive_messages(:foo => 1, :bar => 2)
 
-allow_any_instance_of(SomeClass).to receive(:foo)
+allow_any_instance_of(Klass).to receive(:foo)
 ```
 
 Note: `allow(obj).to receive_messages(:foo => 1, :bar => 2)` that is designed to be the replacement for `obj.stub(:foo => 1, :bar => 2)` is available from RSpec 3.0 (though [it's now being considered to be backported to RSpec 2.99](https://github.com/rspec/rspec-mocks/issues/454)). So, in [the upgrade path to RSpec 3](http://myronmars.to/n/dev-blog/2013/07/the-plan-for-rspec-3#the_upgrade_path), if you want to convert them with keeping the syntax correspondence, you need to follow these steps:
@@ -570,6 +581,8 @@ Note: `allow(obj).to receive_messages(:foo => 1, :bar => 2)` that is designed to
 
 Otherwise `obj.stub(:foo => 1, :bar => 2)` will be converted to two `allow(obj).to receive(...).and_return(...)` expressions on RSpec 2.99.
 
+---
+
 * Conversion can be disabled by: `--keep stub`
 * Deprecation: Deprecated since RSpec 3.0
 * See also:
@@ -625,6 +638,8 @@ double('something')
 
 ### Expectations on attribute of subject with `its`
 
+**This conversion will be disabled automatically if `rspec-its` is loaded in your spec.**
+
 ```ruby
 # Targets
 describe 'example' do
@@ -658,8 +673,13 @@ describe 'example' do
 end
 ```
 
-There's the option to continue using `its` with [rspec-its](https://github.com/rspec/rspec-its) that is an external gem extracted from `rspec-core`.
-If you choose so, disable this conversion with `--keep its`.
+There's an option to continue using `its` with [rspec-its](https://github.com/rspec/rspec-its) that is an external gem extracted from `rspec-core`.
+If you choose so, disable this conversion by either:
+
+* Specify `--keep its` option manually.
+* Require `rspec-its` in your spec so that Transpec automatically disables this conversion.
+
+---
 
 * Conversion can be disabled by: `--keep its`
 * Deprecation: Deprecated since RSpec 2.99, removed at RSpec 3.0

data/README.md.erb

@@ -90,11 +90,11 @@ Before converting your specs:
 * Run `rspec` and check if all the specs pass.
 * Ensure the Git repository is clean. (You don't want to mix up your changes and Transpec's changes, right?)
 
-Then, run `transpec` (using `--generate-commit-message` is recommended) in the project root directory:
+Then, run `transpec` (using `-m/--generate-commit-message` is recommended) in the project root directory:
 
 ```bash
 $ cd some-project
-$ transpec --generate-commit-message
+$ transpec -m
 Copying project for dynamic analysis...
 Running dynamic analysis with command "bundle exec rspec"...
 ...............................................................................
@@ -187,14 +187,14 @@ $ transpec --keep should_receive,stub
 #### Available syntax types
 
 Type             | Target Syntax                    | Converted Syntax
------------------|----------------------------------|----------------------------
+-----------------|----------------------------------|-----------------------------------
 <%=
 conversion_type_table = <<END
 `should`         | `obj.should matcher`             | `expect(obj).to matcher`
 `should_receive` | `obj.should_receive`             | `expect(obj).to receive`
 `stub`           | `obj.stub`                       | `allow(obj).to receive`
 `have_items`     | `expect(obj).to have(x).items`   | `expect(obj.size).to eq(x)`
-`its`            | `its(:attr) { }`                 | `describe { subject { } it { } }`
+`its`            | `its(:attr) { }`                 | `describe { subject { }; it { } }`
 `deprecated`     | `obj.stub!`, `mock('foo')`, etc. | `obj.stub`, `double('foo')`
 END
 
@@ -405,6 +405,8 @@ expect(obj).to be false
 
 So, converting `be_true`/`be_false` to `be_truthy`/`be_falsey` never breaks your specs and this is the Transpec's default. If you are willing to test boolean values strictly, you can convert them to `be true`/`be false` with `--boolean-matcher true,false` option. Note that this may break your specs if your library codes don't return exact boolean values.
 
+---
+
 * Conversion can be disabled by: `--keep deprecated`
 * Deprecation: Deprecated since RSpec 2.99, removed at RSpec 3.0
 * See also: [Consider renaming `be_true` and `be_false` to `be_truthy` and `be_falsey` · rspec/rspec-expectations](https://github.com/rspec/rspec-expectations/issues/283)
@@ -425,6 +427,8 @@ expect(1.0 / 3.0).to be_within(0.001).of(0.333)
 
 ### `have(n).items` matcher
 
+**This conversion will be disabled automatically if `rspec-collection_matchers` or `rspec-rails` is loaded in your spec.**
+
 ```ruby
 # Targets
 expect(collection).to have(3).items
@@ -451,8 +455,15 @@ expect(team.players.size).to eq(3)
 expect(team.send(:players).size).to eq(3)
 ```
 
-There's the option to continue using `have(n).items` matcher with [rspec-collection_matchers](https://github.com/rspec/rspec-collection_matchers) that is an external gem extracted from `rspec-expectations`.
-If you choose so, disable this conversion with `--keep have_items`.
+There's an option to continue using `have(n).items` matcher with [rspec-collection_matchers](https://github.com/rspec/rspec-collection_matchers) that is an external gem extracted from `rspec-expectations`.
+If you choose so, disable this conversion by either:
+
+* Specify `--keep have_items` option manually.
+* Require `rspec-collection_matchers` or `rspec-rails` in your spec so that Transpec automatically disables this conversion.
+
+Note: `rspec-rails` 3.0 [still uses `have(n).items` matcher with `rspec-collection_matchers`](https://github.com/rspec/rspec-rails/blob/v3.0.0.beta1/rspec-rails.gemspec#L41).
+
+---
 
 * Conversion can be disabled by: `--keep have_items`
 * Deprecation: Deprecated since RSpec 2.99, removed at RSpec 3.0
@@ -497,11 +508,11 @@ lambda { do_something }.should_not raise_error # with `--keep should`
 ```ruby
 # Targets
 obj.should_receive(:foo)
-SomeClass.any_instance.should_receive(:foo)
+Klass.any_instance.should_receive(:foo)
 
 # Converted
 expect(obj).to receive(:foo)
-expect_any_instance_of(SomeClass).to receive(:foo)
+expect_any_instance_of(Klass).to receive(:foo)
 ```
 
 * Conversion can be disabled by: `--keep should_receive`
@@ -515,15 +526,15 @@ expect_any_instance_of(SomeClass).to receive(:foo)
 obj.should_receive(:foo).any_number_of_times
 obj.should_receive(:foo).at_least(0)
 
-SomeClass.any_instance.should_receive(:foo).any_number_of_times
-SomeClass.any_instance.should_receive(:foo).at_least(0)
+Klass.any_instance.should_receive(:foo).any_number_of_times
+Klass.any_instance.should_receive(:foo).at_least(0)
 
 # Converted
 allow(obj).to receive(:foo)
 obj.stub(:foo) # with `--keep stub`
 
-allow_any_instance_of(SomeClass).to receive(:foo)
-SomeClass.any_instance.stub(:foo) # with `--keep stub`
+allow_any_instance_of(Klass).to receive(:foo)
+Klass.any_instance.stub(:foo) # with `--keep stub`
 ```
 
 * Conversion can be disabled by: `--keep deprecated`
@@ -540,7 +551,7 @@ obj.stub!(:foo)
 
 obj.stub(:foo => 1, :bar => 2)
 
-SomeClass.any_instance.stub(:foo)
+Klass.any_instance.stub(:foo)
 
 # Converted
 allow(obj).to receive(:foo)
@@ -554,7 +565,7 @@ allow(obj).to receive(:bar).and_return(2)
 # If the target project's rspec gem dependency is 3.0 or later
 allow(obj).to receive_messages(:foo => 1, :bar => 2)
 
-allow_any_instance_of(SomeClass).to receive(:foo)
+allow_any_instance_of(Klass).to receive(:foo)
 ```
 
 Note: `allow(obj).to receive_messages(:foo => 1, :bar => 2)` that is designed to be the replacement for `obj.stub(:foo => 1, :bar => 2)` is available from RSpec 3.0 (though [it's now being considered to be backported to RSpec 2.99](https://github.com/rspec/rspec-mocks/issues/454)). So, in [the upgrade path to RSpec 3](http://myronmars.to/n/dev-blog/2013/07/the-plan-for-rspec-3#the_upgrade_path), if you want to convert them with keeping the syntax correspondence, you need to follow these steps:
@@ -566,6 +577,8 @@ Note: `allow(obj).to receive_messages(:foo => 1, :bar => 2)` that is designed to
 
 Otherwise `obj.stub(:foo => 1, :bar => 2)` will be converted to two `allow(obj).to receive(...).and_return(...)` expressions on RSpec 2.99.
 
+---
+
 * Conversion can be disabled by: `--keep stub`
 * Deprecation: Deprecated since RSpec 3.0
 * See also:
@@ -621,6 +634,8 @@ double('something')
 
 ### Expectations on attribute of subject with `its`
 
+**This conversion will be disabled automatically if `rspec-its` is loaded in your spec.**
+
 ```ruby
 # Targets
 <%=
@@ -638,8 +653,13 @@ END
 <%= Transpec::Converter.new.convert(its_target) -%>
 ```
 
-There's the option to continue using `its` with [rspec-its](https://github.com/rspec/rspec-its) that is an external gem extracted from `rspec-core`.
-If you choose so, disable this conversion with `--keep its`.
+There's an option to continue using `its` with [rspec-its](https://github.com/rspec/rspec-its) that is an external gem extracted from `rspec-core`.
+If you choose so, disable this conversion by either:
+
+* Specify `--keep its` option manually.
+* Require `rspec-its` in your spec so that Transpec automatically disables this conversion.
+
+---
 
 * Conversion can be disabled by: `--keep its`
 * Deprecation: Deprecated since RSpec 2.99, removed at RSpec 3.0

data/lib/transpec/option_parser.rb

@@ -143,7 +143,7 @@ module Transpec
           "  #{'should_receive'.bright} (to #{'expect(obj).to receive'.underline})",
           "  #{'stub'.bright}  (to #{'allow(obj).to receive'.underline})",
           "  #{'have_items'.bright} (to #{'expect(obj.size).to eq(x)'.underline})",
-          "  #{'its'.bright} (to #{'describe { subject { } it { } }'.underline})",
+          "  #{'its'.bright} (to #{'describe { subject { }; it { } }'.underline})",
           "  #{'deprecated'.bright} (e.g. from #{'mock'.underline} to #{'double'.underline})",
           'These are all converted by default.'
         ],

data/lib/transpec/syntax/have.rb

@@ -39,30 +39,11 @@ module Transpec
       end
 
       def register_request_for_dynamic_analysis(rewriter)
-        node = @expectation.subject_node
-
-        # `expect(owner).to have(n).things` invokes private owner#things with Object#__send__
-        # if the owner does not respond to any of #size, #count and #length.
-        #
-        # rubocop:disable LineLength
-        # https://github.com/rspec/rspec-expectations/blob/v2.14.3/lib/rspec/matchers/built_in/have.rb#L48-L58
-        # rubocop:enable LineLength
-        key = :subject_is_owner_of_collection?
-        code = "respond_to?(#{items_name.inspect}) || " +
-               "(methods & #{QUERY_METHOD_PRIORITIES.inspect}).empty?"
-        rewriter.register_request(node, key, code)
-
-        key = :available_query_methods
-        code = "target = #{code} ? #{items_name} : self; " +
-               "target.methods & #{QUERY_METHOD_PRIORITIES.inspect}"
-        rewriter.register_request(node, key, code)
-
-        key = :collection_accessor_is_private?
-        code = "private_methods.include?(#{items_name.inspect})"
-        rewriter.register_request(node, key, code)
+        DynamicInspector.register_request(self, rewriter)
       end
 
       def convert_to_standard_expectation!(parenthesize_matcher_arg = true)
+        return if project_requires_collection_matcher?
         replace(@expectation.subject_range, replacement_subject_source)
         replace(expression_range, replacement_matcher_source(size_source, parenthesize_matcher_arg))
         register_record
@@ -78,6 +59,10 @@ module Transpec
 
       alias_method :items_node, :node
 
+      def items_method_has_arguments?
+        items_node.children.size > 2
+      end
+
       def have_method_name
         have_node.children[1]
       end
@@ -86,21 +71,31 @@ module Transpec
         items_node.children[1]
       end
 
+      def project_requires_collection_matcher?
+        runtime_subject_data && runtime_subject_data[:project_requires_collection_matcher?].result
+      end
+
+      def collection_accessor
+        if runtime_subject_data && runtime_subject_data[:collection_accessor].result
+          runtime_subject_data[:collection_accessor].result.to_sym
+        else
+          items_name
+        end
+      end
+
       def subject_is_owner_of_collection?
-        node_data = runtime_node_data(@expectation.subject_node)
-        node_data && node_data[:subject_is_owner_of_collection?].result
+        return true if items_method_has_arguments?
+        runtime_subject_data && !runtime_subject_data[:collection_accessor].result.nil?
       end
 
       def collection_accessor_is_private?
-        node_data = runtime_node_data(@expectation.subject_node)
-        node_data && node_data[:collection_accessor_is_private?].result
+        runtime_subject_data && runtime_subject_data[:collection_accessor_is_private?].result
       end
 
       def query_method
-        node_data = runtime_node_data(@expectation.subject_node)
-        if node_data && node_data[:available_query_methods].result.is_a?(Array)
-          available_query_methods = node_data[:available_query_methods].result.map(&:to_sym)
-          (QUERY_METHOD_PRIORITIES & available_query_methods).first
+        if runtime_subject_data && runtime_subject_data[:available_query_methods]
+          available_query_methods = runtime_subject_data[:available_query_methods].result
+          (QUERY_METHOD_PRIORITIES & available_query_methods.map(&:to_sym)).first
         else
           default_query_method
         end
@@ -121,13 +116,20 @@ module Transpec
 
       private
 
+      def runtime_subject_data
+        return @runtime_subject_data if instance_variable_defined?(:@runtime_subject_data)
+        @runtime_subject_data = runtime_node_data(@expectation.subject_node)
+      end
+
       def replacement_subject_source
         source = @expectation.subject_range.source
         if subject_is_owner_of_collection?
           if collection_accessor_is_private?
-            source << ".send(#{items_name.inspect})"
+            source << ".send(#{collection_accessor.inspect}"
+            source << ", #{args_range.source}" if items_method_has_arguments?
+            source << ')'
           else
-            source << ".#{items_name}"
+            source << ".#{collection_accessor}#{parentheses_range.source}"
           end
         end
         source << ".#{query_method}"
@@ -160,15 +162,91 @@ module Transpec
         size_node.loc.expression.source
       end
 
-      def dot_items_range
-        map = items_node.loc
-        map.dot.join(map.selector)
-      end
-
       def register_record
         @report.records << HaveRecord.new(self)
       end
 
+      class DynamicInspector
+        def self.register_request(have, rewriter)
+          new(have, rewriter).register_request
+        end
+
+        def initialize(have, rewriter)
+          @have = have
+          @rewriter = rewriter
+        end
+
+        def target_node
+          @have.expectation.subject_node
+        end
+
+        def register_request
+          key = :collection_accessor
+          code = collection_accessor_inspection_code
+          @rewriter.register_request(target_node, key, code)
+
+          # Give up inspecting query methods of collection accessor with arguments
+          # (e.g. have(2).errors_on(variable)) since this is a context of #instance_eval.
+          unless @have.items_method_has_arguments?
+            key = :available_query_methods
+            code = "collection_accessor = #{code}; " +
+                   'target = collection_accessor ? __send__(collection_accessor) : self; ' +
+                   "target.methods & #{QUERY_METHOD_PRIORITIES.inspect}"
+            @rewriter.register_request(target_node, key, code)
+          end
+
+          key = :collection_accessor_is_private?
+          code = "private_methods.include?(#{@have.items_name.inspect})"
+          @rewriter.register_request(target_node, key, code)
+
+          key = :project_requires_collection_matcher?
+          code = 'defined?(RSpec::Rails) || defined?(RSpec::CollectionMatchers)'
+          @rewriter.register_request(target_node, key, code, :context)
+        end
+
+        # rubocop:disable MethodLength
+        def collection_accessor_inspection_code
+          # `expect(owner).to have(n).things` invokes private owner#things with Object#__send__
+          # if the owner does not respond to any of #size, #count and #length.
+          #
+          # rubocop:disable LineLength
+          # https://github.com/rspec/rspec-expectations/blob/v2.14.3/lib/rspec/matchers/built_in/have.rb#L48-L58
+          # rubocop:enable LineLength
+          <<-END.gsub(/^\s+\|/, '').chomp
+            |begin
+            |  exact_name = #{@have.items_name.inspect}
+            |
+            |  inflector = if defined?(ActiveSupport::Inflector) &&
+            |                   ActiveSupport::Inflector.respond_to?(:pluralize)
+            |                ActiveSupport::Inflector
+            |              elsif defined?(Inflector)
+            |                Inflector
+            |              else
+            |                nil
+            |              end
+            |
+            |  if inflector
+            |    pluralized_name = inflector.pluralize(exact_name).to_sym
+            |    respond_to_pluralized_name = respond_to?(pluralized_name)
+            |  end
+            |
+            |  respond_to_query_methods = !(methods & #{QUERY_METHOD_PRIORITIES.inspect}).empty?
+            |
+            |  if respond_to?(exact_name)
+            |    exact_name
+            |  elsif respond_to_pluralized_name
+            |    pluralized_name
+            |  elsif respond_to_query_methods
+            |    nil
+            |  else
+            |    exact_name
+            |  end
+            |end
+          END
+        end
+        # rubocop:enable MethodLength
+      end
+
       class HaveRecord < Record
         def initialize(have)
           @have = have
@@ -210,7 +288,11 @@ module Transpec
 
         def original_items
           if @have.subject_is_owner_of_collection?
-            @have.items_name
+            if @have.items_method_has_arguments?
+              "#{@have.collection_accessor}(...)"
+            else
+              @have.collection_accessor
+            end
           else
             'items'
           end
@@ -218,11 +300,16 @@ module Transpec
 
         def converted_subject
           if @have.subject_is_owner_of_collection?
+            subject = 'obj.'
             if @have.collection_accessor_is_private?
-              "obj.send(#{@have.items_name.inspect}).#{@have.query_method}"
+              subject << "send(#{@have.collection_accessor.inspect}"
+              subject << ', ...' if @have.items_method_has_arguments?
+              subject << ')'
             else
-              "obj.#{@have.items_name}.#{@have.query_method}"
+              subject << "#{@have.collection_accessor}"
+              subject << '(...)' if @have.items_method_has_arguments?
             end
+            subject << ".#{@have.query_method}"
           else
             "collection.#{@have.default_query_method}"
           end

data/lib/transpec/syntax/its.rb

@@ -13,7 +13,15 @@ module Transpec
         receiver_node.nil? && method_name == :its
       end
 
+      def register_request_for_dynamic_analysis(rewriter)
+        key = :project_requires_its?
+        code = 'defined?(RSpec::Its)'
+        rewriter.register_request(@node, key, code, :context)
+      end
+
       def convert_to_describe_subject_it!
+        return if project_requires_its?
+
         front, rear = build_wrapper_codes
 
         insert_before(beginning_of_line_range, front)
@@ -37,6 +45,11 @@ module Transpec
         @node.parent_node
       end
 
+      def project_requires_its?
+        node_data = runtime_node_data(@node)
+        node_data && node_data[:project_requires_its?].result
+      end
+
       private
 
       def build_wrapper_codes
@@ -99,9 +112,9 @@ module Transpec
 
       def converted_syntax
         if attribute_expression.brackets?
-          "describe '[:key]' do subject { super()[:key] } it { } end"
+          "describe '[:key]' do subject { super()[:key] }; it { } end"
         else
-          "describe 'attr' do subject { super().attr } it { } end"
+          "describe 'attr' do subject { super().attr }; it { } end"
         end
       end
 

data/lib/transpec/syntax/method_stub.rb

@@ -23,6 +23,7 @@ module Transpec
           :allow_to_receive_available?,
           [:allow, :receive]
         )
+        register_request_of_any_instance_inspection(rewriter)
       end
 
       def allow_to_receive_available?
@@ -101,8 +102,7 @@ module Transpec
 
       def allow_source
         if any_instance?
-          class_source = class_node_of_any_instance.loc.expression.source
-          "allow_any_instance_of(#{class_source})"
+          "allow_any_instance_of(#{any_instance_target_class_source})"
         else
           "allow(#{subject_range.source})"
         end
@@ -127,7 +127,7 @@ module Transpec
       end
 
       def original_syntax
-        syntax = any_instance? ? 'SomeClass.any_instance' : 'obj'
+        syntax = any_instance? ? 'Klass.any_instance' : 'obj'
         syntax << ".#{method_name}"
         syntax << (arg_node.type == :hash ? '(:message => value)' : '(:message)')
       end
@@ -135,7 +135,7 @@ module Transpec
       def converted_syntax(conversion_type)
         case conversion_type
         when :allow_to_receive, :allow_to_receive_messages
-          syntax = any_instance? ? 'allow_any_instance_of(SomeClass)' : 'allow(obj)'
+          syntax = any_instance? ? 'allow_any_instance_of(Klass)' : 'allow(obj)'
           syntax << '.to '
           if conversion_type == :allow_to_receive
             syntax << 'receive(:message)'