transpec 1.10.4 → 1.11.0

data/spec/transpec/syntax/have_spec.rb

@@ -72,12 +72,23 @@ module Transpec
         end
       end
 
-      describe '#convert_to_standard_expectation!' do
-        let(:record) { have_object.report.records.last }
+      describe '#conversion_target?' do
+        let(:should_node) do
+          ast.each_descendent_node do |node|
+            next unless node.send_type?
+            method_name = node.children[1]
+            return node if method_name == :should
+          end
+          fail 'No #should node is found!'
+        end
 
-        context 'when rspec-rails is loaded in the spec' do
-          include_context 'dynamic analysis objects'
+        let(:should_object) do
+          Should.new(should_node, source_rewriter, runtime_data)
+        end
+
+        subject { should_object.have_matcher.conversion_target? }
 
+        context 'when rspec-rails is loaded in the spec' do
           let(:source) do
             <<-END
               module RSpec
@@ -93,17 +104,17 @@ module Transpec
             END
           end
 
-          let(:have_object) { should_object.have_matcher }
+          context 'without runtime information' do
+            it { should be_true }
+          end
 
-          it 'does nothing' do
-            have_object.convert_to_standard_expectation!
-            rewritten_source.should == source
+          context 'with runtime information' do
+            include_context 'dynamic analysis objects'
+            it { should be_false }
           end
         end
 
         context 'when rspec-collection_matchers is loaded in the spec' do
-          include_context 'dynamic analysis objects'
-
           let(:source) do
             <<-END
               module RSpec
@@ -119,13 +130,23 @@ module Transpec
             END
           end
 
-          let(:have_object) { should_object.have_matcher }
+          context 'without runtime information' do
+            it { should be_true }
+          end
 
-          it 'does nothing' do
-            have_object.convert_to_standard_expectation!
-            rewritten_source.should == source
+          context 'with runtime information' do
+            include_context 'dynamic analysis objects'
+            it { should be_false }
           end
         end
+      end
+
+      describe '#convert_to_standard_expectation!' do
+        let(:record) { have_object.report.records.last }
+
+        before do
+          fail 'The #have_matcher is not a conversion target!' unless have_object.conversion_target?
+        end
 
         context 'with expression `collection.should have(2).items`' do
           let(:source) do

data/spec/transpec/syntax/its_spec.rb

@@ -11,14 +11,23 @@ module Transpec
 
       let(:record) { its_object.report.records.last }
 
-      describe '#convert_to_describe_subject_it!' do
-        before do
-          its_object.convert_to_describe_subject_it!
+      describe '#conversion_target?' do
+        let(:its_node) do
+          ast.each_descendent_node do |node|
+            next unless node.send_type?
+            method_name = node.children[1]
+            return node if method_name == :its
+          end
+          fail 'No #its node is found!'
         end
 
-        context 'when rspec-its is loaded in the spec' do
-          include_context 'dynamic analysis objects'
+        let(:its_object) do
+          Its.new(its_node, source_rewriter, runtime_data)
+        end
+
+        subject { its_object.conversion_target? }
 
+        context 'when rspec-its is loaded in the spec' do
           let(:source) do
             <<-END
               module RSpec
@@ -34,9 +43,20 @@ module Transpec
             END
           end
 
-          it 'does nothing' do
-            rewritten_source.should == source
+          context 'without runtime information' do
+            it { should be_true }
           end
+
+          context 'with runtime information' do
+            include_context 'dynamic analysis objects'
+            it { should be_false }
+          end
+        end
+      end
+
+      describe '#convert_to_describe_subject_it!' do
+        before do
+          its_object.convert_to_describe_subject_it!
         end
 
         context 'with expression `its(:size) { ... }`' do

data/spec/transpec/syntax/method_stub_spec.rb

@@ -684,12 +684,23 @@ module Transpec
               END
             end
 
-            it 'does nothing' do
-              rewritten_source.should == source
+            let(:expected_source) do
+              <<-END
+                describe 'example' do
+                  it 'does not respond to #foo' do
+                    allow(subject).to receive(:foo).and_call_original
+                  end
+                end
+              END
             end
 
-            it 'reports nothing' do
-              method_stub_object.report.records.should be_empty
+            it 'converts to `allow(subject).to receive(:method).and_call_original`' do
+              rewritten_source.should == expected_source
+            end
+
+            it "adds record `obj.#{method}(:message)` -> `allow(obj).to receive(:message).and_call_original`" do
+              record.original_syntax.should  == "obj.#{method}(:message)"
+              record.converted_syntax.should == 'allow(obj).to receive(:message).and_call_original'
             end
           end
         end
@@ -848,12 +859,24 @@ module Transpec
               END
             end
 
-            it 'does nothing' do
-              rewritten_source.should == source
+            let(:expected_source) do
+              <<-END
+                describe 'example' do
+                  it 'does not respond to #foo' do
+                    allow_any_instance_of(Klass).to receive(:foo).and_call_original
+                  end
+                end
+              END
             end
 
-            it 'reports nothing' do
-              method_stub_object.report.records.should be_empty
+            it 'converts to `allow(subject).to receive(:method).and_call_original`' do
+              rewritten_source.should == expected_source
+            end
+
+            it "adds record `Klass.any_instance.#{method}(:message)` " \
+               '-> `allow_any_instance_of(Klass).to receive(:message).and_call_original`' do
+              record.original_syntax.should  == "Klass.any_instance.#{method}(:message)"
+              record.converted_syntax.should == 'allow_any_instance_of(Klass).to receive(:message).and_call_original'
             end
           end
         end

data/spec/transpec/syntax/oneliner_should_spec.rb

@@ -112,97 +112,36 @@ module Transpec
       describe '#operator_matcher' do
         subject { should_object.operator_matcher }
 
-        context 'when it is taking operator matcher' do
-          let(:source) do
-            <<-END
-              describe 'example' do
-                it { should == 1 }
-              end
-            END
-          end
-
-          it 'returns an instance of Operator' do
-            should be_an(Operator)
-          end
+        let(:source) do
+          <<-END
+            describe 'example' do
+              it { should == 1 }
+            end
+          END
         end
 
-        context 'when it is taking non-operator matcher' do
-          let(:source) do
-            <<-END
-              describe 'example' do
-                it { should be_empty }
-              end
-            END
-          end
-
-          it 'returns nil' do
-            should be_nil
-          end
+        it 'returns an instance of Operator' do
+          should be_an(Operator)
         end
       end
 
       describe '#have_matcher' do
         subject { should_object.have_matcher }
 
-        context 'when it is taking #have matcher' do
-          let(:source) do
-            <<-END
-              describe 'example' do
-                it { should have(2).items }
-              end
-            END
-          end
-
-          it 'returns an instance of Have' do
-            should be_an(Have)
-          end
+        let(:source) do
+          <<-END
+            describe 'example' do
+              it { should have(2).items }
+            end
+          END
         end
 
-        context 'when it is taking operator matcher' do
-          let(:source) do
-            <<-END
-              describe 'example' do
-                it { should == 1 }
-              end
-            END
-          end
-
-          it 'returns nil' do
-            should be_nil
-          end
-        end
-
-        context 'when it is taking any other non-operator matcher' do
-          let(:source) do
-            <<-END
-              describe 'example' do
-                it { should be_empty }
-              end
-            END
-          end
-
-          it 'returns nil' do
-            should be_nil
-          end
+        it 'returns an instance of Have' do
+          should be_an(Have)
         end
       end
 
       describe '#expectize!' do
-        context 'when it has an operator matcher' do
-          let(:source) do
-            <<-END
-              describe 'example' do
-                it { should == 1 }
-              end
-            END
-          end
-
-          it 'invokes Operator#convert_operator!' do
-            should_object.operator_matcher.should_receive(:convert_operator!)
-            should_object.expectize!
-          end
-        end
-
         context 'with expression `it { should be true }`' do
           let(:source) do
             <<-END
@@ -244,71 +183,24 @@ module Transpec
           let(:expected_source) do
             <<-END
               describe 'example' do
-                it { is_expected.to eq(1) }
+                it { is_expected.to == 1 }
               end
             END
           end
 
-          it 'converts to `it { is_expected.to eq(1) }` form' do
+          it 'converts to `it { is_expected.to == 1 }` form' do
             should_object.expectize!
             rewritten_source.should == expected_source
           end
         end
       end
 
-      shared_examples 'does not convert if project requires have(n).items matcher' do
-        context 'when rspec-rails is loaded in the spec' do
-          include_context 'dynamic analysis objects'
-
-          let(:source) do
-            <<-END
-              module RSpec
-                module Rails
-                end
-              end
-
-              describe [:foo, :bar] do
-                it { should have(2).items }
-              end
-            END
-          end
-
-          it 'does nothing' do
-            rewritten_source.should == source
-          end
-        end
-
-        context 'when rspec-collection_matchers is loaded in the spec' do
-          include_context 'dynamic analysis objects'
-
-          let(:source) do
-            <<-END
-              module RSpec
-                module CollectionMatchers
-                end
-              end
-
-              describe [:foo, :bar] do
-                it { should have(2).items }
-              end
-            END
-          end
-
-          let(:have_object) { should_object.have_matcher }
-
-          it 'does nothing' do
-            rewritten_source.should == source
-          end
-        end
-      end
-
-      describe '#convert_have_items_to_standard_should!' do
+      describe '#convert_have_items_to_standard_should! and Have#convert_to_standard_expectation!' do
         before do
           should_object.convert_have_items_to_standard_should!
+          should_object.have_matcher.convert_to_standard_expectation!
         end
 
-        include_examples 'does not convert if project requires have(n).items matcher'
-
         context 'with expression `it { should have(2).items }`' do
           let(:source) do
             <<-END
@@ -632,13 +524,12 @@ module Transpec
         end
       end
 
-      describe '#convert_have_items_to_standard_expect!' do
+      describe '#convert_have_items_to_standard_expect! and Have#convert_to_standard_expectation!' do
         before do
           should_object.convert_have_items_to_standard_expect!
+          should_object.have_matcher.convert_to_standard_expectation!
         end
 
-        include_examples 'does not convert if project requires have(n).items matcher'
-
         context 'with expression `it { should have(2).items }`' do
           let(:source) do
             <<-END

data/spec/transpec/syntax/rspec_configure_spec.rb

@@ -9,6 +9,79 @@ module Transpec
       include_context 'parsed objects'
       include_context 'syntax object', RSpecConfigure, :rspec_configure
 
+      describe '#expose_dsl_globally=' do
+        before do
+          rspec_configure.expose_dsl_globally = value
+        end
+
+        let(:value) { true }
+
+        let(:source) do
+          <<-END
+            RSpec.configure do |config|
+              config.expose_dsl_globally = false
+            end
+          END
+        end
+
+        let(:expected_source) do
+          <<-END
+            RSpec.configure do |config|
+              config.expose_dsl_globally = true
+            end
+          END
+        end
+
+        it 'rewrites the `expose_dsl_globally` configuration' do
+          rewritten_source.should == expected_source
+        end
+
+        context 'when #expose_dsl_globally= does not exist' do
+          let(:source) do
+            <<-END
+              RSpec.configure do |config|
+              end
+            END
+          end
+
+          let(:expected_source) do
+            <<-END
+              RSpec.configure do |config|
+                config.expose_dsl_globally = true
+              end
+            END
+          end
+
+          it 'adds #expose_dsl_globally= statement' do
+            rewritten_source.should == expected_source
+          end
+        end
+
+        context 'when there are already some configurations' do
+          let(:source) do
+            <<-END
+              RSpec.configure do |config|
+                config.foo = 1
+              end
+            END
+          end
+
+          let(:expected_source) do
+            <<-END
+              RSpec.configure do |config|
+                config.foo = 1
+
+                config.expose_dsl_globally = true
+              end
+            END
+          end
+
+          it 'adds the block after a blank line' do
+            rewritten_source.should == expected_source
+          end
+        end
+      end
+
       shared_examples '#syntaxes' do |framework_block_method|
         describe '#syntaxes' do
           subject { super().syntaxes }
@@ -91,7 +164,7 @@ module Transpec
         end
       end
 
-      shared_examples '#syntaxes=' do |framework_block_method|
+      shared_examples '#syntaxes=' do |framework_block_method, block_arg_name|
         describe '#syntaxes=' do
           before do
             subject.syntaxes = syntaxes
@@ -183,8 +256,8 @@ module Transpec
             let(:expected_source) do
               <<-END
                 RSpec.configure do |config|
-                  config.#{framework_block_method} :rspec do |c|
-                    c.syntax = :expect
+                  config.#{framework_block_method} :rspec do |#{block_arg_name}|
+                    #{block_arg_name}.syntax = :expect
                   end
                 end
               END
@@ -211,8 +284,8 @@ module Transpec
                   RSpec.configure do |config|
                     config.foo = 1
 
-                    config.#{framework_block_method} :rspec do |c|
-                      c.syntax = :expect
+                    config.#{framework_block_method} :rspec do |#{block_arg_name}|
+                      #{block_arg_name}.syntax = :expect
                     end
                   end
                 END
@@ -230,14 +303,14 @@ module Transpec
         subject { rspec_configure.expectations }
 
         include_examples '#syntaxes', :expect_with
-        include_examples '#syntaxes=', :expect_with
+        include_examples '#syntaxes=', :expect_with, :expectations
       end
 
       describe '#mocks' do
         subject(:mocks) { rspec_configure.mocks }
 
         include_examples '#syntaxes', :mock_with
-        include_examples '#syntaxes=', :mock_with
+        include_examples '#syntaxes=', :mock_with, :mocks
 
         describe '#yield_receiver_to_any_instance_implementation_blocks=' do
           before do
@@ -332,8 +405,8 @@ module Transpec
             let(:expected_source) do
               <<-END
                 RSpec.configure do |config|
-                  config.mock_with :rspec do |c|
-                    c.yield_receiver_to_any_instance_implementation_blocks = true
+                  config.mock_with :rspec do |mocks|
+                    mocks.yield_receiver_to_any_instance_implementation_blocks = true
                   end
                 end
               END
@@ -344,31 +417,61 @@ module Transpec
               rewritten_source.should == expected_source
             end
 
-            context "when RSpec.configure's argument variable name is `rspec`" do
+            context "when RSpec.configure's block argument name is `mocks`" do
               let(:source) do
                 <<-END
-                  RSpec.configure do |rspec|
+                  RSpec.configure do |mocks|
                   end
                 END
               end
 
               let(:expected_source) do
                 <<-END
-                  RSpec.configure do |rspec|
-                    rspec.mock_with :rspec do |mocks|
-                      mocks.yield_receiver_to_any_instance_implementation_blocks = true
+                  RSpec.configure do |mocks|
+                    mocks.mock_with :rspec do |config|
+                      config.yield_receiver_to_any_instance_implementation_blocks = true
                     end
                   end
                 END
               end
 
-              it 'defines #mock_with block argument name as `mocks`' do
+              it 'defines #mock_with block argument name as `config`' do
                 rewritten_source.should == expected_source
               end
             end
           end
         end
       end
+
+      context 'when multiple configurations are added' do
+        before do
+          rspec_configure.expose_dsl_globally = true
+          rspec_configure.mocks.yield_receiver_to_any_instance_implementation_blocks = false
+        end
+
+        let(:source) do
+          <<-END
+            RSpec.configure do |config|
+            end
+          END
+        end
+
+        let(:expected_source) do
+          <<-END
+            RSpec.configure do |config|
+              config.expose_dsl_globally = true
+
+              config.mock_with :rspec do |mocks|
+                mocks.yield_receiver_to_any_instance_implementation_blocks = false
+              end
+            end
+          END
+        end
+
+        it 'adds them properly' do
+          rewritten_source.should == expected_source
+        end
+      end
     end
   end
 end