transpec 1.10.3 → 1.10.4

data/spec/transpec/syntax/current_example_spec.rb

@@ -11,6 +11,79 @@ module Transpec
 
       let(:record) { current_example_object.report.records.last }
 
+      describe '#conversion_target?' do
+        let(:target_node) do
+          ast.each_descendent_node do |node|
+            next unless node.send_type?
+            method_name = node.children[1]
+            next unless method_name == :example
+            return node
+          end
+          fail 'No #example node is found!'
+        end
+
+        let(:current_example_object) do
+          CurrentExample.new(target_node, source_rewriter, runtime_data)
+        end
+
+        subject { current_example_object.conversion_target? }
+
+        context 'with #example node that returns current example object' do
+          let(:source) do
+            <<-END
+              describe 'example' do
+                after do
+                  do_something if example.metadata[:foo]
+                end
+              end
+            END
+          end
+
+          it { should be_true }
+        end
+
+        context 'when #example node that defines a spec example is passed' do
+          let(:source) do
+            <<-END
+              describe 'example' do
+                example 'it does something' do
+                  do_something
+                end
+              end
+            END
+          end
+
+          it { should be_false }
+        end
+
+        context 'when #example node defined with #let by user is passed' do
+          let(:source) do
+            <<-END
+              describe 'example' do
+                let(:example) { 'This is not current example object' }
+
+                it 'does something' do
+                  example
+                end
+              end
+            END
+          end
+
+          it 'unfortunately returns true ' \
+             "since it's impossible to differentiate them without runtime information" do
+            should be_true
+          end
+
+          context 'with runtime information' do
+            include_context 'dynamic analysis objects'
+
+            it 'returns false properly' do
+              should be_false
+            end
+          end
+        end
+      end
+
       describe '#convert!' do
         before do
           current_example_object.convert! unless example.metadata[:no_auto_convert]
@@ -159,9 +232,8 @@ module Transpec
 
           let(:current_example_objects) do
             ast.each_node.reduce([]) do |objects, node|
-              if CurrentExample.conversion_target_node?(node)
-                objects << CurrentExample.new(node, source_rewriter, runtime_data)
-              end
+              current_example_object = CurrentExample.new(node, source_rewriter, runtime_data)
+              objects << current_example_object if current_example_object.conversion_target?
               objects
             end
           end
@@ -199,22 +271,6 @@ module Transpec
           end
         end
 
-        context "with expression `example 'it does something' do do_something end`", :no_auto_convert do
-          let(:source) do
-            <<-END
-              describe 'example' do
-                example 'it does something' do
-                  do_something
-                end
-              end
-            END
-          end
-
-          it 'does nothing' do
-            rewritten_source.should == source
-          end
-        end
-
         context 'with expression `def helper_method example; end`' do
           let(:source) do
             <<-END

data/spec/transpec/syntax/double_spec.rb

@@ -9,8 +9,8 @@ module Transpec
       include_context 'parsed objects'
       include_context 'syntax object', Double, :double_object
 
-      describe '.conversion_target_node?' do
-        let(:send_node) do
+      describe '#conversion_target?' do
+        let(:target_node) do
           ast.each_descendent_node do |node|
             next unless node.send_type?
             method_name = node.children[1]
@@ -20,6 +20,12 @@ module Transpec
           fail 'No #double node is found!'
         end
 
+        let(:double_object) do
+          Double.new(target_node, source_rewriter, runtime_data)
+        end
+
+        subject { double_object.conversion_target? }
+
         context 'when #double node is passed' do
           let(:source) do
             <<-END
@@ -32,9 +38,7 @@ module Transpec
             END
           end
 
-          it 'returns true' do
-            Double.conversion_target_node?(send_node).should be_true
-          end
+          it { should be_true }
         end
 
         context 'with runtime information' do
@@ -52,9 +56,7 @@ module Transpec
               END
             end
 
-            it 'returns true' do
-              Double.conversion_target_node?(send_node).should be_true
-            end
+            it { should be_true }
           end
 
           context 'when another #double node is passed' do
@@ -87,9 +89,7 @@ module Transpec
               END
             end
 
-            it 'returns false' do
-              Double.conversion_target_node?(send_node, runtime_data).should be_false
-            end
+            it { should be_false }
           end
         end
       end

data/spec/transpec/syntax/example_spec.rb

@@ -13,10 +13,8 @@ module Transpec
 
       let(:record) { example_object.report.records.last }
 
-      describe '.conversion_target_node?' do
-        subject { Example.conversion_target_node?(pending_node, runtime_data) }
-
-        let(:pending_node) do
+      describe '#conversion_target?' do
+        let(:target_node) do
           ast.each_descendent_node do |node|
             next unless node.send_type?
             method_name = node.children[1]
@@ -25,6 +23,12 @@ module Transpec
           fail 'No #pending node is found!'
         end
 
+        let(:example_object) do
+          Example.new(target_node, source_rewriter, runtime_data)
+        end
+
+        subject { example_object.conversion_target? }
+
         context 'when #pending example node is passed' do
           let(:source) do
             <<-END

data/spec/transpec/syntax/have_spec.rb

@@ -1141,7 +1141,7 @@ module Transpec
 
           let(:have_object) { expect_object.have_matcher }
 
-          fit "converts to `expect(hash['some_key'].size).to eq(2)` form" do
+          it "converts to `expect(hash['some_key'].size).to eq(2)` form" do
             have_object.convert_to_standard_expectation!
             rewritten_source.should == expected_source
           end

data/spec/transpec/syntax/method_stub_spec.rb

@@ -12,8 +12,8 @@ module Transpec
 
       let(:record) { method_stub_object.report.records.first }
 
-      describe '.conversion_target_node?' do
-        let(:send_node) do
+      describe '#conversion_target?' do
+        let(:target_node) do
           ast.each_descendent_node do |node|
             next unless node.send_type?
             method_name = node.children[1]
@@ -23,6 +23,12 @@ module Transpec
           fail 'No #stub node is found!'
         end
 
+        let(:method_stub_object) do
+          MethodStub.new(target_node, source_rewriter, runtime_data)
+        end
+
+        subject { method_stub_object.conversion_target? }
+
         context 'when #stub node is passed' do
           let(:source) do
             <<-END
@@ -34,9 +40,7 @@ module Transpec
             END
           end
 
-          it 'returns true' do
-            MethodStub.conversion_target_node?(send_node).should be_true
-          end
+          it { should be_true }
         end
 
         context 'when Factory.stub node is passed' do
@@ -50,9 +54,7 @@ module Transpec
             END
           end
 
-          it 'returns false' do
-            MethodStub.conversion_target_node?(send_node).should be_false
-          end
+          it { should be_false }
         end
 
         context 'with runtime information' do
@@ -69,9 +71,7 @@ module Transpec
               END
             end
 
-            it 'returns true' do
-              MethodStub.conversion_target_node?(send_node, runtime_data).should be_true
-            end
+            it { should be_true }
           end
 
           context 'when another #stub node is passed' do
@@ -90,9 +90,7 @@ module Transpec
               END
             end
 
-            it 'returns false' do
-              MethodStub.conversion_target_node?(send_node, runtime_data).should be_false
-            end
+            it { should be_false }
           end
 
           context "when Factory.stub node is passed and it's RSpec's #stub" do
@@ -109,9 +107,7 @@ module Transpec
               END
             end
 
-            it 'returns true' do
-              MethodStub.conversion_target_node?(send_node, runtime_data).should be_true
-            end
+            it { should be_true }
           end
 
           context 'when Factory.stub node is passed and it has not been run' do
@@ -128,9 +124,7 @@ module Transpec
               END
             end
 
-            it 'returns false' do
-              MethodStub.conversion_target_node?(send_node, runtime_data).should be_false
-            end
+            it { should be_false }
           end
         end
       end

data/spec/transpec/syntax/oneliner_should_spec.rb

@@ -11,6 +11,57 @@ module Transpec
 
       let(:record) { should_object.report.records.first }
 
+      describe '#conversion_target?' do
+        let(:target_node) do
+          ast.each_descendent_node do |node|
+            next unless node.send_type?
+            method_name = node.children[1]
+            next unless method_name == :should
+            return node
+          end
+          fail 'No #should node is found!'
+        end
+
+        let(:should_object) do
+          OnelinerShould.new(target_node, source_rewriter, runtime_data)
+        end
+
+        subject { should_object.conversion_target? }
+
+        context 'when one-liner #should node is passed' do
+          let(:source) do
+            <<-END
+              describe 'example' do
+                subject { 1 }
+                it { should == 1 }
+              end
+            END
+          end
+
+          it { should be_true }
+
+          context 'with runtime information' do
+            include_context 'dynamic analysis objects'
+            it { should be_true }
+          end
+        end
+
+        context 'when monkey-patched #should node is passed' do
+          let(:source) do
+            <<-END
+              describe 'example' do
+                subject { 1 }
+                it 'is 1' do
+                  subject.should == 1
+                end
+              end
+            END
+          end
+
+          it { should be_false }
+        end
+      end
+
       describe '#matcher_node' do
         context 'when it is taking operator matcher' do
           let(:source) do

data/spec/transpec/syntax/pending_spec.rb

@@ -11,10 +11,8 @@ module Transpec
 
       let(:record) { pending_object.report.records.last }
 
-      describe '.conversion_target_node?' do
-        subject { Pending.conversion_target_node?(pending_node, runtime_data) }
-
-        let(:pending_node) do
+      describe '#conversion_target?' do
+        let(:target_node) do
           ast.each_descendent_node do |node|
             next unless node.send_type?
             method_name = node.children[1]
@@ -23,6 +21,12 @@ module Transpec
           fail 'No #pending node is found!'
         end
 
+        let(:pending_object) do
+          Pending.new(target_node, source_rewriter, runtime_data)
+        end
+
+        subject { pending_object.conversion_target? }
+
         context 'when #pending specification node inside of an example is passed' do
           let(:source) do
             <<-END

data/spec/transpec_spec.rb

@@ -4,13 +4,11 @@ require 'spec_helper'
 require 'transpec'
 
 module Transpec
-  [:required_rspec_version, :current_rspec_version].each do |method|
-    describe ".#{method}" do
-      subject { Transpec.send(method) }
+  describe '.required_rspec_version' do
+    subject { Transpec.required_rspec_version }
 
-      it 'returns an instance of RSpecVersion' do
-        should be_a(RSpecVersion)
-      end
+    it 'returns an instance of RSpecVersion' do
+      should be_a(RSpecVersion)
     end
   end
 end

data/tasks/demo.rake

@@ -11,11 +11,11 @@ namespace :demo do
   ]
   # rubocop:enable LineLength
 
-  desc 'Publish conversion example on all projects'
+  desc 'Publish conversion examples of all projects'
   task all: demos.map(&:name)
 
   demos.each do |demo|
-    desc "Publish conversion example on #{demo.name} project"
+    desc "Publish conversion example of #{demo.name} project"
     task demo.name do
       demo.run
     end

data/tasks/lib/transpec_demo.rb

@@ -12,7 +12,7 @@ class TranspecDemo < TranspecTest
   def run
     require 'transpec'
 
-    puts " Running demo on #{name} project ".center(80, '=')
+    puts " Publishing conversion example of #{name} project ".center(80, '=')
 
     prepare_project
     run_demo

data/tasks/lib/transpec_test.rb

@@ -36,7 +36,7 @@ class TranspecTest
 
   def run
     require 'transpec'
-    puts " Testing on #{name} project ".center(80, '=')
+    puts " Testing transpec on #{name} project ".center(80, '=')
     prepare_project
     run_test(%w(--force))
   end

data/tasks/test.rake

@@ -23,11 +23,11 @@ namespace :test do
   end
   # rubocop:enable LineLength
 
-  desc 'Test Transpec on all projects'
+  desc 'Test transpec on all projects'
   task all: tests.map(&:name)
 
   tests.each do |test|
-    desc "Test Transpec on #{test.name} project"
+    desc "Test transpec on #{test.name} project"
     task test.name do
       test.run
     end